[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #24 from David Cook --- (In reply to Katrin Fischer from comment #0) > For the ISBN we have the option to activate search with and without hyphens > - but this doesn't work for ISSN. We shoudl make it work there as well. Curious about this one... Since Zebra normalizes the data by stripping out hyphens, it shouldn't be relevant for Zebra? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30851] Improve performance of request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30851 --- Comment #1 from Nick Clemens --- Created attachment 135357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135357=edit Bug 30851: Return rights info from CanItemBeReserved Rather than fath holds rules outside of the routine, let's return the ones we already calculated. There is precedent to return some rules in some instances, this just expands that -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30851] New: Improve performance of request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30851 Bug ID: 30851 Summary: Improve performance of request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #9 from David Cook --- (In reply to Andreas Jonsson from comment #8) > Would it be too risky to send a HUP-signal to the plack process > automatically when a plugin is reuploaded? > > I think that this would be very nice, as it would make plugins upgradable > without command line access. You know... I've been thinking about that idea for years but I never actually tried it. I just tried it now and it worked well! With the Debian packages, each instance is run using a specific Linux user, and it looks like that Linux user can HUP processes it owns, so yeah... it works. -- In terms of risk, I suppose allowing a web user to affect background Linux processes is not ideal. I have noticed that the REST API can be slow to startup and can consume a lot of CPU, so I suppose the risk would be that an accident or an attack could lead to a denial of service. But I think that's a fairly low risk. After all, you can already do a DDOS by attacking the OPAC search function. So I think the risk is worth the reward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30840] Add support for barcode filters to course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30840 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #11 from David Cook --- (In reply to Marcel de Rooy from comment #9) > (In reply to David Cook from comment #5) > > > This looks like a hack. We should pass the code in via a public > > method/function. That said, it looks like this OTP will wind up in the > > message_queue table? > > How vulnerable is that? Surely, the token will be expired very quickly but > can we get back to the originating secret? And that said, would an attack on > the email not have a higher chance of success ? > > https://security.stackexchange.com/questions/42671/is-oath-totp-and-or- > google-authenticator-vulnerable-if-an-attacker-has-n-pre I'm not an expert on the topic, but in theory you could try an offline brute force attack that could potentially reveal the secret eventually, although I imagine we're using complex enough secrets that it would probably be computationally improbable at this time. Technically, I suppose we could encrypt the email contents at rest (like https://docs.aws.amazon.com/sns/latest/dg/sns-server-side-encryption.html), but I think the risk is small enough that can be a future enhancement... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #10 from David Cook --- (In reply to Jonathan Druart from comment #7) > Well, the description was clear enough and the bug has been flagged as > sponsored. I don't think it's fair to ask for a rewrite once the code has > been written. In that case, I should mark more bugs as sponsored heh. (In reply to Jonathan Druart from comment #8) > > Yes, that's a bug. I was pretty sure it was allowing at least 1 old code. > > It's in the POD of ->verify, and members/two_factor_auth.pl, but C4/Auth.pm > > Fixed on bug 30842. Between bug 30842 and bug 30843, that might be enough to cover off the delivery delay of email. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30842] Two-factor authentication code should be valid longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30842 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30843] TOTP expiration delay should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #6 from David Cook --- (In reply to Martin Renvoize from comment #4) > We had customers starting to notice this, so I've taken a pragmatic approach > here for now.. > > I think this all needs a little more thought as to what level it should all > sit at as fetching and processing the MARC data twice is a bit silly. I don't like it but I do see the pragmatism... Yet, if we do this, I don't think we'll ever fix the performance of get_marc_notes() :/. Would a compromise be to add a "record" parameter to "get_marc_notes", and just update the call in opac/opac-detail.pl for now (we could open other tickets for the other Perl scripts)? That would fix Bug 30744 without duplicating processing and with less code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603 --- Comment #8 from David Cook --- Btw, this looks like it's needed in 20.11 and 21.11 at least as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #7 from David Cook --- *** Bug 30841 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30841] Responsiveness not working for some screen sizes on OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30841 David Cook changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from David Cook --- *** This bug has been marked as a duplicate of bug 29603 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 135356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135356=edit Bug 30850: Add default mapping for biblio.author to 110$a (MARC21) This patch adds a mapping to biblio.author in 110$a in the default framework Note: I added lots of tests for different scenarios, I'm not sure it's necessary to test everything. I don't want this to be a deterrent! The first one is necessary, the rest are use cases. Note 2: I don't work with ktd so maybe the steps for loading new frameworks are different, sorry about that, I honestly don't know another way to do it. Test 1 - basic test Before applying patch, 1- Create a new record with a corporate author (110$a) 2- Query the database, author should be null select author from biblio where biblionumber = ; (do other control tests if you want/need before applying the patch) 3- Apply patch 4- Delete frameworks delete from biblio_framework; delete from marc_subfield_structure; delete from marc_tag_structure; 5- Load new frameworks ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 6- Edit the record, don't change anything and save it 7- Query the database, author should be filled 8- Go to Administration > MARC Bibliographic framework test, everything should be OK Test 2 - checkouts table Before applying patch, 1- Create a new record and item with a corporate author (110$a) 2- Checkout the item for that record to a patron Note that the author is not listed in the checkouts table 3- Apply patch 4- Delete frameworks delete from biblio_framework; delete from marc_subfield_structure; delete from marc_tag_structure; 5- Load new frameworks ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 6- Edit the record, don't change anything and save it 7- Refresh the checkouts table, the author should be listed Test 3 - notices and slips Before applying patch, 1- Go to Tools > Notices & slips 2- Edit ISSUESLIP and add <> after <> 3- Save the notice 4- Create a new record and item with a corporate author (110$a) 5- Checkout the item for that record to a patron 6- Print the checkout slip Note that the author is not listed on the slip 7- Apply patch 8- Delete frameworks delete from biblio_framework; delete from marc_subfield_structure; delete from marc_tag_structure; 9- Load new frameworks ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 10- Edit the record, don't change anything and save it 11- Print the checkout slip, the author should be listed Test 4 - labels Before applying the patch, 1- Create a new record and item with a corporate author (110$a) 2- Go to Tools > Label Creator 3- Create a label batch with that item 4- Export the batch in PDF using the Avery 5160 template and 'Label test' layout Note that the author is not listed 5- Apply patch 6- Delete frameworks delete from biblio_framework; delete from marc_subfield_structure; delete from marc_tag_structure; 7- Load new frameworks ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 8- Edit the record, don't change anything and save it 9- Export the label batch again, the author should be listed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30850] New: Add default mapping for biblio.author to 110$a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850 Bug ID: 30850 Summary: Add default mapping for biblio.author to 110$a (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently, biblio.author is only linked to 100$a, which is fine in most cases. But some records have a corporate author (110$a) and those authors don't appear anywhere where the author usually appears (checkout table, letters, labels, etc.) I propose we add a default mapping from 110$a to biblio.author. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 --- Comment #5 from Martin Renvoize --- I can rename it tomorrow too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 --- Comment #4 from Martin Renvoize --- Unit tests to come.. it hit end of day here so they'll be a tomorrow job now.. Works beautifully in bug 30744 though ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #6 from Owen Leonard --- Created attachment 135355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135355=edit Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added Attachment #135339|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 135354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135354=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848
Martin Renvoize changed:
What|Removed |Added
Attachment #135338|0 |1
is obsolete||
--- Comment #3 from Martin Renvoize ---
Created attachment 135353
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135353=edit
Bug 30848: Add an AuthorizedValues RecordProcessor filter
This patch introduces a RecordProcessor filter for MARC::Record objects
that replaces AV codes with AC descriptions in the MARC::Record passed to the
processor.
Target usage:
my $biblio = Koha::Biblios->find(
$biblio_id,
{ prefetch => [ metadata ] }
);
my $record = $biblio->metadata->record;
my $processor = Koha::RecordProcessor->new(
{
filters => ('AuthorizedValues'),
options => {
interface => 'opac',
frameworkcode => $biblio->frameworkcode
}
}
);
$processor->process( $record );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #35 from Tomás Cohen Arazi --- (In reply to David Nind from comment #30) > Hi Tomás. > > I have tested this, and it all works fine except for these two things: > > 1. Test fails for prove t/db_dependent/Koha/Hold.t Fixed! > 2. I'm not sure of the workflow in the staff interface or the reason why > there is a "Reject cancellation" option > ~~~ > > If I: > > 1. Request cancellation in the OPAC (Request cancellation button) it changes > to a non-clickable button (Cancellation requested). > > 2. Reject cancellation in the staff interface (Holds awaiting pickup > Holds > with cancellation requests tab, and select "Reject cancellation". > > The result is: > - In OPAC the button for the hold changes to "Cancellation rejected" > (non-clickable) > - In the staff interface it goes back into the "Holds waiting" tab > - I have to click "Cancel hold", then it is removed from the OPAC and holds > awaiting pickup > Holds waiting tab Yes, I agree this is a bit weird. I tried to submit this as early as possible to get some feedback. I'm not sure this moderation step is required. The original proposal was to just have a way to let the librarian know the user requested cancellation. I can remove the whole 'cancellation request status' thing. The main reasoning was that it was not clear to me how should cancellation requests count towards max reserves and friends (until they actually get acknowledged). We could just mark them as cancelled, actually. But just mark them as user-cancelled... I'm open to ideas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 135349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135349=edit Bug 22456: Add cancellation request methods to Koha::Hold This patch adds the following helper methods for dealing with hold cancellation requests to the Koha::Hold class: * cancellation_requests * add_cancellation_request * cancellation_requestable_from_opac * cancellation_requested_by_owner To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 135352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135352=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 135351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135351=edit Bug 22456: Add Koha::Holds->filter_by_has_pending_cancellation_requests This patch adds that method. Which is covered by new tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 135350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135350=edit Bug 22456: Allow requesting cancellation from the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135326|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135325|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135324|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135323|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30843] TOTP expiration delay should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 --- Comment #2 from Tomás Cohen Arazi --- I would call it something like ExpandAuthorizedValues. We just need some tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30849] New: Make pending patron modification notices on staff main page number of modifications at logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Bug ID: 30849 Summary: Make pending patron modification notices on staff main page number of modifications at logged in branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com On the staff main page pending suggestions show some like: Suggestions pending approval: Centerville: 2 / All libraries: 100 It would be nice if we could do the same thing with pending patron modifications Patrons requesting modifications: Centerville: 2 / All libraries: 100 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #10 from Nick Clemens --- Largely these changes should be small enough to read code for approval To test: 1 - Apply patch 2 - Confirm placing holds on OPAC works 3 - Confirm patron blocked when: marked 'gone no address' marked 'lost' has a restriction is expired and expired patrons are blocked has outstanding fines above maxoutstanding has too many holds (more than maxreserves) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #9 from Nick Clemens --- Created attachment 135348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135348=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot This wil save us fetching more info if we are denying the holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #8 from Nick Clemens --- Created attachment 135347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135347=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the hash is the rank and title We can si9mply fetch the biblio once to calculate no need to fetch all the info as we don't display or use it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #7 from Nick Clemens --- Created attachment 135346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135346=edit Bug 30847: Don't declrae undef variable for assignment New holds have found set to undef - we can do this directly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #6 from Nick Clemens --- Created attachment 135345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135345=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to the biblionumber passed in or it is not and should be - we can just assign directly from the item in all cases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #5 from Nick Clemens --- Created attachment 135344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135344=edit Bug 30847: Remove %itemInfoHash This is not used git grep itemInfoHash only 2 occurences - definition and population - never used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #4 from Nick Clemens --- Created attachment 135343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135343=edit Bug 30847: Don't fetch patron twice We already have a patron objetc, no need to fetch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #3 from Nick Clemens --- Created attachment 135342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135342=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they aren't used! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #2 from Nick Clemens --- Created attachment 135341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135341=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test: 1 - git grep noreserve 2 - only one ocurrence 3 - Apply patch 4 - repeat, no ocurrence 5 - Note the plural has a few uses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #1 from Nick Clemens --- Created attachment 135340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135340=edit Bug 30847: Cleanup calculation of holds and rank Currently we loop over all the holds on the record to get a count of the reserves not waiting and a rank for the upcoming hold We can simply count the number of nont waiting holds and add 1 Note: Before this patch the count of holds included the new hold we were going to place which meant rank and count were the same. I believe countaing existing holds and our upcoming rank is the correct behavior To test: 1 - Set OPACShowHoldQueueDetails system preference to 'Show holds and their priorty level' 2 - Place a few holds on a bib on the staff side 3 - Mark 1 waiting 4 - Attempt to place hold on the bib on the opac 5 - Note 'Your priority' and 'Number of holds' are the same number 6 - Place another hold, confirm both increase 7 - Set another hold waiting, confirm both decrease 8 - Apply patch 9 - Confirm 'Your priority' is now 1 greater than Number of holds 10 - Place a hold, set a hold waiting, confirm numbers adjust as appropriate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #4 from Martin Renvoize --- We had customers starting to notice this, so I've taken a pragmatic approach here for now.. I think this all needs a little more thought as to what level it should all sit at as fetching and processing the MARC data twice is a bit silly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added Assignee|alei...@catalyst.net.nz |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #3 from Martin Renvoize --- Created attachment 135339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135339=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Martin Renvoize changed: What|Removed |Added Blocks||30744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 [Bug 30744] Non-public note is visible in OPAC in Title Notes tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added Depends on||30848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 [Bug 30848] Introduce Koha::Filter::AuthorizedValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848
--- Comment #1 from Martin Renvoize ---
Created attachment 135338
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135338=edit
Bug 30848: Add an AuthorizedValues RecordProcessor filter
This patch introduces a RecordProcessor filter for MARC::Record objects
that replaces AV codes with AC descriptions in the MARC::Record passed to the
processor.
Target usage:
my $biblio = Koha::Biblios->find(
$biblio_id,
{ prefetch => [ metadata ] }
);
my $record = $biblio->metadata->record;
my $processor = Koha::RecordProcessor->new(
{
filters => ('AuthorizedValues'),
options => {
interface => 'opac',
frameworkcode => $biblio->frameworkcode
}
}
);
$processor->process( $record );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] New: Introduce Koha::Filter::AuthorizedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Bug ID: 30848 Summary: Introduce Koha::Filter::AuthorizedValues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org I think we should introduce a Koha::Filter for replacing AV codes with AV values in the MARC::Record.. we already do this using C4::XSLT::transformMARCXML4XSLT but I believe a RecordProcessor makes more sense than to hide the function away in the defunct XSLT module. We can then use this anywhere we have a RecordProcessor instantiated and get the goodness of filtered MARC::Records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #32 from Martin Renvoize ---
Comment on attachment 134069
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134069
Bug 29697: Use flag embed_items
Review of attachment 134069:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=29697=134069)
-
This is a great start, but I think we can golf this between us next cycle and
come up with something considerably cleaner working towards efficiency
::: Koha/Biblio/Metadata.pm
@@ +65,5 @@
> +biblionumber => $biblionumber,
> +itemnumbers => $itemnumbers,
> +opac => $opac
> +}
> +);
I think I'd rather see a distinct ->filtered_record() method as opposed to
adding filtering functionality into the existing method..?
@@ +67,5 @@
> +opac => $opac
> +}
> +);
> +
> +Given a MARC::Record object containing a bib record,
You've made this a class method as well as an object method now I see.. the POD
isn't entirely clear though.. we can work on that.
@@ +72,5 @@
> +modify it to include the items attached to it as 9XX
> +per the bib's MARC framework.
> +if $itemnumbers is defined, only specified itemnumbers are embedded.
> +
> +If $opac is true, then opac-relevant suppressions are included.
Actually.. as far as I can tell.. you're only doing OPAC filtering on the
embedded items.. I'd love to have seem RecordProcessor used here and the actual
record to get fully filtered using the framework display stuff..
@@ +170,5 @@
> +for my $itemnumber ( @itemnumbers ) {
> +my $item_marc = C4::Items::GetMarcItem( $biblionumber,
> $itemnumber );
> +push @item_fields, $item_marc->field($itemtag);
> +}
> +$record->append_fields(@item_fields);
We should use Koha::Filter::EmbedItems here.. this is exactly what it was
designed for I reckon.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] New: Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Bug ID: 30847 Summary: Cleanup opac-reserve.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #31 from Jonathan Druart --- (In reply to Martin Renvoize from comment #30) > I get sha1 issues trying to apply this.. more than happy to use gitlab > branches if that's easier ? https://gitlab.com/joubu/Koha/-/commits/bug_29697 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #30 from Martin Renvoize --- I get sha1 issues trying to apply this.. more than happy to use gitlab branches if that's easier ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30846] Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Nick Clemens changed: What|Removed |Added Blocks||30845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 [Bug 30845] OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Nick Clemens changed: What|Removed |Added Blocks||30845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 [Bug 30845] OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Nick Clemens changed: What|Removed |Added Blocks||30845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 [Bug 30845] OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30845] OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Nick Clemens changed: What|Removed |Added Depends on||25408, 20985, 30846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 [Bug 30846] Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30846] New: Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Bug ID: 30846 Summary: Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30845] New: OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Bug ID: 30845 Summary: OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com We have a number of holds checks: not for loan opacitemholds OPACHoldsIfAvailableAtPickup which are only checked in the script, and not our modules The api uses CanBook/CanItem BeReserved for checking validity of holds and is missing these checks We need to move the checks and cover them with unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Martin Renvoize changed: What|Removed |Added Blocks||30744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 [Bug 30744] Non-public note is visible in OPAC in Title Notes tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on||29871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #9 from Marcel de Rooy --- (In reply to David Cook from comment #5) > This looks like a hack. We should pass the code in via a public > method/function. That said, it looks like this OTP will wind up in the > message_queue table? How vulnerable is that? Surely, the token will be expired very quickly but can we get back to the originating secret? And that said, would an attack on the email not have a higher chance of success ? https://security.stackexchange.com/questions/42671/is-oath-totp-and-or-google-authenticator-vulnerable-if-an-attacker-has-n-pre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29652 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29441 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Martin Renvoize changed: What|Removed |Added Blocks||29652 Depends on|29652 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on||29871 Blocks|29871 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30844] The OPAC detail page's browser is limited to the current page of results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30844 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |kevin.car...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Patch doesn't apply |Signed Off --- Comment #5 from Martin Renvoize --- Trivial and sensible fix.. Straight QAing.. Passed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Martin Renvoize changed: What|Removed |Added Attachment #129379|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 135337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135337=edit Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes Test plan : Display a biblio record with some MARC notes in details page and basket, OPAC and staff Run prove t/db_dependent/Koha/Biblio.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30842] Two-factor authentication code should be valid longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30842 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30844] The OPAC detail page's browser is limited to the current page of results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30844 --- Comment #1 from Kevin Carnes --- Created attachment 135336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135336=edit Bug 30844: The OPAC detail page's browser is limited to the current page of results when using Elasticsearch When viewing the detail page of the first or last record of a result page, it's not possible to browse to another page when using Elasticsearch. To test: 1) Search for "*" in the OPAC 2) Click on the last result of the page 3) Observe that you cannot browse to the next page 4) Apply the patch 5) Search for "*" in the OPAC 6) Click on the last result of the page 7) Observe that you can browse to the next page 8) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30844] The OPAC detail page's browser is limited to the current page of results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30844 Kevin Carnes changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30844] New: The OPAC detail page's browser is limited to the current page of results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30844 Bug ID: 30844 Summary: The OPAC detail page's browser is limited to the current page of results when using Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: kevin.car...@ub.lu.se QA Contact: testo...@bugs.koha-community.org When viewing the detail page of the first or last record of a result page, it's not possible to browse to another page when using Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30841] Responsiveness not working for some screen sizes on OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30841 Owen Leonard changed: What|Removed |Added Severity|critical|major --- Comment #5 from Owen Leonard --- This sounds like Bug 29603. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20608] Elasticsearch - relevancy weights proposition for unimarc in mappings.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20608 Nicolas Legrand changed: What|Removed |Added CC||nicolas.legr...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 --- Comment #33 from Kevin Carnes --- To test: 1) Configure Koha to use ES 6.8 2) Make sure that Search::Elasticsearch@6.80 is installed 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Apply patch 5) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 6) Make sure that all the tests pass 7) Configure Koha to use ES 7 8) Make sure that Search::Elasticsearch has the same version as ES 9) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 10) Apply patch 11) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 12) Make sure that all the tests pass 13) Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #14 from Martin Renvoize --- I worked on an alternative commit message for that last patch to clarify the intent as I think it got a little lost. >This patch changes the signature of Koha::Item->holds_control_library to >accept a hashref with patron_id and patron as keys. The patron key >should contain a reference to a variable that may or may not already >contain a Koha::Patron object. In the case where a Koha::Patron object >is required and the patron reference does not yet contain such an object >the method will fetch the patron using the patron_id passed and populate >the reference so that future calls can now use the populated object instead >of having to fetch it themselves too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #13 from Martin Renvoize --- (In reply to Tomás Cohen Arazi from comment #12) > (In reply to Martin Renvoize from comment #11) > > Created attachment 135281 [details] [review] [review] > > Bug 30825: Pass by reference > > > > Not sure if this is nicer or not honestly. This changes the signature of > > hols_control_library to accept a hashref of patron_id and patron object > > reference. If the patron_object reference is found to be undefined and > > our syspref requires it we populate the reference with a Koha::Patron > > object as found from the patron_id. > > I have the feeling this particular case would do better with just the > patron_id. If we have it, good. If we have it via a Koha::Patron object, > then $patron->id would be pretty clear to read. That goes the other way and introduces extra DB fetches I'd say we either go for passing Patron objects and ensure the caller always has that.. or we pass references so we can delay fetching.. I wouldn't go back and just pass ID's personally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Kevin Carnes changed: What|Removed |Added Attachment #131484|0 |1 is obsolete|| --- Comment #32 from Kevin Carnes --- Created attachment 135335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135335=edit Bug 25669: [alternate] Use include_type_name parameter in ES calls (small fixes) Bulk doesn't support include_type_name, update requirement to Search::Elasticseach@6.80, and remove data type name from tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Kevin Carnes changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25126] MARC visibility settings not obeyed on cart normal and detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25126 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 --- Comment #10 from Kevin Carnes --- (In reply to Fridolin Somers from comment #8) > In my opinion this code looks better (if it fixes the same way) : > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30141#c1 Ok, it now uses that code and has a simple test to make sure that the query looks correct, but doesn't actually test searching. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 Kevin Carnes changed: What|Removed |Added Attachment #131018|0 |1 is obsolete|| --- Comment #9 from Kevin Carnes --- Created attachment 135334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135334=edit Bug 30152: Elasticsearch - queries with OR don't work with limits When a query with "OR" is combined with a limit in Elasticsearch, the precedence is not preserved and the results are not correct. To test: 1) Set SearchEngine to Elasticsearch 2) Index records in Elasticsearch 3) Do an advanced search 4) Select More options 5) Enter a value for the first Keyword (e.g. Novels) 6) Change "and" before the second Keyword to "or" 7) Enter another value for the second Keyword (e.g. Prose) 8) Limit the search (e.g. Item type Books) 9) Do the search 10) Observe that records with the first keyword are not in the results 11) Apply the patch 12) Repeat the search 13) Observe that results with both keywords are in the results 14) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30842] Two-factor authentication code should be valid longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30842 Jonathan Druart changed: What|Removed |Added Blocks||30843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 [Bug 30843] TOTP expiration delay should be configurable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30843] New: TOTP expiration delay should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 Bug ID: 30843 Summary: TOTP expiration delay should be configurable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Depends on: 30842 It's valid 60 seconds, it could be a configuration option. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30842 [Bug 30842] Two-factor authentication code should be valid longer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #8 from Jonathan Druart --- > (In reply to David Cook from comment #6) > > Another thing we could do is add the range parameter to the verify() > > function I believe. At the moment, it looks like we're not following the > > recommendations of rfc6238 to allow additional backwards steps. (Typically, > > with a TOTP, you can usually use up to 2-3 old codes and still work to allow > > for clock drift and slow users.) > > Yes, that's a bug. I was pretty sure it was allowing at least 1 old code. > It's in the POD of ->verify, and members/two_factor_auth.pl, but C4/Auth.pm Fixed on bug 30842. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30842] Two-factor authentication code should be valid longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30842 --- Comment #1 from Jonathan Druart --- Created attachment 135333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135333=edit Bug 30842: 2FA - Allow at least one old TOTP We allow one old token when we are setting the two-factor auth, we should reuse the same settings when validation the authentication itself. Test plan: Setup 2FA for your logged-in user Logout/Login Have a look at the code and wait for 30 sec before using it (< 1min however) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30842] Two-factor authentication code should be valid longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30842 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Jonathan Druart changed: What|Removed |Added Blocks|30842 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30842 [Bug 30842] Two-factor authentication code should be valid longer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
