[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #18 from Martin Renvoize --- I think the original patch attached here is the better approach.. the one that changes PrepareItemForDisplay in C4::Items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30298] Ability to print labels from Serial Collection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30298 Katrin Fischer changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] New: cleanup_database.pl --transfers --old-reserves --confirm does not work.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914
Bug ID: 30914
Summary: cleanup_database.pl --transfers --old-reserves
--confirm does not work.
Change sponsored?: ---
Product: Koha
Version: 20.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Command-line Utilities
Assignee: koha-bugs@lists.koha-community.org
Reporter: andreas.jons...@kreablo.se
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz
When the --confirm flag was added for bug 24153 the same mistake was made twice
- 'delete if $verbose' instead of 'delete if $confirm':
if ($pOldReserves) {
print "Purging old reserves older than $pOldReserves days.\n" if $verbose;
my $old_reserves = Koha::Old::Holds->filter_by_last_update( { days =>
$pOldReserves } );
my $count = $old_reserves->count;
$old_reserves->delete if $verbose;
say sprintf "Done with purging %d old reserves.", $count if $verbose;
}
if ($pTransfers) {
print "Purging arrived item transfers older than $pTransfers days.\n" if
$verbose;
my $transfers = Koha::Item::Transfers->filter_by_last_update(
{
timestamp_column_name => 'datearrived',
days => $pTransfers,
}
);
my $count = $transfers->count;
$transfers->delete if $verbose;
say sprintf "Done with purging %d transfers.", $count if $verbose;
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Andreas Jonsson changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date picker automatically fills today's date on cataloging screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 --- Comment #16 from Martin Renvoize --- Created attachment 135744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135744&action=edit Bug 29963: Do not prefill empty date fields with today's date Revert "Bug 29815: Pre-populate 'Date acquired' field when adding/editing items" commit bd197c64567fba6899f12e4897d786adf52384d8 Items date fields in MARC framework with dateaccessioned.pl assigned as plugin automatically prefilled by it with today's date if empty on page load. This becomes big problem because it silently changes empty date fields in single item edit form with today's date. This drastically degrades UX because user won't noitce that fields were filled. Also, even when user aware about this problem, user is forced to clean the field manually each time they edit items with empty fields. Also in item batch edit tool the probability heavily increases to make mistake and leave those fields prefilled on mass. To reproduce problem with single item edit: 1. Edit single item that doesn't have a date set in any of the date fields where dateaccessioned.pl in MARC framework assigned as plugin, see that the field got prefilled with today's date. 2. Save the item. See that it overwrote the previously empty date. 3. Apply the patch. 4. Edit single item again, and ensure that the empty date fields don't get overwriten like it happened previously. To reproduce problem with bath edit: 1. Edit items in batch for any biblio, see that the date fields where dateaccessioned.pl in MARC framework assigned as plugin is automatically set to current day's date. 2. Apply the patch. 3. Check the fields again, they should be empty after that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date picker automatically fills today's date on cataloging screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 --- Comment #17 from Martin Renvoize --- Created attachment 135745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135745&action=edit Bug 29963: Restore original intention of bug 29815 This patch restores the original intended behaviour of bug 29815; To pre-populate the dateaccessioned field on item creations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date picker automatically fills today's date on cataloging screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #135684|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 Martin Renvoize changed: What|Removed |Added Summary|Date picker automatically |Date accessioned plugin |fills today's date on |should not automatically |cataloging screens |fill today's date on ||cataloguing screens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 --- Comment #18 from Martin Renvoize --- I'm a little torn here.. I've grabbed the original patch from bug 29815 that accomplished the goal in a different manner, but failed QA by Katrin as it doesn't affect all data entry locations. I have renamed the bug, as this is directly related to the dateaccessioned plugin, not all date fields.. it's only date field where end users have explicitly set the field to use dateaccessioned.. should there be a simple datepicker plugin to go along with dateaccessioned as an alternative to these patches.. it highlights a flaw that people are re-using that plugin for non-accession fields in my opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 Martin Renvoize changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 Martin Renvoize changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30915] New: "Scalar" TT plugin no longer needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30915 Bug ID: 30915 Summary: "Scalar" TT plugin no longer needed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 23166, 29844 We needed it to workaround the list context issue we had with Koha::Objects methods using wantarray. Since we remove it (bug 29844) we could remove Koha/Template/Plugin/Context.pm Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 [Bug 23166] Simplify code related to orders in catalogue/*detail.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Jonathan Druart changed: What|Removed |Added Blocks||30915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30915 [Bug 30915] "Scalar" TT plugin no longer needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Jonathan Druart changed: What|Removed |Added Blocks||30915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30915 [Bug 30915] "Scalar" TT plugin no longer needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 --- Comment #6 from Katrin Fischer --- All good, thx for the reply! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 --- Comment #12 from Katrin Fischer --- (In reply to Martin Renvoize from comment #11) > I took a quick look at the code and realised we're not using APIs or > KohaTable here yet.. that has become a stretch goal for me, but we need > something quick here. I'll have a go at doing it the old fashioned way here > today as an alternative option, but if that proves too big a goal I think > the patch here gets us out of a hole in the short term. I'd say hide them all by default and maybe have an option to see them if necessary (maybe like we do for transactions on the accounting table?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23548] AQ field required in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548 --- Comment #8 from Stefan Berndtsson --- (In reply to Martin Renvoize from comment #7) > This works as described, but I'm not sure I follow the workflow.. how can > you check in an item that Koha can't find? The point is that you can't, but the resulting reply (failed to find the item), is required to have the AQ field present (empty) according to the specification. Machines from PV-SUPA crashes when the reply does not contain that required field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 --- Comment #9 from Jonathan Druart --- (In reply to Martin Renvoize from comment #8) > Hmm, I think I actually prefer the consistency of bug 30695 to the > pluralisation this introduces personally.. > > Example > > Holds (0) > Holds (5) > > vs > > 0 Holds > 1 Hold > 2 Holds > > Whilst the latter which this introduces is nice enough, given we have the > bracketed approach elsewhere fairly consistently I currently prefer that for > wider consistency.. I also feel that works better with the (X/Y) approaches > (though the `([X] [Y])` block does make me wince a little) It would be interesting to have end-user's opinions on that. You certainly prefer "Holds (X)" because of your developer's brain :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30916] New: Staged import fails if a title is longer than 128 characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30916 Bug ID: 30916 Summary: Staged import fails if a title is longer than 128 characters Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The staged import tools will fail, if you try to import a record that has a title longer than 128 characters, as import_biblios.title is varchar(128). In comparison, biblio.title is mediumtext. We should make the fields match up or at least extend the size of import_biblios.title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 Martin Renvoize changed: What|Removed |Added Attachment #135745|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 135746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135746&action=edit Bug 29963: Restore original intention of bug 29815 This patch restores the original intended behaviour of bug 29815; To pre-populate the dateaccessioned field on item creations only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #38 from Jonathan Druart ---
(In reply to Nick Clemens from comment #36)
> Rough test plan - Jonathan, at one point you switch from item.onloan to
> item.checkout - do we need this extra fetch? onloan both tells us if checked
> out, and provides due date
From opac-reserve:
-my $issue = Koha::Checkouts->find( { itemnumber => $itemNum } );
-if ( $issue ) {
-$itemLoopIter->{dateDue} = output_pref({ dt =>
dt_from_string($issue->date_due, 'sql'), as_due_date => 1 });
-$itemLoopIter->{onloan} = 'onloan';
So "onloan" was actually coming from item->checkout.
Also:
[% IF (
itemLoo.dateDue ) %]
-Due [% itemLoo.dateDue | html %]
+[% IF (
itemLoo.checkout.date_due) %]
+Due [% itemLoo.checkout.date_due| $KohaDates as_due_date =>
1 %]
=> We need the date_due from issue->checkout anyway.
Thanks a lot for the test plan, Nick!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135648|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135649|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135650|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135651|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135652|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135653|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135654|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135655|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135656|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135657|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135658|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135659|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135642|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135643|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135644|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135645|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135646|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added Attachment #135647|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30916] Staged import fails if a title is longer than 128 characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30916 --- Comment #1 from Katrin Fischer --- I've tried to update locally to mediumtext, but this appears to fail because title is part of the PK. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What|Removed |Added URL||https://gitlab.com/joubu/Ko ||ha/-/commits/bug_27272 Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #39 from Jonathan Druart --- See the following remote branch for the patches rebased against master: https://gitlab.com/joubu/Koha/-/commits/bug_27272 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 --- Comment #20 from Alex Buckley --- Martin: Thank you for attaching the original patch from bug 29815 to this bug report. I agree with you Martin that the problem is compounded if libraries have linked multiple MARC subfields, not just the 952$d (date acquired) subfield, to the dateaccessioned.pl plugin. --- Andrew: I am sorry that my patch on 29815 has caused these unintended problems for people! You’re right the intention of 29815 was to populate the 952$d (Date acquired) field to the current date when adding a new item or receiving a new serial issue. --- Jonathan: You said it would be useful to have feedback from people involved in 29815 so everyone's needs were met. So here is the background context and needs that 29815 was intended to address: We added the 29815 patch because it was thought that Koha did not previously make it clear to cataloguers that if they save the ‘Add item’ page (or receive serial issue page) without setting anything in the 952$d subfield, Koha would still populate the 952$d with today's date. Pre-populating the 952$d on page load was intended to show that a value would be set for that subfield. --- Going forward if there are concerns with the original patch changing the behavior of one item form making it inconsistent with others in cataloguing and acq. Then I think, instead of a behavior change, it should be sufficient to add a hint saying that if you save the 952$d with nothing in it Koha will still auto-populate the 952$d with today's date. Perhaps this is the most straight forward solution? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30882] Add max_result_window to index config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 --- Comment #5 from David Nind --- (In reply to Fridolin Somers from comment #4) > In KTD, use : > curl > 'es:9200/koha_kohadev_biblios/_settings?pretty&filter_path=**. > max_result_window' Thanks Fridolin! That worked after adding this to the es section in koha-testing-docker's docker-compose.yml (after the networks configuration): ports: - "9200:9300" However, the result I got was: "max_result_window" : "1" I think that is because this is the value in the patch (index.max_result_window: 1)! Should that be index.max_result_window: 100? 8-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30916] Staged import fails if a title is longer than 128 characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30916 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Version|20.11 |unspecified --- Comment #2 from Katrin Fischer --- This is an "old version" problem. In master, this table is 'prettier': DROP TABLE IF EXISTS `import_biblios`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `import_biblios` ( `import_record_id` int(11) NOT NULL, `matched_biblionumber` int(11) DEFAULT NULL, `control_number` varchar(25) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `original_source` varchar(25) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `title` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL, `author` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL, `isbn` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL, `issn` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL, `has_items` tinyint(1) NOT NULL DEFAULT 0, KEY `import_biblios_ibfk_1` (`import_record_id`), KEY `matched_biblionumber` (`matched_biblionumber`), KEY `title` (`title`(191)), KEY `isbn` (`isbn`(191)), CONSTRAINT `import_biblios_ibfk_1` FOREIGN KEY (`import_record_id`) REFERENCES `import_records` (`import_record_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684
--- Comment #15 from Alex Buckley ---
Created attachment 135747
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135747&action=edit
Bug 30684: When a service isn't running koha-* scripts --restart should start
it
Test plan:
1. Stop plack, indexer, sip, worker, z3950 and zebra.
Note: To test Z39.50 restarting you will need to setup the server:
https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server#Setting_up_the_Z39.50_and_SRU_Server
2. Run restart command for each service:
- [Plack] sudo koha-plack --restart {instance}
- [Indexer] sudo koha-indexer --restart {instance}
- [SIP] sudo koha-sip --restart {instance}
- [Worker] sudo koha-worker --restart {instance}
- [z3950] sudo koha-z3950-responder --restart {instance}
- [Zebra] sudo koha-zebra --restart {instance}
3. Observe the services do not get restarted.
Instead you get an error saying the service is not running
4. Apply patch
5. If you are using kohadevbox you must copy koha-* scripts to /usr/sbin/:
sudo cp debian/scripts/koha-plack /usr/sbin/koha-plack
sudo cp debian/scripts/koha-indexer /usr/sbin/koha-indexer
sudo cp debian/scripts/koha-sip /usr/sbin/koha-sip
sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker
sudo cp debian/scripts/koha-z3950-responder /usr/sbin/koha-z3950-responder
sudo cp debian/scripts/koha-zebra /usr/sbin/koha-zebra
6. Repeat step 2
7. This time confirm that each service is restarted
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #16 from Alex Buckley --- Hi Marcel and David, Apologies it seems I was overly optimistic about when I could get back to this bug report. Thank you David for replying to my request for comment email to the community mailing list! I have been working on this patchset this evening and I tried to add the following line to the else block of restart_plack() in debian/scripts/koha-plack: stop_plack $instancename && start_plack $instancename I found that when plack is not running if I tried koha-plack --restart I would get the following error from that above line: [FAIL] Error: Plack not running for kohadev: failed! I had a discussion with Chris C about this and we concluded that you cannot stop a service that is not running. You will only get an error that the service is not running. Looking at how Apache does it we thought it would be best for the restart functions in the koha-* scripts to check if the service is running and if not then only start the service, not try to stop then start. Our proposed functionality is contained in the attached patchset for all the koha-* scripts with restart functions. Can you please let me know your thoughts when you have a chance? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 --- Comment #10 from Katrin Fischer --- I think I have developer's brain too ;) But from a UX perspective I like it because the more important information is first. You want to know what to click for 'holds' the number is useful, but secondary and we read left to right. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location if both are mapped to MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location if both are mapped to MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909 --- Comment #1 from Jonathan Druart --- Created attachment 135748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135748&action=edit Bug 30909: Retain permanent_location if mapped If items.permanent_location is mapped to a MARC subfields we must retain the value, not using items.location Test plan: 1 - Map permanent_location to a marc field 2 - Expose that field in the item editor 3 - Change the location of the item and retain the permanent location on saving 4 - note that permanent location has not changed Test the different other situation, when adding and editing: Empty the field, change only location, change only permanent_location, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location if both are mapped to MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- Hum, maybe the batch mod tool is affected as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 --- Comment #2 from Jonathan Druart --- I am not expecting this patch to work correctly. You are removing branchcode from ->find, in my understanding ->find is expecting only 1 result to be returned and for that you have to pass either the PK or the unique key. branchcode is part of the unique key UNIQUE KEY `additional_contents_uniq` (`category`,`code`,`branchcode`,`lang`), -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30673] Improve is_valid_date function for validating date strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30673 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > Should we only test the second patch here? Yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30882] Add max_result_window to index config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 --- Comment #6 from Fridolin Somers --- Ahhh good catch. Could you fix the test plan when you push your patch ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30907] List of checkouts won't load if item is recalled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
||com
--- Comment #1 from Jonathan Druart ---
The column has been renamed "item_level"
Those two occurrences need to be adjusted:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:
[% IF loopro.recall.item_level_recall %]
svc/checkouts:if ( $recall->item_level_recall ) {
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30882] Add max_result_window to index config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 --- Comment #7 from David Nind --- (In reply to Fridolin Somers from comment #6) > Ahhh good catch. > Could you fix the test plan when you push your patch ? No problem! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 --- Comment #13 from Martin Renvoize --- Created attachment 135749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135749&action=edit Bug 30462: Separate Running and Complete jobs This patch updates the background jobs management page to display running and completed jobs in their own tabs on the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Status|Pushed to stable|Pushed to oldstable --- Comment #23 from Arthur Suzuki --- pushed to 21.11.x for 21.11.07, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 --- Comment #14 from Martin Renvoize --- Created attachment 135750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135750&action=edit Bug 30462: Separate Queued and Complete jobs This patch updates the background jobs management page to display queued and completed jobs in their own tabs on the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30830] Add Koha Objects for Koha Import Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30830 Arthur Suzuki changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||arthur.suz...@biblibre.com --- Comment #8 from Arthur Suzuki --- pushed to 21.11.x for 21.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 Martin Renvoize changed: What|Removed |Added Attachment #135749|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30831] Add unit test for BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30831 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Status|Pushed to stable|Pushed to oldstable --- Comment #12 from Arthur Suzuki --- pushed to 21.11.x for 21.11.07, thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 --- Comment #15 from Martin Renvoize --- This serves as an alternative.. instead of cleaning up the tasks from inside the job I split out Queued and Completed jobs into their own tabs. I'm tempted to go further and add a checkbox for displaying 'System initiated' jobs along with the 'User initiated' jobs and hide the system ones by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 Martin Renvoize changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30882] Add max_result_window to index config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30882] Add max_result_window to index config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 David Nind changed: What|Removed |Added Attachment #135572|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 135751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135751&action=edit Bug 30882: Add max_result_window to index config Elasticsearch number of results is by default limited by setting "index.max-result-window", default value is 1. https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window We use this setting: https://git.koha-community.org/Koha-community/Koha/src/commit/44d6528b566e5c16eba9b15f8aa24667293766c3/Koha/SearchEngine/Elasticsearch/Search.pm#L411 I propose we add this setting in index config. Test plan: 1) Use Elasticsearch 2) Apply patch and flush memcached 3) Rebuild indexes: misc/search_tools/rebuild_elasticsearch.pl -v -b -d 4) Check the settings of index (when using koha-testing-docker*): curl 'es:9200/koha_kohadev_biblios/_settings?pretty&filter_path=**.max_result_window' 5) You should see: "max_result_window" : "100" * You also need to add this setting to the es section in koha-testing-docker's docker-compose.yml (after the networks configuration): ports: - "9200:9300" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30882] Add max_result_window to index config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 --- Comment #9 from David Nind --- I amended the patch to change 1 to 100. I also amended the commit message to update the test plan - updated the curl statement and added koha-testing-docker information. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30905] Show waiting recalls in patron account on checkouts tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30905] Show waiting recalls in patron account on checkouts tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905 Owen Leonard changed: What|Removed |Added Attachment #135740|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 135752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135752&action=edit Bug 30905: Show waiting recalls in patron account This enhancement shows recalls ready for pick-up on the patron's account so they can't be missed. To test: 1) Enable the UseRecalls system preference and set up your recalls-related circulation rules. 2) Check out an item to Patron B. 3) Log into the OPAC as Patron A and search for the item. 4) Place a recall on that item. Note the pickup library. 5) Go back to the staff client. At the top right of the page, confirm your logged in library matches the recall pickup library. Set the library to the recall pickup library if needed. 6) Check in the recalled item and confirm the recall as waiting for Patron A. 7) Go to Patron A's account (members/moremember.pl). Confirm the recall shows under 'Recalls waiting here' and all the information is correct. 8) Go to Patron A's checkouts (circ/circulation.pl). Confirm the recall shows under 'Recalls waiting here' and all the information is correct. 9) Click on the menu at the top right of the page and choose 'Set library'. Change the library to some other library. 10) Repeat steps 7 and 8, however this time the recall should show under 'Recalls waiting at other libraries'. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 --- Comment #30 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #29) > (In reply to Marcel de Rooy from comment #28) > > Coming back here very soon. Please keep status. > > Ok, do you have an idea of the timing for this one? Will be going further this afternoon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #17 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #16) > Created attachment 135702 [details] [review] > Bug 30756: (follow-up) Restore MARC21 authority file > > Signed-off-by: Tomas Cohen Arazi Thx. Considering this at least a temporary fix? When I grepped on this exported_records file, I couldnt find a reference, but it is pumped into zebraidx via the folder where it is (without file name). A discussion on itself is how we should test the search engine. We are starting Zebra and Elastic now to do so. Calling it a mock ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30882] Add max_result_window to index config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- (In reply to David Nind from comment #9) > I amended the patch to change 1 to 100. Thats a courageous change! I agree that 10K is too low. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30883] Authorities merge is limited to 100 biblio with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30883 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #69 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #44)
> See also IRC
>
> -my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber =>
> $biblionumber });
> +my $biblio = Koha::Biblios->find($biblionumber);
> +my $marcrecord = $biblio->metadata->record;
>
> This is a general pattern for most of the changes.
> Do you have performance figures ?
We should add `{ prefetch => [ 'metadata' ] }` on the biblio search.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30917] New: Improve course reserves breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917 Bug ID: 30917 Summary: Improve course reserves breadcrumbs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org I think it would be useful to add a link in the breadcrumbs to the course view from the "add items" pages: Home > Course reserves > [Course name] > Add reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #70 from Nick Clemens ---
(In reply to Tomás Cohen Arazi from comment #69)
> (In reply to Marcel de Rooy from comment #44)
> > See also IRC
> >
> > -my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber =>
> > $biblionumber });
> > +my $biblio = Koha::Biblios->find($biblionumber);
> > +my $marcrecord = $biblio->metadata->record;
> >
> > This is a general pattern for most of the changes.
> > Do you have performance figures ?
>
> We should add `{ prefetch => [ 'metadata' ] }` on the biblio search.
For a single record, I don't think it's better. See:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30169
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917 --- Comment #1 from Owen Leonard --- Created attachment 135753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135753&action=edit Bug 30917: Improve course reserves breadcrumbs This patch adds course name to the breadcrumbs and page title on the pages for adding items to a course. To test, apply the patch and go to course reserves. - Click a course to view it. - Click the "Add reserves" button. - In the breadcrumbs you should see: Home > Course reserves > [Course name] > Add reserves - [Course name] should link correctly to the course detail view. In the page title you should see: Add reserves > [Course name] > Course reserves > Home - Enter a barcode or biblionumber and proceed to the next step. Confirm that the same changes are in effect on the second page. - Perform the same tests in the "Batch add reserves" process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio when record has items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 --- Comment #10 from Marcel de Rooy --- (In reply to Nick Clemens from comment #9) > (In reply to Marcel de Rooy from comment #8) > > I agree with this patch, no problem about that. > > But the performance gain should be close to zero. > > Running Biblio.t (calling AddBIblio) twice with and without patch: > > RM: I would suggest to revise the title unless we have clear feedback to > > prove the statement. Keeping the release notes a bit more realistic? > > The gain is only going to come when you have records that contain items. > > Testing with NYTProf against an import with record containing items, there > was a clear improvement > > Biblio.t does not add items to most records, so the savings will be minimal > if present When you look at the AddBiblio code, you will be surprised to see that this routine does not add items at all. During import you need something as BatchCommitItems to add items. So the title of this report still needs attention :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 Jonathan Druart changed: What|Removed |Added Attachment #135583|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |martin.renvoize@ptfs-europe |com |.com --- Comment #16 from Jonathan Druart --- I am seeing this: https://snipboard.io/atirmJ.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 --- Comment #17 from Jonathan Druart --- Wouldn't it better to fetch the queued jobs only by default? Thinking about perfs if there are too many entries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 --- Comment #18 from Jonathan Druart --- Or maybe simply remove the tabs and have a "see all" link/checkbox to display all the jobs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio when record has items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 --- Comment #11 from Nick Clemens --- (In reply to Marcel de Rooy from comment #10) > (In reply to Nick Clemens from comment #9) > > (In reply to Marcel de Rooy from comment #8) > > > I agree with this patch, no problem about that. > > > But the performance gain should be close to zero. > > > Running Biblio.t (calling AddBIblio) twice with and without patch: > > > RM: I would suggest to revise the title unless we have clear feedback to > > > prove the statement. Keeping the release notes a bit more realistic? > > > > The gain is only going to come when you have records that contain items. > > > > Testing with NYTProf against an import with record containing items, there > > was a clear improvement > > > > Biblio.t does not add items to most records, so the savings will be minimal > > if present > > When you look at the AddBiblio code, you will be surprised to see that this > routine does not add items at all. > During import you need something as BatchCommitItems to add items. > > So the title of this report still needs attention :) That's exactly the issue - we aren't adding items, but we are processing item fields - what would you suggest for the bug title? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 Jonathan Druart changed: What|Removed |Added Attachment #135079|0 |1 is obsolete|| Attachment #135678|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 135754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135754&action=edit Bug 30570: Replace the use of jQueryUI tabs in OPAC templates This patch switches to Bootstrap tabs anywhere in the OPAC where jQueryUI tabs were used. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the item type/collection/shelvinglocation tabs on the advanced search page. Test that it works correctly with different variations of the OpacAdvancedSearchTypes system preference. - Search for an authority record and view the details. The "Notes" tab should be styled correctly. - Locate a bibliographic record and view the detail page. Verify that tabs are working, including all the options: - Holdings - Other holdings ( If OpacSeparateHoldings is enabled) - Descriptions ( MARC notes ) - Subscriptions - Serial collection (UNIMARC, untested) - Components ( If ShowComponentRecords is enabled. Link to sample record: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 ) - Comments - Editions (OPACFRBRizeEditions) - Html5media ( If HTML5MediaEnabled is on. Link to sample records: (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685) - Images ( If OPACLocalCoverImages is enabled ) Bonus points for testing these tabs for which I don't have credentials: - Syndetics TOC - Syndetics Excerpt - Syndetics Reviews - Syndetics AuthorNotes - LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView set to "in tabs." - NovelistSelect - Check tabs on these patron-related pages: - Checkout history - Search history - Patron summary. The following tabs are ✓ Checkouts ✓ Relatives' checkouts ✓ Overdues ✓ Fines ✓ Relatives' fines ✓ Holds ✓ Recalls ✓ Article requests ✓ Overdrive Signed-off-by: Lucas Gass Bug 30570: (follow-up) Correct rebase errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #10 from Jonathan Druart --- It's handy but cannot we already provide the same output without this patch? From the patron object you can get the number of renews, the CirculationRules will give you the values for the renewal rules, and then it's a subtraction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 --- Comment #21 from Alex Buckley --- (In reply to Alex Buckley from comment #20) Following on from comment #20 I see on the additem page there is a hint span we could use to display to users that if they leave the subfield linked to items.dateaccessioned (which is usually the 952$d (date acquired) subfield) blank then upon saving Koha will fill it with today's date. See https://github.com/Koha-Community/Koha/blob/7704f51d5131d3f1104244a705294db614eae76e/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc#L201 I'm about to attach a patch that adds this hint. I also added a span hint with the same wording to serials-edit.tt so that the same hint displays when receiving serial issues. The text in both spans may need to be amended if you think it's bad, so please feel free to do so, but this, in combination with the patch reversion might be the way forward? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 --- Comment #22 from Alex Buckley --- Created attachment 135755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135755&action=edit Bug 29963: Display a hint that the 952$d will be filled with current date if blank This hint will show when: - Adding an item - Editing an item - Receiving a serial issue Test plan: 1. Apply patch 2. Add an item to a biblio record, notice there is a hint message for the 952$d (date acquired) subfield 3. Edit an item, notice there is a hint message displaying for the 952$d subfield 4. Receive a serial (The subscription must be setup to create an item upon receival to test this). 5. Notice there is a hint message displaying for the 952$d (Date acquired) subfield in both the main issue you are receiving and the supplemental issue form as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio when record has items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 --- Comment #12 from Marcel de Rooy --- (In reply to Nick Clemens from comment #11) > > That's exactly the issue - we aren't adding items, but we are processing > item fields - what would you suggest for the bug title? Well, lets finish this here. What about: Improve performance of AddBiblio when importing records with many items ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio when importing records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 Nick Clemens changed: What|Removed |Added Summary|Improve performance of |Improve performance of |AddBiblio when record has |AddBiblio when importing |items |records with many items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 --- Comment #23 from Alex Buckley --- It's past midnight here in NZ now, but will check back in on comments on this bug report in the morning! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 --- Comment #1 from Jonathan Druart --- Created attachment 135756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135756&action=edit Bug 30914: (24153 follow-up) Fix cleanup_database.pl --transfers --old-reserves Silly mistake, 'delete if verbose' must be 'delete if confirm' Test plan: Try the cleanup_database.pl script to delete transfers and old issues. Using --transfers --old-reserves and the --confirm flag the entries must be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Version|20.11 |unspecified --- Comment #2 from Jonathan Druart --- Oops, sorry about that! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added Attachment #135415|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 135757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135757&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #13 from Martin Renvoize --- Created attachment 135758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135758&action=edit Bug 30744: Optionally allow passing record to prevent refetch This patch adds the option to pass the marcrecord into the call to prevent the extra DB fetch of the record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #14 from Martin Renvoize --- * Minor rebase for change of filter name in bug 30848 (to fix Katrins issue) * Minor follow-up to allow for David's request that we can pass a record along rather than refetching it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #15 from Martin Renvoize --- I can create a backportable version of this easily enough too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 Jonathan Druart changed: What|Removed |Added Version|22.05 |unspecified CC||jonathan.druart+koha@gmail. ||com, ||n...@bywatersolutions.com Depends on||30060 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 [Bug 30060] Missing primary key on user_permissions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
