[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #64 from Katrin Fischer  ---
I think it's a different feature and would still be nice to have. With recalls
you _have_ to return the item, this is more a 'nicely asking'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30736] Upgrade 'libsearch-elasticsearch-perl' package to version 6.00

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30736

--- Comment #3 from Mason James  ---
(In reply to Mason James from comment #1)
> (In reply to Mason James from comment #0)
> > this bug tracks the upgrade of 'libsearch-elasticsearch-perl' package to
> > version 6.00
> 
> i've updated the koha-staging dev and 21.11 suites with version 6.00
> 
> i'll aim to update the 'koha' repo when we have jenkins tests passing

this is done for stable and oldstable

ill aim to update 21.05 after ES6 jenkins tests are passing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912

--- Comment #8 from Keith Sorbo  ---
(In reply to Nick Clemens from comment #6)
> Created attachment 135881 [details]
> Script to allow running a single update
> 
> Provide the file name of the update you wish to run in the update option.
> 
> e.g.
> 
> perl run_single_update.pl --update 211200016.pl

(Again, please forgive my koha ignorance!)

What folder do I run this from? 
I tried from /usr/share/koha/

and get Can't locate C4/Context.pm in @INC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30937] Add a detail view for libraries

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #10 from David Cook  ---
(In reply to Thomas Klausner from comment #9)
> I could give it another go, but I'll most likely will have to do that on my
> own time (which is fine by me regarding money etc, but it's the most limited
> time slot I have...)

I can relate to that on several projects :(

> So yes, I'd like to finish this feature, but I'm not sure I can prepare a
> patch that's nice enough for you and/or easy to test (mostly because I still
> did not get around to set up a proper Koha dev environment).

Also relatable.

Regarding a proper Koha dev environment, take a look at
https://gitlab.com/koha-community/koha-testing-docker. I think a lot of people
run it on Mac/Linux but I run it on Windows. So happy to answer any questions
you might have about it. It makes Koha dev much easier. 

> I also have some architectural concerns / ideas about how the background
> jobs are implemented (eg having to list all the background job classes in
> the source code seems a bit redundant), but I think it's better to discuss
> those in another issue (or just via mail) instead of bloating this issue.

I have voiced the same concern but I think we might be the minority there. 

I think Bug 29149 re-organized the hard-coded list into a different hard-coded
list in Koha::BackgroundJob.

However, Bug 27783 removed the hard-coded list from
misc/background_jobs_worker.pl at least. 

So halfway there. I don't understand the resistance to not having a hard-coded
allow list. I think its security value is very limited and just makes the
system much less usable...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050

--- Comment #23 from David Cook  ---
(In reply to Katrin Fischer from comment #21)
> > In "sub marc_records_to_documents" in
> > lib/Koha/SearchEngine/Elasticsearch.pm, there is some record mangling to
> > handle indexing 880 fields. 
> > 
> > For Zebra, I created lib/Koha/Filter/MARC/Index880InZebra.pm, which is
> > called in bin/migration_tools/rebuild_zebra.pl. 
> > 
> > It could be good to standardize indexing related mangling...
> 
> Interesting, I wasn't ware of 880 indexing features with Elasticsarch - do
> you know more?

Yeah I've written more about it on Bug 15187. 

Basically, it also indexes the 880 as its associated field. 

E.g. "880 $6 245-01 $a 教牧書信" would be indexed as a 245 title as well. This is
very handy for multilingual Koha libraries. I did the Zebra patches for a
Chinese library of mine. (Learning basic Chinese for fun has been surprisingly
helpful for working on Koha!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29623] Cache effective circulation rules

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623

--- Comment #27 from David Cook  ---
(In reply to Jonathan Druart from comment #26)
> > I'm also interested in David's suggestion about using ID's for the cache
> > key, but I've not investigated the code to validate that myself.
> 
> I don't think it's possible, get_effective_rule_value does not have the ID.

Yeah, there's quite a bit of refactoring to do on the CRUD before we could use
the ID for the caching. My earlier suggestion was a "someday" suggestion heh.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
Nice improvement. Straightforward template changes which look good. No
complaints from the QA scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917

Lucas Gass  changed:

   What|Removed |Added

 Attachment #135795|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 135915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135915=edit
Bug 30917: Improve course reserves breadcrumbs

This patch adds course name to the breadcrumbs and page title on the
pages for adding items to a course.

To test, apply the patch and go to course reserves.

- Click a course to view it.
- Click the "Add reserves" button.
- In the breadcrumbs you should see:

  Home > Course reserves > [Course name] > Add reserves

- [Course name] should link correctly to the course detail view. In the
  page title you should see:

  Add reserves > [Course name] > Course reserves > Home

- Enter a barcode or biblionumber and proceed to the next step. Confirm
  that the same changes are in effect on the second page.
- Perform the same tests in the "Batch add reserves" process.

Signed-off-by: David Nind 

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #9 from Thomas Klausner  ---
We ended up using the commandline tool (bulkmarkimport.pl) to migrate the data.
So I stopped working on porting the web tool to background jobs.

I could give it another go, but I'll most likely will have to do that on my own
time (which is fine by me regarding money etc, but it's the most limited time
slot I have...)

So yes, I'd like to finish this feature, but I'm not sure I can prepare a patch
that's nice enough for you and/or easy to test (mostly because I still did not
get around to set up a proper Koha dev environment).

I also have some architectural concerns / ideas about how the background jobs
are implemented (eg having to list all the background job classes in the source
code seems a bit redundant), but I think it's better to discuss those in
another issue (or just via mail) instead of bloating this issue.

Greetings,
domm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30937] Add a detail view for libraries

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

Lucas Gass  changed:

   What|Removed |Added

 Attachment #135913|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 135914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135914=edit
Bug 30937: Add a detail view for libraries

This patch adds a view page for libraries, so that the user isn't
required to edit the library to see information about it.

To test, apply the patch and log into Koha as a user with permission to
manage libraries.

- In the list of libraries you should see that the library name in the
  first column is now a link.
- When you click the link you should be taken to a view of all the
  information about the library.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30937] Add a detail view for libraries

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30937] Add a detail view for libraries

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #63 from Aleisha Amohia  ---
Is this still relevant/needed now that recalls has been pushed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Noémie Labine  changed:

   What|Removed |Added

 CC||noemie.lab...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27212] Add column configuration to the acquisitions home page

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212

Lucas Gass  changed:

   What|Removed |Added

 Blocks||30938


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938
[Bug 30938] Add column configuration to the acquisitions home page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30938] Add column configuration to the acquisitions home page

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938

Lucas Gass  changed:

   What|Removed |Added

 Depends on||27212
 CC||lu...@bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212
[Bug 27212] Add column configuration to the acquisitions home page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27212] Add column configuration to the acquisitions home page

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212

--- Comment #13 from Caroline Cyr La Rose  ---
I opened bug 30938 and copy pasted my comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27212] Add column configuration to the acquisitions home page

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212

Caroline Cyr La Rose  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30938

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30938] Add column configuration to the acquisitions home page

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938

Caroline Cyr La Rose  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27212

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30938] New: Add column configuration to the acquisitions home page

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938

Bug ID: 30938
   Summary: Add column configuration to the acquisitions home page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

The patch for bug 27212 doesn't work for me. I was told to open a new bug
report.

I tried on a bywater sandbox, just in case it was my installation that was the
problem, and it's not working.

Test plan :
1) Go to Acquisitions
--> Notice the 'All available funds' table doesn't have a 'Columns' button
2) Go to Administration > Table settings > Acquisitions and find the accounts
table
3) Check 'Is hidden by default' on 'owner' and 'library'
4) Click 'Save'
5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5)
--> Notice the Owner and Library columns are still there

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30937] Add a detail view for libraries

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

--- Comment #1 from Owen Leonard  ---
Created attachment 135913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135913=edit
Bug 30937: Add a detail view for libraries

This patch adds a view page for libraries, so that the user isn't
required to edit the library to see information about it.

To test, apply the patch and log into Koha as a user with permission to
manage libraries.

- In the list of libraries you should see that the library name in the
  first column is now a link.
- When you click the link you should be taken to a view of all the
  information about the library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30937] Add a detail view for libraries

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27212] Add column configuration to the acquisitions home page

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212

--- Comment #12 from Katrin Fischer  ---
(In reply to Caroline Cyr La Rose from comment #11)
> This doesn't work for me.
> 
> I tried on a bywater sandbox, just in case it was my installation that was
> the problem, and it's not working.
> 
> Test plan :
> 1) Go to Acquisitions
> --> Notice the 'All available funds' table doesn't have a 'Columns' button
> 2) Go to Administration > Table settings > Acquisitions and find the
> accounts table
> 3) Check 'Is hidden by default' on 'owner' and 'library'
> 4) Click 'Save'
> 5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5)
> --> Notice the Owner and Library columns are still there

Hi Caroline, I saw the interaction in IRC earlier, but rule of thumb is never
to reopen a bug that has been pushed and released - could you file a new bug
instad and link them? We also need this to have proper release notes later for
the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26635] Expand authorised values in REST API call

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #41 from Lucas Gass  ---
Would love to see this get unstuck, authorized values descriptions from the
REST API would be really handy!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30937] New: Add a detail view for libraries

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

Bug ID: 30937
   Summary: Add a detail view for libraries
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The only way to see all information about a library is to edit it. I'd like to
add a view option.

Although the forthcoming patch doesn't implement it, I think the next step is
to add a "view libraries" permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30936] Reindent authority detail template

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936

--- Comment #2 from Owen Leonard  ---
Created attachment 135912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135912=edit
Bug 30936: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30936] Reindent authority detail template

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936

--- Comment #1 from Owen Leonard  ---
Created attachment 135911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135911=edit
Bug 30936: Reindent authority detail template

This patch updates the authority detail template so that indentation is
consistent.

To test, apply the patch and go to Authorities.

- Locate an authority record and view the detail page.
- Everything should look correct, with working numbered tabs.
- If the AuthDisplayHierarchy preference is enabled, you should see a
  collapsible tree of elements in the authority hierarchy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30936] Reindent authority detail template

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30936] New: Reindent authority detail template

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936

Bug ID: 30936
   Summary: Reindent authority detail template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

I propose to reformat the authority detail template in the staff interface
(authorities/detail.tt) so that it has consistent spacing and indentation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050

--- Comment #22 from Elaine Bradtke  ---
I know this is specifically about item records, but there are non-public fields
in the biblio records too. These are used by special libraries and archives who
handle rare and otherwise unusual material.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927

--- Comment #5 from Owen Leonard  ---
Created attachment 135910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135910=edit
Screenshot of how events were added to Calendar on macOS

The attached screenshot shows how the iCal entries look in my Calendar app.
"The Silver Lotus" is due at 8PM on 2022-06-23. "Up!" is due at no specific
time (23:59:59).

My calendar thinks the 8PM event spans 24 hours. Google Calendar seems to do
the same.

I think what we want is for those entries to span no time at all: Starting time
at 8PM and ending time at 8PM on the same day.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #19 from Lucas Gass  ---
Created attachment 135909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135909=edit
Bug 10950: Display pronouns field

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #18 from Lucas Gass  ---
Created attachment 135908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135908=edit
Bug 10950: Add intranet/OPAC form fields

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927

--- Comment #4 from Kyle M Hall  ---
(In reply to Owen Leonard from comment #2)
> I'm getting this error when I click on the iCal link:
> 
> Can't call method "hour" on an undefined value at
> /kohadevbox/koha/opac/opac-ics.pl line 88

Thanks for testing Owen! I think this new version of the patch should fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #135826|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 135907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135907=edit
Bug 30927 - Improve formatting or iCal files for checkout due dates

We got some feedback from a patron regarding the default notifications on the
iCal export for the patron checkout summary in the OPAC. The notifications send
1 minute before the event (the due date), which is midnight.

It makes more sense for:
A) Checkouts due at midnight to be "All day events"
B) Checkouts due at specific time to start in the morning, and end at the time
due.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Make a checkout due at 23:59
4) Make a checkout due at 11:00
5) Download the iCal file from the OPAC
6) Import this file into Calendar
7) Note the first checkout is an all day event
8) Note the second checkout starts in the morning and ends at the due time

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30742] Confusion when placing hold on record with no items available because of not for loan

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742

--- Comment #13 from Nick Clemens  ---
Created attachment 135906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135906=edit
Bug 30742: [21.11.x] Prevent placing holds on items/records where all items
notforloan Bug 30742: Remove 'bad_bibs' and send a list of holdable bibs Bug
30892: (bug 30742 follow-up) Send single bib as a holdable bib

Rebeased/rewritten patch - includes fix from 30892

This patch does a few things:
1 - Adds itemtype not for loan status to display
2 - Adds a conditional to display notforlaon status as the reason a hold cannot
be placed
3 - Seperates the lower 'Place hold(s)' buttons for single and multi holds into
two template sections
4 - Handles the case where all bibs in a multi hold have no items available
5 - Disables the button for single hlds when all items are unavailable

To test:
 1 - Find or create a record with all items of itemtype marked 'notforloan'
 2 - Attempt to place single hold on this record from staff client
 3 - See one disab;ed button, one enabled 'Place holds' button
 4 - Click 'Place holds' - hold placed
 5 - Cancel hold
 6 - Place multiple holds with some bibs that can be held, and this one that
cannot
 7 - Notice message that 'Cannot place hold on some items'
 8 - Click 'Place holds' - hold is generated for the notforloan bib
 9 - Apply patch
10 - Place single hold
11 - Note you now see not for loan status on items
12 - Note the red x also includes message abnout not for loan status
13 - Note the 'Place hold' button is disabled
14 - Attempt multi hold
15 - Message now includes "No items available: One or more records have no
items that can be held"
16 - Click 'Place holds'
17 - Above still places the hold - this is for a followup patch

Currently place request gets a list of bad_bibs that is created via javascript
on the
template. It ignores this list

Ths patch instead doesn't add info for bad bibs, and provides a list of the
bibs that
can be held

To test:
1 - Attempt multi hold with some items that can be held, and one that cannot
due to notforloan
2 - Fill in pickup locations and place hold
3 - Note hold is place on bib with no avilable items and hsows twice in results
4 - Apply patch
5 - repeat with another patron
6 - Note no aidditonal hold on record with notforloan items
7 - Note with with not for loan items appears only once in results

Bug 30892
To test:
1. Try placing hold
2. Everything seems to work but no hold gets placed.
3. Apply patch
4. Verify holds are no placed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

--- Comment #3 from Caroline Cyr La Rose  ---
I added some screenshots of the sandbox.

Just in case it's relevant...

In about, it says I'm at version 22.06.00.001

The last commit in the git log is 
commit d9e8a0e9d23a62e64a1b67e96e0dd2de9613e2ab
Author: Tomás Cohen Arazi 
Date:   Tue Jun 7 09:36:31 2022 -0300

Bug 13614: Compiled CSS

Signed-off-by: Tomas Cohen Arazi 


In the git log of the sandbox, I see the patch for Bug 30337 but not the one
for bug 24488 (probably because it's too old, I'm not sure how many commits
that git log shows)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 135905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135905=edit
Holds to pull list shows third patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 135904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135904=edit
List of holds for the title

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30935] New: Holds to pull shows wrong first patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

Bug ID: 30935
   Summary: Holds to pull shows wrong first patron
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I've seen a couple of bugs on this and they're all 'Resolved' but I still see
the problem. Maybe it's not the exact same thing... So I'm creating this in
case. Someone else can test and tell me if I'm crazy or not.

When a biblio has more than one hold (record-level), the 'First patron' column
on the 'Holds to pull' report is not showing the actual first patron, but the
last in the line.

I tried it on a bywater sandbox, just in case it was my installation that was
the problem, and it does the same thing.

To test :
1) Place a record-level hold on a biblio with an available item
2) Check the Holds to pull page (circ/pendingreserves.pl)
--> The biblio should appear in the list and the patron should appear in the
'First patron' column
3) Place a second record-level hold on the same biblio
4) Go back to the Holds to pull page
--> The biblio is still there, but the patron in the 'First patron' column is
the second patron 
5) Place a third record-level hold on the same biblio
6) Go back to the Holds to pull page
--> The biblio is still there, but the patron in the 'First patron' column is
the third patron 

Other bugs I found that talk about this: Bug 24488 (Closed fixed), Bug 30337
(pushed to master)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title Notes tab

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918

--- Comment #4 from Martin Renvoize  ---
I created this bug after bug 30744 after it was requested there that I do
something super simple for backport.  So this is the simple first step and then
I try to do a more thorough cleanup job of the code in the other bug (and
follow-up bugs atop it)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Cannot change owner of list

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #19 from Martin Renvoize  ---
I've never really investigated this area of Koha much.. I was surprised to see
the 'share' options only work from the OPAC.. I thought you'd be able to share
a private list with other staff via the staff client... that belief made me
think perhaps the transfer of ownership stuff would be tied to who you shared a
list with (and what capacity the share was.. read only, edit, owner.. somewhat
like google docs and similar friends).

Just some meandering thoughts.. I'll be interested to see where you take this
Marcel.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Fix recalls-related errors in transfers and cancelling actions

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Fix recalls-related errors  |Fix recalls-related errors
   |in log viewer, patron   |in transfers and cancelling
   |details, transfers, |actions
   |cancelling  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Fix recalls-related errors in log viewer, patron details, transfers, cancelling

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Fix recalls-related errors in log viewer, patron details, transfers, cancelling

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

--- Comment #7 from Tomás Cohen Arazi  ---
David, you mention some workflow issues, besides explosions.

I dealt with explosions on the patches, please file specific bugs for the
workflow issues you might encounter, and make sure Aleisha notices them,
perhaps assign them to her.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Fix recalls-related errors in log viewer, patron details, transfers, cancelling

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
Summary|Recalls workflow - errors   |Fix recalls-related errors
   |and issues: log viewer, |in log viewer, patron
   |patron details, transfers,  |details, transfers,
   |cancelling once checked in  |cancelling
   |(waiting for pickup)|
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 135903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135903=edit
Bug 30924: DBIC update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 135902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135902=edit
Bug 30924: Add missing branchtransfers.reason value for recall cancellation

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #99 from Martin Renvoize  ---
I'm in agreement with Marcel here.. lets be pragmatic and get this moving.

Whilst there's lots of patches here, the final diff is actually small and well
formed.. lots of good golfing.

I think 'virtualshelves' is the wrong naming for the Koha:: namespace really..
but that's not new here and I think should be handled in it's own bug..
'Koha::Biblio::Lists' or 'Koha::Lists::Biblios' perhaps.

After all that, the QA scripts is passing, tests are happy and I think this is
a solid improvement.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

--- Comment #98 from Martin Renvoize  ---
Created attachment 135901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135901=edit
Bug 11889: (QA follow-up) Spelling

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135876|0   |1
is obsolete||

--- Comment #97 from Martin Renvoize  ---
Created attachment 135900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135900=edit
Bug 11889: (follow-up) We did not need get_shared_shelves after all

Test plan:
Run t/db_dependent/Virtualshelves.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135875|0   |1
is obsolete||

--- Comment #96 from Martin Renvoize  ---
Created attachment 135899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135899=edit
Bug 11889: (follow-up) Get rid of FIXME in Koha::Patron

Instead of get_lists, I added ->virtualshelves.

I removed the addition of the suffix to the shelf name here; if we
really want that (doubts), we should do it pref based. Removing a
staff member with public lists would result in weird names with
shelf numbers on the OPAC. (Should be very easy to restore.)

Used this opportunity to refactor the patron->delete subtest a bit:
switching to build_object, removing the 'retrieved patrons',
differentiating between staff patron and patron for sharing,
adding a few tests.

Test plan:
Enable transfer ownership. Delete a patron with lists in interface.
Check what happened.
Run t/db_dependent/Koha/Patrons.t.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135874|0   |1
is obsolete||

--- Comment #95 from Martin Renvoize  ---
Created attachment 135898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135898=edit
Bug 11889: (QA follow-up) Fix tests

We need some changes for 28959 changing category to public.
Added the userenv mocking.

Note: A follow-up does a bit more refactoring here. But they
should pass at least now.

Test plan:
Run t/db_dependent/Virtualshelves.t
Run t/db_dependent/Koha/Patrons.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135873|0   |1
is obsolete||

--- Comment #94 from Martin Renvoize  ---
Created attachment 135897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135897=edit
Bug 11889: (QA follow-up) Changes for wantarray move in ->search

See bug 29844.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135872|0   |1
is obsolete||

--- Comment #93 from Martin Renvoize  ---
Created attachment 135896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135896=edit
Bug 11889: (QA follow-up) Convert to new atomicupdate style

The first patch contained an old .sql atomic update.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135871|0   |1
is obsolete||

--- Comment #92 from Martin Renvoize  ---
Created attachment 135895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135895=edit
Bug 11889: (QA follow-up) Add POD ground work

Make QA tools a fraction happier ;)

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135870|0   |1
is obsolete||

--- Comment #91 from Martin Renvoize  ---
Created attachment 135894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135894=edit
Bug 11889: (follow-up) Tests and new get_shared_shelves

Signed-off-by: Marcel de Rooy 
This is a manual reconstruction of an older patch, that git
did not want to apply anymore (sha trouble etc.)
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135869|0   |1
is obsolete||

--- Comment #90 from Martin Renvoize  ---
Created attachment 135893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135893=edit
Bug 11889: (QA follow-up) Add entry to sysprefs.sql

Also changes the insert in the atomic update to an insert ignore, as
we generally do for inserting sysprefs (see updatedatabase).

Signed-off-by: Marcel de Rooy 
Signed-off-by: Cédric Vita 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135868|0   |1
is obsolete||

--- Comment #89 from Martin Renvoize  ---
Created attachment 135892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135892=edit
Bug 11889: (follow-up) Remove share if you are the new owner

This will probably be exceptional. But if the staff member already had
a share for a private list of the patron he deletes now, he will be
the new owner and we should remove the share record.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Cédric Vita 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135867|0   |1
is obsolete||

--- Comment #88 from Martin Renvoize  ---
Created attachment 135891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135891=edit
Bug 11889: Disown a list upon deletion of owner

This patch adds a syspref 'ListOwnershipUponPatronDeletion' which
decides if all the owner's lists (public and private) are deleted
when the owner is deleted, or if the ownership of their public and
shared lists are transfered to the user who deleted the owner (private
lists that are not shared are always deleted).

To test:
1) Apply patch and update database
2) Set the ListOwnershipUponPatronDeletion syspref to 'Transfer...'
3) Set up a superlibrarian user
4) Log in as this superlibrarian user and set up three lists, a public
list (maybe named 'public'), and two private lists (named 'private' and
'shared')
5) Log in as this user to the opac (if you haven't already) and share
the 'shared' list with someone
6) View the virtualshelves table in mysql to see the three lists you
just created under your new user
7) Also view the virtualshelfshares table in mysql to see the 'shared'
list
8) Log into the staff client with your regular user (a different user to
the one you just created)
9) Search for the user you just created and delete them
10) Go to your lists
11) You should see the 'shared' list under your private lists, and their
'public' list under your public lists, both with you as the owner
12) if you view both the virtualshelves table and the virtualshelfshares
table in mysql again, youll see you are now the owner and the 'private'
list will no longer exist.
13) Set the ListOwnershipUponPatronDeletion syspref back to 'Delete...'
14) Repeat steps 3 - 10 again (it may help to delete the 'shared' and
'public' lists before you re-create them)
15) You should not see any of the lists you just made under private or
public lists this time. To confirm, check the virtualshelves table in
mysql and make sure that all three lists have been deleted.

Sponsored-by: Catalyst IT
Signed-off-by: Cédric Vita 
Signed-off-by: Marcel de Rooy 
2022-06-08 Removed old atomic update. See new follow-up.
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27212] Add column configuration to the acquisitions home page

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #11 from Caroline Cyr La Rose  ---
This doesn't work for me.

I tried on a bywater sandbox, just in case it was my installation that was the
problem, and it's not working.

Test plan :
1) Go to Acquisitions
--> Notice the 'All available funds' table doesn't have a 'Columns' button
2) Go to Administration > Table settings > Acquisitions and find the accounts
table
3) Check 'Is hidden by default' on 'owner' and 'library'
4) Click 'Save'
5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5)
--> Notice the Owner and Library columns are still there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #17 from Lucas Gass  ---
Created attachment 135890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135890=edit
Bug 10950: Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Cannot change owner of list

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #18 from Marcel de Rooy  ---
By far not ready :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Cannot change owner of list

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #17 from Marcel de Rooy  ---
Created attachment 135889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135889=edit
Bug 25498: Add transfer button on intranet

Note: Adjusting shelves_results template too for not allowing delete
when you do not have delete_public_lists (or higher). If you are the
owner, you are allowed to edit or delete. But transfer specifically
needs edit_public_lists (or higher).

Test plan:
Check if you see the transfer button on public lists only when having
permission edit_public_lists (or higher). And never on private lists.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064

--- Comment #17 from Nick Clemens  ---
Created attachment 135888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135888=edit
Bug 18064: (follow-up) Get libraries as a list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #16 from Lucas Gass  ---
Created attachment 135887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135887=edit
Bug 10950: API spec update

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

Lucas Gass  changed:

   What|Removed |Added

 Attachment #135883|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #15 from Lucas Gass  ---
Created attachment 135886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135886=edit
Bug 10950: Database update

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Martin Renvoize  ---
No other occurrences found.. passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135882|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 135885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135885=edit
Bug 30907: Fix incorrect uses of Koha::Recall->item_level_recall

This attribute name was changed to *item_level* but this two remaining
places kept calling it with the old name.

To test, verify things don't explode when looking at checkouts with
recalls and also in the log viewer.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 135884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135884=edit
Bug 30924: Fix transferstoreceive.pl explosion on recalls

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #14 from Lucas Gass  ---
Created attachment 135883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135883=edit
Bug 10950: Database update

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30934] New: Allow for this system preference NoRefundOnLostReturnedItemsAge to be library specific

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30934

Bug ID: 30934
   Summary: Allow for this system preference
NoRefundOnLostReturnedItemsAge to be library specific
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Currently, each branch can identify what their refund rules are in the
circulation and fine rule matrix in the 'Default lost item fee refund on return
policy'. Recently the system preference, NoRefundonLostReturnedItemAge has been
introduced however as a global option.  It would be more beneficial to
multibranch library systems to determine this specific system preference by
branch and not a system rule.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

--- Comment #3 from Tomás Cohen Arazi  ---
Working on Error 3.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|List of checkouts won't |Remaining incorrect uses of
   |load if item is recalled|Koha::Recall->item_level_re
   ||call

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

--- Comment #2 from Tomás Cohen Arazi  ---
Error 1: Solved on bug 30907
Error 2: Solved on bug 30907

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] List of checkouts won't load if item is recalled

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||30924


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924
[Bug 30924] Recalls workflow - errors and issues: log viewer, patron details,
transfers, cancelling once checked in (waiting for pickup)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Depends on||30907


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907
[Bug 30907] List of checkouts won't load if item is recalled
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] List of checkouts won't load if item is recalled

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 135882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135882=edit
Bug 30907: Fix incorrect uses of Koha::Recall->item_level_recall

This attribute name was changed to *item_level* but this two remaining
places kept calling it with the old name.

To test, verify things don't explode when looking at checkouts with
recalls and also in the log viewer.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] List of checkouts won't load if item is recalled

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] List of checkouts won't load if item is recalled

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_22_05_candidate
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30768] Typo: pin should be PIN

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768

--- Comment #10 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30768] Typo: pin should be PIN

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30585] Table settings for course_reserves_table are wrong due to lack of "Holding library" option

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30585] Table settings for course_reserves_table are wrong due to lack of "Holding library" option

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912

--- Comment #7 from Nick Clemens  ---
(In reply to Keith Sorbo from comment #4)
> 
> Where should I run the test plan?
> It looks like the test plan has sql commands. Do I run in the mysql command
> line? 
> I assume the restart_all and updatedatabase commands are macros created by
> koha?
> 
> (Please excuse my ignorance in the koha system.)
> 
> ***
> Test plan:
> update systempreferences set value="21.1200015" where variable="version";
> restart_all
> updatedatabase
> 
> ALTER TABLE user_permissions DROP PRIMARY KEY;
> update systempreferences set value="21.1200015" where variable="version";
> restart_all
> updatedatabase
> **

To run the SQL you should enter mysql like:
sudo koha-mysql kohadev

Where "kohadev" is your instance name

You can 'sudo koha-list' to confirm instance name(s)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30907] List of checkouts won't load if item is recalled

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060

2022-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912

--- Comment #6 from Nick Clemens  ---
Created attachment 135881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135881=edit
Script to allow running a single update

Provide the file name of the update you wish to run in the update option.

e.g.

perl run_single_update.pl --update 211200016.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >