[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Martin Renvoize changed: What|Removed |Added Attachment #134209|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 135916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135916&action=edit Bug 29623: Cache circulation rules Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Martin Renvoize changed: What|Removed |Added Attachment #135463|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 135917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135917&action=edit Bug 29623: Don't flush the whole L1 cache We shouldn't flush L1 cache completely, only the values related to the circulation rules. It is not correct to update the value of the value we are currently setting (because of the inheritance concept of the circ rules). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #31 from Martin Renvoize --- Created attachment 135918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135918&action=edit Bug 29623: (QA follow-up) Add POD to Koha::Cache::Lite Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #32 from Martin Renvoize --- Created attachment 135919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135919&action=edit Bug 29623: (QA follow-up) Add POD to Koha::CirculationRules Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #33 from Martin Renvoize --- OK, all points raised in the discussion have been agreed upon.. Happy to PQA (with the POD follow-ups to squash QA script noise). Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #34 from Martin Renvoize --- (In reply to Jonathan Druart from comment #28) > IMO It's not about refactoring, it's just not possible. get_effective_rule > will still need to get (category, library, itemtype) in parameter. If the > caller has the rule's id, it does not need to ask for the *effective* rule :) Agreed.. now I've delved into the code that's pretty obvious. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 --- Comment #5 from Martin Renvoize --- Also, as dcook mentioned.. it was a little sub-optimal that we're fetching the metadata record twice to filter twice.. by allowing it to be passed along we may gain a minor performance improvement (unmeasured). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #309 from Eugene Espinoza --- Hi David! Any updates on this? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 Harald changed: What|Removed |Added CC||fechs...@gmail.com --- Comment #11 from Harald --- The code in the first attachment from Jonathan Druart works for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30939] New: remove_unused_authorities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30939 Bug ID: 30939 Summary: remove_unused_authorities.pl Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: bibliot...@agustinosvalladolid.org QA Contact: testo...@bugs.koha-community.org When I try to remove unused authorithies I get: authid=1 type=PERSO_NAME : used 6 time(s) authid=2 type=TOPIC_TERM : used 23 time(s) authid=3 type=PERSO_NAME : used 3 time(s) authid=4 type=PERSO_NAMEUndefined subroutine &main::DelAuthority called at /usr/share/koha/bin/migration_tools/remove_unused_authorities.pl line 98. When I try only a test works OK. Thank you Fernando -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #135856|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 135920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135920&action=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #4 from Jonathan Druart --- Sorry, I forgot to commit a new file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #42 from Martin Renvoize --- I'm still coming back around to comment #32, in particular: > a single page web app would actually grab the full AV list when it first > needs it and cache it locally to use for subsequent uses.. I think for efficiency we're going to really struggle with embedding AV's dynamically in the results. I'm thinking more and more we need to focus on having AV and Framework routes and then building a JS equivalent to the RecordProcessor pattern for the UI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #21 from Marcel de Rooy --- Created attachment 135921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135921&action=edit Bug 25498: Add a transfer form for public lists Test plan: [1] Valid transfer: Log in with staff patron C having edit_public_lists. Pick a public list. Choose Transfer. Select a patron. Submit and check if transfer was successful. [2] Permission problem: Pick a staff user D. Temporary enable edit_public_lists. Add another private tab. Login with D. Pick a public list. Transfer. Choose another patron. Wait. Switch tab: remove added permission from D. Switch tab again: Submit transfer form. Error? Close tab. [3] Bonus test - Shelf disappeared: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete the selected public list. Close tab. Submit the transfer. Not exist error? [4] Bonus test - Patron not found: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete selected patron. Close tab. Submit transfer. Patron not found error? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #22 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #20) > Allow the owner of a shared list to transfer ownership to another member of > the list like you wrote above. Does anyone already have some thoughts about the sensitivity of this OPAC operation? I'm thinking of a simple select containing the names only of the members that accepted a share of this list. But actually we only mailed an invitation via the Share button; very strictly speaking this would reveal more information. On the other hand, the shared list owner should be entitled somehow to see which people are using the list. Note: Instead of a name, we could list an email address with a borrowernumber behind it in the select option? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #68 from Radek Šiman (R-Bit Technology, s.r.o.) --- (In reply to Michal Denar from comment #67) > I asked Radek to comment on this patch. Hi girls and boys, the libraries we support like this feature, but until it notifies the user during the loan only once, it's kind of unusable. Thinking about use cases maybe I've found a way to solve this issue. We could try to find the last HOLDPLACED_CONTACT message's time_queued in the message_queue table between issuedate and recently created hold's reservedate. If there is a message, we shouldn't send another one. In the case of no results, new HOLDPLACED_CONTACT message will be queued. Is is good or bad idea? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Attachment #113616|0 |1 is obsolete|| Attachment #113617|0 |1 is obsolete|| Attachment #113618|0 |1 is obsolete|| Attachment #113619|0 |1 is obsolete|| Attachment #113620|0 |1 is obsolete|| Attachment #113621|0 |1 is obsolete|| Attachment #113622|0 |1 is obsolete|| Attachment #113623|0 |1 is obsolete|| Attachment #113624|0 |1 is obsolete|| --- Comment #111 from Kyle M Hall --- Created attachment 135922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135922&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #112 from Kyle M Hall --- Created attachment 135923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135923&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #113 from Kyle M Hall --- Created attachment 135924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135924&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #114 from Kyle M Hall --- Created attachment 135925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135925&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #115 from Kyle M Hall --- Created attachment 135926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135926&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #116 from Kyle M Hall --- Created attachment 135927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135927&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #117 from Kyle M Hall --- Created attachment 135928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135928&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #118 from Kyle M Hall --- Created attachment 135929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135929&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #119 from Kyle M Hall --- Created attachment 135930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135930&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30940] New: Add ability to skip hold fee when placing hold via the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30940 Bug ID: 30940 Summary: Add ability to skip hold fee when placing hold via the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sally.hea...@cheshiresharedservices.gov.uk QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com We have some patron categories which are charged a hold fee. The hold fee is applied to the patron's account when they collect the item and check it out. However, there are occasions when the staff place a hold and agree to waive the hold fee as a goodwill gesture. At the moment, this happens: - Staff member offers the patron a free hold - Staff member puts a note on the patron account - Item arrives to fill the hold and is checked in - Patron collects the item and checks it out - A hold charge is applied - Patron has to go to the desk to have the charge waived It gives the impression that the staff forgot to waive the charge - and it can be frustrating for the patron to have to wait in a queue to speak with a staff member to resolve this, whereas the rest of the transaction was self service. It would be great if we could have a check box on the place hold process, where staff can choose to override the hold charge so that it doesn't generate as a one-off. For example: - Staff member places a hold and checks a box to say 'free hold' - Hold arrives and is collected - Patron checks the item out - No hold charge is applied -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30824] Improve performance of BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30824] Improve performance of BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 --- Comment #11 from Martin Renvoize --- Blocking patch has been pushed now, setting back to PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added Component|OPAC|Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #19 from Martin Renvoize --- Moved the original bugfix to it's own bug and changed this to an architectural one. I'm still working through this tree at the moment really so perhaps not worth testing. If you were to test, it's basically to confirm that there are no user facing changes when this bug is applied atop bug 30198 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize changed: What|Removed |Added Text to go in the|This fixes the display of | release notes|nonpublic notes (583$x) in | |the OPAC. Before this, if | |the OPAC visibility setting | |in the framework for 583$x | |was set not to show, it was | |still showing. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #9 from Martin Renvoize --- Comment on attachment 135759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135759 Bug 30889: Set userenv for background jobs Review of attachment 135759: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=30889&attachment=135759) - ::: misc/background_jobs_worker.pl @@ +126,5 @@ > +C4::Context->_new_userenv(-1); > +C4::Context->set_userenv( > +$patron->borrowernumber, $patron->userid, > +$patron->cardnumber, $patron->firstname, > +$patron->surname,$patron->branchcode, This feels a little funky.. isn't the branchcode meant to reflect the logged in branch... i.e. 'where that patron triggered the job'.. so that may not be the patrons home branch at all. This is not a trivial thing to resolve correctly though, you're right. @@ +131,5 @@ > +$patron->library->branchname, $patron->flags > +); > +$job->process( $args ); > +C4::Context->_unset_userenv(-1); > +} ese { else -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #10 from Martin Renvoize --- I'm wondering if we ought to record some of this at enqueue time in the queue table itself... then set the userenv from that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] New: Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Bug ID: 30941 Summary: Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #3 from Nick Clemens --- Created attachment 135931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135931&action=edit Bug 30025: DB update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX --- Comment #45 from Nick Clemens --- Deprecating in favor of 30920 / 30848 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Bug 15262 depends on bug 28371, which changed state. Bug 28371 Summary: Improve performance of XSLTParse4Display https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #11 from Martin Renvoize --- The more I contemplate this the more I think we should add a 'context' field (probably replacing the 'borrowernumber' field) to the background_jobs table and populate it with a serialised context from the enqueue method and then use that context to set a context for the job to run in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23541] Duplicate Hold Notifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Still valid? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #11) > The more I contemplate this the more I think we should add a 'context' field > (probably replacing the 'borrowernumber' field) to the background_jobs table > and populate it with a serialised context from the enqueue method and then > use that context to set a context for the job to run in. I support this option. Context needs to be set on enqueing the job. The caller knows the context. The background job class should be able to set userenv correctly when starting the job. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #43 from Tomás Cohen Arazi --- One thing to consider is we should (ideally) not change the API often so devs can rely on it. That said what if we streamline the data structure (i.e. do not return the AV object, but just the description, making it context (opac?)) and try this. Once we find a better pattern in real-life uses, we can flag this as 'slow' and propose a different one, while keeping it for some cases in which it really doesn't hurt performance. Bug 8179 is a real example of using this feature without any noticeable overhead. So maybe when this is *not enough* we look for other approaches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23541] Duplicate Hold Notifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541 --- Comment #5 from Lucy Vaux-Harvey --- Thanks for the reminder Nick - I haven't received any further reports of this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Martin Renvoize changed: What|Removed |Added Attachment #135759|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 135932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135932&action=edit Bug 30889: Set userenv for background jobs We need to set the userenv when we process the jobs. It is useful for stats (at least) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Martin Renvoize changed: What|Removed |Added Attachment #135760|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 135933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135933&action=edit Bug 30889: Set interface to 'intranet' Is that correct? Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #15 from Martin Renvoize --- Created attachment 135934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135934&action=edit Bug 30889: (follow-up) Add context field to background_jobs This patch adds a new 'context' field to the background_jobs table to record the context in which the job was queued. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #16 from Martin Renvoize --- Created attachment 135935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135935&action=edit Bug 30889: (follow-up) Record and use context in background_jobs This patch records the current context to the background_jobs table at enqueue time and then uses that record to set the context at process time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #17 from Martin Renvoize --- Created attachment 135936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135936&action=edit Bug 30889: DBIC Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30911] Datatables error on course-details.pl after adding a bib-level course reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Katrin Fischer changed: What|Removed |Added Depends on||14237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 [Bug 14237] Allow bibs to be added to course without items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14237] Allow bibs to be added to course without items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Katrin Fischer changed: What|Removed |Added Blocks||30911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 [Bug 30911] Datatables error on course-details.pl after adding a bib-level course reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #18 from Martin Renvoize --- So we could probably squash this as it's basically an alternative.. but I based it on top of Jonathans work in case he wanted recognition for working on it already :) I've not tested it deeply as yet, but I believe this approach should work and be a little more correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Martin Renvoize changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |martin.renvoize@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #1 from Julian Maurice --- Created attachment 135937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135937&action=edit Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30942] New: Why can I place a recall on a bib when no items are on loan?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30942 Bug ID: 30942 Summary: Why can I place a recall on a bib when no items are on loan? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org The 'Place recall' button always seems to be present, even when there's no items on loan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30943] New: Make background job classes use helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Bug ID: 30943 Summary: Make background job classes use helpers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Bug 30360 introduced helper methods for dealing with starting, marking as finished and also handling progress. Our tasks should use them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30943] Make background job classes use helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||30360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 [Bug 30360] Add helper methods to Koha::BackgroundJobs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 [Bug 30943] Make background job classes use helpers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 George Williams (NEKLS) changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 --- Comment #20 from Martin Renvoize --- Created attachment 135938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135938&action=edit Bug 30462: (follow-up) Limit completed to 60 minutes This follow-up reduces the completed jobs list to only those jobs completed within the last 60 minutes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Juliet Heltibridle changed: What|Removed |Added CC||jheltibri...@rcplib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 --- Comment #21 from Martin Renvoize --- I think this should be enough to backport and get us out of the current hole we are in.. I don't think we should completely hide index jobs for now. I think further work should be done in new bugs linked off this one to refine the whole interface and convert to API-driven tables allowing for more full-fledged filters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29860] Useless warnings in regressions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #7 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30772] Terminology: Replace instances of "reserve" with "hold"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.01 released in|| --- Comment #11 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30772] Terminology: Replace instances of "reserve" with "hold"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 David Nind changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30774] Typo: i %sEdit %sReserve %s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #8 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #20 from David Nind --- Thanks Martin. I'll leave for a bit and come back to this one later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30828] Remove unused variable in placerequest.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #11 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Kyle M Hall changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |testo...@bugs.koha-communit ||y.org Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #16 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.01 released in|| --- Comment #10 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Nick Clemens changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Nick Clemens changed: What|Removed |Added Attachment #33238|0 |1 is obsolete|| Attachment #33239|0 |1 is obsolete|| Attachment #33240|0 |1 is obsolete|| --- Comment #22 from Nick Clemens --- Created attachment 135939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135939&action=edit Bug 12630: Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! - -- REPLICATE LIKE THIS -- - 0. Enable AllowHoldDateInFuture-system preference! 1. Select a biblio with some holds. 2. Place a hold with the "Hold starts on date"-attribute set to future. 3. More the specific hold up on the priority queue. 4. Add another normal hold, observe how it is prioritized with the "Hold starts on date"-hold, leaving old holds to the prioritization queue tail. Unfair eh? Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #23 from Nick Clemens --- Created attachment 135940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135940&action=edit Bug 12630: (QA follow-up) - Rename _ShiftPriorityByDateAndPriority to _ShiftPriority Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #24 from Nick Clemens --- Created attachment 135941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135941&action=edit Bug 12630: Add regression tests Verify that the 2 tests failed before applying this patch and return green after. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #25 from Nick Clemens --- Created attachment 135942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135942&action=edit Bug 12630: Rebase tests and cover CheckReserves It turns out we do honor reservedate in CheckReserves, so a hold with a lower priority will fill before a hold in the future. I add tests to cover this and fix the old tests to pass again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30842] Two-factor authentication code should be valid longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30842 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #10 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13202] Holds with a future date should be skipped over until that date is current
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13202 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Nick Clemens --- This does actually seem to be the case, bug 9761 even allowed for lookahead to capture some of these. Tests added on bug 12630 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Bug 12630 depends on bug 13202, which changed state. Bug 13202 Summary: Holds with a future date should be skipped over until that date is current https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13202 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30731] Noise from about script coming from Test::MockTime (or other CPAN modules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #15 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Kyle M Hall --- A couple points: A) I'm getting 'Can't call method "unblessed" on an undefined value at /kohadevbox/koha/catalogue/detail.pl line 205' if a subscription has no order related to it B) There's no need to unbless the order to work with it, just use the object's accessors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com --- Comment #38 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #19 from Jonathan Druart --- +my $job_context = $params->{job_context} // C4::Context->userenv; Shouldn't we force that? Either C4::Context->userenv or job_context is passed. Otherwise explode? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #20 from Jonathan Druart --- (In reply to Martin Renvoize from comment #18) > So we could probably squash this as it's basically an alternative.. but I > based it on top of Jonathans work in case he wanted recognition for working > on it already :) You can squash, I don't mind! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30629] in title of patron card creator template needs to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.01 released in|| --- Comment #12 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Kyle M Hall changed: What|Removed |Added QA Contact||k...@bywatersolutions.com CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28723] Holds table not displayed when it contains a biblio without title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #14 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Kyle M Hall changed: What|Removed |Added Attachment #135244|0 |1 is obsolete|| Attachment #135245|0 |1 is obsolete|| Attachment #135246|0 |1 is obsolete|| --- Comment #25 from Kyle M Hall --- Created attachment 135943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135943&action=edit Bug 24239: Add column illrequests.date_due Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 --- Comment #26 from Kyle M Hall --- Created attachment 135944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135944&action=edit Bug 24239: Unit tests Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 --- Comment #27 from Kyle M Hall --- Created attachment 135945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135945&action=edit Bug 24239: Let the ILL module set ad hoc hard due dates The Swedish Libris ILL backend lets librarians store a specific due date when an ILL loan is received. This patch set adds a new date_due column to the illrequets table that can be used by the different backends to store a due date. If an illrequest has the date due set, it will be used when the item is checked out instead of the calculation using the circulation conditions. To test: - Apply the patch and make sure the atomic database update is run - Use the FreeForm backend to add one ILL request. Take note of the illrequest_id of the request you created. We refer to this as "x" below. - Connect a biblio (with biblionumber y), that has an item with a barcode, to the ILL request directly in the database: UPDATE illrequests SET biblio_id = y WHERE illrequest_id = x; - Next we set the due date, this would normally be done by or from the backend. UPDATE illrequests SET date_due = "2023-01-01" WHERE illrequest_id = x; - Go to circulation and issue the barcode of the item to the patron associated with the FreeForm ILL request. Verify that the loan gets a due date of 2023-01-01. - Ideally: return the item and issue it again through SIP2 and SCO, and verify that the due date is still 2023-01-01. - Verify that there are no regressions, so that regular calculation of due dates still work. - prove t/db_dependent/Circulation.t (Patch description, test plan and partial code credits to Magnus Enger) Signed-off-by: Katrin Fischer (Patch description and test plan rewritten to reflect changes in development) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/