[Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on the bibliographic detail page

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

--- Comment #5 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #4)
> Might be fixed by bug 27272.

Hum, forget that, it won't.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on the bibliographic detail page

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

--- Comment #4 from Jonathan Druart  ---
Might be fixed by bug 27272.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

Michal Urban  changed:

   What|Removed |Added

 CC||michalurban...@gmail.com
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

--- Comment #6 from Michal Urban  ---
Created attachment 136471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136471=edit
Bug 10086: No way to go back to the basket on uncertain prices page

Fixed the edit button placement to the right-most column and fixed the
the displayed information in the order column from calling non-existent
variables based on the item.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

--- Comment #6 from David Cook  ---
(In reply to Mark Alexander from comment #5)
> Thanks.  Setting max_servers to '2' works for my use case with two
> simultaneous connections.

Great. Glad I was able to help. I enjoy networking issues heh.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

--- Comment #5 from Mark Alexander  ---
Thanks.  Setting max_servers to '2' works for my use case with two simultaneous
connections.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31022] 400/404 actually returns 500

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31022

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30879] Add option to sort components by biblionumber

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879

--- Comment #18 from David Cook  ---
Since 30327 has been updated...

My test plan:
1 - Apply patches
2 - cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
/etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
3a - restart_all
3b - koha-rebuild-zebra -b -f -v kohadev
3c - koha-upgrade-schema kohadev
4 - Browse to:
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw=a_by=biblionumber_dsc=20
5 - Confirm records sorted correctly
6 - Browse to
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw=a_by=biblionumber_asc=20
7 - Confirm records sorted correctly

I don't know how to test the Elasticsearch or UNIMARC changes.

I've changed "SearchEngine" to "Elasticsearch" and run "koha-elasticsearch
--rebuild kohadev" which spat out the following:
Cannot determine authority type for record: 1 at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 564.

In the logs I'm seeing this error:
[2022/06/24 02:25:42] [WARN] [Request] ** [http://es:9200]-[400]
[query_shard_exception] No mapping found for [local-number__sort] in order to
sort on, with:
{"index":"koha_kohadev_biblios","index_uuid":"CVVpzugoRfqw7zsFft1pnQ"}

Will need more specific instructions to test this one. I'll leave it as "Needs
Signoff" rather than "Failed QA" in the event that someone else can test it
correctly. 

--

The test plan for bug 30327 wasn't very specific in its instruction "Add some
components to a record by control number or title depending on above", so I
tried a lot of things... many which didn't work. Would've been nice to have
more explicit steps there. 

Additional test plan:
1 - Update ComponentSortField system preference and verify biblionumber is an
option
2 - Repeat test plan from 30327 and confirm sorting with biblionumber works

This looks OK with Zebra.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
Btw, Nick, you made me chuckle with "Orly" heh.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

David Cook  changed:

   What|Removed |Added

Version|21.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

--- Comment #4 from David Cook  ---
Created attachment 136470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136470=edit
Bug 31033: Explicitly define max child processes for SIP server

By default, the SIP server appears to only use 1 child process for
responding to SIP connections.

This change makes this explicit in the configuration, which should
make it so that people who need more than 1 simultaneous SIP connection
can know to just increase the value for the "max_servers" parameter
in the SIPconfig.xml file.

Test plan:
1. Add "max_servers='1'" to your SIP configuration file
2. koha-sip --restart kohadev
3. Open 3 terminals
4. Run "telnet localhost 6001" on 2 terminals
5. On the 3rd terminal, run the following:
ss -l -n -t
ps -efww | grep "sip"
6. Note that there are 2 processes called
kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm
/etc/koha/sites/kohadev/SIPconfig.xml
One of these processes is the parent of the other
7. The Recv-Q in the "ss" output should show 1
(This means that 1 of your telnet connections is in the server's TCP backlog)
8. Celebrate as the configuration works as expected

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

--- Comment #3 from David Cook  ---
It looks like Net::Server::Prefork subclasses Net::Server::PreForkSimple which
subclasses Net::Server and I'm not sure that the "max_server" configuration
item actually gets passed along correctly... 

So I'm going to add a default of "1" for Koha since that seems to be what's
used in practice... 

In your case, I'd say just add "max_servers='2'" or whatever you need to
support your situation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

--- Comment #2 from David Cook  ---
Mark, your problem is solvable by changing your SIPconfig.xml file, but I think
this bug is worth keeping open for now, as maybe we should change the defaults
for the Koha SIP server, or at least add some comments to make it clear how it
works.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
That's quite interesting.

Using koha-testing-docker, I ran "telnet localhost 6001" from two different
terminals. In a third terminal, I ran the following "ss -l -n -t" and I can see
that the SIP process listening on 127.0.0.1:6001 has 1 connection in its TCP
"listen" backlog. 

While the telnet client says it's connected, that just mean it's connected to
the server's network stack. Only one connection has actually been accepted by
the application. (This would probably be clear from your prod syslog as well.)

Looking at the "server-params" in the SIPconfig.xml file, it looks like
min_servers = 1 and min_spare_servers = 0. In theory, 0 should be fine because
that should just means 0 spare servers...

When I change min_spare_servers to = 1, the forking seems to work correctly. If
there are no current connections, then there is only 1 child process. If there
are current connections, then it keeps 1 extra connection around. 

I'd say it's a bug/quirk in Net::Server::PreFork which powers the SIP server. 

Since it looks like the SIP server has accidentally been using a max of 1 child
process, we should probably set some limits on maximums since the default max
server is 50. The default max spare servers is 10...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31035] Script to update OPACSuppression field depending on hidden items

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
This script would break the functionality introduced by the syspref
"OpacHiddenItemsExceptions" though, unfortunately.

I thought about this a bunch while working on bug 19704. 

In theory, you could enqueue a background job, when "OpacHiddenItems" is saved,
which could process every record with items and then update a "biblio.hidden"
field (so that it can be queried for SQL searches and not just Search Engine
searches), if "OpacHiddenItemsHidesRecord" is set. 

--

Maybe the solution is to get rid of "OpacHiddenItemsExceptions" and then either
use a cronjob or a background job to update the 942$n/biblio.hidden.

It would be great to be able to eliminate the post-processing of records/items
caused by "OpacHiddenItems", so generally speaking I'm on board for what you're
trying to do!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #34 from David Cook  ---
Signed off!

Hopefully it'll get through QA soon and we'll have a generic OpenID Connect
client in the main Koha codebase!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #78 from David Cook  ---
Just noting that I've signed off Bug 30988 so it would be great to get some QA
eyes on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21586] Add generic OpenIDConnect client implementation

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #16 from David Cook  ---
Just noting that I've signed off Bug 30988 so it would be great to get some QA
eyes on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #33 from David Cook  ---
Created attachment 136469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136469=edit
Bug 30988: Fix minor formatting issues

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

David Cook  changed:

   What|Removed |Added

 Attachment #136451|0   |1
is obsolete||

--- Comment #32 from David Cook  ---
Created attachment 136468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136468=edit
Bug 30988: Moving id token validation code into a module

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

David Cook  changed:

   What|Removed |Added

 Attachment #136450|0   |1
is obsolete||

--- Comment #31 from David Cook  ---
Created attachment 136467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136467=edit
Bug 30988: Add generic OpenIDConnect client implementation

A generic OpenID Connect implementation.

Test plan:
1- Set up an OAuth2 provider that has a discovery doc (e.g. for google it's
https://accounts.google.com/.well-known/openid-configuration) and note down the
client id and client secret.
Docs to help setup:
google: https://developers.google.com/identity/protocols/oauth2/openid-connect
   
https://koha-community.org/manual/20.11/en/html/administrationpreferences.html
gitlab: https://docs.gitlab.com/ee/integration/oauth_provider.html
2- Apply the patch
3- Run atomicupdate to update database
4- Configure system preferences:
a- Set OIDC to Yes
b- Enter the url to the discovery doc of your OAuth2 provider
c- Fill OIDCOAuth2ClientID with noted client id
d- Fill OIDCOAuth2ClientSecret with noted client secret
e- Change OIDCProviderName to change the text displayed on OIDC login
buttons

f- Configure the other related system preferences as you wish. They
shoud work the same way as the similar googleopenidconnect system
preferences.
5- If OIDCAutoRegister is set to Don't allow, have a koha
account with the same email as the one used by your OAuth2 provider.
6- In OPAC, sign in using OpenID Connect.
7- You may have to log into your OpenID provider account and accept conditions.
It should finally log you into the koha account.

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31035] Script to update OPACSuppression field depending on hidden items

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035

--- Comment #1 from Fridolin Somers  ---
Created attachment 136466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136466=edit
Bug 31035: Script to update OPACSuppression field depending on hidden items

WIP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #30 from David Cook  ---
*** Bug 28420 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420

David Cook  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #24 from David Cook  ---


*** This bug has been marked as a duplicate of bug 30988 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31021] Part of C4::Search::searchResults() is only for staff interface

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31021

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
I haven't deep dived this one (yet) but (re)moving unnecessary code sounds
good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on the bibliographic detail page

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
I've been thinking it would be good to have a "suppressed" or "hidden" column
in the "biblio" table... it would help prevent this sort of situation I reckon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31035] Script to update OPACSuppression field depending on hidden items

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31035] Script to update OPACSuppression field depending on hidden items

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035

Fridolin Somers  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31035

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31035] Script to update OPACSuppression field depending on hidden items

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24403

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31035] New: Script to update OPACSuppression field depending on hidden items

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035

Bug ID: 31035
   Summary: Script to update OPACSuppression field depending on
hidden items
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

System preference OPACSuppression enables to skip from search results biblio
records with a dedicated search field (usually on 942$n).

We should have a script to update this MARC field depending if all items of the
record are hidden (OpacHiddenItems and hidelostitems).

This is independant from OpacHiddenItemsHidesRecord Bug 18989 that has known
issues : Bug 17787, Bug 23923 ... See Bug 24403 dependencies

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||27685


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685
[Bug 27685] Syspref OpacSuppression has no effect on the bibliographic detail
page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on the bibliographic detail page

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Depends on||10195


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195
[Bug 10195] Records hidden with OpacSuppression can still be accessed
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #78 from David Nind  ---
Created attachment 136465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136465=edit
Bug 27113 - Advanced search - more options display issue

I've added a follow-up with my suggestions for the descriptions for the two new
system preferences.

I've changed the status to Failed QA as there is a slight issue with the staff
interface advanced search > more options after the patch is applied. See the
attached screenshots.

Also, something for QA to comment on. The spelling for Elasticsearch - the s in
search is not capitalised, as it is the product name (not ElasticSearch). Does
this need changing for the preference names, and the other code in the patches?

Can confirm everything continues to work otherwise, and I like it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #77 from David Nind  ---
Created attachment 136464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136464=edit
Bug 27113: (follow-up) Update descriptions for system preferences

Update the descriptions for the new system preferences -
IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch.

Test plan:
1. Review the descriptions for the IntranetAutocompleteElasticSearch
   and OPACAutocompleteElasticSearch system preferences.
2. Make sure they are readable and make sense.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31034] Bib image hidden after changes in bib detail

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31034

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |normal
Version|21.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31034] Bib image hidden after changes in bib detail

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31034

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #1 from Lucas Gass  ---
(In reply to Sara Brown from comment #0)
> Hiding the Content type line in opacusercss with 
> 
> #content_type {
>   display: none;
> }

I think this CSS is a red herring. 

Whats is happening for me, on the OPAC detail page, is this:

1. Turn on Coce and all the image providers
2. Enable Coce for the OPAC
3. Go to a results set and choose a record that clearly shows an image on the
results page. 
4. Now click on that records detail page, you may see the
'#biblio-cover-slider' appear for a second before it disappears. If you have to
clear your cache, and reload. 
5. View the page source. The #biblio-cover-slider element is present in the
source but has been removed when you inspect with your browsers dev tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28696] Point of sale: attempting to pay with the "Enter" key cause an overcharge in the database

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28696

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31034] New: Bib image hidden after changes in bib detail

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31034

Bug ID: 31034
   Summary: Bib image hidden after changes in bib detail
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: sbr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Hiding the Content type line in opacusercss with 

#content_type {
  display: none;
}

somehow is causing the bib image to also be hidden once the page reloads. It
doesn't show even if the code is removed but does display again if the cache is
cleared. Hiding LOC and DDC details didn't affect the image in this way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28696] Point of sale: attempting to pay with the "Enter" key cause an overcharge in the database

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28696

--- Comment #5 from Marie-Luce Laflamme  ---
I can no longer reproduce the problem in Koha 20.05. I'm not sure what went
wrong before, maybe some old sales were left in my cache.

However, the point-of-sale behaviour has changed since my first test. In 21.05,
 you are now forced to choose a cash register before the payment confirmation.

This new behaviour seems to fix the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30998] [DOCS] Managing documentation tasks - simplify processes and integrate more with the development process

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30998

--- Comment #23 from David Nind  ---
Comments on comment #15 (Arthur) and comment #16 (Victor).

I think Martin has tried to encourage that type of work flow - where a bug
isn't pushed until the docs are done, but that hasn't worked that well for
Koha.

I'd more than welcome, and certainly encourage, contributions from developers
for their bugs, but I realise that this may not necessarily be a strength or
something they are interested in doing.

Everyone can contribute to the docs, but there is a bit of a learning curve
(although developers are at least familiar with git, so that is once less
hurdle!). I'll take a look at updating our instructions and guidance, which I'm
trying to cover in a "Content Development Guide".

Slightly off-topic, but I'd probably like developers to focus on adding release
notes before they tackle the documentation, for example:

- This new feature [does XYZ].
- This enhancement [adds X and Y to Z].
- This fixes [XYZ] so that it does [expected behaviour], [instead of whatever
error or problem was happening]. 

That way, it makes it much easier to identify if documentation updates are
required (instead of having to read through the bug history/latest patches).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30998] [DOCS] Managing documentation tasks - simplify processes and integrate more with the development process

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30998

--- Comment #22 from David Nind  ---
(In reply to Martin Renvoize from comment #21)
> I like that we're encouraging 'someone' to look at every bug and assess
> whether it needs a docs change or not.. but perhaps we could 'burden' the
> rmaints to be a little picky and do some of the obvious filterings at 'Not
> backporting' time.. when it's obviously a behind-the-scenes change that
> doesn't affect workflow, UX or UI they could just skip straight to Resolved
> Fixed still instead of using the middle 'Needs documenting' ?

I think that would work - ideally, they should add a comment about why
documentation updates are not required (as you have been doing),

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] New: SIP2 does not correctly handle multiple simultaneous connections

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

Bug ID: 31033
   Summary: SIP2 does not correctly handle multiple simultaneous
connections
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ma...@pobox.com
QA Contact: testo...@bugs.koha-community.org

If two connections are made to the SIP2 server simultaneously, the second
connection does not receive any replies until the first connection is closed. 
Here is how I reproduced the problem:

In terminal #1, use 'telnet koha.ourlibrary.com 6001' to connect to
the SIP2 server.  Send a 9300CN message to log into SIP2.  The SIP2
server sends back the expected 941 response.

In terminal #2, use telnet in the same way to connect
to the SIP2 server.  Then try sending the 9300CN message to log in.
The SIP2 does not send any response.  

In terminal #1, close the telnet connection.  Now terminal #2
receives its expected 941 message.

This problem was discovered by Lyrasis, a content provider that we are trying
to integrate with our library's Koha installation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

--- Comment #28 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

--- Comment #34 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31031] MarkLostItemsAsReturned does not work with batch item modification

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31031

--- Comment #3 from Christopher Brannon  ---
(In reply to Sara Brown from comment #2)
> In my testing, it depends on the lost status prior to the batch modification:
> 
> -If I add a lost status via batch item modification on an item that is
> checked out but not currently lost, it *does* check the item in
> -If I run batch item modification on a lost item that is still checked out
> to change it to a different lost status, it *doesn't* check the item in

Yes.  This is contrary to how the feature works on the item tab.  We take
advantage of the behavior (how it works on the item tab) so we can leave the
charge but check the item in so it can be deleted.  Doing this in the batch
tool would make this process easier.  However, the batch tool isn't working the
same way.

AND, if there is a way to delete items without removing the charge that is less
complicated, I welcome that.  But for now, this is what we have to do to retain
that charge.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 136463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136463=edit
Bug 24239: (QA follow-up) Make dbrev idempotent

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 136462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136462=edit
Bug 24239: DBIC update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 136461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136461=edit
Bug 24239: (QA follow-up) Rename date_due => due_date

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #135945|0   |1
is obsolete||

--- Comment #30 from Tomás Cohen Arazi  ---
Created attachment 136460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136460=edit
Bug 24239: Let the ILL module set ad hoc hard due dates

The Swedish Libris ILL backend lets librarians store a specific due date
when an ILL loan is received.

This patch set adds a new date_due column to the illrequets table that can be
used by the different backends to store a due date. If an illrequest has the
date due set, it will be used when the item is checked out instead of the
calculation
using the circulation conditions.

To test:
- Apply the patch and make sure the atomic database update is run
- Use the FreeForm backend to add one ILL request. Take note  of the
  illrequest_id of the request you created. We refer to this as
  "x" below.
- Connect a biblio (with biblionumber y), that has an item with a
  barcode, to the ILL request directly in the database:
  UPDATE illrequests SET biblio_id = y WHERE illrequest_id = x;
- Next we set the due date, this would normally be done by or from the backend.
  UPDATE illrequests SET date_due = "2023-01-01" WHERE illrequest_id = x;
- Go to circulation and issue the barcode of the item to the
  patron associated with the FreeForm ILL request. Verify that the
  loan gets a due date of 2023-01-01.
- Ideally: return the item and issue it again through SIP2 and SCO,
  and verify that the due date is still 2023-01-01.
- Verify that there are no regressions, so that regular calculation
  of due dates still work.
- prove t/db_dependent/Circulation.t

(Patch description, test plan and partial code credits to Magnus Enger)

Signed-off-by: Katrin Fischer 

(Patch description and test plan rewritten to reflect changes in development)

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #135944|0   |1
is obsolete||

--- Comment #29 from Tomás Cohen Arazi  ---
Created attachment 136459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136459=edit
Bug 24239: Unit tests

Signed-off-by: Katrin Fischer 
Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #135943|0   |1
is obsolete||

--- Comment #28 from Tomás Cohen Arazi  ---
Created attachment 136458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136458=edit
Bug 24239: Add column illrequests.date_due

Signed-off-by: Katrin Fischer 
Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31018] Allow patrons to batch cancel holds

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31018

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #1 from Barbara Johnson  ---
+1 That would be a great feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #133410|0   |1
is obsolete||

--- Comment #76 from Shi Yao Wang  ---
Created attachment 136457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136457=edit
Bug 27113: (follow-up) Move new CSS to main SCSS files

This patch removes the separate CSS files added for the autocomplete
feature and puts them into the "main" SCSS files. I think a separate
file isn't necessary because the amount of CSS it adds is so small.

I've also tweaked the style of the autocomplete menu shown when you use
the arrow keys to navigate through the autocomplete choices. I think the
previous white-on-light-green didn't have enough contrast.

To test you must rebuild the OPAC and staff client CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

Follow the previous test plan, being careful to observe how it
works when the autocomplete menu has been triggered and you use the
arrow keys to navigate through the results.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #133409|0   |1
is obsolete||

--- Comment #75 from Shi Yao Wang  ---
Created attachment 136456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136456=edit
Bug 27113: ElasticSearch: Autocomplete in input search

Usually the user knows only part of the title of the book or only the name of
the author, etc. When he start search something Koha (ElasticSearch) predicts
the rest of a word or expression which user is typing.  Autocomplete predicts
that thanks to index of ElasticSearch.

TEST PLAN
Important! In this patch we need to do reindex ElasticSearch. ElasticSearch
must have all information in his index.
1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch
!! APPLY PATCH !!
2. Mapping is good (Intranet -> Catalog -> Search engine configuration
(Elasticsearch) ).
!Recommended 'Reset Mapping'  -> 'Yes'
3. In your koha-conf.xml file you must have good  for
 and version ES
4. Update Preference:
./installer/data/mysql/updatedatabase.pl
If that passe good you can look the lines:
 - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl
 - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with
elasticsearch
5. After that we can look two options in the preferences:
-  IntranetAutocompleteElasticSearch;
-  OPACAutocompleteElasticSearch;
4. For add information in the index we must run script for reindexing:
./misc/search_tools/rebuild_elasticsearch.pl -v -d
5. Waiting for the end of indexing
6. Go on Preference and find :
-  IntranetAutocompleteElasticSearch;
-  OPACAutocompleteElasticSearch;
Value "Show" turn on autocomplete.
7. Now we have Autocomplete for Intranet/OPAC search input (advanced search
also).

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31032] Patron attributes branch limitations are unclear

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31032] New: Patron attributes branch limitations are unclear

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

Bug ID: 31032
   Summary: Patron attributes branch limitations are unclear
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When a patron attribute is limited to some branches it seems to mean:
1 - That attribute shows on moremember, and on opac to patron, but not in
patron edit screen if signed in at a different branch 
2 - It can be set for any patron from any branch on staff side, but only by
libraries from the limited list
3 - The code in extended_attributes appears to ignore all branch specific
mandatory attributes:
1707 my @required_attribute_types =
1708 Koha::Patron::Attribute::Types->search(
1709 {
1710 mandatory => 1,
1711 category_code => [ undef, $self->categorycode
],
1712
'borrower_attribute_types_branches.b_branchcode' =>
1713   undef,
1714 },
1715 { join => 'borrower_attribute_types_branches' }
1716 )->get_column('code');

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30478] Unexpected behavior in patrons' accounts when un-losing items via batch item modification

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30478

Sara Brown  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31031

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31031] MarkLostItemsAsReturned does not work with batch item modification

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31031

Sara Brown  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30478

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31031] MarkLostItemsAsReturned does not work with batch item modification

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31031

Sara Brown  changed:

   What|Removed |Added

 CC||sbr...@bywatersolutions.com

--- Comment #2 from Sara Brown  ---
In my testing, it depends on the lost status prior to the batch modification:

-If I add a lost status via batch item modification on an item that is checked
out but not currently lost, it *does* check the item in
-If I run batch item modification on a lost item that is still checked out to
change it to a different lost status, it *doesn't* check the item in

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
   Severity|normal  |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005

--- Comment #2 from Nick Clemens  ---
Created attachment 136455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136455=edit
Bug 31005: Don't inlcude attributes only required for other categories

To test:
 1 - Create a new patron attribute - check boxes to make it mandatory and
visible etc.
 2 - Limit it to 'Patron' or other category
 3 - Edit a patron not in that category
 4 - Attempt to save
 5 - 500 Error
 6 - Missing mandatory extended attribute (type=MAND)
 7 - Apply patch
 8 - Attempt aedit again
 9 - It succeeds!
10 - Edit a patron in the category with MAND required
11 - on the edit page, right click teh attribute - click 'delete node'
12 - Submit the form
13 - 500 error, but this time that's good, the attribute check works

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005

--- Comment #1 from Nick Clemens  ---
Created attachment 136454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136454=edit
Bug 31005: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31031] MarkLostItemsAsReturned does not work with batch item modification

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31031

--- Comment #1 from Christopher Brannon  ---
FYI, what we expect with the batch item modification is the same behavior we
get if we change the lost status on an individual item in the items tab.  With
this setting set, we can change the lost status of the item, and the item is
checked in, but the item charge is left on the patron account.  This is
ultimately what we want so that we can delete the item without removing the
charge.  We do this for long lost items that we need to get out of the system,
but still want the patron to pay for.

Currently, with just that setting set, it changes the status, but doesn't check
the item in.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30950] timepicker.inc is no longer used and should be removed

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30950

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30950] timepicker.inc is no longer used and should be removed

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30950

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #216 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31031] New: MarkLostItemsAsReturned does not work with batch item modification

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31031

Bug ID: 31031
   Summary: MarkLostItemsAsReturned does not work with batch item
modification
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If you choose the "from the batch item modification tool" in the
MarkLostItemsAsReturned preference, it does not work.  Status is changed as
usual, but it does not check the item(s) in.

This means for now, staff have to do this manually, one item at a time!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31030] New: Add a tab in patron account for pending ILL requests (staff)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31030

Bug ID: 31030
   Summary: Add a tab in patron account for pending ILL requests
(staff)
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de

When a user has placed ILL requests the open requests are only visible in the
ILL request history tab. 

This table can grow over time and is not a good way to quickly see any
outstanding requests.

We should add a new tab to the table at the bottom of the checkouts and details
tabs that displays the pending/awaiting pick-up ILL requests. 

The status to display might need to be defined in a system preference, as not
all backends do have a 'awaiting pickup' status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31029] New: ILL request ID in ILL history table should link to the ILL request if permissions allow for it

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31029

Bug ID: 31029
   Summary: ILL request ID in ILL history table should link to the
ILL request if permissions allow for it
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de

When a patron has placed ILL requests, they are shown in the patron account in
a new tab "ILL request history". 

From this table, there is no way to get to the ILL request in the ILL module.
We should link the request ID if the user has permissions to access the module.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23838] Add ability to view item renew history

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25466] Review 'problem_reports' column names and types

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25466

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31028

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Enhance 'Report a problem' to specify catalogue problems

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25466

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4461] Add a context-sensitive report a problem process

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||31028


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Enhance 'Report a problem' to specify catalogue problems
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Enhance 'Report a problem' to specify catalogue problems

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||4461


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
[Bug 4461] Add a context-sensitive report a problem process
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] New: Enhance 'Report a problem' to specify catalogue problems

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Bug ID: 31028
   Summary: Enhance 'Report a problem' to specify catalogue
problems
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

Currently we have a generic 'Report a problem' link at the bottom of all pages
on the OPAC.. however there's no easy way to report a problem about a specific
biblio.

We could add a more specific 'Report a problem with this record' option on the
details display and record the biblionumber so staff can quickly see the record
in context.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30947] Simplify date handling in CanbookBeIssued

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30947

--- Comment #10 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30947] Simplify date handling in CanbookBeIssued

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30947

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30998] [DOCS] Managing documentation tasks - simplify processes and integrate more with the development process

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30998

--- Comment #21 from Martin Renvoize  ---
Jonathan has highlighted that this may create a bit of bugzilla spam as part of
the process.. if every bug goes through this new state those of us that are cc
on a metric tonne of bugs will get an email for the change to 'Resolved fixed'

I like that we're encouraging 'someone' to look at every bug and assess whether
it needs a docs change or not.. but perhaps we could 'burden' the rmaints to be
a little picky and do some of the obvious filterings at 'Not backporting'
time.. when it's obviously a behind-the-scenes change that doesn't affect
workflow, UX or UI they could just skip straight to Resolved Fixed still
instead of using the middle 'Needs documenting' ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #42 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #41 from Tomás Cohen Arazi  ---
Created attachment 136453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136453=edit
Bug 25669: (follow-up) Minor fixes

Bulk doesn't support include_type_name, update requirement to
Search::Elasticseach@6.80, and remove data type name from tests.

Signed-off-by: Julian Maurice 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #40 from Tomás Cohen Arazi  ---
Created attachment 136452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136452=edit
Bug 25669: Use include_type_name parameter in ES calls

This patch includes the parameter:
include_type_name
on our ES calls

It removes the deprecation warning we are seeing, and should allow using ES7
with no other chnages.

For ES8 we will need to remove the hardcoded type,

I would suggest a second patch, with a new syspref "ElasticsearchLegacyType"
set to 'True' by default.
Description can explain that this must be set to false, and data reindexed
after upgrading to ES7 and before
upgrading to ES8 - then we can drop this pref when we drop ES7 support

When we drop ES6 support the pref can be set default true for upgrades, default
'false' for new installs

Signed-off-by: Julian Maurice 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #136418|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #136417|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30998] [DOCS] Managing documentation tasks - simplify processes and integrate more with the development process

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30998

--- Comment #20 from Martin Renvoize  ---
Found a clear example for this.. bug 30599.. backported and does require some
docs updates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

Martin Renvoize  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

--- Comment #11 from Martin Renvoize  ---
Holding off on updating the docs screenshots whilst we consider bug 31027

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||31027


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31027
[Bug 31027] Incorrect col sizing for Suggestions Management
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >