[Koha-bugs] [Bug 30663] POST /api/v1/suggestions won't honor suggestions limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30663 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|22.05.00,21.11.06 |22.05.00,21.11.06,21.05.16 released in|| CC||vic...@tuxayo.net Status|Pushed to stable|Needs documenting --- Comment #17 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 David Nind changed: What|Removed |Added Text to go in the||This fixes an error when a release notes||mandatory patron attribute ||limited to a specific ||patron category was causing ||a '500 error' when editing ||a patron not in that ||category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #56 from David Nind --- Testing notes: 1. I hope I have got the text for the release notes correct - I wasn't sure how to describe the changes to all the areas where the CSV export is used/was updated (apart from listing them all). 2. These are a couple of things I noted - these are outside the scope of this bug though: - In areas where DataTables is used (which has its own export function), is it now necessary to have an output section (output to screen and to file)? For example, the log viewer. - For the log viewer, the columns that are exported when using the output area export file are different to that displayed on the screen: . Screen: Date, Librarian, Module, Action, Object, Info, Interface . Output to file from the output selection area: action, barcode, biblioitemnumber, biblionumber, info, interface, module, object, timestamp, user . DataTables export: same as for screen 3. I only tested a couple of areas after the patch was applied: item search, log viewer, and the circulation report (after adding a few check outs). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 David Nind changed: What|Removed |Added Text to go in the||This fixes the CSV export release notes||so that data is correctly ||exported with a tab (\t) as ||the separator when this ||format is selected. This ||was incorrectly using the ||word 'tabulation' as the ||separator. (The default ||export format is set using ||the CSVdelimiter system ||preference.) In addition, ||the code where this is used ||was simplified (including ||several of the default ||reports, item search ||export, and the log ||viewer), and the default ||for CSVdelimiter was set to ||the comma separator. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 David Nind changed: What|Removed |Added Attachment #136475|0 |1 is obsolete|| --- Comment #55 from David Nind --- Created attachment 136537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136537=edit Bug 28327: (follow-up) Comma as default CSV delimiter Looks like most of existing code wants comma as default value. Also impact installer/data/mysql/mandatory/sysprefs.sql. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 David Nind changed: What|Removed |Added Attachment #136474|0 |1 is obsolete|| --- Comment #54 from David Nind --- Created attachment 136536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136536=edit Bug 28327: Unify CSV delimiter special behavior for tabulation System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch adds C4::Context->csv_delimiter to add a uniq metod dealing with this behavior. Also create Koha::Template::Plugin::Koha->CSVDelimiter for calls from Toolkit Templates. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' 4) Check with another delimiter Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 David Nind changed: What|Removed |Added Attachment #136473|0 |1 is obsolete|| --- Comment #53 from David Nind --- Created attachment 136535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136535=edit Bug 28327: Add unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29987] Manual credits are not recorded for a register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #3 from Katrin Fischer --- Wondering: Maybe we need the payment type pull down on the credits? That way libraries could say it was a cash or other? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29987] Manual credits are not recorded for a register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Katrin Fischer changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 29987, which changed state. Bug 29987 Summary: Manual credits are not recorded for a register https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29987] Manual credits are not recorded for a register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #2 from Katrin Fischer --- Hm, for me a credit means money exchanging hands. A patron might make a deposit that future fines/fees may be deducted from. Otherwise the option to pay out a credit would not make any sense...? I tihnk at least this needs a little more discussion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #228 from Katrin Fischer --- (In reply to Martin Renvoize from comment #227) > (In reply to Katrin Fischer from comment #224) > > 1) Adding to bundle and removing from bundle > > > > a) When adding a non-existing barcode like "eee", I get an unspecific error > > message: Failure: Check the logs for details (blocker) > > Fixed in follow-up attached Will test later when you have gone through that pile of comments :) > > b) The contrast is not really good on those errors I feel, maybe black text > > would be better on the colored background if that is an easy option. The > > light red background + red font is a little hard to read. (Accessibility) > > I stick to the bookstrap standard alerts here, I'll defer to Owen for > guidance.. it's an area I've felt we're really inconsistent all over the > place for ages and aught to improve... but I'd rather do a consistent job > everywhere in a distinct bug. That's fair, not a blocker for me. > > c) If you have a leading space in front of the barcode, it won't be > > recognized. This can happen easily if you copy and paste when forming the > > bundle and we deal with it in other places - I think we should do it here > > too for consistency (see also bug 30409) (normal) > > Fixed in a follow-up attached.. but it felt a bit wrong to use barcodedecode > here.. we should perhaps use JS instead on input. I am not stuck on a specific technical solution, just wanted to show that we try to make this behaviour consistent as an argument why we should ignore spaces here too :) > > d) Should we be able to change contents of a bundle while it is checked out? > > At the moment it's possible. Maybe a 'safety question'? > > (question/suggestion) > > Really good point.. I think it probably shouldn't be possible.. I'll have a > go at that next week and then continue with your review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 David Nind changed: What|Removed |Added Text to go in the||This enhancement to patron release notes||search remembers selections ||across multiple pages of ||search results and multiple ||different searches. The ||selected patrons can be ||added to a patron list or ||submitted for merging. ||Selections can be cleared ||manually and are ||automatically removed upon ||logout. Previously, ||selections were only ||remembered for the current ||page of search results. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 David Nind changed: What|Removed |Added Attachment #136097|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 136534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136534=edit Bug 29971: Remember selections across patron search pages This patch modifies the patron search results page to enable checkbox selections to be remembered in the browser's localStorage. This allows checkbox selections to persist while navigating through multiple pages of search results or even across multiple different searches. Once selected, these values can be added to a patron list or submitted for merging. Selections can be cleared manually and will be automatically be removed upon logout. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff interface perform a patron search in the Patrons module which will return multiple pages of results.. - Check checkboxes next to several patrons. - After one checkbox is checked the "Add to patron list" button should be enabled. - After more than one checkbox is checked the "Merge selected patrons" button should be enabled. - A box should appear in the toolbar above the search results, "Patrons selected: X" - Navigate to another page of results. Check more checkboxes. The "Patrons selected" information should be updated. - Return to the first page of results. Your original selections should still be checked. - Test that the correct set of patrons is used when clicking "Merge selected patrons" or when using "Add to patron list." - Click the "Clear" button in the selections information box. Checkboxes should be cleared on every page of results you previously checked. - The "Add to patron list" and "Merge selected patrons" buttons should become disabled. - After making several selections, log out of the staff interface and log back in, returning to the same patron search. Your selections should have been forgotten. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30883] Authorities merge is limited to 100 biblio with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30883 David Nind changed: What|Removed |Added Text to go in the||This fixes the hard-coded release notes||limit of 100 when merging ||authorities (when ||Elasticsearch is the search ||engine). When merging ||authorities where the term ||is used over 100 times, ||only the first 100 ||authorities would be merged ||and the old term deleted, ||irrespective of the value ||set in the ||AuthorityMergeLimit system ||preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 David Nind changed: What|Removed |Added Text to go in the||This fixes the command line release notes||script misc/commit_file.pl ||and manage staged MARC ||records tool in the staff ||interface so that imported ||records are processed. || ||The ||error message from The ||command line script was ||failing with this error ||message ||"DBIx::Class::Storage::DBI: ||:_exec_txn_begin(): DBI ||Exception: DBD::mysql::db ||begin_work failed: Already ||in a transaction at ||/kohadevbox/koha/C4/Biblio. ||pm line 303". In the staff ||interface, the processing ||of staged records would ||fail without any error ||messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind changed: What|Removed |Added Text to go in the||This fixes an error that release notes||occurred when viewing ||recalls log entries. The ||error was caused by the ||renaming of itemnumber, ||biblionumber, and ||branchcode attributes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31046] New: Floating Rules Based on Collection/Shelving Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31046 Bug ID: 31046 Summary: Floating Rules Based on Collection/Shelving Location Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: daniel.gag...@pueblolibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com PCCLD would like an option for floating rules to be based on the items shelving location or collection. This is how it would work. 1. A system preference allows for an Authorized Value/Shelfing Location or Collection to restrict floating. 2. The Western Research (Library A) location is added to the system preference and all material with the value does not float. 3. Item is cataloged with the Western Research shelving location. 4. Item is checked-out by a user at Library A. 5. The item is returned to Library B. 5. A message appears in Koha stating the item needs to return to Library A because it does not float. -Daniel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #27 from Tomás Cohen Arazi --- This was actually PQA :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31045] New: Add a housebound notification to staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31045 Bug ID: 31045 Summary: Add a housebound notification to staff interface Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: esth...@sodaspringsid.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Similar to the notification for curbside pickup or purchase suggestions, it would be nice to add a housebound delivery notification reminder. Otherwise staff would need to know, remember, or otherwise maintain a list of patrons who need housebound services outside of Koha. If combined with bug 26545 where patrons can update info or request a delivery through the OPAC, the overall module becomes much more useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28182] Elastic search exact authorities search includes punctuation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28182 Esther Melander changed: What|Removed |Added CC||esth...@sodaspringsid.com --- Comment #2 from Esther Melander --- I think this may be connected to bug 26472. It appears a wider discussion about how Elastic Search is handling punctuation is needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Esther Melander changed: What|Removed |Added CC||esth...@sodaspringsid.com --- Comment #1 from Esther Melander --- We are using Elastic Search and have noticed a similar problem for authorities with trailing periods. The trailing periods of an authority should be ignored in the sort, but are instead showing at the end of the result list. This problem appears in the advanced editor with the authority look-up (ctrl-shift-L) search. If you were to search for "Cooking." with the search parameter "contains" the result is not returned at the top of the list as expected, but rather towards the bottom. Further complicating, if you use the search parameter "starts with" or "exact" no results are returned. Do the same search without the trailing period "Cooking" and you will get the expected results. Also, Library of Congress is moving toward minimally punctuated authorities in which there is no closing punctuation on some authorities. As a result there are now existing authorities following different punctuation rules. Regardless of the source, trailing periods are throwing off the sort and I also suspect auto linking. Here are some additional papers on punctuation in authorities. https://www.oclc.org/bibformats/en/6xx.html shows examples of the 600 subject tags without punctuation at the end. These are links to a power point and paper on minimally punctuated records put out by Library of Congress. https://www.loc.gov/aba/pcc/sct/documents/GuidelinesMinimallyPunctuatedMARC-SCT-2020-01.pptx https://www.loc.gov/aba/pcc/documents/PCC-Guidelines-Minimally-Punctuated-MARC-Data.docx In any event, Elastic Search appears to need some refinement in how punctuation is handled to bring it into compliance with current practice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #6 from Owen Leonard --- Created attachment 136533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136533=edit Bug 31039: (follow-up) Wrap jQuery in $(document).ready() cashup_modal.js consists only of jQuery code, so the whole thing should be contained in a $(document).ready() function. This may or may not be contributing to the behavior this bug is trying to fix. Please note that this patch contains whitespace changes, so diff accordingly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Owen Leonard changed: What|Removed |Added Attachment #136488|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 136532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136532=edit Bug 31039: Remove duplicate modal printing JS This patch removes the erroneos duplication of the modal printing js. Test plan 1) Create some transactions and perform a cashup. 2) Open the cashup summary modal 3) Click 'Print' 4) Cancel the print dialogue 5) Note that the dialogue re-appears 6) Apply the patch 7) Repeat and note the dialogue closes first time now. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #16 from Lucas Gass --- backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #67 from Lucas Gass --- Thanks for the speedy rebase Nick! Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31044] New: Allow padding of call numbers in runtime parameters to compare to cn_sort values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31044 Bug ID: 31044 Summary: Allow padding of call numbers in runtime parameters to compare to cn_sort values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andre...@dubcolib.org QA Contact: testo...@bugs.koha-community.org When using SQL to find items in a call number range, best results are achieved by using cn_sort values rather than itemcallnumber values. However, most users won't know how to manually generate a padded call number for comparison to cn_sort values. It'd be helpful if we could set a runtime parameter that would allow a user to input an unpadded call number and select a classification scheme so Koha could then pad their call number and compare it to cn_sort. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #66 from Nick Clemens --- Created attachment 136531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136531=edit Bug 29325: [22.05.X] Fix commit_file.pl This patch fixes the broken commit_file.pl script. It doesn't deal with commiting the import from the UI. To test: 1. Pick a file for staging: $ kshell k$ misc/stage_file.pl --file TestDataImportKoha.mrc => SUCCESS: All good 2. Commit! k$ misc/commit_file.pl --batch-number 1 => FAIL: You see DBIx::Class::Storage::DBI::_exec_txn_begin(): DBI Exception: DBD::mysql::db begin_work failed: Already in a transaction at /kohadevbox/koha/C4/Biblio.pm line 303 3. Apply this patch 4. Repeat 2 => SUCCESS: Commit succeeds 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Bug 29325: (QA follow-up) Remove unexisting parameters of BatchRevertRecords There is no interval and callback as in BatchCommitRecords. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Bug 29325: Call progress callback one last time to confirm comppletion Previously after finishing the loop we were still in a transaction that never completed - we should report progress when done one final time to commit the last records To test: 1 - Stage a file with > 100 records 2 - Commit file 3 - Confirm batch is imported and no records left as staged Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Bug 29325: Fix import from staff client same test as before, but via the staff client Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Bug 29325: Handle the transaction in BatchCommitRecords Requiring the callback to commit was breaking reversion, and likely elsewhere Let's simplify and say that the routine iteself will handle the txn and commit TO test: 1 - Stage a file 2 - Import a file 3 - Revert a file 4 - Test staff client and command line Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Bug 29325: (QA follow-up) Tidy up tools/manage-marc-import.pl: sub commit_batch does no longer need $schema tools/manage-marc-import.pl: sub revert_batch: calling BatchRevertRecords which has no interval and callback misc/commit_file.pl: sub print_progress_and_commit does no longer commit, renamed misc/commit_file.pl: sub print_progress does no longer have a schema parameter misc/commit_file.pl: sub revert_batch reported deleted items as added Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31034] Bib image hidden after changes in bib detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31034 --- Comment #4 from Owen Leonard --- (In reply to Lucas Gass from comment #3) > Owen, were you using Chrome while testing? No, Firefox (102.0b9, macOS) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard --- The DataTable configuration should have been updated in the second patch, because the wrong columns have disabled sorting. Better than numeric column targeting is targeting by table header cell class. See other templates for " { 'bSortable': false, "bSearchable": false, 'aTargets': [ 'NoSort' ] }," -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30234] Serial local covers don't appear in the staff interface for other libraries with SeparateHoldings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #26 from Lucas Gass --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30972] "Replace existing covers" checkbox replaces ALL local covers for a biblio, not only the specific item's covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30520] Command line stage and import broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31043] New: Marc records imports stuck at 0% or 4%
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31043 Bug ID: 31043 Summary: Marc records imports stuck at 0% or 4% Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: jheanelle.fos...@nlj.gov.jm QA Contact: testo...@bugs.koha-community.org When trying to import staged marc records, it freezes at 4 %; another file freezes at 0%. Both files are over 6,000 records in length. The same happens on KOHA 21.11. On the contrary it accepts an import file of 1,700 records. Thanks for your assistance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #65 from Lucas Gass --- Won't apply cleanly to 22.05.x, can someone rebase this for 22.05 ASAP? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30883] Authorities merge is limited to 100 biblio with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30883 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #10 from Lucas Gass --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.x released in|| Status|Pushed to master|Pushed to stable --- Comment #21 from Lucas Gass --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #227 from Martin Renvoize --- (In reply to Katrin Fischer from comment #224) > 1) Adding to bundle and removing from bundle > > a) When adding a non-existing barcode like "eee", I get an unspecific error > message: Failure: Check the logs for details (blocker) Fixed in follow-up attached > b) The contrast is not really good on those errors I feel, maybe black text > would be better on the colored background if that is an easy option. The > light red background + red font is a little hard to read. (Accessibility) I stick to the bookstrap standard alerts here, I'll defer to Owen for guidance.. it's an area I've felt we're really inconsistent all over the place for ages and aught to improve... but I'd rather do a consistent job everywhere in a distinct bug. > c) If you have a leading space in front of the barcode, it won't be > recognized. This can happen easily if you copy and paste when forming the > bundle and we deal with it in other places - I think we should do it here > too for consistency (see also bug 30409) (normal) Fixed in a follow-up attached.. but it felt a bit wrong to use barcodedecode here.. we should perhaps use JS instead on input. > d) Should we be able to change contents of a bundle while it is checked out? > At the moment it's possible. Maybe a 'safety question'? (question/suggestion) Really good point.. I think it probably shouldn't be possible.. I'll have a go at that next week and then continue with your review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Lucas Gass --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #226 from Martin Renvoize --- Created attachment 136530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136530=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #225 from Martin Renvoize --- Created attachment 136529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136529=edit Bug 28854: (follow-up) Improve error for item not found -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #10 from Lucas Gass --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #18 from Lucas Gass --- backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #224 from Katrin Fischer --- Taking things for a test run now :) 1) Adding to bundle and removing from bundle a) When adding a non-existing barcode like "eee", I get an unspecific error message: Failure: Check the logs for details (blocker) b) The contrast is not really good on those errors I feel, maybe black text would be better on the colored background if that is an easy option. The light red background + red font is a little hard to read. (Accessibility) c) If you have a leading space in front of the barcode, it won't be recognized. This can happen easily if you copy and paste when forming the bundle and we deal with it in other places - I think we should do it here too for consistency (see also bug 30409) (normal) d) Should we be able to change contents of a bundle while it is checked out? At the moment it's possible. Maybe a 'safety question'? (question/suggestion) 2) Detail view of bundle Staff: a) From the bundle, there is no way to access the record that holds the bundled item. It would be nice if the Title could be linked in the table to allow for that. (suggestion) b) Collection is not resolved into the description in the table. (blocker) c) The item type column is empty, although the bundled item has an itemtype (blocker) d) If an item is lost, the date is formatted 'database' style. DateFormat is not applied: Last seen: 2022-06-24. DateFormat was set to DD.MM.. (blocker) e) As all items on collections now show the "Manage bundle" button, there is no way to see which item actually has bundled items. An idea here would be to add the number of bundled items to the button text. (strong suggestion?) * Empty: Manage bundle * 3 items bundled in: Manage bundle (3) f) If you have 2 items on a bundle record and "Manage bundle" the first, the button appearance changes and looks a bit 'pushed'. Now push the second "Manage bundle link". Both bundles are open now, but only the second button appears 'pushed'. Close the first bundle - the button looks pushed now... close the second, now you have a detail page with the second button looking pushed. This seems a bit of a confusing UI message. Maybe it was supposed to close the first when the second was opened? (question) 3) Detail view of bundled items a) Staff - bundled: I like the link from the status to the record there, although it makes the column quite wide for a longer one. It all has nice class mark-up, so would be easy to play with if needed. (comment) b) OPAC - bundled: We show "Added to bundle" but there is no way for the OPAC user to figure out "how to get it". I'd really like to see a way to navigate this here. Maybe we could link the status on the detail page to the bundle? (normal) 4) Checkout - nothing found there :) 5) Checkin - nothing to complain about here either. I like the new modal and its functionality. 6) Lost/return claims Checked in a bundle of 3 items, but one was 'lost'. a) Details tab: The return claim was created and in the patron account it shows Claims ( 0 1 ) on the tab. But when I click on the tab, there is nothing below. (blocker) b) Checkouts tab: The claim shows here, but also shows a little issue: In the notes column, it shows the text 'null'. And when I edit the note the text is there as well. c) When trying to resolve the checkout claim to "(Not lost)", I see an "Uncaught ReferenceError" in the console and the display of the claims table is not refreshed. When I reload the page, I can see that the claim was actually resolved. (blocker?) d) When the claim return is resolved to another lost status, like "Lost", the bundle view will show: Lost: 1. It should resolve to the description instead. (blocker) 7) Inventory on checkin feature - no complaints 8) Wish/suggestion list a) Some items are really similar if you don't see the subtitle, part_name and part_number. The bundle display and the modals in circulation only show title. I think it would make a lot of sense to add the other fields here to display as well. The use case here would be language materials for us. They often match on title ($a) and the important bit is in the other fields (work book, DVD, etc.9. They would also lend themselves to be 'bundled up'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30879] Add option to sort components by biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #23 from Martin Renvoize --- Awesome teamwork here guys, thankyou very much. All tested and working as expected from my side.. signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30879] Add option to sort components by biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize changed: What|Removed |Added Attachment #136427|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 136527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136527=edit Bug 30879: Handle index/sorting for UNIMARC Same as before, but test with UNIMARC setup Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30879] Add option to sort components by biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize changed: What|Removed |Added Attachment #136428|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 136528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136528=edit Bug 30879: Add option to syspref and update display To test: 1 - Update ComponentSortField system preference and verify biblionumber is an option 2 - Repeat test plan from 30327 and confirm sorting with biblionumber works Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30879] Add option to sort components by biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize changed: What|Removed |Added Attachment #136426|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 136526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136526=edit Bug 30879: Allow biblionumber as sort option in Elasticsearch Repeat previous tests with Elasticsearch engine You will need to reindex and reset mappings to pickup the changes form the file Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30879] Add option to sort components by biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize changed: What|Removed |Added Attachment #136425|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 136525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136525=edit Bug 30879: Add biblionumber as a sorting option in MARC21 This patch updates the Local-Number indexing by adding a zeropad option to Zebra indexing and adding this to the mapping files It also updates C4/Search.pm to allow biblionumber as an option To test: 1 - Apply patches 2 - copy etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl to /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 3 - Restart all, reindex zebra 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw=a_by=biblionumber_dsc=20 5 - Confirm records sorted correctly 6 - Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw=a_by=biblionumber_asc=20 7 - Confirm records sorted correctly Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #120 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 --- Comment #26 from Lucas Gass --- rebased for current master and reset to NSO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Lucas Gass changed: What|Removed |Added Attachment #135473|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Lucas Gass changed: What|Removed |Added Attachment #135473|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 --- Comment #25 from Lucas Gass --- Created attachment 136524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136524=edit Bug 22659: (follow-up) Add category to redirect Signed-off-by: Sally Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Lucas Gass changed: What|Removed |Added Attachment #135471|0 |1 is obsolete|| Attachment #135473|0 |1 is obsolete|| --- Comment #24 from Lucas Gass --- Created attachment 136523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136523=edit Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. Signed-off-by: Sally Signed-off-by: Sally Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #119 from Christopher Brannon --- Passed QA! This is a huge step forward! This has been needed for so long! Thank you Martin for this much needed field! I am really looking forward to seeing it in production! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31032] Patron attributes branch limitations are unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135189|0 |1 is obsolete|| --- Comment #118 from Martin Renvoize --- Created attachment 136522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136522=edit Bug 21978: Add middle_name to sysprefs.sql And add middle_name at the exact same places for installations with the default value. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135188|0 |1 is obsolete|| --- Comment #117 from Martin Renvoize --- Created attachment 136521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136521=edit Bug 21978: (follow-up) Stop using C4 methods in atomicupdate We should really only use C4::Context methods where absolutely necessary.. in this case is was simple to replace the get_preference and set_preference calls with SQL Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135187|0 |1 is obsolete|| --- Comment #116 from Martin Renvoize --- Created attachment 136520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136520=edit Bug 21978: (follow-up) Stop passing holdfor_cardnumber We not longer need to pass holdfor_cardnumber distinctly, we can just refer to holdfor_patron.cardnumber instead. This patch does that ;P Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135186|0 |1 is obsolete|| --- Comment #115 from Martin Renvoize --- Created attachment 136519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136519=edit Bug 21978: Use patron-title for holdfor handling in results This patch update the catalogue search results page to use the patron-title include to display patron titles for the 'Holds for' line in results and dropdown list. Test plan 1) Load patron account 2) Press search to hold 3) Perform a search which brings back 2+ items (e.g. 'street') 4) Note that on the search results it says: Place hold for 'firstname (othername) surname (cardnumber)' 5) Press the Place hold button and note that the dropdown includes "Place hold for 'firstname (othername) surname'" and "Forget 'firstname (othername) surname'" 6) Click through to an item from the results, press the 'Place hold' button and note the dropdown includes "Place hold for 'firstname (othername) surname'" Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135185|0 |1 is obsolete|| --- Comment #114 from Martin Renvoize --- Created attachment 136518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136518=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135184|0 |1 is obsolete|| --- Comment #113 from Martin Renvoize --- Created attachment 136517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136517=edit Bug 21978: Add middle_name into hold request autocomplete Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135183|0 |1 is obsolete|| --- Comment #112 from Martin Renvoize --- Created attachment 136516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136516=edit Bug 21978: Schema Update Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135182|0 |1 is obsolete|| --- Comment #111 from Martin Renvoize --- Created attachment 136515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136515=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135181|0 |1 is obsolete|| --- Comment #110 from Martin Renvoize --- Created attachment 136514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136514=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Attachment #135180|0 |1 is obsolete|| --- Comment #109 from Martin Renvoize --- Created attachment 136513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136513=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. Sponsored-by: Cheshire Libraries Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- I don't have valid OverDrive credentials, so wasn't able to test accessing the search results page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 David Nind changed: What|Removed |Added Attachment #136487|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 136512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136512=edit Bug 31040: jsTree image being used outside of jsTree plugin This patch corrects OPAC templates which tried to use a jsTree image asset which is missing following the jsTree upgrade (see Bug 11873). Templates should use /images/spinner-small.gif instead. To test, apply the patch and enable OpenLibrarySearch and populate OverDrive and RecordedBooks preferences with credentials (they don't have to be valid). Perform a catalog search in the OPAC. When the search results page first loads you should see messages about the services being queried: Searching OpenLibrary... Searching RecordedBoks... Searching OverDrive... Each should show a working "spinner" image while the queries are being performed. If you have valid OverDrive credentials you can try clicking through to the OverDrive search results page to confirm that the image is working on that page too. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #23 from Tomás Cohen Arazi --- Please rebase ASAP. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize --- No regressions found in my testing.. passing to QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What|Removed |Added Attachment #135499|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 136511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136511=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What|Removed |Added Attachment #135498|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 136510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136510=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What|Removed |Added Attachment #135497|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 136509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136509=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What|Removed |Added Attachment #135496|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 136508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136508=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What|Removed |Added Attachment #135495|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 136507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136507=edit Bug 30310: Add dayjs v1.11.2 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 Bug 30576 depends on bug 30626, which changed state. Bug 30626 Summary: DT REST API wrapper not building the filter query correctly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 --- Comment #9 from Nick Clemens --- Created attachment 136506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136506=edit Bug 10086: No way to go back to the basket on uncertain prices page Fixed the edit button placement to the right-most column and fixed the the displayed information in the order column from calling non-existent variables based on the item. To test: 1) Add an item with uncertain prices to a basket 2) Go to the vendor of the basket 3) Click Uncertain prices on the left 4) Notice 'edit' button does not look like a button, and basket name is not a link 5) Apply patch and refresh page 6) Basket name is now a link. Click to confirm it takes you to the right page 7) Edit button is now in edit column. Confirm it works as expected 8) Confirm you cannot sort on Edit column and the button does not wrap on a narrower browser 9) Check that the correct information is displayed for the order column (title, author, publisher code, publication year, copyright date, isbn) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Nick Clemens changed: What|Removed |Added Attachment #60167|0 |1 is obsolete|| Attachment #136471|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 136505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136505=edit Bug 10086: Link to go to basket from uncertain prices page This patch moves the Edit button into an Edit column, styled with bootstrap button and font awesome icon, and adds a link on the basket name to go to the basket. To test; 1) Add an item with uncertain prices to a basket 2) Go to the vendor of the basket 3) Click Uncertain prices on the left 4) Notice 'edit' button does not look like a button, and basket name is not a link 5) Apply patch and refresh page 6) Basket name is now a link. Click to confirm it takes you to the right page 7) Edit button is now in edit column. Confirm it works as expected 8) Confirm you cannot sort on Edit column and the button does not wrap on a narrower browser Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #11 from Martin Renvoize --- There wasn't actually a unit test for this.. either way. I'm not sure what the repercussions are of having a null deaccessioned in the database? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #4 from David Nind --- If it's any consolation, I didn't notice anything different after applying the patch. I use Firefox Developer Edition for testing (with the history/caching deleted each time it starts up). Maybe it only shows up on other operating systems? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 --- Comment #10 from Martin Renvoize --- Created attachment 136504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136504=edit Bug 29958: Do not set dateaccessioned on updates This patch reomves the second occurence of setting daeaccessioned today, outside of the 'add/update' handling in Koha::Item->store. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30852] article_requests missing index on debit_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30852 Tomás Cohen Arazi changed: What|Removed |Added Keywords|rel_22_05_candidate | Status|Pushed to master|RESOLVED CC||tomasco...@gmail.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Bug 27829 depends on bug 27619, which changed state. Bug 27619 Summary: Remove fr-FR installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27619] Remove fr-FR installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|RESOLVED CC||tomasco...@gmail.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #64 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/