[Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on the bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #9 from Katrin Fischer --- Sadly it looks like it was a while ago already, I have been seeing the issue on 20.11 in testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31052] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31052 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED Summary|How Do I Get Cash App ++|SPAM |with no delays? | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30830] Add Koha Objects for Koha Import Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30830 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in||21.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30831] Add unit test for BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30831 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in||21.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in||21.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31053] New: Add Context module to Koha/Encryption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31053
Bug ID: 31053
Summary: Add Context module to Koha/Encryption
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
perl -MKoha::Encryption -e'print Koha::Encryption->new->encrypt_hex("test");'
Can't locate object method "config" via package "C4::Context" (perhaps you
forgot to load "C4::Context"?) at /usr/share/koha/Koha/Encryption.pm line 56.
Trivial fix.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31053] Add Context module to Koha/Encryption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31053 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31053] Add Context module to Koha/Encryption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31053
--- Comment #1 from Marcel de Rooy ---
Created attachment 136567
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136567&action=edit
Bug 31053: Add Context module to Koha::Encryption
Test plan:
perl -MKoha::Encryption -e'print Koha::Encryption->new->encrypt_hex("test");'
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31053] Add Context module to Koha/Encryption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31053 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #26 from David Nind --- Apologies that it has taken me so long to retest. Summary from testing: - test plan for first patch: worked as expected - with no date of birth: does not appear in the list, no warnings on the patron page in staff interface [1] - with invalid age in category having age required: unitilized value message if upper age limit blank [2] - with invalid age in category having upper age limit: unitilized value message if upper age limit blank [3] - with invalid age in category having age required and upper age limit: works as expected Hopefully I haven't misinterpreted what is expected here! [1] with no date of birth ~ 1. Edited a staff patron (Henry: patron id = 19) and removed date of birth using the staff interface (dateofbirth shows as NULL in database) 2. Changed the staff patron category (S) so age required = 18-99 years 3. Does not appear in the list after running the script [2] with invalid age in category having age required 1. Edited a patron (Mary Burton - borrowernumber = 49) so that age is less than 24. 2. Changed patron category (PT) so age required = 24 and no maximum age (left blank). 3. Worked as expected except for 'Use of unitialized value...' message: ==> Use of uninitialized value in sprintf at misc/maintenance/search_for_data_inconsistencies.pl line 304. * Patron borrowernumber=49 has an invalid age of 21 for their category 'PT' (24-) 4. If they have the correct age (changed so they were older than 24), then no unitialized value message [3] with invalid age in category having upper age limit ~~~ 1. Edited a patron (Mary Burton - 49) so that age is more than 50. 2. Changed patron category (PT) so that no age required and upper age limit was 50. 3. Output as expected, except for 'Use of uninitialized value in sprintf...' message: ==> Use of uninitialized value in sprintf at misc/maintenance/search_for_data_inconsistencies.pl line 304. * Patron borrowernumber=49 has an invalid age of 58 for their category 'PT' (-50) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31053] Add Context module to Koha/Encryption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31053 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.druart+koha@gmail. ||com, tomasco...@gmail.com --- Comment #2 from Marcel de Rooy --- Taking liberty to switch to PQA rightaway -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Slava Shishkin changed: What|Removed |Added Attachment #136557|0 |1 is obsolete|| --- Comment #7 from Slava Shishkin --- Created attachment 136568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136568&action=edit Bug 31000: HOTFIX. Warn removal: param record_type can be undef Uninitialized value warning on /tools/export.pl when $record_type is undef Use of uninitialized value $record_type in string eq at /home/vagrant/kohaclone/tools/export.pl line 43. This warning in koha-testing-docker appears in: /var/log/koha/kohadev/intranet-error.log This patch fixes it by working when $record_type is Undef. The functionality still remains the same but warning doesn't flood error log. To reproduce: 1. Go to export data tool page (/tools/export.pl). 2. Check the error log and find the upper mentioned warning, check the timestamp to ensure that it was added when you loaded the page. 3. Apply the patch. 4. Load the page again, ensure that the same warning doesn't get added to the log file again. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 --- Comment #8 from Slava Shishkin --- David, thanks for the note. I added it to the patch description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 George Veranis changed: What|Removed |Added CC||gvera...@dataly.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31017] Add type field for vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- I couldn't see the vendor category on the vendor page. Is the expectation that libraries will choose either the free form text field, or use the authorized values? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 David Nind changed: What|Removed |Added Attachment #135793|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 136569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136569&action=edit Bug 30152: Elasticsearch - queries with OR don't work with limits When a query with "OR" is combined with a limit in Elasticsearch, the precedence is not preserved and the results are not correct. To test: 1) Set SearchEngine to Elasticsearch 2) Index records in Elasticsearch 3) Do an advanced search 4) Select More options 5) Enter a value for the first Keyword (e.g. Novels) 6) Change "and" before the second Keyword to "or" 7) Enter another value for the second Keyword (e.g. Prose) 8) Limit the search (e.g. Item type Books) 9) Do the search 10) Observe that records with the first keyword are not in the results 11) Apply the patch 12) Repeat the search 13) Observe that results with both keywords are in the results 14) Sign off Sponsored-by: Lund University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #68 from Katrin Fischer --- Hi Arthur and all, please back-port, this issue is present in 20.11 and pretty bad. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Kyle M Hall changed: What|Removed |Added Attachment #125189|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 136570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136570&action=edit Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Marcel de Rooy changed: What|Removed |Added Attachment #135287|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 136571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136571&action=edit Bug 28787: Send a notice with the TOTP token Bug 28786 let librarians enable a Two-factor authentication but force them to use an application to generate the TOTP token. This new enhancement add the ability to send an email containing the token to the patron once it's authenticaed The new notice template has the code '2FA_OTP_TOKEN' Test plan: - Setup the two-factor authentication (you need the config entry and the syspref ON) - Enable it for your logged in patron - Logout - Login and notice the new link "Send the code by email" - Click on it and confirm that you received an email with the code - Use the code to be fully logged in QA question: Is 400 the correct error code to tell the email has not been sent? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #14 from Marcel de Rooy --- Created attachment 136572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136572&action=edit Bug 28787: (follow-up) Changes in API auth, moved otp out of Letters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #15 from Marcel de Rooy --- Created attachment 136573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136573&action=edit Bug 28787: Typo authenticaction Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
--- Comment #16 from Marcel de Rooy ---
Generally, I have some doubts about the API path api/v1/auth/send_otp_token.
Sending a token is not a normally expected API action; it sounds like a
'misused verb'. You could think of creating a OTP code as an API action,
although we do not really add it as entity.
Apart from that it works. See some details hereunder.
[1] Your TODO - I am not sure about the following line, so I commented it but
let it in the patch
+#|| $c->req->url->to_abs->path eq '/api/v1/auth/send_otp_token' )
{
The otp path should go thru the chain. So this line should not be here although
commented. Removed it.
[2] Code segment from Koha/REST/V1/Auth.pm
if ( !$authorization and
( $params->{is_public} and
( C4::Context->preference('RESTPublicAnonymousRequests') or
$user) or $params->{is_plugin} )
or $pending_auth
This does not look good to me. Do we need pending_auth here ? If so, at least
we need parentheses etc. My follow-up removes the line now.
[3] This segment is incomplete:
elsif ($status eq "additional-auth-needed") {
if ( $c->req->url->to_abs->path eq '/api/v1/auth/send_otp_token' )
{
$user = Koha::Patrons->find( $session->param('number') );
$cookie_auth = 1;
$pending_auth = 1;
}
I think we should raise an exception if we have this status and the api path
does not match (so add an else). Removed pending_auth. Added a simple exception
in my follow-up.
[4] When I tested this API path via API keys, I got no authorization. I added a
permission catalogue (staff access) to get around that. If you dont have that
permission, we should not even send a code.
[5] Letters:
+if ( $content =~ m|\[% otp_token %\]| ) {
+my $patron = Koha::Patrons->find(C4::Context->userenv->{number});
+$tt_params->{otp_token} = Koha::Auth::TwoFactorAuth->new({patron =>
$patron})->code;
+}
This seems quite hacky. Why not pass it to Letters from the api module? Moved
it now.
This still needs updating the notice stuff.
[6] QA question: Is 400 the correct error code to tell the email has not been
sent?
I guess it is not. The client did nothing wrong. Maybe just plain 500? But
having some doubts about that too.
Or always 200/201 and refer for details to JSON body?
[7] TODO Hardcoded phrase: It is valid one minute.
[8] Functional question:
When you want to enable 2FA without a mobile phone, what should you do? There
is no link to send the code on that form.
[9] Current code:
C4::Context->config('encryption_key')
__ENCRYPTION_KEY__
Do we still need to replace it in koha-create by the actual key ?
Enable 2FA: Form text: Can't scan the code? To add the entry manually, provide
the following details to the application on your phone. Account: BRANCH Key:
BRANCH_EMAIL Time based: Yes
But the form does not show the Secret. So telling the user to enter the details
on their phone is useless?
Let me know if you agree with the follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Marcel de Rooy changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #17 from Marcel de Rooy --- Tomas, what do you think? See prev comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart changed: What|Removed |Added Depends on|30964 | Blocks||30964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 [Bug 30964] Add information about overdues and restrictions on the curbside pickup list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 Jonathan Druart changed: What|Removed |Added Blocks|30650 | Depends on||30650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Convert the Curbside Pickup plugin to Koha core -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 --- Comment #1 from Kyle M Hall --- Created attachment 136574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136574&action=edit Bug 31054 - Manual importing for EDIFACT invoices fails with a 500 error page Error in plack log is: Can't locate object method "new" via package "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin" (perhaps you forgot to load "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin"?) at /usr/share/koha/lib/Koha/EDI.pm line 219. Test Plan: 1) Set EdifactInvoiceImport to "Don't" 2) Configure an EDI vendor to use an EDIFACT plugin 3) Attempt to import an invoice file 4) You will be shown an error page 5) Apply this patch 6) Restart all the things! 7) Attempt to import another invoice file 8) It works! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 Kyle M Hall changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31054] New: Manual importing for EDIFACT invoices fails with a 500 error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 Bug ID: 31054 Summary: Manual importing for EDIFACT invoices fails with a 500 error page Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Error in plack log is: Can't locate object method "new" via package "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin" (perhaps you forgot to load "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin"?) at /usr/share/koha/lib/Koha/EDI.pm line 219. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136130|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 136575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136575&action=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136131|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 136576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136576&action=edit Bug 30578: Restore highlighting of patrons from the logged-in library Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136132|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 136577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136577&action=edit Bug 30578: Fix on-select for 2 occurrences Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136133|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart --- Created attachment 136578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136578&action=edit Bug 30578: Remove ajaxSetup from checkouts.js It was a IE fix apparently commit f021b52e71deaac0b46992fa33ef02f2b001e56d Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136134|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 136579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136579&action=edit Bug 30578: Fix multi-terms search Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #31 from Jonathan Druart --- Conflict with bug 21978 fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30196] Odd number of elements warning caused by dt_from_string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30196 --- Comment #4 from Blou --- I couldn't find a task here related to this bz. I'll create on and have shi yao look at it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963 Jonathan Druart changed: What|Removed |Added CC||alissa.desaintlaurent@univ- ||brest.fr, ||sonia.bo...@univ-lyon3.fr Status|ASSIGNED|In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 Jonathan Druart changed: What|Removed |Added CC||alissa.desaintlaurent@univ- ||brest.fr, ||sonia.bo...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart changed: What|Removed |Added CC||alissa.desaintlaurent@univ- ||brest.fr, ||sonia.bo...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart changed: What|Removed |Added CC||alissa.desaintlaurent@univ- ||brest.fr, ||sonia.bo...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30196] Odd number of elements warning caused by dt_from_string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30196 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com ||, shi-yao.w...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] New: Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Bug ID: 31055 Summary: Move koha-functions to /usr/sbin instead of koha/bin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org For a long time I am copying koha-functions.sh to /usr/share/koha/bin, since that is the location that the koha-* scripts expect it to be. It would be easier to put it in sbin too. Please tell me if there are valid legitimate reasons to do not so. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #1 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #0) > For a long time I am copying koha-functions.sh to /usr/share/koha/bin, since > that is the location that the koha-* scripts expect it to be. Talking about a gitified dev package install. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #2 from Marcel de Rooy --- Created attachment 136580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136580&action=edit Bug 31055: Update install location for koha-functions Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #3 from Marcel de Rooy --- Created attachment 136581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136581&action=edit Bug 31055: Change the source statement in koha scripts All references to koha-functions moved to sbin. git grep -l "bin/koha-functions.sh" | xargs sed -i -e's/usr\/share\/koha\/bin\/koha-functions.sh/usr\/sbin\/koha-functions.sh/g' Test plan: [1] Copy debian scripts to /usr/sbin locally. [2] Remove /usr/share/koha/bin/koha-functions.sh [3] Try a few scripts [4] git grep -E "[^s]bin/koha-funct". No occurrences? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Marcel de Rooy changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 --- Comment #1 from Jonathan Druart --- Created attachment 136582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136582&action=edit Bug 30964: Add 'restricted' and 'has overdues' on curbside pickup This patch adds more information about the patron's account on the curbside pickup list view. "Patron's account is restricted" if the patron is restricted "Patron has items overdue" if the patron has overdues Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #1 from Jonathan Druart --- Created attachment 136583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136583&action=edit Bug 30965: Add patron autocomplete search to curbside pickups Prior to this patch librarians had to know the cardnumber to search for patron. Now it's possible to search using the default patron autocomplete search (name, cardnumber, etc.) Test plan: Confirm that you can search for a patron without their cardnumber, select it and create a curbside pickup Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #9 from Jonathan Druart --- Created attachment 136584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136584&action=edit Bug 30650: DB changes Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #10 from Jonathan Druart --- Created attachment 136585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136585&action=edit Bug 30650: Koha classes Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #11 from Jonathan Druart --- Created attachment 136586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136586&action=edit Bug 30650: Add the CurbsidePickup syspref Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #13 from Jonathan Druart --- Created attachment 136588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136588&action=edit Bug 30650: Add link from the admin home page Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #15 from Jonathan Druart --- Created attachment 136590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136590&action=edit Bug 30650: Adjust atomic update Take into account existing installs using the plugins Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #12 from Jonathan Druart --- Created attachment 136587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136587&action=edit Bug 30650: Add new permission manage_curbside_pickups Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #16 from Jonathan Druart --- Created attachment 136591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136591&action=edit Bug 30650: Be more flexible with opening slots Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #17 from Jonathan Druart --- Created attachment 136592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136592&action=edit Bug 30650: Add some useful modules and tests Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #18 from Jonathan Druart --- Created attachment 136593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136593&action=edit Bug 30650: Add circulation page view This is the main commit message. A plugin already exists to manage curbside pickups. This new enhancehemnt is suggesting an implementation that is ready to be integrated into Koha core in order to provide the feature out-of-the-box. What has been done in this patch set: - Deal with installations using the existing plugin (upgrade the DB schema and migrate their data) - Add a new syspref (CurbsidePickup) and two new permissions: * parameters.manage_curbside_pickups * circulate.manage_curbside_pickups - Add an administration page to setup the configuration: admin/curbside_pickup.pl - Add a circulation page to manage the existing pickups, and create new one - Add a new OPAC view "your curbside pickups" to let patron manage their pickups, and create new ones - Add link from the "member" toolbar Improvements compared to the plugin: - Ability to create several pickup windows per day - Better display of the pickup times (not in a dropdown list) - Ability to disable pickups for patrons without waiting holds - Display pickups on the patron circulation page - Display pickups of the library on the homepage - Prevent pickup to be created on a holiday - Better error handling (exceptions) - Unit tests More improvements are already planned, see related bug reports. Test plan: After you setup the feature correctly from the administration view, you will be able to use the schedule curbside pickups from the staff interface, and from the OPAC interface if you selected "patron-scheduled pickup" A. Staff interface 1. Go to Circulation > Curbside pickups => If the logged-in user has the circulate.manage_curbside_pickups permission you will be able to create and manage curbside pickups 2. Go to a patron detail page and click the "Schedule pickup" button in the toolbar 3. If the patron has waiting holds and you selected "Enable for waiting holds only", of if you didn't select the option, you will be able to select a pickup date and slots to create a pickup. 4. Confirm that you cannot create more pickups per slot than what you defined in the curbside pickup configuration for this library 5. Confirm that you cannot create a pickup if the feature is disabled for the library 6. Notice that you can mark the pickup as "stage and ready", then "patron is outside" and finally "delivered today". You can also rollback the change 7. Notice that once the pickup has been marked as delivered, the item has been checked out and that a new notice has been generated (if the patron has "Hold_Filled" in their messaging preferences 8. Confirm that the information about current pickups is displayed on the circulation page of the patron B. OPAC interface 1. Create a new curbside pickup from the OPAC 2. Confirm that the same limitations as from the staff interface are in effect (waiting holds, number of patron per slots, etc.) 3. Confirm that you can cancel a pickup and alert staff of you arrival 4. Confirm that you cannot cancel a pickup that has been delivered already Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #19 from Jonathan Druart --- Created attachment 136594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136594&action=edit Bug 30650: Add dayjs and isSameOfAfter plugin Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #20 from Jonathan Druart --- Created attachment 136595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136595&action=edit Bug 30650: Add dayjs to opac Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #21 from Jonathan Druart --- Created attachment 136596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136596&action=edit Bug 30650: OPAC view Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #22 from Jonathan Druart --- Created attachment 136597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136597&action=edit Bug 30650: Add link from the member toolbar Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #23 from Jonathan Druart --- Created attachment 136598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136598&action=edit Bug 30650: Notify the patron when a new curbside pickup is created Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #24 from Jonathan Druart --- Created attachment 136599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136599&action=edit Bug 30650: DB - Add policy.enable_waiting_holds_only Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #25 from Jonathan Druart --- Created attachment 136600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136600&action=edit Bug 30650: Allow to restrict curbside pickup for waiting holds only Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #26 from Jonathan Druart --- Created attachment 136601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136601&action=edit Bug 30650: Add link from the mainpage Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #27 from Jonathan Druart --- Created attachment 136602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136602&action=edit Bug 30650: Add link from the circ patron page Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #28 from Jonathan Druart --- Created attachment 136603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136603&action=edit Bug 30650: Add filter_by_scheduled_today A bit of cleaning Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #29 from Jonathan Druart --- Created attachment 136604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136604&action=edit Bug 30650: Prevent pickup to be created on holiday We could improve this more and add disable the holiday from the date picker widget, but it's out of the scope here. Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #30 from Jonathan Druart --- Created attachment 136605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136605&action=edit Bug 30650: Split the permission We actually want one permission to manage the administration page, and one for the circulation module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #31 from Jonathan Druart --- Created attachment 136606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136606&action=edit Bug 30650: Select 'schedule a pickup' if no pickups yet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #32 from Jonathan Druart --- Created attachment 136607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136607&action=edit Bug 30650: Prevent browser crash if no pickup interval set Don't get stuck in an infinite loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #33 from Jonathan Druart --- Created attachment 136608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136608&action=edit Bug 30650: Compiled CSS Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #34 from Jonathan Druart --- Created attachment 136609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136609&action=edit Bug 30650: DBIC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #35 from Jonathan Druart --- Created attachment 136610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136610&action=edit Bug 30650: DBIC specific Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #2 from Jonathan Druart --- This is ready for testing, see test plans in patch "Bug 30650: Admin page" and "Bug 30650: Add circulation page view" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #36 from Jonathan Druart --- This is ready for testing, see test plans in patches "Bug 30650: Admin page" and "Bug 30650: Add circulation page view" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #14 from Jonathan Druart --- Created attachment 136589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136589&action=edit Bug 30650: Admin page This patch adds a new page in the administration area to manage curbside pickups. Test plan: 1. Enable the new CurbsidePickup syspref 2. Go to Administration > Curbside pickups => If the logged-in user has the manage_curbside_pickups permission you should see the administration view 3. Enable the feature for some libraries and configure it. a. You must define a "pickup interval" and a "maximum patrons per interval" values. b. If "Patron-scheduled pickup" is enabled, patrons will be able to schedule curbside pickups from the OPAC c. If "Enable for waiting holds only" is enabled, only patron with waiting holds will be allowed to schedule curbside pickups d. In the bottom part of the form you can define the slots available for curbside pickups. e. Save Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 David Nind changed: What|Removed |Added Attachment #136570|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 136611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136611&action=edit Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31053] Add Context module to Koha/Encryption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31053 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31053] Add Context module to Koha/Encryption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31053 --- Comment #3 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 --- Comment #13 from Shi Yao Wang --- Created attachment 136612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136612&action=edit Bug 29922: Make get_search_groups return results sorted by title get_search_groups from Koha/Library/Groups.pm returns library groups sorted by title. Test plan: 1- Go to administration > library groups and create multiple library groups with different names (e.g. AGroup, BGroup, ÄGroup, etc.). Make sure to tick "Use for OPAC search groups" checkbox. 2- Go to advanced search in OPAC. 3- Under "Groups of librairies" , click the select button. 4- Notice that the library groups are not in alphabetical order. 5- Apply the patch. 6- Notice that the library groups are in alphabetical order. 7- Run `prove t/db_dependent/LibraryGroups.t` and all test should pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com Attachment #131444|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Shi Yao Wang changed: What|Removed |Added Attachment #131343|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #136344|0 |1 is obsolete|| --- Comment #229 from Martin Renvoize --- Created attachment 136613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136613&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #136345|0 |1 is obsolete|| --- Comment #230 from Martin Renvoize --- Created attachment 136614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136614&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #136346|0 |1 is obsolete|| --- Comment #231 from Martin Renvoize --- Created attachment 136615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136615&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #136348|0 |1 is obsolete|| --- Comment #233 from Martin Renvoize --- Created attachment 136617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136617&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #136349|0 |1 is obsolete|| --- Comment #234 from Martin Renvoize --- Created attachment 136618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136618&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #136350|0 |1 is obsolete|| --- Comment #235 from Martin Renvoize --- Created attachment 136619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136619&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #136351|0 |1 is obsolete|| --- Comment #236 from Martin Renvoize --- Created attachment 136620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136620&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
