[Koha-bugs] [Bug 31075] Obscure notice handling in overdue_notices.pl needs to be improved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075 Marcel de Rooy changed: What|Removed |Added Summary|Script overdue_notices.pl |Obscure notice handling in |should use |overdue_notices.pl needs to |GetPreparedLetter |be improved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31075] Script overdue_notices.pl should use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075 Marcel de Rooy changed: What|Removed |Added Severity|major |normal --- Comment #2 from Marcel de Rooy --- Lowering severity because I just now see that parse_overdues_letter does call GetPreparedLetter after all. This code really needs to be improved. Obscure stuff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31075] Script overdue_notices.pl should use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075 Marcel de Rooy changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com --- Comment #1 from Marcel de Rooy --- ccing Nick Tomas Jonathan -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29354] overdue_notices.pl should be able to send an attachment as HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354 --- Comment #1 from Marcel de Rooy --- I opened bug 31075 for a wider scope -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31075] Script overdue_notices.pl should use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29354 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29354] overdue_notices.pl should be able to send an attachment as HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31075 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31075] New: Script overdue_notices.pl should use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075
Bug ID: 31075
Summary: Script overdue_notices.pl should use GetPreparedLetter
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
The overdue_notices.pl script contains a lot of code for letter/notice handling
that really should not be there. Some regular notice constructs do not work
since it is doing its own thing.
Look at this example:
my $letter = parse_overdues_letter(
{ letter_code => $overdue_rules->{"letter$i"},
borrowernumber => $borrowernumber,
branchcode => $branchcode,
items => \@items,
substitute => {# this appears to be a hack
to overcome incomplete features in this code.
bib =>
$library->branchname, # maybe 'bib' is a typo for 'lib'?
'items.content' => $titles,
'count' => $itemcount,
},
# If there is no template defined for the requested
letter
# Fallback on the original type
message_transport_type => $letter_exists ?
$effective_mtt : $mtt,
}
);
The comment talks about a hack to overcome incomplete features.
I did mark this as major, and not enhancement for refactoring.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31064] Local login is difficult to style using CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31064 --- Comment #6 from David Cook --- (In reply to Fridolin Somers from comment #5) > Trivial but very useful, PQA > > BTW : a class on Local login would also be very useful. I was thinking that too. Once this one is in, I could do another patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30580] GetItemsAvailableToFillHoldRequestsForBib should get transfers during initial query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Michal Urban changed: What|Removed |Added CC||michalurban...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30580] GetItemsAvailableToFillHoldRequestsForBib should get transfers during initial query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Michal Urban changed: What|Removed |Added Attachment #133560|0 |1 is obsolete|| --- Comment #2 from Michal Urban --- Created attachment 136797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136797&action=edit Bug 30580: Don't use GetTransfers in GetItemsAvailableToFillHoldRequestsForBib This patch simply moves the check for transfers into the initial query Test result: Works as intended To test: 1 - Place some holds that show in the holds queue 2 - Add a manual transfer to one item 3 - Confirm it no longer hsows in the queue 4 - Apply patch 5 - Confirm item still does not appear in the queue Signed-off-by: Michal Urban -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Caroline Cyr La Rose --- Just marking this as Failed QA to correct the typo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 --- Comment #14 from Caroline Cyr La Rose --- I was wondering if "when importing a record" also works with the record file staging/importing tool or if it only works with Z39.50? Since I was unable to test that patch with Z39.50, I didn't try with the staging/importing tool. If it's only Z39.50, it should say so in the syspref, and add an option for when importing a file. If it's both, I will try to test that too when I am able. Thanks! Caroline (Sorry for spamming, I'm done now... :) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31017] Add type field for vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Rachael changed: What|Removed |Added CC||rachael.lar...@inlibro.com --- Comment #7 from Rachael --- Tester par Rachael Laritz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Caroline Cyr La Rose --- I'm in the second test plan, step 4, I unchecked "when importing a record", but my Z39.50 record had the framework default in it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 --- Comment #12 from Caroline Cyr La Rose --- Still in the first test plan, I'm at step 16 (Repeat steps 4 to 15 with authority types and authority records). I think that should be Repeat steps 4-12 as steps 13-15 deal with changing the framework, but this is not a possibility in authority records (unless I don't see it? But it wouldn't be logical...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #11 from Caroline Cyr La Rose --- Hi Aleisha! I'm trying to test this using a sandbox. I was able to get the original behaviour (behaviour without the patch) and now I'm playing with the different options of the system preference. I'm at step 7 of the first test plan. When I uncheck the option so that no options are selected and save, I have a message saying 'Nothing to save'. I do have the message '(modified)' next to the pref name, but I am unable to change the pref to no options. I can save without problem when I check at least one option. I will continue the other steps, but I will not be able to sign off because I can't test without options... Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices and manual credits in patron accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335
Rachael changed:
What|Removed |Added
Attachment #132031|0 |1
is obsolete||
--- Comment #2 from Rachael ---
Created attachment 136796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136796&action=edit
Bug 30335: Add classes to invoice/credit tabs on patron accouting pages
To test:
1. Apply patch and go to the patron accounting page.
2. Notice the class names for each list element on the page.
3. You can use the following CSS to try hiding each of the tabs:
.transactions { display: none; }
.makepayment { display: none; }
.manualinvoice { display: none; }
.manualcredit { display: none; }
Signed-off-by: rachael
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices and manual credits in patron accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335 Rachael changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30403] Update notforloan status also on check out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Rachael changed: What|Removed |Added CC||rachael.lar...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Rachael --- patch does not apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31017] Add type field for vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #6 from David Nind --- (In reply to Caroline Cyr La Rose from comment #5) > To answer David' second comment, I think it is ok to have either free text > or authorised value. It is the same about everywhere in Koha: patron sort > fields, acquisitions statistical fields, drop downs in MARC frameworks, etc. > ... Thanks Caroline. I hadn't noticed this before, and this was the first time I'd come across it. (I've been living such a sheltered life in Kohaland!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30411] Add separate shelving location column to Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Rachael changed: What|Removed |Added CC||rachael.lar...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Rachael --- patch does not apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31074] New: Plugin metadata is kept in cache after uninstalling a plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 Bug ID: 31074 Summary: Plugin metadata is kept in cache after uninstalling a plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: vic...@tuxayo.net QA Contact: testo...@bugs.koha-community.org == test plan == 1. Install a plugin, like the kitchen sink https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases 2. Modify the .kpz and in KitchenSink.pm, change MINIMUN_VERSION 3. Uninstall the plugin 4. Install the new version 5. The Minimum Koha version column still lists the old version 6. restart services 7. The Minimum Koha version column is correct now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #17 from Victor Grousset/tuxayo --- (In reply to Martin Renvoize from comment #15) > This is all very cool thoughts.. but this bug is more around dealing with > Koha version comparisons than it is about Plugin versioning ;). That's why I was confused XD === I downloaded the kitchen sink plugin, changed our $MINIMUM_VERSION = "21.05"; ↓↓↓ our $MINIMUM_VERSION = "23.05.01.001"; I see the warning in the UI and Minimum Koha version: 23.05.01.001 But I don't get a warning in the logs. Any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |isobel.graha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785 --- Comment #1 from Isobel Graham --- Created attachment 136795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136795&action=edit Bug 30785: Fixed typo in SIP2SortBinMapping To test: 1. Go to the admin page. 2. Search for the above preference. 3. Confirm that "Will" is now spelled correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30269] Use objects directly to display holds on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30269 --- Comment #10 from Marie-Luce Laflamme --- Created attachment 136794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136794&action=edit hold page incorrect display after applying the patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30269] Use objects directly to display holds on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30269 Marie-Luce Laflamme changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||marie-luce.laflamme@inlibro ||.com --- Comment #9 from Marie-Luce Laflamme --- Patch doesn't apply. I've followed the test plan 1 - Place many holds on a record 2 - Set some waiting, some in transit 3 - View the holds page and note loading time 4 - Apply patch 5 - Reload 6 - Page appears the same 7 - Load time is faster (more with more holds) Somehow, the reserve/request.pl?biblionumber= display changed after applying the patch. It shows up a new button with the bugnumber. see my test in this sandboxe https://staff-test.sandbox.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblionumber=144 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Kyle M Hall changed: What|Removed |Added Attachment #136783|0 |1 is obsolete|| --- Comment #24 from Kyle M Hall --- Created attachment 136793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136793&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #13 from Caroline Cyr La Rose --- (In reply to Caroline Cyr La Rose from comment #12) > Is this still to be tested or is it a duplicate or bug 27272? *of -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #12 from Caroline Cyr La Rose --- Is this still to be tested or is it a duplicate or bug 27272? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibault Keromnès changed: What|Removed |Added CC||thibault.keromnes@univ-pari ||s8.fr Status|Needs Signoff |Failed QA --- Comment #34 from Thibault Keromnès --- I have the same issue as David (from a sandbox). The patch applies but the error happens when trying to replace authorities (even by the method that works without the patch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31017] Add type field for vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #5 from Caroline Cyr La Rose --- Hi Nick! 1) I second David in saying that the vendor type should appear on the vendor details page (supplier.pl). Right now, it only appears in booksellers.pl 2) I would add a description to the authorised value category. Maybe something like "Values that can be entered to fill in the 'Vendor type' field in the acquisitions module, that can be used for statistical purposes" (I copied from Bsort1, but feel free to put whatever description you think is best) To answer David' second comment, I think it is ok to have either free text or authorised value. It is the same about everywhere in Koha: patron sort fields, acquisitions statistical fields, drop downs in MARC frameworks, etc. In all those cases, if you add values in the AV category, the free text field will become a drop down and you cannot choose to have both free text and dropdown. The only exceptions AFAIK are in the MARC frameworks, where it is now possible to add values on the fly while cataloging; the suggestion approval/refusal reasons, where there is an 'Other' option that, when selected opens a free text field; and for the cities and towns in patron files, where you can choose from the drop down or manually enter a city. But that last one (cities) is not authorised values... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|katrin.fisc...@bsz-bw.de|k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #16 from Caroline Cyr La Rose --- I tried to test, but I am unable to get the original "problematic" behaviour. My rules are as follows: Patron category: Teacher Item type: Books Current checkouts allowed: 10 Current on-site checkouts allowed: 10 Loan period: 10 Hard due date: None defined (I didn't fill out anything else) Patron category: Teacher Item type: All Current checkouts allowed: 10 Current on-site checkouts allowed: 10 Loan period: 10 Hard due date : Exactly on 2022-06-30 (I didn't fill out anything else) I also have the All/All rule that comes with a sandbox Patron category: All Item type: All Current checkouts allowed: 5 Current on-site checkouts allowed: 5 Loan period: 5 Hard due date: None defined (etc.) I checked out 303857 (item-level itype = Music) to 23529000139858, and the due date was 2022-06-30 (today) I checked out 310114 (item-level itype = Books) to the same patron and the due date was 2022-07-10 (ten days from now) I'm not sure what I did differently than the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_21_05_candidate, ||rel_21_11_candidate, ||rel_22_05_candidate CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_21_05_candidate, ||rel_21_11_candidate, ||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_21_05_candidate, ||rel_21_11_candidate, ||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #41 from Tomás Cohen Arazi --- Created attachment 136792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136792&action=edit [DO NOT PUSH] Bug 30889: Schema update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 136791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136791&action=edit Bug 30889: Add comment for the new DB field Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 136790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136790&action=edit Bug 30889: Unit tests - process This patch adds corresponding unit tests for the 'process' side of this patchset. We check that the Context for the job to run in as set from the Job context recorded at enqueue time. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 136789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136789&action=edit Bug 30889: Unit tests This patch adds a unit test for the 'enqueue' part of the bug. We check that the mocked context (and interface) are recorded with the job enqueue in the new 'context' field. We do not yet test the 'process' end, where we then read the context out and set the job Context from it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 136788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136788&action=edit Bug 30889: Fix atomic update permissions Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 136787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136787&action=edit Bug 30889: (follow-up) Record and use context in background_jobs This patch records the current context to the background_jobs table at enqueue time and then uses that record to set the context at process time. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 136786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136786&action=edit Bug 30889: (follow-up) Add context field to background_jobs This patch adds a new 'context' field to the background_jobs table to record the context in which the job was queued. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 136785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136785&action=edit Bug 30889: Set interface to 'intranet' Is that correct? Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 136784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136784&action=edit Bug 30889: Set userenv for background jobs We need to set the userenv when we process the jobs. It is useful for stats (at least) Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo --- > I couldn't place a hold : I've got this error : "Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1445". Note: this is without the patch > And I can't run the cronjob build_holds_queue Note: this is from a sandbox (we are doing a test session with librarians ^^) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136376|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136375|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136299|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136298|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136297|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136296|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136295|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136294|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 catherine.dupuy-le...@univ-rennes1.fr changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||catherine.dupuy-lenen@univ- ||rennes1.fr --- Comment #3 from catherine.dupuy-le...@univ-rennes1.fr --- I couldn't place a hold : I've got this error : "Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1445". And I can't run the cronjob build_holds_queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #163 from Lucas Gass --- When I add a custom page for the 'OPAC' or 'Librarian and OPAC' I do not see a news item but I do see the empty news container and the RSS container (.rssnews-container) and words like "RSS feed for Centerville and system-wide library news". Can that be removed if we have no actual news items? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- Marie-Luce and Axelle tested at the same time and one signoff line was lost. I just reattached the patches with both signoff lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs Signoff |Signed Off --- Comment #10 from Caroline Cyr La Rose --- 7 and 8 work with the patch! Thanks Andrew and Martin, this is major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 136783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136783&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 ByWater Sandboxes changed: What|Removed |Added Attachment #134899|0 |1 is obsolete|| --- Comment #9 from ByWater Sandboxes --- Created attachment 136782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136782&action=edit Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate Signed-off-by: Caroline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136773|0 |1 is obsolete|| --- Comment #13 from Victor Grousset/tuxayo --- Created attachment 136781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136781&action=edit Bug 31051: Show patron savings on the OPAC This new feature shows a patron how much they have saved by using the library rather than purchasing items. Savings are calculated based on item replacement prices. The system preference allows you to choose where to display the savings - the user page, the summary box on the OPAC homepage, or the checkout history page. To test: 1. Update database and restart services 2. Confirm the new OPACShowSavings system preference is found in the OPAC tab of Administration -> global system preferences. There should be no options selected. 3. Find a patron with a checkout history, or check out a few items to a patron. 4. Test with different values of OPACShowSavings and confirm that savings are shown in the expected places. Sponsored-by: Horowhenua Libraries Trust Signed-off-by: Marie-Luce Signed-off-by: Axelle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 ByWater Sandboxes changed: What|Removed |Added Attachment #134898|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 136780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136780&action=edit Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. Signed-off-by: Caroline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136772|0 |1 is obsolete|| --- Comment #12 from Victor Grousset/tuxayo --- Created attachment 136779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136779&action=edit Bug 31051: Add OPACShowSavings system preference Signed-off-by: Marie-Luce Signed-off-by: Axelle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135762|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135772|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 136778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136778&action=edit Bug 30918: Allow passing filtered record to get_marc_notes This patch does the absolute bare minimum to prevent private notes from appearing on the OPAC. Test plan 1. Go to Koha Administration -> Koha bibliographic frameworks 2. View the MARC structure for your BKS framework (or something else) 3. Search for tag 583, edit subfields 4. Go to subfield 'x' - nonpublic note. Confirm the OPAC visibility checkbox is UNCHECKED. 5. Edit or create a record using the BKS framework. Put a note in the 583$x. 6. View this record in the OPAC 7. Go to the Title notes tab. Confirm the non-public note is showing, even though the framework says it should not be visible via the OPAC. 8. Apply patch 9. Confirm the non-public note is no longer visible Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 --- Comment #52 from Tomás Cohen Arazi --- Created attachment 136777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136777&action=edit Bug 30848: Add exec flag to test Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 --- Comment #51 from Tomás Cohen Arazi --- Created attachment 136776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136776&action=edit Bug 30848: Fix issue exposed by unit tests This patch changes the 'map' to a simple for loop so that we can easily map multiple subfields to a field without overwriting the first previous subfields in the structure. Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 --- Comment #50 from Tomás Cohen Arazi --- Created attachment 136775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136775&action=edit Bug 30848: Expand unit tests Add to the unit tests to test Library and Itemtype expansions as well as linking multiple subfields of the same marc field to such expansions. Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848
--- Comment #49 from Tomás Cohen Arazi ---
Created attachment 136774
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136774&action=edit
Bug 30848: Add an ExpandCodedFields RecordProcessor filter
This patch introduces a RecordProcessor filter for MARC::Record objects
that replaces Koha codes with descriptions in the MARC::Record passed to the
processor.
Target usage:
my $biblio = Koha::Biblios->find(
$biblio_id,
{ prefetch => [ metadata ] }
);
my $record = $biblio->metadata->record;
my $processor = Koha::RecordProcessor->new(
{
filters => ('ExpandCodedFields'),
options => {
interface => 'opac',
frameworkcode => $biblio->frameworkcode
}
}
);
$processor->process( $record );
Test plan
* Read the included unit test and confirm it makes sense and passes
Signed-off-by: Nick Clemens
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136262|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136261|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136260|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136259|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Medium patch|Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 sandbo...@biblibre.com changed: What|Removed |Added Attachment #136770|0 |1 is obsolete|| --- Comment #11 from sandbo...@biblibre.com --- Created attachment 136773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136773&action=edit Bug 31051: Show patron savings on the OPAC This new feature shows a patron how much they have saved by using the library rather than purchasing items. Savings are calculated based on item replacement prices. The system preference allows you to choose where to display the savings - the user page, the summary box on the OPAC homepage, or the checkout history page. To test: 1. Update database and restart services 2. Confirm the new OPACShowSavings system preference is found in the OPAC tab of Administration -> global system preferences. There should be no options selected. 3. Find a patron with a checkout history, or check out a few items to a patron. 4. Test with different values of OPACShowSavings and confirm that savings are shown in the expected places. Sponsored-by: Horowhenua Libraries Trust Signed-off-by: Axelle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 sandbo...@biblibre.com changed: What|Removed |Added Attachment #136698|0 |1 is obsolete|| --- Comment #10 from sandbo...@biblibre.com --- Created attachment 136772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136772&action=edit Bug 31051: Add OPACShowSavings system preference Signed-off-by: Axelle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Axelle Aix-Marseille Université changed: What|Removed |Added CC||axelle.clari...@univ-amu.fr --- Comment #9 from Axelle Aix-Marseille Université --- Tested with a UNIMARC sandbox : items replacement prices = 995$g in UNIMARC. It works well too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31073] ThingISBN API being unavailable blocks loading of opac-detail when API can't be found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31073 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #1 from Liz Rea --- Specifically, when the patron clicks on the detail many times, because it appears that the page didn't load the first time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30268] When creating an order from a staged file, mandatory item subfields that are empty do not block form submission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Thibault Keromnès changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||thibault.keromnes@univ-pari ||s8.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31073] New: ThingISBN API being unavailable blocks loading of opac-detail when API can't be found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31073 Bug ID: 31073 Summary: ThingISBN API being unavailable blocks loading of opac-detail when API can't be found Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org We've noticed that when the ThingISBN API is running slowly or down, that libraries that enable this preference can cause themselves a denial of service when patrons try to load the detail page of a book that has Editions. It would be good to make this not block the loading of the page, the Editions tab isn't the primary viewed tab anyway - it would be fine to load in it's data in the background. Thanks for looking, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30268] When creating an order from a staged file, mandatory item subfields that are empty do not block form submission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #131557|0 |1
is obsolete||
--- Comment #2 from sandbo...@biblibre.com ---
Created attachment 136771
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136771&action=edit
Bug 30268: Check mandatory fields in addorderiso2709.pl
Test plan:
1. Make sure you have mandatory item subfields in the MARC bibliographic
framework used in acquisitions ("ACQ" if it exists, the default framework
otherwise).
2. Use the "Stage MARC records for import" tool to upload a file. Do not import
the bibliographic records.
3. Create a new acquisition basket ("Create items when:" must be set to
"placing an order") and add a new order from a staged file
4. Select the file you just uploaded
5. In the "Items information" tab, make sure at least one mandatory subfield is
empty
6. Try to submit the form. If there are errors about other mandatory fields
(like the fund for instance), fix those errors and resubmit. There should be
an error message about mandatory item subfields.
7. Enter a value for the mandatory item subfields and resubmit the form. Verify
that the order and the item have been correctly created.
Signed-off-by: Thibault Kero
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 ByWater Sandboxes changed: What|Removed |Added Attachment #136699|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 136770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136770&action=edit Bug 31051: Show patron savings on the OPAC This new feature shows a patron how much they have saved by using the library rather than purchasing items. Savings are calculated based on item replacement prices. The system preference allows you to choose where to display the savings - the user page, the summary box on the OPAC homepage, or the checkout history page. To test: 1. Update database and restart services 2. Confirm the new OPACShowSavings system preference is found in the OPAC tab of Administration -> global system preferences. There should be no options selected. 3. Find a patron with a checkout history, or check out a few items to a patron. 4. Test with different values of OPACShowSavings and confirm that savings are shown in the expected places. Sponsored-by: Horowhenua Libraries Trust Signed-off-by: Marie-Luce -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs Signoff |Failed QA --- Comment #4 from Caroline Cyr La Rose --- I agree that the test plan is not very clear. What are we supposed to put in 580 (and which subfield(s)?) Are we supposed to put ; ? I catalogued my authority's 580 field as follows 580$v Form subdivision 580$x General subdivision 580$y Chronological subdivision 580$z Geographic subdivision (yes I actually put the name of the subfield in the subfield) The summary when searching for authorities looks like this (without patch) Personal Names: Ó Cadhain, Máirtín. see also: Form subdivision General subdivision Chronological subdivision Geographic subdivision Please review test plan and make it more detailed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31061] OPACSuppress does not work properly with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31061 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #4 from Caroline Cyr La Rose --- I must not be completely awake, but I cannot reproduce the original "problematic" behaviour. Without applying the patch, using ES, the number of records fluctuates according to 942$n being Yes (1) or No (0) and OpacSuppression being on or off. There are 3 records with 1 in 942$n With OpacSuppression = 405 Without OpacSuppression = 408 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Marie-Luce Laflamme changed: What|Removed |Added CC||marie-luce.laflamme@inlibro ||.com Status|Needs Signoff |Signed Off --- Comment #7 from Marie-Luce Laflamme --- testing note: add an item replacement cost (952$ v) on checkout items it works well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #68 from Tomás Cohen Arazi --- Petro et al, please look at the follow-up I've added. I think there's still some little work to do here. In particular, running: $ git grep ExpireReservesMaxPickUpDelayCharge showed that some spots need thought still. Places where templates still check the syspref when they should be checking the "effective value", even without my follow-up. Looking forward to the upcoming follow-ups for pushing this ASAP. Thanks! PS It also felt like we could move ExpireReservesMaxPickupDelay and put them both on its own section below the big matrix. We can do it on a follow-up bug of course. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #67 from Tomás Cohen Arazi --- Created attachment 136769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136769&action=edit Bug 25711: Deprecate ExpireReservesMaxPickUpDelayCharge Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Thibault Keromnès changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||thibault.keromnes@univ-pari ||s8.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 sandbo...@biblibre.com changed: What|Removed |Added Attachment #136757|0 |1 is obsolete|| --- Comment #162 from sandbo...@biblibre.com --- Created attachment 136768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136768&action=edit Bug 15326: Using AdditionalContents for custom pages on OPAC This page utilises the Additional Contents feature to add custom pages to the staff client and the OPAC in the user's desired language. To test: 1. Apply patch and restart services 2. In the staff client, go to Tools, then go to the new 'Pages' page 3. Add a new page to display on both the staff client and OPAC. 4. Confirm the URLs in the Page URL column work as expected. 5. Confirm that any pages made for the staff client only do not show in the OPAC, and that any pages made for the OPAC only do not show in the staff client. 6. Confirm that pages do not show on the OPAC main page where news items show. Confirm news items show on the OPAC main page as expected. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Thibault Kero -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #2 from Caroline Cyr La Rose --- Hi Julian, I would appreciate a more detailed test plan. barcode.pl is linked to an item field for me, so I can't clone it. All the other plugins for specific fields (e.g. 000, 005, 008) are on non-repeatable fields too. Do we have to modify the framework in order to test this? Thanks, Caroline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31072] New: Remove direct CSV export in itemsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31072 Bug ID: 31072 Summary: Remove direct CSV export in itemsearch.pl Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: simon.h...@dainst.org QA Contact: testo...@bugs.koha-community.org I am not 100% sure if this is something you are considering in need of fixing, but anyway: We just had a colleague crashing our system by running multiple searches with cgi-bin/koha/catalogue/itemsearch.pl. The search scope was rather broad (a lot of entries) and the output option had been set to CSV (without going to the "screen" view). Because the interface did not give any feedback after starting the search (it just indicated "website loading"), the colleague refreshed the browser window and started another search. The result: We had 2 processes running on the server, using 8gb of RAM each, thus causing our server to grind to a halt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29924] Introduce password expiration to patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit password expiration dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926 Nick Clemens changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
