[Koha-bugs] [Bug 31100] New: Notice editor should only show relevant options

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31100

Bug ID: 31100
   Summary: Notice editor should only show relevant options
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

At the moment, when editing a notice, you can select from a long list of fields
to insert into a notice template.

However, in many cases (e.g. PREDUEDGST), only a sub-selection of these will
ever actually work. 

We should control the list so that it only shows what you can use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|n...@bywatersolutions.com   |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #23 from victor  ---
Complementing the information.
I saw this error when updating to version 22.05.02.000

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31099] [DOCS] Export data tool - setup so database and configuration data can be downloaded

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31099

victor  changed:

   What|Removed |Added

 CC||vbovic...@gmail.com

--- Comment #2 from victor  ---
No, because the backup is not finalizing.

$koha-dump instance
Dumping Koha site instace:

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

victor  changed:

   What|Removed |Added

 CC||vbovic...@gmail.com

--- Comment #22 from victor  ---
Will the next updates fix this bug?
Or do you need to do the correction manually?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564

David Nind  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31099

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

David Nind  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31099

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31099] [DOCS] Export data tool - setup so database and configuration data can be downloaded

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31099

David Nind  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31098,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14564

--- Comment #1 from David Nind  ---
This is set up by:

1. Enabling the export of the database and configuration in the Koha instance
koha-conf.xml file:
   . backup directory: /var/spool/koha/kohadev
   . enable database and configuration dumps (change 0 to 1):
 
 1
 1

2. Running koha-run-backups so that the downloadable backups are created and
available. Example: koha-run-backups --days 2 --output /var/spool/koha

3. This can be done either as a one-off, or as a setup as a cronjob so that it
runs regularly.

Areas in the manual to update or cross-reference:
- tools.rst:
https://koha-community.org/manual/22.05/en/html/tools.html#export-data
- cron_jobs.rst:
https://koha-community.org/manual/22.05/en/html/cron_jobs.html#backup - this
covers a different option that is a separate script to run a database backup
and set it up as a cron job, once the relative merits of the different
approaches are worked out add across-reference to how to do backups with
koha-run-backups 

Ideas for improvement:
- Look at adding something/section/guide about system administration activities
and tasks (as opposed to these are the cron jobs available, and the Koha
package commands).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 137142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137142=edit
Bug 29418: (follow-up) Fix links generated in XSLTs

This patch addresses the case of links that are generated on the XSLT
side, those linking to host records using 773$t and 773$a.

To test:
1. Repeat the test plan from the other patches
2. When sitting on the detail view of the host record, click on the link
   to open the child.
=> SUCCESS: The link works, because of the previous patches
3. Click on the 'In:' link so the search takes you to the host record
=> FAIL: The link leads no results
4. Apply this patch
5. Restart all
6. Reload the child record page and click on the link
=> SUCCESS: Voila! The host record is retrieved!
7. Bonus points: Retry the full test plan, but add a " or ? to the
   author in both host and child records
=> SUCCESS: Things don't work before this patch, and work afterwards.
8. Sign off :-D

Sponsored-by: Theke Solutions

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

--- Comment #2 from David Nind  ---
Hi victor.

You've set things up to enable backups, but the actual backups need creating
using koha-run-backups

Example: koha-run-backups --days 2 --output /var/spool/koha

Then the database and configuration backups will appear on the tabs to export
the database and configuration.

I'd imagine this could be setup as a cronjob.

This is not documented in the manual, so I've added a documentation bug to do
this: bug 31099

See also bug 14564 - there was some discussion there about allowing it or not,
or removing the option.

I'm not sure whether there needs to be a note or information on how to set this
up, either:
- in the koha-conf.xml file, or
- on the export database and export configuration page.

It definitely should be covered in the manual to help avoid confusion!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31099] New: [DOCS] Export data tool - setup so database and configuration data can be downloaded

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31099

Bug ID: 31099
   Summary: [DOCS] Export data tool - setup so database and
configuration data can be downloaded
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: da...@davidnind.com
QA Contact: testo...@bugs.koha-community.org

Add information to the manual on how to set up Tools > Export data so that the
database and configuration backups are enabled and shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs. Print (noun)

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes (using koha-testing-docker):

1. I had to do steps 8 and 9 (enable the new language) after step 15 (install
the language).

2. It was an interesting exercise navigating around the staff interface in
another language - I didn't have to switch back to English very often.

3. All the optional steps (18-48) were all fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs. Print (noun)

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

David Nind  changed:

   What|Removed |Added

 Attachment #137101|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 137141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137141=edit
Bug 31068: Context for translation: Print (verb) vs. Print (noun)

This patch adds context to the term Print in the context of message transport
types (as opposed to printing something/print button), for translation
purposes.

To test:
0- Apply patch

Check the terms to be changed
1- Go to Tools > Notifications & slips
2- Edit a notification
** 3- In the tabs for different transport types, check the 'Print' term
(letter.tt)
4- Go to Tools > Overdue notice/status triggers
** 5- In the transport types, check the 'Print' column heading
(overduerules.tt)

Add a new language (fr-CA in the example, change for whatever language code you
want)
6- In a terminal, run
gulp po:create --lang fr-CA
7- Then, run
gulp po:update --lang fr-CA
8- In system preferences, enable the new language in language and OpacLanguages
9- Switch the language in staff interface and OPAC

Change the translations
10- In your favourite text editor, open fr-CA-messages.po
11- Find the string msgctxt "Message transport type"
12- Enter a word in msgstr
13- Save the file
14- In a terminal, go to misc/translator
15- Run
./translate install fr-CA

Check the translations
16- Redo the steps to check the terms (steps 1-5) and make sure the terms in
steps 3 and 5 are changed for the word you put in step 12.

17- Optionally, check the other pages where the term is supposed to be
unchanged and make sure it is unchanged

Check the terms to leave unchanged (optional)
18- Enable the HoldsAutoFill and UseCashRegisters system preferences
19- Go to Administration > Cash registers and create a cash register
20- Go to a patron's account
** 21- Check the 'Print' button in the menu bar or the patron's account
(members-toolbar.inc)
22- Go to the 'Accounting' tab
23- Create a manual invoice
** 24- In the 'Transactions' tab, check the 'Print' button in the fee line
(boraccount.tt)
25- Pay the fee (make sure to use the cash register)
** 26- In the 'Transactions' tab, check the 'Print' button in the payment line
(boraccount.tt)
27- At the top of the transactions table, click the 'Export' option
** 28- Check the 'Print' option (columns_settings.inc)
29- Go to the 'Check out' tab and check out an item
30- Go to the item's bibliographic record
** 31- Check the 'Print' button in the menu bar of the detailed record
(cat-toolbar.inc)
32- Add the record to the cart and open the cart
** 33- Check the 'Print' button in the cart (basket.tt)
34- Place a hold on the item
35- In the search bar at the top, click the 'Check in' tab and check in the
item
** 36- Check the 'Print' button in the 'Hold filled for' message (returns.tt)
37- Go to Tools > Cash summary for Branch
38- Click 'record cashup' and confirm
39- Click the 'Summary' link in the 'Last cashup' column
** 40- Check the 'Print' button in the cashup summary modal
(cashup_summary.inc)
41- Go to Serials
42- Create a subscription (if there aren't any)
43- Receive an issue
44- From the subscription detail page, go to Create routing list
45- Add a recipient to the list
46- Save the routing list
47- Click 'Save and preview routing slip'
** 48- Check the 'Print' button in the routing list preview
(routing_preview_slip.tt)

Note: I can't find where the 'Print' from tinymce_i18n.inc is displayed in the
staff interface

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs. Print (noun)

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31095] Koha::Patron::Debarment should be updated to follow current Koha:: style

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
I suspect that this will be a setup problem rather than a bug.

I'd suggest you look at https://koha-community.org/support/ for some options on
getting support with your issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind  changed:

   What|Removed |Added

 Attachment #137137|0   |1
is obsolete||

--- Comment #35 from David Nind  ---
Created attachment 137140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137140=edit
Bug 29418: Make detail rendering use the cleaned-up title for searching

This patch makes both staff and OPAC detail pages generate a valid
search link so you can trace related records in the Show analytics
link.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind  changed:

   What|Removed |Added

 Attachment #137136|0   |1
is obsolete||

--- Comment #34 from David Nind  ---
Created attachment 137139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137139=edit
Bug 29418: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind  changed:

   What|Removed |Added

 Attachment #137135|0   |1
is obsolete||

--- Comment #33 from David Nind  ---
Created attachment 137138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137138=edit
Bug 29418: Unit tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

David Nind  changed:

   What|Removed |Added

Summary|The option tohe option of   |The options to "export
   |"export database" and   |database" and "export
   |"export settings" are not   |settings" are not available
   |available.  |
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 137137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137137=edit
Bug 29418: Make detail rendering use the cleaned-up title for searching

This patch makes both staff and OPAC detail pages generate a valid
search link so you can trace related records in the Show analytics
link.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 137136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137136=edit
Bug 29418: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #30 from Tomás Cohen Arazi  ---
Created attachment 137135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137135=edit
Bug 29418: Unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #137048|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Error searching for analytics in detail view

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31017] Add type field for vendors

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31017] Add type field for vendors

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #136903|0   |1
is obsolete||

--- Comment #9 from ByWater Sandboxes  ---
Created attachment 137134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137134=edit
Bug 31017: Add new vendor_type field to edit screen and display

This patch adds a new vendor_type field when creating/editing vendors
and displays the field on search and details for a vendor

To test:
 1 - Apply patch, update database
 2 - Edit/create a vendor in acquisitions
 3 - Note new 'Vendor type' field, free text in editor
 4 - Save a value
 5 - Confirm it displays in vendor search results and vendor main page
 6 - In Authorised values add a new value to 'VENDOR_TYPE' category
 7 - Confirm the description of VENDOR_TYPE shows and makes sense
 8 - Add/Edit a vendor, note the vendor type is now a dropdown selection
 9 - Save with a value
10 - Confirm the description shows in results and vendor page and vendor
details

Signed-off-by: Caroline 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||shi-yao.w...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #129810|0   |1
is obsolete||

--- Comment #6 from Shi Yao Wang  ---
Created attachment 137133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137133=edit
Bug 28975: Holds queue lists can show holds from all libraries even with
IndependentBranches

When using IndependentBranches, usually all branches are removed from the
drop-down menus. But in the Holds Queue page, there is the possibility to
choose "All branches". From there, you can see holds from all libraries.

To recreate :
1) Activate IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian),
including holds permissions. Here are mine as an example
  - circulate (all)
  - catalogue
  - borrowers
- delete_borrowers
- edit_borrowers
  - reserveforothers (all)
  - reports (all)
3) Create (or make sure you already have) a patron in another branch (we'll
call them patron X)
4) Place a hold for patron X on an available item from their own library
5) Run misc/cronjobs/holds/build_holds_queue.pl
6) Go to Circulation > Holds queue and make sure you can see the hold
7) Log in as your limited staff patron
8) Go to Circulation > Holds queue
9) In the drop-down menu, choose "All" and click Submit
-- Notice you see the hold of the patron from another branch under Patron
column: "A patron from library "
11) Apply the patch.
12) Notice that the "All" option is no longer available for the limited patron.
Limited patrons can't see holds from other libraries anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

MichaelaSieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28854] Add ability to create bundles of items

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

MichaelaSieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #136802|0   |1
is obsolete||

--- Comment #7 from ByWater Sandboxes  ---
Created attachment 137132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137132=edit
Bug 30619: Add sample email notice

This patch adds a default same email type notice for the point of sale
receipt.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #136801|0   |1
is obsolete||

--- Comment #6 from ByWater Sandboxes  ---
Created attachment 137131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137131=edit
Bug 30619: Add email receipt to POS

This patch adds the ability to use email receipts with the point of sale
module.

To test:
1) Configure your Koha to enable the point of sale system.
2) Add an email template to the 'Point of sale > RECEIPT' notice.
3) Add some charges on point of sale and pay for them.
3a) You should now see a new 'Email receipt' button next to the 'Print
receipt' option.
3b) Clicking the button will display a modal to enter the anonymous
users email address
3c) Enter an email address and confirm to send the email

Sponsored-by: Martin Renvoize 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31098] New: The option tohe option of "export database" and "export settings" are not available.

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

Bug ID: 31098
   Summary: The option tohe option of "export database" and
"export settings" are not available.
 Change sponsored?: ---
   Product: Koha
   Version: 22.05
  Hardware: All
OS: Linux
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: bugs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vbovic...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I enabled in instance-conf.xml

1
1

In Tools --> Export Data
The option tohe option of "export database" and "export settings" are not
available.

Here's the information that appears:
"Note: This generated file will be very large, and will be generated daily."
"Unfortunately, there are no backups available."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137094|0   |1
is obsolete||

--- Comment #287 from Katrin Fischer  ---
Created attachment 137130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137130=edit
Bug 23681: (QA follow-up) Fix memberentry page display

We were missing some changes to the restriction types dropdown handling
in the memberentry template.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137093|0   |1
is obsolete||

--- Comment #286 from Katrin Fischer  ---
Created attachment 137129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137129=edit
Bug 23681: (QA follow-up) Fix debarment count

This patch fixes the debarment count displayed on the circulation page
tabs

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137092|0   |1
is obsolete||

--- Comment #285 from Katrin Fischer  ---
Created attachment 137128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137128=edit
Bug 23681: (QA follow-up) Match default data to update

The default data at install time didn't match the data added at update.

This patch corrects that and by doing so it also adds back the ability
to make MANUAL restriction types the default after any other type has
been made default.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137091|0   |1
is obsolete||

--- Comment #284 from Katrin Fischer  ---
Created attachment 137127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137127=edit
Bug 23681: (QA follow-up) Remove spacing and add question mark

This patch removes the superflous whitespace around the restriction
descriptions and also adds the missing question mark into the delete
question.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137090|0   |1
is obsolete||

--- Comment #283 from Katrin Fischer  ---
Created attachment 137126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137126=edit
Bug 23681: (QA follow-up) Add patron restrictions to admin menu

This patch adds the patron restrictions page to the admin menu that
appears to the left on all administration pages.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137089|0   |1
is obsolete||

--- Comment #282 from Katrin Fischer  ---
Created attachment 137125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137125=edit
Bug 23681: (follow-up) Mark fields at booleans

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137088|0   |1
is obsolete||

--- Comment #281 from Katrin Fischer  ---
Created attachment 137124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137124=edit
Bug 23681: DBIC Rebuild

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137087|0   |1
is obsolete||

--- Comment #280 from Katrin Fischer  ---
Created attachment 137123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137123=edit
Bug 23681: (QA follow-up) Proper handling of default option

This patch removes the 'can_be_added_manually' flag. Only non-system
restriction types can be added manually, so we exclude is_system instead
of having two flags. (And we set the 'Manual' that's added at install
time to default but not system).

We then add proper handling for setting the default manual restriction
type in the management page and set the dropdown list to use that value
by default.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137086|0   |1
is obsolete||

--- Comment #279 from Katrin Fischer  ---
Created attachment 137122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137122=edit
Bug 23681: (QA follow-up) Merge update files

This patch merges the three atomic update files into one and also
adds a check for foreing key existance to make the update idempotent.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137085|0   |1
is obsolete||

--- Comment #278 from Katrin Fischer  ---
Created attachment 137121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137121=edit
Bug 23681: (QA follow-up) Restore customisablity of description

This patch restores the customisability of description for system restriction
types. Translatability is not affected as you can translate the defaults
via template translation and assuming the end users leave their
descriptions at the default, the translations will be picked.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137084|0   |1
is obsolete||

--- Comment #277 from Katrin Fischer  ---
Created attachment 137120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137120=edit
Bug 23681: (QA follow-up) Move preference again

This patch removes the new PatronRestrictionTypes preference from the
accounting area in preference to creating a new group for 'Patron
restriction' related preferences in the circulation preferences tab.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137083|0   |1
is obsolete||

--- Comment #276 from Katrin Fischer  ---
Created attachment 137119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137119=edit
Bug 23681: DO NOT PUSH! Schema changes

To be able to delete and pass tests we need to declare
koha_object[s]_class to DebarmentType.pm. Otherwise
following error is raised:

"Can't locate object method "_new_from_dbic" via package
"Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?)
at /kohadevbox/koha/Koha/Object.pm line 237"

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137082|0   |1
is obsolete||

--- Comment #275 from Katrin Fischer  ---
Created attachment 137118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137118=edit
Bug 23681: Fix QA issues

This patch fixes following QA issues:
- convert intaller files as .yml
- change column name readonly as is_system
- change column name is_system as default_value
- add column can_be_added_manually (testplan for this below)
- move syspref "PatronRestrictionTypes" to "Accounting > Features" tab
- tweak page title
- tweak tests to apply these changes

Also atomicupdate files have been updated. Issues with delete and tests
is fixed with adding additional schema change file.

To test:
1) Add new restriction type and make it manual.
2) Navigate to patron details page.
3) Add new restriction to patron.
=> Only selectable restriction should be the one
you just created.

Also prove t/db_dependent/RestrictionTypes.t.

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137081|0   |1
is obsolete||

--- Comment #274 from Katrin Fischer  ---
Created attachment 137117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137117=edit
Bug 23681: (QA follow-up) Fix prefs

Add the missing `.` and switch from `yes/no` to `1/0`.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137080|0   |1
is obsolete||

--- Comment #273 from Katrin Fischer  ---
Created attachment 137116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137116=edit
Bug 23681: (QA follow-up) Rename columns

Renames ronly to readonly and dflt to is_system.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137079|0   |1
is obsolete||

--- Comment #272 from Katrin Fischer  ---
Created attachment 137115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137115=edit
Bug 23681: (QA follow-up) Fix license, perlcritic & executable

This patch fixes the simple issues mentioned by the QA script.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137078|0   |1
is obsolete||

--- Comment #271 from Katrin Fischer  ---
Created attachment 137114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137114=edit
Bug 23681: Updates for bug 26703

This patch fixes the title ordering and also replaces the breadcrumbs
with the modern nav block equivilent

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137077|0   |1
is obsolete||

--- Comment #270 from Katrin Fischer  ---
Created attachment 137113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137113=edit
Bug 23681: (QA follow-up) Allow for translations

This patch allows for existing translations to follow through if
debarment type descriptions are left unaltered for the default types.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137076|0   |1
is obsolete||

--- Comment #269 from Katrin Fischer  ---
Created attachment 137112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137112=edit
Bug 23681: (follow-up) Fix rebase issues

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137075|0   |1
is obsolete||

--- Comment #268 from Katrin Fischer  ---
Created attachment 137111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137111=edit
Bug 23681: (follow-up) Fix typo

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137074|0   |1
is obsolete||

--- Comment #267 from Katrin Fischer  ---
Created attachment 137110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137110=edit
Bug 23681: Add unit tests

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137073|0   |1
is obsolete||

--- Comment #266 from Katrin Fischer  ---
Created attachment 137109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137109=edit
Bug 23681: Clean up on delete

When a patron restriction type is deleted, any debarments that use that
type need to revert to the default type, this patch implements this
behaviour

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137072|0   |1
is obsolete||

--- Comment #265 from Katrin Fischer  ---
Created attachment 137108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137108=edit
Bug 23681: Allow for selection of restriction type

This patch displays a restriction type select box (when appropriate)
when adding manual patron restrictions

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137071|0   |1
is obsolete||

--- Comment #264 from Katrin Fischer  ---
Created attachment 137107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137107=edit
Bug 23681: Allow for changes to debarments

The structure of debarments has changes slightly in that the displayed
text is now a product of a call to Koha::RestrictionTypes rather than
just the debarment's code. This patch allows for that

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137070|0   |1
is obsolete||

--- Comment #263 from Katrin Fischer  ---
Created attachment 137106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137106=edit
Bug 23681: Add management UI

This patch adds UI to allow CRUD operations on restriction types

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137069|0   |1
is obsolete||

--- Comment #262 from Katrin Fischer  ---
Created attachment 137105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137105=edit
Bug 23681: Add Koha::RestrictionType(s)

This patch adds the following objects:

Koha::RestrictionType
Koha::RestrictionTypes

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137068|0   |1
is obsolete||

--- Comment #261 from Katrin Fischer  ---
Created attachment 137104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137104=edit
Bug 23681: Add modify_patron_restrictions perm

This patch adds a new "modify_patron_restrictions" permission

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137067|0   |1
is obsolete||

--- Comment #260 from Katrin Fischer  ---
Created attachment 137103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137103=edit
Bug 23681: Add debarment_types

This patch adds the table debarment_types and changes
borrower_debarments.type to be a foreign key to it

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137066|0   |1
is obsolete||

--- Comment #259 from Katrin Fischer  ---
Created attachment 137102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137102=edit
Bug 23681: Add PatronRestrictionTypes syspref

This patch adds the new syspref "PatronRestrictionTypes"

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs. Print (noun)

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 137101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137101=edit
Bug 31068: Context for translation: Print (verb) vs. Print (noun)

This patch adds context to the term Print in the context of message transport
types (as opposed to printing something/print button), for translation
purposes.

To test:
0- Apply patch

Check the terms to be changed
1- Go to Tools > Notifications & slips
2- Edit a notification
** 3- In the tabs for different transport types, check the 'Print' term
(letter.tt)
4- Go to Tools > Overdue notice/status triggers
** 5- In the transport types, check the 'Print' column heading
(overduerules.tt)

Add a new language (fr-CA in the example, change for whatever language code you
want)
6- In a terminal, run
gulp po:create --lang fr-CA
7- Then, run
gulp po:update --lang fr-CA
8- In system preferences, enable the new language in language and OpacLanguages
9- Switch the language in staff interface and OPAC

Change the translations
10- In your favourite text editor, open fr-CA-messages.po
11- Find the string msgctxt "Message transport type"
12- Enter a word in msgstr
13- Save the file
14- In a terminal, go to misc/translator
15- Run
./translate install fr-CA

Check the translations
16- Redo the steps to check the terms (steps 1-5) and make sure the terms in
steps 3 and 5 are changed for the word you put in step 12.

17- Optionally, check the other pages where the term is supposed to be
unchanged and make sure it is unchanged

Check the terms to leave unchanged (optional)
18- Enable the HoldsAutoFill and UseCashRegisters system preferences
19- Go to Administration > Cash registers and create a cash register
20- Go to a patron's account
** 21- Check the 'Print' button in the menu bar or the patron's account
(members-toolbar.inc)
22- Go to the 'Accounting' tab
23- Create a manual invoice
** 24- In the 'Transactions' tab, check the 'Print' button in the fee line
(boraccount.tt)
25- Pay the fee (make sure to use the cash register)
** 26- In the 'Transactions' tab, check the 'Print' button in the payment line
(boraccount.tt)
27- At the top of the transactions table, click the 'Export' option
** 28- Check the 'Print' option (columns_settings.inc)
29- Go to the 'Check out' tab and check out an item
30- Go to the item's bibliographic record
** 31- Check the 'Print' button in the menu bar of the detailed record
(cat-toolbar.inc)
32- Add the record to the cart and open the cart
** 33- Check the 'Print' button in the cart (basket.tt)
34- Place a hold on the item
35- In the search bar at the top, click the 'Check in' tab and check in the
item
** 36- Check the 'Print' button in the 'Hold filled for' message (returns.tt)
37- Go to Tools > Cash summary for Branch
38- Click 'record cashup' and confirm
39- Click the 'Summary' link in the 'Last cashup' column
** 40- Check the 'Print' button in the cashup summary modal
(cashup_summary.inc)
41- Go to Serials
42- Create a subscription (if there aren't any)
43- Receive an issue
44- From the subscription detail page, go to Create routing list
45- Add a recipient to the list
46- Save the routing list
47- Click 'Save and preview routing slip'
** 48- Check the 'Print' button in the routing list preview
(routing_preview_slip.tt)

Note: I can't find where the 'Print' from tinymce_i18n.inc is displayed in the
staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs. Print (noun)

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #258 from Katrin Fischer  ---

0) QA script + unit tests
RESOLVED

1) Side menu 
RESOLVED

2) Delete confirmation
RESOLVED

3) Default behavior / MANUAL
RESOLVED

4) :)

5) Pre-selection in pull down
Retested and RESOLVED. 

6) Number in restrictions tab
RESOLVED

7) When editing the patron record, the pull down for restriction type is empty.
RESOLVED

8) Show restriction type in places
MOVE to separate bug later :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #43 from Katrin Fischer  ---
Hi Aleisha, 

1) there were several complaints by the QA tools that I have fixed 2 in
separate follow-up patches. Could you please fix the third one? I have not been
able to figure this one out:

 FAIL   acqui/moddeliverydate.pl
   FAIL   valid
Useless use of private variable in void context

2) This bit here is not translatable:

var modalTitle = $(this).attr("title") + " (order number " + ordernumber + ")";

3) When adding a new order, there is no calendar widget for the estimated
delivery date column. I have tried to do an update to flatpickr in a follow-up,
but I think it's not complete yet. 

I believe these type of lines need to be removed from the files as well:
$("#estimated_delivery_date").datepicker();

4) Looking for 'datepicker' in the code, I saw that there is code for a modal
in lateorders.tt, but it doesn't appear to be used, it looks like
moddeliverdatey.tt is used instead. A modal like the edit notes one on the same
page would really nice and more consistent:




Estimated
delivery date



[% INCLUDE 'date-format.inc' %]




5) It's not possible to edit the estimated delivery date from a closed basket.
If you reopen and close the basket, the close date will be updated, that is
also used as the order date. So we need to be able to update this without
reopening.

6) When editing the delivery date from the late orders page, things would
explode. I fixed the import statements in a follow-up. Hope I caught them all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639

mathieu saby  changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on the bibliographic detail page

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

--- Comment #15 from Koha Team University Lyon 3  ---
I confirm that the problem seems to be solved (for both Zebra and Elastic
Search).

In prod (indexed with Zebra) :
example with biblionumber 3652 wich has the Suppress field enabled (099$0 = 1).
Searching with the terms "Einstein 1905" does not get this title in the
results.
Searching for detailed page
"https://catalogue.univ-lyon3.fr/cgi-bin/koha/opac-detail.pl?biblionumber=3652;
get 404 error.

Same searches on our preprod instance (with Elastic search in test) : same
results.

Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #137095|0   |1
is obsolete||

--- Comment #38 from Jonathan Druart  ---
Created attachment 137100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137100=edit
Bug 30650: Display holds waiting at the logged-in library

Not those waiting at the library of the logged-in user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #42 from Katrin Fischer  ---
Created attachment 137099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137099=edit
Bug 15348: (follow-up) Update calendar widget to flatpickr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #41 from Katrin Fischer  ---
Created attachment 137098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137098=edit
Bug 15348: (follow-up) Fix imports in moddeliverydate.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #136583|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 137097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137097=edit
Bug 30965: Add patron autocomplete search to curbside pickups

Prior to this patch librarians had to know the cardnumber to search for
patron. Now it's possible to search using the default patron
autocomplete search (name, cardnumber, etc.)

Test plan:
Confirm that you can search for a patron without their cardnumber,
select it and create a curbside pickup

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #136582|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  ---
Created attachment 137096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137096=edit
Bug 30964: Add 'restricted' and 'has overdues' on curbside pickup

This patch adds more information about the patron's account on the
curbside pickup list view.
"Patron's account is restricted" if the patron is restricted
"Patron has items overdue" if the patron has overdues

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #37 from Jonathan Druart  ---
Created attachment 137095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137095=edit
Bug 30650: Display holds waiting at the logged-in library

Not those waiting at the library of the logged-in user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30619] Add the option to email receipts as an alternative to printing

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

Martin Renvoize  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on vendor search page

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082

David Nind  changed:

   What|Removed |Added

 Blocks||31096


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31096
[Bug 31096] [DOCS] Review and update acquisitions chapter
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31096] [DOCS] Review and update acquisitions chapter

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31096

David Nind  changed:

   What|Removed |Added

   Keywords||Manual-updated
 Resolution|--- |FIXED
 Status|NEW |RESOLVED
   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com
 Depends on||28082

--- Comment #1 from David Nind  ---
Complete review and update of the acquisitions chapter by Caroline Cyr La Rose,
now updated to current master (22.06) and merged into the manual.

This includes:
- image updates
- related changes to the administration chapter
- fixes to formatting in the administration chapter (warnings and notes)
- acquisition permissions in the patrons chapter
- various doc build errors
- stage and import MARC records in the tools chapter
- Bug 28082: Add acquisitions toolbar to vendors on vendor search page


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
[Bug 28082] Add acquisitions toolbar to vendors on vendor search page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30526] The pagination in the REST API does not work if $c->objects->search is called multiple times.

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526

--- Comment #5 from Andreas Jonsson  ---
It seems that the issue at hand have been accidentally fixed.

Let me propose a simpler test plan:

* Open up Koha/REST/Plugin/Query.pm and look at the subroutine _build_link
* Observe that the subroutine overwrites $args->{params}->{_page} and
$args->{params}->{_per_page}
* Ponder for a second over how one can reasonable expect that these parameters
remain unchanged for the duration of the request.
* Ponder for a second over how this unexpected modification of the parameters
might have caused the issue at hand, how it might be causing other undiscovered
issues and how it may cause issues with code yet to be written.
* Ponder for a second over how no sane programmer could have written any code
which, outside of the subroutine _build_link, relies on this unexpected update
of the parameters.
* Ponder for a second over how the proposed patch unburdens you from these
concerns.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #257 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #256)
> (In reply to Katrin Fischer from comment #224)
> 
> > I'd also make the button just "Delete" or "Yes, delete", but that's a
> > personal preference and I see that this was 'copied' from how deleting a
> > patron category looks like.
> 
> Hmm, I'd love to see us standardise on something and create a guideline
> about it.. at that time I'd be keen to go through and get everything
> consistent.

Agreed, I was just wondering, because in German such buttons tend to get huge.
> 
> > 3) After installing/updating with this patch, MANUAL is marked es the
> > default. You cannot change it, until you have added a new restriction, which
> > makes sense, as the system internal ones should not be default. But: you
> > cannot ever change the default back to MANUAL. I think this is because
> > system internal values are excluded, but it might raise complaints for
> > people experimenting with the feature that want to restore previous 
> > behavior.
> 
> I discovered the update and the install data were out of sync.. fixed in a
> follow-up. This resolves the defaulting issue.

Good catch! Will retest.

> > 5) When adding a manual restriction to the patron account, the default seems
> > to be only used when PatronRestrictionTypes is off, when it's on and the
> > pull down shows, the default is not preselected, but the first entry is. 
> 
> Hmm, I couldn't replicate this.

I'll retest.


> > 8) I notice that the type itself doesn't show up in the OPAC or the note on
> > the patron account in staff, just the comments do. This is the case with and
> > without the patches, maybe something so consider later. Or we could imagine
> > adding a default comment? (no blocker, just loud thinking)
> 
> Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one?

Yes, loud thinking definitely warrants a separate bug. I'd also not noticed
that before, but it's unchanged by this patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31097] Patron restriction types should display in Staff and OPAC

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31097

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||31097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31097
[Bug 31097] Patron restriction types should display in Staff and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31097] New: Patron restriction types should display in Staff and OPAC

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31097

Bug ID: 31097
   Summary: Patron restriction types should display in Staff and
OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Depends on: 23681

Where we display the patron restrictions in the OPAC and Staff client, we don't
always display the type description.. only the comment.

We should add this to the display.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
[Bug 23681] Patron restrictions should be user definable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #256 from Martin Renvoize  ---
(In reply to Katrin Fischer from comment #224)
> 1) The new patron restrictions configuration page is missing from the
> Administration side menu, visible when you are on any of the admin pages.
> It's ok on the start page of the module.

Fixed in follow-up

> 2) The delete confirmation question is missing a question mark :) (also
> might want to remove the additional spaces)
> Are you sure you want to delete " Test "

Fixed in follow-up

> I'd also make the button just "Delete" or "Yes, delete", but that's a
> personal preference and I see that this was 'copied' from how deleting a
> patron category looks like.

Hmm, I'd love to see us standardise on something and create a guideline about
it.. at that time I'd be keen to go through and get everything consistent.

> 3) After installing/updating with this patch, MANUAL is marked es the
> default. You cannot change it, until you have added a new restriction, which
> makes sense, as the system internal ones should not be default. But: you
> cannot ever change the default back to MANUAL. I think this is because
> system internal values are excluded, but it might raise complaints for
> people experimenting with the feature that want to restore previous behavior.

I discovered the update and the install data were out of sync.. fixed in a
follow-up. This resolves the defaulting issue.

> 4) Just a comment: Love the new Patron restrictions sub heading in patron
> preferences :)

Glad you like it :)

> 5) When adding a manual restriction to the patron account, the default seems
> to be only used when PatronRestrictionTypes is off, when it's on and the
> pull down shows, the default is not preselected, but the first entry is. 

Hmm, I couldn't replicate this.

> 6) Something super odd: In the patron account in the staff interface, on the
> checkout tab, the Restrictions shows as (0), while on the details tab the
> restrictions show the correct number (2) I have added. Only the tab heading
> is wrong, otherwise the restrictions show ok.

Unrelated to this patchset I believe.. bit it is fixed in a follow-up now.

> 7) When editing the patron record, the pull down for restriction type is
> empty.

Fixed in follow-up.

> 8) I notice that the type itself doesn't show up in the OPAC or the note on
> the patron account in staff, just the comments do. This is the case with and
> without the patches, maybe something so consider later. Or we could imagine
> adding a default comment? (no blocker, just loud thinking)

Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #255 from Martin Renvoize  ---
Created attachment 137094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137094=edit
Bug 23681: (QA follow-up) Fix memberentry page display

We were missing some changes to the restriction types dropdown handling
in the memberentry template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #254 from Martin Renvoize  ---
Created attachment 137093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137093=edit
Bug 23681: (QA follow-up) Fix debarment count

This patch fixes the debarment count displayed on the circulation page
tabs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #253 from Martin Renvoize  ---
Created attachment 137092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137092=edit
Bug 23681: (QA follow-up) Match default data to update

The default data at install time didn't match the data added at update.

This patch corrects that and by doing so it also adds back the ability
to make MANUAL restriction types the default after any other type has
been made default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #252 from Martin Renvoize  ---
Created attachment 137091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137091=edit
Bug 23681: (QA follow-up) Remove spacing and add question mark

This patch removes the superflous whitespace around the restriction
descriptions and also adds the missing question mark into the delete
question.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #251 from Martin Renvoize  ---
Created attachment 137090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137090=edit
Bug 23681: (QA follow-up) Add patron restrictions to admin menu

This patch adds the patron restrictions page to the admin menu that
appears to the left on all administration pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #136739|0   |1
is obsolete||

--- Comment #250 from Martin Renvoize  ---
Created attachment 137089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137089=edit
Bug 23681: (follow-up) Mark fields at booleans

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #136738|0   |1
is obsolete||

--- Comment #249 from Martin Renvoize  ---
Created attachment 137088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137088=edit
Bug 23681: DBIC Rebuild

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #136737|0   |1
is obsolete||

--- Comment #248 from Martin Renvoize  ---
Created attachment 137087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137087=edit
Bug 23681: (QA follow-up) Proper handling of default option

This patch removes the 'can_be_added_manually' flag. Only non-system
restriction types can be added manually, so we exclude is_system instead
of having two flags. (And we set the 'Manual' that's added at install
time to default but not system).

We then add proper handling for setting the default manual restriction
type in the management page and set the dropdown list to use that value
by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #136736|0   |1
is obsolete||

--- Comment #247 from Martin Renvoize  ---
Created attachment 137086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137086=edit
Bug 23681: (QA follow-up) Merge update files

This patch merges the three atomic update files into one and also
adds a check for foreing key existance to make the update idempotent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #136735|0   |1
is obsolete||

--- Comment #246 from Martin Renvoize  ---
Created attachment 137085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137085=edit
Bug 23681: (QA follow-up) Restore customisablity of description

This patch restores the customisability of description for system restriction
types. Translatability is not affected as you can translate the defaults
via template translation and assuming the end users leave their
descriptions at the default, the translations will be picked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #136734|0   |1
is obsolete||

--- Comment #245 from Martin Renvoize  ---
Created attachment 137084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137084=edit
Bug 23681: (QA follow-up) Move preference again

This patch removes the new PatronRestrictionTypes preference from the
accounting area in preference to creating a new group for 'Patron
restriction' related preferences in the circulation preferences tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #136733|0   |1
is obsolete||

--- Comment #244 from Martin Renvoize  ---
Created attachment 137083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137083=edit
Bug 23681: DO NOT PUSH! Schema changes

To be able to delete and pass tests we need to declare
koha_object[s]_class to DebarmentType.pm. Otherwise
following error is raised:

"Can't locate object method "_new_from_dbic" via package
"Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?)
at /kohadevbox/koha/Koha/Object.pm line 237"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >