[Koha-bugs] [Bug 31135] New: Circulation guided report missing biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31135 Bug ID: 31135 Summary: Circulation guided report missing biblio table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org The circulation guided report uses the 'borrowers', 'statistics', 'items', 'biblioitems' tables but not the 'biblio' table. This seems strange. Personally, I find the guided report generates very bad reports, but it's a clear oversight. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 --- Comment #3 from Aleisha Amohia --- Created attachment 137601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137601=edit Bug 31132: (follow-up) Reset dropdown values and style button This follow-up patch resets the dropdown values of the form alongside the text inputs. It styles the button to look like a link so it doesn't distract the user and get 'accidentally' clicked when attempting to submit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Aleisha Amohia changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22313] Show cover image on any matching ISBN found in a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22313 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- I think this is a flaw in Koha as well but it is complicated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19556] Added Content ISBN Does Not Match MARC 020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19556 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Koha converts ISBN-13 into ISBN-10 for looking up a lot of enhanced content. I think that Amazon can only use ISBN-10 so that might be the origin for this behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 --- Comment #3 from Tomás Cohen Arazi --- Ok, this should cover one part of the problem. There's still Koha::Biblio::ItemGroup which is failing, ran out of fuel today/yesterday, late already :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 137600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137600=edit Bug 31133: Add a way to handle multiple relationships on same column This patch introduces a syntax for TestBuilder so we can specify which is the preferred relationship in situations like Koha::Checkouts::Renewals that have more than one virtual FK [1] for the same column. In this case, there are the following relationships: * checkouts * old_checkouts both of which link the *checkout_id* column to the *issue_id* column of the **issues** and **old_issues** tables respectively. It does so by defining a mapping between the (concatenated, maybe multiple) related source column and foreign counterpart. The mapping structure is explained in the POD. To test: 1. Apply the regression tests 2. Run the tests a couple times: $ kshell k$ prove t/db_dependent/TestBuilder_multi_vfk.t => FAIL: Tests fail often, randomly! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No random failures! 5. Bonus, run: $ kshell k$ prove t/db_dependent/TestBuilder.t => FAIL: It fails consistently about Koha::Biblio::ItemGroup [1] i.e. defined at DBIC level but not present on the DB structure. DISCLAIMER: This is not a complete solution as it still requires a way to override the hardcoded default. This would require a special syntax for build() and build_object() which I prefer to delay until we really need it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 137599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137599=edit Bug 31133: Regression tests (1) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What|Removed |Added Blocks||31133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 [Bug 31133] TestBuilder fragile on virtual fks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Tomás Cohen Arazi changed: What|Removed |Added Depends on||24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Blocks||31133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 [Bug 31133] TestBuilder fragile on virtual fks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Tomás Cohen Arazi changed: What|Removed |Added Depends on||30275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 [Bug 30275] Checkout renewals should be stored in their own table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #219 from Tomás Cohen Arazi --- Created attachment 137598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137598=edit Bug 30275: (QA follow-up) Trivial fix to schema file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Aleisha Amohia changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31134] New: t/Ediorder.t tests failing on 22.05.02
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Bug ID: 31134 Summary: t/Ediorder.t tests failing on 22.05.02 Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Bug 30135 might have introduced a flaw in the tests - when we try to install Koha 22.05.02 and run t/ediorder.t, it fails with this output: vagrant@kohadevbox:kohaclone((v22.05.02))$ sudo koha-shell kohadev kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/Ediorder.t t/Ediorder.t .. 1/13 Use of uninitialized value $lsq_field in hash element at /home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563. Use of uninitialized value $lsq_field in hash element at /home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563. t/Ediorder.t .. 11/13 # Failed test 'Single Gir field OK' # at t/Ediorder.t line 104. # got: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM' # expected: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM' Use of uninitialized value $lsq_field in hash element at /home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563. Use of uninitialized value $lsq_field in hash element at /home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563. $VAR1 = 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM+S_I:LVT'; $VAR2 = 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM+S_I:LVT'; Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t line 119. # Failed test 'First part of split Gir field OK' # at t/Ediorder.t line 119. # got: undef # expected: 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM' Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t line 125. # Failed test 'Second part of split GIR field OK' # at t/Ediorder.t line 125. # got: undef # expected: 'GIR+002+S_I:LVT' # Looks like you failed 3 tests of 13. t/Ediorder.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/13 subtests Test Summary Report --- t/Ediorder.t (Wstat: 768 Tests: 13 Failed: 3) Failed tests: 11-13 Non-zero exit status: 3 Files=1, Tests=13, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.10 csys = 1.52 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 David Nind changed: What|Removed |Added Text to go in the||This fixes the patron release notes||delete messages dialogue ||box to make the message ||shown translatable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 David Nind changed: What|Removed |Added Attachment #135584|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 137597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137597=edit Bug 30028: Fix patron message delete confirmation to be translatable Make the message deletion confirmation popup translatable. Test plan uses fr-CA translations. Test plan: 1) Switch language to french (fr-CA) If you do not have the translations, go to misc/translator then do ./translate install fr-CA After it is done, go to administration > global system preference > l18N/L10N then select Français (fr-CA) under language preference. Refresh then you should be able to switch languages. 2) Add a message to a patron account from your own branch (or make sure AllowAllMessageDeletion is on) 3) Click "Delete" next to the message --> a confirmation message appears "Are you sure you want to delete this message? This cannot be undone." with options "Cancel" and "OK". 4) Apply the patch 5) Write a translation in misc/translator/po/fr-CA-messages-js.po : msgid "Are you sure you want to delete this message? This cannot be undone." msgstr "Êtes-vous sûr de vouloir supprimer ce message? Cette opération est irréversible." 6) Refresh the translations by going to misc/translator and execute ./translate install fr-CA 7) Refresh and click "Delete" again --> now the confirmation message is "Êtes-vous sûr de vouloir supprimer ce message? Cette opération est irréversible." with options "Cancel" and "OK" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices script ( advance_notices.pl )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Hi :) If I understand correctly there will be a change for existing notices. items.content now is the 1st title instead of the concatenation of all of them. Is that correct? I don't know what is the template variable where it end but it's content will change then. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 David Nind changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #23 from David Nind --- (In reply to Shi Yao Wang from comment #22) > It still works well for me... > > Not sure where the problem comes from. I tested with chrome and firefox. > I tried blocking prompts on firefox and the popup does not appear, but the > message is not deleted. > > Any ideas? I retested, and it all works now... not sure what I did to make it not work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106
David Nind changed:
What|Removed |Added
Text to go in the||This fixes two issues that
release notes||affect searching and links
||for analytics on the detail
||view pages for records in
||the staff interface and
||OPAC:
||
||1. Several
||characters will break Zebra
||search engine queries, so
||search terms need to be
||quoted by the query builder
||for things to work. Double
||quotes in titles and used
||in search terms were not
||escaped, cuasing issues
||with results.
||
||2. This
||caused links to and from
||host records using 773$t
||and 773$a to fail (not find
||or display the expected
||results).
||
||Example: Before
||this was fixed, for a host
||record with the title
||'Uncond"itional?¿' and
||child records linked using
||773$t and 773$a:
||- the
||'Show analytics' link was
||not displayed in the staff
||interface and OPAC for the
||host record
||- the link from
||the child record back to
||the host record ('In' Title
||of host record (linked))
||didn't work.
--- Comment #20 from David Nind ---
I've added some text for the release notes, but not sure if I've described this
correctly. Corrections and updates to the release notes text welcome!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 David Nind changed: What|Removed |Added Text to go in the||This fixes a duplicate release notes||print dialogue box ||appearing when printing the ||cashup summary for cash ||registers - ins some ||circumstances when ||cancelling the print ||dialogue, it reappeared ||instead of closing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31133 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16155 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 David Nind changed: What|Removed |Added Attachment #137595|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 137596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137596=edit Bug 31132: Add button to clear the cataloguing auth finder form This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records. To test: 1) Search for a bibliographic record in the staff interface 2) Edit a record 3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder plugin 4) Launch the authority finder plugin by clicking the Tag editor icon at the end of the field 5) If the fields are empty, add some text in the text fields 6) Click the 'Clear form' link at the bottom of the form 7) Confirm the text is cleared from the input fields and the form is empty Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31133] New: TestBuilder fragile on virtual fks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 Bug ID: 31133 Summary: TestBuilder fragile on virtual fks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org As exposed with the introduction of Koha::Checkouts::Renewal(s), which has two relationships (checkout and old_checkout) defined at the DBIC level (and not at DB level) that point the same column name, to the same fk name, TestBuilder fails in some situations. Looking at the code I found there's some code for detecting duplicate fk introduced by bug 16155, but it doesn't seem to be effective: it fails randomly depending on the key that is picked. I will submit my attempt to make things work, but more eyes are needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #7 from David Nind --- Could we get a test plan for this? Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Aleisha Amohia changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||'Clear form' link to empty ||all of the input fields on ||the authority finder plugin ||form when cataloguing ||bibliographic records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 --- Comment #1 from Aleisha Amohia --- Created attachment 137595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137595=edit Bug 31132: Add button to clear the cataloguing auth finder form This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records. To test: 1) Search for a bibliographic record in the staff interface 2) Edit a record 3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder plugin 4) Launch the authority finder plugin by clicking the Tag editor icon at the end of the field 5) If the fields are empty, add some text in the text fields 6) Click the 'Clear form' link at the bottom of the form 7) Confirm the text is cleared from the input fields and the form is empty Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 David Nind changed: What|Removed |Added Attachment #137577|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 137594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137594=edit Bug 31128: Add effective_not_for_loan_status into items response Signed-off-by: Nick Clemens Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 David Nind changed: What|Removed |Added Attachment #137576|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 137593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137593=edit Bug 31128: Unit tests This patch adds unit tests for the new effective_not_for_loan_status which I add to the items api responses in this patchset. Test plan 1) Run the unit test without applying the next commit, it should fail 2) RUn the test again after applying the next commit, it should pass Signed-off-by: Nick Clemens Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Aleisha Amohia changed: What|Removed |Added Assignee|koha-train...@catalyst.net. |alei...@catalyst.net.nz |nz | CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Koha Training Catalyst changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |koha-train...@catalyst.net. |ity.org |nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31132] New: Add button to clear the cataloguing authority plugin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Bug ID: 31132 Summary: Add button to clear the cataloguing authority plugin form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: koha-train...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Add a button that will empty all of the search fields in the authority finder plugin when cataloguing biblios -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Patch complexity|--- |Small patch --- Comment #8 from Victor Grousset/tuxayo --- > ->status_is( 200, 'SWAGGER3.2.2' ) How can we have Swagger version hardcoded in tests and it still works? Searching for "SWAGGER" shows multiple versions allover the tests and yet it still work :o -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | --- Comment #4 from Victor Grousset/tuxayo --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #136436|0 |1
is obsolete||
--- Comment #3 from Victor Grousset/tuxayo ---
Created attachment 137592
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137592=edit
Bug 31020: Fix PassItemMarcToXSLT in system preferences description
Bug 28373 added system preference PassItemMarcToXSLT is referenced is all XSLT
system preferences.
But it only applies on results pages.
The only use in perl code is in C4::Search :
> $marcrecord->delete_fields( @fields ) unless
C4::Context->preference('PassItemMarcToXSLT');
I've tested by adding in all XSLT files :
ITEMS
Number of items only appears in OPAC and staff interface results pages.
In fact only search pages get MARC record from search engine, in which items
datas have been embedded for indexing.
In other pages MARC record does not embed items datas.
This patch adds "MARC21 952, UNIMARC 995" to be explicit we talk about
MARC datas not item tags build in XML recieved by XSLT.
Test plan :
1) Apply patch
2) Search for PassItemMarcToXSLT in system preferencies
3) Look at description of PassItemMarcToXSLT
4) Check PassItemMarcToXSLT only apprears in OPACXSLTResultsDisplay and
XSLTResultsDisplay
Signed-off-by: David Nind
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 --- Comment #7 from Andrew Fuerste-Henry --- Another +1 on here now that I'm working in a library that would like for overdues restrictions to clear based on *triggering* overdues rather than all overdues. (In reply to Andrew Fuerste-Henry from comment #6) > +1 here, I've spoken to many libraries that would prefer the restriction be > specific to the item(s) that triggered the notice. This could be a new > syspref tied to AutoRemoveOverduesRestrictions so it asks: "(Do / Do not) > allow OVERDUES restrictions triggered by sent notices to be cleared > automatically when (all / triggering) overdue items are returned by a > patron." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31116] Article requests doesn't respect the 'CircSidebar' preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31116] Article requests doesn't respect the 'CircSidebar' preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header which is over 8192 bytes apache's limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header which is over 8192 bytes apache's limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails with a 500 error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #19 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 --- Comment #11 from Slava Shishkin --- Thanks, Victor! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Version(s)|This fixes the cause of an | released in|error message that appears | |in the system logs every| |time that Tools > Catalog > | |Export data | |(/cgi-bin/koha/tools/export | |.pl) is accessed. The error | |message was "AH01215: Use | |of uninitialized value | |$record_type in string eq | |at /koh | |adevbox/koha/tools/export.p | |l line 43.: | |/kohadevbox/koha/tools/expo | |rt.pl,...". | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #137589|0 |1 is obsolete|| --- Comment #89 from Tomás Cohen Arazi --- Created attachment 137591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137591=edit Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC This patch adds a helper method for filtering out cancellation requested-holds from resultsets, and makes use of it in the OPAC to filter out those in the current holds tab. Holds history now shows 'Waiting (cancellation requested)' on those. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #88 from Tomás Cohen Arazi --- Hi everyone, I addressed Lari's concerns about leftovers (hopefully I didn't miss things!). I also decided to consider this holds cancelled. This means: - They are not displayed anymore in the current holds - They show as cancelled in the holds history for OPAC users. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20439] SMS provider sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 George Williams (NEKLS) changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20439] SMS provider sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 ByWater Sandboxes changed: What|Removed |Added Attachment #137579|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 137590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137590=edit Bug 20439: Sort SMS providers in alphabetical order To test: 1/ Add 'Email' to the 'SMSSendDriver' system preference. 2/ Make sure 'EnhancedMessagingPreferencesOPAC' and 'EnhancedMessagingPreferences' are turned on. 3/ Add some SMS providers (/cgi-bin/koha/admin/sms_providers.pl) with different names. 4/ Notice on memberentry.pl and opac-messaging.pl the SMS providers sort by when they were added, not alphabetically. 5/ Apply patch and restart services. 6/ Look at memberentry.pl and opac-messaging.pl and notice that they SMS providers now sort alphabetically. Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #87 from Tomás Cohen Arazi --- Created attachment 137589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137589=edit Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC This patch adds a helper method for filtering out cancellation requested-holds from resultsets, and makes use of it in the OPAC to filter out those in the current holds tab. Holds history now shows 'Waiting (cancellation requested)' on those. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #86 from Tomás Cohen Arazi --- Created attachment 137588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137588=edit Bug 22456: (follow-up) Cancel holds at checkin This patch makes checkin process the cancellation requested holds actually cancel them before moving forward. To test: 1. Have a waiting hold with a patron generated cancellation request 2. At circulation, check the item in => SUCCESS: The workflow follows as if the cancellation requested hold was already cancelled => SUCCESS: The hold is actually cancelled => SUCCESS: Not shown in the OPAC anymore Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #85 from Tomás Cohen Arazi --- Created attachment 137587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137587=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #84 from Tomás Cohen Arazi --- Created attachment 137586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137586=edit Bug 22456: Allow requesting cancellation from the OPAC Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #83 from Tomás Cohen Arazi --- Created attachment 137585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137585=edit Bug 22456: Add Koha::Holds->filter_by_has_cancellation_requests This patch adds that method. Which is covered by new tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #82 from Tomás Cohen Arazi --- Created attachment 137584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137584=edit Bug 22456: Add cancellation request methods to Koha::Hold This patch adds the following helper methods for dealing with hold cancellation requests to the Koha::Hold class: * cancellation_requests * add_cancellation_request * cancellation_requestable_from_opac * cancellation_requested_by_owner To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #81 from Tomás Cohen Arazi --- Created attachment 137583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137583=edit Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) This patch adds the Koha::Object-derived classes for cancellation requests. Tests are added for the overloaded ->store method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #80 from Tomás Cohen Arazi --- Created attachment 137582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137582=edit [DO NOT PUSH] Bug 22456: DBIC update Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #79 from Tomás Cohen Arazi --- Created attachment 137581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137581=edit Bug 22456: Add waiting_hold_cancellation circulation rule This patch adds handling for the waiting_hold_cancellation circulation rule. It is set no 'No' by default in the atomic update, if not previously set. Handling in the rules editor is added, in its own section. To test: 1. Apply this patch 2. Run: $ updatedatabase => SUCCESS: All good 3. Verify that the syspref is set: $ koha-mysql kohadev > SELECT * FROM circulation_rules WHERE rule_name='waiting_hold_cancellation'; => SUCCESS: Set to 0 4. Play with the rules editor, changing things back and forth, things should work, including library-specific and global/defualt settings. => SUCCESS: It works => SUCCESS: Texts are idiomatic 5. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #78 from Tomás Cohen Arazi --- Created attachment 137580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137580=edit Bug 22456: Add cancellation request table This patch adds a new table, for storing holds cancellation requests, and managing them afterwards. The *hold_id* attribute is not made a FK on the reserves table because of the old_reserves thing we still do (see bug 25260 for a discussion about it). Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135839|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135838|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135846|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135845|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135844|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135843|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135842|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135841|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135840|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20439] SMS provider sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20439] SMS provider sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 --- Comment #3 from Lucas Gass --- Created attachment 137579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137579=edit Bug 20439: Sort SMS providers in alphabetical order To test: 1/ Add 'Email' to the 'SMSSendDriver' system preference. 2/ Make sure 'EnhancedMessagingPreferencesOPAC' and 'EnhancedMessagingPreferences' are turned on. 3/ Add some SMS providers (/cgi-bin/koha/admin/sms_providers.pl) with different names. 4/ Notice on memberentry.pl and opac-messaging.pl the SMS providers sort by when they were added, not alphabetically. 5/ Apply patch and restart services. 6/ Look at memberentry.pl and opac-messaging.pl and notice that they SMS providers now sort alphabetically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20439] SMS provider sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31127] By default sort suggestions from latest to oldest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Kyle M Hall changed: What|Removed |Added Attachment #37446|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 137578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137578=edit Bug 12225: Fix SIP message templates If a renewal via SIP would produce an error due to being on reserve, or exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the item even if the "no block" flag is set to Y. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #7 from Nick Clemens --- Created attachment 137577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137577=edit Bug 31128: Add effective_not_for_loan_status into items response Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Nick Clemens changed: What|Removed |Added Attachment #137574|0 |1 is obsolete|| Attachment #137575|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 137576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137576=edit Bug 31128: Unit tests This patch adds unit tests for the new effective_not_for_loan_status which I add to the items api responses in this patchset. Test plan 1) Run the unit test without applying the next commit, it should fail 2) RUn the test again after applying the next commit, it should pass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Nick Clemens changed: What|Removed |Added Attachment #137508|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 137575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137575=edit Bug 31128: Add effective_not_for_loan_status into items response -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Nick Clemens changed: What|Removed |Added Attachment #137507|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 137574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137574=edit Bug 31128: Unit tests This patch adds unit tests for the new effective_not_for_loan_status which I add to the items api responses in this patchset. Test plan 1) Run the unit test without applying the next commit, it should fail 2) RUn the test again after applying the next commit, it should pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA CC||n...@bywatersolutions.com --- Comment #17 from Nick Clemens --- I think this is fine, as long as this feature (item-level_itpyes set to 'biblio') exists - libraries using biblio itemtypes seem to be in the minority according to: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106 If we remove the feature later, we remove the extra field small patch, straight to PQA to let RM weigh in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26933 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28180 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26933 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 Owen Leonard changed: What|Removed |Added Summary|OPAC - Multiple cover image |Improve handling of |show in results and details |multiple covers on catalog |pages |search results in the OPAC Status|NEW |ASSIGNED See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25846 --- Comment #2 from Owen Leonard --- Since the OPAC detail page has already been upgraded to handle multiple covers like the staff interface has, I'm re-titling this bug to cover only OPAC search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
