[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #134477|0 |1 is obsolete|| --- Comment #97 from Aleisha Amohia --- Created attachment 137694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137694=edit Bug 3150: (follow-up) Fixing errors and notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #134307|0 |1 is obsolete|| --- Comment #96 from Aleisha Amohia --- Created attachment 137693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137693=edit Bug 3150: (follow-up) Add missing bracket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #134306|0 |1 is obsolete|| --- Comment #95 from Aleisha Amohia --- Created attachment 137692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137692=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #134305|0 |1 is obsolete|| --- Comment #94 from Aleisha Amohia --- Created attachment 137691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137691=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #134304|0 |1 is obsolete|| --- Comment #93 from Aleisha Amohia --- Created attachment 137690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137690=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED Version(s)|22.11.00, 22.05.01, |22.11.00, 22.05.01, released in|21.11.10|21.11.10, 21.05.17 --- Comment #12 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.17 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30551] Cash register report shows wrong library when paying fees in two different libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED Version(s)|22.05.00|22.05.00,21.05.17 released in|| --- Comment #10 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.17 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30551] Cash register report shows wrong library when paying fees in two different libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30551] Cash register report shows wrong library when paying fees in two different libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to master|Pushed to stable --- Comment #9 from Victor Grousset/tuxayo --- Note: was backported to 21.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #20 from David Nind --- I tested (after making the change in comment #19) using koha-testing-docker. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the file was saved in the koha directory - adjust file location as appropriate):[1] misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches.[2] 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that all the Feminism headings are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record ids for the various feminism authority records)).[3] [1] After importing the authorities, I got an error and had to reindex: misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 Characteristic MARC flavour: MARC21 .One or more ElasticSearch errors occurred when indexing documents at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148. .One or more ElasticSearch errors occurred when indexing documents at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148. .One or more ElasticSearch errors occurred when indexing documents at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148. [2] After applying the patch I edited mappings.yaml to remove the nomarc entry that was added so the resetting the mappings worked vi admin/searchengine/elasticsearch/mappings.yaml - remove lines 750-754 added by the mapping patch [3] Not all links to feminism are linked to authority records. Links for subject terms for step 9 in order are: Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur; MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #70 from Victor Grousset/tuxayo --- > The current patch is quite different than the previous one so I marked the > previous tests as obsolete. Makes sense. Tests on the new changes are still needed for this to be ready for QA. These are not trivial changes and AddReturn() in Circulation.pm is like super critical code ^^" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #43) > Backported: Pushed to 21.05.x branch for 21.05.17 Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #12 from Victor Grousset/tuxayo --- > The bit you highlight Victor is actually just a comment rather than test > condition. Ah, it's just string that pops when the test fails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Passed QA |Pushed to oldoldstable Version(s)||21.05.17 released in|| --- Comment #43 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|22.05.00,21.11.05 |22.05.00,21.11.05,21.05.17 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Bug 25439 depends on bug 28610, which changed state. Bug 28610 Summary: Elasticsearch 7 - hits.total is now an object https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #25 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.17 Nothing to document (not yet full support for ES 7), marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #19 from David Nind --- Hi Frank. I think I'm getting the error because of lines 750-754 from the admin/searchengine/elasticsearch/mappings.yaml patch. If I remove those lines, then I can reset the mappings without an error. NORMARC was removed from Koha from 21.11 - see bug 187984 David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30035] Wrong month name in numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 --- Comment #12 from Victor Grousset/tuxayo --- Reverted from 21.05.x to fix Ubuntu 16.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA CC||vic...@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #24 from David Nind --- Testing notes (using koha-testing-docker): - Patch still applies. - Things work as per the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31153] Search bar not visible on recalls history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 137689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137689=edit Recalls history page The is the Recalls history page. Note that the logo and search bar are not visible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31153] Search bar not visible on recalls history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 137688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137688=edit Holds history page for comparison This is the holds history page, for comparison. Note that the logo and search bar are visible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added Attachment #127098|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 137687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137687=edit Bug 29114: Trim whitespace before the barcode The solution was to add regexp that trims all whitespaces. How to test: 1. Go to the koha/virtualshelves/shelves.pl; 2. Add new list or edit existing one; 3. Start adding new items; 4. In the "Barcode" field add barcode(s) with whitespaces before them; 5. Observe that it wasn't added as the barcode isn't recognized because of whitespaces; 6. Apply the patch; 7. Repeat step 4; 8. Observe that the item was successfully added; Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31153] New: Search bar not visible on recalls history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 Bug ID: 31153 Summary: Search bar not visible on recalls history page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When accessing the 'Recalls history' tab in a patron's file in the staff interface, the section where the Koha logo and search bar are disappears. To test: 1) Turn on recalls 1.1) In Administration > Global system preferences, enable UseRecalls 1.2) Add recalls permissions in your circulation rules 2) In the OPAC, log in as a patron 3) Find a record with checked out items and place a recall 4) In the staff interface, go to the patron's account 5) Click on any tab on the left in the patron's account (e.g. Holds history) --> Note that the Koha logo and search bar is at the top of the page between the module menu and the breadcrumbs 6) Click on the 'Recalls history' tab --> Note that the Koha logo and search bar disappear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync with upgraded databases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836 --- Comment #4 from Tomás Cohen Arazi --- We ceratinly need to define a good way to patch things in production for the regular user, leaving room so we don't break more advanced users setups. If this is not doable, then we need to document better how to reset the indexes, or provide a tool to let them know they are out of sync. This is a blocker for several enhancements. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225
David Nind changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #17 from David Nind ---
(In reply to Kyle M Hall from comment #16)
> David, can you test again with the latest patch? It switches to using the
> offline circ checkout code. The idea behind "no block" is the patron already
> has it. It's basically SIP offline circ ( aka store and forward ) where the
> patron already has it so we'd better check it out to them! It makes sense to
> use the same code for both.
Hi Kyle.
I have retested
When I post the command in step 5 with the patches applied and after restarting
everything:
- Telnet exits saying: Connection closed by foreign host.
- The item is not checked out.
Commands entered after applying patches, flush_memcached, restart_all, and
koha-sip --restart kohadev:
telnet 127.0.0.1 6001
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
9300CNkoha|COkoha|CPCPL|
941
11YY2022071116350220250711
163502AOCPL|AA2352935676|AB301396|ACkoha|BON|BIN|
Connection closed by foreign host.
From the sip.log:
87 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying 6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
88 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying *:6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
89 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying 127.0.0.1:6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
90 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]: raw_transport:
timeout is 60 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
91 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: read_request trimmed
1 character(s) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
92 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: INPUT MSG:
'9300CNkoha|COkoha|CPCPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
93 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '9300CNkoha...', '93'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
94 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]:
Sip::MsgType::_initialize('Login', '00CNkoha|COkoha|CPCPL', 'A1A1', '2', ...)
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
95 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: Successful login/auth
for 'koha' of 'CPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
96 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: login_core: $VAR1 =
'ILS';
97 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
98 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: new ILS 'CPL'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
99 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: OUTPUT MSG: '941'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
100 [2022/07/13 21:16:43] [4660] [DEBUG] koha@127.0.0.1: raw_transport:
uname/inst: 'koha/CPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
101 [2022/07/13 21:16:56] [4660] [DEBUG] koha@127.0.0.1: read_request trimmed 2
character(s) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
102 [2022/07/13 21:16:56] [4660] [INFO] koha@127.0.0.1: INPUT MSG:
'11YY2022071116350220250711
163502AOCPL|AA2352935676|AB301396|ACkoha|BON|BIN'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
103 [2022/07/13 21:16:56] [4660] [DEBUG] koha@127.0.0.1:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '11YY202207...', '11'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
104 [2022/07/13 21:16:56] [4660] [DEBUG] koha@127.0.0.1:
Sip::MsgType::_initialize('Checkout', 'YY2022071116350220250711
163502AOCPL|AA2352935676|AB301396|ACkoha|BON|BIN',
'A1A1A18A18', '38', ...) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
105 [2022/07/13 21:16:56] [4660] [WARN] koha@127.0.0.1: received no-block
checkout from terminal 'koha' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
106 [2022/07/13 21:16:56] [4660] [DEBUG] koha@127.0.0.1: new
ILS::Patron(2352935676): found patron '2352935676' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
107 [2022/07/13 21:16:56] [4660] [DEBUG] koha@127.0.0.1: new
ILS::Item('301396'): found with title 'Philippics.'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
108 [2022/07/13 21:16:56] [4660] [DEBUG] koha@127.0.0.1:
ILS::Transaction::Checkout performing checkout... C4::SIP::Sip::siplog
/kohadevbox/koh a/C4/SIP/Sip.pm (220)
109 [2022/07/13 21:16:56] [4660] [INFO] koha@127.0.0.1: raw_transport: shutting
down
[Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Emily W changed: What|Removed |Added CC||emily.warwas@cedarparktexas ||.gov --- Comment #4 from Emily W --- Recently began having this issue. Digests will be checked when creating the guarantee but will uncheck once saved. Takes up staff time adding an additional step to sign up process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31152] EasyAnalyticalRecords - trim leading whitespace from barcode when linking to host record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31152 David Nind changed: What|Removed |Added Summary|EasyAnalyticalRecord - trim |EasyAnalyticalRecords - |leading whitespace from |trim leading whitespace |barcode when linking to |from barcode when linking |host record |to host record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31152 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31152] EasyAnalyticalRecord - trim leading whitespace from barcode when linking to host record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31152 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30409 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31152] New: EasyAnalyticalRecord - trim leading whitespace from barcode when linking to host record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31152 Bug ID: 31152 Summary: EasyAnalyticalRecord - trim leading whitespace from barcode when linking to host record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: da...@davidnind.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When adding analytical record relationships the easy way with the EasyAnalyticalRecords system preference enabled, any leading whitespace in the barcode is not trimmed. To reproduce: 1. Enable the EasyAnalyticalRecord system preference - change to 'Show'. 2. Copy a barcode from any item, for example: 300498 3. For any record with item, select Edit > Link to host record. 4. Enter item barcode: - paste the barcode into the input field - put spaces before the barcode - press 'Select'. 5. Note error message: "ERROR: Unable to get the item number from this barcode.". Notes: - Only leading whitespace causes the error, trailing whitespace does not cause the error. - Recent bug 30409 did some work on consolidating barcode checking. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30989] Tags with some special characters are not encoded right
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30925] Creating public list by adding items to new list creates a private list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30925 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.03 released in|| CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.03 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #38 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30938] Fix column configuration to the acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.03 released in|| --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30954] includes/background_jobs_update_elastic_index.inc must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30954 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.03 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #5 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30973] Serials search wrong body id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30973 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #7 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30974] Job size not correct for indexing jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30974 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.03 released in|| --- Comment #5 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30420] Rename Koha::Patron->get_overdues with ->overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Needs documenting --- Comment #5 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Needs documenting --- Comment #40 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Needs documenting --- Comment #8 from Lucas Gass --- Enhancement will not be backported to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.03 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #26 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #10 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.03 released in|| --- Comment #13 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30798] Columns Home library and Checked out from in wrong order on table settings for account_fines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30924] Fix recalls-related errors in transfers and cancelling actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.03 released in|| CC||lu...@bywatersolutions.com --- Comment #18 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071 ByWater Sandboxes changed: What|Removed |Added Attachment #137657|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 137686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137686=edit Bug 31071: Regression: date due removed from staff search results This patch corrects a regression caused by Bug 28321, which inadvertently removed the date due from output of item information in each search result. To test, apply the patch and perform a catalog search which will return some results which are checked out and some which aren't. Confirm that the checked out items show the date due correctly. Signed-off-by: David Nind Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30399] Patron.t fails when there is a patron attribute that is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.03 released in|| --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26170] Create "system" patrons that cannot be (easily) deleted via the web UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #7 from Liz Rea --- Maybe a default attribute of "undeletable," just to be general -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #137684|0 |1 is obsolete|| --- Comment #503 from Martin Renvoize --- Created attachment 137685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137685=edit Bug 28854: (follow-up) Replace unique constraint in return claims This patch fixes the failing test for the return claims api. We add a new unique constraint to replace the one we removed earlier in the patchset. One should not be able to create a duplicate return claim for the same issue of an item. Test plan 1) Run the database update 2) Confirm that t/db_dependent/api/v1/return_claims.t now passes 3) Confirm that t/db_dependent/api/v1/items.t continues to pass 4) Bonus points, confirm that bundle checkin still works when items are missing Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #502 from Martin Renvoize --- Follow-up attached to fix the failing introduced here on master. Not sure why I didn't think about this constraint replacement in the first place, it's a nice improvement over the simple removal I did before and shouldn't have any negative side effects on the feature introduced here. The follow-up includes an atomic update and the kohaschema change but does not include the dbic schema build ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #501 from Martin Renvoize --- Created attachment 137684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137684=edit Bug 28854: (follow-up) Replace unique constraint in return claims This patch fixes the failing test for the return claims api. We add a new unique constraint to replace the one we removed earlier in the patchset. One should not be able to create a duplicate return claim for the same issue of an item. Test plan 1) Run the database update 2) Confirm that t/db_dependent/api/v1/return_claims.t now passes 3) Confirm that t/db_dependent/api/v1/items.t continues to pass 4) Bonus points, confirm that bundle checkin still works when items are missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071 --- Comment #7 from Owen Leonard --- (In reply to Emmanuel Bétemps from comment #6) > Could we rather get something like This patch fixes a regression, so it doesn't make changes to the order of the elements. A separate bug could be filed to talk about improvements to the display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New interface for staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7021] Add patron category to the statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > Not a big deal but this one seems weird to me. Why don't you pass the data > you need instead? TestBuilder is never going to put useful info here, seemed reasonable to default to NULL I don't need anything in these, but it did sometime interfere with testing or demo when fields had to be corrected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7021] Add patron category to the statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #45 from Sally --- We'd really love to see this feature in Koha. We don't use pseudonymization as there are statistics that we pull together where we reference date of birth. Pseudonymization definitely has a place, but we've developed policies to ensure that we're processing our collected data in line with GDPR and with consent granted by our patrons. The statistics table is the heart of our performance statistics, and having a permanent record of which category a patron was in would be a major step forward for us. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 --- Comment #6 from Jonathan Druart --- Not a big deal but this one seems weird to me. Why don't you pass the data you need instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31058] Bad import in auto_unsuspend_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31058 evelyn changed: What|Removed |Added CC||eve...@bywatersolutions.com --- Comment #5 from evelyn --- Can this be backported to 21.11? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31141] We can remove 'select_column' from waiting_holds.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31141] We can remove 'select_column' from waiting_holds.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #500 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31151] On mobile, the sticky menu when viewing a list is very big
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31151 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync with upgraded databases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836 Nick Clemens changed: What|Removed |Added CC||ere.maij...@helsinki.fi, ||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #16 from Kyle M Hall --- David, can you test again with the latest patch? It switches to using the offline circ checkout code. The idea behind "no block" is the patron already has it. It's basically SIP offline circ ( aka store and forward ) where the patron already has it so we'd better check it out to them! It makes sense to use the same code for both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #15 from Kyle M Hall --- Created attachment 137683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137683=edit Bug 12225: Use ProcessOfflineIssue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #69 from Shi Yao Wang --- The current patch is quite different than the previous one so I marked the previous tests as obsolete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31151] On mobile, the sticky menu when viewing a list is very big
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31151 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 137682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137682=edit List view on 21.05 on iPhone8 This is a screenshot of my phone, an iPhone8, with Safari, viewing a 21.05 OPAC. The sticky menu takes up almost half the screen space. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31151] New: On mobile, the sticky menu when viewing a list is very big
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31151 Bug ID: 31151 Summary: On mobile, the sticky menu when viewing a list is very big Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When a patron views their list on mobile, the sticky menu can take up to half the screen depending on the device. To test: 1) Using a smartphone or your browser's mobile view tool, go to the OPAC 2) Log in as a patron 3) Create a list 4) Add items to the list (at least 2 or 3) 5) View the list, scroll down The sticky menu has lots of options New list, download, send list, etc. and it takes up a lot of space. I think the sticky menu is fun, but on mobile, it should maybe be a couple of option plus a burger menu (three lines)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Nick Clemens changed: What|Removed |Added Attachment #136505|0 |1 is obsolete|| Attachment #136506|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 137681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137681=edit Bug 10086: Link to go to basket from uncertain prices page This patch moves the Edit button into an Edit column, styled with bootstrap button and font awesome icon, and adds a link on the basket name to go to the basket. To test: 1) Add an item with uncertain prices to a basket 2) Go to the vendor of the basket 3) Click Uncertain prices on the left 4) Notice 'edit' button does not look like a button, and basket name is not a link 5) Apply patch and refresh page 6) Basket name is now a link. Click to confirm it takes you to the right page 7) Edit button is now in edit column. Confirm it works as expected 8) Confirm you cannot sort on Edit column and the button does not wrap on a narrower browser 9) Check that the correct information is displayed for the order column (title, author, publisher code, publication year, copyright date, isbn) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #8 from Jonathan Druart --- Yes, that's for the API, not the DB :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31114] OpacHiddenItems is not respected in search results when an OPAC search is filtered by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114 --- Comment #4 from Lucy Vaux-Harvey --- Thanks Katrin. I have marked this as an enhancement. The libraries in our larger Koha systems use the library filtering quite a bit so it would be good if opachiddenitems could be taken into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31114] OpacHiddenItems is not respected in search results when an OPAC search is filtered by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114 Lucy Vaux-Harvey changed: What|Removed |Added Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #7 from Martin Renvoize --- Found it.. we voted https://meetings.koha-community.org/2020/development_irc_meeting_5_february_2020.2020-02-05-20.00.log.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #6 from Martin Renvoize --- Hmm, we dropped the 'DRAFT' part from the API Guidelines wiki page in the evening of 5th Februrary 2020, and I presume I only did that after we voted and agreed to it in a meeting.. I'll go hunting. https://wiki.koha-community.org/w/index.php?title=Coding_Guidelines_-_API=historysubmit=24914=24910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #51 from Martin Renvoize --- Must admit, I didn't do a code review here.. just confirmed the feature worked as described. As you've adopted this one Owen, feel free to ask for help to update it to more usual practices.. I'm happy to help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #5 from Daniel Jones --- (In reply to Aleisha Amohia from comment #4) > (In reply to Daniel Jones from comment #3) > > Signing off as test plan works as described. > > > > One thing I noticed was that I couldn't complete the hold by checking in the > > item. Is this expected behaviour? > > Do you mean you couldn't set the hold as waiting? Or fill the hold? > > What do you mean by complete the hold? The hold cannot be filled. Once it is checked in, the book just asks to be returned to its home library, and not sent to the patron's library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #50 from Jonathan Druart ---
+my $borrowernumber = $cgi->param('borrowernumber') || undef;
$borrowernumber MUST be retrieved from get_template_and_user (or another
C4::Auth method), not from the query parameters.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #49 from Jonathan Druart --- There is NO authentication check, everybody (no need to be loggedin) can delete a message. This is a hard fail. Really, it would have been better (and easier for everybody) to follow the usual pattern we have in our scripts, than decide on something that is not Koha-styled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #5 from Jonathan Druart --- (In reply to Martin Renvoize from comment #2) > Interesting.. I think we've since settled on _date to stay in line with the > also recent discussions around api field names as described here: > https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4: > _mapping > > We should update the db fields page you linked to link between the two > definitions and make sure they're consistent. We never decided either. Hence this bug report. See previous comment. If we move to "*_date", does it include datetime and timestamp, etc. It's not that trivial. And in my mind we decided on "_on", or at least I picked that because it had the more occurrences in the codebase. There is no record of a community decision (at least I didn't find one). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #4 from Martin Renvoize --- As for existing inconsistencies.. I'd love to fix those but I always get met with the "This will break reports" argument so in general I've ended up leaving the DB inconsistent and kept the old field names. I did have some partners complaining only a day ago that it's really annoying that our API field names dont match our database field names.. but I do think the API is much more consistent and better named in general... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #3 from Jonathan Druart --- At 20200129 dev meeting we discussed about _date for the REST API (does it cover timestamp and datetime as well, etc.) https://meetings.koha-community.org/2020/development_irc_meeting_29_january_2020.2020-01-29-14.00.log.txt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #2 from Martin Renvoize --- Interesting.. I think we've since settled on _date to stay in line with the also recent discussions around api field names as described here: https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4:_mapping We should update the db fields page you linked to link between the two definitions and make sure they're consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #1 from Jonathan Druart --- IRC log, 20200723 remind me of our policy on db column name consistency There_isNoCon_sistency! lol! maybe this? https://wiki.koha-community.org/wiki/DBIC_naming_conventions for a date, should end with _on or _date, apparently if above link is not good, let me know and I'll add a warning saying this is not accurate I don't know for you, but I feel like no column should ever be called just "id", but somethingid, so that it's the same in all tables I wrote that guideline I think. oh.. maybe not.. maybe I wrote the corresponding api one I prefer _on.. but don't really like inconsistency within a table but I also don't want to update other fields in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #48 from Jonathan Druart --- DB naming (suffix _date), see bug 31150. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] New: _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 Bug ID: 31150 Summary: _on or _date for DB date columns? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: martin.renvo...@ptfs-europe.com, n...@bywatersolutions.com, tomasco...@gmail.com We need to decide a naming for the dates column. We have _on and _date: % git grep -c '_date`' installer/data/mysql/kohastructure.sql installer/data/mysql/kohastructure.sql:14 % git grep -c '_on`' installer/data/mysql/kohastructure.sql installer/data/mysql/kohastructure.sql:31 I've tried to find previous discussion but haven't found much. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31149] Use dayjs to parse dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC||martin.renvoize@ptfs-europe ||.com, oleon...@myacpl.org, ||tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31149] Use dayjs to parse dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149 --- Comment #1 from Jonathan Druart --- Created attachment 137680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137680=edit Bug 31149: Use dayjs to parse dates We can use the isValid's dayjs function instead of our own parsing functions. Test plan: Confirm that you cannot enter an invalid date when using a date picker widget. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
