[Koha-bugs] [Bug 31193] New: API error when receiving orders

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31193

Bug ID: 31193
   Summary: API error when receiving orders
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

We've noticed that when receiving orders, we can't seem to filter the results
using the search boxes in the pending orders table.

When we type in the 'summary search' filter for example, this error shows in
the console:

GET
https://toi-ohomai-admin.test.mykoha.co.nz/api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20&_match=contains&_order_by=+basket.name
[HTTP/1.1 500 Internal Server Error 173ms]
DataTables warning: table id=pending_orders - Ajax error. For more information
about this error, please see http://datatables.net/tn/7

And the API error log shows:

[2022/07/20 16:02:28] [ERROR] GET /api/v1/acquisitions/orders: unhandled
exception (DBIx::Class::Exception)<>
Koha::REST::Plugin::Exceptions::ANON
/usr/share/koha/lib/Koha/REST/Plugin/Exceptions.pm (73)

The biblioitem.title field doesn't exist. I imagine this is something to do
with the code in Koha/REST/V1/Acquisitions/Orders.pm

Can anyone else reproduce this bug? Do we know a fix?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15326] Add CMS feature

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Aleisha Amohia  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31188] UPC or ASIN from amazon for dvd, music cds image

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31188

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
The cover images code could really use some improvements more generally I think
but I think it would take a sponsored effort to do it.

With the UPC, you could use "024$a1234$2upc" from a data point of view, and
then update the code to handle that case. 

Using the ASIN would be harder... since asin/Amazon isn't a standard code for
the 024 $2 subfield (which is interesting since "spotify" is so clearly there
are some fairly recent codes in there)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27667] Display the number of non-indexed records

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #12 from David Cook  ---
Some day, it would be nice to make about.pl use more asynchronous calls. 

I often look at about.pl when I want to double-check a Koha instance's version
and it takes so long to load these days...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29001] Subfields attributes are not preserved when order is changed in framework

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Thibault Keromnès  changed:

   What|Removed |Added

 CC||thibault.keromnes@univ-pari
   ||s8.fr
 Status|Needs Signoff   |Failed QA

--- Comment #3 from Thibault Keromnès  ---
The patch fixes the issue but brings another one, I can't mark a subfield as
repeatable now (if i check the 3 attributes and save the subfield will be
mandatory and important but not repeatable). 
I don't have this issue with the current master.

I change the status to failed QA, not sure it's the right one, feel free to
change it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds
  release notes||support for displaying and
   ||linking to subject headings
   ||from different thesaurus
   ||when using Elasticsearch.
   ||The thesaurus used for the
   ||term is added to the
   ||authority record using
   ||040$f. For the
   ||bibliographic record, set
   ||the second indicator to 7
   ||for 650 and add the source
   ||to 650$2. For local terms,
   ||use 4 (Source not
   ||specified) as the
   ||indicator.
   ||
   ||Example for a
   ||bibliographic record:
   ||
   ||650
   ||_ 0 $a Feminism
   ||650 _ 7 $a
   ||Feminism $2 sao
   ||650 _ 7 $a
   ||Feminism $2 barn
   ||
   ||The first
   ||example above is the LCSH
   ||term. The other two terms
   ||are from sao (controlled
   ||Swedish subject heading
   ||system) and barn (Swedish
   ||children subject heading
   ||system). These three are
   ||using the same TOPIC_TERM
   ||Feminism, but they belong
   ||to different thesaurus.

--- Comment #29 from David Nind  ---
(In reply to Frank Hansen from comment #25)
> I fixed the mapping issue

Thanks Frank!

I have re-tested and signed off.

Re replies on comment #21 - thanks for the explanations for my footnote [3]. I
also didn't get the error message mentioned in my footnote [1] this time, so
not sure what was going on whenI orginally tested this...

The QA Team may ask you to amend the patches as per the commit message
guidelines https://wiki.koha-community.org/wiki/Commit_messages

I've had a go at the text for the release note, feel free to update it as I'm
not sure I've described this correctly.

Test plan:
1. Enable Elasticsearch as the search engine (SearchEngine system preference =
Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev).
2. Load sample authority records attached to the bug (in this case the
authorities.mrc file was saved in the koha directory - adjust file location as
appropriate):
   misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert
-c=MARC21
3. Load the sample bibliographic record attached to the bug:
   misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert
-c=MARC21
4. Search for ISBN 0704328623 and verify that the subject terms are not linked
to any authority records (if you hover over the link terms, all links should
look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should
have any ?q=an:XXX (where XXX = authority record ids) in the link).
5. Apply the patches.
6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine
configuration (Elasticsearch)).
7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
8. Link bibliographic records to authority records:
misc/link_bibs_to_authorities.pl -v -l
9. Repeat the search in step 4 (or refresh the record details page) and verify
that the first three Feminism headings[1] are linked to an authority record
(should have ?q=an:XXX (where XXX = different authority record IDs for the
various feminism authority records linked to a specific thesaurus)).
10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev

[1] Links for subject terms for step 

[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind  changed:

   What|Removed |Added

 Attachment #137820|0   |1
is obsolete||

--- Comment #28 from David Nind  ---
Created attachment 137892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137892=edit
Bug 30280: Removing tab character in Heading.pm

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind  changed:

   What|Removed |Added

 Attachment #137818|0   |1
is obsolete||

--- Comment #26 from David Nind  ---
Created attachment 137890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137890=edit
Bug 30280: Add a new mapping authority marc field 040\$f

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind  changed:

   What|Removed |Added

 Attachment #137819|0   |1
is obsolete||

--- Comment #27 from David Nind  ---
Created attachment 137891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137891=edit
Bug 30280: Handle subject headings from differens thesaurus

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31184] Add default permissions by patron category

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31184

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30882] Add max_result_window to index config

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882

David Nind  changed:

   What|Removed |Added

  Text to go in the||This updates the number of
  release notes||results set by default in
   ||Elasticsearch for the
   ||setting
   ||"index.max-result-window"
   ||from  10,000 to 1,000,000.
   ||This can be useful for
   ||really large catalogs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes a regression
  release notes||introduced in Koha 21.11
   ||that inadvertently removed
   ||the date due in the staff
   ||interface search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27667] Display the number of non-indexed records

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

David Nind  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds   |This enhancement adds
  release notes|information about   |information about
   |non-indexed records when|non-indexed records when
   |using the Elasticsearch |using the Elasticsearch
   |search engine on the About  |search engine on the About
   |Koha > System information   |Koha > System information
   |page.
  |page.
   |
   |
   |For example:
   |For example:
   ||
   |Records are missing in  |Records are not indexed in
   |Elasticsearch search engine |Elasticsearch
   |- Warning  1 record(s)  |- Warning 1
   |missing on a total of 435   |record(s) missing on a
   |in indice   |total of 435 in index
   |koha_kohadev_biblios.
  |koha_kohadev_biblios.record
   |-   |(s).
   |Warning  1 record(s)|- Warning 1 record(s)
   |missing on a total of 1705  |missing on a total of 1705
   |in indice   |in index
   |koha_kohadev_authorities.   |koha_kohadev_authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs. Print (noun)

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds
  release notes||context for translation
   ||purposes to the term
   ||'Print' for notices and
   ||slips message transport
   ||types (email, print, SMS).
   ||(In English, the word
   ||"print" is the same whether
   ||it is a verb (to print
   ||something) or a noun (a
   ||print of something),
   ||however, for other
   ||languages different words
   ||may be used. When the word
   ||is in a sentence, it's not
   ||too difficult to translate,
   ||but in cases where the
   ||string to translate is
   ||simply "Print", it is often
   ||used in different cases
   ||(noun or verb). For
   ||example: in French there
   ||are two different
   ||spellings, "Imprimer" or
   ||"Imprimé".)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

knmarti...@santafenm.gov changed:

   What|Removed |Added

 CC||knmarti...@santafenm.gov

--- Comment #118 from knmarti...@santafenm.gov ---
Addressing accessibility concerns presented by others, I have to second this.
If categories on the home page are no longer neatly grouped, navigation and
orientation will take longer and I anticipate my staff having difficulty with
this. In present format, eyes do tend to drift across the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30858] Add serial enumeration/chronology to itemsearch.pl

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement to the
  release notes||item search in the staff
   ||interface adds a serial
   ||enumeration/chronology
   ||(952$h) column to the
   ||search results and export.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30858] Add serial enumeration/chronology to itemsearch.pl

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

David Nind  changed:

   What|Removed |Added

 Attachment #137850|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 137889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137889=edit
Bug 30589: (follow-up) Add enumchron to CSV export and fix CSS class

https://bugs.koha-community.org/show_bug.cgi?id=30858

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30858] Add serial enumeration/chronology to itemsearch.pl

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

David Nind  changed:

   What|Removed |Added

 Attachment #137849|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 137888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137888=edit
Bug 30858: Add serial enumeration/chronology to item search

To test:
1. Apply patch
2. Go to  Catalog > Item search and do a search for items that you know contain
a items.enumchron
3. The result set should now show the items.enumchron
4. Make sure you can properly "Export results to.."

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30858] Add serial enumeration/chronology to itemsearch.pl

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Nick Clemens  changed:

   What|Removed |Added

 Blocks||31192


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192
[Bug 31192] Checking in an unkown barcode causes error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Nick Clemens  changed:

   What|Removed |Added

 Depends on||28854


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items for circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31192] New: Checking in an unkown barcode causes error

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Bug ID: 31192
   Summary: Checking in an unkown barcode causes error
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Can't call method "is_bundle" on an undefined value at
/kohadevbox/koha/circ/returns.pl line 413

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #5 from Caroline Cyr La Rose  ---
I changed the .pref file, I'm not sure if that's where it's changed or if it's
the only place... Let me know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #4 from Caroline Cyr La Rose  ---
Created attachment 137887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137887=edit
Bug 31191: Specify FacetLabelTruncationLength is only for Zebra

This patch adds a note in the description of FacetLabelTruncationLength
that it only works with Zebra.

To test:
0) Apply patch
1) Go to Administration > Global system preference > Searching
preferences
2) Search for FacetLabelTruncationLength
3) Read the description, make sure it indicates that is requires Zebra

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #3 from Caroline Cyr La Rose  ---
In my test, I did not change the FacetLabelTruncationLength system preference
when I changed search engines. 

I also did not specify staff interface or OPAC, but it does the same thing in
both interfaces.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 137886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137886=edit
Screenshot of facets with Elasticsearch

This is a screenshot of facets with Elasticsearch. Note that the longer ones
are there in full, e.g. "Association for Scottish Literary Studies"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 137885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137885=edit
Screenshot of facets with Zebra

This is a screenshot of facets with Zebra. Note that the longer ones are
truncated with an ellipsis, e.g. "Association for Scot..."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] New: Specify FacetLabelTruncationLength is only for Zebra

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Bug ID: 31191
   Summary: Specify FacetLabelTruncationLength is only for Zebra
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When using ElasticSearch, the FacetLabelTruncationLength system preference
doesn't apply. I don't know if it's a bug or by design. Maybe it should be
indicated in the syspref description that it only works with Zebra?

To test:
1) Change the searchengine syspref to Zebra
2) Reindex
3) Do a search
4) Check the facets
   --> The longer ones should be truncated to 20 characters
5) Change the seachengin syspref to Elasticsearch
6) Redo steps 2-4
   --> The longer facets are displayed in full

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

--- Comment #14 from Joonas Kylmälä  ---
Fixes the issue as advertised, passing QA.

On an unrelated note whilst testing this bug I noticed that we seem to have a
cache invalidation problem with Koha to MARC mapping. After removing the 952$k
mapping to items.permanent_location I had to restart all koha services (i guess
memcached would have been plenty) for the functionality to return to original,
that is, when location is updated also permanent_location is updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #137873|0   |1
is obsolete||

--- Comment #13 from Joonas Kylmälä  ---
Created attachment 137884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137884=edit
Bug 30909: Retain permanent_location if mapped

If items.permanent_location is mapped to a MARC subfields we must retain
the value, not using items.location

Test plan:
1 - Map permanent_location to a marc field
2 - Expose that field in the item editor
3 - Change the location of the item and retain the permanent location on saving
4 - note that permanent location has not changed

Test the different other situation, when adding and editing: Empty the field,
change only location, change only permanent_location, etc.

Signed-off-by: andrew 

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #137877|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 137883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137883=edit
Bug 31179: (QA follow-up) Set field as hidden for tests

We want the tests to pass in the case where field is set to visibile in Koha

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #137876|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 137882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137882=edit
Bug 31179: (QA follow-up) POD fix

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #137875|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 137881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137881=edit
Bug 31179: Don't copy invisible subfields when duplicating items

Duplicate item is intended to duplicate the visible cataloging fields of an
item, however,
currently it is duplicating the complete internal record of the item

To recreate:
1 - find an item in Koha staff client, copy the barcode
2 - Issue this item to a patron
3 - Return to the record
4 - Edit items
5 - Click 'Actions->Duplicate' for the item in question
6 - Save the item
7 - Note in the items table above for that 'Total checkouts' 'Due date'
 etc. have not been copied to new item

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Joonas Kylmälä  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi
   |y.org   |
 CC||joonas.kylm...@iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off
 CC||tomasco...@gmail.com

--- Comment #22 from Tomás Cohen Arazi  ---
@Marcel and @Martin. Please review my follow-ups. I'll push the tree if we
agree with them. Would like your signature, though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #21 from Tomás Cohen Arazi  ---
Created attachment 137880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137880=edit
Bug 30933: Add lists methods for disowning

This patch aims to tidy things a bit by doing the following changes:

* Koha::Virtualshelf gets the 'transfer_ownership' method
* Koha::Virtualshelves gets the 'disown_or_delete' method
* Koha::Patron->delete gets rewritten/simplified by using
  disown_or_delete

The idea is to capture the current behavior in more fine grained
methods. So current tests should be passing as they do now.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t \
   t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run:
  k$ prove t/db_dependent/Koha/Virtualshelf.t \
   t/db_dependent/Koha/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 137879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137879=edit
Bug 30933: Unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #101 from Tomás Cohen Arazi  ---
(In reply to Joonas Kylmälä from comment #100)
> (In reply to Jonathan Druart from comment #99)
> > May need to be investigated before push.
> 
> In comment 81 the cause was deemed to be an invalid MARC record. However, as
> this breaks the development setup, and the automated test server / jenkins I
> presume, then to me this is FQA. We need to provide a patch along with this
> change that removes the invalid MARC record.

This is actually a behavior change we need to address on this patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #20 from Lucas Gass  ---
Marcel,

Is this ready for testing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #100 from Joonas Kylmälä  ---
(In reply to Jonathan Druart from comment #99)
> May need to be investigated before push.

In comment 81 the cause was deemed to be an invalid MARC record. However, as
this breaks the development setup, and the automated test server / jenkins I
presume, then to me this is FQA. We need to provide a patch along with this
change that removes the invalid MARC record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29446] Add ability to delete image from item edit drop down

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29446

--- Comment #1 from Esther Melander  ---
After filing this bug it appears there is a way to delete item images without
having to go through the tools/upload menu. Unfortunately it is not intuitive -
you have to know it is there. Currently, you have to click on the item image
and the delete image option is in the lower left corner. It would still be
helpful to have the option to delete the image from the edit button dropdown.
It was the first placed I looked for it and could not find it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

--- Comment #104 from Katrin Fischer  ---
Created attachment 137878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137878=edit
Bug 3150: (follow-up) Fix .yml formatting

 FAIL yaml_valid
 YAML::XS::Load Error: The problem:  did not find expected key  was found
at document: 1, line: 1748, column: 1 while parsing a block mapping at line:
23, column: 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #48 from Katrin Fischer  ---
Hi Aleisha,

thanks a lot for the follow-ups! The modals look really nice now.

Found a small glitch: you cannot empty the estimated delivery date from the
modal on the basket summary page once it has been set. When emptying the field
using the red X next to the field, the field empties, but today's date will be
saved. It's always today's date, independent of the setting for the vendor.

I have created 3 orders:
2022-07-30
2022-07-19
NULL - calculated from 10 days in vendor: 2022-07-29

When I search for:
- 2022-07-01 - 2022-07-30  - OK, all show
- 2022-07-01 - 2022-07-29  - NOT OK, still all three show, but 30 should not
- 2022-07-01 - 2022-07-27  - NOT OK, 30t and 19 show, but 29, the calculated
one does not

I've tried the dd.mm. and the -mm-dd Dateformat settings and the
behaviour is the same. Can you help?

Are moddelivery.tt/.pl fallbacks for no JavaScript?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31190] New: Add item creation date in items table

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31190

Bug ID: 31190
   Summary: Add item creation date in items table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mathsaby...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

In biblio table, there is a "datecreated" field, but I believe there is nothing
similar for items.
Some other ILS have a field to store the effective creation date of an item in
the system, in a non editable way, which is not the same kind of information as
items.dateaccessioned (the date of entry of an item in library's collection).

This kind of information can be useful for system administration purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

--- Comment #5 from Nick Clemens  ---
Created attachment 137877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137877=edit
Bug 31179: (QA follow-up) Set field as hidden for tests

We want the tests to pass in the case where field is set to visibile in Koha

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

--- Comment #4 from Nick Clemens  ---
Created attachment 137876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137876=edit
Bug 31179: (QA follow-up) POD fix

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Nick Clemens  changed:

   What|Removed |Added

 Attachment #137872|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 137875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137875=edit
Bug 31179: Don't copy invisible subfields when duplicating items

Duplicate item is intended to duplicate the visible cataloging fields of an
item, however,
currently it is duplicating the complete internal record of the item

To recreate:
1 - find an item in Koha staff client, copy the barcode
2 - Issue this item to a patron
3 - Return to the record
4 - Edit items
5 - Click 'Actions->Duplicate' for the item in question
6 - Save the item
7 - Note in the items table above for that 'Total checkouts' 'Due date'
 etc. have not been copied to new item

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

mathieu saby  changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing and item editor

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001
[Bug 29001] Subfields attributes are not preserved when order is changed in
framework
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7882] Add ability to move and reorder fields and subfields in MARC editor

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|29001   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001
[Bug 29001] Subfields attributes are not preserved when order is changed in
framework
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29001] Subfields attributes are not preserved when order is changed in framework

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|7882|8976
 CC||jonathan.druart+koha@gmail.
   ||com
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882
[Bug 7882] Add ability to move and reorder fields and subfields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976
[Bug 8976] Default sequence of subfields in cataloguing and item editor
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29001] Subfields attributes are not preserved when order is changed in framework

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

--- Comment #2 from Jonathan Druart  ---
Created attachment 137874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137874=edit
Bug 29001: Fix framework edition when subfields are reordered

There is a flaw when subfields are ordered, the inputs are not retrieved
correctly.
We should not rely on the order but use an id instead.
Test plan:
Create, edit subfields
Modify values from the different subfields
Confirm that values are correctly saved

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29001] Subfields attributes are not preserved when order is changed in framework

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Jason Robb  changed:

   What|Removed |Added

 CC||jr...@sekls.org

--- Comment #3 from Jason Robb  ---
This is very much needed.

We currently don't keep logs past 6 months due to our size but need to be able
to report annually on how many items each branch has weeded. The only way to do
that at present is by counting deleted items based on timestamp, so when that
table gets updated and the timestamps change, we lose the ability to accurately
retrieve that information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31189] New: Use different material type icon for LDR Pos. 6 = t - Manuscript language material

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31189

Bug ID: 31189
   Summary: Use different material type icon for LDR Pos. 6 = t -
Manuscript language material
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

It would be nice if Koha could display a specific material type icon for
manuscripts (LDR Pos. 6 = t)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055

--- Comment #10 from wajasu  ---
if you colocate the koha-functions.sh next to the other scripts, you can source
them path relative. But if other scripts somewhere else them, they will use
have an absolute path.

Some lib or scripts directory is definitely desired with an absolute path.

Will they be used by maintenance scripts?  That you probably don't want in
/usr/sbin.
I didn't find any currently when grepping. Most of our scripts are perl, but
these are bash shell.

A) /usr/share/koha/lib   <-- perl code
B) /usr/share/koha/lib/scripts   <-- doesn't exist yet
C) /usr/sbin <-- but gets out commands available in system
dir
D) /usr/share/koha/bin   <-- This is where koha-functions.sh is now.
  (which not on the PATH in KTD.  by design?)

I can easily test many of the koha-functions by sourcing the file from
debian/scripts and just calling them in the shell to examine $? and such.

Then I just run the cp_debian_files.pl everytime I make change.  Because the
koha-commands are sourcing the absolute path anyway.  A pain to fix/test, but
it works.

I tried to add a PREPATH inthe files/templates/defaults.env and change it in my
.env, but alas run.sh is set in stone in the image.  Making it less easy to
change (accidentall).
I was trying to put /kohadevbox/koha/debian/scripts prepended to the PATH so I
could edit/test without cp_debian_files.pl but that would only work if run.sh
had PATH=${PREPATH}:/usr/bin/usr/sbin/${PATH}:/kohadevbox/bin  and the koha-*
scripts used source ./koha-functions.sh

Maybe making it less painful to test with koha_functions.sh in the same
directory as /usr/sbin  is less clunky to fix/test and even explain an easier
test plan (without cp_debian_files.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31188] New: UPC or ASIN from amazon for dvd, music cds image

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31188

Bug ID: 31188
   Summary: UPC or ASIN from amazon for dvd, music cds image
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: julie.em...@collecto.ca
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi, 

We would like, in the same way as the isbn for books, that the UPC code or the
ASIN for amazon enter automatically for the display of images for dvds and
music cds. 

In short for other documents that do not have an isbn. 

On other request we see that some have briefly talked about it but no solution
except to enter the images by hand has been submitted. A gateway between amazon
and koha for the UPC code in the same way as we have a gateway for the
simagette with an ISBN.


Thank you for your help

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||31187


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187
[Bug 31187] Regression, Permanent shelving location is always updated when
editing location VIA BATCH ITEM MOD if both are mapped to MARC fields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on||30909


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909
[Bug 30909] Regression, Permanent shelving location is always updated when
editing location VIA ADDITEM.PL if both are mapped to MARC fields
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31187] New: Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187

Bug ID: 31187
   Summary: Regression, Permanent shelving location is always
updated when editing location VIA BATCH ITEM MOD if
both are mapped to MARC fields
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Bug 30909 handled this bug in the single item editor. It also exists in batch
item mod.

Same test plan applies, but use item batch modification for all of the edits:

1: create new subfield in DEFAULT framework, 952$k, visible in editor, managed
in tab 10, tied to LOC auth value
2: In Koha to MARC mapping, find items.permanent_location and add a mapping to
952$k
3: Find a bib and item in the default framework
4: Edit the item, see that both the 952$c and 952$k are visible in the editor
-- In my test, both fields started at a value of "General Stacks"
5: change both values and save the item, confirm both values change and save
successfully -- I set 952$c to Audio Visual and 952$k to Fiction
6: edit again, change only 952$c, save -- I changed 952$c to On Display and
left 952$k set to Fiction

THIS IS WHERE THINGS GO WRONG. After saving that change, both 952$c AND 952$k
are set to On Display, even though I only changed the 952$c.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Andrew Fuerste-Henry  changed:

   What|Removed |Added

Summary|Regression, Permanent   |Regression, Permanent
   |shelving location is always |shelving location is always
   |updated when editing|updated when editing
   |location if both are mapped |location VIA ADDITEM.PL if
   |to MARC fields  |both are mapped to MARC
   ||fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #135748|0   |1
is obsolete||

--- Comment #12 from ByWater Sandboxes  ---
Created attachment 137873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137873=edit
Bug 30909: Retain permanent_location if mapped

If items.permanent_location is mapped to a MARC subfields we must retain
the value, not using items.location

Test plan:
1 - Map permanent_location to a marc field
2 - Expose that field in the item editor
3 - Change the location of the item and retain the permanent location on saving
4 - note that permanent location has not changed

Test the different other situation, when adding and editing: Empty the field,
change only location, change only permanent_location, etc.

Signed-off-by: andrew 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

--- Comment #11 from Andrew Fuerste-Henry  ---
> Notes:
> - When you add a mapping: the instructions say:
> "Adding a mapping for: items.permanent_location.
> Please enter field tag and subfield code, separated by a comma. (For control
> fields: add '@' as subfield code.)
> The change will be applied immediately."
> - However, at the top of the page it says: "If you make any change to the
> mappings, you must ask your administrator to run
> misc/batchRebuildBiblioTables.pl."
> - Not sure which is right here and hwteher this shouldbe logged as a new bug.

Agreed on all of this. The format of "952,k" is confusingly nonstandard, I'd
love to see it normalized to "952$k."

I believe those two notes about immediate changes and rebuilds are meant to
convey that any mapping change will be applied to new and edited records
immediately but that existing records will need a rebuild to reflect the
change. This could certainly be explained more clearly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

--- Comment #10 from Andrew Fuerste-Henry  ---
Confirming current incorrect behavior: 

1: create new subfield in DEFAULT framework, 952$k, visible in editor, managed
in tab 10, tied to LOC auth value
2: In Koha to MARC mapping, find items.permanent_location and add a mapping to
952$k
3: Find a bib and item in the default framework
4: Edit the item, see that both the 952$c and 952$k are visible in the editor
-- In my test, both fields started at a value of "General Stacks"
5: change both values and save the item, confirm both values change and save
successfully -- I set 952$c to Audio Visual and 952$k to Fiction
6: edit again, change only 952$c, save -- I changed 952$c to On Display and
left 952$k set to Fiction

THIS IS WHERE THINGS GO WRONG. After saving that change, both 952$c AND 952$k
are set to On Display, even though I only changed the 952$c.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

--- Comment #2 from Jonathan Druart  ---
Created attachment 137872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137872=edit
Bug 31179: Don't copy invisible subfields when duplicating items

Duplicate item is intended to duplicate the visible cataloging fields of an
item, however,
currently it is duplicating the complete internal record of the item

To recreate:
1 - find an item in Koha staff client, copy the barcode
2 - Issue this item to a patron
3 - Return to the record
4 - Edit items
5 - Click 'Actions->Duplicate' for the item in question
6 - Save the item
7 - Note in the items table above for that 'Total checkouts' 'Due date'
 etc. have not been copied to new item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
 Depends on||27526

--- Comment #1 from Jonathan Druart  ---
If this is a regression it's certainly coming from bug 27526.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
[Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||31179


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179
[Bug 31179] Duplicate item is duplicating internal item fields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31032] Patron attributes branch limitations are unclear

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

--- Comment #5 from Jonathan Druart  ---
(In reply to Nick Clemens from comment #3)
> Does limiting an attribute to a branch(es) imply that only librarians from
> that branch can see that attribute?

This.
It was the goal of bug 7919, restrict some values to a list of branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location if both are mapped to MARC fields

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #9 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #8)
> I have tried to test this, but I can't replicate the problem, could this
> have been fixed otherwise?
> 
> To recreate:
> 1 - Map permanent_location to a marc field
> 2 - Expose that field in the item editor
> 
> I used 952k, tab 10, visibile in editor, AV = LOC.
> Updated Koha-to-MARC-mappings to map to permanent_location.
> 
> 3 - Change the location of the item and retain the permanent location on
> saving
> 
> My item had no locations set. I set permanent location and locatoon to
> different values and saved.
> 
> 4 - note that permanent location has changed anyway
> 
> The fields kept the values I set, nothing was changed unexectedly.
> 
> Maybe I am missing something?

Create an item, set location=Audio Visual (AV), save
=> permanent location is AV
Edit again, set location=Child's area (CHILD), don't modify permanent location,
save
=> permanent location is CHILD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #61 from Jonathan Druart  ---
Just wanted to test the last patch. All good.

A quick remark when testing: I think we need the "transfer" action available
from the show list view (/virtualshelves/shelves.pl?op=view=1). Not
considering blocker however.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #137867|0   |1
is obsolete||

--- Comment #60 from Jonathan Druart  ---
Created attachment 137871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137871=edit
Bug 25498: (follow-up) Change for autocomplete change of 30578

Test plan:
Check if the patron search still works on the intranet shelves form
when transferring ownership.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

--- Comment #8 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30905] Show waiting recalls in patron account on checkouts tab

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30905] Show waiting recalls in patron account on checkouts tab

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30905] Show waiting recalls in patron account on checkouts tab

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 137870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137870=edit
Bug 30905: (follow-up) Get logged in branch once

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #25 from Jonathan Druart  ---
(In reply to Owen Leonard from comment #22)
> > > - circulation.pl
> > >   Template process failed: undef error - The given date (01.06.2022 11:59
> > > PM) does not match the date format (iso) at
> > >
> > > The above error occurred when checking out and specifying a date in the 
> > > past.
> 
> I'm still getting this error when manually selecting a due date in the past.
> 
> I now notice that the time portion of the datetime is not appearing in the
> input field. The same is true on the checkin and offline circulation page.

This was hiding something critical, thanks for the catch.

> > > - tools/holidays.pl
> 
> There's now a little calendar icon showing above the calendar on this page.

Yes, we don't need it there, fixed.

> > > - Tasks scheduler: "Failed to add Tasks"
> > Fixed (note that time part is mandatory but the UI does not ask for it).
> 
> Would it make sense to update the form in this patch set to use a single
> field with the Flatpickr timepicker enabled?

I would consider that different from what we are doing here. Should be fixed
separately in my opinion.

> I notice also that paired date fields (start date & end date) now show an
> extra "X" icon after the second field, e.g. serial claims or catalog
> statistics.

Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #24 from Jonathan Druart  ---
Created attachment 137869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137869=edit
Bug 30718: Prevent 'reset' icon to appear twice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #23 from Jonathan Druart  ---
Created attachment 137868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137868=edit
Bug 30718: Fix time display

Especifically when timeformat=12h

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #59 from Marcel de Rooy  ---
Created attachment 137867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137867=edit
Bug 25498: (follow-up) Change for autocomplete change of 30578

Test plan:
Check if the patron search still works on the intranet shelves form
when transferring ownership.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #136221|0   |1
is obsolete||

--- Comment #58 from Marcel de Rooy  ---
Created attachment 137866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137866=edit
Bug 25498: (QA follow-up) Rename virtualshelfshare->patron

This patron is a 'sharee' (not the sharer).

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #136169|0   |1
is obsolete||

--- Comment #57 from Marcel de Rooy  ---
Created attachment 137865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137865=edit
Bug 25498: Transfer ownership shared list on OPAC

Test plan:
Pick or create a shared list. Login as owner.
Transfer to one of the other members.
Verify that you do no longer have Transfer, but see Remove share.
Login as the other member. Transfer it back.

Bonus: Working with two tabs, you can open the Transfer form and
in the meantime delete the list, the patron or remove the share.
Or change permissions. Submit after that and check the error message.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #136168|0   |1
is obsolete||

--- Comment #56 from Marcel de Rooy  ---
Created attachment 137864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137864=edit
Bug 25498: Show transfer button for shared lists on OPAC

Test plan:
Pick or create a shared list.
Verify that OPAC only shows the Transfer button when you are the
owner of a shared list.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #136167|0   |1
is obsolete||

--- Comment #55 from Marcel de Rooy  ---
Created attachment 137863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137863=edit
Bug 25498: Add a transfer form for public lists

Test plan:
[1] Valid transfer:
Log in with staff patron C having edit_public_lists.
Pick a public list. Choose Transfer. Select a patron.
Submit and check if transfer was successful.
[2] Permission problem:
Pick a staff user D. Temporary enable edit_public_lists.
Add another private tab. Login with D.
Pick a public list. Transfer. Choose another patron. Wait.
Switch tab: remove added permission from D.
Switch tab again: Submit transfer form. Error? Close tab.
[3] Bonus test - Shelf disappeared:
Pick a public list. Transfer. Choose another patron. Wait.
Open another tab. Delete the selected public list.
Close tab. Submit the transfer. Not exist error?
[4] Bonus test - Patron not found:
Pick a public list. Transfer. Choose another patron. Wait.
Open another tab. Delete selected patron.
Close tab. Submit transfer. Patron not found error?

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #136166|0   |1
is obsolete||

--- Comment #54 from Marcel de Rooy  ---
Created attachment 137862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137862=edit
Bug 25498: Add transfer button on intranet

Note: Adjusting shelves_results template too for not allowing delete
when you do not have delete_public_lists (or higher). If you are the
owner, you are allowed to edit or delete. But transfer specifically
needs edit_public_lists (or higher).

Note: Removed a few useless POD lines to make qa tools happy.

Test plan:
Check if you see the transfer button on public lists only when having
permission edit_public_lists (or higher). And never on private lists.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl
 CC||tomasco...@gmail.com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from Marcel de Rooy  ---
Super trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

--- Comment #1 from Marcel de Rooy  ---
Created attachment 137861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137861=edit
Bug 31186: Fix the hidingrules test for result numbering

We should not test the $hidingrules variable but the number
of keys it contains.

Test plan:
Clear OpacHiddenItems.
Check with and without this patch search result numbering on
the OPAC.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31186] New: Search result numbering in OPAC got suppressed

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Bug ID: 31186
   Summary: Search result numbering in OPAC got suppressed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Trivial fix forthcoming

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

Adolfo Rodríguez Taboada  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities

2022-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

--- Comment #1 from Adolfo  ---
Created attachment 137860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137860=edit
Detect duplicate authorities using Link authorities automatically

This patch fixes LinkBibHeadingsToAuthorities so it detects duplicate
authorities using "Link authorities automatically"

To test
1 Make sure the system preference AutoCreateAuthorities is turned to don't
generate
2 Create a duplicate authority and check that search in Authorities module
returns both. For example, two Personal Name (Smith, John)
3 Create a new record and fill the entry point with the same text of the
authorities you just created. For example 100$a Smith, John
4 Click "Link authorities automatically" and you will obtain the following
message "No matching authority found."
5 Apply patch, restart services
6 Click "Link authorities automatically" and you will obtain the following
message "More than one local match found. Possibly a duplicate authority!"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >