[Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786 Caroline Cyr La Rose changed: What|Removed |Added Documentation||Caroline Cyr La Rose contact|| CC||caroline.cyr-la-rose@inlibr ||o.com Keywords|Academy, Manual | Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/575 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 Caroline Cyr La Rose changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||second, automatic, search ||with the search terms ||between quotation marks ||when a search returns no ||results. || ||For example, ||searches with special ||characters don't work with ||Elasticsearch. ||A search for ||Ivy + Bean will return no ||results. But a search for ||"Ivy + Bean" will return ||results. || ||With this ||enhancement, if a user ||searches for Ivy + Bean ||without quotation marks and ||gets no results, Koha will ||automatically search for ||"Ivy + Bean" and return ||those results. || ||This ||targets both Zebra and ||Elasticsearch, but is more ||relevant for Elasticsearch. Keywords|release-notes-needed| CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #19 from Kyle M Hall --- Created attachment 138144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138144&action=edit Bug 31223: Do not try to report results if task not started Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30654] Even with RabbitMQ enabled, we should poll the database for jobs at worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com, ||l...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Kyle M Hall changed: What|Removed |Added Attachment #138129|0 |1 is obsolete|| Attachment #138130|0 |1 is obsolete|| Attachment #138131|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 138142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138142&action=edit Bug 31223: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234 --- Comment #2 from Fridolin Somers --- Item restricted edition dates back to Bug 7673 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29994] Single label PDF export not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 --- Comment #8 from Lucas Gass --- I am able to recreate this in current master. 1. Make a label batch. 2. Go to 'label-edit-batch.pl' and select at least one item in the table. ( #batcht ) 3. Use the 'Export' button to export at one item. 4. Choose template/layout etc. 5. Download as PDF This is the error I see: Can't locate object method "get_attr" via package "-2" (perhaps you forgot to load "-2"?) at /kohadevbox/koha/labels/label-create-pdf.pl line 127 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30654] Even with RabbitMQ enabled, we should poll the database for jobs at worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31223 --- Comment #12 from Tomás Cohen Arazi --- Let's kill the rabbit ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Caroline Cyr La Rose changed: What|Removed |Added Attachment #135194|0 |1 is obsolete|| --- Comment #19 from Caroline Cyr La Rose --- Created attachment 138140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138140&action=edit Bug 29012: Add default values for blank circulation rules that weren't saved to the database There are 5 fields that are not set if no value is provided when saving/editing a rule in Administration->Circulation and fines rules - issuelength - hardduedate - unseenrenewalsallowed - rentaldiscount - decreaseloanholds This is problematic because it gives the impression these rules are set as blank, but in reality they don't exist and the rule will fal back to the higher level To test: 1 - Set a rule for Patron category: Teacher Itemtype: All Hard due date: (Today) Lona period: 10 2 - Set a rule for Patron category: Teacher Itemtype: Books Hard due date: (leave blank) Loan period: 10 3 - Expected behaviour is Book item will checkout to teacher for 10 days, all other types will be due yesterday at 25:59:00 4 - Checkout an non-book item type to teacher 5 - Hard due date applies 6 - Checkout a 'book' item type to teacher 7 - Hard due date applies - FAIL Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Caroline Cyr La Rose changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/577 Keywords|Manual | Documentation||Caroline Cyr La Rose contact|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #16 from Isabel Pineda --- (In reply to Tomás Cohen Arazi from comment #15) > (In reply to Isabel Pineda from comment #0) > > In a register with several items I select all (or some) items and click > > "edit selected items". I make the modification (write a public note, change > > the signature, change item type etc.) and click "Save", the modifications > > don't get saved. > > It used to work in previous versions. > > In the meantime, you should enable plugins in koha-conf.xml until this is > pushed. > > Also, I noticed that the task will stay as 'new' because it is not being > picked by the message queue. So I suggest you: > > - systemctl stop rabbitmq > - koha-worker --restart --queue default > > so it is picked again. Thank you. The plugins were enabled, actually I am using the coverflow plugin on the OPAC. But for some reason the koha-worker wasn't working. So the line - koha-worker --restart --queue default solved the problem for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Fridolin Somers changed: What|Removed |Added Blocks||31234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234 [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #18 from Caroline Cyr La Rose --- Sigh. I was able to reproduce the original behaviour in a fresh sandbox, but even after applying the patch in the sandbox, the behaviour stayed the same... I will try on my dev install -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 138130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138130&action=edit Bug 31223: Do not explode if plugins disabled This patch makes the code skip calculating the plugin-related task codes => class mapping if plugins are entirely disbaled. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t => FAIL: Tests explode with: Can't call method "GetPlugins" on an undefined value at... Koha/BackgroundJob.pm line 424. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What|Removed |Added Attachment #133274|0 |1 is obsolete|| Attachment #133275|0 |1 is obsolete|| Attachment #133276|0 |1 is obsolete|| --- Comment #21 from Owen Leonard --- Created attachment 138137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138137&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #22 from Owen Leonard --- Created attachment 138136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138136&action=edit Bug 30077: (follow-up) Set max width for library drapdown If you have a library with a very long name the dropdown will expand to accommodate it. I think this is awkward-looking, so I propose to set a max width on elements in the header search region. The patch requires a rebuild of the staff interface CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added Attachment #138126|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30879] Add option to sort components by biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #30 from Katrin Fischer --- No reply from Nick yet, I think we still need the release notes note, but dropping the other requirement from my side. I believe this is worth having. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #22 from Owen Leonard --- Created attachment 138138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138138&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Keywords||rel_22_05_candidate Status|NEW |ASSIGNED Version|22.05 |master Summary|Batch edit items - not |Batch edit items explodes |working anymore in 22.05|if plugins disabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 138131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138131&action=edit Bug 31223: Do not try to report results if task not started Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30654 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #20 from Caroline Cyr La Rose --- It worked on my local installation :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added Attachment #138128|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords|release-notes-needed|Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #11 from Tomás Cohen Arazi --- Need to re-do the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Owen Leonard changed: What|Removed |Added Attachment #132821|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 138133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138133&action=edit Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Signed-off-by: Séverine Queune -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi David and Stefan, looking into this and trying to rephrase what I think this does: If an item is returned, we check if the patron is still restricted by an OVERDUES restriction. If that's the case, we check if they have any remaining checkouts that have triggered an OVERDUES restriction (are overdue long enough). If there are no such remaining checkouts, we undebar. Is that about right? 1) Could you please add a test plan and some description to the commit message? 2) You are missing the sysprefs.sql change for adding a new system preference in your patch. And in the pref file, don't use yes/no, but 0/1. 3) The new pref is named: ODueDebarmentRemovalAllowUnrestricted I wonder if instead of using a new pref, it might be nicer to change the existing pref AutoRemoveOverduesRestrictions to have 3 options: * Don't lift restriction * Lift restriction if no more overdues * Lift restriction if remaining overdues didn't trigger a restriction (some native speaker might be able to help with a more elegant phrasing) If we go with 2 separate preferences, they should be linked to each other in the .pref (there are a lot of examples for this in the files). Also a bit different name might be nice... but I have to admit, I don't have a good idea right now. I think I'd really prefer not to have them separate. 4) Missing unit tests for the changes in Circulation.pm and Patron.pm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #129 from Shi Yao Wang --- Created attachment 138132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138132&action=edit Bug 17385: Add missing imports and equivalent code for GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Isabel Pineda from comment #0) > In a register with several items I select all (or some) items and click > "edit selected items". I make the modification (write a public note, change > the signature, change item type etc.) and click "Save", the modifications > don't get saved. > It used to work in previous versions. In the meantime, you should enable plugins in koha-conf.xml until this is pushed. Also, I noticed that the task will stay as 'new' because it is not being picked by the message queue. So I suggest you: - systemctl stop rabbitmq - koha-worker --restart --queue default so it is picked again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #23 from Owen Leonard --- Created attachment 138139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138139&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Owen Leonard changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #3 from Katrin Fischer --- *** Bug 16882 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30654] Even with RabbitMQ enabled, we should poll the database for jobs at worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654 --- Comment #13 from Tomás Cohen Arazi --- Send message to a durable RabbitMQ queue(In reply to David Cook from comment #10) > 4. Send message to a durable RabbitMQ queue What is the 'durable RabbitMQ queue' in this context? In order for using RabbitMQ makes sense, I feel like we need: - A Task queue manager (we have the table, just missing a process that polls it and sends 'the message' - A way to dispatch the message to notify workers about it (Yay, RabbitMQ) - A worker that reads the message and acts accordingly Questions: - how does a worker report back if it failed? Probably directly to the DB? This is a case for a task queue manager, which would read and make the decision it is time to retry. - if we had 2 workers waiting for 'index' jobs through the mq, how do we pick which process takes the job? how does the system know it is being processed by who? what if the process dies and we need to assign a new worker? That's where I was going with the PID thing. BEcause I was thinking about things locally (wrong) but the case still stands with this question. Who is running what? I personally don't see a case in which RabbitMQ is being useful right now. At least when we still haven't implemented a way to avoid tasks that failed to get notified through the mq to be retried, scheduled, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 138128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138128&action=edit Bug 31223: Do not try to report results if task not started Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Caroline Cyr La Rose changed: What|Removed |Added Keywords|release-notes-needed| CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Owen Leonard changed: What|Removed |Added Attachment #135530|0 |1 is obsolete|| Attachment #135531|0 |1 is obsolete|| Attachment #135532|0 |1 is obsolete|| --- Comment #20 from Owen Leonard --- Created attachment 138134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138134&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: Sally Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #130 from Shi Yao Wang --- (In reply to David Nind from comment #128) > Thanks Shi Yao, the patches now apply! > > However, I've changed the status to Failed QA as there are: > > 1. Error traces after the patches are applied: > >a. See error traces for the staff interface - see [1], [2], and [3] > (occurs if the 'XSL - Simple Export' option for OpacExportOptions is either > selected or not selected). > >b. See error traces for the OPAC - see [4]. > > 2. If the 'XSL - Simple Export' option for OpacExportOptions is not > selected, it still appears in the staff interface record details page as a > save option. > > 3. The t/XSLT.t tests fail - see [5]. 1. There shouldn't be any errors now 2. The system preference has the word "Opac" in it so I assume it only affects OPAC interface and not the staff interface 3. Couldn't run the test on my machine because I have trouble installing Test::DBIx::Class. Hope it works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer --- I think 29145 would work here, but is currently failed QA. *** This bug has been marked as a duplicate of bug 29145 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #21 from Owen Leonard --- Created attachment 138135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138135&action=edit Bug 30077: (follow-up) retain branch selection To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch and retain that branch in the dropdown, just like the OPAC. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #7 from Caroline Cyr La Rose --- I cannot reproduce the problematic behaviour either in a sandbox nor on my local dev install with the steps from comment 4. In all cases, I am brought to the batch item modification page without problem and am able to launch the batch modification. I do get a 500 error when I click on the "View detail of the enqueued job" link to see the background job. I tried with and without the patch and get the same behaviour... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31238] Unable to save authorised value to frameworks subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 sandbo...@biblibre.com changed: What|Removed |Added Attachment #138119|0 |1 is obsolete|| --- Comment #3 from sandbo...@biblibre.com --- Created attachment 138125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138125&action=edit Bug 31238: Fix typo in marc_subfields_structure.pl After bug 29001 one is unable to save authorised value to frameworks subfields. This is caused by minor typo in marc_subfields_structure.pl. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty 4. Apply this patch. 5. Repeat steps 1.-3. => authorised value should now be saved Sponsored-by: Koha-Suomi Oy Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31229] Column visibility broken on patron search view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Caroline Cyr La Rose changed: What|Removed |Added Keywords|release-notes-needed| Text to go in the||This patch corrects a bug release notes||in the Circulation ||statistics wizard. ||Previously, the wizard only ||looked at existing items to ||calculate statistics. It ||now includes transactions ||made on items that are now ||deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added Attachment #138127|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 138129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138129&action=edit Bug 31223: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Emmanuel Bétemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30837] Fix table width on 'Print summary'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 pierre.ge...@biblibre.com changed: What|Removed |Added CC||pierre.ge...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Emmanuel Bétemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #6 from Katrin Fischer --- Thx for the patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 138126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138126&action=edit Bug 31223: Regression tests This patch adds tests so we are sure things don't explode with/without plugins enabled. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #13 from Kyle M Hall --- (In reply to Tomás Cohen Arazi from comment #11) > (In reply to Paul Derscheid from comment #5) > > The other issue is that this route can be abused for DOS-attacks which must > > be handled somehow. > > Isn't that already the case for bots hitting opac-search.pl? > > I think we need to introduce some tool for throttling, but not necessarily > as part of this dev, as it is really tricky (e.g. it will be common for > campus sites to be queried many times from a transparent proxy on the LAN so > we will also need to be able to configure exceptions...). That is a good point. Now, we just need to add throttling to this api, then use that api in opac-search ;) Tomas, at this time I think you have the ultimate authority to declare throttling "out of scope" and move it to a new bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #16 from Kyle M Hall --- I'd really like to see us get away from Apache based solutions, but at the same time it's a very practical way to handle it that works for 99.9% of Koha users. If there exists middleware that would work for Koha, that would be a better solution IMO, especially because we can bake the throttling settings directly into Koha. Now, I think we've done enough bike-shedding. We should move this discussion to a throttling specific bug report! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Emmanuel Bétemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 138127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138127&action=edit Bug 31223: Do not explode if plugins disabled This patch makes the code skip calculating the plugin-related task codes => class mapping if plugins are entirely disbaled. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/BackgroundJob.t => FAIL: Tests explode with: Can't call method "GetPlugins" on an undefined value at... Koha/BackgroundJob.pm line 424. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31211] Check slips and notices for valid Template Toolkit and report errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Paul Derscheid from comment #7) > That's right but at LMSCloud we need this as a public route and tcohen also > wants this to be public, so the simple approach doesn't fly. We can have both, really. And when we say 'public' we mean 'unprivileged access' which could or not imply authentication. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31017] Add type field for vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Caroline Cyr La Rose changed: What|Removed |Added Text to go in the||This enhancement adds a new release notes||field to record the vendor ||type when creating or ||editing vendors. This field ||can be used as a free text ||field, or a drop-down menu ||if there are authorized ||values in the VENDOR_TYPE ||authorized value category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31229] Column visibility broken on patron search view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #9 from Paul Derscheid --- Another question is what a sane 'number of requests/interval' would look like. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31211] Check slips and notices for valid Template Toolkit and report errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #13) > That is a good point. Now, we just need to add throttling to this api, then > use that api in opac-search ;) > > Tomas, at this time I think you have the ultimate authority to declare > throttling "out of scope" and move it to a new bug report. I think we should file a separate bug, yes. And I wouldn't make this one dependent on the new one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #11 from Tomás Cohen Arazi --- (In reply to Paul Derscheid from comment #5) > The other issue is that this route can be abused for DOS-attacks which must > be handled somehow. Isn't that already the case for bots hitting opac-search.pl? I think we need to introduce some tool for throttling, but not necessarily as part of this dev, as it is really tricky (e.g. it will be common for campus sites to be queried many times from a transparent proxy on the LAN so we will also need to be able to configure exceptions...). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #11) > (In reply to Paul Derscheid from comment #5) > > The other issue is that this route can be abused for DOS-attacks which must > > be handled somehow. > > Isn't that already the case for bots hitting opac-search.pl? What I meant to say is that introducing this route just adds another place we need to take care of. But the solution is needed in general. Maybe at Apache level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #10 from Kyle M Hall --- (In reply to Paul Derscheid from comment #9) > Another question is what a sane 'number of requests/interval' would look > like. I think that depends on the power of the server, and your use case. What will you be using this API for? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #17 from Tomás Cohen Arazi ---
Comment on attachment 138123
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138123
Bug 25870 - Add a q_ccl query parameter to /biblios
Review of attachment 138123:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25870&attachment=138123)
-
::: Koha/REST/V1/Biblios.pm
@@ +160,5 @@
> +my $record_processor = Koha::RecordProcessor->new(
> +{
> +filters => 'ViewPolicy',
> +options => {
> +interface => 'opac',
I think you could implement only a list() method, and rely on
$c->stash('is_public') to choose staff vs. public. And later check the
OpacHiddenItems stuff accordingly.
@@ +177,5 @@
> +}
> +);
> +}
> +
> +sub format_record_by_content_type {
This inline subs look really untidy.
@@ +243,5 @@
> +}
> +
> +my $response =
> + format_record_by_content_type(
> +{ content_type => $requested_content_type, records => \@records
> } );
It feels like this method call should be placed in the data => portion of the
respond_to, with the right parameters for each case instead of 'detecting it'
inside format_record_... But as I said, I'm still not convinced by those subs.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #6 from Kyle M Hall --- (In reply to Paul Derscheid from comment #5) > The other issue is that this route can be abused for DOS-attacks which must > be handled somehow. Wouldn't the simplest solution be to make it *not* public, and just require the catalogue permission? Another option would be to bake in a rate limiting middleware such as https://metacpan.org/pod/Plack::Middleware::Throttle or https://metacpan.org/pod/Plack::Middleware::Throttle::Lite -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #8 from Kyle M Hall --- Also https://metacpan.org/pod/Plack::Middleware::Cerberus We need something that throttles by the minute or even second if possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Emmi Takkinen changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emmi.takki...@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #5 from Emmi Takkinen --- Created attachment 138124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138124&action=edit Bug 31154: Pass biblionumber to Koha::UI::Form::Builder::Item->new from batchMod.pl to prevent error 500 When one tries to batch mod items and has "Use default values" checkbox checked on and their default framework contains default values, Koha dies on error 500. In logs it reads: Can't call method "field" on an undefined value at .../Koha/Koha/UI/Form/Builder/Item.pm line 164. This happens because in batchMod.pl line 269 we don't pass biblionumber as parameter to Koha::UI::Form::Builder::Item->new and thus Koha fails to fetch biblios marc record. To test: 1. Update default framework 952 and add a default value * Example: Add REF as default for 952$8 with standard sample data 2. Find some item(s) to modify 3. Provide barcodes of those item(s) and check checkbox "Use default values" 4. Hit "Continue" => error 500 is raised 5. Apply patch. 6. Repeat steps 3. and 4. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #7 from Paul Derscheid --- That's right but at LMSCloud we need this as a public route and tcohen also wants this to be public, so the simple approach doesn't fly. Thanks for the pointers, I'll have a look in a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31211] Check slips and notices for valid Template Toolkit and report errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 --- Comment #7 from Kyle M Hall --- (In reply to Katrin Fischer from comment #6) > Created attachment 138108 [details] [review] > Bug 31211: (QA follow-up) Add class to new list element for error > > To allow additional styling the class template_toolkit_error was > added to the list element. > > Signed-off-by: Katrin Fischer Good idea! Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Anneli Österman changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #16 from Anneli Österman --- Katrin, thanks, refreshing the schema helped! :) There is a deleted_on column on both items and deleteditems table and it is updated when item is deleted (regardless of the method used, batch delete or actions/delete in modify page.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #4 from Paul Derscheid --- Created attachment 138123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138123&action=edit Bug 25870 - Add a q_ccl query parameter to /biblios This patch adds new functionality to the existing /public/biblios route. Instead of specifying a biblio by a biblionumber as a path parameter, you can use the new q_ccl query parameter to run a query on the endpoint. To test: 1) Apply the patch 2) Pick an endpoint tester of your choice, e.g. Insomnia or the ThunderClient if you use VSCode or derivatives. 3) Run a query while using Zebra. 4) Observe the marc-in-json response and check for validity. 5) Run a query while using Elasticsearch. 6) Again, observe the marc-in-json response and check for validity. 7) I'd love to say: 'Sign-Off' but the unit tests need work and I need help with that, so.. an attachment or guidance would be great. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #5 from Paul Derscheid --- The other issue is that this route can be abused for DOS-attacks which must be handled somehow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Janusz Kaczmarek changed: What|Removed |Added Attachment #69350|0 |1 is obsolete|| --- Comment #6 from Janusz Kaczmarek --- Created attachment 138121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138121&action=edit Bug 19693: update of an authority record creates inconsistency when the heading tag is changed Since after a few years the problem is still unresolved here comes a new attempt to address it: In those rare cases when authorities are updated by an external agency (or even internally, by reviewing and correcting an exported authority file) when the heading tag will be changed (seems odd but happens: 111 Congress ==> 110 Corporate body.Congress ; 100 Person ==> 110 Corporate body (a company named with person's name ; 151 City--object ==> 150 Object (city) etc.) and then the authority record in Koha database will be updated with bulkmarcimport or by calling directly ModAuthority from a custom script, the merge function "doesn't know" that the change to the authority type has been made and, consequently, doesn't adequately change the tag in related fields in biblio records (as it would if two different records with different authtypecode were merged with Koha interface). This is because at the moment when merge function is being called by ModAuthority: Koha::Authority::Types->find($autfrom->authtypecode) Koha::Authority::Types->find($authto->authtypecode) both have the same value (because $mergefrom == $mergeto). Therefore in case when $mergefrom == $mergeto and the heading tag changes, $authtypefrom and $authfrom calculated in merge in the ordinar way are misleading and should not be taken unto consideration. Test plan: == 1. run t/db_dependent/Authority/Merge.t 2. you should see problems in "Test update A with modified heading tag (changing authtype)" 3. apply the patch 4. run t/db_dependent/Authority/Merge.t again 5. the test should pass Alternatively: 1. have an authority record used in biblio; export it to file; change 1XX heading tag to a different (but reasonable) value and possibly change also the content of the heading (one can delete also 942 but it doesn't matter); make bulkmarcimport.pl -a -update -file and see that the tag in biblio record has not been changed (whereas the type of authority record did change); 2. make orders in database (so that the authority type and the tag of the field in biblio record correspond); apply the patch; 3. repeat the test from 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Janusz Kaczmarek changed: What|Removed |Added Status|Failed QA |Needs Signoff Priority|P5 - low|P3 Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 --- Comment #7 from Janusz Kaczmarek --- Created attachment 138122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138122&action=edit Bug 19693: Add test sub to Merge.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28269] Order search should be possible with ISSN too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 MichaelaSieber changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23202] Problems when adding multiple items to an order in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #8 from Johanna Räisä --- Created attachment 138120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138120&action=edit Bug 23202: Problems when adding multiple items to an order in acquisitions This patch fixes adding multiple items on order acquisitions 1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field. 2) Create basket to a vendor and add order from a new empty record. 3) Add date acquired value from calendar. 4) Add multiple items and see that the view freezes. 5) Apply the patch 6) Reload the page and repeat the steps 3 and 4. 7) See that the items are added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31238] Unable to save authorised value to frameworks subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Emmi Takkinen changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emmi.takki...@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #2 from Emmi Takkinen --- Created attachment 138119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138119&action=edit Bug 31238: Fix typo in marc_subfields_structure.pl After bug 29001 one is unable to save authorised value to frameworks subfields. This is caused by minor typo in marc_subfields_structure.pl. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty 4. Apply this patch. 5. Repeat steps 1.-3. => authorised value should now be saved Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31239] New: search_for_data_inconsistencies.pl fails for Koha to MARC mapping using biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239
Bug ID: 31239
Summary: search_for_data_inconsistencies.pl fails for Koha to
MARC mapping using biblio table
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Command-line Utilities
Assignee: koha-bugs@lists.koha-community.org
Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz
The script misc/maintenance/search_for_data_inconsistencies.pl search for
invalid values using Koha to MARC mapping fields.
The tables items and biblioitems are OK but mappings can be on biblio table :
my $value = $table eq 'items' ? $i->$column : $i->biblioitem->$column;
For example in UNIMARC if fails with error :
The method Koha::Biblioitem->medium is not covered by tests!
Trace begun at /home/koha/src/Koha/Object.pm line 880
Koha::Object::AUTOLOAD('Koha::Biblioitem=HASH(0x55c9a1905a40)') called at
/home/koha/src/misc/maintenance/search_for_data_inconsistencies.pl line 196
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31238] Unable to save authorised value to frameworks subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238
--- Comment #1 from Emmi Takkinen ---
There seems to be a minor typo on marc_subfields_structure.pl,
>$input->param("authorised_values_$id")
should be
>$input->param("authorised_value_$id")
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31238] New: Unable to save authorised value to frameworks subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Bug ID: 31238 Summary: Unable to save authorised value to frameworks subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takki...@koha-suomi.fi QA Contact: testo...@bugs.koha-community.org While working on bug 31154 I stumbled on problem described above. As it states I'm unable to save authorised value to frameworks subfields and was wondering is anyone able to repeat this. I suspect that this is caused by changes made in bug 29001, before it variable $authorised_value in marc_subfields_structure.pl is succesfully filled with value indented to be saved. After applying bug again $authorised_value is undef. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 --- Comment #15 from Katrin Fischer --- Hi Anneli, are you testing using the sandboxes or ktd? If ktd, run: dbic If sandboxes, got to Actions > Refresh schema This should hopefully make the error go away. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] Batch edit items - not working anymore in 22.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 George Veranis changed: What|Removed |Added CC||gvera...@dataly.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 --- Comment #14 from Anneli Österman --- I tested in Bywater's sandbox. If I deleted item via batch item delete (backgroun jobs), it is deleted but deleted_on is empty in deleteditems table. If I delete the item from "additem.pl?op=edititem&biblionumber=" page (Actions -> Delete) I get this error message: DBIx::Class::Row::store_column(): No such column 'deleted_on' on Koha::Schema::Result::Deleteditem at /kohadevbox/koha/Koha/Item.pm line 341 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 There is deleted_on column on items and deleteditems table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31231] Link authorities automatically does not always work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231 --- Comment #3 from Katrin Fischer --- I was not sure if they were the same, so that's perfectly fine. Thx for taking a look! I'll keep them linked with see also, because they touch the same area at least. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31017] Add type field for vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Katrin Fischer changed: What|Removed |Added Attachment #136444|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31231] Link authorities automatically does not always work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231 --- Comment #2 from Holly --- I'm not sure it is. Bug 31185 seems to be about when duplicate authorities already exist and you try to use the "Link authorities automatically" button. What I am seeing is in situations where there is only one authority, but it has content in multiple subfields, the "Link authorities automatically" button can't pick up the one authority and duplicates it. So, "Link authorities automatically" is wrongly creating new authorities. Please let me know if I am wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #12 from Katrin Fischer --- I think the problem is not the HTML so much as the expectation that it should render... and then it will be used for formatting, which is not a good mix usually - formatting and data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
