[Koha-bugs] [Bug 18796] Allow to print notice while claiming serials

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796

--- Comment #10 from Katrin Fischer  ---
Ping?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31272] New: Show library name not code when placing item level holds in OPAC

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Bug ID: 31272
   Summary: Show library name not code when placing item level
holds in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When placing an item level hold in the OPAC and there are other pending holds,
the branchcode will show instead of the branchname:

On hold for patron expected at FFL since 07/30/2022 .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|30992   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992
[Bug 30992] Hard to translate single word strings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||30992


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992
[Bug 30992] Hard to translate single word strings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25126] MARC visibility settings not obeyed on cart normal and detailed views

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25126

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Katrin Fischer  ---
I retested with 650a set to hidden and this works now. Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138136|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 138398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138398=edit
Bug 30077: (follow-up) Set max width for library drapdown

If you have a library with a very long name the dropdown will expand to
accommodate it. I think this is awkward-looking, so I propose to set a
max width on  elements in the header search region.

The patch requires a rebuild of the staff interface CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137666|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 138393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138393=edit
Bug 30992: Improve translatability for Waiting at|On hold

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684

--- Comment #10 from Katrin Fischer  ---
I think this is about the different behaviour of the add item form
(cataloguing) vs. the add item form (serials). If I read the test plan right,
they should preselect the 0 value in both when you open the forms.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|31272   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272
[Bug 31272] Show library name not code when placing item level holds in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30672] Special characters entered into circulation and fine rules causes errors

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30672

--- Comment #2 from Katrin Fischer  ---
I think what was meant here was the missing validation on the fields that is
maybe partially to blame on the switch to circulation_rules. Before, you
couldn't save an amount of 4,00€ in fine, now you can, but it will cause
problems down the road.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138134|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 138396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138396=edit
Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown

To test:
1. Apply patch, updatedatabase, restart_all
2. Search for the system pref 'IntranetAddMastheadLibraryPulldown'
3. Set it to 'Show'.
4. Go to any page that contains header search box and click on 'Search
   the catalog'.
5. To the left of the search bar you should see a dropdown for branches.
6. This should be defaulted to 'All libraries'.
7. In the dropdown choose any branch and do a search and make sure it is
   correctly limiting to that branch.
8. Try changing to a different branch and doing another search. It
   should correcrly limit to that branch BUT it should also default back
   to 'All libraries' for the next search.
9. Try selecting 'All libraries' from the top of the dropdown and make
   sure it is correctly searching all branches.
10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make
sure it looks nice with both of those dropdowns and functions when
you use limiters from both dropdowns.

Signed-off-by: Sally 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31272


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272
[Bug 31272] Show library name not code when placing item level holds in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138241|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 138392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138392=edit
Bug 31251: Use jQuery val() to clear_entry

1. Add some patron attributes that are textarea and some that have an AV
category so they are select dropdowns
2. Go to the patron form and add some values to the patron attributes
3. Use the "Clear" button to try and clear the values, doesnt work.
4. Apply patch
5. Try clearing values from patron attributes that are both select dropdowns
and textarea. The "Clear" button should work.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #417 from Victor Grousset/tuxayo  ---
Hi :) I tried to rebase because why not, but hit a wall on the changes on
ModReserveFill which was moved (and changed a lot) to Hold::fill(). I don't
know where is a right place to put the new code:

# if this hold was part of a group, cancel other holds in the group
my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id });
foreach my $h ( @holds ) {
$h->cancel unless $h->reserve_id == $hold->reserve_id;
}


Also, maybe these lines are also needed in Hold::cancel()
Not sure at all.

I would gladly give another try if someone know what to do about the two above
points.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31272


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272
[Bug 31272] Show library name not code when placing item level holds in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18783] Allow automatic claims for serials

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #15 from Katrin Fischer  ---
(In reply to Jessie Zairo from comment #13)
> When testing we got an error of DBIx::Class::Row::store_column(): No such
> column 'auto_claim_enabled' on Koha::Schema::Result::Subscription at
> /kohadevbox/koha/Koha/Object.pm line 79
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77

If you see an error like this, make sure that the database update has run and
if there is no Schema update patch, you need to 'refresh schema' in the sandbox
or run the dbic command.

Would love to see this back in the queues!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805

--- Comment #10 from Victor Grousset/tuxayo  ---
(In reply to Katrin Fischer from comment #0)
> Are we still supporting 5.7?
> 
> If not, should we highlight that somewhere?
> 
> We currently only list MariaDB versions on the wiki linked from release
> notes:
> https://wiki.koha-community.org/wiki/System_requirements_and_recommendations
> 
> We are still listing MySQL here:
> https://koha-community.org/download-koha/

Woops I only understand now why I was CCed here.
The only CI running MySQL is for Master with MySQL 8
Since more than a year anything could break with MySQL 5.7 and we wouldn't
notice it in any release. So maybe we didn't formally decided to not support it
but the current state is not a support one.

I added the question to the next meeting:
https://wiki.koha-community.org/wiki/Development_IRC_meeting_3_August_2022

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20119] Ability to print claims for late orders

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #21 from Katrin Fischer  ---
Hi Alex, could you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20119 - Ability to print claims for late orders
Applying: Bug 20119 - Add unit tests
error: sha1 information is lacking or useless (C4/Letters.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 20119 - Add unit tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-20119---Add-unit-tests-BTwZip.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31258] Accessing patron lists from patron accounts

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31258

Katrin Fischer  changed:

   What|Removed |Added

Version|21.11   |master

--- Comment #1 from Katrin Fischer  ---
Again, this would be better as an omnibus bug with the ideas listed as several
small bugs. Easier to solve and better to advertise :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #23 from Joonas Kylmälä  ---
Created attachment 138391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138391=edit
Bug 31223: Do not explode if plugins disabled

This patch makes the code skip calculating the plugin-related task
codes => class mapping if plugins are entirely disbaled.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t
=> FAIL: Tests explode with: Can't call method "GetPlugins" on an
undefined value at... Koha/BackgroundJob.pm line 424.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Joonas Kylmälä  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi
   |y.org   |
 CC||joonas.kylm...@iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #138142|0   |1
is obsolete||
 Attachment #138143|0   |1
is obsolete||

--- Comment #22 from Joonas Kylmälä  ---
Created attachment 138390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138390=edit
Bug 31223: Regression tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #138376|0   |1
is obsolete||

--- Comment #8 from Joonas Kylmälä  ---
Created attachment 138389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138389=edit
Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to
correct keyboard shortcuts

Keyboard shortcuts for catalog search, check in and renew should be following:
1) Alt-q for catalog search
2) Alt-r for check in
3) Alt-w for renew

However on some of the pages shortcuts get mixed up:

1) Alt-w for catalog search
2) Alt-q for check in
3) Alt-r for renew

Affected files are:
circ/pendingreserves.tt
circ/circulation_batch_checkouts.tt
circ/circulation-home.tt
circ/branchtransfers.tt
circ/branchoverdues.tt
circ/set-library.tt
circ/checkout-notes.tt
circ/renew.tt
circ/waitingreserves.tt
circ/transferstoreceive.tt
circ/offline.tt
circ/bookcount.tt
circ/on-site_checkouts.tt
circ/circulation.tt
circ/transfers_to_send.tt
circ/request-article.tt
circ/overdue.tt
circ/reserveratios.tt
offline_circ/list.tt
offline_circ/process_koc.tt
offline_circ/enqueue_koc.tt
plugins/plugins-upload.tt
plugins/plugins-disabled.tt
pos/registers.tt
pos/register.tt
pos/pay.tt
reports/reports-home.tt
reports/dictionary.tt
reports/guided_reports_start.tt
reserve/request.tt
tools/scheduler.tt

This is because the include statement for catalogue-search-box.inc is in the
wrong line in circ-search.inc.

To test:
1) Go to an affected page (circulation-home was the first one I noticed)
2) Try the keyboard shortcuts and notice they are incorrect
3) Apply patch and refresh the page
4) Notice that the keys work properly

Signed-off-by: Andrew 

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@iki.fi
 QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi
   |y.org   |
Version|21.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Katrin Fischer  ---
Looking at this again... the libsuite8 conversion is an odd one:

IMS-b-126 searches for: CPL-IMS-b--126 => Where is the branchcode suddenly
coming from?

This should not happen, IMS-B-125 should stay identical on conversion?

t/Circulation_barcodedecode.
'libsuite8' => ['b000126', 'b12', 'B0126', 'IMS-B-126',
'ims-b-126','CD024','00123','11998'],
'libsuite8' => ['IMS-b-126', 'IMS-b-12', 'IMS-B-126', 'IMS-B-126',
'ims-b-126','IMS-CD-24','IMS-b-123','IMS-b-11998'],

Can you have a look please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31271] New: "Edit search" always resets search options to keyword

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Bug ID: 31271
   Summary: "Edit search" always resets search options to keyword
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, n...@bywatersolutions.com

To test:
- Go to the advanced search in the staff interface
- Select Barcode as search option and search for a non-existing barcode
- From the search results, go back by Edit search link
- Verify the search option flipped back to Keyword :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #81 from Joonas Kylmälä  ---
Did some testing, no code review yet but noticed the following problems:

1. Going to a serial biblio's detail page fails on opac, e.g. page
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 on KTD.

> DBIx::Class::ResultSource::_resolve_join(): No such relationship serial on 
> Item at /kohadevbox/koha/Koha/Objects.pm line 421

Same error on the detail.pl on the staff side.


2. Go to any biblio's OPAC detail page, checkout an item for that biblio and
notice the Status column is not updated and it still shows "Available". Before
applying these patches the status was "Checked out"

3. serials/routing-preview.pl doesn't display the branch name anymore.

Will continue testing after this, there are still some things I want to test on
the biblio detail pages that I cannot due to the internal server errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

--- Comment #2 from Katrin Fischer  ---
I like this, but I was a little worried it could create problems with the other
barcode filters.

So what happens if the barcode is not scanned but for example copied from a
report or from the items table (already being converted?)

Are we sure the existing filters will not "double-convert" those?

So I have tested (looking at the test for the barcode filters):

libsuite8
Unconverted: b000126 searches for:
Converted: IMS-b-126 searches for: CPL-IMS-b--126
--> unwanted conversion
This is odd, because the test covers this and they should actually be the same?
The additional space should not upset Koha, so we can probably ignore this.

Also tested CueCat, T, EAN etc. and it looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138379|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 138388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138388=edit
Bug 28864: Have patron card creator use PatronsPerPage

Add pageLength to members/member.tt
Add aLengthMenu and pageLength to
 patroncards/add_user_search (common/patron_search.tt).
Add aLengthMenu, pageLength, and iDisplayLength to patroncards/edit-batch

Test plan:
1.  Set the PatronsPerPage system preference to any integer other than 20.

2.  Go to Tools -> Patron card creator.
3.  Start a new Card Batch.
4.  Click the 'Add patron(s)' button to open the patron search window.
5.  Do a search.
6.  Add more than 20 patrons to the batch.
7.  Close patron search window.
8.  Click the 'Add patron(s)' button to add the selected patrons to the batch.
9.  Observe that the table of patrons is has 20 as the default per page
setting.

10. Apply patch.
11. Reload the batch.
12. Observe that the per page drop down includes the value of PatronsPerPage
 and that value is selected by default.

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This enhancement allows |This enhancement allows
  release notes|libraries to receive|libraries to receive
   |notifications when patrons  |notifications when patrons
   |self-register.
 |self-register.
   |
   |
   |This is |This is
   |enabled using the new   |enabled using the new
   |system preference   |system preference
   |EmailPatronRegistrations|EmailPatronRegistrations
   |(options are: none, email   |(options are: none, email
   |address of branch,  |address of library,
   |EmailAddressForPatronRegist |EmailAddressForPatronRegist
   |rations, and|rations, and
   |KohaAdminEmailAddress) and  |KohaAdminEmailAddress) and
   |a new notice (OPAC_REG).
   |a new notice (OPAC_REG).
   ||
   |To use a specific email |To use a specific email
   |address for notifications,  |address for notifications,
   |use the new system  |use the new system
   |preference  |preference
   |EmailAddressForPatronRegist |EmailAddressForPatronRegist
   |rations.
   |rations.
   |
   |
   |If verification |If verification
   |is required for |is required for
   |self-registrations (when|self-registrations (when
   |PatronSelfRegistrationVerif |PatronSelfRegistrationVerif
   |yByEmail is enabled), then  |yByEmail is enabled), then
   |notifications are only sent |notifications are only sent
   |to the library once the |to the library once the
   |registration is confirmed.  |registration is confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138237|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 138383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138383=edit
Bug 23538: Database changes

Sponsored-by: Catalyst IT

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #33 from Katrin Fischer  ---
Very happy to see inbound_email_address and ReplyToDefault used here!

installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql is no longer
necessary. I have amended David's patch removing the file and adjusting the
commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138240|0   |1
is obsolete||

--- Comment #31 from Katrin Fischer  ---
Created attachment 138386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138386=edit
Bug 23538: (follow-up) Fix up notices

- Add toolkit template (TT) syntax to notices
- Add TT conditionals to notices

Sponsored-by: Catalyst IT

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #23 from Katrin Fischer  ---
Thanks for clearing that up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138238|0   |1
is obsolete||

--- Comment #29 from Katrin Fischer  ---
Created attachment 138384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138384=edit
Bug 23538: Email library when new patron self-registers

Test plan:
1. Apply all patches
2. Update database
3. Restart services
4. Set email addresses in:
- KohaAdminEmailAddress syspref
- EmailAddressForPatronRegistrations syspref
- Email address in the library branch
5. Enable PatronSelfRegistration syspref
6. Test the following use cases:

- EmailPatronRegistrations syspref = 'none'.
Submit OPAC registration.
= OUTCOME: Confirm no OPAC_REG notice in message_queue table

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138239|0   |1
is obsolete||

--- Comment #30 from Katrin Fischer  ---
Created attachment 138385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138385=edit
Bug 23538: Unit tests

Test plan:
1. Run unit tests:
sudo koha-shell 
cd t/db_dependent/Koha
prove -v Patron.t

Sponsored-by: Catalyst IT

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #32 from Katrin Fischer  ---
Created attachment 138387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138387=edit
Bug 23538: (QA follow-up) Group system preferences into one entry

This makes the new perferences EmailPatronRegistrations and
EmailAddressForPatronRegistrations
follow a little more closely the pattern set by the very similar
EmailPurchaseSuggestions and EmailAddressforSuggestions.

* Group both preferences into one entry
* Add line break between preferences
* Switch branch for library in pull down

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31270] Terminology: Standardize on self-registration or self registration

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

--- Comment #1 from Katrin Fischer  ---
Maybe some native speaker can help?

According to coding guidelines we use AE spelling.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31270] New: Terminology: Standardize on self-registration or self registration

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270

Bug ID: 31270
   Summary: Terminology: Standardize on self-registration or self
registration
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Currently we have a bit of a mix in the templates and the notices and I think
it would be nice to standardize.

I found this, but happy with either as long as we are consistent:
https://www.merriam-webster.com/dictionary/self-registering

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email library when new patrons self register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer  changed:

   What|Removed |Added

Summary|Email Library when New  |Email library when new
   |Patrons Self Register   |patrons self register
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31266] Curbside pickups - New messaging preference

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31266

--- Comment #1 from Katrin Fischer  ---
I think a separate messaging setting would be for sure the cleanest approach. 

A "cheaper" alternative could be to update the text of the messaging
preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264

--- Comment #1 from Katrin Fischer  ---
In Germany the week usually starts on Monday, so the pull down starting with
Sunday is a little irritating and it won't match the calendars and other pages
were calendar settings are used.

I think it would be really nice to fix the pull down on the curbside
configuration page and also the way the scheduled times are displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137308|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 138381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138381=edit
Bug 30964: Add 'restricted' and 'has overdues' on curbside pickup

This patch adds more information about the patron's account on the
curbside pickup list view.
"Patron's account is restricted" if the patron is restricted
"Patron has items overdue" if the patron has overdues

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

--- Comment #6 from Katrin Fischer  ---
Created attachment 138382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138382=edit
Bug 30964: (QA follow-up) Add classes to allow for additional styling

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #1 from Katrin Fischer  ---
I think it's a little tidier and that improves orientation. But I agree there
could be room for more enhancement.

In the OPAC the entries are a little wide, maybe we could center the times as
they are padded and have all the same size and decrease the width a little?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31263] Curbside pickups - Should the patron be able to alert even if not staged

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263

--- Comment #1 from Katrin Fischer  ---
I think it's a little harsh to have them just sit in front of the library. If
we don't allow them to 'alert' we should probably at least display information
about the pickup not being ready yet?
Or a library might want to put a "rush" on it if the patron is already waiting
(and allow the alert)?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Katrin Fischer  ---
My problem with the patron search here is that you get 'stuck' on it.

Search for a patron, pick it - names were all similar, it's not the right one!

There is no way to reset the form. You'd have to schedule a curbside pickup
(which sends an email) and remove it again to get out of it.

Can we have some kind of reset button to get back to search?

Not for this bug, but how do people feel about having a way to open an
'advanced search' (like the normal pop-up) with a button if needed? We've had
complaints form libraries with lots of patrons with very similar names in the
past and this might help them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31256] Circ rules batch modification

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256

Katrin Fischer  changed:

   What|Removed |Added

Version|21.11   |master

--- Comment #1 from Katrin Fischer  ---
Yes, it would be nice :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31254] Add additional fields for accountlines

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254

Katrin Fischer  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Add a curbside pickup module

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add a Curbside Pickup   |Add a curbside pickup
   |module  |module

--- Comment #162 from Katrin Fischer  ---
It looks like we have a failing test now?
not ok 264 - Module Koha::CurbsidePickupPolicys should be defined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30327] Sort component parts

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327

--- Comment #44 from Katrin Fischer  ---
(In reply to Lucas Gass from comment #43)
> Backported to 22.05.x for 22.05.04

I am not sure about this one, if the sorting currently was by biblionumber that
might have been the expected sorting - and it won't work now as long as we
don't have bug 30879 in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29188] Expired serial subscriptions can still receive issues

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29188

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31268

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #136076|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 138377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138377=edit
Bug 30624: Add select_loggedin_library permission

To test:
1. Apply patch, updatedatabase, restart_all
2. Have a user with superlibrarian privileges ( User1 )
3. Have a user who has staff access and circulate privileges but is not a super
librarian. ( User2 ) Make note of this users home library
4. Turn on the system preference 'CircSidebar'.

-MAIN log in ( auth.tt )
5. As User1, go to the main login screen and try logging in. You should be able
to log in AND you should be able to properly chnage your branch BEFORE logging
in.
6. As User2, to to the main login screnn amd try logging in. You should be able
to but if you try and switch your libraray to anything beside the user's home
branch it will not work. You will be logged in at your home branch.
7. For User2, set the new permission 'select_loggedin_library' on.
8. Now you should be able to successfully switch libraries before log in.
9. Turn the 'select_loggedin_library' back off for User2.

-AFTER log in-
10. With User1, click on your name/branch in the top right, you should see the
the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the
link will be 'Set library and desk'.
11. With User2, click on your name/branch in the top right. If you have
'UseCirculationDesks' on, you should see 'Set desk', otherwise you should see
nothing.
12. Repeat step 7.
13. NOw if you click on your name/branch in the top right, you should see the
the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the
link will be 'Set library and desk'.
14. Repeat Step 9.

-CircSideBar-
15. With 'CircSideBar' turned on, go to any ciculation page (Holds queue, Holds
to pull, Holds awaiting pickup) with User1. You will see the 'Set library'
link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'.
16. Try with User2 and you will not see a 'Set library' link. If
'UseCirculationDesks' is on you will see a 'Set desk' link.
17. Repeat step 7.
18. For with User2 you go to any ciculation page (Holds queue, Holds to pull,
Holds awaiting pickup). You will see the 'Set library' link. If
'UseCirculationDesks' is on you will see a 'Set library and desk'.
19. Repeat step 9.

-Set library page-
20. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User1. You will
see a dropdown for 'Set library'. Make sure you can change your library
successfully.
21. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. You should
NOT see see a dropdown for 'Set library'.
22. Repeat step 7.
23. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. Now you
should see a dropdown for 'Set library'.

Signed-off-by: Andrew 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15338] Remove inconsistency in location of SIPServer.pm

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
No longer applies cleanly to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #138297|0   |1
is obsolete||

--- Comment #79 from Jonathan Druart  ---
Created attachment 138307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138307=edit
Bug 27272: Add tests for search_ordered

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #138296|0   |1
is obsolete||

--- Comment #78 from Jonathan Druart  ---
Created attachment 138306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138306=edit
Bug 27272: Allow to pass params and attributes to search_ordered

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30984] Action logs should log the cronjob script name that generated the given log

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #138294|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 138295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138295=edit
Bug 30984: (QA follow-up) Switch from mediumtext to varchar(255)

My research indeicates that tinytext of less than 40 bytes uses
about the same storage as a varchar(255). Also, using
a TEXT field in a complex query may create a temp table.
varchar fields are also more efficient for sorting on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #138197|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26486] Group edit buttons in reports toolbar

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26486

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.04
released in||

--- Comment #6 from Lucas Gass  ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29897] Display author identifiers for researchers

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #62 from Jonathan Druart  ---
Created attachment 138371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138371=edit
Bug 29897: Remove 'linkage' leftover

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30775] 952w should have datepicker plugin enabled for it by default

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.04
released in||
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30994] Typo: item was on loan. couldn't be returned.

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30994

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.04
released in||
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138289|0   |1
is obsolete||

--- Comment #146 from Katrin Fischer  ---
Created attachment 138357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138357=edit
Bug 30650: Don't display slots that have are before now

Signed-off-by: Koha Team University Lyon 3 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

--- Comment #28 from Kyle M Hall  ---
Created attachment 138312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138312=edit
Bug 23919: Zebra search by ISSN variations

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29282] Show items.issue and items.renewals in the holdings table on the detail page in the staff interface

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Needs documenting

--- Comment #18 from Lucas Gass  ---
Enhancment will not be backported to 22.05.x series unless requested

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||31262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262
[Bug 31262] Curbside pickups - disable dates without slots
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138288|0   |1
is obsolete||

--- Comment #145 from Katrin Fischer  ---
Created attachment 138356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138356=edit
Bug 30650: Display holds waiting at the logged-in library

Not those waiting at the library of the logged-in user

Signed-off-by: Koha Team University Lyon 3 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #103 from Jonathan Druart  ---
Created attachment 138290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138290=edit
Bug 30650: Add dayjs customParseFormat plugin

Signed-off-by: Koha Team University Lyon 3 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Add a Curbside Pickup module

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||Manual,
   ||release-notes-needed
 CC||tomasco...@gmail.com
Summary|Convert the Curbside Pickup |Add a Curbside Pickup
   |plugin to Koha core |module

--- Comment #160 from Tomás Cohen Arazi  ---
Great job, Jonathan.

- We could use some more unit tests
- Some of this could've been squashed, specially the typos, etc.
- ^^ I don't care much about the above, this is great

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29897] Display author identifiers for researchers

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #63 from Jonathan Druart  ---
Created attachment 138372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138372=edit
Bug 29897: Adjust syspref description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138283|0   |1
is obsolete||

--- Comment #140 from Katrin Fischer  ---
Created attachment 138351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138351=edit
Bug 30650: Split the permission

We actually want one permission to manage the administration page, and
one for the circulation module.

Signed-off-by: Koha Team University Lyon 3 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138323|0   |1
is obsolete||

--- Comment #154 from Katrin Fischer  ---
Created attachment 138365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138365=edit
Bug 30650: Add the sidebar to the circ view

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

--- Comment #31 from Kyle M Hall  ---
Created attachment 138315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138315=edit
Bug 23919: Add tests for Items search by ISBN and ISSN with variations

(sysprefs SearchWithISBNVariations/SearchWithISSNVariations)

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30269] Use objects directly to display holds on request.pl

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30269

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org
 Status|Needs Signoff   |Failed QA

--- Comment #13 from Andrew Fuerste-Henry  ---
With this patch applied on a sandbox, I am not able to open request.pl for a
bib with holds on it. I get the following error:
"Template process failed: undef error - The method Koha::Hold->date is not
covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875"

After a bunch of error output, it goes on to say:
"in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30937] Add a detail view for libraries

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Needs documenting

--- Comment #7 from Lucas Gass  ---
Enhancement will not be backported to 22.05.x series, unless requested

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha core

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138273|0   |1
is obsolete||

--- Comment #130 from Katrin Fischer  ---
Created attachment 138341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138341=edit
Bug 30650: Add dayjs to opac

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records

2022-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

--- Comment #1 from Lucas Gass  ---
Since columns 4 and 5 are later populated by jQuery 'sDefaultContent' should be
used to define the placeholder value, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/