[Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices script ( advance_notices.pl )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- I fully support having an TT based option besides items.content for these notices. It's about time! But I am still a bit confused about this patch :( What information can I get from issue or issues? (which tables?) We'll definitely need to document. As it has the title in your example, I assume it's not just a line from the issues table, but more than that. https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Variables_available_in_each_notice Terminology: We really should be using checkout instead of issue. If we use checkout(s), will it be the same as the one available in other notices? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #24 from Katrin Fischer --- > bug 30836 needs to address this as a larger issue, but I don't think this > should be held up by that Agreed. So looking for another set of QA eyes or another sign-off here! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023 Katrin Fischer changed: What|Removed |Added Attachment #137662|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 139852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139852&action=edit Bug 31023: Unit tests Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023 Katrin Fischer changed: What|Removed |Added Attachment #137663|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 139853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139853&action=edit Bug 31023: Quote authtypecode in FindDuplicateAuthorities To test: 0 - Have Koha using Elasticsearch 1 - Set QueryRegexEscapeOptions to 'unescape escaped' 2 - Attempt to add a new 'GENRE/FORM' authority record 3 - On save you get a 500 error Unable to understand your search query, please rephrase and try again. at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 102 4 - Apply patch, restart all 5 - Attempt to add a new 'GENRE/FORM' authority record 6 - Success! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Summary|Koha does not currently |Support authority records |support authority records |with common subject |with common subject |headings from different |headings from different |thesaurus |thesaurus | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #137900|0 |1 is obsolete|| --- Comment #38 from Katrin Fischer --- Created attachment 139854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139854&action=edit Bug 30280: Elasticsearch - Add 040f to Subject-heading-thesaurus-conventions (new) authority mapping index field (MARC21) This patch adds 040 $f to a new field Subject-heading-thesaurus-conventions authority index mapping. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #137901|0 |1 is obsolete|| --- Comment #39 from Katrin Fischer --- Created attachment 139855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139855&action=edit 30280: Add support for subject headings from different thesaurus when using Elasticsearch This patch allows subject headings from different thesaurus to co-exist in Koha. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the authorities.mrc file was saved in the koha directory - adjust file location as appropriate): misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches. 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that the first three Feminism headings[1] are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record IDs for the various feminism authority records linked to a specific thesaurus)). 10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev [1] Links for subject terms for step 9 in order are (the authority ids may be different depending on how ou are testing): Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"; MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur Note: The fourth Feminism term has second indicator 4 which means "Source not specified". So this term is only a local term and does not belong to any specific thesaurus and thus not linked. To specify a source of a term, the second indicator must be set as 7. The source of heading is then specified in subfield 2. Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #137902|0 |1 is obsolete|| --- Comment #40 from Katrin Fischer --- Created attachment 139856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139856&action=edit Bug 30280: (follow-up) Removing tab character in Heading.pm Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #41 from Katrin Fischer --- Thx for the great work on the test plan and sample data, this makes it much easier to test :) I am happy to add another sign-off, but for this to go through QA, we will also need unit tests to cover the changes in the .pm files. Please let us know if we can help with that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #42 from Katrin Fischer --- You can switch back to signed off directly once the unit tests are done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #54 from Katrin Fischer --- Sorry for being too late again :( Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17170: DB Updates Applying: Bug 17170: DO NOT PUSH - Schema Updates Applying: Bug 17170: Update schema for boolean Applying: Bug 17170: Add API route for SearchFilters Applying: Bug 17170: Add search filters to staff and opac interfaces Applying: Bug 17170: Handle search filters in query builders error: sha1 information is lacking or useless (C4/Search.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17170: Handle search filters in query builders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #5 from Katrin Fischer --- Created attachment 139857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139857&action=edit Bug 31185: Link authorities automatically doesn't detect duplicate authorities This patch fixes LinkBibHeadingsToAuthorities so it detects duplicate authorities using "Link authorities automatically" To test 1 Make sure the system preference AutoCreateAuthorities is turned to don't generate 2 Create a duplicate authority and check that search in Authorities module returns both. For example, two Personal Name (Smith, John) 3 Create a new record and fill the entry point with the same text of the authorities you just created. For example 100$a Smith, John 4 Click "Link authorities automatically" and you will obtain the following message "No matching authority found." 5 Apply patch, restart services 6 Click "Link authorities automatically" and you will obtain the following message "More than one local match found. Possibly a duplicate authority!" Signed-off-by: Rachael Laritz Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer changed: What|Removed |Added Attachment #138518|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- I have added the bug description and test plan to the commit message according to our guidelines. Also happy to sign off on this, but we'll need a unit test covering this change for it to pass QA. Please let us know if we can help with that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What|Removed |Added Attachment #139526|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 139858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139858&action=edit Bug 31374: Database/Schema update Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What|Removed |Added Attachment #139527|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 139859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139859&action=edit Bug 31374: Add non-public note to template Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What|Removed |Added Attachment #139528|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 139860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139860&action=edit Bug 31374: Add privatenote column to table settings Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What|Removed |Added Attachment #139529|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 139861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139861&action=edit Bug 31374: Update API spec Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What|Removed |Added Attachment #139530|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 139862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139862&action=edit Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What|Removed |Added Attachment #139627|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 139863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139863&action=edit Bug 31374: (follow-up) change private note to staff_note and reorder columns Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #22 from Katrin Fischer --- Created attachment 139864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139864&action=edit Bug 31374: (QA follow-up) Fix typo collumn in database update Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27195] Set focus for cursor to city input box when creating new cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Katrin Fischer changed: What|Removed |Added Assignee|ellawipat...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Katrin Fischer changed: What|Removed |Added Summary|BiblioAddsAuthorities is|Split BiblioAddsAuthorities |poorly named|into 2 preferences Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31474] New: Patron category system preferences cannot be unselected completely
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31474 Bug ID: 31474 Summary: Patron category system preferences cannot be unselected completely Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, oleon...@myacpl.org Initially found by Rhonda on bug 31333, the problem seems to affect all system preferences using the patron category multi-select feature: To test: * Search for the OPACHoldsIfAvailableAtPickupExceptions system preference * Check some patron categories and save * Uncheck all patron categories and save - it says 'nothing to save' * Reload the page or search for OPACHoldsIfAvailableAtPickupExceptions again * The selected values remain and cannot all be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31474 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Summary|Allow the ability to make |Add the ability to limit |purchase suggestions to be |purchase suggestions by |set by borrower type|patron category --- Comment #19 from Katrin Fischer --- I am starting QA here, also filed bug 31474 for the general bug Rhonda found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31474] Patron category system preferences cannot be unselected completely
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31474 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31333 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #652 from Andrew Nugged --- I am now doing intermediate rebase, this one will go on tag v22.04.05 (commit hash 75372f012b4ecc321a0658f22ae4f3700502f018). Intermediate, because in the next step after below pre-rebase (pre- because not yet on current master), I plan to squash and re-factor TOO BIG to debug and do future rebasings code, and this will help us to rebase & sign off much cleaner code later. And also, it will include 7 more (!) bug fixes patches over the current state of the things above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged changed: What|Removed |Added Attachment #131458|0 |1 is obsolete|| Attachment #131459|0 |1 is obsolete|| Attachment #131460|0 |1 is obsolete|| Attachment #131461|0 |1 is obsolete|| Attachment #131462|0 |1 is obsolete|| Attachment #131463|0 |1 is obsolete|| Attachment #131464|0 |1 is obsolete|| Attachment #131465|0 |1 is obsolete|| Attachment #131466|0 |1 is obsolete|| Attachment #131467|0 |1 is obsolete|| Attachment #131468|0 |1 is obsolete|| Attachment #131469|0 |1 is obsolete|| Attachment #131470|0 |1 is obsolete|| Attachment #131471|0 |1 is obsolete|| Attachment #131472|0 |1 is obsolete|| Attachment #131473|0 |1 is obsolete|| Attachment #131474|0 |1 is obsolete|| Attachment #131475|0 |1 is obsolete|| Attachment #131476|0 |1 is obsolete|| Attachment #131477|0 |1 is obsolete|| Attachment #131478|0 |1 is obsolete|| Attachment #131479|0 |1 is obsolete|| Attachment #131480|0 |1 is obsolete|| Attachment #131481|0 |1 is obsolete|| Attachment #131482|0 |1 is obsolete|| --- Comment #653 from Andrew Nugged --- Created attachment 139865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139865&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Co-authored-by: Andrew Nugged Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #654 from Andrew Nugged --- Created attachment 139866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139866&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #655 from Andrew Nugged --- Created attachment 139867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139867&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #656 from Andrew Nugged --- Created attachment 139868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139868&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #657 from Andrew Nugged --- Created attachment 139869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139869&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #658 from Andrew Nugged --- Created attachment 139870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139870&action=edit Bug 20447: Fixes for bug 17600 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #659 from Andrew Nugged --- Created attachment 139871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139871&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged Rebased-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #660 from Andrew Nugged --- Created attachment 139872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139872&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #661 from Andrew Nugged --- Created attachment 139873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139873&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #662 from Andrew Nugged --- Created attachment 139874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139874&action=edit Bug 20447: (QA follow-up) Fix framework switching bug Form's parameter never used because $record was always defined, with new or with existing holding, but always. Fixed by adding incoming $holding_id presence check. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #663 from Andrew Nugged --- Created attachment 139875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139875&action=edit Bug 20447: (QA follow-up) Fix full-path call for xml_escape Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #664 from Andrew Nugged --- Created attachment 139876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139876&action=edit Bug 20447: (QA follow-up) Remove undef warnings and add UX note Use of uninitialized value in concatenation (.) or string at /usr/share/koha/lib/Koha/UI/Form/Builder/Item.pm line 255. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #665 from Andrew Nugged --- Created attachment 139877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139877&action=edit Bug 20447: (QA follow-up) include Koha::Holdings where needed (and remove uses where don't) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #666 from Andrew Nugged --- Created attachment 139878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139878&action=edit Bug 20447: (QA follow-up) undefined $mode warning remove When POST /intranet/cataloguing/addholding.pl happens from any /cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=XXX&holding_id=YYY it has "$mode" undefined but comes to code "$mode ne 'popup'" hence the warning. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #667 from Andrew Nugged --- Created attachment 139879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139879&action=edit Bug 20447: (QA follow-up) typo, framework= should be frameworkcode= we don't have 'framework' param parsed in addholding.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #668 from Andrew Nugged --- Created attachment 139880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139880&action=edit Bug 20447: (QA follow-up) bugfix: holding_id not sent down from params and was not taken into account Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #669 from Andrew Nugged --- Created attachment 139881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139881&action=edit Bug 20447: (QA follow-up) bugfix: itemcallnumber pref wasn't taken into account Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #670 from Andrew Nugged --- Created attachment 139882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139882&action=edit Bug 20447: (QA follow-up) UX improvement: merge point of values should be invisible. This is requested by customers, i.e. no pipe separate char between (librarians said they using it also for copy-pasting, and it confuses patrons because they read roman numbers with this | wrongly) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #671 from Andrew Nugged --- Created attachment 139883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139883&action=edit Bug 20447: (QA follow-up) Warning suppression tab might be undefined (sidenote: probably tags->subfields->tabs structures should be defined more) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #672 from Andrew Nugged --- Created attachment 139884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139884&action=edit Bug 20447: (QA follow-up) bugfix: undefined holding_id in code on store After saving to DB code didn't get back "last inserted ID" so wasn't able to allow for interface to go back to newly created holding ID Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #673 from Andrew Nugged --- Created attachment 139885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139885&action=edit Bug 20447: (QA follow-up) Warning removal: undef param 'sep' expected to be string in further processing Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #674 from Andrew Nugged --- Created attachment 139886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139886&action=edit Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. Note / bigger bug: this happened only for first added item, all next other items in same basket were added without sending biblionumber as in original Koha code: so, this is very suspicious change without any person to explain why. This rolled-back code looks like unfinished feature or mistake. So I will leave this comment especially for future checks, if extension or this feature development will be needed. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #675 from Andrew Nugged --- Created attachment 139887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139887&action=edit Bug 20447: (follow-up) Get frameworks as list Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #676 from Andrew Nugged --- Created attachment 139888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139888&action=edit Bug 20447: (QA follow-up) Fix compatibility to 22.05 Fix to conform with 22.05 Koha::Object's 'search' wantarray removal ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #677 from Andrew Nugged --- Created attachment 139889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139889&action=edit Bug 20447: (QA follow-up) Fix atomic update to be more idempotent Fix atomic update not to add bad ACQ 952k row into marc_subfield_structure when no ACQ present at all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #678 from Andrew Nugged --- Created attachment 139890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139890&action=edit Bug 20447: (QA follow-up) Whitespaces in .css file fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #679 from Andrew Nugged --- Created attachment 139891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139891&action=edit Bug 20447: (QA follow-up) .css file alignment as in addbiblio.css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #680 from Andrew Nugged --- Created attachment 139892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139892&action=edit Bug 20447: (QA follow-up) detail.tt rebase cimpatibility fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #681 from Andrew Nugged --- Created attachment 139893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139893&action=edit Bug 20447: (QA follow-up) addholding.tt rebase compatibility fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #682 from Andrew Nugged --- Created attachment 139894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139894&action=edit Bug 20447: (QA follow-up) Show blocking full-screen error if biblio record removed elsewhere (biblio id not found). Rebased-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #683 from Andrew Nugged --- Now I will combine changes into less scattered code and a smaller number of patches (also because I am now co-authoring this task for a while). Because so many patches patch other patches :) and evolutionary old master branch compatibility changes should be just in 1st commit, so this burden is mostly impossible to rebase over the current master (but we need to). This should help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged changed: What|Removed |Added Attachment #139865|0 |1 is obsolete|| Attachment #139866|0 |1 is obsolete|| Attachment #139867|0 |1 is obsolete|| Attachment #139868|0 |1 is obsolete|| Attachment #139869|0 |1 is obsolete|| Attachment #139870|0 |1 is obsolete|| Attachment #139871|0 |1 is obsolete|| Attachment #139872|0 |1 is obsolete|| Attachment #139873|0 |1 is obsolete|| Attachment #139874|0 |1 is obsolete|| Attachment #139875|0 |1 is obsolete|| Attachment #139876|0 |1 is obsolete|| Attachment #139877|0 |1 is obsolete|| Attachment #139878|0 |1 is obsolete|| Attachment #139879|0 |1 is obsolete|| Attachment #139880|0 |1 is obsolete|| Attachment #139881|0 |1 is obsolete|| Attachment #139882|0 |1 is obsolete|| Attachment #139883|0 |1 is obsolete|| Attachment #139884|0 |1 is obsolete|| Attachment #139885|0 |1 is obsolete|| Attachment #139886|0 |1 is obsolete|| Attachment #139887|0 |1 is obsolete|| Attachment #139888|0 |1 is obsolete|| Attachment #139889|0 |1 is obsolete|| Attachment #139890|0 |1 is obsolete|| Attachment #139891|0 |1 is obsolete|| Attachment #139892|0 |1 is obsolete|| Attachment #139893|0 |1 is obsolete|| Attachment #139894|0 |1 is obsolete|| --- Comment #684 from Andrew Nugged --- Created attachment 139895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139895&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Smaller notes to task parts (batch rebuild script): --- Includes misc/batchRebuildHoldingsTables.pl: a batch rebuild script for holdings table which can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. --- End of smaller notes Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Co-authored-by: Andrew Nugged Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #685 from Andrew Nugged --- Created attachment 139896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139896&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #686 from Andrew Nugged --- All intermediate patches were obsoleted and merged into the final solution, as explained in comment #683 (this is for history to note how it was before): 139865 - Bug 20447: MARC Holdings support 139866 - Bug 20447: Add holding_id to REST API item definition 139867 - Bug 20447: Add a batch rebuild script for holdings table 139868 - Bug 20447: Add import/export support for holdings 139869 - Bug 20447: (QA follow-up) Update for bug 26703 139870 - Bug 20447: Fixes for bug 17600 139871 - Bug 20447: DBIX schema changes 139872 - Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 139873 - Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef 139874 - Bug 20447: (QA follow-up) Fix framework switching bug 139875 - Bug 20447: (QA follow-up) Fix full-path call for xml_escape 139876 - Bug 20447: (QA follow-up) Remove undef warnings and add UX note 139877 - Bug 20447: (QA follow-up) include Koha::Holdings where needed (and remove uses where don't) 139878 - Bug 20447: (QA follow-up) undefined $mode warning remove 139879 - Bug 20447: (QA follow-up) typo, framework= should be frameworkcode= 139880 - Bug 20447: (QA follow-up) bugfix: holding_id not sent down from params 139881 - Bug 20447: (QA follow-up) bugfix: itemcallnumber pref wasn't taken into account 139882 - Bug 20447: (QA follow-up) UX improvement: merge point of values should be invisible. 139883 - Bug 20447: (QA follow-up) Warning suppression 139884 - Bug 20447: (QA follow-up) bugfix: undefined holding_id in code on store 139885 - Bug 20447: (QA follow-up) Warning removal: undef 139886 - Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. 139887 - Bug 20447: (follow-up) Get frameworks as list 139888 - Bug 20447: (QA follow-up) Fix compatibility to 22.05 139889 - Bug 20447: (QA follow-up) Fix atomic update to be more idempotent 139890 - Bug 20447: (QA follow-up) Whitespaces in .css file fixes 139891 - Bug 20447: (QA follow-up) .css file alignment as in addbiblio.css 139892 - Bug 20447: (QA follow-up) detail.tt rebase cimpatibility fixes 139893 - Bug 20447: (QA follow-up) addholding.tt rebase compatibility fixes 139894 - Bug 20447: (QA follow-up) Show blocking full-screen error if biblio record removed elsewhere (biblio id not found). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #687 from Andrew Nugged --- The above is still based on tag v22.04.05 (commit hash 75372f012b4ecc321a0658f22ae4f3700502f018). Now I am doing rebase to the latest master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #16 from Victor Grousset/tuxayo --- To spare testing time you can check the "Depends on:" field of the ticket. Here it links to bug 30733 which isn't in 21.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #33 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #26) > (In reply to Victor Grousset/tuxayo from comment #24) > > (In reply to Marcel de Rooy from comment #23) > > What do you mean? The patch doesn't use --preload-app. > I did not say that. Please read the comment. It is a quote. That confusion was after reading it several time before writing the message because I wasn't sure what you meant by this quote. And the best I could come up with is that we were using --preload-app So still confused but glad it got sorted out in this end ^o^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
