[Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472

--- Comment #6 from Marcel de Rooy  ---
(In reply to Fridolin Somers from comment #4)
> Signed-off-by: Fridolin Somers 

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472

--- Comment #5 from Fridolin Somers  ---
Makes perfect sens.
Generated DBIx looks OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||30472


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472
[Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT
NULL
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Depends on||14570


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
[Bug 14570] Make it possible to add multiple guarantors to a record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #139711|0   |1
is obsolete||

--- Comment #4 from Fridolin Somers  ---
Created attachment 139972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139972&action=edit
Bug 30472: Make borrower_relationships.guarantor_id not null

In harmony with dbrev 19.06.00.022.

Test plan:
Run dbrev.
Run t/db_dependent/Patron/Relationships.t
Run t/db_dependent/Koha/Patrons.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472

Fridolin Somers  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139738|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139739|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #5 from Alex Buckley  ---
I am working on a compromise patch for this bug report - as per
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456#c6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139971|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446

--- Comment #4 from Alex Buckley  ---
Created attachment 139971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139971&action=edit
Bug 31446: Add IDs to parent elements of cover images

Having ID attributes for all parent div tags of OPAC lightbox cover images
would
make it easier for libraries to hide the lightbox descriptions hint text
displaying under cover images.

Libraries could simply add some JavaScript (in a format like below) to their
OpacUserJS system preference for each image content source they use:
$("#coce-coverimg > .hint").hide();

Test plan:
1. Apply patch
2. Confirm all parent div elements of cover images now have an ID in
opac-detail.tt

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446

Alex Buckley  changed:

   What|Removed |Added

Summary|Optionally hide |Make it easier for
   |lightbox_descriptions from  |libraries to hide
   |OPAC lightbox gallery   |lightbox_descriptions from
   ||OPAC lightbox gallery

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139739|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139738|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153

--- Comment #15 from David Cook  ---
(In reply to Katrin Fischer from comment #7)
> Could we treat it ' as a space and 'no space' at the same time maybe? 

Without language-specific analysis, this might be the best way to go...

(In reply to Nick Clemens from comment #13)
> Created attachment 139969 [details] [review]
> Bug 27153: POC
> 
> This is a small example to show that we can add an extra field to our
> default indexing that
> removes punctuation.
> 
> If we then add that field to the fields we push, we can sarch both the
> regular and the punctuation stripped version

I'm not very familiar with the Elasticsearch integration, but that POC doesn't
touch the indexing, does it? Isn't it just modifying the search? (I don't know
that it's touching apostrophes either?)

If you searched "carries war" but it had been indexed as "carrie s war", then
you still wouldn't get a hit?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153

--- Comment #14 from David Cook  ---
I had a librarian (from an English-only library) asking for this the other day,
and I was wondering why we have apostrophes replaced with a space (both for CHR
and ICU indexing with Zebra).

But Frido's example makes a lot of sense:

(In reply to Fridolin Somers from comment #6)
> Elision removes the text : l'europe = europe
> This apostrophe filter creates : l'europe = leurope
> 
> Wrong in french but surely ranking will bet better for the exact match.

And in English, we'd have "father's" become "fathers", which means "father"
wouldn't match unless you're using right truncation (which Koha typically does
out of the box I suppose). 

But then there's a Ukrainian word під'їзд which if you broke it into під їзд,
you'd get hits for під which is a totally unrelated word.  

--

I know people have praised Google here, but it's not perfect either. 

Try searching "l'arbre під'їзд" and try searching "під'їзд l'arbre", and you'll
get wildly different results. 

It seems that Google tries to determine the language of the search query
(possibly based off the first word), and then analyze the search string based
off that. 

For "l'arbre під'їзд", you get many results with "L'Arbre", "des arbres",
"arbre", etc. Most results seem to include Russian rather than Ukrainian. 

But for "під'їзд l'arbre", you only get a few results that have the string
"L'Arbre"and most of the results are Ukrainian. 

So Google is likely determining the language of the search string and then
applying a language-specific analyzer. 

"My mom" in Chinese is 我的妈妈. 的 is the character that denotes possession of mom
(妈妈) by me/I (我). You might think then you could replace 的 with a space to
separate the 2 nouns... except 的 isn't always used that way. The word 目的 means
"goal". Doing anything to 的 would compromise the word, unless you're able to
understand the context that it's used in. 

If you google "我的妈妈", eventually it strips off "我的" and just searches for "妈妈"
since that's the main noun in the phrase. 

Search is hard.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25816] Add OPAC messages in SIP display

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483

Lucas Gass  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com
 Status|NEW |Needs Signoff
   Severity|enhancement |trivial
 CC||lu...@bywatersolutions.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483

--- Comment #1 from Lucas Gass  ---
Created attachment 139970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139970&action=edit
Bug 31483: Correct tiny HTML error on password reset page

To test:
1) Enable EnableExpiredPasswordReset
2) Find a patron and change their password so you know what it is supposed to
be
3) In the database, expire the patron's password, e.g.
UPDATE borrowers SET password_expiration_date = '2022-08-22' where
borrowernumber = 21;
4) Go to the OPAC, try to log in with the patron's credentials
5) Click Reset your password
=> Note that the form is in the grey breadcrumbs box, you can compare with any
other OPAC page, the grey box should only contain the breadcrumbs
6) Apply patch
7) Try steps 4-5 again. The gray breadcrumbs box should be for breadcrumbs
only!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153

--- Comment #13 from Nick Clemens  ---
Created attachment 139969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139969&action=edit
Bug 27153: POC

This is a small example to show that we can add an extra field to our default
indexing that
removes punctuation.

If we then add that field to the fields we push, we can sarch both the regular
and the punctuation stripped version

To complete this we would need to add a 'search variations' field to the ES
config page, for the user to decide which
fields should be searched in all variations, and which shouldn't

Or we could add this to all 'simple searches' from the search bar, and only
search exact on advanced searches.

I am happy to explore either option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #63 from Lucas Gass  ---
Thanks for the feedback Cait and Andrew! I agree that adding the pronouns to
the patron-title include makes things cumbersome. 

Since this is mostly informational for staff I think it is adequate to show it
in the brief display and on the details page. The most sense to be would be
underneath that patrons name, so that is where I added it in my follow-up. 

Also, happy to have other opinions therefore I am resetting this to Needs
Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #62 from Lucas Gass  ---
Created attachment 139968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139968&action=edit
Bug 10950: (follow-up) Change display of pronoun fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090

Alex Buckley  changed:

   What|Removed |Added

 Attachment #112493|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090

Alex Buckley  changed:

   What|Removed |Added

 Attachment #112494|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090

Alex Buckley  changed:

   What|Removed |Added

 Attachment #112495|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090

Alex Buckley  changed:

   What|Removed |Added

 Attachment #112496|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25090] Moderate OPAC self registrations before a patron account is created

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090

Alex Buckley  changed:

   What|Removed |Added

 Attachment #112497|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31486] Deleting a message from circulation.pl redirects to moremember.pl

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
  Text to go in the||This patch corrects a
  release notes||problem where message
   ||deletion was improperly
   ||redirecting to the patron
   ||delete page when a message
   ||is deleted on the
   ||circulation page.
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31486] Deleting a message from circulation.pl redirects to moremember.pl

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486

--- Comment #1 from Lucas Gass  ---
Created attachment 139967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139967&action=edit
Bug 31486: Redirect to proper page after message deletion

To test:
1. Go to a patron account and create some messages
2. Try deleting some from both the patron details page and the patron checkout
page.
3. Notice that is you are on the patron checkout page and delete a message you
are then redirected to the patron details page.
4. Apply patch
5. Try deleting messages from both pages and confirm you are redirected back to
that same page and the message is properly deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31486] Deleting a message from circulation.pl redirects to moremember.pl

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl'

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209

--- Comment #12 from Victor Grousset/tuxayo  ---
(In reply to Mason James from comment #10)
> hi tuxayo, any chance we can get this patch added to 21.05?

What about 21.11?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl'

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|22.05.00|22.05.00, 21.05.19
released in||

--- Comment #11 from Victor Grousset/tuxayo  ---
Backported: Pushed to 21.05.x branch for 21.05.19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473

--- Comment #3 from Victor Grousset/tuxayo  ---
Thanks a lot :D

Backport needed down to 21.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167

--- Comment #1 from Joonas Kylmälä  ---
Created attachment 139966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139966&action=edit
Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl

With UseCashRegisters syspref disabled going to the page
/cgi-bin/koha/circ/set-library.pl in staff interface and setting a
library gives the following errors in plack-intranet-error.log:

Use of uninitialized value $register_id in string ne at
/kohadevbox/koha/circ/set-library.pl line 79.
Use of uninitialized value $referer in pattern match (m//) at
/kohadevbox/koha/circ/set-library.pl line 114.

In the if clause $userenv_register_id appears to be typoed, it should have
been $register_id as $userenv_register_id is always defined. As for the
$referer variable, it is undef if there is no referer so let's just initialize
it to an empty string for the regex so it doesn't give the warning.

To test:
 1) Go directly to /cgi-bin/koha/circ/set-library.pl by typing it in
the URL bar and set a library
 2) Make sure plack-intranet-error.log doesn't contain the above mentioned
errors
after applying this patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167

Joonas Kylmälä  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31486] New: Deleting a message from circulation.pl redirects to moremember.pl

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486

Bug ID: 31486
   Summary: Deleting a message from circulation.pl redirects to
moremember.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If you are on the patron checkout page (circulation.pl) and you delete a
message you will be redirected to the details page (moremember.pl)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15002] All system resources get used if user refreshes a web page

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15002

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Joonas Kylmälä  ---
Unactionable as such, need to work on specific perf problems to mitigate the
resource usage. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153

Jennifer Millikan  changed:

   What|Removed |Added

 CC||jmilli...@sja1840.org

--- Comment #12 from Jennifer Millikan  ---
I am brand new to Koha, but I was told this bug is why I have to include
apostrophes while searching. I tried searching for Don't Hate the Player title
and came up with zero results. I did not use the apostrophe because I have
never had to before in multiple catalog systems. I repeated the search with the
apostrophe and found the title. I agree with this and think the searching
should work both ways with or without the apostrophe. Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Jennifer Millikan  changed:

   What|Removed |Added

 CC||jmilli...@sja1840.org

--- Comment #65 from Jennifer Millikan  ---
I am brand new to Koha, but I was told this bug is why I have to include
apostrophes while searching. I tried searching for Don't Hate the Player title
and came up with zero results. I did not use the apostrophe because I have
never had to before in multiple catalog systems. I repeated the search with the
apostrophe and found the title. I think the searching should work both ways
with or without the apostrophe. Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@iki.fi

--- Comment #1 from Joonas Kylmälä  ---
Martin, Any status update? I'm thinking whether to work on this, unless you
have some plans already.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485

--- Comment #1 from Joonas Kylmälä  ---
Created attachment 139965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139965&action=edit
Bug 31485: Move _item_denied_renewal to Koha::Item

The question whether item is denied renewal doesn't depend on
circulation rules or the patron, it is only a property of the item and
only changes to the item's attributes can cause the return value of
the check to change, thus we should move this to be a method of
Koha::Item.

To test:
 1) Run unit tests
$ prove t/db_dependent/Circulation.t
$ prove t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31485] New: Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485

Bug ID: 31485
   Summary: Move ItemsDeniedRenewal checks from C4::Circulation to
Koha::Item
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: joonas.kylm...@iki.fi
  Reporter: joonas.kylm...@iki.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

C4/Circulation.pm contains currently a function called _item_denied_renewal
which is clearly a method of Koha::Item, thus it should be moved there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

--- Comment #12 from Kyle M Hall  ---
(In reply to Kyle M Hall from comment #11)
> I have no idea what's going on, but in production this is breaking SIP!
> No errors in the logs.
> Is anyone else experiencing this?

Ignore this^ I had set max lower than min. That was my bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

--- Comment #11 from Kyle M Hall  ---
I have no idea what's going on, but in production this is breaking SIP!
No errors in the logs.
Is anyone else experiencing this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458

--- Comment #4 from Kyle M Hall  ---
I believe we've discussed this elsewhere, but just to make sure it's public;
The field borrowers.debarred was retained so that existing code utilizing the
debarred field would continue to work. In practice, sometimes that field gets
out of sync with the actual debarments. At this point in time, it makes a lot
more sense to remove borrowers.debarred from the database. I think the same can
be said for debarredcomment as well.

(In reply to Martin Renvoize from comment #3)
> Created attachment 139800 [details] [review]
> Add _update_patron_restriction_fields
> 
> This still needs some work.. picking which of the two constructs for
> ordering works and removing new lines from the debarredcomment field.
> 
> Do we even need the local debarredcomment field any more... and should
> the debarred field just become a boolean.. or should we just drop the
> fields from the borrowers table entirely and rely on relations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #139802|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 139964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139964&action=edit
Bug 25426: Allow return policy to be selected via syspref and not just home
library

1) Apply this patch
2) Run updatedatabase.pl
3) Verify CircControlReturnsBranch is set to home library by default
4) Set a Return policy for Branch A to "Item returns home" ( homebranch )
5) Set a Return polity for Branch B to "Item returns to issuing library" (
holdingbranch )
6) Set a Return polity for Branch C to "Item floats" ( noreturn )
7) Create an item with homebranch of Branch A, holding branch of branch B
8) Log in as Branch C
9) Set CircControlReturnsBranch to "the library the item is currently held by"
10) Check the item in, note it should be returned to the holding library
11) Set CircControlReturnsBranch to "the library the item is owned by"
12) Check the item in, note it should be returned to the home library
13) Set CircControlReturnsBranch to "the library you are logged in at"
14) Check the item in, note it should float

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Carl  changed:

   What|Removed |Added

 CC||ct...@hcc.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31484] New: Renewals disabled message doesn't display all reasons why something cannot be renewed

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31484

Bug ID: 31484
   Summary: Renewals disabled message doesn't display all reasons
why something cannot be renewed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

There are many reasons why the renewals-disabled button might display in the
issues table but not all of them will display depending on the circumstance,
this can hamper librarians ability to make correct choices. 

For example:
1. Have an item checkout out what can be renewed at least one time BUT make
that item overdue. 
2. In the renewal column you'll see "0 Not allowed: overdue". That is good.
3. Have 'AllowRenewalOnHoldOverride' set to 'Don't allow'
4. Place the same item from 1-2 on hold. Make it an item level hold on that
specific item.
5. Look at the issues table again, it still says "0 Not allowed: overdue". 
6. The message should include some language saying the item can't be renewed
becuase it is on hold AND it is overdue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30648] Title is lost in Holds History when biblio is deleted

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648

--- Comment #3 from Owen Leonard  ---
In the meantime I think we need an update to the holds history page in the OPAC
to exclude deleted titles.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29198] Inconsistencies in opac results display vs staff results display

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29198

--- Comment #3 from Lucas Gass  ---
This is still a bug although things have changed somewhat since I intially
filed it. 

To recreate:

1. Create a NOT_LOAN value with a AV of 1. Give it both an description and OPAC
desrciption.
2. Find something in the catalog with at least 2 items. 
3. Mark at least 1 item with the new NOT_LOAN value. 
4. Look at OPAC results vs staff results, the displays are not consistent. The
OPAC says 1 available for reference. The staff client results says 1
unvailable.
5. Look at OPAC detail vs staff detail. OPAC says 'Available' while the staff
client says "Not for loan (Staff description) Available"

These displays should all be consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||31483


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483
[Bug 31483] Minor UI problem in opac-reset-password.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||31382


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382
[Bug 31382] Cannot reach password reset page when password expired
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31483] New: Minor UI problem in opac-reset-password.pl

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483

Bug ID: 31483
   Summary: Minor UI problem in opac-reset-password.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When EnableExpiredPasswordReset is enabled, patrons can access a page to reset
their password. In this page, the grey box that normally contains the
breadcrumbs encompasses the whole form.

To test:
1) Enable EnableExpiredPasswordReset
2) Find a patron and change their password so you know what it is supposed to
be
3) In the database, expire the patron's password, e.g.
UPDATE borrowers SET password_expiration_date = '2022-08-22' where
borrowernumber = 21;
4) Go to the OPAC, try to log in with the patron's credentials
5) Click Reset your password
=> Note that the form is in the grey breadcrumbs box, you can compare with any
other OPAC page, the grey box should only contain the breadcrumbs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269

Mason James  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl'

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209

Mason James  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 CC||vic...@tuxayo.net

--- Comment #10 from Mason James  ---
(In reply to Mason James from comment #7)
> (In reply to Mason James from comment #5)
> > hi Frido
> > can you apply this patch to pass the master tests on jenkins
> > 
> > https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/548/
> 
> lets not apply this to 21.11 and lower, for now

hi tuxayo, any chance we can get this patch added to 21.05?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269

Mason James  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 CC||vic...@tuxayo.net
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl'

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209

--- Comment #9 from Mason James  ---
(In reply to Mason James from comment #7)
> (In reply to Mason James from comment #5)
> > hi Frido
> > can you apply this patch to pass the master tests on jenkins
> > 
> > https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/548/
> 
> lets not apply this to 21.11 and lower, for now

hi tuxayo, any chance we can get this patch added to 21.05?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #17 from Lucas Gass  ---
Created attachment 139963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139963&action=edit
Bug 30624: (follow-up) Remove IndependentBraches check on auth.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #16 from Lucas Gass  ---
(In reply to Fridolin Somers from comment #12)
> I mean in authentication TT.
> Actually there is only a UNLESS IndependentBranches :
> 
> https://git.koha-community.org/Koha-community/Koha/src/commit/
> fc78953951837f6fe7a3e9d66ac497dcb5511f53/koha-tmpl/intranet-tmpl/prog/en/
> modules/auth.tt#L91

Ah, yes! Since that will be handled by a permission we no longer need this
check, the dropdown should always show.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #15 from Lucas Gass  ---
rebased for current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

 Attachment #138378|0   |1
is obsolete||

--- Comment #14 from Lucas Gass  ---
Created attachment 139962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139962&action=edit
Bug 30624: DB Update to add permission

Signed-off-by: Andrew 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

 Attachment #138377|0   |1
is obsolete||

--- Comment #13 from Lucas Gass  ---
Created attachment 139961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139961&action=edit
Bug 30624: Add select_loggedin_library permission

To test:
1. Apply patch, updatedatabase, restart_all
2. Have a user with superlibrarian privileges ( User1 )
3. Have a user who has staff access and circulate privileges but is not a super
librarian. ( User2 ) Make note of this users home library
4. Turn on the system preference 'CircSidebar'.

-MAIN log in ( auth.tt )
5. As User1, go to the main login screen and try logging in. You should be able
to log in AND you should be able to properly chnage your branch BEFORE logging
in.
6. As User2, to to the main login screnn amd try logging in. You should be able
to but if you try and switch your libraray to anything beside the user's home
branch it will not work. You will be logged in at your home branch.
7. For User2, set the new permission 'select_loggedin_library' on.
8. Now you should be able to successfully switch libraries before log in.
9. Turn the 'select_loggedin_library' back off for User2.

-AFTER log in-
10. With User1, click on your name/branch in the top right, you should see the
the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the
link will be 'Set library and desk'.
11. With User2, click on your name/branch in the top right. If you have
'UseCirculationDesks' on, you should see 'Set desk', otherwise you should see
nothing.
12. Repeat step 7.
13. NOw if you click on your name/branch in the top right, you should see the
the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the
link will be 'Set library and desk'.
14. Repeat Step 9.

-CircSideBar-
15. With 'CircSideBar' turned on, go to any ciculation page (Holds queue, Holds
to pull, Holds awaiting pickup) with User1. You will see the 'Set library'
link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'.
16. Try with User2 and you will not see a 'Set library' link. If
'UseCirculationDesks' is on you will see a 'Set desk' link.
17. Repeat step 7.
18. For with User2 you go to any ciculation page (Holds queue, Holds to pull,
Holds awaiting pickup). You will see the 'Set library' link. If
'UseCirculationDesks' is on you will see a 'Set library and desk'.
19. Repeat step 9.

-Set library page-
20. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User1. You will
see a dropdown for 'Set library'. Make sure you can change your library
successfully.
21. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. You should
NOT see see a dropdown for 'Set library'.
22. Repeat step 7.
23. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. Now you
should see a dropdown for 'Set library'.

Signed-off-by: Andrew 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777

Jérémy Breuillard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777

--- Comment #7 from Jérémy Breuillard  ---
Created attachment 139960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139960&action=edit
screenshot 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777

--- Comment #6 from Jérémy Breuillard  ---
Created attachment 139959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139959&action=edit
screenshot 1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777

Jérémy Breuillard  changed:

   What|Removed |Added

 Attachment #128939|0   |1
is obsolete||

--- Comment #5 from Jérémy Breuillard  ---
Created attachment 139958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139958&action=edit
Bug 29777: Fields 580 are wrong displayed in summary column

The summary of Authority search results doesn't display informations about
field $580.
Those informations are separated by ;

To test:
1) Make sure to have at least one authority with subfield 580$a
2) Home > Authorities > Results from authority search
3) Notice the series of semicolons in the summary " ; ; ; ; " - (screenshot 1)
4) Usually for earch subfield 580$a that you fill up when you modify/create an
authority the summary should display 580$a (also $550, $560) followed by a
semicolons "myEntryElementForSubfield580$a ;
myOtherEntryElementForSubfield580$a ; "
5) Apply patch & refresh the browser
6) Notice the 580$a are now visible on summary and ends with a semicolon
(screenshot 2)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #64 from Nick Clemens  ---
Created attachment 139957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139957&action=edit
Bug 17170: Add the ability to create 'saved searches' for use as filters when
searching the catalog

This patch alters the code in the ES QueryBuilder. Reflecting
how things are handled in build_query_compat we clean the query,
but not the limits. In Zebra we simply recursivly call buildQuery,
but the ES query structure

This patchset adds a new ability to save searches on the staff client, and
display them in the results
page on staff or opac as a new filter.

New filters can be added from the results page after a search, and there is an
admin page for updating
deleting and renaming filters

There is a new permission to control management of these filters

New filters can be added that are not displayed along with facets, this allows
for building custom links
using these filters to keep URLs shorter

Due to bug 30528 testing in ES is recommended

To test:
 1 - Apply patches and update database and restart all
 2 - Enable new system preference 'SavedSearchFilters'
 3 - As superlibrarian perform a search in staff client, something broad like
'a'
 4 - Note new 'Save search as filter' link on results page
 5 - Click it, save search as new filter, check 'Staff client' visibility
 6 - Perform another search
 7 - Note the filter now appears above facets
 8 - Click to it filter results
 9 - Note results are limited by the new filter, and it is checked in the
facets
10 - Confirm click the [x] removes the filter
11 - Go to administration->search filters
12 - Confirm the filter appears
13 - Edit and mark as OPAC visible
14 - Test OPAC to ensure it shows and can be applied/removed
15 - Copy URL with filter applied
16 - In adminsitration mark filter as not visible on staff or opac
17 - Confirm link above still works
18 - Create a new staff with catalogue and search filters permission
19 - Ensure they can access/save filters
20 - Remove filter permission and ensure they cannot
21 - Disable system preference
22 - Confirm links to search filters page are removed from admin home and admin
sidebar
23 - Confirm filters do not appear on results and cannot be created
24 - Enable pref
25 - Create a filter
26 - From search filters page, click 'Edit search'
27 - Confirm you are taken to advanced search page letting you know which
filter you are editing
28 - Confirm you can change searhc options and save
29 - Confirm you can perform the search from this page

Signed-off-by: Michal Urban 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #63 from Nick Clemens  ---
Created attachment 139956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139956&action=edit
Bug 17170: (follow-up) Display search filters admin links when apprropriate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #62 from Nick Clemens  ---
Created attachment 139955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139955&action=edit
Bug 17170: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #61 from Nick Clemens  ---
Created attachment 139954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139954&action=edit
Bug 17170: Add admin page for filters and ability to edit/save existing filters

This patchset adds a new ability to save searches on the staff client, and
display them in the results
page on staff or opac as a new filter.

New filters can be added from the resuilts page after a search, and there is an
admin page for updating
deleting and renaming filters

There is a new permission to control management of these filters

New filters can be added that are not displayed along with facets, this allows
for building custom links
using these filters to keep URLs shorter

Due to bug 30528 testing in ES is recommended

To test:
 1 - Apply patches and update database and restart all
 2 - Enable new system preference 'SavedSearchFilters'
 3 - As superlibrarian perform a search in staff client, something broad like
'a'
 4 - Note new 'Save search as filter' link on results page
 5 - Click it, save search as new filter, check 'Staff client' visibility
 6 - Perform another search
 7 - Note the filter now appears above facets
 8 - Click to it filter results
 9 - Note results are limited by the new filter, and it is checked in the
facets
10 - Confirm click the [x] removes the filter
11 - Go to administration->search filters
12 - Confirm the filter appears
13 - Edit and mark as OPAC visible
14 - Test OPAC to ensure it shows and can be applied/removed
15 - Copy URL with filter applied
16 - In adminsitration mark filter as not visible on staff or opac
17 - Confirm link above still works
18 - Create a new staff with catalogue and search filters permission
19 - Ensure they can access/save filters
20 - Remove filter permission and ensure they cannot
21 - Disable system preference
22 - Confirm links to search filters page are removed from admin home and admin
sidebar
23 - Confirm filters do not appear on results and cannot be created
24 - Enable pref
25 - Create a filter
26 - From search filters page, click 'Edit search'
27 - Confirm you are taken to advanced search page letting you know which
filter you are editing
28 - Confirm you can change searhc options and save
29 - Confirm you can perform the search from this page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #60 from Nick Clemens  ---
Created attachment 139953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139953&action=edit
Bug 17170: Handle search filters in query builders

This patch updates the query building code to expand filters when searching
and pass them back as part of the cgi and descriptive search strings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #59 from Nick Clemens  ---
Created attachment 139952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139952&action=edit
Bug 17170: Add search filters to staff and opac interfaces

This patch displays the filters on the results pages with the facets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #57 from Nick Clemens  ---
Created attachment 139950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139950&action=edit
Bug 17170: Update schema for boolean

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #58 from Nick Clemens  ---
Created attachment 139951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139951&action=edit
Bug 17170: Add API route for SearchFilters

This adds the API routes and tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #56 from Nick Clemens  ---
Created attachment 139949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139949&action=edit
Bug 17170: DO NOT PUSH - Schema Updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Nick Clemens  changed:

   What|Removed |Added

 Attachment #138505|0   |1
is obsolete||
 Attachment #138506|0   |1
is obsolete||
 Attachment #138507|0   |1
is obsolete||
 Attachment #138508|0   |1
is obsolete||
 Attachment #138509|0   |1
is obsolete||
 Attachment #138510|0   |1
is obsolete||
 Attachment #138511|0   |1
is obsolete||
 Attachment #138512|0   |1
is obsolete||
 Attachment #138513|0   |1
is obsolete||
 Attachment #138514|0   |1
is obsolete||

--- Comment #55 from Nick Clemens  ---
Created attachment 139948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139948&action=edit
Bug 17170: DB Updates

This patch adds the new table, permission, and a syspref to enable the feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #44 from Marcel de Rooy  ---
Trivial: self SO. Just housekeeping.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59252|0   |1
is obsolete||
  Attachment #59253|0   |1
is obsolete||

--- Comment #43 from Marcel de Rooy  ---
Created attachment 139947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139947&action=edit
Bug 15545: Remove reqholdnotes from opac-reserve

This never really made it. So let's remove all traces.

Test plan:
Look at code changes and git grep reqholdnotes.
Bonus: Place a hold with/without hold notes.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off
   Patch complexity|Small patch |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #61 from Andrew Fuerste-Henry  ---
Good catch on that missing space! And I agree about the use of quotes around
pronouns in Contact Information -- it feels sort of off and non-standard. Using
parentheses would make more sense to me. But I like it in the Contact
Information section generally; that's where I'd expect to find information
about how to address someone.

(As an aside, I see we're similarly putting Other Name in parentheses some
places and quotes others. I feel like for American English usage that should be
quotes all over, but that at least another bug and probably a larger linguistic
conversation.)

I don't know the full extent of the change Katrin suggests to not include
pronouns in koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc. I like
the general idea, though, of only including pronouns in a few places in the
patron record, not necessarily pushing them out to everywhere the patron name
appears.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Component|Hold requests   |Architecture, internals,
   ||and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Optionally make hold notes  |Remove remainders of
   |required when placing a |unfinished reqholdnotes
   |hold|functionality

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #42 from Marcel de Rooy  ---
Gonna remove the remainders of this bug report here now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #51832|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #139945|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 139946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139946&action=edit
Bug 31482: Label creator does not call item_barcode_transform plugin hook

The label creator can accept a list of either itemnumbers or item barcodes.
In the case that the list of composed of barcodes, those barcodes should be
passed though the item_barcode_transform plugin hook before the lookup is
performed.

Test Plan:
1) Apply this patch
2) Download and install the Barcode Transformer plugin
  
https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/
3) Go to the plugin configuration page, set the configuration to the example
configuration from the same page
4) On the "New label batch" page of the Label creator,,
   type in some valid barcodes, but prefix them with X and postfix them with Y,
e.g. X123456Y
5) Submit the form
6) Note the items are added to the label batch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||31482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482
[Bug 31482] Label creator does not call item_barcode_transform plugin hook
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||26351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351
[Bug 26351] Add plugin hooks to transform item barcodes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

--- Comment #1 from Kyle M Hall  ---
Created attachment 139945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139945&action=edit
Bug 31482i: Label creator does not call item_barcode_transform plugin hook

The label creator can accept a list of either itemnumbers or item barcodes.
In the case that the list of composed of barcodes, those barcodes should be
passed though the item_barcode_transform plugin hook before the lookup is
performed.

Test Plan:
1) Apply this patch
2) Download and install the Barcode Transformer plugin
  
https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/
3) Go to the plugin configuration page, set the configuration to the example
configuration from the same page
4) On the "New label batch" page of the Label creator,,
   type in some valid barcodes, but prefix them with X and postfix them with Y,
e.g. X123456Y
5) Submit the form
6) Note the items are added to the label batch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31482] Label creator does not call item_barcode_transform plugin hook

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31482] New: Label creator does not call item_barcode_transform plugin hook

2022-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Bug ID: 31482
   Summary: Label creator does not call item_barcode_transform
plugin hook
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The label creator can accept a list of either itemnumbers or item barcodes. In
the case that the list of composed of barcodes, those barcodes should be passed
though the item_barcode_transform plugin hook before the lookup is performed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >