[Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects instead of raw SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Joonas Kylmälä changed: What|Removed |Added Summary|C4::Tags should use |C4::Tags should use |Koha::Tags objects |Koha::Tags objects instead ||of raw SQL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 --- Comment #5 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #4) > Please let's go directly with the proper solution, number 1 or 2 that > Jonathan suggested? Reviewing, merging and reverting this and then going for > solution 1 or 2 is extra work. I personally prefer number 1, the user might not care about the description at all so having to fill fields that are not useful is not something we should force the users to do. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||joonas.kylm...@iki.fi --- Comment #4 from Joonas Kylmälä --- Please let's go directly with the proper solution, number 1 or 2 that Jonathan suggested? Reviewing, merging and reverting this and then going for solution 1 or 2 is extra work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Severity|minor |normal Assignee|koha-b...@lists.koha-commun |joonas.kylm...@iki.fi |ity.org | --- Comment #6 from Joonas Kylmälä --- Added a couple patches that make adding a new numbering pattern usable, I don't understand how it can have been, apparently already since bug 7688 / year 2013, this broken and nobody has fixed this. Further improvement can be done, like I don't think description should be mandatory but will leave this like this to be easily reviewable patch so we can make this feature usable ASAP. Ready for sign-off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 --- Comment #5 from Joonas Kylmälä --- Created attachment 140197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140197=edit Bug 28012: Creating numbering pattern: mark mandatory fields required If any of these fields were missing, notably the Numbering formula then saving the new numbering pattern silently failed, it didn't give any error but it didn't save any new pattern either. To test: 1) After applying this patch make sure all the 3 fields must be filled in /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new page and it cannot be saved without those. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 --- Comment #4 from Joonas Kylmälä --- Created attachment 140196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140196=edit Bug 28012: Use definedness test instead of bool when checking whether to null fields Saving a new numbering pattern didn't work without having to fill all the fields, even those that are not mandatory. To test: 1) Go to /cgi-bin/koha/serials/subscription-numberpatterns.pl and try creating a new pattern, notice that only Name and Description are mandatory after applying this patch 2) Make sure editing existing numbering patterns still works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Joonas Kylmälä changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31488] "You have checked out too many items"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 Nick Clemens changed: What|Removed |Added Attachment #140149|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 140195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140195=edit Bug 31488: Update Max checkout text This changes text from "you have checked out too many items" to "You have reached the maximum limit of items checked out". Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31488] "You have checked out too many items"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29608] Editing numbering patterns does require full serials permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608 Nick Clemens changed: What|Removed |Added Attachment #140111|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 140194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140194=edit Bug 29608: Made so doesn't require full permission Made so the numbering sequence does not need to require full permission. 1. Edit number patterns a confirm you don't need full permission Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29608] Editing numbering patterns does require full serials permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31009] Claims list take too much times (timeout when you have so many claims) on serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31009 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi --- Comment #3 from Joonas Kylmälä --- I'm thinking a new subroutine for doing the calculation would be in place here rather than making GetSuppliersWithLateIssues more complex, and probably slightly slower for all the other users of this function. It would be good to have these as Koha objects to make creating the queries easier... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Emmanuel Bétemps changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #18 from Emmanuel Bétemps --- (In reply to Shi Yao Wang from comment #16) > apply the patch at step 10: > >10. Apply the patch, translate again and refresh the page > > and do step 1.1 again to refresh translations (that's what I meant by > "translate again" here). my bad ! I didn't understand I had to install translation twice (once before and once after installing the patch) 'translate again' meant to me 'change the language of the interface' thanks for your patience & explanations :) Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30232] Acquisition logged in user performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|Needs Signoff |Failed QA --- Comment #8 from Joonas Kylmälä --- I think it would be better if you change those C4/Budgets.pm functions accept directly a Koha::Patron, reading the code there is now a lot of duplication regarding the unblessing of the patron. Haven't checked all cases but if you check the code for CanUserUseBudget it's perfectly fine to just use the Koha::Patron methods, just remove the curly braces from the current code basically to make it work. I'd like to mark this as FQA if you don't mind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 ByWater Sandboxes changed: What|Removed |Added Attachment #139718|0 |1 is obsolete|| --- Comment #17 from ByWater Sandboxes --- Created attachment 140193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140193=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. in commandline: `cd misc/translator/; ./translate install xx-XX` 2. Check the box of the language in the 'language' system preference and save 3. Refresh and you should be able to choose languages 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch, translate again and refresh the page 11. Do step 8-9 again and notice it now behaves as it should Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #17 from Joonas Kylmälä --- Running prove t/db_dependent/Members/IssueSlip.t gives the following warning: t/db_dependent/Members/IssueSlip.t .. DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider using ->all() instead at /kohadevbox/koha/Koha/Objects.pm line 312 Can you also please clone $tomorrow and $yesterday from $today, and subtract/add one day? This prevents the race condition that could happen in the unit tests when the time is 23:59. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
