[Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Summary|It should be possible to|It should be possible to |cancel a request sent to a |cancel an ILL request sent |partner |to a partner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi --- Comment #6 from Joonas Kylmälä --- Looks good to me but I want one more sign-off from the QA team since this change concerns authorization. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 --- Comment #5 from Joonas Kylmälä --- Created attachment 140203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140203=edit Bug 31389: (QA follow-up) Correct test message The test in question concerns non-superlibrarian staff users. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 Joonas Kylmälä changed: What|Removed |Added Attachment #139398|0 |1 is obsolete|| --- Comment #4 from Joonas Kylmälä --- Created attachment 140202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140202=edit Bug 31389: Calculate user permissions in separate function This patch refactors the setting of user permissions for templates into a new function, which can be easily unit tested and reduces the amount of code in C4::Auth::get_template_and_user(). It also aids in the re-usability of permission checking code. Test plan: 0) Apply patch and koha-plack --restart kohadev 1) prove t/Koha/Auth/Permissions.t 2) As koha superlibrarian, go to http://localhost:8081/cgi-bin/koha/tools/tools-home.pl 3) Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl 4) Create new test user with "Staff access..." and "Remaining circulation permissions" 5) Logout of koha superlibrarian 6) Login as test user 7) Note you can only see a limited view of the staff interface (i.e. no administration, no tools, no reports, etc.) Signed-off-by: Kyle M Hall Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Joonas Kylmälä changed: What|Removed |Added Attachment #140102|0 |1 is obsolete|| --- Comment #6 from Joonas Kylmälä --- Created attachment 140201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140201=edit Bug 31364: Check length of the multiple syspref array instead whether it is null The multiple systempreferences are always defined as an empty array at the minimum, so in order to determine whether we need to remove all the selections from the systempreference we should check whether the array is empty and not whether the array doesn't exist. To test: 1) Set at least 1 value for OPACHoldsIfAvailableAtPickupExceptions 2) Remove all the values for OPACHoldsIfAvailableAtPickupExceptions and notice you get the message "Nothing to save" 3) Apply patch and repeat, removing all the values should work now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Failed QA CC||joonas.kylm...@iki.fi --- Comment #5 from Joonas Kylmälä --- Adds a comma in the end of the syspref list due to it sending an empty sysref value in addition to filled ones in the query string: > MariaDB [koha_kohadev]> select * from systempreferences where variable = > "OPACHoldsIfAvailableAtPickupExceptions"\G > *** 1. row *** >variable: OPACHoldsIfAvailableAtPickupExceptions > value: B,HB, > options: > explanation: List the patron categories not affected by > OPACHoldsIfAvailableAtPickup if off >type: Free Since the sysref object value is an array we can just check instead whether the array is empty. Will send a patch shortly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #31 from Joonas Kylmälä --- (In reply to Victor Grousset/tuxayo from comment #28) > (In reply to Katrin Fischer from comment #19) > > Applied the patches, restart_all: > > > > * The page loads ok, table is empty in my installation > > * I check the "Only include jobs started in the last hour" checkbox: > > Error: Something went wrong when loading the table. > > 500: Internal Server Error > > > > In my background_jobs table I have several entries, one for > > batch_item_record_modification and several update_elastic_index. All are > > finished. > > I don't get the issue. Tested with empty db table and after checking in an > item of a record on hold I get a Holds queue update and Update Elasticsearch > index entry. > > (why is there an ES entry update?) > > The change here since your test doesn't look like to be able to fix that. > And there were no changes on bug 30462. Unable to reproduce here as well, so maybe fixed in the dependency or there was some configuration issue in the setup katrin used, although if so, then I think we have a bug somewhere. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Failed QA CC||joonas.kylm...@iki.fi --- Comment #30 from Joonas Kylmälä --- The table filter "Type" doesn't work, if you select something else than the empty filter you get no results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31519] Unused template parameters in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Joonas Kylmälä changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |joonas.kylm...@iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31519] Unused template parameters in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 --- Comment #2 from Joonas Kylmälä --- Created attachment 140200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140200=edit Bug 31519: Move preference fetching directly to be done in the template Since we are not in a loop or using this multiple times it's simple to do it this way, helps with changing the template code in the future too since if we want to remove this syspref variable we know it is only used in this one particular place. To test: 1) Grep for reserve_in_future and make sure there are no matches after applying this patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31519] Unused template parameters in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 --- Comment #1 from Joonas Kylmälä --- Created attachment 140199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140199=edit Bug 31519: Remove unused SuspendHoldsIntranet and AutoResumeSuspendedHolds variables If you grep koha-tmpl/intranet-tmpl/prog/en for those you will see there are no references for those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31519] Unused template parameters in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Joonas Kylmälä changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31519] New: Unused template parameters in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Bug ID: 31519 Summary: Unused template parameters in request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@iki.fi QA Contact: testo...@bugs.koha-community.org reserve/request.pl sets SuspendHoldsIntranet and AutoResumeSuspendedHolds template parameters which are not used in any templates or template includes. Those should be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31518] Hidden items count not displayed on hold request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Joonas Kylmälä changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31518] Hidden items count not displayed on hold request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 --- Comment #1 from Joonas Kylmälä --- Created attachment 140198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140198=edit Bug 31518: Fix syntax error on request.tt that prevents showing hidden item count The variable set by request.pl doesn't have biblio prefix, it is just hiddencount. To test: 1) Log in with a staff member account that has "Lost items in staff interface" setting set to "Hidden by default" in the patron category settings 2) Add a lost item to biblio 3) Go place a hold on staff interface (request.pl) notice the broken link on the request page: "Show all items ( hidden)" 4) After applying the patch it should read "Show all items (1 hidden)" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31518] Hidden items count not displayed on hold request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Joonas Kylmälä changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31518] New: Hidden items count not displayed on hold request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Bug ID: 31518 Summary: Hidden items count not displayed on hold request page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: joonas.kylm...@iki.fi Reporter: joonas.kylm...@iki.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com If I go place a hold on staff interface (request.pl) and the staff member logged in has "Lost items in staff interface" setting set to "Hidden by default" in the patron category settings and a biblio has a lost item then we get on the page the following link: > Show all items ( hidden) The lost/hidden item count is missing due to a syntax error, it should read: > Show all items (1 hidden) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
