[Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Attachment #139248|0   |1
is obsolete||

--- Comment #6 from sandbo...@biblibre.com  ---
Created attachment 140218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140218&action=edit
Bug 31371: Value builder for field 283

On page cataloging some plugins were added for subfields $2 and $a from field
$283

Test plan:
1)Go to Home > Cataloging > New record
2)Section 2 - field 283 : it contains subfields $2, $6, $8 & $a
3)Inputs are writable but notice that no plugins are suggested
4)Apply patch and repeat 1) to 3)
5)Values builders plugins are available for $2 and $a

Signed-off-by: Thibault Keromnès 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons.

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501

Liny Varghese  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Liny Varghese  ---
On upgrade, this statement was not executed(don't know the reason). I have done
it manually now and it seems working now.

 ALTER TABLE `borrower_attributes` ADD `id` int(11) NOT NULL AUTO_INCREMENT
PRIMARY KEY FIRST

Thank you all for your support

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732

Victor Grousset/tuxayo  changed:

   What|Removed |Added

URL||https://gitlab.com/tuxayo/K
   ||oha/-/tree/hold-rules-check
   ||er-master/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout)

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28290] Record matching rules with no subfields cause ISE

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50 filter

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 CC|vic...@tuxayo.net   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50 filter

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Attachment #139014|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons.

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501

--- Comment #11 from aeisj...@gmail.com ---
I was able to fix mine by installing libmojolicious-plugin-openapi-perl deb
package
I just run this script and everything works fine now, thanks...

sudo apt-get install libmojolicious-plugin-openapi-perl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons.

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501

--- Comment #10 from aeisj...@gmail.com ---
This is what I found at the plack-error.log

Error while loading /etc/koha/plack.psgi: Can't load application from file
"/usr/share/koha/api/v1/app.pl": Can't locate
JSON/Validator/Schema/OpenAPIv2.pm in @INC (you may need to install the
JSON::Validator::Schema::OpenAPIv2 module) (@INC contains: /usr/share/koha/lib
/usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0
/usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/var/lib/koha/cvsumain/plugins) at /usr/share/koha/lib/Koha/REST/V1.pm line 25.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #25 from Aleisha Amohia  ---
Have rebased and addressed:

(In reply to David Nind from comment #23)
> I've tested, but haven't signed off.
> 

> 3. For the staff interface and with the CSS to hide the text description:
>. catalogue/detail.tt: see note for staff interface and
> catalogue/detail.tt - can't hide text description for 'Itemtype' shown on
> the details page before the holdings tab
> 

Fixed this

> 4. For the OPAC, I'm not sure how to test opac-results-grouped.tt: there is
> no opac-results-grouped.tt file, item type icon and text show for normal
> OPAC search results when OPACnoItemTypeImages system preference is set to
> 'Show', with OPAC CSS to hide no text description is shown in search results
> (but icon is).
>

From an old version of Koha, have removed this from the test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #137760|0   |1
is obsolete||

--- Comment #24 from Aleisha Amohia  ---
Created attachment 140217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140217&action=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-shelves.tt
 - opac-user.tt

Refer to David Nind's test notes from Comment 23 for a more detailed
plan for acessing these pages.

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31514] OPAC user interface should show all Course Reserves lists - not just active ones

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31514

--- Comment #1 from Katrin Fischer  ---
I think a lot of libraries like the fact, that they can prepare the course
reserves behind the scenes and that they are not visible to the patrons unless
active. This should probably be a setting/option and not a general change.

Could it be a compromise to make the courses visible to the added instructors?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

--- Comment #55 from Aleisha Amohia  ---
(In reply to Felicity Brown from comment #51)
> Does this apply to setting a status to "missing" as well as lost?

The short answer is Yes.

The long answer: this uses items.itemlost value in the database to determine if
the item is lost. By default, this is usually linked to the LOST authorised
value. So, any selected value of LOST (which might be Lost, or Missing, or Long
Overdue) will flag items.itemlost in the database as true.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout)

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #125439|0   |1
is obsolete||

--- Comment #54 from Aleisha Amohia  ---
Created attachment 140216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140216&action=edit
Bug 20844: (follow-up) Get working with transfers

Test:

1) Change branch to Branch B
2) Place a biblio-level hold at Branch B
3) Change branch to Branch A
4) Check in item at Branch A and set waiting and trigger transfer
5) Go to edit item and set item as lost
6) Check borrower's notices tab and confirm the lost_waiting_hold notice
was enqueued
7) Follow test plan again with item-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #125438|0   |1
is obsolete||

--- Comment #53 from Aleisha Amohia  ---
Created attachment 140215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140215&action=edit
Bug 20844: (follow-up) SendLostHoldNotices

This patch adds a new syspref SendLostHoldNotices

Test:
1) Update database and restart memcached
2) Enable the SendLostHoldNotices system preference
3) Place a hold on an item
4) Check in the item and set the hold to waiting
5) Go to edit the item and set an item lost status
6) Check the borrower's notices and confirm the notice has been enqueued
7) Confirm the notice is not sent twice when reverting or cancelling the
hold
8) Confirm notice enqueues as expected for a bib-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #125437|0   |1
is obsolete||

--- Comment #52 from Aleisha Amohia  ---
Created attachment 140214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140214&action=edit
Bug 20844: Revert or cancel lost holds

This patch introduces the RevertLostBibLevelHolds syspref. When an item
is marked as lost, if there is a bib-level hold on it waiting, the hold
is reverted. If there is an item-level hold on it waiting, there is an
alert box asking if the library would like to revert the hold or cancel
it.

Test:

1) Update database and restart memcached/plack
2) Place a hold on Biblio A
3) Check in Item A from Biblio A and set the hold as waiting
4) Edit Item A and give it a lost status (952$1, you may need to edit
your MARC frameworks to have this visible in the Editor)
5) Look at your hold. Notice it is still waiting.
6) Go to Administration -> System preferences. Find the
RevertLostBibLevelHolds system preference and enable it.
7) Cancel your hold and remove Item A's lost status. Place another biblio-level
hold on the same biblio
8) Check in Item A from Biblio A and set the hold as waiting
9) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
10) Edit Item A and give it a lost status
11) Once the page reloads, go to view your hold. It should no longer be
waiting and have no item allocated.
12) Cancel your hold and remove Item A's lost status. Place an item-level hold
on Item A
13) Check in Item A and set the hold as waiting
14) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
15) Give Item A a lost status and save changes
16) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
17) Confirm your hold is no longer waiting, but the item is still
allocated
18) Remove Item A's lost status
19) Check in Item A and set the hold as waiting
20) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
21) Give Item A a lost status and save changes
22) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
23) Confirm the hold is now cancelled
24) Remove Item A's lost status
25) Place an item-level hold on Item A
26) Check in Item A and set the hold as waiting
27) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
28) Give Item A a lost status and save changes
29) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
30) Confirm your hold is no longer waiting, but the item is still
allocated
31) Remove Item A's lost status
32) Check in Item A and set the hold as waiting
33) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
34) Give Item A a lost status and save changes
35) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
36) Confirm the hold is now cancelled
37) Remove Item A's lost status
38) Place an item-level hold on Item A. Check in Item A and set the hold
as waiting
39) Place an item-level hold on Item B (same biblio) for another borrower.
Check in
Item B and set the hold as waiting.
40) Give both Items A and B lost statuses.
41) Confirm that both Items are included in the alert box on page when
editing items (cataloguing/additem.pl)
42) Confirm that both Items have individual alert boxes on the Items tab
(catalogue/moredetail.pl)
43) Confirm tests pass t/db_dependent/Reserves.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31477] Switch icon for inventory

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477

--- Comment #2 from Katrin Fischer  ---
That would explain, why I couldn't make it work when I tried... What about
list-check - that should be in 2.0?

https://fontawesome.com/icons/list-check?s=solid&f=classic

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31253] Item search in staff interface should call barcodedecode if the search index is a barcode

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31391] Staff-side recalls

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Aleisha Amohia  changed:

   What|Removed |Added

 CC||da...@davidnind.com,
   ||fridolin.som...@biblibre.co
   ||m,
   ||jonathan.druart+koha@gmail.
   ||com,
   ||katrin.fisc...@bsz-bw.de,
   ||m.de.r...@rijksmuseum.nl,
   ||tomasco...@gmail.com,
   ||vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||joonas.kylm...@iki.fi

--- Comment #5 from Joonas Kylmälä  ---
Needs another rebase :|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #115311|0   |1
is obsolete||

--- Comment #8 from Joonas Kylmälä  ---
Created attachment 140213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140213&action=edit
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

The overdue and pre-overdue cron scripts are not skipping the generation of
phone notices. This causes many phone notices to be created that will always be
left at 'pending' as the Talking Tech outbound script creates its own phone
notices and puts them in the message queue.

Test Plan:
1) Enable Talking Tech
2) Enable predue and overdue notice phone transports for a patron
3) Generate overdues and predues, notice phone notices are generated
4) Apply the patch
5) Repeat steps 2-3
6) Note phone notices are not generated

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@iki.fi
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23342] Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23342

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||joonas.kylm...@iki.fi

--- Comment #3 from Joonas Kylmälä  ---
Doesn't apply anymore and would have to be split into separate patches for each
individual change described in the patch message as this patch combines
multiple changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons.

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501

--- Comment #9 from Joonas Kylmälä  ---
 (In reply to aeisjean from comment #7)
> Good day, I am having the same problem. I attached screenshot in developers
> mode.

Since the failure is in the API request, could you check on the server side
plack-api-error.log and plack-error.log files? I think the first one should
contain the error message but if not check the other one too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||joonas.kylm...@iki.fi

--- Comment #9 from Joonas Kylmälä  ---
In the second patch the file
koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt has undef instead of
null.

Not sure I agree with the last patch, it is unnecessary information exposed to
the programmer, since there is a default, no settings, then I don't see why it
would have to be marked explictly, we don't supply the other KohaTable
add_filters parameter either. I'd suggest removing the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@iki.fi

--- Comment #11 from Joonas Kylmälä  ---
Mason, I think the test patch attached doesn't make sense for other timezones
as only in Brazil in 2019 the day light saving time was cancelled. Was the
patch made so that ubuntu 18 test failure would be prevented somehow?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31521] Allow to configure behaviour when checking in a reserved item at SCO

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31521] Allow to configure behaviour when checking in a reserved item at SCO

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521

--- Comment #1 from Julian Maurice  ---
Created attachment 140212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140212&action=edit
Bug 31521: Configure behaviour when checking in a reserved item at SCO

This patch adds a system preference (SCOCheckinIfReservedBehaviour)
which allow to control the behaviour of SCO checkin when the returned
item is reserved:
- allow checkin (current behaviour)
- allow checkin and show a message
- forbid checkin and show a message

The message is configurable is another system preference
(SCOCheckinIfReservedMessage)

Test plan:
1. Apply patch, run updatedatabase.pl and restart koha
2. Enable WebBasedSelfCheck and SCOAllowCheckin
3. (Staff) Set SCOCheckinIfReservedBehaviour to "Forbid checkin & show
   message"
4. (Staff) Write some text in SCOCheckinIfReservedMessage
5. (Staff) Checkout an item I to patron A
6. (Staff) Place a hold on item I for patron B
7. (SCO) Log in to SCO with patron A
8. (SCO) Try to return item I
   The configured message should be displayed and item I should still be
   checked out
9. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin & show message"
10. (SCO) Try to return item I
The configured message should be displayed and item I should have
been checked in
11. (Staff) Checkout item I to patron A again
12. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin"
13. (SCO) Try to return item I
The configured message should NOT be displayed and item I should
have been checked in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31521] New: Allow to configure behaviour when checking in a reserved item at SCO

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521

Bug ID: 31521
   Summary: Allow to configure behaviour when checking in a
reserved item at SCO
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Self checkout
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Some users want to display a custom message to patrons self returning items
that are on hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #79 from Marcel de Rooy  ---
Will hopefully finish up tomorrow.
Nick, could you have another look later this week?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435

--- Comment #8 from Martin Renvoize  ---
OK.. so whilst trying to come up with a test plan I spotted a few
inconsistencies in how we're instantiating our kohaTables and KohaTables.

Instead of not passing anything, or passing an explicit 'null', we were passing
empty arrays and empty hashrefs in some places.. my follow-ups correct that for
consistency.

In short, the tables affected by the two follow-up patches will all have
displayed the 'Configure' link even when there's nothing to configure... that's
the test plan ;P

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435

--- Comment #7 from Martin Renvoize  ---
Created attachment 140211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140211&action=edit
Bug 31435: (follow-up) Make KohaTable calls consistent

Our calls to instantiate a KohaTable from were inconsistent in how
they pass table_settings where no table_settings exist.

This patch replaces empty arrays and empty hashrefs with a consistent
'null' being passed to ake it clear we don't have any settings to pass
yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435

--- Comment #6 from Martin Renvoize  ---
Created attachment 140210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140210&action=edit
Bug 31435: (follow-up) Make kohaTable calls consistent

Our calls to instantiate a kohaTable from JS were inconsistent in how
they pass table_settings where no table_settings exist.

This patch replaces empty arrays and empty hashrefs with a consistent
'null' being passed to ake it clear we don't have any settings to pass
yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #139570|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 140209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140209&action=edit
Bug 31435: Tie 'Configure' to table_settings

This patch adds a check for table_settings to prevent the display of
'Configure this table' when table settings are not passed to the
datatable wrapper.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #78 from Marcel de Rooy  ---
Created attachment 140208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140208&action=edit
Bug 27421: (QA follow-up) Polishing the backgroundjob modules

StageMARCForImport:
- Rollback in catch
- Setting progress, size or status after BatchStageMarcRecords
  in both try and catch block

ImportCommitBatch:
- Move setting size back to enqueue moment
- Rollback in catch
- Setting progress, size or status after BatchStageMarcRecords
  in both try and catch block

ImportRevertBatch:
- Move setting size back to enqueue moment
- Adding transaction/rollback to module since import routine
  does not support it. Could be moved later.
- Setting progress, size or status after BatchStageMarcRecords
  in both try and catch block

Test plan:
Run t/db_dependent/Koha/BackgroundJobs/StageMARCForImport.t
Test staging file
Bonus: Put a die statement in BatchStageMarcRecords.
Test importing batch
Bonus: Include some records with an invalid library code; this will
trigger an FK exception.
Test reverting batch.
Bonus: Put a die in BatchRevertRecords.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #140206|0   |1
is obsolete||

--- Comment #77 from Marcel de Rooy  ---
Created attachment 140207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140207&action=edit
Bug 27421: (QA follow-up) BatchCommitImportRecords needs param for skipping
commits

When you submit a background jobs, and it fails, you do not expect
partial results in the database.
Note that when the Background feature would support a partially
completed status, things might change again.

Note that the >0 test was superfluous if you check for ^\d+$.

Test plan:
Run t/db_dependent/Koha/BackgroundJobs/StageMARCForImport.t
Note: This serves to verify that it still runs as expected.
We will still test the new parameter further on.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #76 from Marcel de Rooy  ---
Created attachment 140206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140206&action=edit
Bug 27421: (QA follow-up) BatchCommitImportRecords needs param for skipping
commits

When you submit a background jobs, and it fails, you do not expect
partial results in the database.
Note that when the Background feature would support a partially
completed status, things might change again.

Test plan:
Run t/db_dependent/Koha/BackgroundJobs/StageMARCForImport.t
Note: This serves to verify that it still runs as expected.
We will still test the new parameter further on.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #139797|0   |1
is obsolete||

--- Comment #75 from Marcel de Rooy  ---
Created attachment 140205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140205&action=edit
Bug 27421: (QA follow-up) Sub finish should respect failed status too

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #74 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #73)
> Hmm. Transaction stuff too in MARCImportCommitBatch..
> There is no rollback included as if you would have called txn_do !

I am wondering if we should still commit after 50 records or so. If the job
fails, I do not expect it to commit any records at all now. Especially since it
runs in a background worker now.
My idea now: parameter that controls intermediate commits !

Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31496] Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco.

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496

--- Comment #4 from Lari Strand  ---
(In reply to Lucas Gass from comment #3)
> Lari,
> 
> IS the idea here to print the branch specific slip of the AutoSelfCheck user?

The SCO uses the default issue slip in my case. Of course same applies for
branch specific slips too. Without the patch the code is sending the logged in
patron's branch to the function that generates the slip.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890

--- Comment #4 from Martin Renvoize  ---
(In reply to Owen Leonard from comment #3)
> -[% ELSIF query_type == 'status' %]
> +[% ELSIF query_type == 'illview' %]
> 
> Is the "status" query_type not used for anything?

It's a good question.. as far as I can tell from the controller query_type will
never be returned with a value of 'status'.  I tried digging through the git
logs to see when it was introduced or changed, but it appears to have never
been returned going as far back as the original introduction of ILL into core
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #73 from Marcel de Rooy  ---
Hmm. Transaction stuff too in MARCImportCommitBatch..
There is no rollback included as if you would have called txn_do !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777

Julian Maurice  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com
   |ity.org |
 CC||julian.maur...@biblibre.com
 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #191 from Martin Renvoize  ---
PTFS-E have a group of us scheduled to go through the new UI this Friday (9th
September).. hopefully, it'll yield lots of good feedback and help drive this
through.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #190 from Martin Renvoize  ---
(In reply to Paul Poulain from comment #188)
> (In reply to Owen Leonard from comment #187)
> > Was it agreed upon to not use the tab design from the original work?
> > 
> > What we have now: https://snipboard.io/A9SOz7.jpg
> > 
> > What it would look like with the original style:
> > https://snipboard.io/2FJSnl.jpg
> 
> +1000 for the "now" version !

I raised a github issue for this.. I think there's more to it than just the tab
based nav.. the card layout isn't as the mock-ups suggested either and I think
that lack of cards causes some of the difficulties Jonathan D and I raised
regarding the right aligned toolbar buttons and lack of toolbar background
making the buttons lose natural focus.

https://github.com/jajm/koha-staff-interface-redesign/issues/17 and
https://github.com/jajm/koha-staff-interface-redesign/issues/8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #189 from Martin Renvoize  ---
As a middle ground for the search bar changes stuff as it appears to be the
most contentious part..  I re-read the comments on the Mock-ups and Myka's
comments seems really relevant.

> Can having the persistent search at the top throughout the site continue to 
> be an option (toggle on/off) in admin settings?

We could fairly easily get the best of both worlds as an interim option.. with
a system preference that either embeds the search stuff in the top header OR
uses Owens separate bar as the alternate option... Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643

--- Comment #16 from Marcel de Rooy  ---
Any news here?

Having max_holds on various levels in circ rules and maxreserves as the general
cap is quite confusing especially since the latter is a pref.
If seems to me that we can do without it. You can specify one general max_holds
without a patron category serving as 'maxreserves' or define multiple maximums
per patron category (probably more useful for most).

I think that changing the 'for all libraries' to something like 'Default rules
(may be overridden by rules for specific libaries)' would be good.

Side note: max_holds in the staff view under 20.11 works a bit silently. I set
it to 10, select 20 records. maxreserves is higher. Without warning I can place
holds (in one action) but only 10 are actually placed.
Same under OPAC actually: rest is ignored.
Could be more user friendly?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29393] Ability to send emails from patron details page

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393

Axelle Aix-Marseille Université  changed:

   What|Removed |Added

 CC||axelle.clari...@univ-amu.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31520] New: Only log ILL changes that are actual changes

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31520

Bug ID: 31520
   Summary: Only log ILL changes that are actual changes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no

"Bug 20750 - Allow timestamped auditing of ILL request events" added the
ability to log status changes to ILL requests, in the action_logs table, with
action = 'STATUS_CHANGE'. 

I have an ILL setup where a remote API is checked for data every 3 minutes, and
requests are updated. With Illlog = on, this leads to 480 action_logs entries
per 24-hour period. I have a test setup where the amount of logs was causing
the detailed display of illrequests to time out, because there were so many log
entries to fetch. 

This could be improved if we only logged actual status changes. Today there is
a log entry even if the status is not changed: 

| ILL| STATUS_CHANGE |
{"status_after":"IN_LEV","log_origin":"core","status_before":"IN_LEV"} |
| ILL| STATUS_CHANGE |
{"status_after":"IN_LEV","status_before":"IN_LEV","log_origin":"core"} |
| ILL| STATUS_CHANGE |
{"status_before":"IN_LEV","status_after":"IN_LEV","log_origin":"core"} |
| ILL| STATUS_CHANGE |
{"log_origin":"core","status_before":"IN_LEV","status_after":"IN_LEV"} |
| ILL| STATUS_CHANGE |
{"status_before":"IN_LEV","status_after":"IN_LEV","log_origin":"core"} |
| ILL| STATUS_CHANGE |
{"status_after":"IN_LEV","log_origin":"core","status_before":"IN_LEV"} |
++---++

We could compare status_before and status_after, and only log if they differ.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371

Thibault Keromnès  changed:

   What|Removed |Added

 CC||thibault.keromnes@univ-pari
   ||s8.fr
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules

2022-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/