[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

--- Comment #14 from Marcel de Rooy  ---
(In reply to David Cook from comment #12)
> I've signed off Martin's patch, added my own to fix the issue Frido found,
> and moved back to Needs Signoff.

I will consider this patch as Signed off and QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #13 from Marcel de Rooy  ---
(In reply to David Cook from comment #7)

> It's fine for us to "exit" because CGI::Compile (used in
> Plack::App::WrapCGI) redefines "exit" for us automatically.
> 
> Since we only seem to use C4::Auth::safe_exit in a CGI context, we don't
> actually need this PSGI detection at all here.

These comments should have been included in the commit message. I will adjust
it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #139117|0   |1
is obsolete||

--- Comment #14 from Marcel de Rooy  ---
Created attachment 140688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140688&action=edit
Bug 29554: Do not hide display of itemtypes on neworderempty

Hiding the list may lead to biblioitems.itemtype being NULL.
We do not want that, since 942$c is mandatory.

Test plan:
Create basket and set 'create items when' to receiving or
cataloging.
Create order from new empty record.
Check biblioitems.itemtype of created biblio.
Without this patch, it would have been NULL like this:
select biblionumber,title from biblio;
|7 | Test 3|
select biblionumber,itemtype from biblioitems;
|7 | NULL |

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #13 from Marcel de Rooy  ---
Sorry David, that was a dumb omission related to the change of ->search to
scalar context. We need ->as_list currently.
I updated the test plan to include choosing receiving/cataloging to make more
clear what this patch is about.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #281 from Julian Maurice  ---
Created attachment 140687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140687&action=edit
Bug 30952: (follow-up) Proposed reworking of catalog header menu link

Issue #46

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31465] 21.11 manual says it is 20.05 manual

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465

--- Comment #3 from Martin Renvoize  ---
It'll be the pipeline task... I'll fix it today. I didn't actually think we'd
branched yet as it also says 22.05 is the Development manual too.

I

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #33 from David Cook  ---
It looks like this ended up suffering from scope creep?

I had someone raise this issue locally the other day, so it would be
interesting to see how Koha wants to move forward.

For now, locally we're going to update the 490 data, so that the 830 shows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #27 from Victor Grousset/tuxayo  ---
Ok, will backport before next release :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31538] Crash on item tab of a record with UNIMARC

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31538

--- Comment #6 from Victor Grousset/tuxayo  ---
Thanks for the analysis :)

> unimarc default data

Is that just about sample data that is inserted directly via SQL? Or is that
something that valid UI usage can produce?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31465] 21.11 manual says it is 20.05 manual

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465

--- Comment #2 from Lucas Gass  ---
Some more info here:

"Even though it says 20.05 it is actually 21.11 and if I do an additional
search where it says Koha Manual 21.05, the search is in 21.11 and the manual
number depicted in the green background switches to 21.11."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558

Lucas Gass  changed:

   What|Removed |Added

 Attachment #140609|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 140686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140686&action=edit
Bug 31558: Fix image drag and drop in TinyMCE

Bug 26949 upgraded JS lib TinyMCE to 5.9.2

This version has a known issue on images drag and drop :
https://stackoverflow.com/questions/64782955/tinymce-inline-drag-and-drop-image-upload-not-working

Test plan :
1) Go to Tools > HTML customizations
2) Create a new entry (not using text editor)
3) Drag and drop an image
=> Without patch you see an error message from TinyMCE 'Dropped file type is
not supported'
=> With patch : It works !

Signed-off-by: David Nind 

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #5 from Lucas Gass  ---
This adds a bunch of base64 encoded stuff into the additional_contents table in
the DB, not my favorite but likely not harmful.

I tried renaming a JS file to JPG and it comes out looking like this:




The fix is trivial so I am passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31515] Select and edit multiple Course Reserves at once

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31515

--- Comment #1 from skVT  ---
In addition to 'enable'/'disable', 'export' (for downloading or printing entire
lists) and 'export/print list of selected' (for a list of all active courses)
would be helpful actions to be able to apply to a selected group of course
reserves.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31514] OPAC user interface should show all Course Reserves lists - not just active ones

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31514

--- Comment #2 from skVT  ---
Karen, that would not work for our purposes, for the following reasons:

At the college where I work, I share the link to the Course Reserves with all
faculty in preparation for the upcoming semester. I ask them to review the
courses they will be teaching and respond via a form, linked to a spreadsheet
that I then work from to organize, activate and prepare the lists. I often do
not know exactly who will be teaching what, when, so it is not practical for me
to activate all courses before getting these responses; I just send out the
link and form to ALL faculty/adjunct faculty. Furthermore, once I activate
courses so instructors can actually see them in Koha (ideally a month prior to
the semester, to give me time to make purchases and procure ILLs), patrons are
blocked from borrowing those books. That's not necessary, so far in advance

We aren't concerned about Course Reserves lists being "behind the scenes"
because our course reserves are not private or confidential. I think that most
student patrons rarely use this function in the OPAC, and when they do, it's
for a course they're enrolled in, which would in that case already be active
and ready to go. You could also put a clear note about this beside course
reserves search bar/page in the OPAC: "Course Reserves are subject to change. A
list is not confirmed and available until marked 'Active'." (Or something along
those lines.) Perhaps, users could even apply a filter to show 'active' courses
only.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31572] New: E-mail and SMS verification

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31572

Bug ID: 31572
   Summary: E-mail and SMS verification
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I believe Koha has a basic level of e-mail verification with patrons that self
register, but it would be helpful if there were a verification method for
e-mail and SMS on both staff and patron sides.

The idea is, that when an e-mail address or SMS number is entered by staff or
patron, there would be a button next to each that would say something like
'Verify'.  Staff or patron would click the button, and a link is sent to the
e-mail address or number with an explanation (instantly, not through a queue). 
If the patron clicks the link within a specified amount of time, the button
next to that address or number goes away, replaced by the word 'Verified!'.

Until the number or address is verified, notices will not go through that
method.  Notices would only go out through methods that are setup and verified.

A step further would be to have another button next to it on the staff side
that would be something like 'Re-verification Request'.  If staff get bounced
e-mails or texts, it would put the address or phone number back to a
verification needed mode, and stop all notifications through that method until
verified again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31513] NaN errors when using refund and payout with CurrencyFormat = FR

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31513

--- Comment #8 from Joonas Kylmälä  ---
Created attachment 140685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140685&action=edit
Bug 31513: (QA follow-up) Keep price formatting on non-editable text fields

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31513] NaN errors when using refund and payout with CurrencyFormat = FR

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31513

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #140612|0   |1
is obsolete||

--- Comment #7 from Joonas Kylmälä  ---
Created attachment 140684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140684&action=edit
Bug 31513: Remove price formatting form data- attributes

We cannot use data formatted with a decimal comma for
calculations. So we need to make sure that the data- attributes
passed to the modals are in 'database format' with decimal .

This will fix the NaN errors on the forms, but might also
negatively effect formatting in some spots.
Formatting should be fixed separately as this is for sure the
right first step, but we need to put in more work for displays.

To test:
* Set CurrencyFormat system preference to FR
* Go to any patron account > accounting tab
* Create a credit
* On Transactions tab: Payout amount at bottom = Verify NaN in input
* On Transactions tab: Issue payout on the credit line = Verify NaN in input
* Create a manual debit and pay it
* On Transactions tab: Issue refund = Verify NaN in input
* Apply patch
* Repeat test plan
* Now all input fields should be set with the correct amounts

https://bugs.koha-community.org/show_bug.cgi?id=31486

Signed-off-by: Michaela Sieber 

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31513] NaN errors when using refund and payout with CurrencyFormat = FR

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31513

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31513] NaN errors when using refund and payout with CurrencyFormat = FR

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31513

Joonas Kylmälä  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi
   |y.org   |
 CC||joonas.kylm...@iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #310 from Joonas Kylmälä  ---
(In reply to Blou from comment #309)
> We have stopped maintaining the patch as a formal prospect long ago, after
> being told there was no need nor interest for it.  It is an endeavour, and
> maintaining it "proper" is very time consumming.
> 
> 
> So we maintain it for ourselves and our clients (maybe hoping that maybe one
> day the stars will align?), as it is vastly superior to the current
> "calendar" in Koha.
> 
> 
> We tried many splits over the years, following recommendations.  Right now
> it's mostly for the sake of easy "git apply".

I see many people here in the comments interested in these patches, maybe you
mean with no interest as in no interest to review? As the motivation and
benefits of the patches is not super clear (due to the missing descriptions in
patches) I'm thinking that could have played its part here. However, from the
first comment on this bug I see that performance seems to be the reason for the
work.

I'm quite confident that if the patches with proper descriptions were submitted
they would move forward or be rejected as another approach to solving the bug
would be considered better. Actually what's the bug here? Calendar slow? If so,
the bug report title should be changed. For the Calendar slowness there might
be other fixes too so those need to be explored and documented.

In any case, until the patches are redone so that they could be reviewed may I
ask to keep the status in Failed QA so people don't spend unnecessarily time on
reviewing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #137643|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 140683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140683&action=edit
Bug 30687: Override hold policy when no valid pickup location

This patch allows hold policy to be overridden when there is no valid
pickup location and AllowHoldPolicyOverride is enabled. This is
re-implementing old behaviour that has been lost.

To test:

1. Go to Administration -> Circulation and fines rules. Ensure there is
a default circulation rule and default reserves policy.
2. Change the library using the dropdown and scroll to the bottom of the
page to set a reserves policy by item type for Library A, which the
following settings:
- Item type: BK
- Reserve policy: From home library
- Reserve pickup library match: any library
- Return policy: Item returns home
3. Go to Administration -> system preferences. Set the
AllowHoldPolicyOverride setting to Allow.
4. Create a biblio with an item where the item's home library is Library
A and the itemtype is BK.
5. Log in to the staff client as a Patron that belongs to Library B.
6. Search for the biblio you just created and try to request a hold for
yourself. Notice there is a blocking notice "Cannot place reserve", the
"Place reserve" button is disabled, and the item has a "No valid pickup
location" error.
7. Apply the patch and refresh the page or re-request the hold.
8. Confirm you can now place the hold, acknowledging that you must
override hold policy to do so (note the exclamation point icon).
9. Set the AllowHoldPolicyOverride system preference to "Don't allow".
10. Repeat Step 6. Confirm you are blocked again from requesting the
hold and cannot override it.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: Daniel 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 CC||k...@bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #6)
> Hi Aleisha, could you please look into Daniel's comment? If the hold cannot
> be filled at the pickup-location this might not work as intended.

The library community has spoken loud and clearly in the past and present, and
the consensus is that librarians should be able to force holds that are
unfillable. In the past I attempted to limit forced holds to those that would
be filled, and what we found out is that libraries utilize those unfillable
holds for a variety of reasons. We ended up reverting those changes in
community. We also have partners with this very same issue Aleisha is
describing. I think it's safe to say that the questions of "can this hold be
placed" and "can this hold be filled" are very much separate questions. In that
spirit, I think the question of "should this item be trapped instead of
transferred back" should be dealt with on a separate bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458

--- Comment #7 from Martin Renvoize  ---
Must admit.. I'd also be more motivated to continue if the dependant bug was
moving ;P..

Bug 31095 seems to have stalled waiting for someone to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458

--- Comment #6 from Martin Renvoize  ---
'Still on my list' is the status ;P

I need to swing back around to it soon, but have had other priorities the last
couple of weeks :S

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27066] Implement hooks for patrons updates

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27066

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #15 from Nick Clemens  ---
(In reply to Martin Renvoize from comment #14)
> If 'before' and 'after' actions don't affect the data of the object.. then
> they wont affect the actionlogs call.. so it shouldn't matter if they're
> before or after.  Personally.. I prefer to have them as late as possible, so
> after, but that's just a style thing.

I agree - the log should come before the after action hook - as the log is that
state when Koha is done with its work

The after action hook shouldn't change the data, but it seems more stable to
put our log before passing the object, in case something outside does change it
- we can at least record what Koha thinks the object should be

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Joelle Hannert  changed:

   What|Removed |Added

 CC||jhann...@nmc.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #140665|0   |1
is obsolete||

--- Comment #14 from ByWater Sandboxes  ---
Created attachment 140682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140682&action=edit
Bug 31569: Add filters

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #140664|0   |1
is obsolete||

--- Comment #13 from ByWater Sandboxes  ---
Created attachment 140681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140681&action=edit
Bug 31569: Remove unecessary imports

By using objects a number of other routines are not needed:
GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber

To test:
Grep for routines above in addorderiso2709 and confirm they are not used

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #140663|0   |1
is obsolete||

--- Comment #12 from ByWater Sandboxes  ---
Created attachment 140680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140680&action=edit
Bug 31569: Remove GetImportRecordsRange from list step

This patch removes the use of GetImportRecordsRange from the step
of listing import batches to choose. It was only used for a count so is a
simple
replacement

To test:
1 - Stage a number of files for import
2 - Import one of the files from tools
3 - Add to basket form a staged file
4 - Confirm staged baskets are listed, and imported basket is not

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #140662|0   |1
is obsolete||

--- Comment #11 from ByWater Sandboxes  ---
Created attachment 140679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140679&action=edit
Bug 31569: Remove GetImportRecordsRange from import stage

This patch removes the use of GetimportRecordsRange from the importing
step

To test:
 0 - Apply patch
 1 - Stage a marc file for import
 2 - Add to basket from a staged file
 3 - Select titles to import (don't select all)
 4 - Fill out necessary fields, be sure to select itemtype on items tab
 5 - Import
 6 - Confirm titles successfully added to basket
 7 - Confirm staged import not marked as imported
 8 - Add to basket from same file
 9 - Select rest of titles
10 - Import
11 - Confirm staged file now marked imported

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #140661|0   |1
is obsolete||

--- Comment #10 from ByWater Sandboxes  ---
Created attachment 140678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140678&action=edit
Bug 31569: Remove GetImportRecordsRange from import_biblios_list

This patch changes the way records are loaded for display when adding to
a basket from a staged file

To test:
1 - Stage a file of records for import
2 - Go to Acquisitions, find a vendor, create or find a basket
3 - Add to basket from staged file
4 - Choose the file
5 - Note the display of records
6 - Cancel
7 - Apply patch
8 - Stage from same file
9 - Note the display is unchanged

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #140660|0   |1
is obsolete||

--- Comment #9 from ByWater Sandboxes  ---
Created attachment 140677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140677&action=edit
Bug 31569: DO NOT PUSH Schema Updates

RM: Please copy object class lines :-)

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #140659|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 140676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140676&action=edit
Bug 31569: DB update and objects

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
What is the status of this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31571] CORS header needs more flexibility

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31571

Tomás Cohen Arazi  changed:

   What|Removed |Added

URL||https://developer.mozilla.o
   ||rg/en-US/docs/Web/HTTP/Head
   ||ers/Access-Control-Allow-Or
   ||igin
 CC||l...@bywatersolutions.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31571] New: CORS header needs more flexibility

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31571

Bug ID: 31571
   Summary: CORS header needs more flexibility
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

In order to have several domains allowed for the Access-Control-Allow-Origin we
need to:

 * Allow the AccessControlAllowOrigin syspref to take several values
 * On the controllers code, we should check Origin on each request against the
defined values and return the right value on the header.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #36 from Martin Renvoize  ---
This one took me a little while to wrap my head around.. probably just too many
bugs on the mind.

Anywho, now I have it looks great and all works as expected.. I think we'll
need to carefully document it somewhere to showcase it.

Tests are passing and the changes are covered nicely.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #139820|0   |1
is obsolete||

--- Comment #35 from Martin Renvoize  ---
Created attachment 140675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140675&action=edit
Bug 31380: Add unit tests

Signed-off-by: Kyle M Hall 
Signed-off-by: Paul Derscheid 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #139819|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 140674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140674&action=edit
Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller

This change checks for a "use_mojolicious" method in the plugin in order to
determine whether it should use a Mojolicious controller or a CGI script
controller.

Note that the check is for the existence of the method, so it is backwards
compatible with all existing Koha Plugins.

Signed-off-by: Kyle M Hall 
Signed-off-by: Paul Derscheid 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #139818|0   |1
is obsolete||

--- Comment #33 from Martin Renvoize  ---
Created attachment 140673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140673&action=edit
Bug 31380: Allow Koha Plugins to run using Mojolicious controllers

This patch adds a new mount point in plack.psgi, which makes Koha
able to run Mojolicious controllers. For example:
http://localhost:8081/cgi-bin/koha/staff/plugins/run

0a) Apply patch
0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi
0c) koha-plack --restart
1) Upload Koha Plugin koha-plugin-mojolicious.kpz
2) koha-plack --restart
3) Go to
http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl
4) Next to "Mojolicious Test", click "Actions", then click "Run tool"
5) Note that the web page looks perfect
6) Note that the URL is a bit different to normal:
http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious&method=tool
instead of:
http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious&method=tool

Note: The test Koha plugin will only work with a Mojolicious controller,
but it could be easily made to work with both

Signed-off-by: Kyle M Hall 
Signed-off-by: Paul Derscheid 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31509] Additional contents: Code should be configurable sometimes

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31509

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31570

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31570] Move patron consent title/description to Additional contents

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31570

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31509

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||31570


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31570
[Bug 31570] Move patron consent title/description to Additional contents
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31570] Move patron consent title/description to Additional contents

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31570

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||31503


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503
[Bug 31503] Allow several consent types on the consents tab of OPAC account
page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31570] New: Move patron consent title/description to Additional contents

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31570

Bug ID: 31570
   Summary: Move patron consent title/description to Additional
contents
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Follow-up for 31503.
This needs a bit more flexibility in AC. Like bug 31509?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27512] Block creation of invalid authorised values for LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512

--- Comment #5 from Marcel de Rooy  ---
(In reply to Andrew Fuerste-Henry from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > You can create the authorised values without issue, but you cannot use them
> > in items. items.damaged linked to DAMAGED only takes numerical AV codes.
> > (datatype)
> 
> Correct. I can create an authorized value in the DAMAGED category that has
> the value "TORN". Koha allows the creation of that authorized value, and
> then will show TORN as an option when editing items. However, it will never
> actually save TORN on an item and will never explain why it's failed to do
> so. The answer to that lies over in the schema, which tells us items.damaged
> only holds a bit.

Okay. How to proceed?
We could move damaged to varchar() as expected by Authorised Values?
Or we could intercept this in storing the item?
Or even before building the combo, but that could be quite generic code, so a
bit harder? Or when loading the form in javascript (hide options with a
non-numeric value)?
Another idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

--- Comment #26 from Marcel de Rooy  ---
The experimental patch with Additional Contents is obsoleted. The feature is
not flexible enough yet. Will open another report to move to AC later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #140090|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

--- Comment #25 from Marcel de Rooy  ---
Created attachment 140672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140672&action=edit
Bug 31503: Configurable consent text

Although I planned to implement this via Additional
contents (AC), I am using the AV description here after
all, since AC does not yet provide enough flexibility.

The title on the consents page is constructed from the
consent type now still, and the description is from the
OPAC description in AV (PATRON_CONSENT).

Note: AV allows you to add html in the description, although
it was not meant to do so. When we switch to AC later, we
will have the possibility of html, languages, title and
content.

Second note: We still need AV translations too. See
Bugzilla.

Test plan:
[1] Add a NEWSLETTER value under AV category PATRON_CONSENT.
[2] Add no OPAC description. Save. Hit OPAC consents page.
[3] Add description. Check page again.
[4] Add html to description. Check again.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #140089|0   |1
is obsolete||

--- Comment #24 from Marcel de Rooy  ---
Created attachment 140671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140671&action=edit
Bug 31503: Make opac-patron-consent more generic

We now allow multiple consent types as defined under AV
(read: authorised values) category 'PATRON_CONSENT'.
The description is used on the form too.

This is the base patch for multiple consents. We can do some more
polishing on a follow-up or another report even.
Note: the alert for GDPR was moved to the description.

Test plan:
First check the form without any PATRON_CONSENT values in AV. Toggle
the value of pref GDPR_Policy.
Now add GDPR_PROCESSING and another one (e.g. NEWSLETTER).
Refresh the OPAC form. Verify that you can toggle consent/dissent
and that everything is saved correctly. Note only a real change updates
the timestamp.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #140088|0   |1
is obsolete||

--- Comment #23 from Marcel de Rooy  ---
Created attachment 140670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140670&action=edit
Bug 31503: Add $av_cat->values

Test plan:
Run t/db_dependent/AuthorisedValues.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #140087|0   |1
is obsolete||

--- Comment #22 from Marcel de Rooy  ---
Created attachment 140669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140669&action=edit
Bug 31503: Change usermenu condition

Test plan:
Check if you see Consents tab depending on GDPR_Policy or having
PATRON_CONSENT authorised values.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Nick Clemens  changed:

   What|Removed |Added

 Depends on||31569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569
[Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19358
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358
[Bug 19358] Purchase suggestions - enhancements to linking to orders
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #140082|0   |1
is obsolete||

--- Comment #21 from Marcel de Rooy  ---
Created attachment 140668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140668&action=edit
Bug 31503: Use patron->consent in opac-patron-consent

Includes a few small additional changes in template:
[1] op == save (more generic)
[2] agreed/disagreed replaced by 1/0
[3] toggling display of consent_info paragraph

Test plan:
Enable GDPR_Policy.
Test adding/removing consent. Check what happens with
alert, consent_info paragraph and save button.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #140081|0   |1
is obsolete||

--- Comment #20 from Marcel de Rooy  ---
Created attachment 140667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140667&action=edit
Bug 31503: Add $patron->consent

Test plan:
Run t/db_dependent/Koha/Patron.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #140080|0   |1
is obsolete||

--- Comment #19 from Marcel de Rooy  ---
Created attachment 140666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140666&action=edit
Bug 31503: Adjust db column patron_consent.type

We want to control this field now via authorised values. An ENUM
is too restrictive.
A foreign key on the values of authorised_value for category
'PATRON_CONSENT' is not possible.
This will do for now.

Test plan:
Run dbrev.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

--- Comment #7 from Nick Clemens  ---
Created attachment 140665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140665&action=edit
Bug 31569: Add filters

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

--- Comment #6 from Nick Clemens  ---
Created attachment 140664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140664&action=edit
Bug 31569: Remove unecessary imports

By using objects a number of other routines are not needed:
GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber

To test:
Grep for routines above in addorderiso2709 and confirm they are not used

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

--- Comment #5 from Nick Clemens  ---
Created attachment 140663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140663&action=edit
Bug 31569: Remove GetImportRecordsRange from list step

This patch removes the use of GetImportRecordsRange from the step
of listing import batches to choose. It was only used for a count so is a
simple
replacement

To test:
1 - Stage a number of files for import
2 - Import one of the files from tools
3 - Add to basket form a staged file
4 - Confirm staged baskets are listed, and imported basket is not

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

--- Comment #4 from Nick Clemens  ---
Created attachment 140662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140662&action=edit
Bug 31569: Remove GetImportRecordsRange from import stage

This patch removes the use of GetimportRecordsRange from the importing
step

To test:
 0 - Apply patch
 1 - Stage a marc file for import
 2 - Add to basket from a staged file
 3 - Select titles to import (don't select all)
 4 - Fill out necessary fields, be sure to select itemtype on items tab
 5 - Import
 6 - Confirm titles successfully added to basket
 7 - Confirm staged import not marked as imported
 8 - Add to basket from same file
 9 - Select rest of titles
10 - Import
11 - Confirm staged file now marked imported

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

--- Comment #3 from Nick Clemens  ---
Created attachment 140661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140661&action=edit
Bug 31569: Remove GetImportRecordsRange from import_biblios_list

This patch changes the way records are loaded for display when adding to
a basket from a staged file

To test:
1 - Stage a file of records for import
2 - Go to Acquisitions, find a vendor, create or find a basket
3 - Add to basket from staged file
4 - Choose the file
5 - Note the display of records
6 - Cancel
7 - Apply patch
8 - Stage from same file
9 - Note the display is unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

--- Comment #2 from Nick Clemens  ---
Created attachment 140660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140660&action=edit
Bug 31569: DO NOT PUSH Schema Updates

RM: Please copy object class lines :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

--- Comment #1 from Nick Clemens  ---
Created attachment 140659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140659&action=edit
Bug 31569: DB update and objects

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

--- Comment #61 from Andrew Fuerste-Henry  ---
(In reply to Martin Renvoize from comment #60)
> OK.. I'm going to hold off on continuing through this until we have bug
> 30592 pushed as I feel that's now just around the corner and it'll save me
> considerable rebases.. hopefully we'll get this set of bugs finished up in
> quick succession once that one is pushed and have the full effect for 22.11
> :)

Guessing you mean bug 30952, staff client redesign. Bug 30592 is something
about borrowers.secret.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27512] Block creation of invalid authorised values for LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512

--- Comment #4 from Andrew Fuerste-Henry  ---
(In reply to Katrin Fischer from comment #3)
> You can create the authorised values without issue, but you cannot use them
> in items. items.damaged linked to DAMAGED only takes numerical AV codes.
> (datatype)

Correct. I can create an authorized value in the DAMAGED category that has the
value "TORN". Koha allows the creation of that authorized value, and then will
show TORN as an option when editing items. However, it will never actually save
TORN on an item and will never explain why it's failed to do so. The answer to
that lies over in the schema, which tells us items.damaged only holds a bit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24288] Add wording to authorized value interface to indicate valid code length

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288

--- Comment #13 from Andrew Fuerste-Henry  ---
(In reply to Jonathan Druart from comment #12)
> 1. Maybe also YES_NO?
Makes sense to me to include this.

> 
> 2. NOT_LOAN can be negative. I don't think negative numbers are "one-digit"
> numbers (being pedantic I suppose but that may be confusing?)
I see your point, technically. Would it be more clear an understandable to say
something like "whole number between -9 and 9"?

> 
> 3. Shouldn't we then add a check inputmode="numeric" and pattern when
> appropriate?
Sounds good!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|31403   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403
[Bug 31403] Activate circulation sidebar (CircSidebar system preference) on
default in new installations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31403] Activate circulation sidebar (CircSidebar system preference) on default in new installations

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|31411   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411
[Bug 31411] [Omnibus] Set focus to first input field of an add/entry form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31159] Can we make sidebar navigation collapsible?

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159

Martin Renvoize  changed:

   What|Removed |Added

Summary|Can we drop the |Can we make sidebar
   |'CircSideBar' preference|navigation collapsible?
   |and convert the sidebar to  |
   |being collapsible?  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31159] Can we drop the 'CircSideBar' preference and convert the sidebar to being collapsible?

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159

--- Comment #2 from Martin Renvoize  ---
In bug 31403 we enable CircSideBar by default for new installs.. so I'm going
to repurpose this bug to just the 'Make it collapsible' part.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31159] Can we drop the 'CircSideBar' preference and convert the sidebar to being collapsible?

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31403

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31403] Activate circulation sidebar (CircSidebar system preference) on default in new installations

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31159

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31569] New: Remove GetImportsRecordRange from acqui/addorderiso2709

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

Bug ID: 31569
   Summary: Remove GetImportsRecordRange from
acqui/addorderiso2709
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Refactor to use Koha::Import::Records

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192
Bug 31192 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail view

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083
Bug 31083 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31130] Display collection code in bundle management table

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31130
Bug 31130 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31084] Display item type in bundle management table

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084
Bug 31084 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082
Bug 31082 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31080] Block adding the bundle item to its own bundle

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080
Bug 31080 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31081] Improve display of 'Manage bundle' button

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31081
Bug 31081 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31079] Entering an empty line on checking of an item bundle, gives "Unexpected:" error

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31079
Bug 31079 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31078] Lost status different to 1 don't show with description in bundle detail view

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31078
Bug 31078 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566
Bug 29566 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560
Bug 29560 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29099] Add support for item bundles in the inventory tool

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099
Bug 29099 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503
Bug 25503 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|Needs documenting
  Documentation||Martin Renvoize
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

--- Comment #60 from Martin Renvoize  ---
OK.. I'm going to hold off on continuing through this until we have bug 30592
pushed as I feel that's now just around the corner and it'll save me
considerable rebases.. hopefully we'll get this set of bugs finished up in
quick succession once that one is pushed and have the full effect for 22.11 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #280 from Julian Maurice  ---
Created attachment 140658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140658&action=edit
Bug 30952: Fix table styling (cell borders, striping)

Issue #22

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >