[Koha-bugs] [Bug 31622] New: tes

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31622

Bug ID: 31622
   Summary: tes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: brayqud...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Created attachment 140967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140967&action=edit
hai semua

hai semua heheheh xixixixixix

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29001] Subfields attributes are not preserved when order is changed in framework

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

--- Comment #12 from Andrew Nugged  ---
(In reply to Lucas Gass from comment #10)
> Backported to 22.05.x for 22.05.05

Bug 31238 is also needed in 22.05
because this 29001 brings a bug and fixed in this way:


-my $authorised_value = $input->param("authorised_values_$id");
+my $authorised_value = $input->param("authorised_value_$id");

in 31238.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28555] Improve logging for overdue_notices.pl

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28555] Improve logging for overdue_notices.pl

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555

David Nind  changed:

   What|Removed |Added

 Attachment #134076|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 140968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140968&action=edit
Bug 28555: Improve logging for overdue_notices.pl

Currenlty the output with -v from overdue_notices is a bit overwhelming and
hard to parse

I do a few things here:
1 - Only show SQL if verbose > 1
2 - Add some separators to make it more readab;e
3 - Remove some redundant messages with branchcode and borrowernumber

To test:
1: perl misc/cronjobs/overdue_notices.pl -v
2: Notice you get a LOT of information all smushed together
3: Apply patch
4: perl misc/cronjobs/overdue_notices.pl -v
5: Less info, and easier to read
6: perl misc/cronjobs/overdue_notices.pl -v -v
7: All the info, but nicer to read

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168

David Nind  changed:

   What|Removed |Added

 Attachment #134603|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 140969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140969&action=edit
Bug 30168: Use checkout object in GetSoonestRenewDate

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
I've signed off on the basis that the tests pass before and after the patch is
applied: prove t/db_dependent/Circulation.t 

Let me know if there is anything else required to test this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168

--- Comment #7 from David Nind  ---
I also ran similar tests to bug 30167, for what it is worth.

- Tested on 09/25/2022 (American date format) with 
  . 'no renewal before' set to 3
  . 'loan period' set to 5
- Checked out on date is 09/25/2022 05:10
- For the patron from the checkouts: No renewal before 04/27/2022
- When trying to renew from Circulation > Renew, the message is "Intermediate
Perl / ( 305134 ) cannot be renewed before 09/27/2022."
- When trying to renew by checking out to the same patron again, the message
is: "No more renewals possible"
- Date is calculated correctly including the current day (3 days - 25th, 26th +
27th)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

David Nind  changed:

   What|Removed |Added

 Attachment #137745|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 140970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140970&action=edit
Bug 29102: Do not count patron's own hold against limits

This patch makes three changes:
1 - The borrower's own holds are not counted towards HighHolds limit
2 - We exclude all hold counts from CanItemBeReserved
3 - Static mode should only decrease hold when over the
decreaseLoanHighHoldsValue, not when equal

Previously a patron's hold could put the count over the threshhold, and
if the patron is only allowed 1 hold per record, and the hold wasn't found
before
the checkout, it would make all items unholdable, thus lowering the theshhold
for
dynamic HighHolds

To test:
 1 - Set sysaprefs:
 decreaseLoanHighHolds  - enable
 decreaseLoanHighHoldsDuration - 1
 decreaseLoanHighHoldsValue - 1
 decreaseLoanHighHoldsControl - "over the number of holdable items on the
record" / dynamic
 decreaseLoanHighHoldsIgnoreStatuses - blank
 2 - Set circ rules to allow 1 hold per record and loan period of 5
 3 - Find/create a record with 3 items
 4 - Place a title level hold for two different patrons
 5 - Attempt to checkout item - note warning about high holds
 6 - Cancel checkout
 7 - Set decreaseLoanHighHoldsControl - "on the record" / static
 8 - Attempt checkout - note warning about high holds
 9 - Apply patch
10 - Checkout item - no warning
11 - checkin item, replace hold
12 - Set decreaseLoanHighHoldsControl - "over the number of holdable items on
the record" / dynamic
13 - Checkout item - no warning
14 - prove t/db_dependent/DecreaseLoanHighHolds.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

David Nind  changed:

   What|Removed |Added

 Attachment #137746|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 140971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140971&action=edit
Bug 29102: Remove ignore_found_holds

If not counting patrons holds, found or unfound, we no longer need this option
introduced by bug 28078

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31577] Use patron category multi-select for OpacHiddenItemsExceptions system preference

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31577

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31577] Use patron category multi-select for OpacHiddenItemsExceptions system preference

2022-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31577

David Nind  changed:

   What|Removed |Added

 Attachment #140762|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 140972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140972&action=edit
Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions
system preference

We are now using the patron category selects on almost all system
preferences, but OpacHiddenItemsExceptions was still missing.

To test:
- Before applying the patch:
- Add patron categories to OpacHiddenItemsExceptions using |
- Add configuration to OpacHiddenItems
- Verify all works as expected in the OPAC
- Apply patch, run database update
- Verify the system preference shows the correct settings from before
- Verify feature still works as expected

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/