[Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #141592|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  ---
Created attachment 141854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141854&action=edit
Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield

Remove 'i' added to the end of the breadcrumb on the confirmation page
when deleteing a MARC framework subfield.

Test plan:
1. Go to Administration > MARC bibliographic frameworks.
2. View the subfields for a tag for a framework, for example:
   . BKS framework > Actions > MARC structure
   . Search for tag 245
   . Select Actions > View subfields.
3. Select any subfield to delete and select the Delete button.
4. Note that there is an 'i' at the end of the breadcrumb, for example:
   . ... > Confirm deletion of subfield bi
5. Apply the patch.
6. Refresh the page and note that that 'i' is removed.
7. Sign off.

Signed-off-by: David Nind 
Signed-off-by: Fridolin Somers 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756

--- Comment #9 from David Nind  ---
(In reply to David Cook from comment #8)

> Yeah, the default sort in Zebra is ascending by internal record number which
> is the same as biblionumber. 
> 
> What happens with MARC21? Surely it must be the same behaviour...

There are only 400 odd records in the sample data set, so doesn't show as an
issue.

I've had no luck exporting all the records from Koha and then importing at the
moment, so can't test this out...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

--- Comment #63 from Jonathan Druart  ---
What did you fix, and how?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31784] New: SingleBranchMode ignores public flag

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784

Bug ID: 31784
   Summary: SingleBranchMode ignores public flag
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

The test in C4/Auth.pm:
singleBranchMode   => ( Koha::Libraries->search->count == 1 ),
misses a fundamental condition, i.e. public should be true.

C4/XSLT.pm:my $singleBranchMode = Koha::Libraries->search->count == 1 ? 1 :
0;

t/Koha.t:is ( Koha::Libraries->search->count, 1, 'There should be only 1
library (singleBranchMode on)' );

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #41 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #40)
> Added Marcel to CC list.. this patchset changes get_marc_host.. I know
> you're close to that sub.. any chance you could validate the change here..
> I'm afraid my knowledge of that area has dropped away somewhat.

Its on my list now ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31775] Show opac_info of single library

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775

--- Comment #4 from Marcel de Rooy  ---
(In reply to David Nind from comment #3)
> I had a go at testing, but struggled to notice any difference - except that
> for a single library, the library name is linked. No additional information
> is displayed on the linked page (even if all the library information fields
> are filling in).
> 
> If this is what is expected, I'm happy to sign off.

Thx for testing, David. You are correct: my test plan could be more detailed.
What we need to do also, is add the opac_info information for a branch via
Additional Contents, html cust., OpacLibraryInfo location.
For one library you should see the full info page at once. For more libraries
you should see the list first.

Deleting a library should not be needed. Just hiding it via the public flag. I
will check if you found a bug there too..

Will comment on a few other points still.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743

Marcel de Rooy  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #4 from Marcel de Rooy  ---
(In reply to Marie-Luce Laflamme from comment #2)
> Suggestion for the test plan
> 
> 1. Apply the patch
> 3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
> 4. Enable TranslateNotices.
> 5. Login on the OPAC and go in "your messaging"
> 6. Check if you can only change notice language
> 7. Enable EnhancedMessagingOPAC.
> 8. Check if you can change messaging prefs too.

Thx Marie-Luce for signing off !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756

--- Comment #7 from David Nind  ---
(In reply to David Cook from comment #6)

> Could you elaborate a bit more? You say the order changes to "asc". Does
> that mean it was "desc" before? 

Yes.

For UNIMARC, when I used the URL with dsc in it:
- Results 1 to 1,000 appear to sort correctly, with biblo records in descending
order
- For result 1,001 the biblio number of the record displayed is 1, and then it
continues in ascending order for the rest of the paged set of results (until
"last")

If there is a setting that limits the sorting to 1,000, then I would expect
this to happen with the URL with asc in it as well, but it doesn't - everything
appears to be as expected with all the results set 4,000+ sorting correctly.

Maybe for the asc URL this is the "default" for the Zebra config, would that
explain why they act differently?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #66 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #62)
> (In reply to Katrin Fischer from comment #21)
> > I just noticed that you need to run the database update for Koha to work.
> > Not sure if this could cause problem with the web installer.
> > 
> > Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load
> > application from file "/kohadevbox/koha/api/v1/app.pl":
> > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> > execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at
> > /kohadevbox/koha/Koha/Objects.pm line 312
> 
> This is certainly an issue. I'm looking at follow-ups...

Please comment about the code, propose things and stuff so this shines for the
release. Follow-ups will come out of course. Thanks for your time!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #65 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #63)
> (In reply to Martin Renvoize from comment #58)
> > To test:
> > 1. Apply this patch
> > 2. Run:
> >$ kshell
> >   k$ prove t/db_dependent/api/v1/auth_providers.t
> > => SUCCESS: Tests pass!
> > 3. Sign off :-D
> 
> Looks like the unit test file is t/db_dependent/Koha/Auth/Provider.t these
> days.

There should be tests for the providers CRUD in there as well.

git diff origin/master --name-only

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #64 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #62)
> (In reply to Katrin Fischer from comment #21)
> > I just noticed that you need to run the database update for Koha to work.
> > Not sure if this could cause problem with the web installer.
> > 
> > Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load
> > application from file "/kohadevbox/koha/api/v1/app.pl":
> > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> > execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at
> > /kohadevbox/koha/Koha/Objects.pm line 312
> 
> This is certainly an issue. I'm looking at follow-ups...

I think the old GoogleOpenId... stuff removal is to blame, as we decided to
defer it. Will look tomorrow morning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Failed QA

--- Comment #5 from David Nind  ---
Hi David.

Things seem to be working for MARC21.

However, for UNIMARC:
- I changed the count number =100
- After the first 10 pages of results (that is, from page 11 and the 1001
search result) the order changes to asc starting from 1

It works fine for asc.

Note: when copying the definitions in step 2, I replaced marc21 with unimarc in
the file paths.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31783] Table settings page needs page-section class

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783

--- Comment #1 from Lucas Gass  ---
Created attachment 141852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141852&action=edit
Bug 31783: Add page-section to columns_settings.tt page

This patch adds the page-section class to the tables on the Table settings
page.

To test:

1. Apply patch and go to Administration > Table settings
2. Make sure the tables look good with the new page-section class, which is
added to an existing div in this case.
3. Make sure that changing some table setting still works and you can properly
save new settings.

Note: This patch moves the fieldset which contains the Save button into the
page-section div.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31783] Table settings page needs page-section class

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Lucas Gass  changed:

   What|Removed |Added

 Blocks||31783


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783
[Bug 31783] Table settings page needs page-section class
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31783] New: Table settings page needs page-section class

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783

Bug ID: 31783
   Summary: Table settings page needs page-section class
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 30952

We need the page-section div added to the columns_settings.tt page to ensure
proper contrast for even/odd rows on the tables.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781

--- Comment #1 from Lucas Gass  ---
Created attachment 141851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141851&action=edit
Bug 31781: Add page-section to branchtransfers page

This patch adds the page-section div to 2 tables on the branch transfer page.

To test:
1. Apply patch
2. Place an item level hold on a few items.
3. Now go to the branch transfer page and try transferring your items that have
holds on them.
4. This should bring up a 'Reserve found' page. Look at the table and make sure
it looks good with the page-section div added.
5. Now try some transfers that do not have holds. Make sure the table that
populates also goods good with the page-section div added.

Note: There are some indentation changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629

David Nind  changed:

   What|Removed |Added

 Attachment #141837|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 141850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141850&action=edit
Bug 31629: Add elasticqueue options to cleanup_database

This patch adds an elasticqueue option to cleanup_database.pl to allow
for purging completed reindexing jobs

To test:
 1 - Enable elastic search in Koha
 2 - perl misc/maintenance/touch_all_items.pl
 3 - Check db and note there are a bunch of elastic reindex jobs
 4 - Update to make them old
 UPDATE background_jobs SET ended_on = '2022-10-01 00:00:00' WHERE type =
'update_elastic_index'
 5 - perl misc/cronjobs/cleanup_database.pl
 6 - Note elasticqueue entry shows in help
 7 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v
 8 - Note that elasticqueue would have been cleared
 9 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v --confirm
10 - Note that number of entries deleted is reported
11 - Confirm in staff interface that jobs are gone:
 http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl
 (Uncheck 'Current jobs only')

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766

--- Comment #7 from Lucas Gass  ---
(In reply to David Nind from comment #6)
> It is better than it was before, so I've signed off.
> 
> However, I like the border around the table and table header (in the first
> screenshot).
> 
> For me:
> - the header/table blends in too much with the background without the borders
> - with the border, it makes it much easer to scan the table column headers
> and rows

David, I agree. The header/table blends in too much, this is happening on this
page and elsewhere. I think we'll need to address that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #13 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
It is better than it was before, so I've signed off.

However, I like the border around the table and table header (in the first
screenshot).

For me:
- the header/table blends in too much with the background without the borders
- with the border, it makes it much easer to scan the table column headers and
rows

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31155] Document --since option in help of borrowers-force-messaging-defaults.pl

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to stable|Needs documenting

--- Comment #7 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Maybe docs to update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #141768|0   |1
is obsolete||

--- Comment #3 from ByWater Sandboxes  ---
Created attachment 141849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141849&action=edit
Bug 31743: Change condition for messaging tab

Note for QA:
The code for SMSnumber is still made dependent on
EnhancedMessagingPreferencesOPAC in order to not
disturb current behavior.
This fixes Enhanced on, EnhancedOPAC off; the case of
Enhanced off is not considered here.

Test plan:
Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
Enable TranslateNotices.
Check if you can only change notice language on OPAC.
Enable EnhancedMessagingOPAC.
Check if you change messaging prefs too.

Signed-off-by: Marcel de Rooy 

Signed-off-by: marie-luce 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743

Marie-Luce Laflamme  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||marie-luce.laflamme@inlibro
   ||.com

--- Comment #2 from Marie-Luce Laflamme  ---

Suggestion for the test plan

1. Apply the patch
3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
4. Enable TranslateNotices.
5. Login on the OPAC and go in "your messaging"
6. Check if you can only change notice language
7. Enable EnhancedMessagingOPAC.
8. Check if you can change messaging prefs too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

--- Comment #6 from David Nind  ---
(In reply to Lucas Gass from comment #5)
> Let's file a separate bug for that.

Bug 31782 created for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766

David Nind  changed:

   What|Removed |Added

 Attachment #141829|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 141848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141848&action=edit
Bug 31766: Add page-section wrapper to notice table

To test:
1. Apply patch
2. Look at the noitce page and notice how the table, and it's tools, now are
wrapped with the page-section element.
3. Is it better than it was before?

Feel free to osboslete these patch and replace it with your own.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt )

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780

David Nind  changed:

   What|Removed |Added

 Attachment #141841|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 141847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141847&action=edit
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class
added.

Note: There are some indentation changes.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt )

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31782] Patron lists - patron autocomplete search does not work

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

David Nind  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31782] New: Patron lists - patron autocomplete search does not work

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Bug ID: 31782
   Summary: Patron lists - patron autocomplete search does not
work
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: da...@davidnind.com
QA Contact: testo...@bugs.koha-community.org

When adding a patron to a list, the autocomplete search does not work.

Instead, you have to paste the patron card number or borrower number into the
Add multiple patrons form.

To replicate:
1. Go to Tools > Patrons and circulation > Patron lists.
2. Add a new patron list.
3. Go to add patrons page for the list. Note that there is a JavaScript in the
web developer tools console [1].
4. Type an existing name in the patron search box, for example: mary. 
5. Note that the progress icon/circle appears very briefly, but the name is not
autocompeleted.
6. Note also that there is a 400 bad request error in the web developer tools
console.[2]

[1] JavaScript error when viewing Add patrons page for a patron list:

Uncaught TypeError: can't access property "_renderItem",
$(...).autocomplete(...).data(...) is undefined
patron_autocomplete
http://127.0.0.1:8081/intranet-tmpl/js/autocomplete/patrons_22.0600062.js:20

http://127.0.0.1:8081/cgi-bin/koha/patron_lists/list.pl?patron_list_id=1:1080
jQuery 2
e
t

[2] 400 bad request error when typing a name in the autocomplete field:

GET http://127.0.0.1:8081/api/v1/patrons?term=mary
Status: 400 Bad Request
Version:  HTTP/1.1
..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Lucas Gass  changed:

   What|Removed |Added

 Blocks||31781


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781
[Bug 31781] Transferred items table (branchtransfers.tt) needs page-section
class
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31781] New: Transferred items table (branchtransfers.tt) needs page-section class

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781

Bug ID: 31781
   Summary: Transferred items table (branchtransfers.tt) needs
page-section class
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Depends on: 30952

We need the page-section div added to the branchtransfers page to ensure proper
contrast for even/odd rows on the tables.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773

David Nind  changed:

   What|Removed |Added

 Attachment #141843|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 141846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141846&action=edit
Bug 31773: Add page-section class to Manage staged MARC records page

To test:
1. Apply patch
2. Have some MARC records and stage them for import. It will be nessesary to
add more than 1
3. Go to the Manage staged MARC records page and make sure the table looks
right with the page-section added.

Note: I am also adding the Bootstrap table class to this table becuase I think
it makes the table look much nicer.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

--- Comment #5 from Lucas Gass  ---
(In reply to David Nind from comment #4)
> I hadn't refreshed the page - I now see it was already signed off!
> 
> I notice that the auto complete for patron search when adding patrons to a
> list is not working (it wasn't working before the patch was applied).
> 
> Should this be a separate bug?

Never hurts to have 2 sign-offs!

I see there is a JS error on that page and that is likely why the auto complete
function is broken:

Uncaught TypeError: $(...).autocomplete(...).data(...) is undefined

Let's file a separate bug for that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
I hadn't refreshed the page - I now see it was already signed off!

I notice that the auto complete for patron search when adding patrons to a list
is not working (it wasn't working before the patch was applied).

Should this be a separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

David Nind  changed:

   What|Removed |Added

 Attachment #141840|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 141845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141845&action=edit
Bug 31763: Add 'page-section' to patron lists page

This patch updates patron lists templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Unrelated change: I wrapped some form controls in a  to make
it consistent with other pages and to work better with the updated
markup.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron lists.

- If necessary, create one or more patron lists so that the table
  appears. Confirm that the content area looks correct.
- Click Actions -> Add patrons to confirm that the screen
  looks correct.

Signed-off-by: Lucas Gass 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes (using koha-testing-docker):

- Ran cronjob with --preserve-logs option and got error message:
  misc/cronjobs/cleanup_database.pl --preserve-logs
  Unknown option: preserve-logs

- Ran cronjob with --preserve-log option and got message "You did not specify
any cleanup work for the script to do."

- Checked help after patch applied and help text is corrected
(misc/cronjobs/cleanup_database.pl --help)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824

--- Comment #14 from Katrin Fischer  ---
Could this be a duplicate to the just fixed bug 31587?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776

David Nind  changed:

   What|Removed |Added

 Attachment #141826|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 141844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141844&action=edit
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage

cleanup_database.pl cronjob has a typo in it's usage/help:
"preserve-logs" option should be "preserve-log" as it is everywhere
in the code.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31775] Show opac_info of single library

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
I had a go at testing, but struggled to notice any difference - except that for
a single library, the library name is linked. No additional information is
displayed on the linked page (even if all the library information fields are
filling in).

If this is what is expected, I'm happy to sign off.

Testing notes (using koha-testing-docker):

- Needed to batch modify patrons to change their library to the one kept
(possibly could have just deleted all patrons).

- Needed to batch modify items for all libraries not kept so that their home
library and current library changed to the library kept.

- Not sure how to make a library not publicly accessible, is there some other
system preference to change?
  . Changing an existing library: get message "An error occurred when updating
this library. Perhaps it already exists."
  . Creating a new library - even if you change public to "No", it saves as
public with "Yes".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773

--- Comment #1 from Lucas Gass  ---
Created attachment 141843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141843&action=edit
Bug 31773: Add page-section class to Manage staged MARC records page

To test:
1. Apply patch
2. Have some MARC records and stage them for import. It will be nessesary to
add more than 1
3. Go to the Manage staged MARC records page and make sure the table looks
right with the page-section added.

Note: I am also adding the Bootstrap table class to this table becuase I think
it makes the table look much nicer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC records page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt )

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31767] Add 'page-section' to tags page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767

Lucas Gass  changed:

   What|Removed |Added

 Attachment #141838|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 141842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141842&action=edit
Bug 31767: Add 'page-section' to tags page

This patch updates tags templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Tags.

- Confirm that the content area of the page looks correct.
- Click one of the tag terms to view the list of titles tagged with that
  term. Confirm that this page looks correct too.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31767] Add 'page-section' to tags page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt )

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780

--- Comment #1 from Lucas Gass  ---
Created attachment 141841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141841&action=edit
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class
added.

Note: There are some indentation changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt )

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31779] Article Request form shows all locations in pickup library menu

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31779

--- Comment #1 from Eric Phetteplace  ---
In case it's useful for other people, this is the custom JS I've added:

if (location.pathname.match('/cgi-bin/koha/opac-request-article.pl')) {
// remove invalid pickup library options
$('option[value="NOTAPICKUPLIB1"],
option[value="NOTAPICKUPLIB2"]').remove()
}

You need to add in your own branch codes. We actually only have one valid
location so I added another line `$('#branchcode').parent().hide()` to hide the
menu and its label altogether since there's no choice for users to make.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Lucas Gass  changed:

   What|Removed |Added

 Blocks||31780


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780
[Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt )
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31780] New: Add 'page-section' to audio alerts ( audio_alerts.tt )

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780

Bug ID: 31780
   Summary: Add 'page-section' to audio alerts ( audio_alerts.tt )
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 30952

We need the page-section div adding to audio alerts page to ensure proper
contrast for even/odd rows on the tables.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31760] Low constrast of some colors (WCAG)

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766

Lucas Gass  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

Lucas Gass  changed:

   What|Removed |Added

 Attachment #141835|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 141840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141840&action=edit
Bug 31763: Add 'page-section' to patron lists page

This patch updates patron lists templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Unrelated change: I wrapped some form controls in a  to make
it consistent with other pages and to work better with the updated
markup.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron lists.

- If necessary, create one or more patron lists so that the table
  appears. Confirm that the content area looks correct.
- Click Actions -> Add patrons to confirm that the screen
  looks correct.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31779] New: Article Request form shows all locations in pickup library menu

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31779

Bug ID: 31779
   Summary: Article Request form shows all locations in pickup
library menu
 Change sponsored?: ---
   Product: Koha
   Version: 22.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ephettepl...@cca.edu
QA Contact: testo...@bugs.koha-community.org

To recreate:

1. have multiple locations/branches
2. set one to not be available as a pickup location
3. have an item where you can make article requests (e.g. a newspaper or
journal)
4. go to the article request form for the item
/cgi-bin/koha/opac-request-article.pl?biblionumber={{biblionumber}}
5. note the "pickup library" select menue at the bottom of the form

Expected behavior: the location in step #2 will not be listed in the select
menu because it is not an available pickup location. This is the case, for
instance, on the holds form at
/cgi-bin/koha/opac-reserve.pl?biblionumber={{biblionumber}}.

Actual behavior: all libraries are listed. The template iterates over all
branches `FOREACH b IN Branches.all` without discrimination.

There's a question of whether article pickups and holds pickups should be
treated the same, maybe there's some edge case where these are different, but
for us and I would imagine the vast majority of libraries it doesn't make sense
to offer a pickup location for articles when the branch itself doesn't process
holds (usually means there are no circulation functions or staff at that
location).

I looked at the logic in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt to see if it could be
easily copied over to the
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt but it is not
as straightforward as I'd expected. We will probably resort to OPACUserJS to
work around this in the meantime.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31778] action logs for administrative tasks

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31778

Evelyn Hartline  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764

Lucas Gass  changed:

   What|Removed |Added

 Attachment #141836|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 141839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141839&action=edit
Bug 31764: Add 'page-section' to patron clubs page

This patch updates patron clubs template so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron clubs.

- If necessary, add at least one club template and at least one club
  based on that template.
- Confirm that the display of club templates and clubs looks correct.
- Locate some patrons and add them to a club.
- On the patron clubs page, locate a club with enrollments and click
  Actions -> Enrollments. Confirm that the page looks correct.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31778] New: action logs for administrative tasks

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31778

Bug ID: 31778
   Summary: action logs for administrative tasks
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Transaction logs
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: eve...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

There are no action logs generated for changes/creation/removal of branches
(for example, the branch code, email, SMTP server selection, etc.). It would be
great if changes like that were logged. 

If there is interest, these logs could be extended to other "administrative"
tasks as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31767] Add 'page-section' to tags page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767

--- Comment #1 from Owen Leonard  ---
Created attachment 141838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141838&action=edit
Bug 31767: Add 'page-section' to tags page

This patch updates tags templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Tags.

- Confirm that the content area of the page looks correct.
- Click one of the tag terms to view the list of titles tagged with that
  term. Confirm that this page looks correct too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31767] Add 'page-section' to tags page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31767] Add 'page-section' to tags page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629

--- Comment #1 from Nick Clemens  ---
Created attachment 141837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141837&action=edit
Bug 31629: Add elasticqueue options to cleanup_database

This patch adds an elasticqueue option to cleanup_database.pl to allow
for purging completed reindexing jobs

To test:
 1 - Enable elastic search in Koha
 2 - perl misc/maintenance/touch_all_items.pl
 3 - Check db and note there are a bunch of elastic reindex jobs
 4 - Update to make them old
 UPDATE background_jobs SET ended_on = '2022-10-01 00:00:00' WHERE type =
'update_elastic_index'
 5 - perl misc/cronjobs/cleanup_database.pl
 6 - Note elasticqueue entry shows in help
 7 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v
 8 - Note that elasticqueue would have been cleared
 9 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v --confirm
10 - Note that number of entries deleted is reported
11 - Confirm in staff interface that jobs are gone:
 http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl
 (Uncheck 'Current jobs only')

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764

--- Comment #1 from Owen Leonard  ---
Created attachment 141836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141836&action=edit
Bug 31764: Add 'page-section' to patron clubs page

This patch updates patron clubs template so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron clubs.

- If necessary, add at least one club template and at least one club
  based on that template.
- Confirm that the display of club templates and clubs looks correct.
- Locate some patrons and add them to a club.
- On the patron clubs page, locate a club with enrollments and click
  Actions -> Enrollments. Confirm that the page looks correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766

Lucas Gass  changed:

   What|Removed |Added

 Attachment #141829|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766

Lucas Gass  changed:

   What|Removed |Added

 Attachment #141829|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

--- Comment #1 from Owen Leonard  ---
Created attachment 141835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141835&action=edit
Bug 31763: Add 'page-section' to patron lists page

This patch updates patron lists templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Unrelated change: I wrapped some form controls in a  to make
it consistent with other pages and to work better with the updated
markup.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron lists.

- If necessary, create one or more patron lists so that the table
  appears. Confirm that the content area looks correct.
- Click Actions -> Add patrons to confirm that the screen
  looks correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

--- Comment #34 from Lucas Gass  ---
This patchset has been reverted from 22.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Andrew Nugged  changed:

   What|Removed |Added

 Status|Pushed to stable|ASSIGNED

--- Comment #33 from Andrew Nugged  ---
ok, so everything what was done above this message is OBSOLETE now,

Kevin Carnes, are you ok with committing here new solution from base?

(please mind the patches if something were useful in Bug 31727 too).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727

Andrew Nugged  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29012

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Andrew Nugged  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31727

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Andrew Nugged  changed:

   What|Removed |Added

 Depends on|31727   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727
[Bug 31727] Orphan records in circulation_rules and false positives after
attempt to fix values to be empty or zeroes instead of missing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758

--- Comment #14 from Owen Leonard  ---
(In reply to Martin Renvoize from comment #13)
> Created attachment 141834 [details] [review]
> Bug 31758: (follow-up) Remove fat margin-top
> 
> This removes the increased top margin appearing on subsection headings
> after clicking through from search..

The purpose of the extra margin can be seen if you click one of the sidebar
subheadings to jump down. Without the extra margin, when you jump to that
section the heading is obscured by the floating toolbar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727

Andrew Nugged  changed:

   What|Removed |Added

 Blocks|29012   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012
[Bug 29012] Some rules are not saved when left blank while editing a 'rule'
line in smart-rules.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012
Bug 29012 depends on bug 31727, which changed state.

Bug 31727 Summary: Orphan records in circulation_rules and false positives 
after attempt to fix values to be empty or zeroes instead of missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727

Andrew Nugged  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |INVALID

--- Comment #17 from Andrew Nugged  ---
this ticket is not needed anymore because the contents of 29012 will be
obsoleted and re-done.


to Kevin Carnes:

let's go back to Bug 29012 and obsolete everything there and make again a full
new solution taking the idea but do that now as we now know.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727

--- Comment #16 from Andrew Nugged  ---
(In reply to Victor Grousset/tuxayo from comment #14)
> > bug 29012 hasn't been released
> 
> So I don't know if that changes the strategy for this bug.

We SHOULD change strategy, and that's great - this means we don't need to make
complicated "reversal atomic updates" for the older wrong atomic update which
was very complicated and anyway dangerous. That's great.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758

--- Comment #13 from Martin Renvoize  ---
Created attachment 141834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141834&action=edit
Bug 31758: (follow-up) Remove fat margin-top

This removes the increased top margin appearing on subsection headings
after clicking through from search..

I'm not sure if we need it or not now.. the original feature it appeared
to help with doesn't work for me.. scroll to section doesn't happen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

--- Comment #40 from Martin Renvoize  ---
Added Marcel to CC list.. this patchset changes get_marc_host.. I know you're
close to that sub.. any chance you could validate the change here.. I'm afraid
my knowledge of that area has dropped away somewhat.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

Martin Renvoize  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31747] Round corners in boxes

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747

Lucas Gass  changed:

   What|Removed |Added

 Attachment #141790|0   |1
is obsolete||

--- Comment #9 from Lucas Gass  ---
Created attachment 141833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141833&action=edit
Bug 31747: Use page-section class, reduce CSS

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31747] Round corners in boxes

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747

Lucas Gass  changed:

   What|Removed |Added

 Attachment #141755|0   |1
is obsolete||

--- Comment #8 from Lucas Gass  ---
Created attachment 141832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141832&action=edit
Bug 31747: Give area-news box new staff design look

To test:
1. Apply patch
2. Regenerate staff CSS (
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface
)
3. Look at the #area-news element of the mainpage.
4. There should be no rounded corners and the box-shadow should be the same as
seen elsewhere ( i.e. patron details page )

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31747] Round corners in boxes

2022-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >