[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m CC||m.de.r...@rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- Fridolin: penalty points for not filling Assignee field. You should know. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #7 from Marcel de Rooy --- Not sure if a yellow button on a green form is the most optimal choice of colors. But its all a matter of taste :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What|Removed |Added Attachment #142223|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 142294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142294&action=edit Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31871] Due date not shown on items tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31871] Due date not shown on items tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Marcel de Rooy changed: What|Removed |Added Attachment #142207|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 142295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142295&action=edit Bug 31871: Date due not shown on items tab Changed ITEM_DAT to checkout in moredetail.tt Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31871] Due date not shown on items tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31422] Library limitations might cause data loss
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- If I am reading the comments, this patch only solves one issue but the description is broader than that? Am I correct? Or will the other issue(s) be addressed separately? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- FAIL Koha/Template/Plugin/Categories.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'limited' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31881] Link in MARC view does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 --- Comment #3 from Marcel de Rooy --- Not created here, but how ugly is this: [% IF ( subfiel.link ) %] subfiel ?? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31881] Link in MARC view does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy --- Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'. Not sure about this one. Are we really resolving the problem or just creating a workaround? You say that the query contains 'field'. Isnt that just misconfiguration? The framework column link should contain a valid index? Please clarify. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639
Thibaud Guillot changed:
What|Removed |Added
Attachment #122500|0 |1
is obsolete||
--- Comment #4 from Thibaud Guillot ---
Created attachment 142296
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142296&action=edit
Bug 28639: Embed see-from headings (from authorities) into bibliographic
records at OAI repository level
Test plan:
1. Create an authority with at least a 1XX$a and a 4XX$a, for instance:
100 $a Foo
400 $a Bar
2. Create a biblio and add a link to this authority using the
cataloguing plugin
3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox"
4. Go to OAI repository and display the previously created record (at
/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber}
5. The record should not contain see-from headings
6. Enable OAI-PMH:EmbedSeeFromInBibRecord
7. Go again to the OAI record, you should see alternative forms at the end of
the record
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31487] Add emails to message queue by longoverdue script options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639
Thibaud Guillot changed:
What|Removed |Added
Attachment #142296|0 |1
is obsolete||
--- Comment #5 from Thibaud Guillot ---
Created attachment 142297
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142297&action=edit
Bug 28639: Embed see-from headings (from authorities) into bibliographic
records at OAI repository level
Test plan:
1. Create an authority with at least a 1XX$a and a 4XX$a, for instance:
100 $a Foo
400 $a Bar
2. Create a biblio and add a link to this authority using the
cataloguing plugin
3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox"
4. Go to OAI repository and display the previously created record (at
/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber}
5. The record should not contain see-from headings
6. Run perl
installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl
7. Enable OAI-PMH:EmbedSeeFromInBibRecord
8. Go again to the OAI record, you should see alternative forms at the end of
the record
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31576] Cannot place hold even when AllowHoldPolicyOverride should allow it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Shouldnt this be pushed to the queue of the RMaint of 21.11 ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot changed: What|Removed |Added CC||thibaud.guil...@biblibre.co ||m --- Comment #6 from Thibaud Guillot --- (In reply to Julien Sicot (Univ. Rennes 2) from comment #0) > Hi, > > It could be interesting to enrich the bibliographic records exposed in OAI > with see-from headings, this would allow users who use koha with a discovery > tool to be able to manage, normalize and index some authorities data ? > > This is something that could be done directly in C4::Biblio::GetMarcBiblio > following the same method used for embedding items. > We could use an optional parameter like embed_items (embed_seefromheading) > and a function similar to C4::Biblio::EmbedItemsInMarcBiblio by reusing what > was made for zebra with EmbedSeeFromHeadings (bug #7417). > > Thanks for feedback, > Best > Julien Sicot > Systems Librarian, > Université Rennes 2 Thanks to you, I just rebase your proposal on master updated and add a atomic update file. I just call Koha::Filter::MARC::EmbedSeeFromHeadings on OAI server side to show or hide embed see-from headings. I could not test your development due to an error so I hope that the intended behaviour remains the same. Please let me know if not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #11 from Marcel de Rooy --- > The logic of all of this is tricky, makes sense in a certain light, any > complaints are for a new bug :-) LOL The module change makes sense to me, reading the tests is hard, you need to make a study of the logic in order to grasp whats going on there.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What|Removed |Added Attachment #141936|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 142298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142298&action=edit Bug 31644: Unit test Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What|Removed |Added Attachment #141937|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 142299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142299&action=edit Bug 31644: Check if subfield defined, not for truth To test: 1 - Define a new MARC Modification template with actions: Copy field 600$a to 942$0 2 - Define a new record like: LDR 00334nam a22001217a 4500 003 ff 005 20201102111604.0 008 201102bxxu| 00| 0 eng d 040 _ _ ‡cvsd 100 1 _ ‡012345‡aKnuth, Donal Ervin‡d1938 245 _ _ ‡012345‡aThe aty of computer programming‡cDonald E. Knuth 600 _ 0 ‡042‡aComputer programming‡9462 3 - Modify this record using the template above 4 - Note that entire field is copied to 942 5 - Apply patch 6 - Now only subfield 0 is copied Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What|Removed |Added Attachment #141938|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 142300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142300&action=edit Bug 31644: Add copy test and clarify some functions This patch adds a tst for copy without subfields. I also clarify what eachstep does so the next user/coder understands current behaviour Update existing or add new: In the case where the field/subfield exists we update, if we have two fields - one with the subfield, and one without, we add the subfield to the one without Copy field: - If given a subfield - we will add to existing fields in the record - If not given a subfield - we create an entirely new field The logic of all of this is tricky, makes sense in a certain light, any complaints are for a new bug :-) Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 --- Comment #15 from Marcel de Rooy --- Created attachment 142301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142301&action=edit Bug 31644: (QA follow-up) Add two missing shebang lines Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31715] Add missing German translations for language descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31715] Add missing German translations for language descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Marcel de Rooy changed: What|Removed |Added Attachment #141940|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 142302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142302&action=edit Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31715] Add missing German translations for language descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 --- Comment #7 from Marcel de Rooy --- Looks good to me. Just found this thing: INSERT INTO language_descriptions(subtag, type, lang, description) -VALUES ( 'la', 'language', 'de', 'Latein'); +VALUES ( 'la', 'language', 'de', 'Lateinisch'); It is in the installer file. But not in the dbrev. So could be considered as an inconsistency. Feel free to add a QA follow-up :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31715] Add missing German translations for language descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31465] Link system preference tabs to correct manual pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Marcel de Rooy changed: What|Removed |Added Attachment #141946|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 142303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142303&action=edit Bug 31738: Fix untranslatable string for recalls To test translation: 1. Apply patch and update your po files using: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation 2. Verify the string appears in po files now and translate it 3. Install the language To test functionality: 1. Turn on recalls 1.1. In Administration > Global system preferences, enable UseRecalls 1.2. Add recalls permissions in your circulation rules 2. In the OPAC, log in as a patron 3. Find a record with checked out items and place a recall 4. In the intranet, go to the patron file of the patron who currently has that item checked out --> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Martin Renvoize changed: What|Removed |Added Attachment #142243|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 142304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142304&action=edit Bug 31888: Define save button as primary in Elasticsearch mappings page Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow. Test plan : Go to Administration > Search engine configuration (Elasticsearch) => Check save button has class btn-primary and is yellow Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31850] Patron import: welcome email option style as list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Martin Renvoize changed: What|Removed |Added Attachment #142100|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 142305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142305&action=edit Bug 31850: Patron import: welcome email option style as list This patch corrects the markup around the "Send email to new patrons" checkbox on the patron import page. The list should be an ordered list, not an unordered list. To test, apply the patch and go to Tools -> Import patrons. In the "Welcome email" section, there should be no bullet point before the "Send email to new patrons" line. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31850] Patron import: welcome email option style as list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Martin Renvoize changed: What|Removed |Added Attachment #142092|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 142306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142306&action=edit Bug 31848: Correct margin and padding on action fieldset in aside This patch makes a minor modification to the padding and margin of nested in a .brief fieldset. This markup is seen most often in sidebar filter form. The change allows the submit button to line up better with other form fields. The patch also corrects and inconsistency by modifying the holds queue template so that the .action fieldset is inside the .brief fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - If necessary, place one or more holds for pickup at your logged-in library and rebuild the holds queue (misc/cronjobs/holds/build_holds_queue.pl) - Go to Circulation -> Holds queue. - The form should look correct. - Submit the form and check the form in the sidebar. It should look correct as well, with the submit button aligned left with the other form fields. - Check pages with similar sidebar forms, e.g.: - Administration -> Budgets -> Funds -> Planning - Circulation -> Overdues - Circulation -> Holds to pull - Acquisitions -> Invoices -> Search results Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31894] Extend Hold hooks with more actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #4 from Stefan Berndtsson --- I can't say why all the others did it this way. My hooks were just copies of the model used everywhere else. I can reason about a situation where it will likely matter. If the plugin forks/threads before doing its work, there is a chance that the originally stored object has been changed after the hook is called, but before the plugin has actually done its work. By fetching a new object, this is not the case. I also do remember having seen a situation where the state of $self after store was not the same as the newly fetched object, but I can't recall how or where this was the case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31894] Extend Hold hooks with more actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 Stefan Berndtsson changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #5 from Stefan Berndtsson --- Setting it back to Signed off, since nothing has changed in the patch, and clarification was provided. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31896] New Recall hook when adding recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 Stefan Berndtsson changed: What|Removed |Added Attachment #142279|0 |1 is obsolete|| --- Comment #5 from Stefan Berndtsson --- Created attachment 142307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142307&action=edit Bug 31896: New after_recall_action hook Hooks added: after_recall_action with new action add How to test: Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31896] New Recall hook when adding recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 Stefan Berndtsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Stefan Berndtsson --- Now passes QA in my system. Fixed file permissions and trailing whitespace. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Stefan Berndtsson changed: What|Removed |Added Attachment #142280|0 |1 is obsolete|| --- Comment #4 from Stefan Berndtsson --- Created attachment 142308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142308&action=edit Bug 31897: New before_index_action hook for Elasticsearch Hooks added: before_index_action with new action update How to test: Run tests in t/db_dependent/Koha/Plugins/Elasticsearch_Indexer_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Stefan Berndtsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Stefan Berndtsson --- Fixed file permissions and some trailing whitespace in this one as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 --- Comment #6 from Marcel de Rooy --- (In reply to Stefan Berndtsson from comment #5) > Fixed file permissions and some trailing whitespace in this one as well. If you only do cosmetic fixing, keep the previous signoff line and change status back to Signed off. No need to wait for another signoff imo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31895] New Account hook when adding credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 --- Comment #4 from Stefan Berndtsson --- I'm unclear about this one. I agree it looks strange. It comes from all other files. Holds_hooks.t, Circulation_hooks.t, Patron.t Barcode_transform_hooks.t and so on all have it in this order. I don't know why. I can change it easily of course, so it's not a big deal. There is also some unfixed traling whitespace in this one still remaining that I haven't updated yet. If I should swap the order of those two lines, I'll do that and fix whitespace at the same time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31806] Add 'page-section' to holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #3 from Martin Renvoize --- Created attachment 142309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142309&action=edit Bug 31806: Add page-section to holds tables This patch adds the page-section class to each holds view on reserve/request.pl Test plan 1) Find an biblio to test on and add holds items of different types and homebranches. 2) Work through each setting of the HoldsSplitQueue preference and confirm the page-sections appear as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31806] Add 'page-section' to holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31806] Add 'page-section' to holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #4 from Martin Renvoize --- I wasn't entirely sure where to put the page-section on this one.. especially given the various options for HoldsSplitQueue. At the moment, I've sectioned off each 'Split' as governed by HoldsSplitQueue.. but the argument could be made that the whole 'Existing holds' form could be a single page-section container? Also.. do the buttons look a bit crowded together for anyone else.. probabably a different bug entirely, but I think the markup there might be wrong too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31806] Add 'page-section' to holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #5 from Martin Renvoize --- Created attachment 142310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142310&action=edit Bug 31806: Add page-section container to existing holds This patch adds a page-section container around the existing holds content section -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31806] Add 'page-section' to holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #6 from Martin Renvoize --- OK.. after a little more testing I decided a container around the whole existing holds section feels like it makes more sense.. second patch attached does this so you can test one after the other if you'd like to see the distinction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31902] New: Inconsistent table formatting for 'Existing holds'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 Bug ID: 31902 Summary: Inconsistent table formatting for 'Existing holds' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, katrin.fisc...@bsz-bw.de, koha-bugs@lists.koha-community.org, testo...@bugs.koha-community.org Depends on: 31834 Blocks: 31833 The table(s) on reserves/request.pl for Existing holds have inconsistent formatting. The top header is missing a line beneath it for each table which is inconsistent with other pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 [Bug 31833] [Omnibus] Fix table inconsistencies https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 [Bug 31834] Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize changed: What|Removed |Added Blocks||31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31833] [Omnibus] Fix table inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 Martin Renvoize changed: What|Removed |Added Depends on||31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing holds'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 Martin Renvoize changed: What|Removed |Added Depends on|31834 |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 [Bug 31834] Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What|Removed |Added Blocks||31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize changed: What|Removed |Added Blocks|31902 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize changed: What|Removed |Added Depends on||30952 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What|Removed |Added Blocks||31834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 [Bug 31834] Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31833] [Omnibus] Fix table inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What|Removed |Added Blocks|31833 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 [Bug 31833] [Omnibus] Fix table inconsistencies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Martin Renvoize changed: What|Removed |Added Attachment #142281|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 142311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142311&action=edit Bug 31811: Add 'page-section' to MARC modification templates pages This patch adds "page-section" divs to the MARC modification templates template so that sections are properly defined and content has adequate contrast. Note: The patch includes indentation changes, so please ignore whitespace when checking the diff. To test, apply the patch and go to Cataloging -> MARC modification templates. The main content should be surrounded by a white box whether you're looking at the list of templates, the the action add/edit form. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #4 from Martin Renvoize --- `git diff -w` comes in handy with these paches ;p All looks good, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31903] New: Article requests: Edit URLs link missing in the New tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Bug ID: 31903 Summary: Article requests: Edit URLs link missing in the New tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Trivial fix. The format should be passed along like we do for the other tables. Found in 21.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31829] Change password form in patron account is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 Martin Renvoize changed: What|Removed |Added Attachment #142234|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 142312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142312&action=edit Bug 31829: Fix change password form alignment This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list. To test: 1. Apply patch 2. Pull up a patron record and go to 'Change password'. 3. Make sure the form now looks good. 4. Also check and make sure the form is still functional. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31829] Change password form in patron account is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 --- Comment #1 from Marcel de Rooy --- Created attachment 142313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142313&action=edit Bug 31903: Fix missing Edit URL link We need to pass format too for New tab (see Pending/Processing). Test plan: Include SCAN format in AR preferences. Check circ rules too. Add a new request. Check Circulation, Article requests, New tab. Verify that the Actions menu for a single row (!) does contain the option now. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Trivial one-liner, not widely used (yet). Self SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31904] New: The 'action' fieldset following another fieldset feels disparate to the form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31904 Bug ID: 31904 Summary: The 'action' fieldset following another fieldset feels disparate to the form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The 'action' fieldset that we use to contain our action buttons at the end of a form now feels distinct from the form itself.. the combined margin and padding of the two fieldsets one above the over leads to a lot of 'greyspace' between the 'box' of the form input section and the buttons in the action fieldset. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31904] The 'action' fieldset following another fieldset feels disparate to the form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31904 Martin Renvoize changed: What|Removed |Added Depends on||30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What|Removed |Added Blocks||31904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31904 [Bug 31904] The 'action' fieldset following another fieldset feels disparate to the form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31904] The 'action' fieldset following another fieldset feels disparate to the form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31904 --- Comment #1 from Martin Renvoize --- Created attachment 142314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142314&action=edit Example -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31905] New: Buttons lack spacing on Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Bug ID: 31905 Summary: Buttons lack spacing on Holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 31806 The buttons on the reserves/request.pl page have no spacing between them. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 [Bug 31806] Add 'page-section' to holds page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31806] Add 'page-section' to holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize changed: What|Removed |Added Blocks||31905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 [Bug 31905] Buttons lack spacing on Holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31905] Buttons lack spacing on Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 --- Comment #1 from Martin Renvoize --- Created attachment 142315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142315&action=edit Example -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing holds'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 Martin Renvoize changed: What|Removed |Added Depends on|30952 |31806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 [Bug 31806] Add 'page-section' to holds page -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What|Removed |Added Blocks|31902 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31806] Add 'page-section' to holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize changed: What|Removed |Added Blocks||31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #118 from Jonathan Druart --- (This is so AWESOME!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31759] Tabs vs Pills
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #10 from Martin Renvoize --- So the current tabs is inconsistent with the cards we're using elsewhere.. I think the question is really around how do we make it look like it belongs with all the other elements on the page rather than sticking out as different. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31750] Need more padding in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31750] Need more padding in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize changed: What|Removed |Added Attachment #142095|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 142316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142316&action=edit Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31750] Need more padding in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize changed: What|Removed |Added Attachment #142096|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 142317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142317&action=edit Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31750] Need more padding in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Solid improvements here.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31750] Need more padding in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #11 from Martin Renvoize --- It may be my eyes... but isn't the 'Cancel' link mis-aligned slightly.. apearing slightly above the content of the buttons in the toolbar? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31750] Need more padding in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #12 from Martin Renvoize --- Nah.. it's my eyes.. inspecting it suggests it's all the same padding etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31751] Breadcrumb style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- I think I just about prefer the old style rather than the new caret icon... but it's a close call for me.. I like them both better than the current `/` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31751] Breadcrumb style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31751] Breadcrumb style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #6 from Martin Renvoize --- Hate to say it, but I think I agree with David.. I thought I'd prefer the friendlier green for the modal headers/footers but actually I find the contrast between the linked green and the background of the header/footer not as nice... wonder if there's a slight middle ground. I'm not a big color pallet guru though.. I'd love to see our greens a little more standardized.. I prefer our bugzilla/koha-community.org/git.koha-community.org green to the green we use for the new search header bar for example though that doesn't really relate to this directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678
Kyle M Hall changed:
What|Removed |Added
Attachment #139816|0 |1
is obsolete||
Attachment #139943|0 |1
is obsolete||
Attachment #139944|0 |1
is obsolete||
--- Comment #21 from Kyle M Hall ---
Created attachment 142318
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142318&action=edit
Bug 22678: Use Koha::Logger for Mojolicious API logger
This patch adds Koha::Logger as the Mojolicious logging object
for the API Mojolicious app.
Test plan:
0. Apply the patch and koha-plack --restart kohadev
1. Add $c->app->log->debug('DEBUG') and
$c->app->log->warn('WARN') to a API controller like
Koha::REST::V1::Libraries
2. koha-plack --restart kohadev
3. Go to the API route tied to that API controller method
4. Look at /var/log/koha/kohadev/api-error.log
5. Note that 'WARN' appears but 'DEBUG' does not
Signed-off-by: Marcel de Rooy
[EDIT] Adding a context sub to Koha::Logger to get it working.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
