[Koha-bugs] [Bug 31966] New: Checkout / CheckIn book using restful api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31966 Bug ID: 31966 Summary: Checkout / CheckIn book using restful api Change sponsored?: --- Product: Koha Version: 22.05 Hardware: PC OS: Linux Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: ashanfar...@gmail.com CC: tomasco...@gmail.com I am developing an android application using Koha Restful API. the issue I am facing is that I cannot find anything API for item checkout(book issue) or item checkin(book return). I have installed the koha on ubuntu(Linux) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #5 from Aleisha Amohia --- Ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #4 from Aleisha Amohia --- Created attachment 142597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142597=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #6 from David Cook --- (In reply to David Cook from comment #5) > (I wrote a local generic OIDC client back in 2014 which I've carried all > these years. If Bug 31378 doesn't get in, I'll just keep using it. That > said, I have been thinking about implementing it as a Koha plugin. I wasn't > planning on working on that until Feb/March 2023, but perhaps I could move > up my schedule on that...) The one thing a Koha plugin can't do is an OIDC logout, but I don't think the googleopenidconnect can handle that either anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #88 from David Cook --- (In reply to David Cook from comment #87) > I've been saying for years that we need to standardize session creation, and > it's still true. Recently, I did a little patch for that at Bug 31050, but I haven't had an urgent reason to continue on it. It would be perfect for a situation like this though. (Of course, I thought of it while working on Koha plugins, other auth solutions, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
--- Comment #87 from David Cook ---
Comment on attachment 141807
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141807
Bug 31378: Add Auth mojo plugin
Review of attachment 141807:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=31378=141807)
-
::: Koha/REST/Plugin/Auth.pm
@@ +83,5 @@
> +'auth.session' => sub {
> +my ( $c, $patron ) = @_;
> +my $userid = $patron->userid;
> +my $cardnumber = $patron->cardnumber;
> +my $cgi= CGI->new;
I don't think that we should be using the CGI module in the Mojolicious REST
API, since we're not using CGI. This is hacky.
@@ +89,5 @@
> +$cgi->param( userid=> $userid );
> +$cgi->param( cardnumber=> $cardnumber );
> +$cgi->param( auth_client_login => 1 );
> +
> +my ( $status, $cookie, $session_id ) =
> C4::Auth::check_api_auth($cgi);
This is a suboptimal design for at least a couple of reasons: 1) it requires a
CGI object; 2) it creates a session for the API interface rather than the
OPAC/Staff interfaces; 3) it's not to purpose - we're not checking auth. We
know that we're just creating a new session.
I've been saying for years that we need to standardize session creation, and
it's still true.
In the meantime, a minimal session can be created as simply as this:
$session->param( 'number', $patron->borrowernumber );
$session->param( 'id', $patron->userid );
$session->param( 'cardnumber', $patron->cardnumber );
$session->param( 'firstname',$patron->firstname );
$session->param( 'surname', $patron->surname );
$session->param( 'branch', $patron->branchcode );
$session->param( 'branchname', $patron->library->branchname );
$session->param( 'flags',$patron->flags );
$session->param( 'emailaddress', $patron->email );
$session->param( 'ip', $session->remote_addr() );
$session->param( 'lasttime', time() );
$session->param( 'interface',$type);
Then you can either pass the $session object or the session ID as the return
value.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Keywords||additional_work_needed --- Comment #31 from Tomás Cohen Arazi --- Tests are failing due to this: https://jenkins.koha-community.org/job/Koha_Master_D10/887/ Please provide patches for the tests. Best regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #5 from David Cook --- (In reply to Aleisha Amohia from comment #4) > If Bug 31378 isn't far away I will wait for that and help you on that ticket. > > If we can't get that into Koha 22.11 then I'll revisit this. > Sounds like a plan to me. At the moment, I'm waiting on updated patches from Agustin. Hoping that he provides something ASAP, as I'm keen to see this get in. (I wrote a local generic OIDC client back in 2014 which I've carried all these years. If Bug 31378 doesn't get in, I'll just keep using it. That said, I have been thinking about implementing it as a Koha plugin. I wasn't planning on working on that until Feb/March 2023, but perhaps I could move up my schedule on that...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #25 from David Nind --- I've signed off, as everything works as per the test plan. For step 8, I added two item level holds for the same patron - I hope that is what was required. My only suggestion would be to change the "Details" column label to "Hold type". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What|Removed |Added Attachment #142587|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 142596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142596=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What|Removed |Added Attachment #142586|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 142595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142595=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What|Removed |Added Attachment #141474|0 |1 is obsolete|| --- Comment #13 from Aleisha Amohia --- Created attachment 142594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142594=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #86 from Aleisha Amohia --- *** Bug 31965 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Aleisha Amohia changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Aleisha Amohia --- If Bug 31378 isn't far away I will wait for that and help you on that ticket. If we can't get that into Koha 22.11 then I'll revisit this. *** This bug has been marked as a duplicate of bug 31378 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 David Nind changed: What|Removed |Added Attachment #142576|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 142593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142593=edit Bug 31952: Fix broken layout on system pref search TO test: 1. Do an empty system pref search 2. Layout is broken. 3. Apply patch, restart_all 4. Do another empty system pref search, the layout should be fixed. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 David Nind changed: What|Removed |Added Attachment #142585|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 142592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142592=edit Bug 31963: Only show hold fee msg on OPAC if patron will be charged This patch ensures HoldFeeMode is considered when displaying a message to patrons on the OPAC that says they'll be charged a hold fee when placing or collecting the hold. When HoldFeeMode is set to not_always or "only if all items are checked out and the record has at least one hold already" then the hold fee message should only show if all items on the record are checked out, AND the record has at least one hold already - both of these conditions must be met. To test: 1. Go to Administration -> Patron categories 2. Edit your patron category and give a hold fee of $1. 3. Go to Administration -> System preferences and search for HoldFeeMode. Set to 'only if all items are checked out and the record has at least one hold already' if not already set. Keep this tab open. 4. In another tab, open the OPAC. 5. Search the OPAC for a record with one item which is NOT checked out. 6. Go to place a hold on this record. Confirm you see a message saying that you will be charged a hold fee, even though not all items are checked out and the record does not have a hold --> This is the bug. 7. Apply patch and restart services. Items available, no holds placed 8. Repeat steps 5-6. This time, you should NOT see the hold fee message. Items available, holds placed 9. In your staff interface tab, find the same record. 10. Place a hold for a different patron on this record. 11. In your OPAC tab, find this record again and go to place a hold. You should NOT see the hold fee message. No items available, no holds placed 12. In your staff interface tab, cancel the hold placed on this record. 13. Check out the item to a different patron. 14. In your OPAC tab, find this record again and go to place a hold. You should NOT see the hold fee message. No items available, holds placed 15. In your staff interface tab, keep the item checked out to another patron. 16. Place a hold for a third patron on this record. 17. In your OPAC tab, find this record again and go to place a hold. You SHOULD see the hold fee message. Multiple holds 18. Search the OPAC for a record. Make sure your search will return more than one result, including our test record. 19. Check the checkbox for our test record, plus another record where the item is not checked out. 20. Click the Place hold button to place holds on all of our selected records. You should only see the hold fee message above our test record. 21. In your staff interface tab, test setting HoldFeeMode to the other values and confirm the hold message shows on the OPAC as expected. 22. Confirm tests pass t/db_dependent/Reserves/GetReserveFee.t Sponsored-by: Horowhenua Libraries Trust Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |dc...@prosentient.com.au |y.org | --- Comment #3 from David Cook --- (In reply to Aleisha Amohia from comment #2) > Thanks David, I wasn't aware of Bug 31378. > > I do know that $issuer needs a system preference too, I was going to do that > separately. > > We have a partner library that needs to use OpenID Connect with Azure so > perhaps this could be the interim fix while Bug 31378 gets over the line? I suppose that's up to the RM, so best to send him an email. If he's OK with it, I could QA it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Created attachment 142591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142591=edit Screenshot - new subscription form A couple of things I noted (see the screenshot): 1. For When receiving this serial: when "Create an item record" is selected, the Collection and Item type fields are misaligned. 2. For vendor: no space after the closing bracket and before the search icon, also there is a space between the end of the form field and the bracket which looks odd. 3. For Record: no space after the closing bracket and before "Required", also there is a space between the end of the form field and the bracket which looks odd. 4. "Search for record" and "Create record" placement: looks "off" where they are at the moment - maybe should be aligned under the input field/help text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 David Nind changed: What|Removed |Added Attachment #142578|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 142590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142590=edit Bug 31910: Fix list and add page-section to request-article.tt To test: 1. Apply patch 2. Look at article request form and ensure the fields and labels look good. 3. Ensure there are no more bullet points on the list. 4. Make sure the page-section div around the item selection looks good. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #2 from Aleisha Amohia --- Thanks David, I wasn't aware of Bug 31378. I do know that $issuer needs a system preference too, I was going to do that separately. We have a partner library that needs to use OpenID Connect with Azure so perhaps this could be the interim fix while Bug 31378 gets over the line? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31965 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31378 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- I think that the community are planning to replace this functionality soon with Bug 31378. I'm not a fan of the googleopenidconnect script myself (for lots of reasons), but I suppose there is no harm in updating it. You'd need to add a system preference for the "issuer" as well, and to rewrite with a patch or with JS anything in the OPAC that says Google I suppose... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #4 from David Nind --- After applying the patch, I'm getting an error trace when I go to access the transfer page: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt line 275: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #43 from David Nind --- Have signed off based on the follow-up, and that semicolons will be addressed in another bug. Thanks Heather for your great comments! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31965] New: Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Bug ID: 31965 Summary: Put OpenID discovery doc URL in a system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Theoretically we could authenticate with OpenID Connect and any other identity provider than Google using the existing googleopenidconnect script, this would be helped if the discovery doc URL could be provided with a system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What|Removed |Added Attachment #142530|0 |1 is obsolete|| --- Comment #42 from David Nind --- Created attachment 142589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142589=edit Bug 13600: (follow-up) Add separator between different series fields This patch checks for an upcoming series tag, and adds a separator if one is found Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What|Removed |Added Attachment #140705|0 |1 is obsolete|| --- Comment #41 from David Nind --- Created attachment 142588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142588=edit Bug 13600: XSLT - 8xx not showing if there is no 4xx This patch adjusts XSLT so that series tag displays if any 440,490,800,810,830 is present It also adjusts 8xx to display even if 490 ind 1 = 1 is not present To test: 1 - Check records with multiple series tag 2 - Confirm display is correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #22 from Lari Taskula --- (In reply to Lucas Gass from comment #19) > I do wonder if there is still going to be some confusion on what the > dropdown does. Do we need a hint or a tip to help describe what the dropdown > is going to do? I think the dropdown values themselves explain what it does. If you think more detailed description is needed, feel free to make a suggestion. On another note I've squashed the follow-ups into the main patch and updated test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #85 from David Cook --- I'm not too worried about the JSON editor at this point. More of a nice to have but not essential. Agustin, are we going to get an updated version before the end of this week? I could make time to QA this before the soft feature freeze this Friday. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Attachment #142114|0 |1 is obsolete|| --- Comment #21 from Lari Taskula --- Created attachment 142587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142587=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Attachment #142102|0 |1 is obsolete|| Attachment #142115|0 |1 is obsolete|| Attachment #142116|0 |1 is obsolete|| Attachment #142117|0 |1 is obsolete|| Attachment #142118|0 |1 is obsolete|| --- Comment #20 from Lari Taskula --- Created attachment 142586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142586=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28577] Add column for copynumber on overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 --- Comment #4 from David Nind --- In admin/columns_settings.yml columnname is spelt incorrectly - spelt as columname (In reply to Katrin Fischer from comment #3) > (In reply to David Nind from comment #2) > > Created attachment 142090 [details] > > Screenshots of column display and settings table > > > > Hi Katrin. > > > > After the patch is applied (see attached screenshots): > > > > - Item type is displaying in the copy number column, and copy number is > > displaying in the item type column. > > > > - There is no column name label in the table settings (and the wrong columns > > are toggled). > > > > David > > Hm, I wonder what I did there, will have a look. For the column name label not displaying, columnname is spelt incorrectly in admin/columns_settings.yml - spelt as columname. (Spotted by Lucas for bug 21381.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What|Removed |Added Text to go in the||This patch ensures release notes||HoldFeeMode is considered ||when displaying a message ||to patrons on the OPAC that ||says they'll be charged a ||hold fee when placing or ||collecting the hold. || ||When ||HoldFeeMode is set to ||not_always or "only if all ||items are checked out and ||the record has at least one ||hold already" then the hold ||fee message should only ||show if all items on the ||record are checked out, AND ||the record has at least one ||hold already - both of ||these conditions must be ||met. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 --- Comment #1 from Aleisha Amohia --- Created attachment 142585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142585=edit Bug 31963: Only show hold fee msg on OPAC if patron will be charged This patch ensures HoldFeeMode is considered when displaying a message to patrons on the OPAC that says they'll be charged a hold fee when placing or collecting the hold. When HoldFeeMode is set to not_always or "only if all items are checked out and the record has at least one hold already" then the hold fee message should only show if all items on the record are checked out, AND the record has at least one hold already - both of these conditions must be met. To test: 1. Go to Administration -> Patron categories 2. Edit your patron category and give a hold fee of $1. 3. Go to Administration -> System preferences and search for HoldFeeMode. Set to 'only if all items are checked out and the record has at least one hold already' if not already set. Keep this tab open. 4. In another tab, open the OPAC. 5. Search the OPAC for a record with one item which is NOT checked out. 6. Go to place a hold on this record. Confirm you see a message saying that you will be charged a hold fee, even though not all items are checked out and the record does not have a hold --> This is the bug. 7. Apply patch and restart services. Items available, no holds placed 8. Repeat steps 5-6. This time, you should NOT see the hold fee message. Items available, holds placed 9. In your staff interface tab, find the same record. 10. Place a hold for a different patron on this record. 11. In your OPAC tab, find this record again and go to place a hold. You should NOT see the hold fee message. No items available, no holds placed 12. In your staff interface tab, cancel the hold placed on this record. 13. Check out the item to a different patron. 14. In your OPAC tab, find this record again and go to place a hold. You should NOT see the hold fee message. No items available, holds placed 15. In your staff interface tab, keep the item checked out to another patron. 16. Place a hold for a third patron on this record. 17. In your OPAC tab, find this record again and go to place a hold. You SHOULD see the hold fee message. Multiple holds 18. Search the OPAC for a record. Make sure your search will return more than one result, including our test record. 19. Check the checkbox for our test record, plus another record where the item is not checked out. 20. Click the Place hold button to place holds on all of our selected records. You should only see the hold fee message above our test record. 21. In your staff interface tab, test setting HoldFeeMode to the other values and confirm the hold message shows on the OPAC as expected. 22. Confirm tests pass t/db_dependent/Reserves/GetReserveFee.t Sponsored-by: Horowhenua Libraries Trust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21381] Add serial enumeration to circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What|Removed |Added Attachment #142573|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 142584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142584=edit Bug 21381: (follow-up) fix typo in columns setting yml Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21381] Add serial enumeration to circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What|Removed |Added Attachment #142035|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 142583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142583=edit Bug 21381: (follow-up) Fix table configuration for new column The new column was added to the table settings configuration. To test: * Make sure the column shows up in the columns menu of the table in the staff interface. * Verify it can be hidden/unhidden correctly using the menu or the table setings. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21381] Add serial enumeration to circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What|Removed |Added Attachment #142033|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 142582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142582=edit Bug 21381: Add serial enumeration to circulation/checkout history * Set readinghistory and intranetreadinghistory to Allow * Check out some items and return some. At least one item should have serial enumeration set to something * Go to OPAC > patron account > checkout history * Verify the Vol info shows the same as on the detail page. * Go to staff interface > patron account > circulation history * Verify the Vol info shows correctly there as well. Bug 21381: Add serial enumeration to circulation/checkout history https://bugs.koha-community.org/show_bug.cgi?id=31281 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21381] Add serial enumeration to circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #1 from Lucas Gass --- Created attachment 142581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142581=edit Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What|Removed |Added Patch complexity|--- |String patch CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31495] Allow viewing CMS pages when enforcing GDPR policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Katrin Fischer changed: What|Removed |Added Summary|Allow opac-page when|Allow viewing CMS pages |enforcing GDPR policy |when enforcing GDPR policy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #7 from Katrin Fischer --- Created attachment 142580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142580=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Katrin Fischer changed: What|Removed |Added Attachment #141401|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 142579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142579=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #13 from David Nind --- (In reply to Katrin Fischer from comment #10) > (In reply to David Nind from comment #9) > > Created attachment 142562 [details] > > Screenshot - list of rotating collections > > > > Something minor (and maybe for another bug) - do we need to show 'Showing 1 > > to 2 of 2 entries' on a separate line? See the screenshot. > > > > I think on other screens (such as list of items for a record) we show on the > > same row as the DataTables header. > > I think this has to do with today's changes to the datatable controls, > unrelated to this bug. I see the same on the libraries page. > > I kinda like it, because the inofrmation was often missed before, but not > sure if intentional or not. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 --- Comment #1 from Lucas Gass --- Created attachment 142578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142578=edit Bug 31910: Fix list and add page-section to request-article.tt To test: 1. Apply patch 2. Look at article request form and ensure the fields and labels look good. 3. Ensure there are no more bullet points on the list. 4. Make sure the page-section div around the item selection looks good. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694
--- Comment #5 from Katrin Fischer ---
Maybe we should remove the translations here?
-overlay_rules_presets[_("Overwrite")] = {
+overlay_rules_presets[_("overwrite")] = {
So maybe:
-overlay_rules_presets[_("Overwrite")] = {
+overlay_rules_presets["Overwrite"] = {
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20732] Display the note tab for records without items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20732 Katrin Fischer changed: What|Removed |Added Summary|Display the note tab for|Display the note tab for |records without items. |records without items Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20732] Display the note tab for records without items.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20732 --- Comment #2 from Katrin Fischer --- I like both ideas, not sure if Elaine's suggestion would need to be a system preference. Removing the (0) would also be interesting for libraries using AlternateHoldingsField. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12709] Send a custom email to some or all patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 --- Comment #8 from Katrin Fischer --- Maybe we should rename this "Move patron-emailer functionality into core"? Then one could manually send custom notices manually and next step could be to implement scheduling in the GUI maybe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31960] Information on job detail view is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Lucas Gass --- It is likely happening with other jobs. The problem lines are these ones: Report: [% IF job.status != 'new' %][% PROCESS 'report' %][% END %] Detailed messages: [% IF job.status != 'new' %][% PROCESS 'detail' %][% END %] We are processing those blocks inside of a list element and those blocks contain a bunch of their own HTML, including h2 and h3. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #36 from Katrin Fischer --- (In reply to Martin Renvoize from comment #35) > I don't understand how running the exact same SQL as is in the update itself > can resolve this problem. Fixed on bug 31673. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #81 from Katrin Fischer --- Sad to see this one stuck again. At the moment also doesn't apply cleanly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31964] Missing manpage for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31964 --- Comment #1 from Tomás Cohen Arazi --- Not sure how we missed that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Tomás Cohen Arazi changed: What|Removed |Added Blocks||31964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31964 [Bug 31964] Missing manpage for koha-z3950-responder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31964] Missing manpage for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31964 Tomás Cohen Arazi changed: What|Removed |Added Depends on||13937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31964] New: Missing manpage for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31964 Bug ID: 31964 Summary: Missing manpage for koha-z3950-responder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 142577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142577=edit Bug 25716: (QA follow-up) Make sure a comment doesn't break tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 --- Comment #2 from Lucas Gass --- Created attachment 142576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142576=edit Bug 31952: Fix broken layout on system pref search TO test: 1. Do an empty system pref search 2. Layout is broken. 3. Apply patch, restart_all 4. Do another empty system pref search, the layout should be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Lucas Gass --- This is the same problem as Bug 31886. I neglected to update local_use.pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25936] Notify users if their password has changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Katrin Fischer changed: What|Removed |Added Text to go in the||When the system preference release notes||NotifyPasswordChange is set ||to 'Notify' a notification ||will be sent to the user ||when their password is ||changed. The new ||notification uses the ||letter code PASSCHANGE. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #79 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #30 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 142575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142575=edit Bug 23012: get_lostreturn_policy returns a scalar On commit 4d994773f83468b561896939f16131d0332d9cfc Koha::Item->_set_found_trigger gets the call to get_lostreturn_policy() changed so it expects a hashref instead of the scalar it returns. This patch adjusts it back. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What|Removed |Added Version|22.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] New: Only show reserve fee message on OPAC if they will actually be charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Bug ID: 31963 Summary: Only show reserve fee message on OPAC if they will actually be charged Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Hold fees can be set at the patron-category level, and if a patron who could be charged a reserve fee logs into the OPAC and tries the place a hold, a message about being charged a hold fee will show. This message does not take HoldFeeMode into consideration. When HoldFeeMode is set to "any time a reserve is collected" the message will be "You will be charged a hold fee of $X when you collect this item", but if HoldFeeMode is set to anything else, the message will be what we are seeing "You will be charged a hold fee of $X for placing this hold". This message can be a bit unexpected, especially if HoldFeeMode is set so hold fees should only be charged if all items are checked out and the record has at least one hold already. We don't expect we should see the message if there are items available and no holds on the record, when HoldFeeMode is set this way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Katrin Fischer changed: What|Removed |Added Attachment #140975|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 142574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142574=edit Bug 31609: JavaScript error on Additional contents main page This patch makes a minor modification to the JavaScript on the Additional contents page to prevent an error when there are no tabs present on the page. The JS needs an additional check so that it doesn't run when there are no tabs. To test you should have more than one language installed. - Before the patch, you would see a JavaScript error in the console: "Uncaught TypeError: can't access property "hash", firstTab[0] is undefined." - Apply the patch and go to Tools -> Additional contents. - With the patch applied there should be no error on the additional contents main page. - Try creating or editing additional contents entries to confirm that the interface still works correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #11 from Katrin Fischer --- With this patch, all 3, Pages, News and HTML customizations on longer show the error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21381] Add serial enumeration to circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 --- Comment #5 from Lucas Gass --- Created attachment 142573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142573=edit Bug 21381: (follow-up) fix typo in columns setting yml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #10 from Katrin Fischer --- I can see the JavaScript error as dscribed on Tools > News: Uncaught TypeError: firstTab[0] is undefined http://localhost:8081/cgi-bin/koha/tools/additional-contents.pl?category=news:1653 jQuery 13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer changed: What|Removed |Added Text to go in the|This adds a way to print|This adds a way to print release notes|information about renewals |information about renewals |to notices with Template|to notices with Template |Toolkit. |Toolkit. This includes the |Documentation: |numbers for used renewals, |https://wiki.koha-community |allowed renewals and |.org/wiki/Notices_with_Temp |remaining renewals and |late_Toolkit#Example:_Circu |more. |lationRules.Renewals|Documentation: ||https://wiki.koha-community ||.org/wiki/Notices_with_Temp ||late_Toolkit#Example:_Circu ||lationRules.Renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer changed: What|Removed |Added Text to go in the||This adds a way to print release notes||information about renewals ||to notices with Template ||Toolkit. ||Documentation: ||https://wiki.koha-community ||.org/wiki/Notices_with_Temp ||late_Toolkit#Example:_Circu ||lationRules.Renewals Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180
--- Comment #14 from Katrin Fischer ---
(In reply to Marie-Luce Laflamme from comment #13)
> The IntranetUserJS syspref work around isn't working in Koha 22.05+ version.
The handling for cookies has changed, this appears to work on master:
$(document).ready(function() {
if (typeof script !== 'undefined' &&
Cookies.get("issues-table-load-immediately-" + script) !== "true") {
Cookies.set("issues-table-load-immediately-" + script, true, { expires:
365, sameSite: 'Lax' });
}
});
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Caroline Cyr La Rose changed: What|Removed |Added Attachment #142569|0 |1 is obsolete|| --- Comment #4 from Caroline Cyr La Rose --- Created attachment 142572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142572=edit Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag" To get to the string in the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title) --> a little popup thing (tooltip?) appears with "Delete this Tag" 4. Open the developper tools inspector in your browser 5. Click on the delete tag button --> the image alt text is "Delete this Tag" 6. Repeat the same check in the authorities editor 7. Apply patch 8. All tooltips and alt text should read correctly now Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 --- Comment #3 from Lucas Gass --- Rebased for current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 Lucas Gass changed: What|Removed |Added Attachment #142000|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 142571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142571=edit Bug 31671: Add print slip button to transfer page To test: 1. Apply patch 2. Go to Circulation / Transfer 3. Try transfering some items and notice the 'Print transfer slip' button 4. Try clicking on it and make sure it generates correctly and with the correct information on the slip -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Caroline Cyr La Rose changed: What|Removed |Added Attachment #142568|0 |1 is obsolete|| --- Comment #2 from Caroline Cyr La Rose --- Created attachment 142570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142570=edit Bug 31876: Fix capitalization "Click to Expand Tag" The string "Click to Expand this Tag" appears in addbiblio.tt a couple of times. It should be "Click to expand this tag". To get to the string for the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER) --> a little popup thing (tooltip?) appears with "Click to Expand this Tag" 4. Go to Administration > Global system preferences 5. Search for advancedMARCeditor 6. Change the value to "Don't show" 7. Click "Save all Cataloging preferences" 8. Go back to Cataloging > New record 9. Hover the mouse cursor over the tag number (e.g. 001) --> a little popup thing (tooltip?) appears with " Click to Expand this Tag" 10. Go to Authorities > new record 11. Hover over the desription of a tag which subfields are collapsed --> verify the tooltip appears with "Click to Expand this Tag" 12. Apply patch, all occurrences should be fixed now. https://bugs.koha-community.org/show_bug.cgi?id=31907 Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31669] Improve support for ILL "cost" field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31669 --- Comment #1 from Katrin Fischer --- We use the cost field in our backend for the fee that can be charged to the patron for the ILL request. I am not sure how support for backend would be implemented as not all ILL systems might charge/have costs. Maybe this should cover the 'make editable'? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
