[Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #31 from David Cook --- FYI on October 12th I updated our OAI-PMH servers to honour OpacSuppression and OpacHiddenItems, so we've been running it in production for nearly a month. So far so good. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32064] Add missing test to template permission calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064 --- Comment #3 from David Cook --- Thanks, David :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #106 from David Cook --- Overall, I think that we're on the right track, and I'm so excited for this feature. Thanks for all the work, Theke. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- (In reply to Kyle M Hall from comment #3) > * I can only find my logged in user when searching for users to add to an > agreement ( http://192.168.1.20:8081/cgi-bin/koha/erm/agreements/add ) (In reply to Jonathan Field from comment #4) > On Point 1 Kyle, when you add users to an Agreement you ONLY see users who > have the ERM permission, that is by design so that you do not retrieve many > regular patrons. Is that what you are seeing or something else? Works as expected when having multiple users with ERM permission or superlibrarians. Also tested addition multiple users and custom roles via the AV. And basic creation of license, package, title Any guidelines to test this? Beside from filling every field and being creating to try to find edge cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #105 from David Cook --- I appreciate the replacement of "Authentication provider" being changed to "Identity provider" and "tranverse_hash" being changed to "traverse_hash", but it looks like every other issue I described last time is still present in the Gitlab version... I have to fail this again, because several of the features don't work. Before I test this again, I'd like someone to confirm that they've looked at my "FIXME" comments, and fixed them (or at least provide a reason for not fixing them). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook changed: What|Removed |Added Status|Patch doesn't apply |Failed QA --- Comment #104 from David Cook --- Test plan 1: 1. apt install libmojolicious-plugin-oauth2-perl 2. koha-upgrade-schema kohadev 3. restart_all Test plan 2: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Identity providers" 3. Click "New identity provider" (#NOTE: UI formatting looks OK on Koha 22.06, but I wonder what it'll look like on Koha 22.11...) (#FIXME: "Add default OAuth..." buttons still don't work if you make any changes in the text box before pressing the button.) (#FIXME: There's still not enough help text on the UI to explain how to fill it all in.) (#NOTE: It probably makes more sense to default to "OIDC" than "OAuth" since the former is more common with common identity providers) 4. Enter relevant details and click "Submit" (#FIXME: "Code" shouldn't be able to contain non-alphanumeric characters) (#FIXME: Putting in garbage values causes the page to return to /cgi-bin/koha/admin/identity_providers.pl with no error messages) (#FIXME: There needs to be a warning that integration won't work until after an application restart...) 5. Click on "Manage Domains" (#FIXME: It's not clear what "domains" means in this context. It should say something like "Identity provider email domains") 6. Click "Edit" on the default domains (#FIXME: The "Default library" and "Default category" are initially set to empty, but you can't set them to empty in the "Edit" interface) (#FIXME: The breadcrumb says "Domains for" instead of "Domains for Test") 7. koha-plack --restart kohadev 8. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha (#FIXME: When authentication fails, the end user sees the following message: There was an error authenticating to external identity provider Can't call method "auto_register" on an undefined value at /kohadevbox/koha/Koha/REST/Plugin/Auth/IdP.pm line 66. ) 9. Change "Identity provider" default domain to "Auto register" 10. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha (#FIXME: When authentication fails, the end user sees the following message: There was an error authenticating to external identity provider Can't call method "auto_register" on an undefined value at /kohadevbox/koha/Koha/REST/Plugin/Auth/IdP.pm line 66. ) (#FIXME: The auto register feature doens't work. It needs to be fixed.) 11. Create a Koha user to match your IdP user 12. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha 13. Login succeeds 14. Kill IdP session and logout of Koha 15. Change default domain to "Update on login" 16. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha (#FIXME: The update on login feature doesn't work. It needs to be fixed.) 17. Change default domain to "Allow staff" logins 18. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha 19. Note that you get a normal "Error: You do not have permission to access this page" message. That's good. 20. Add "catalogue" permission to the Koha user 21. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha 22. Login succeeds 23. In an Incognito window or different browser, go to http://localhost:8081, and try logging in with a user that doesn't exist in Koha (#FIXME: When authentication fails, the end user sees the following message: Error: Session timed out. Please log in again There was an error authenticating to external identity provider Exception 'Koha::Exceptions::Auth::Unauthorized' thrown 'External auth user cannot access resource' with code => 401 ) 24. Add a new domain for that matches the email domain of your IdP/Koha user. 25. Mark "Allow opac" and "Allow staff" as "No" 26. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha (#FIXME: Koha login happens even though the specific domain says it shouldn't be allowed) 27. In an Incognito window or different browser, go to http://localhost:8081, and try logging in with a user that does exist in Koha (#FIXME: Koha login happens even though the specific domain says it shouldn't be allowed) -- I imagine that there are other problems, but I think that's a fairly thorough analysis of the core functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs
[Koha-bugs] [Bug 32064] Add missing test to template permission calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064 David Nind changed: What|Removed |Added Attachment #142904|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 142913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142913=edit Bug 32064: Add test data for all report subpermissions This patch adds test data to prove that all authorizations for subpermissions are set when only a top level flag is set. To test: 0) Apply patch 1) prove ./t/Koha/Auth/Permissions.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32064] Add missing test to template permission calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #103 from David Cook --- I'll still keep testing to see what I can see though... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #102 from David Cook --- Started trying to fix the merge conflicts but looks like there's a fair number. This is something that should've been done before moving it to "Needs Signoff" I reckon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #101 from David Cook --- Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Auto-merging installer/data/mysql/mandatory/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/userpermissions.sql error: could not apply b466baa415... Bug 31378: Add manage_authentication_providers permission Resolve all conflicts manually, mark them as resolved with "git add/rm ", then run "git rebase --continue". You can instead skip this commit: run "git rebase --skip". To abort and get back to the state before "git rebase", run "git rebase --abort". Could not apply b466baa415... Bug 31378: Add manage_authentication_providers permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #100 from David Cook --- Looks like we're 547 commits behind master... and for some reason "qa" think the "qa-prev-commit" is 1 commit behind. Getting a number of failures: testing 1 commit(s) (applied to 46c299f 'd6 Bug 31378: Rename Auth Provider to') Processing files before patches Configure idp routes=>| 10 / 10 (100.00%) Processing files after patches |>| 10 / 10 (100.00%) OK Koha/Auth/Client.pm OK Koha/REST/V1/Auth/Identity/Provider/Domains.pm OK api/v1/swagger/definitions/identity_provider.yaml OK api/v1/swagger/definitions/identity_provider_domain.yaml OK api/v1/swagger/paths/auth.yaml OK installer/data/mysql/atomicupdate/bug_31378.pl OK installer/data/mysql/kohastructure.sql FAIL t/db_dependent/Koha/REST/Plugin/Auth/IdP.t FAIL file permissions File must have the exec flag FAIL forbidden patterns forbidden pattern: trailing space char (line 55) forbidden pattern: trailing space char (line 123) FAIL t/db_dependent/api/v1/idp.t FAIL file permissions File must have the exec flag FAIL forbidden patterns forbidden pattern: trailing space char (line 195) forbidden pattern: trailing space char (line 258) forbidden pattern: trailing space char (line 301) forbidden pattern: Use of Data::Printer (line 310) forbidden pattern: Use of Data::Printer, should only be used for devlopment purpose (line 310) FAIL spelling wiht ==> with wihtout ==> without FAIL valid Can't locate Crypt/OpenSSL/RSA.pm in @INC (you may need to install the Crypt::OpenSSL::RSA module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/ perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) FAIL t/lib/IdP/ExternalIdP.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Processing additional checks * Commit title does not start with 'Bug X: ' - c649ebc111 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #99 from David Cook --- Ok. Starting testing now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #44 from David Cook --- Want to work on this since it's fresh in the mind... but better work on OIDC instead... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #43 from David Cook --- (In reply to David Cook from comment #42) > I like a lot of things from these patches, but I reckon they could probably > be broken up into a number of smaller issues. - Refactor C4::Auth::getuserflags() and move to Koha::Auth::Permissions->get_flags() with unit tests - Refactor Koha::Auth::Permissions->get_authz_from_flags to build a fully populated authz hash, and then create Koha::Auth::Permissions->get_template_authz_from_authz() - Refactor C4::Auth::haspermission() (this is actually used more extensively through Koha than I originally thought...) - Update Acquisition.pm, Budgets.pm, about.pl, and other users of authorization data checks outside of the initial AuthZ check on page load... The goal of the above is to centralize the business logic of permission/authorization checks in Koha, so we're not repeating complex code structures throughout the app. - Finally, move "flags" column into "user_permissions" table (that said, this could have unexpected consequences for borrower_modifications and deletedborrowers...)(this also will have consequences with manual SQL and tests) The goal of the above is to free us from the bit-packed "flags" integer and separate sub-permission table, so that it's easier to create and organise flags/permissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Attachment #139110|0 |1 is obsolete|| --- Comment #34 from Aleisha Amohia --- Created attachment 142912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142912=edit Bug 30358: (follow-up) stripWhitespaceChars subroutine and tests To test: Confirm test plan above still works as expected and tests pass in t/Koha_MetadataRecord.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Attachment #137457|0 |1 is obsolete|| --- Comment #33 from Aleisha Amohia --- Created attachment 142911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142911=edit Bug 30358: (follow-up) Put multiple subfields fix on auth side Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Attachment #137456|0 |1 is obsolete|| --- Comment #32 from Aleisha Amohia --- Created attachment 142910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142910=edit Bug 30358: (follow-up) Consider field has multiple subfields of same key To test: 1) Click the clone subfield button to make multiple subfields with the same key, i.e. 500$a$a$a 2) Save the record and confirm that the fields contain the correct data after whitespaces are stripped. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Attachment #137455|0 |1 is obsolete|| --- Comment #31 from Aleisha Amohia --- Created attachment 142909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142909=edit Bug 30358: (follow-up) Clarify syspref wording about fields affected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Attachment #137454|0 |1 is obsolete|| --- Comment #30 from Aleisha Amohia --- Created attachment 142908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142908=edit Bug 30358: (follow-up) Fixing tests and including for inner newlines Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Attachment #137453|0 |1 is obsolete|| --- Comment #29 from Aleisha Amohia --- Created attachment 142907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142907=edit Bug 30358: (follow-up) Inner newlines should be replaced with a space Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Attachment #137452|0 |1 is obsolete|| --- Comment #28 from Aleisha Amohia --- Created attachment 142906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142906=edit Bug 30358: (follow-up) Also strip inner newlines This patch amends the StripWhitespaceChars system preference to also strip inner newlines (line breaks and carriage returns) when enabled. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Attachment #137451|0 |1 is obsolete|| --- Comment #27 from Aleisha Amohia --- Created attachment 142905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142905=edit Bug 30358: Strip leading/trailing whitespace characters from input fields when cataloguing This enhancement adds a system preference StripWhitespaceChars which, when enabled, will strip leading and trailing whitespace characters from all fields when cataloguing both bibliographic records and authority records. Whitespace characters that will be stripped are: - spaces - newlines - carriage returns - tabs To test: 1. Apply patch and install database updates 2. Go to Administration, system preferences, find the new StripWhitespaceChars preference. It should be "Don't strip" by default. Change it to "Strip". 3. Search for a biblio record and edit it. Put some leading or trailing whitespace characters in input fields and textarea fields and save. 4. Confirm these characters are removed when you save the record. 5. Repeat steps 3 and 4 for authority records. 6. Confirm tests pass t/db_dependent/Biblio/ModBiblioMarc.t Sponsored-by: Educational Services Australia SCIS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31886] No side menu when searching for syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #14 from Victor Grousset/tuxayo --- Ok, I wasn't sure if a follow-up could be made in the existing tickets: Bug 32065 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32065] Invalid YAML for some system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Victor Grousset/tuxayo changed: What|Removed |Added Summary|Invalid for some system|Invalid YAML for some |preferences |system preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||32065 Depends on|32065 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 [Bug 32065] Invalid for some system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31886] No side menu when searching for syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||32065 Depends on|32065 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 [Bug 32065] Invalid for some system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32065] Invalid for some system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Victor Grousset/tuxayo changed: What|Removed |Added Blocks|31886, 31952| Depends on||31886, 31952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 [Bug 31952] Sending an empty system preference search breaks layout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Victor Grousset/tuxayo changed: What|Removed |Added Depends on||32065 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 [Bug 32065] Invalid for some system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31886] No side menu when searching for syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Victor Grousset/tuxayo changed: What|Removed |Added Depends on||32065 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 [Bug 32065] Invalid for some system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32065] Invalid for some system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||31952, 31886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 [Bug 31952] Sending an empty system preference search breaks layout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32065] New: Invalid for some system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Bug ID: 32065 Summary: Invalid for some system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: vic...@tuxayo.net QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Follow up are needed here after bug 31952 and bug 31886 CI caught this: (https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/consoleText) koha_1 | # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref is YAML' koha_1 | # at xt/yaml_valid.t line 41. koha_1 | koha_1 | # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/local_use.pref is YAML' koha_1 | # at xt/yaml_valid.t line 41. koha_1 | koha_1 | # Failed test '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref is YAML' koha_1 | # at xt/yaml_valid.t line 41. koha_1 | # Looks like you failed 3 tests of 17. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30891] SMS provider shows on staff side even if SMS::Send driver is not set to "Email"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 --- Comment #8 from Victor Grousset/tuxayo --- Noted for 21.05, hopefully it will be in 21.11 before the next and last release of 21.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010 --- Comment #6 from Victor Grousset/tuxayo --- > Use Carp::Always to get the stacktrace (`perl -MCarp::Always test.t`). I meant if should I submit a patch to make diagnosing this easier as wait_for_ajax is in a lot of places. But maybe it's so rare to fail like that. So ok for now I'll change from using prove to `perl -MCarp::Always` for running UI tests in a loop. Meanwhile, "not such alert" and "unexpected alert open" come so much more often than hunting for "Cannot wait more for jQuery to be active" would be tedious. So should ticket this be reopened? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #13 from David Cook --- (In reply to David Cook from comment #12) > So I think this could actually just be handled during an authorization step. That is, they've proven they are who they say they are during the authentication step. But expired users aren't authorized to use Koha, so they must take steps out-of-band to no longer be expired, so that they can be re-authorized. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #12 from David Cook --- If I recall correctly, locally we block SIP logins if the user is expired. So I think this could actually just be handled during an authorization step. We just need to add some business logic alongside the account lockout feature I imagine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31718] Change the IF ELSE values in MARC subfields structure breadcrumbs to facilitate translation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #16 from Victor Grousset/tuxayo --- > After that, I figured it wouldn't apply... It depends on the conflicts, if they are simple, Lucas will be able to solve them. Otherwise they will call for a backported patch here if someone needs it. You might then need to ask your dev colleagues to try to backport it and solve the conflict if you really need it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #10 from David Cook --- I reckon we log it in action_logs, but just make it so that it can't be toggled off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #42 from David Cook --- I like a lot of things from these patches, but I reckon they could probably be broken up into a number of smaller issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #41 from David Cook --- (In reply to Marcel de Rooy from comment #37) > This is just top of the iceberg. Looks like this development is far from > ready. Yikes... yeah maybe it'll be a while before we get rid of flags... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 --- Comment #16 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #13) > Are you editing it manually? There is a RMaint script for that! I do it manually too (I got stuff ready to copy paste so it's quick), especially needed since we now have to assess if documentation is needed or not or maybe. That changes the status and message to write. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813
--- Comment #40 from David Cook ---
(In reply to Martin Renvoize from comment #39)
> I've discussed this a little offline with a few people but never found a
> moment to put it down as a comment here.
>
> I think this bug starts going in the right direction.. but..
>
> I don't think we should continue down the route of 'nesting' permissions in
> a hierarchy.
>
> I'd rather see 'a bag of permissions' and then ways to arbitrarily group
> them.. be that for 'roles' or 'permissions groups' or whatever.
Agreed.
I think a good first step would be to have a single coherent way of fetching
and checking permissions (ie authorizations) across Koha, and then we can
incrementally improve the creation and organisation of permissions.
Right now, we use "C4::Auth::haspermission($userid,$flagsrequired)" in order to
get our permission data structure, when really we should be doing something
like "Koha::Auth->is_authorized({ flags => $flags, flagsrequired =>
$flagsrequired })"
Bug 31389 takes the $flags data structure and translates it into something that
can be used for the template authorizations.
Koha::Auth->is_authorized could actually leverage
Koha::Auth::Permissions->get_authz_from_flags().
Or something new could be made that fits the different scenarios.
--
Overall, we're not doing anything too complicated with
permissions/authorizations.
Maybe I could have another look at this sometime...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 David Cook changed: What|Removed |Added Blocks||32064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064 [Bug 32064] Add missing test to template permission calculation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32064] Add missing test to template permission calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064 David Cook changed: What|Removed |Added Depends on||31389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 [Bug 31389] Calculate user permissions in separate function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32064] Add missing test to template permission calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064 --- Comment #1 from David Cook --- Created attachment 142904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142904=edit Bug 32064: Add test data for all report subpermissions This patch adds test data to prove that all authorizations for subpermissions are set when only a top level flag is set. To test: 0) Apply patch 1) prove ./t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32064] Add missing test to template permission calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 --- Comment #13 from David Cook --- In hindsight, there is 1 test missing. For "normal staff user test", I should've included "'reports' => 1" and then checked that it all the sub-permissions authorizations. I've opened bug 32064 to include that missing test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32064] New: Add missing test to template permission calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064 Bug ID: 32064 Summary: Add missing test to template permission calculation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: dc...@prosentient.com.au Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Bug 31389 refactored how permissions are calculated for the templates. Today I realized there was 1 missing test to test that all subpermission authorizations are set when the top level permission is set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24465] Label creator requires catalogue permission instead of label_creator permission from tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Can you clarify this one? It looks to me like the template for ./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt uses the correct tools label creator sub-permission. However, it looks like the Perl scripts (e.g. ./labels/label-home.pl) are using the "catalogue" permission instead. Actually running 'grep "flagsrequired" ./labels/*' shows either "catalogue => 1" or "tools => 'label_creator'" or "borrowers => 'edit_borrowers'" I wonder if the Perl scripts should have both the "label_creator" sub permission and the "catalogue" permission... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #98 from Tomás Cohen Arazi --- (In reply to David Cook from comment #97) > > It looks like the last commit includes some updates besides tests though > despite the commit name? Skip the tests themselves, unless you really want to look at them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #97 from David Cook --- (In reply to Tomás Cohen Arazi from comment #96) > Just skip the last commit (wip trying to add tests). > > I noticed we need to redo Nick's and your patches It looks like the last commit includes some updates besides tests though despite the commit name? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32036] Cannot set single sub-permission without also setting the top level flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036 David Cook changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Choosing the top level flag is the same thing as selecting all sub-permissions. If you go to "Check out and check in items", choose all the sub-permissions and you'll see that the top level flag gets set. (Alternatively, if you just choose the top level flag, it will set all the sub-permissions. Uncheck one sub-permission, and you the top level flag is unchecked.) If you go to https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=31389=140563 and look at "Permissions.t", it might be clearer. You get CAN_user_circulate if you're superlibrarian, if you have the top level "circulate" permission, or if you have *any* circulation sub-permission. When you just set "circulate" without specifying individual subpermissions, it automatically gives you all sub-permissions. So setting the "manage_recalls" sub-permission is functionally equivalent to setting the "recalls" top level flag, since there is only . You'll get the exact same authorization. I hope that makes sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6960] staffaccess permission requires borrowers permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6960 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #7 from David Cook --- I agree with Katrin. It's not feasible to turn "staffacess" into a subpermission of "borrowers". In theory, the "staffaccess" line could be moved up and placed adjacent to the "borrowers" and "permissions" lines. However, that would probably require a re-jigging of the templating, since right now the permissions are in "bit" order. That re-jigging might be a good idea though, as there are other permissions that could potentially be grouped together functionally. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31329] Add ability to block all linked accounts when one account has been restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31329 sayl...@spanishfork.org changed: What|Removed |Added CC||sayl...@spanishfork.org --- Comment #4 from sayl...@spanishfork.org --- Yes! Yes! Yes! We would absolutely love this feature at our library. Like others have said, manually blocking/blocking all of the guarantee accounts is time consuming and oftentimes forgotten about. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #96 from Tomás Cohen Arazi --- Just skip the last commit (wip trying to add tests). I noticed we need to redo Nick's and your patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32063] Streamline importing of records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32063 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32033] Cannot rebuild zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033 --- Comment #7 from David Cook --- Katrin, do you think this should be closed? On one hand, failing to reindex due to one bad record seems suboptimal. On the other hand, if it just warns or silences the error, then it's not obvious there is a problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32033] Cannot rebuild zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033 --- Comment #6 from David Cook --- (In reply to Chaminda de Silva from comment #5) > Thank you very much David, I figured out the problem of Tag "24 " is not a > valid tag using your SQL Query. It should be Tag "245" not Tag "24 ". I thought that's what I was saying in my 1st comment. Apologies that I wasn't clearer! Glad you were able to sort it out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #95 from David Cook --- (In reply to Tomás Cohen Arazi from comment #94) > It means an attempt from AgustÃn to write login tests didn't go well. We're > can live without those. Ok I think I understand. I won't worry too much about failing tests for this go around then. > I'd like you to test that branch, which solves things that were reported, > including a rename. That branch probably needs a tidy, I haven't checked > that last commit (before the tests). The follow up commits seem to be a mix of the tests and core code changes, so those would need to be re-organised before QAing and pushing I think. -- I suppose Aleisha or myself could QA, so I suppose either of us could sign off. I'll have a look in any case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #94 from Tomás Cohen Arazi --- (In reply to David Cook from comment #93) > (In reply to Tomás Cohen Arazi from comment #89) > > Hi all, a couple follow-ups have been pushed to the branch and are ready for > > testing. We couldn't make some new tests we attempted to write for login > > work. > > > > It would be great to have them, but not sure if required. Why help there is > > welcome. We ran out of fuel yesterday > > Does this mean that the tests are failing and you'd like help to fix the > tests? It means an attempt from AgustÃn to write login tests didn't go well. We're can live without those. I'd like you to test that branch, which solves things that were reported, including a rename. That branch probably needs a tidy, I haven't checked that last commit (before the tests). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #93 from David Cook --- (In reply to Tomás Cohen Arazi from comment #89) > Hi all, a couple follow-ups have been pushed to the branch and are ready for > testing. We couldn't make some new tests we attempted to write for login > work. > > It would be great to have them, but not sure if required. Why help there is > welcome. We ran out of fuel yesterday Does this mean that the tests are failing and you'd like help to fix the tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8305] Add an icon for iOS home screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31419] Add accesskeys to recall modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31565] Patron search filter by category code with special character returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.07 released in|| --- Comment #26 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31605] Improve style of OPAC suggestions search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31605 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.07 released in|| --- Comment #6 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31527] Breadcrumbs for anonymous suggestions are not correct
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31527 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.07 released in|| Status|Pushed to master|Pushed to stable --- Comment #7 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23538] Email library when new patrons self register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #42 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Bug 22678 depends on bug 31468, which changed state. Bug 31468 Summary: Koha::Logger should prefix interface with 'plack' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Needs documenting CC||lu...@bywatersolutions.com --- Comment #29 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #15 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31525] Street number not being accessed correctly on patron search results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.07 released in|| CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31518] Hidden items count not displayed on hold request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.07 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #5 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.07 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #44 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #92 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #91) > Is this the link? > https://gitlab.com/thekesolutions/Koha/-/commits/oauth_client Hi Aleisha, Tomas added it to the URL field after my last comment, it matches with yours. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #91 from Aleisha Amohia --- Is this the link? https://gitlab.com/thekesolutions/Koha/-/commits/oauth_client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.07 released in|| Status|Pushed to master|Pushed to stable --- Comment #85 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.07 released in|| --- Comment #37 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32063] New: Streamline importing of records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32063 Bug ID: 32063 Summary: Streamline importing of records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Since bug 27421, importing records is managed in background jobs. I feel like this has added steps/clicks to something that was already click-heavy. Before (basing off of 22.05), to import a record file 1. Go to Tools > Stage MARC records for import 2. Click Browse and choose the file 3. Click Upload file 4. Choose the settings 5. Click Stage for import --> The summary of the file is presented 6. Click Manage staged records --> I am taken directly to manage my file 7. If needed, choose parameters, framework, etc. 8. Click Import this file into the catalog --> File is imported --> If needed, I can view/edit the records (for bibliographic records, this is almost always since I add items manually to add the barcodes) Now (based off master 22.06.?) 1. Go to Cataloging > Stage records for import 2. Click Browse and choose the file 3. Click Upload file 4. Choose the settings 5. Click Stage for import 6. Click View details of the enqueued job 7. Click View batch 8. If needed, choose parameters, framework, etc. 9. Click Import this file into the catalog Mine, for some reason, never works on the first try, so I have to go back and click Import this file into the catalog again, then it works. I hope this is just me... 10. Click Manage imported batch (if needed to see the records to add items for example) So it's not that many new clicks, but it's still two more steps than before, 10 vs 8 (or four more if the import doesn't work on the first try like mine!) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Caroline Cyr La Rose changed: What|Removed |Added Blocks||32062 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32062 [Bug 32062] Add import tool to Authorities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32062] Add import tool to Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32062 Caroline Cyr La Rose changed: What|Removed |Added Depends on||31162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32062] New: Add import tool to Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32062 Bug ID: 32062 Summary: Add import tool to Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The stage MARC records/managed staged MARC records tools have been moved from tools to cataloging in bug 31162. Those two tools are also used for authority records. We should add a link there too, because now it looks like it's only for bibliographic records. (we could argue that authorities are cataloging, I'm open to whatever, I just find that authorities are left behind) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #195 from Aleisha Amohia --- Created attachment 142903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142903=edit Bug 8367: (follow-up) Remove unnecessary code and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #133094|0 |1 is obsolete|| --- Comment #194 from Aleisha Amohia --- Created attachment 142902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142902=edit Bug 8367: (follow-up) Fix tests Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #133093|0 |1 is obsolete|| --- Comment #193 from Aleisha Amohia --- Created attachment 142901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142901=edit Bug 8367: (follow-up) Remove pickup delay message from OPAC It adds unnecessary complexity and information. Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #133092|0 |1 is obsolete|| --- Comment #192 from Aleisha Amohia --- Created attachment 142900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142900=edit Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #133091|0 |1 is obsolete|| --- Comment #191 from Aleisha Amohia --- Created attachment 142899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142899=edit Bug 8367: Make database update idempotent (across different MariaDB versions) The previous query seemed to work on MariaDB 10.1.48 (used by koha-testing-docker), but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this writing), but this patched query works on both indempotently. Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #133090|0 |1 is obsolete|| --- Comment #190 from Aleisha Amohia --- Created attachment 142898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142898=edit Bug 8367: Make database update idempotent Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #133089|0 |1 is obsolete|| --- Comment #189 from Aleisha Amohia --- Created attachment 142897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142897=edit Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few different numbers for different branches as well. 4) Place a hold on a biblio from the staff client. 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules. 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t 13) Test Talking Tech: 13a) Enable TalkingTechItivaPhoneNotification 13b) Go to Tools -> Notices & slips. Add content to the HOLD phone (itiva) notice. 13c) In your terminal, run perl /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o ~/itiva.tmp -w 0 --type=RESERVE Sponsored-by: Catalyst IT Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32054] GetImportRecordMatches returns the wrong match when passed 'best only'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32054 --- Comment #3 from Nick Clemens --- Created attachment 142896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142896=edit Sample biblio from sample database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32061] New: in the title of z39.50 servers page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Bug ID: 32061 Summary: in the title of z39.50 servers page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When accessing the Z39.50 servers page, in the title of the page (what appears in the browser tab) there are html tags . To test: 1. Go to Administration > Z39.50/SRU servers 2. Click "New Z39.50 server" --> Notice in the browser tab, the title of the page is New Z39.50 server > ... It does this for new Z39.50 server, new SRU server and when editing a server too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32054] GetImportRecordMatches returns the wrong match when passed 'best only'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32054 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- I'm happy to try and test, however there is no attached record (step 1 of the test plan). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32058] 'Print > Print X' could use clearer labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32058 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org --- Comment #1 from Andrew Fuerste-Henry --- I'm ok with new labels/names, but please remember we've got a couple of sysprefs that refer to these by their current names: CircAutoPrintQuickSlip and DisplayClearScreenButton. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com --- Comment #11 from Blou --- The last patch "import issue" fixes a crash in 22.05.06 (at least). I haven't managed to apply the whole set on Koha/VirtualShelf.pm, because of Bug 30933. It's a rabbit hole, but without it we get a 500 on public lists when logged in the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 Lucas Gass changed: What|Removed |Added Keywords||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
