[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #143053|0 |1 is obsolete|| --- Comment #46 from David Nind --- Created attachment 143065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143065&action=edit Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #142912|0 |1 is obsolete|| --- Comment #45 from David Nind --- Created attachment 143064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143064&action=edit Bug 30358: (follow-up) stripWhitespaceChars subroutine and tests To test: Confirm test plan above still works as expected and tests pass in t/Koha_MetadataRecord.t Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #142911|0 |1 is obsolete|| --- Comment #44 from David Nind --- Created attachment 143063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143063&action=edit Bug 30358: (follow-up) Put multiple subfields fix on auth side Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #142910|0 |1 is obsolete|| --- Comment #43 from David Nind --- Created attachment 143062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143062&action=edit Bug 30358: (follow-up) Consider field has multiple subfields of same key To test: 1) Click the clone subfield button to make multiple subfields with the same key, i.e. 500$a$a$a 2) Save the record and confirm that the fields contain the correct data after whitespaces are stripped. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #142909|0 |1 is obsolete|| --- Comment #42 from David Nind --- Created attachment 143061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143061&action=edit Bug 30358: (follow-up) Clarify syspref wording about fields affected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #142908|0 |1 is obsolete|| --- Comment #41 from David Nind --- Created attachment 143060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143060&action=edit Bug 30358: (follow-up) Fixing tests and including for inner newlines Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #142907|0 |1 is obsolete|| --- Comment #40 from David Nind --- Created attachment 143059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143059&action=edit Bug 30358: (follow-up) Inner newlines should be replaced with a space Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #142906|0 |1 is obsolete|| --- Comment #39 from David Nind --- Created attachment 143058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143058&action=edit Bug 30358: (follow-up) Also strip inner newlines This patch amends the StripWhitespaceChars system preference to also strip inner newlines (line breaks and carriage returns) when enabled. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Attachment #142905|0 |1 is obsolete|| --- Comment #38 from David Nind --- Created attachment 143057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143057&action=edit Bug 30358: Strip leading/trailing whitespace characters from input fields when cataloguing This enhancement adds a system preference StripWhitespaceChars which, when enabled, will strip leading and trailing whitespace characters from all fields when cataloguing both bibliographic records and authority records. Whitespace characters that will be stripped are: - spaces - newlines - carriage returns - tabs To test: 1. Apply patch and install database updates 2. Go to Administration, system preferences, find the new StripWhitespaceChars preference. It should be "Don't strip" by default. Change it to "Strip". 3. Search for a biblio record and edit it. Put some leading or trailing whitespace characters in input fields and textarea fields and save. 4. Confirm these characters are removed when you save the record. 5. Repeat steps 3 and 4 for authority records. 6. Confirm tests pass t/db_dependent/Biblio/ModBiblioMarc.t Sponsored-by: Educational Services Australia SCIS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #108 from Agustín Moyano --- (In reply to David Cook from comment #105) > I appreciate the replacement of "Authentication provider" being changed to > "Identity provider" and "tranverse_hash" being changed to "traverse_hash", > but it looks like every other issue I described last time is still present > in the Gitlab version... > > I have to fail this again, because several of the features don't work. > > Before I test this again, I'd like someone to confirm that they've looked at > my "FIXME" comments, and fixed them (or at least provide a reason for not > fixing them). Hi David, could you please try again? I've attended to all your valuable FIXME comments in the last patch. Please let me know what you think. Thanks so much! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Agustín Moyano changed: What|Removed |Added Attachment #143056|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Agustín Moyano changed: What|Removed |Added Attachment #141801|0 |1 is obsolete|| --- Comment #107 from Agustín Moyano --- Created attachment 143056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143056&action=edit Bug 31378: DB changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32076] Form for editing a basket group is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076 David Nind changed: What|Removed |Added Attachment #143026|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 143055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143055&action=edit Bug 32076: Add page-section to basketgroup.tt and clean-up markup This patch adds the page-section div to the basket group 'Ungrouped baskets'. It also adds the row class to the fieldset to get the list to display properly. To test: 1. Apply patch 2. Make sure the page section div for 'Ungrouped baskets' looks good. 3. Look at the markup changes and make sure the make sense. 4. Make sure the form still works as it should. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32076] Form for editing a basket group is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32006] Add page-section to local use system preference tab (admin)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes: - Used https://www.gueury.com/mozilla/index.html as an HTML validator for Firefox. - Lots of warnings, but no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32006] Add page-section to local use system preference tab (admin)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006 David Nind changed: What|Removed |Added Attachment #143045|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 143054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143054&action=edit Bug 32006: Add page-section for local use system preferences To test: 1. Go to the System preferences > Local use 2. Notice there is no page section and the table has much more space on the left than other system preference sections 3. Apply patch 4. Look again, the extra space on the left should be eliminated and the page-section should be added. 5. Use an HTML validator to spot errors. Note: I elimiated the inline style on the table that set the width to 80%. I don't see why that is needed but if it is we should be using CSS to do so. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32006] Add page-section to local use system preference tab (admin)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and charge hold fee if HoldFeeMode conditions are true as described in the system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What|Removed |Added Summary|Only show hold fee message |Only show hold fee message |on OPAC and charge hold fee |on OPAC and charge hold fee |is HoldFeeMode conditions |if HoldFeeMode conditions |are true as described in|are true as described in |the system preference |the system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and charge hold fee is HoldFeeMode conditions are true as described in the system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 --- Comment #5 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #4) > Can you please update the bug description/title and release notes to be more > clear about this not only affecting display please? I've done an update, hopefully that's better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and charge hold fee is HoldFeeMode conditions are true as described in the system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What|Removed |Added Text to go in the|This patch ensures |When HoldFeeMode is set to release notes|HoldFeeMode is considered |not_always or "only if all |when displaying a message |items are checked out and |to patrons on the OPAC that |the record has at least one |says they'll be charged a |hold already", Koha will |hold fee when placing or|unexpectedly show a hold |collecting the hold. |fee message and charge a | |hold fee if at least one of |When|those conditions are met. |HoldFeeMode is set to | |not_always or "only if all |This patch fixes the |items are checked out and |behaviour so that a hold |the record has at least one |fee message is only shown, |hold already" then the hold |and hold fee only charged, |fee message should only |if all items on the record |show if all items on the|are checked out, AND the |record are checked out, AND |record has at least one |the record has at least one |hold already - both of |hold already - both of |these conditions must be |these conditions must be|met, as the system |met.|preference implies. Summary|Only show hold fee message |Only show hold fee message |on OPAC if they will|on OPAC and charge hold fee |actually be charged |is HoldFeeMode conditions ||are true as described in ||the system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #37 from Aleisha Amohia --- Created attachment 143053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143053&action=edit Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32080] New: Public lists not available after recent upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080
Bug ID: 32080
Summary: Public lists not available after recent upgrade
Change sponsored?: ---
Product: Koha
Version: 22.05
Hardware: All
OS: Linux
Status: NEW
Severity: major
Priority: P5 - low
Component: Lists
Assignee: koha-bugs@lists.koha-community.org
Reporter: snick...@maine.rr.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
I recently upgraded the Debian package version from 19.11.03.000 to the
latest 22.05.04.000 (including the underlying OS upgrades as well) and now
no one is able to view any of the "Public Lists" and get a 500 error when
trying. Opac-error.log shows this ("USERID" is my userid and "WEBSITE" is the
hostname in the messages below):
Mon Oct 24 17:44:32.268569 2022] [cgi:error] [pid 22000] [client
x.x.x.x:5322] AH01215: DBIx::Class::Storage::DBI::select_single(): Query
returned more than one row. SQL that returns multiple rows is DEPRECATED
for ->find and ->single at /usr/share/koha/lib/Koha/Objects.pm line 96:
/usr/share/koha/opac/cgi-bin/opac/opac-suggestions.pl
[Mon Oct 24 17:44:39.651936 2022] [cgi:error] [pid 21984] [client
x.x.x.x:56417] AH01215: Use of inherited AUTOLOAD for non-method
Koha::Virtualshelf::haspermission() is deprecated at
/usr/share/koha/lib/Koha/Virtualshelf.pm line 247.:
/usr/share/koha/opac/cgi-bin/opac/opac-shelves.pl, referer:
http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list&public=1
[Mon Oct 24 17:44:39.652426 2022] [cgi:error] [pid 21984] [client
x.x.x.x:56417] AH01215: Template process failed: undef error - Can't locate
object method "_columns" via package "USERID" (perhaps you forgot to load
"USERID"?) at /usr/share/koha/lib/Koha/Object.pm line 858.:
/usr/share/koha/opac/cgi-bin/opac/opac-shelves.pl, referer:
http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list&public=1
[Mon Oct 24 17:44:39.695408 2022] [cgi:error] [pid 21984] [client
x.x.x.x:56417] End of script output before headers: opac-shelves.pl,
referer: http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list
&public=1
I did look in the database itself and do find a count of 93 items in the
'virtualshelves' table.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32028] Add page-section to various administration pages (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028 Lucas Gass changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32028] Add page-section to various administration pages (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028 --- Comment #1 from Lucas Gass --- Created attachment 143052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143052&action=edit Bug 32028: Add page-section to smart-rules.tt and fix markup errors To test: 1. Apply patch 2. Go to Adminstration > Circulation and fine rules 3. Look at the page-section added and make sure each looks good. 4. Use an HTML validator to check and make sure the HTML looks good. Note: There are indentation changes and some fixes to bad markup ( stray tags, etc ). Since there were quite a few mark-up errors I am attaching the smart-rules.tt patch by itself. The rest of the Adminstration pages mentioned will be in a single patch that is incoming! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32066] User can get stuck on login screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 --- Comment #12 from David Cook --- (In reply to Katrin Fischer from comment #11) > There are scripts that delete older entries from action_logs, something to > think about if you don't want these to be deleted by accident. I suppose that's a problem we'll face with any kind of logging potentially. But that does explain Kyle's suggestion of logging it outside of Koha. Log rotation would be up to the sysadmins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32045] Cannot order mulitple from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 --- Comment #1 from Katrin Fischer --- To test: * Create order * Stage file of MARC records * Order from staged file * Select file * Select one or more records for ordering using the checkbox * Save: You get: Some budgets are not defined in item records * IMPORTANT: Set the funds on the "Default accounting details" tab * Save again: nothing happens New bug: that error is actually wrong too budgets should be funds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 --- Comment #11 from Katrin Fischer --- There are scripts that delete older entries from action_logs, something to think about if you don't want these to be deleted by accident. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #20 from David Cook --- (In reply to Martin Renvoize from comment #18) > OK.. I decided to open another bug for my thoughts on key change.. > > I'll pass this one but highlight to the RM that we may need to rethink the > DB update. I've commented on Bug 32078 with what I think would be a fairly straightforward approach to allow key rotation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #19 from David Cook --- (In reply to Martin Renvoize from comment #17) > When we upgraded > from SHA to BCrypt for user account hashing we added a layer inside the > codebase to upgrade the hash on first access I seem to recall. We were upgrading from MD5 hashes to BCrypt hashes, which were easy to differentiate, since the BCrypt hashes started with "$2a$08$". We also had the user input so you could always compare hashes. In this case with the decryption I don't think there's any way to know whether or not you got a valid decrypted value (unless the encryption module throws an exception)... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #44 from Katrin Fischer --- Do we need the separator (last patch) for the OPAC too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #10 from Katrin Fischer --- Thanks Nick for tackling this, it was bothering us quite a bit. I wonder if the warning should stand out even more. I have updated the image to fa-exclamation-triangle to give it more of a warning character in the follow-up. Maybe it would be nice to also have a confirmation message if the category was changed? Commit message could have more words! ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #9 from Katrin Fischer --- Created attachment 143051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143051&action=edit Bug 31422: (QA follow-up) Fix terminology and switch icon * fa-exclamation-circle looks more like 'info', but I feel this should be more of a warning, so switched to fa-exclamation-triangle * Changed branches to libraries in message Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer changed: What|Removed |Added Attachment #142285|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 143050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143050&action=edit Bug 31422: Add patron's current category to dropdown while editing Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32078] We should have an easy way for an administrator to update the encryption keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Good call on adding functionality for key rotation! The tricky thing is that we don't currently have a way of noting which key was used to encrypt which field. In master, I'm only seeing Koha::Encryption used in Koha::Patron, and within Koha::Patron it's used in the function "encode_secret". So we could put a "key_id" or "encrypt_key_id" field in the patron table row, and then look up the key that way. Then the re-encryption tool could take a source ID and a destination ID for doing the re-encryption. If we wanted to automate it more, we could add additional metadata to the keys to indicate something like "revoked", "preferred", or whatever. But I think recording the key ID would be the first step. (You can see this all over AWS with KMS IDs.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer' checkin are not sent if modal is dismissed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Katrin Fischer changed: What|Removed |Added Attachment #141576|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 143049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143049&action=edit Bug 29792: Automatically send wrong transfers Bug 24434 reinstated the 'updateWrongTransfer' call here, but made the assertion that the transfer should not be sent until 'Ok' was clicked. I see how unsent transfers are useful for rotation, but I believe for wrong transfer we shouldn't require a confirm or print. If a library does want to, the 'transfersblockcirc' system preference will enforce clicking the button to continue This patch also confirms a transfer when item already has a transfer and only options are Confirm/Print because the transfer already exists To test: 1 - Disable TransfersBlockCirc system preference 2 - Manually transfer an item from branch A to branch B 3 - Check in the item at branch A 4 - Dismiss modal without confirming 5 - View item on biblio details page, item not in transit 6 - Check in item, confirm transfer 7 - Note item in transit on details page 8 - Check in the item at branch C 9 - Dismiss modal without confirm 10 - View item on biblio detail, not in transit 11 - Checkin at A, cancel transfer 12 - Apply patch 13 - repeat 1 - 4 14 - Confirm item appears in transit 15 - Check in at branch C, dismiss modal 16 - Confirm item in transit Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer' checkin are not sent if modal is dismissed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer' checkin are not sent if modal is dismissed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Summary|Transfers created from |Transfers created from |Wrong Transfer checkin are |'wrong transfer' checkin |not sent if modal is|are not sent if modal is |dismissed |dismissed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects instead of raw SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 --- Comment #8 from Katrin Fischer --- Created attachment 143048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143048&action=edit Bug 31517: (QA follow-up) Fix indentation Also removes commented out Data::Dumper. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects instead of raw SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Katrin Fischer changed: What|Removed |Added Attachment #142848|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 143047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143047&action=edit Bug 31517: Remove unused get_tag function Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects instead of raw SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Katrin Fischer changed: What|Removed |Added Attachment #142847|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 143046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143046&action=edit Bug 31517: Replace raw SQL queries in C4::Tags with Koha object accesses To test: 1) Create a few new tags to any biblio by visiting the biblio's detail page on OPAC 2) The visit http://localhost:8080/cgi-bin/koha/opac-tags.pl and try deleting those tags. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects instead of raw SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32050] Add 'page-section' to calendar page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32050 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32050] Add 'page-section' to calendar page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32050 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32044] Yellow buttons are styled differently in different spots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32044] Yellow buttons are styled differently in different spots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32038] Sidebar and footer style improvements on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32038] Sidebar and footer style improvements on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32014] Tweak style of checkout settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32014 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32014] Tweak style of checkout settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32014 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32012] runreport.pl should use binmode UTF-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32012] runreport.pl should use binmode UTF-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31664] Show pending transfers on catalog details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31664] Show pending transfers on catalog details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32079] New: Add 'select all' to Tags page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32079 Bug ID: 32079 Summary: Add 'select all' to Tags page in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org On the tags tab in the OPAC you can select multiple entries for deletion, but you can only do it one by one using the checkboxes. It would be nice to have a 'select all/select none' toggle. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32006] Add page-section to local use system preference tab (admin)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32006] Add page-section to local use system preference tab (admin)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006 --- Comment #2 from Lucas Gass --- Created attachment 143045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143045&action=edit Bug 32006: Add page-section for local use system preferences To test: 1. Go to the System preferences > Local use 2. Notice there is no page section and the table has much more space on the left than other system preference sections 3. Apply patch 4. Look again, the extra space on the left should be eliminated and the page-section should be added. 5. Use an HTML validator to spot errors. Note: I elimiated the inline style on the table that set the width to 80%. I don't see why that is needed but if it is we should be using CSS to do so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32006] Add page-section to local use system preference tab (admin)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32036] Cannot set single sub-permission without also setting the top level flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036 --- Comment #4 from David Cook --- (In reply to Nick Clemens from comment #3) > I think this causes confusion then - either we should always have a single > subpermission, or we should only have them if we have two? Confusion for whom? > For OPAC problem reports - we only seem to ever check the top permission > For recalls we check the subpermission every time, except once > > Having two settings with the same behavior seems wrong to me What do you mean by "two settings"? For "OPAC problem reports management" and "Recalls", you get the same thing whether you click the top level or the sub-permission, and that's clearly indicated visually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32006] Add page-section to local use system preference tab (admin)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Lucas Gass --- Local use works a bit differently than the rest of the prefs so I think we need to add the page-section for this directly in systempreferences.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #79 from Tomás Cohen Arazi --- I haven't fully recovered, but... I get bored so... I have submitted a revisited patch for revisiting the data structure and methods, and then another interesting follow-up for getting rid of the x-koha-expand-av flag, and just add a syntax for +av_expand on the x-koha-embed, which makes a lot more sense and provides a fine-grained approach instead of an all-or-nothing one. I implemented things mostly as Jonathan proposed (I only added an obvious 'category' attribute). We'll see how we later add 'str' counterpart for other types of things. Please test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #78 from Tomás Cohen Arazi ---
Created attachment 143044
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143044&action=edit
Bug 26635: Move expand syntax to x-koha-embed
Instead of a global av-expand flag (through a header) this patch
proposes to allow specifying +av_expand at the x-koha-embed header
level. This allows a more fine-grained control on what objects get avs
expanded. e.g.:
GET /patrons/123
x-koha-expand: +av_expand,checkouts.item+av_expand
=>
{
"_str": {
"city": { "str": "Córdoba", ... }
},
...
"checkouts": [
{
...,
"item": {
"_str": {
"not_for_loan_status": { "str": "Reference material", ...
},
...
},
...
}
}
]
}
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t \
t/Koha/REST/Plugin/Query.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
2. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #77 from Tomás Cohen Arazi ---
Created attachment 143043
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143043&action=edit
Bug 26635: Refined data structure and methods
This patch makes the returned data structure be simpler:
_str => {
attribute_1 => {
category => 'some_category_name',
str => 'description',
type => 'av'
},
...
}
The description is sensible to context, so if public => 1 is passed,
then lib_opac is passed, and lib is returned otherwise. Whenever we add
language to the combo, we will add it to the implementation.
Tests are adjusted accordingly, also to reflect the public => 1 use
case.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #76 from Tomás Cohen Arazi ---
Created attachment 143042
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143042&action=edit
Bug 26635: AV expansion should ackowledge $params->{public}
This patch simplifies the original implementation so it is more
readable, removing extra loops and methods and just dealing with the
coded values inline on the existing loops.
It also adds non-public attributes removal from the original list, to
address the changes introduced by bug 28948.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #75 from Tomás Cohen Arazi --- Created attachment 143041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143041&action=edit Bug 26635: Add tests for av-expand => 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #74 from Tomás Cohen Arazi ---
Created attachment 143040
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143040&action=edit
Bug 26635: Expand authorised values in to_api method
This patch adds the posibility to expand authorised values when to_api
method is called.
The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following
{
column_name => Koha::AuthorisedValue->unblessed
...
}
This patch will be used in bug 8179, so please test there.
Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #73 from Tomás Cohen Arazi --- Created attachment 143039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143039&action=edit Bug 26635: Add tests Add tests in t/db_dependent/Koha/Object.t and t/db_dependent/Koha/REST/Plugin/Objects.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32065] Invalid YAML for some system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #235 from David Nind --- Thanks Martin for addressing the items I raised! I've retested and here are some more comments. 1. When submitting a concern on the OPAC, there is no acknowledgement message, for example like when you report a problem or make a purchase suggestion (such as, "Your catalog concern report was submitted.") - you are just returned to the record. 2. Last comment/update is prepopulated into the update field without a hard page refresh: 2.1 Click on the Details action for a concern 2.2 Add a comment in the update field and click on comment 2.3 Click on the details action again for the same concern without refreshing the page: note that the update field is populated with the last comment made 2.4 Click on another concern: same results as 2.3 2.5 If you click away to another page (or a hard referesh - Shift + Refresh), and then go back to the catalog concerns page this doesn't happen. 3. Permissions to manage concerns - I still can't get this to work using the editcatalog permission: 3.1 I added the editcatalog permission + all tools to a staff user (Henry). 3.2 When I go to access catalog concerns (either from 'Pending catalog concerns' on the home page or from the cataloging home page), I get "You do not have permission to access this page" and the login form. 3.3 Without the permission, I don't see 'Pending catalog concerns' on the home page or "Catalog concerns" on the Cataloguing home page (as expected). 3.4 I also gave all permissions except "Access to all librarian functions (superlibrarian)" and I still get the same permission error as in 3.2. 4. Details of concerns listed on the record details page are now shown, however: 4.1 If resolved, can still add comments, and can also click on resolve again (using the koha superlibrarian user). 4.2 Whereas, in the Cataloging > Catalog concerns area, once you have resolved the concern the only option you have is the "Comment" button. 4.2 If you don't have permission, can see the details in modal window and the Resolve and Comment buttons are displayed. When attempting to make a comment or resolve, the modal sits there with the "spinner" on the button. 5. Reporting a catalog concern from the staff interface - display of help text: 5.1 If the help text has a bulleted list, the bullets aren't shown (add some lines to the help text, make them into a bulleted list, report a problem in the staff interface for a record). 6. Notices sent using email (see [1] for how I set up to test): 8.1 Acknowledgement, update, and resolved notifications come through (acknowledgement messages cam straight through, but update and resolved came through when I ran misc/cronjobs/process_message_queue.pl). 8.2 The notify message to CatalogersEmail address didn't come through and is not in the message queue. 8.3 Messages come through as a single line without any line breaks. Does the notice need HTML tags for this? See [2] for examples of what was received. 8.4 Only the 'Catalog concern updated' and 'Catalog concern resolved; notices were displayed under the patron's record of notices - the acknowledgement notice wasn't listed. 7. Setting CatalogerEmails - wrong name in test plan for patch 'Add email notification of cataloguers on submissions' (CataloguerEmails should be CatalogerEmails. 8. List of concerns - should it default to only displaying the unresolved concerns? Otherwise, the list could get quite long... Maybe this should be a separate bug if considered an issue, as I noticed that this is the same pattern used for OPAC problem reports and AllowCheckoutNotes. [1] Set up for testing notifications using Gmail when using KTD. Add this to /etc/koha/sites/kohadev/koha-conf.xml, setup an App password for your Gmail account, add the details as indicated, and add your Gmail address as the email for a patron(s) used in testing: smtp.gmail.com 587 5 STARTTLS YOURGMAILADDRESS YOURAPPPASSWORD/password> 1 [2] Text of email messages - came through as a single line: Acknowledgement: Dear koha (42), Thankyou for your report concerning Lady Susan ; The Watsons ; Sanditon / . You reported: **Describe the concern** A clear and concise description of what the concern is. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '' 3. Scroll down to '' 4. See error **Expected behavior** A clear and concise description of what you expected to happen. Thankyou Update: Dear koha (42), The library has added an update to the concern you reported against Lady Susan ; The Watsons ; Sanditon / . The following comment was left: Send an update Thankyou Resolved: Dear koha (42), The library has now marked your concern with Lady Susan ; The Watsons ; Sanditon / as resolved. The following comment was left: This is now fixed! Thankyou -- You are receiving this mail because: You are watching
[Koha-bugs] [Bug 31015] Remove option to clear pickup location selects on multi-holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31015 --- Comment #3 from Jason Robb --- The larger issue was that holds could be placed without branchcodes assigned under certain circumstances. If I'm understanding correctly, bug 31086 seems to fully prevent that from happening so this may not be a problem any longer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 --- Comment #12 from Victor Grousset/tuxayo --- Thanks Jonathan! Testing notes: After `apt install libmojolicious-plugin-renderfile-perl` you need to restart the services to have it work. Otherwise: [2022/11/02 19:54:30] [ERROR] Warning: Could not load REST API spec bundle: Plugin "RenderFile" missing, maybe you need to install it? [2022/11/02 20:05:50] [ERROR] GET /api/v1/erm/documents/1/file/content: unhandled exception (Mojo::Exception)<> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects instead of raw SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31664] Show pending transfers on catalog details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664 Katrin Fischer changed: What|Removed |Added Attachment #142121|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 143038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143038&action=edit Bug 31664: Display pending transfer information on details page If a transfer is requested, but not sent, we should display this information on biblio details for staff This patch also removes nocancel parameter that was not used, passes transfer object directly to template To test 1 - Manually transfer an item 2 - Note the item shows in transit on details page 3 - Remove the datesent to emulate a pending transfer UPDATE branchtransfers SET datesent = NULL itemnumber=1; 4 - View details page - no info on transfer 5 - Apply patch 6 - Item shows 'Transit pending' Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31664] Show pending transfers on catalog details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664 Katrin Fischer changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31664] Show pending transfers on catalog details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Summary|Show pending transfers on |Show pending transfers on |biblio details page |catalog details page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Katrin Fischer changed: What|Removed |Added Attachment #142275|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 143037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143037&action=edit Bug 31889: Replace append_fields in _embed_items Test plan: Run t/db_dependent/Koha/Biblio/Metadata.t again. Should pass. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Katrin Fischer changed: What|Removed |Added Attachment #142274|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 143036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143036&action=edit Bug 31889: Add unit test to show problem Test plan: Run t/db_dependent/Koha/Biblio/Metadata.t Fails with: not ok 10 - 951-952s-953 in 245,100,942,951,953,999,952,952,952,952,952,952,952,952 Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Katrin Fischer changed: What|Removed |Added Attachment #142273|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 143035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143035&action=edit Bug 31889: Remove exported ghost routine from Biblio module It has been moved to a Koha object. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #5 from Katrin Fischer --- Great little fix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035 Katrin Fischer changed: What|Removed |Added Attachment #143031|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 143034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143034&action=edit Bug 32035: Add "Koha" to the staff interface home page Currently the staff interface does not include Koha before the version number shown on the home page. Test plan: 1. Log in and view the staff interface home page. 2. In the bottom right-hand corner "Version 22.06.00" is shown. 3. Apply the patch. 4. Refresh the staff interface home page. 5. It now shows "Koha 22.06.00" (linked to the Koha website). 6. Sign off :D (or comment on alternative options). Signed-off-by: David Nind Signed-off-by: Claude Demeure Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035 --- Comment #9 from Katrin Fischer --- (In reply to Claude Demeure from comment #8) > Hello Katrin, > it was my first time "alone" on Bugzilla ;-). > Did i forgot something when i signed off ? Hi Claude, not a problem :) You didn't add the sign-off line to the patch. I can do that right now for you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035 --- Comment #8 from Claude Demeure --- Hello Katrin, it was my first time "alone" on Bugzilla ;-). Did i forgot something when i signed off ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15869] Change framework on overlay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #15 from Nick Clemens --- Created attachment 143033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143033&action=edit Bug 15869: (follow-up) Don't mock undef return value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Katrin Fischer changed: What|Removed |Added Attachment #142230|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 143032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143032&action=edit Bug 31887: Fix search on MARC field in Elasticsearch mappings table In Elasticsearch mappings table, in tabs with MARC fields, searching using DataTable search field does not work for MARC fields / subfields. This is because cell contains an input HTML tag with MARC data in attribute value. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Go to tab 'Bibliographic records' 3) Enter in search field a used MARC field (like 245) => Table gets filtered by rows with mapping on searched field 4) Enter in search field the field+subfield used for issues (952l in KTD) => Table gets filtered by rows with mapping on field+subfield Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035 --- Comment #7 from Katrin Fischer --- Claude, I see you set this to Signed off - are we missing your sign-off line here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035 Katrin Fischer changed: What|Removed |Added Attachment #142800|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 143031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143031&action=edit Bug 32035: Add "Koha" to the staff interface home page Currently the staff interface does not include Koha before the version number shown on the home page. Test plan: 1. Log in and view the staff interface home page. 2. In the bottom right-hand corner "Version 22.06.00" is shown. 3. Apply the patch. 4. Refresh the staff interface home page. 5. It now shows "Koha 22.06.00" (linked to the Koha website). 6. Sign off :D (or comment on alternative options). Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
