[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #40 from David Nind --- I've ended up adding sign off lines for the first two patches - not sure how to remove those! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #17 from David Nind --- (In reply to Aleisha Amohia from comment #16) > (In reply to David Nind from comment #14) > > Hi Aleisha. > > > > Apologies for Failing QA on this again! > > > > The previous issue reported is fixed (step 7 - can't cancel a recall from > > OPAC when RecallsInterface = staff interface only). > > > > I've identified a new issue with step 5 - cancelling a recall from the > > recalls section for a record - record doesn't exist after cancelling a > > recall using the 'Cancel selected recalls' button and selecting the normal > > section. > > > > To replicate: > > 1. Place a recall > > 2. Go to the recalls section for the record on the staff interface > > 3. Using Actions > Cancel works as expected > > 4. Repeat steps 1 and 2. > > 5. Cancel the recall by ticking the box next to the item and then selecting > > 'Cancel selected recalls' button doesn't work as expected: > >. The recall is cancelled > >. URL = http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl > >. Breadcrumb = Home > Catalog > No title > Place a recall > >. Click on the normal section: > > message = The record you requested does not exist (). > > URL = > > http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber= > > > > I'm not sure if I tested this last time. I'm also sure I've seen this when > > testing something else a while ago, but can't remember or find what bug it > > was. > > Fixed in latest follow-up This is still not working for me and doesn't appear to be fixed. If it helps, there is an entry in /var/log/koha/kohadev/plack-intranet-error.log: [2022/11/04 06:36:44] [WARN] Use of uninitialized value $biblionumber in concatenation (.) or string at /kohadevbox/koha/recalls/request.pl line 49. Everything else continues to work as per the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #133 from David Cook --- Agustín, how are you testing this during development? In my docker-compose.yml, I use the following: keycloak: image: jboss/keycloak networks: - kohanet environment: KEYCLOAK_USER: KEYCLOAK_PASSWORD: ports: - "8082:8080" If you are interested in using Keycloak for testing, I can give a few more instructions on how to set up the realm, the client, the user, and where to find the details for the Koha configuration. -- That actually reminds me that I don't have a test plan for the "OAuth" Protocol option. Does it still work with the OIDC option since OIDC is just a wrapper around OAuth? -- Anyway, that's all for me for now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #132 from David Cook --- Looks like Koha/Template/Plugin/AuthClient.pm might be having an issue with Koha/Auth/Identity/Providers.pm... -- Test plan 1: 0. Apply patches 1. apt install libmojolicious-plugin-oauth2-perl 2. koha-upgrade-schema kohadev 3. restart_all Test plan 2: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Identity providers" 3. Click "New identity provider" 4. Enter relevant details and click "Submit" 5. Click on "Manage Domains" 6. Click "Edit" on the default domains 7. Set "Allow staff" and allow update on login and autoregister and click "Submit" 8. koha-plack --restart kohadev 9. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha -- I'm getting this error: "There was an error authenticating to external identity provider No configuration found for your provider" I'm seeing the following error in the logs on Starman startup: [2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration: Can't locate object method "search" via package "Koha::Auth::Providers" (perhaps you forgot to load "Koha::Auth::Providers"?) at /kohadevbox/koha/Koha/REST/V1.pm line 143. [2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration: Can't locate object method "search" via package "Koha::Auth::Providers" (perhaps you forgot to load "Koha::Auth::Providers"?) at /kohadevbox/koha/Koha/REST/V1.pm line 143. -- Looks like a typo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #131 from David Cook --- First things first...staying in Failed QA due to qa tool failures: -- testing 21 commit(s) (applied to ba01d76 '78 Bug 31713: Fix permissions') Processing files before patches Configure idp routes=>| 48 / 48 (100.00%) Processing files after patches |>| 48 / 48 (100.00%) OK C4/Auth.pm OK Koha/Auth/Client.pm FAIL Koha/Auth/Client/OAuth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Auth/Provider.pm OK Koha/Auth/Provider/Domain.pm OK Koha/Auth/Provider/Domains.pm OK Koha/Auth/Provider/OAuth.pm OK Koha/Auth/Provider/OIDC.pm OK Koha/Auth/Providers.pm OK Koha/Exceptions.pm FAIL Koha/Exceptions/Auth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/REST/Plugin/Auth.pm OK Koha/REST/V1.pm OK Koha/REST/V1/Auth/Provider/Domains.pm OK Koha/REST/V1/Auth/Providers.pm OK Koha/REST/V1/OAuth/Client.pm OK Koha/Schema/Result/AuthProvider.pm OK Koha/Schema/Result/AuthProviderDomain.pm OK Koha/Schema/Result/Branch.pm OK Koha/Schema/Result/Category.pm OK Koha/Schema/Result/IdentityProviderDomain.pm OK Koha/Template/Plugin/AuthClient.pm OK admin/authentication_providers.pl OK admin/identity_providers.pl OK api/v1/swagger/definitions/auth_provider.yaml OK api/v1/swagger/definitions/auth_provider_domain.yaml OK api/v1/swagger/paths/auth.yaml OK api/v1/swagger/paths/oauth.yaml OK api/v1/swagger/paths/public_oauth.yaml OK api/v1/swagger/swagger.yaml OK installer/data/mysql/atomicupdate/bug_31378.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_provider_domains.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_providers.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL valid_template DBIx::Class::Schema::source(): Can't find source for IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524 OK t/db_dependent/Koha/Auth/Client.t OK t/db_dependent/Koha/Auth/Provider.t OK t/db_dependent/Koha/REST/Plugin/Auth/IdP.t OK t/db_dependent/api/v1/idp.t FAIL t/lib/IdP/ExternalIdP.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #130 from David Cook --- (In reply to Agustín Moyano from comment #108) > Hi David, could you please try again? > > I've attended to all your valuable FIXME comments in the last patch. > > Please let me know what you think. > > Thanks so much! Thanks, Agustín. I don't have time to thoroughly test it today, and I'm away on Monday, but I'll do a quick glance over it now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32106 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32106] Formatting issues - accounting details form when receiving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32106 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31631 Patch complexity|--- |String patch Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32106] New: Formatting issues - accounting details form when receiving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32106 Bug ID: 32106 Summary: Formatting issues - accounting details form when receiving items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: da...@davidnind.com QA Contact: testo...@bugs.koha-community.org Created attachment 143163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143163&action=edit Screenshot - Receiving order form - formatting When receiving an order, there are some minor formatting issues for two fields on the accounting details form (see the attached screenshot): - Retail price: no space after value and the opening bracket; no space between comma and tax exclusive (or tax inclusive, depending on the vendor setting) - Budgeted cost: no space after value and the opening bracket This requires changes to koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt to fix. To replicate:* 1. Add an order to a basket for a vendor (Acquisitions > Manage orders > click search > select My Basket (for My Vendor) > Add to basket). 2. Close the basket (select 'Close basket' from the basket page). 3. Receive shipments for the vendor (Acquisitions > Manage orders > click search (shows My Basket for My Vendor) > Receive shipments > Enter an invoice number > Next). 4. Click receive for an item in My Basket. 5. Note the formatting issues on the accounting details form for these fields: - Retail price: no space after value and the opening bracket; no space between comma and tax exclusive (or tax inclusive) - Budgeted cost: no space after value and the opening bracket 6. On another tab, edit the vendor so that for 'list prices' and 'invoice prices' the 'include tax' option is selected. 7. Refresh the tab for receiving items. 8. Note the same formatting issues as in step 5. * Using koha-testing-docker (KTD) there is one vendor (My Vendor) with an empty basket (My Basket) already setup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] Content field in HTML customizations is too narrow ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32036] Cannot set single sub-permission without also setting the top level flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036
--- Comment #6 from David Cook ---
(In reply to Nick Clemens from comment #5)
> (In reply to David Cook from comment #4)
> > Confusion for whom?
>
> For developers, or users. Why does problem reports have a subpermission, and
> edit authorities does not?
Ahh, I understand now. That is confusing. My only thought is that the original
developer thought that additional sub-permissions might be added?
Aleisha could probably speak to that for recalls.
> > What do you mean by "two settings"?
>
> flagsrequired => { recalls => "manage_recalls" }
> flagsrequired => { recalls => 1 }
>
> These are checking two different things, but provide the same answer
That's true (where there is only one sub-permission like recalls).
If additional sub-permissions were added, they would mean different things. I
suppose that is both a pro and a con...
> > For "OPAC problem reports management" and "Recalls", you get the same thing
> > whether you click the top level or the sub-permission, and that's clearly
> > indicated visually.
>
> Sure, but then why is the subpermission added at all? If it is the same as
> clicking the top level, let's not provide two checkboxes when one will do
I think that's the crux of the matter.
I suppose one option could be removing unnecessary sub-permissions?
Alternatively, we could also grey-out sub-permissions where there's only 1
sub-permission available. That might make it less confusing visually?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32105] New: Patron lists needs to share to specific people or groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Bug ID: 32105 Summary: Patron lists needs to share to specific people or groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org If using patron lists with the batch permissions modifier plugin, there is no way to share that list with specific people or groups. It is all or nothing. This means if you use the plugin, either only one person maintains that list, or everyone with patron list permissions has access to that list, giving them power over all permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What|Removed |Added Attachment #143151|0 |1 is obsolete|| --- Comment #39 from David Nind --- Created attachment 143162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143162&action=edit Bug 31692: (follow-up) Adjust reserves.item_level_hold Original patch missed handling reserves.item_level_hold column. To test: 1. prove t/db_dependent/Koha/Hold.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What|Removed |Added Attachment #142819|0 |1 is obsolete|| --- Comment #38 from David Nind --- Created attachment 143161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143161&action=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What|Removed |Added Attachment #142818|0 |1 is obsolete|| --- Comment #37 from David Nind --- Created attachment 143160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143160&action=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #36 from David Nind --- (In reply to Lari Taskula from comment #35) > (In reply to David Nind from comment #34) > > The patches still apply, but something seems changed: > > > > 1. Step 7 - There is now no dropdown list (before there was a drop down list > > with Only item and Next available); selecting next available and > > updating removes the drop down list). > > The wording in this step is a bit silly, it appears I didn't properly > rewrite it when I squashed the new dropdown menu with the original patch. > > What you describe seems expected behavior to me. After changing from item > level hold to record level hold there should no longer be a dropdown. So at > step 7 if you see just the text "Next available" then that is to be expected. > > This is because the patches here do not add GUI support for going from > record level to item level hold, but only the other way around. Thanks for clarifying! > > 2. Step 9 - There is still a dropdown list with the two options (Only item > > and Next available). > > This is not expected, did you add the two item level holds for the same > patron? I noticed the test plan does not clarify that this is required. I added for different patrons, so will use the same patron. Just re-testing, so should be signed off shortly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind changed: What|Removed |Added Attachment #142597|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 143159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143159&action=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind changed: What|Removed |Added Attachment #141019|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 143158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143158&action=edit Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind changed: What|Removed |Added Attachment #141018|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 143157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143157&action=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order keeping all the default values 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind changed: What|Removed |Added Attachment #141017|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 143156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143156&action=edit Bug 31631: Add new system preference Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #35 from Lari Taskula --- (In reply to David Nind from comment #34) > The patches still apply, but something seems changed: > > 1. Step 7 - There is now no dropdown list (before there was a drop down list > with Only item and Next available); selecting next available and > updating removes the drop down list). The wording in this step is a bit silly, it appears I didn't properly rewrite it when I squashed the new dropdown menu with the original patch. What you describe seems expected behavior to me. After changing from item level hold to record level hold there should no longer be a dropdown. So at step 7 if you see just the text "Next available" then that is to be expected. This is because the patches here do not add GUI support for going from record level to item level hold, but only the other way around. > 2. Step 9 - There is still a dropdown list with the two options (Only item > and Next available). This is not expected, did you add the two item level holds for the same patron? I noticed the test plan does not clarify that this is required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #16 from Aleisha Amohia --- (In reply to David Nind from comment #14) > Hi Aleisha. > > Apologies for Failing QA on this again! > > The previous issue reported is fixed (step 7 - can't cancel a recall from > OPAC when RecallsInterface = staff interface only). > > I've identified a new issue with step 5 - cancelling a recall from the > recalls section for a record - record doesn't exist after cancelling a > recall using the 'Cancel selected recalls' button and selecting the normal > section. > > To replicate: > 1. Place a recall > 2. Go to the recalls section for the record on the staff interface > 3. Using Actions > Cancel works as expected > 4. Repeat steps 1 and 2. > 5. Cancel the recall by ticking the box next to the item and then selecting > 'Cancel selected recalls' button doesn't work as expected: >. The recall is cancelled >. URL = http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl >. Breadcrumb = Home > Catalog > No title > Place a recall >. Click on the normal section: > message = The record you requested does not exist (). > URL = > http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber= > > I'm not sure if I tested this last time. I'm also sure I've seen this when > testing something else a while ago, but can't remember or find what bug it > was. Fixed in latest follow-up > > Also, for step 13 it is possible to have more than one recall for a record > or item. Whose recall takes priority, and what is the workflow libraries > would use to address this? > - If a recall is already on the record (from the previous step), there are > now two recalls (a record level one, and an item level one) > - On the record page is shows "recalled by X on [date]" - for X it shows the > person who made the latest recall, not the first person who place a recall. > - Is this an edge case to be resolved in a separate bug, or a non-issue? > - It seems logical that multiple patrons could make a recall request for the > same record. What would the workflow be for libraries if they were in this > situation, and how do they resolve this? > I think that is outside of the scope of this particular ticket (because fulfilling recalls via the staff interface came from the original Bug 19532) but at the moment the oldest/earliest placed recall will be picked first, and priority is given to item-level recalls over biblio-level recalls. A follow-up to all of this would be to introduce a priority field like reserves has, but that can come after we bring in functionality to place recalls via the staff interface I think > > David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #15 from Aleisha Amohia --- Created attachment 143155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143155&action=edit Bug 31391: (follow-up) Fix cancel recalls using checkbox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #34 from David Nind --- The patches still apply, but something seems changed: 1. Step 7 - There is now no dropdown list (before there was a drop down list with Only item and Next available); selecting next available and updating removes the drop down list). 2. Step 9 - There is still a dropdown list with the two options (Only item and Next available). Happy to sign off again if that is what is expected. Tests pass both before and after patches are applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] Content field in HTML customizations is too narrow ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass changed: What|Removed |Added Summary|Can't focus on content |Content field in HTML |field in HTML |customizations is too |customizations with mouse |narrow ( CodeMirror ) |click ( CodeMirror )| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] Can't focus on content field in HTML customizations with mouse click ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #1 from Lucas Gass --- Created attachment 143154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143154&action=edit Bug 32104: Prevent console error on additonal-contents.pl To test: 1. Make a new HTML customization, news item, or page with the text editor ( CodeMirror ). 2. Save the content ( not Save and continue ) 3. Notice the console error: 4. Apply patch 5. Try 1 & 2 again. 6. No error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] Can't focus on content field in HTML customizations with mouse click ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 --- Comment #3 from Lucas Gass --- Created attachment 143153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143153&action=edit Bug 32103: Remove flex from tab-content list elements To test: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. It is hard to focus on the Content field because the wrapper width is very small. 3. Apply patch and try again 4. The CodeMirror wrapper width should be normal again. 5. Check the other language tabs. 6. Also test the WYSIWYG editor, it should also be normal. Note: I added some CSS to make the labels appear bold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] Can't focus on content field in HTML customizations with mouse click ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #7 from Aleisha Amohia --- Thanks for testing David (In reply to David Nind from comment #6) > Created attachment 142661 [details] > Screenshot - Receiving order - formatting and default values > > Testing notes and issues/query (tested using koha-testing-docker). > > Three things I noticed: > > 1. Tax Rate system preference warning message > - > Unrelated (exists before patches), see bug 31984 > > 2. Step 13 - Formatting things > -- > Unrelated (exists before patches), maybe open another bug for this? > > 3. For step 13 - Query about using the default values > - > > These values are correctly calculated, but don't match up with the test > plan. So should I have entered the actual costs as 8.00 (the $10 retail > price less the 20% discount, tax exclusive)? Yes I think that's right sorry! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32085] Consistent classes for primary buttons: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (using koha-testing-docker) 1. These change the label templates accessed from Cataloging > Tools > Label creator Barcode image generator Quick spine label creator 2. I struggled on the best way to test these changes. In the end, I: . Reviewed the patch - 31 > Show barcode) - label-bib-search.tt (note: couldn't figure out where this is used from - no results except .po files from "git grep label-bib-search.tt" (git grep label-bib-search.tt ":(exclude)*.po" shows no results)) - label-edit-layout.tt (No change. Label creator > New > Layout) - label-edit-profile.tt (No change. Label creator > New > Printer profile) - label-edit-range.tt (Changed - now orange colour. Label creator > New > Barcode range) - label-edit-template.tt (No change. Label creator > New > Label template) - label-print.tt (No changes. Called from . labels/label-print.pl (Label creator > New > Label batch > [add some barcodes or item numbers] > Add items > select and use any of the export options) . labels/spinelabel-print.pl (Quick spine label creator > [Enter a barcode for an item with a call number] > pop up window with noptions to "Print this label" and "Edit this label")) - search.tt (No change. Label creator > New > Label batch > [leave Add by barocde(s) or itemnumbers field blank] > enter search criteria > Search) (called from label-item-search.pl) - spinelabel-home.tt (No change. Quick spine label creator > 31 > View spine label) 4. Files not changed: - label-edit-batch.tt (Label creator > New > Label batch) - label-home.tt (Label creator) - label-manage.tt (Any of the options for Label creator > Manage) - result.tt (called from label-item-search.pl - see search.tt) - spinelabel-print.tt (result window from spinelabel-home.tt (Quick spine label creator > 31 > View spine label) 5. File count check: - Number of files in folder: 14 - Number of files listed: 14 Questions: 1. Should the buttons be in the div or outisde the div? Those in the white background are: - Barcode image generator - Quick spine label creator 2. I couldn't figure out where label-bib-search.tt is used from - looks like it is not used anywhere. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] Can't focus on content field in HTML customizations with mouse click ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 --- Comment #2 from Lucas Gass --- Ahh, it's because the list element now uses flex. Perhaps this particular content should not do that. We can remedy it by removing the rows class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32085] Consistent classes for primary buttons: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 David Nind changed: What|Removed |Added Attachment #143081|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 143152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143152&action=edit Bug 32085: Consistent classes for primary buttons: Labels This patch makes changes the button markup in label-creation templates -- including the barcode image generator -- so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view label-related pages to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32085] Consistent classes for primary buttons: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #6 from Fridolin Somers --- I'm a fan of JS DataTable ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32012] runreport.pl should use binmode UTF-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012 --- Comment #11 from Fridolin Somers --- This is great :D thanks everyone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] Can't focus on content field in HTML customizations with mouse click ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 --- Comment #1 from Lucas Gass --- I can focus with my mouse but it is difficult the CodeMirror-wrap is only as wide as the content, so when there is no content it is very small. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] New: console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Bug ID: 32104 Summary: console error on additional_content.pl after saving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1. Make a new HTML customization, news item, or page with the text editor ( CodeMirror ). 2. Save the content ( not Save and continue ) 3. Notice the console error: Uncaught TypeError: firstTab[0] is undefined This only seems to happen for me when using CodeMirror. Using the WYSIWYG editor does not produce the console error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] Can't focus on content field in HTML customizations with mouse click ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32103] New: Can't focus on content field in HTML customizations with mouse click ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Bug ID: 32103 Summary: Can't focus on content field in HTML customizations with mouse click ( CodeMirror ) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. Trying using your mouse to focus on the content field. You cannot gain focus. 3. I can use my tab key to focus on the field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #33 from Lari Taskula --- Created attachment 143151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143151&action=edit Bug 31692: (follow-up) Adjust reserves.item_level_hold Original patch missed handling reserves.item_level_hold column. To test: 1. prove t/db_dependent/Koha/Hold.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #32 from Lari Taskula --- (In reply to Katrin Fischer from comment #31) > Oh no... I found an issue :( > > You remove the itemnumber, which would have been enough on old versions, but > now we also need to change reserves.item_level_hold > > Should be an easy fix - please follow-up. Good catch. Although it has been there for 3 years I didn't know of this "new" column :) Fix will follow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32101] Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- Thanks Owen, I've noticed this but neglected to file a bug. Glad to see it fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32101] Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Lucas Gass changed: What|Removed |Added Attachment #143147|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 143150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143150&action=edit Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32101] Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32102] Improve specificity of batch record modification breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102 --- Comment #1 from Owen Leonard --- Created attachment 143149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143149&action=edit Bug 32102: Improve specificity of batch record modification breadcrumbs This patch makes a minor change to the batch record modification template so that there is a link back to the initial view after you have submitted a batch for modification. To test, apply the patch and go to Cataloging -> Batch record modification. - Initially the breadcrumbs menu should show Home -> Cataloging -> Batch record modification - Submit a batch of bibliographic or authority records for modification - The breadcrumbs should now read Home -> Cataloging -> Batch record modification -> Results - The same menu options should show after you confirm the operation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32102] Improve specificity of batch record modification breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return all item values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32102] New: Improve specificity of batch record modification breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102 Bug ID: 32102 Summary: Improve specificity of batch record modification breadcrumbs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org After you've submitted a batch of biblionumbers for modification the breadcrumbs menu doesn't offer you a link back to the initial page where you can submit another batch. The breadcrumbs menu should reflect whether or not you're on the first page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Pedro Amorim changed: What|Removed |Added Attachment #143144|0 |1 is obsolete|| --- Comment #4 from Pedro Amorim --- Created attachment 143148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143148&action=edit Add delete action to stock rotation rotas To test: 1) Enable StockRotation system preference 2) Tools > Stock rotation > New rota 3) Enter Name, save 4) Verify "Delete" button shows on the right 5) Click "Delete" -> Confirm "Yes" 6) Repeat steps 1-3 and click "Manage"->"Stages" 7) Add a new stage, enter Library and Duration, click "Save" 8) Return to rotas, click "Manage"->"Items" 9) Add item, enter barcode, click "Save" (optional: add more than 1 item) 10) Click "return to rotas" and press "Delete" 11) Verify the warning now shows, because items are attached, with the attached items count 12) Click "Delete" -> Deletion is successful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28396] Call number browse pagination
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 --- Comment #7 from Lucas Gass --- Perhaps making this into a dataTable is not a good idea. Maybe instead we can either up the number of results shown at a time. Or maybe a system preference so the number of results can be defined there? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32028] Add page-section to various administration pages (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028 --- Comment #3 from Lucas Gass --- I believe the background jobs page has already handled in Bug 31960. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32101] Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 --- Comment #1 from Owen Leonard --- Created attachment 143147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143147&action=edit Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32101] Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5463] limit to available shows on hold items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #5 from George Williams (NEKLS) --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27973] Limit to currently available items should have an option to filter out notforloan statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #4 from George Williams (NEKLS) --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32028] Add page-section to various administration pages (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028 --- Comment #2 from Lucas Gass --- Created attachment 143146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143146&action=edit Bug 32028: Add page-section to various admin pages This patch adds the page section to div to the following administration pages: admin/cash_registers.tt admin/cities.tt admin/credit_types.tt admin/debit_types.tt admin/patron-attr-types.tt admin/restrictions.tt plugins/plugins-home.tt To test go the following pages and make sure everything looks good: Administration > Cash registers. You must enable the sys pref 'UseCashRegisters' Administration > Cities and towns. Administration > Credit types Administration > Debit types Administration > Patron restrictions Adminstration > Patron attribute types Administration > Manage plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32028] Add page-section to various administration pages (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028 Lucas Gass changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #21 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #20) > As noted in comments before this one, I don't think that making the > description mandatory is the right solution here. I addressed this after the last time you commented on this, please see the patch again, it is not mandatory. Setting the status back to Signed off, let me know if there is something I'm not understanding. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What|Removed |Added Blocks||32101 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 [Bug 32101] Add padding to floating toolbars -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32101] New: Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Bug ID: 32101 Summary: Add padding to floating toolbars Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 30952 Created attachment 143145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143145&action=edit Patron entry form floating toolbar In several cases floating toolbars have no padding, making the layout seem awkward. See attached screenshot. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 --- Comment #3 from Pedro Amorim --- Created attachment 143144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143144&action=edit Add delete action to stock rotation rotas To test: 1) Enable StockRotation system preference 2) Tools > Stock rotation > New rota 3) Enter Name, save 4) Verify "Delete" button shows on the right 5) Click "Delete" -> Confirm "Yes" 6) Repeat steps 1-3 and click "Manage"->"Stages" 7) Add a new stage, enter Library and Duration, click "Save" 8) Return to rotas, click "Manage"->"Items" 9) Add item, enter barcode, click "Save" (optional: add more than 1 item) 10) Click "return to rotas" and press "Delete" 11) Verify the warning now shows, because items are attached, with the attached items count 12) Click "Delete" -> Deletion is successful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #143111|0 |1 is obsolete|| --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 143143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143143&action=edit Bug 8948 (follow-up) Correct OPAC link Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #143084|0 |1 is obsolete|| --- Comment #26 from Andrew Fuerste-Henry --- Created attachment 143142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143142&action=edit Bug 8948: Changes for OPAC Test with same record, confirm OPAC view is as expected Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #143083|0 |1 is obsolete|| --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 143141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143141&action=edit Bug 8948: Display MARC 787 relationship field This field is defined similar to 775, as a related work: https://www.loc.gov/marc/bibliographic/bd787.html This patch adds a display of this field, linking to the referenced record as the 775 does It also tests for 580 field, and displays the text there if present, using the 787 a and t subfields otherwise To test: 1 - Edit the default framework to make 787atw and 580a visible in editor 2 - Add a 787 to a record: $tThe ideas behind the chess openings $aFine, Reuben< $w2470231 3 - Confirm there is no display 4 - Apply patch / restart all 5 - 'Other related works' now shows 6 - Link should be using title of record 7 - Set system preference UseControlNumber to Use 8 - Reload details, link should now use control number 9 - Add a 580 to the record: $a This is a friendly work to this one 10 - Confirm the text of the link now displays before the link 11 - Add a second 580, confirm it displays as well - there is no seperator as each should end with a period or other punctuation according to MARC - there is a dpan with a class surrounding each so styling can be added as desired 12 - Add a second 787 - confirm seperator present and wrapped in a span with a class - confirm each 787 is shown with a span/class for styling Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32099] Consistent classes for primary buttons: Assorted templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099 --- Comment #1 from Owen Leonard --- Created attachment 143140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143140&action=edit Bug 32099: Consistent classes for primary buttons: Assorted templates This patch makes changes the button markup in various assorted templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view the following pages to confirm that everything looks correct. In most cases there are no visible changes. - Staff interface login - Authorities -> Add/edit - Authorities -> Merge - ILL -> ILL requests - Tools -> Patron lists - Administration -> Manage plugins -> Upload plugin - Point of sale - Point of sale -> Transaction history - Holds - Suggestions - Tags - Calendar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32099] Consistent classes for primary buttons: Assorted templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31271] "Edit search" always resets search options to keyword
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||32100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100 [Bug 32100] "edit search" feature quote-wraps search terms if original search had no results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||32100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100 [Bug 32100] "edit search" feature quote-wraps search terms if original search had no results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32100] New: "edit search" feature quote-wraps search terms if original search had no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100 Bug ID: 32100 Summary: "edit search" feature quote-wraps search terms if original search had no results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: andre...@dubcolib.org QA Contact: testo...@bugs.koha-community.org CC: n...@bywatersolutions.com Depends on: 22605, 31271 To recreate: - perform a search that returns no results - on the No Results Found page, click Edit Search - when the search page reloads, note that your search term is now wrapped in double quotes - enter your now-quoted search, then click Edit Search on the No Results page again - your search term is now double-double quoted Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 [Bug 31271] "Edit search" always resets search options to keyword -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31271] "Edit search" always resets search options to keyword
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #143086|0 |1 is obsolete|| --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 143139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143139&action=edit Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31271] "Edit search" always resets search options to keyword
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org --- Comment #4 from Andrew Fuerste-Henry --- (In reply to Andrew Fuerste-Henry from comment #3) > Created attachment 143138 [details] [review] > Bug 31818: Enable table elements in keyboard shortcuts popover > > This patch updates the whitelist for the popover to ensrue our shortcuts > table displays > > To test: > 1 - Open the advanced cataloging editor > 2 - Click 'Keyboard shortcuts' > 3 - Is empty, be sad > 4 - Apply patch > 5 - Reload > 6 - Click it again > 7 - Shortcuts! > > Signed-off-by: Andrew Fuerste-Henry In my testing, I was not able to feel actual sadness in step 3, but maybe we can handle that in a followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #143135|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 143138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143138&action=edit Bug 31818: Enable table elements in keyboard shortcuts popover This patch updates the whitelist for the popover to ensrue our shortcuts table displays To test: 1 - Open the advanced cataloging editor 2 - Click 'Keyboard shortcuts' 3 - Is empty, be sad 4 - Apply patch 5 - Reload 6 - Click it again 7 - Shortcuts! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31819] Formatting of item form in acq when ordering is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31819] Formatting of item form in acq when ordering is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #3 from Lucas Gass --- Created attachment 143137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143137&action=edit Bug 31819: Fix formatting of item form in acq when ordering To test: 1. Apply patch and regenerate CSS ( yarn build ) 2. Add to order from an empty record to an order, make sure the page looks good. 3. Add to order from an existing record to an order, make sure the page looks good. 4. In neworderempty.pl add some new items to the order by clicking 'Add item'. The item lists table should now appear, confirm it looks right. 5. Save the form, ensuring everthing still works as it should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31819] Formatting of item form in acq when ordering is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31819] Formatting of item form in acq when ordering is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067 Owen Leonard changed: What|Removed |Added Depends on||32099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099 [Bug 32099] Consistent classes for primary buttons: Assorted templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32099] New: Consistent classes for primary buttons: Assorted templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099 Bug ID: 32099 Summary: Consistent classes for primary buttons: Assorted templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 32067 As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons: This patch will update buttons in remaining unchanged templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes. In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067 [Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #142082|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 143136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143136&action=edit Bug 31557: Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library Right now the holds queue builder starts filling bib-level holds with items whose patron's home library matches the item's home library. It would be good and reasonable to have the option to prioritize item's whose patron's home library matches the item's holding library to minimize transfers. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 --- Comment #2 from Nick Clemens --- Created attachment 143135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143135&action=edit Bug 31818: Enable table elements in keyboard shortcuts popover This patch updates the whitelist for the popover to ensrue our shortcuts table displays To test: 1 - Open the advanced cataloging editor 2 - Click 'Keyboard shortcuts' 3 - Is empty, be sad 4 - Apply patch 5 - Reload 6 - Click it again 7 - Shortcuts! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #97 from Kyle M Hall --- Created attachment 143134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143134&action=edit Bug 26635: (QA follow-up) Remove test for x-koha-av-expand header This patch updates the last remaining test that mentioned the now defunkt x-koha-av-expand header. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5463] limit to available shows on hold items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #96 from Kyle M Hall --- Created attachment 143133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143133&action=edit Bug 26635: (follow-up) Add optional support for `:` as the modifier This patch adds optional support for using `:` as the modifier for invoking the 'count' method for relations as discussed. We retain support for `+` for backward compatability to prevent a breaking change. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #95 from Kyle M Hall ---
Created attachment 143132
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143132&action=edit
Bug 26635: Move expand syntax to x-koha-embed
Instead of a global av-expand flag (through a header) this patch
proposes to allow specifying +av_expand at the x-koha-embed header
level. This allows a more fine-grained control on what objects get avs
expanded. e.g.:
GET /patrons/123
x-koha-expand: +av_expand,checkouts.item+av_expand
=>
{
"_str": {
"city": { "str": "Córdoba", ... }
},
...
"checkouts": [
{
...,
"item": {
"_str": {
"not_for_loan_status": { "str": "Reference material", ...
},
...
},
...
}
}
]
}
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t \
t/Koha/REST/Plugin/Query.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
2. Sign off :-D
Signed-off-by: Martin Renvoize
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #94 from Kyle M Hall ---
Created attachment 143131
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143131&action=edit
Bug 26635: Refined data structure and methods
This patch makes the returned data structure be simpler:
_str => {
attribute_1 => {
category => 'some_category_name',
str => 'description',
type => 'av'
},
...
}
The description is sensible to context, so if public => 1 is passed,
then lib_opac is passed, and lib is returned otherwise. Whenever we add
language to the combo, we will add it to the implementation.
Tests are adjusted accordingly, also to reflect the public => 1 use
case.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
