[Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154 Jonathan Druart changed: What|Removed |Added Depends on||32030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What|Removed |Added Blocks||32154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154 [Bug 32154] Missing primary key on erm_user_roles table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163 --- Comment #1 from Jonathan Druart --- Created attachment 143623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143623=edit Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole Test plan: run t/db_dependent/TestBuilder.t and confirm that the error related to this module is gone. Another one may still fail however -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154 Jonathan Druart changed: What|Removed |Added Blocks||32163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163 [Bug 32163] ErmUserRole has wrong koha_object[s]_class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163 Jonathan Druart changed: What|Removed |Added Depends on||32154 Keywords||rel_22_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154 [Bug 32154] Missing primary key on erm_user_roles table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What|Removed |Added Blocks||32163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163 [Bug 32163] ErmUserRole has wrong koha_object[s]_class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32163] New: ErmUserRole has wrong koha_object[s]_class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163 Bug ID: 32163 Summary: ErmUserRole has wrong koha_object[s]_class Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 32030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 --- Comment #1 from Jonathan Druart --- Created attachment 143622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143622=edit Bug 32162: Add primar key to erm_eholdings_packages_agreements Test plan: Confirm that this change fixes the related TestBuilder.t failure Confirm that it does not break the eRM app, try to attach an agreement to a package. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What|Removed |Added Blocks||32162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 [Bug 32162] erm_eholdings_packages_agreements does not have a primary key -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32162] New: erm_eholdings_packages_agreements does not have a primary key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 Bug ID: 32162 Summary: erm_eholdings_packages_agreements does not have a primary key Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 32030 And TestBuilder.t is failing because of this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong koha_object_class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong koha_object_class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161 --- Comment #1 from Jonathan Druart --- Created attachment 143621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143621=edit Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement Test plan: run t/db_dependent/TestBuilder.t and confirm that the error related to this module is gone. Another one may still fail however -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong koha_object_class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What|Removed |Added Blocks||32161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161 [Bug 32161] ErmEholdingsPackagesAgreement has wrong koha_object_class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32161] New: ErmEholdingsPackagesAgreement has wrong koha_object_class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161 Bug ID: 32161 Summary: ErmEholdingsPackagesAgreement has wrong koha_object_class Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 32030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154 Jonathan Druart changed: What|Removed |Added Attachment #143565|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 143620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143620=edit Bug 32154: Missing primary key on erm_user_roles table The aforementioned TestBuilder should display "Koha::ERM::UserRole", not be empty. This patch adds a primary key to the erm_user_roles table and fixes that. Also includes atomicupdate file to update database schema as well as updates to kohastructure.sql provided by Jonathan Druart. Looked into the vue files but didn't find anywhere or a need to include the new primary key in any of the requests as there is no request of users by role_user_id being made. Erm users are being created/updated as a relationship through licenceses/agreements. Furthermore, when editing a role of an existing user, this new primary key is already being supplied embeded in the license/agreement. Test plan: Add users to license and agreement Run the cypress tests Confirm that the change fix the test that was failing in TestBuilder.t (another one may still fail however) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What|Removed |Added Version(s)|22.11.00| released in|| --- Comment #42 from Jonathan Druart --- (In reply to Jonathan Druart from comment #39) > (In reply to Marcel de Rooy from comment #36) > > File not found : js/vue/dist/main.js at > > /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. > > > > Does this module not work on a dev install ? > > `yarn build_js` will generate it > Should have been done by Tomas, as we agreed on... This was wrong, we agreed on generating them at releasing time. See https://lists.koha-community.org/pipermail/koha-devel/2022-November/047385.html for more details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #12 from Emmi Takkinen --- Setting this as Needs Signoff, notice form shouldn't now be saved when pressing cancel on pop-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff Keywords||rel_22_11_candidate Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |pjamori...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32108] Change "x" icon to replace patron when scheduling a pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #10) > Is it expected that the search doesn't work with cardnumber? Or is it > because 42 is too short an input? The autocomplete starts at 3 chars, yes. Is that a problem? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #49 from Lari Taskula --- (In reply to David Nind from comment #40) > I've ended up adding sign off lines for the first two patches - not sure how > to remove those! I've removed those for you. (In reply to Katrin Fischer from comment #41) > There is a conflict in the .t, can you please fix? Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Attachment #143616|0 |1 is obsolete|| --- Comment #48 from Lari Taskula --- Created attachment 143619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143619=edit Bug 31692: (follow-up) Adjust reserves.item_level_hold Original patch missed handling reserves.item_level_hold column. To test: 1. prove t/db_dependent/Koha/Hold.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Attachment #143615|0 |1 is obsolete|| --- Comment #47 from Lari Taskula --- Created attachment 143618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143618=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown is gone and cell value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds for the same patron 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Attachment #143614|0 |1 is obsolete|| --- Comment #46 from Lari Taskula --- Created attachment 143617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143617=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #45 from Lari Taskula --- I accidentally removed the signed-off lines from patches, fixing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #267 from David Cook --- (In reply to Tomás Cohen Arazi from comment #266) > The third patch introduced it. Ahhh, I see it now. I expected it to be in the usual alphabetical order, but I do see it now. All good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Attachment #143162|0 |1 is obsolete|| --- Comment #44 from Lari Taskula --- Created attachment 143616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143616=edit Bug 31692: (follow-up) Adjust reserves.item_level_hold Original patch missed handling reserves.item_level_hold column. To test: 1. prove t/db_dependent/Koha/Hold.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Attachment #143161|0 |1 is obsolete|| --- Comment #43 from Lari Taskula --- Created attachment 143615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143615=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Attachment #143160|0 |1 is obsolete|| --- Comment #42 from Lari Taskula --- Created attachment 143614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143614=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32130] Vue files must be kept tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Tested (using KTD) by running prove xt/vue_tidy.t I hope that is sufficient. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32130] Vue files must be kept tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 David Nind changed: What|Removed |Added Attachment #143387|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 143613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143613=edit Bug 32130: Add a test to ensure vue files will be kept tidy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32130] Vue files must be kept tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after uninstalling a plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #3 from David Nind --- I'm getting an error trace after applying the patch and restarting everything (flush_memcached and restart_all, using koha-testing-docker)(step 7): try() encountered an unexpected argument (undef) - perhaps a missing semi-colon before or at /kohadevbox/koha/Koha/Plugins.pm line 251. at /usr/lib/x86_64-linux-gnu/perl-base/Carp.pm line 289 Testing with the ByWater Solutions kitchen sink plugin. Before applying the patch, I can install plugins without any problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32160] New: Batch record modification - show MARC preview no longer works
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32160 Bug ID: 32160 Summary: Batch record modification - show MARC preview no longer works Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: da...@davidnind.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When clicking on the 'Show MARC' action from the list of records to be modified using Cataloguing > Batch record modification, it shows as 'Loading' and does not complete the display of the modified MARC record. In the web developer tools an error is displayed: 14:24:26.131 XHR GET http://127.0.0.1:8081/cgi-bin/koha/svc/records/preview?record_type=biblio_id=262=3_context=batchmod [HTTP/1.1 500 Internal Server Error 87ms] To replicate using koha-testing-docker (KTD): 1. Add a MARC modification template (Cataloguing > MARC modification templates > New template > give it a name and click submit > add a 'New action" (for example: Add new 500$a with value 'OK')). 2. Modify a batch of records (Cataloguing > Batch record modification): - For 'Enter a list of record numbers' enter 17 and 262 (sample data for KTD) - Choose the template you created in step 1 - Press Continue 3. Enable the web developer tools console. 3. From the results list, click on 'Show MARC'. 4. On the modal window, note that the spinner says 'Loading', and doesn't complete the display of the MARC. 5. Note that in the web developer tools console there is an error: 14:24:26.131 XHR GET http://127.0.0.1:8081/cgi-bin/koha/svc/records/preview?record_type=biblio_id=262=3_context=batchmod [HTTP/1.1 500 Internal Server Error 87ms] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32102] Improve specificity of batch record modification breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102 David Nind changed: What|Removed |Added Attachment #143149|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 143612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143612=edit Bug 32102: Improve specificity of batch record modification breadcrumbs This patch makes a minor change to the batch record modification template so that there is a link back to the initial view after you have submitted a batch for modification. To test, apply the patch and go to Cataloging -> Batch record modification. - Initially the breadcrumbs menu should show Home -> Cataloging -> Batch record modification - Submit a batch of bibliographic or authority records for modification - The breadcrumbs should now read Home -> Cataloging -> Batch record modification -> Results - The same menu options should show after you confirm the operation Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32102] Improve specificity of batch record modification breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32108] Change "x" icon to replace patron when scheduling a pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108 Katrin Fischer changed: What|Removed |Added Attachment #143180|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 143611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143611=edit Bug 32108: Replace "x" icon with the "search" icon Change "x" icon to replace patron when scheduling a pickup. Test plan: Schedule a new pickup, select a patron, notice the change. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32108] Change "x" icon to replace patron when scheduling a pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32108] Change "x" icon to replace patron when scheduling a pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108 --- Comment #10 from Katrin Fischer --- Is it expected that the search doesn't work with cardnumber? Or is it because 42 is too short an input? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31262] Curbside pickups - disable dates without slots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Katrin Fischer changed: What|Removed |Added Attachment #143294|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 143610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143610=edit Bug 31262: Curbside pickup - Remove day without slots We disable dates from the date picker that do not have slots defined in the configuration. Note that dates that have slots configured but none are available will still be displayed. To implement that we would need to calculate the availability for all the dates displayed on the widget (1 month) and that will (certainly) slow down considerabily the UI. Test plan: Configure curbside pickup for a given library. Define slots for several days of the week (not all). Schedule a pickup and confirm that only the days with slots defined are available in the date picker widget Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31262] Curbside pickups - disable dates without slots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #7 from Katrin Fischer --- (In reply to Lucas Gass from comment #6) > It looks like I can only make the error happen when using Firefox. Hm I did use Firefox :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #6 from Lucas Gass --- It looks like I can only make the error happen when using Firefox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #5 from Katrin Fischer --- I couldn't make it happen when I tried earlier, maybe another set of eyes would help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #4 from Lucas Gass --- (In reply to Katrin Fischer from comment #3) > I didn't see the console error on master - could you please verify if maybe > bug 31609 fixed this? It did not, the console error remains. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #41 from Katrin Fischer --- There is a conflict in the .t, can you please fix? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32101] Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Katrin Fischer changed: What|Removed |Added Attachment #143150|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 143609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143609=edit Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32101] Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #266 from Tomás Cohen Arazi --- (In reply to David Cook from comment #265) > (In reply to Marcel de Rooy from comment #263) > > Error while loading /etc/koha/plack.psgi: Can't load application from file > > "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm > > in @INC > > > > Should we mark this as dependency for Mason please? > > > > apt-get install libmojolicious-plugin-oauth2-perl > > apt-get install libmojolicious-plugin-renderfile-perl > > I can see 'Mojolicious::Plugin::RenderFile' in cpanfile, but I can't see > 'Mojolicious::Plugin::OAuth2'. The third patch introduced it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #26 from David Cook --- (In reply to Katrin Fischer from comment #25) > (In reply to David Cook from comment #24) > > (In reply to Katrin Fischer from comment #23) > > > It might also hinder a a quick desaster recovery to a different server? At > > > least something more to think about for backups etc. > > > > With the encryption key in koha-conf.xml, they wouldn't be able to decrypt > > the encrypted passwords in the database either. > > True, so something to keep in mind then for the sysadmins? Yeah, I mean there's other bits of config that this happens for too. I use the "OAI-PMH:ConfFile" syspref, and if you just restore the database dump without including the server-side file, it'll break the OAI. So sysadmins really need to keep in mind that the database and server-side config need to be restored together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #36 from David Cook --- I was doing some more thinking... On one hand, I was thinking maybe we should make a more consistent login box. For instance, if you go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=add_form, the opac-auth.tt template creates a login box that works as expected. But the modal sends you off to opac-user.pl. There's no reason the masthead.inc couldn't create the same login box as opac-auth.tt. On the other hand, I like the idea of login endpoints (like with SSO), which need to redirect you back, so maybe this redirect is fine (so long as we're rewriting/validating the redirect URLs) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #35 from David Cook --- Note that while the code checks for URI::http as the URI class type, this includes URI::https since it subclasses URI::http, so it works for OPACBaseURL using either HTTP or HTTPS URLs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #34 from David Cook --- Created attachment 143608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143608=edit Bug 31699: (follow-up) Protect more against open redirects This change checks that the OPACBaseURL exists, and uses its scheme and authority to rewrite the URL passed through the "return" param. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #33 from David Cook --- With my upcoming patch, Without OPACBaseURL, no redirection happens for the following: http://localhost:8080/cgi-bin/koha/opac-user.pl?return=http://koha-community.org/test?test=test With OPACBaseURL, the return URL is rewritten to use the scheme and authority of OPACBaseURL, so that the following: http://localhost:8080/cgi-bin/koha/opac-user.pl?return=http://koha-community.org/test?test=test#test Redirects to: http://localhost:8080/test?test=test#test -- So it shouldn't be possible to send a user anywhere other than http://localhost:8080. (An alternative would be to set the page visited in the user's database session and then juggle that around and try to return to that, but that would be a more difficult code change than Martin's patches here.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Katrin Fischer changed: What|Removed |Added Attachment #143596|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 143607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143607=edit Bug 32148: Buttons must inherit Bootstrap size classes This patch removes global font and padding settings which were overriding the Bootstrap classes we use to change the size of Bootstrap buttons. The font and padding settings are moved to the CSS which covers button which are not styled as Bootstrap buttons. To test, apply the patch and view pages where buttons are styled with different Bootstrap size classes: - Circulation -> Check out: - The "Check out" button, the "Show checkouts" button, Renew buttons in the footer. - Patrons -> Patron details -> Edit buttons in each section. - Patrons home -> Buttons in sidebar filter - Catalog -> Bibliographic details -> Item details Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #32 from David Cook --- (In reply to David Cook from comment #31) > If I erase OPACBaseURL, then I get the open redirect vulnerability again. Worth noting that this affects only logged in users. The redirect code won't trigger for anonymous users, since we short-circuit opac-user.pl for anonymous users and prompt with a regular login box. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #31 from David Cook --- At the moment, with Martin's patches, the following will generate a "ERR_INVALID_REDIRECT": http://localhost:8080/cgi-bin/koha/opac-user.pl?return=http://koha-community.org/test If I erase OPACBaseURL, then I get the open redirect vulnerability again. So now I'll add a patch... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31928] Add page-section to callnumber browser value builder (cat)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Katrin Fischer changed: What|Removed |Added Attachment #143594|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 143606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143606=edit Bug 31928: Add page-section to callnumber browser value builder (cat) This patch adds a page-section div around the search results shown by the call number browser plugin in Cataloging. The patch also restructures the search form so that the layout is correct. To test you must have an item subfield linked to the call number browser plugin: - Go to MARC frameworks -> Default MARC framework -> MARC structure. - Locate the 952 tag and click Actions -> Edit subfields. - Open the "o" tab and in the last section, "Other options," choose "cn_browser.pl" for the plugin field. Open an item record for editing: - Go to Cataloging and search for a bibliographic record. - Click Actions -> Add/Edit items for one of the results. - In the item edit form, the "o - Full call number" field should have a "..." link at the end. - Clicking it should trigger a popup window. - The search form at the top should be laid out correctly. - Perform a search which will return results. - The table of results should be contained within a white box. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31928] Add page-section to callnumber browser value builder (cat)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #30 from David Cook --- (In reply to David Nind from comment #29) > The last follow-up has "broken" the redirect used for bug 31028 - Catalog > concerns (see comment 323 (!!)), so it may pay to test with that bug. That's interesting. I don't think it would've been the follow-up, so much as the whole feature. How were you setting the data-return attribute? I think that might be part of your problem? (Interestingly, it looks like opac-reserve.pl might be broken in master as well on an unrelated note...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32146] Add page-section to course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146 Katrin Fischer changed: What|Removed |Added Attachment #143586|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 143605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143605=edit Bug 32146: Add page-section to course reserves This patch adds a "page-section" wrapping div to two Course Reserves templates. Note: This patch contains indentation changes. To test, apply the patch and go to Course Reserves. - The table of course reserves should appear in a white section. - View the details of a course: There should be a white section for the list of details at the top and another for the table of reserves. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32146] Add page-section to course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31828] Add page-section to list of open invoices on receive shipment page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Katrin Fischer changed: What|Removed |Added Attachment #143593|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 143604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143604=edit Bug 31828: Add page-section to list of open invoices on receive shipment page (acq) This patch adds a "page-section" class to the div wrapping the table of shipments on the "Receive shipment" page in Acquisitions. This patch also modifies the markup around additional fields so that an empty fieldset is not displayed when there are no additional fields to display. To test, apply the patch and go to Acquisitions. - Locate a vendor and view its details. - In the toolbar, click "Receive shipments." - On the receive page, there should be a section listing shipments and a section headed "Receive a new shipment." - If you have additional fields defined (in Administration -> Additional fields -> Invoices) there should be a third section showing those fields. - With no additional fields defined you should not see an empty fieldset. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31828] Add page-section to list of open invoices on receive shipment page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31828] Add page-section to list of open invoices on receive shipment page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31827] Add page-section to list to log viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827 Katrin Fischer changed: What|Removed |Added Attachment #143591|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 143603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143603=edit Bug 31827: Add page-section to list to log viewer This patch adds a "page-section" container div around the log viewer output. To test, apply the patch and go to Tools -> Logs. - Perform a log search which will return results. - The table of results should appear in a white box. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31827] Add page-section to list to log viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31826] Add page-section to item form on order receive page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826 Katrin Fischer changed: What|Removed |Added Attachment #143590|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 143602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143602=edit Bug 31826: Add page-section to item form on order receive page (acq) This patch adds a "page-section" class to the container div around the items table on the order receive page in acquisitions. To test, apply the patch and go to Acquisitions. - Locate a vendor and few its details. - Click "Receive shipments." - Fill out the "Receive shipment" form if you have no existing shipments. Otherwise click on the invoice number link to get to the "Receive orders" page. - In the table of pending orders, click a "Receive" link. - On the "Receive items" page there should be three sections: Catalog details, Acquisitions details, and Items. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31826] Add page-section to item form on order receive page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #29 from David Nind --- The last follow-up has "broken" the redirect used for bug 31028 - Catalog concerns (see comment 323 (!!)), so it may pay to test with that bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31824] Add page-section to list of pending/received orders (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824 Katrin Fischer changed: What|Removed |Added Attachment #143589|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 143601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143601=edit Bug 31824: Add page-section to list of pending/received orders (acq) This patch adds a "page-section" class to the divs wrapping two sections on the "Receive orders" page in Acquisitions. To test, apply the patch and go to Acquisitions. - Locate a vendor and view its details. - In the toolbar, click "Receive shipments." - If you have existing shipments listed in the first section, click the invoice number link. - If not, fill out the "receive a new shipment" form and submit it. - On the "Receive orders" page there should be two sections: "Pending orders" and "Already received." Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31824] Add page-section to list of pending/received orders (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699
--- Comment #28 from David Cook ---
Comment on attachment 143469
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143469
Bug 31699: (follow-up) Protect against unauthorized redirects
Review of attachment 143469:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=31699=143469)
-
::: opac/opac-user.pl
@@ +428,5 @@
> # back to the page we triggered the login from
> my $return = $query->param('return');
> if ( $return ) {
> +my $uri = C4::Context->preference('OPACBaseURL');
> +$uri .= $return;
If OPACBaseURL isn't set, which happens more often than I'd like, this would
still be vulnerable to open redirects.
I was thinking that we'd re-write the URL using the URI module.
Today, I thought we could potentially get away with nuking the "scheme" and
"authority", but then I figured out a URL trick to get it to redirect to a
malicious URL.
So I think we need to do a bit more validation. I'll write up a quick patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31824] Add page-section to list of pending/received orders (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31823] Add page-section to uncertain prices page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823 Katrin Fischer changed: What|Removed |Added Attachment #143588|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 143600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143600=edit Bug 31823: Add page-section to uncertain prices page (acq) This patch adds a "page-section" wrapping div to the uncertain prices page in Acquisitions Note: This patch contains indentation changes. To test, apply the patch and go to Acquisitions. - Locate a vendor and view its details - In the left-hand sidebar, click "Uncertain prices." - The page should have two sections: Details about the vendor, and a list of orders with uncertain prices. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31823] Add page-section to uncertain prices page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32159] New: Uncertain prices has 2 level 1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 Bug ID: 32159 Summary: Uncertain prices has 2 level 1 headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy, accessibility Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Instead of h1 - h2 - h2 we have 2 h1 headings with almost the same text on the uncertain prices page in acquisitions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32104] console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #3 from Katrin Fischer --- I didn't see the console error on master - could you please verify if maybe bug 31609 fixed this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32043] Circulation alerts can overlap other elements on smaller screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043 Katrin Fischer changed: What|Removed |Added Attachment #143291|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 143599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143599=edit Bug 32043: Circulation alerts can overlap other elements on smaller screens This patch makes a minor change to CSS controlling the appearance of the dialog which appears on the checkout page when a confirmation is required. To test, apply the patch and rebuild the staff interface CSS. Open a patron account for checkout, and submit the barcode of an item which will require confirmation before the operation can be completed. For example: - Item on hold for another patron - Item waiting for another patron - Item is checked out to another patron. The confirmation dialog should have a comfortable margin between it and the checkout form. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32043] Circulation alerts can overlap other elements on smaller screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What|Removed |Added Blocks||32158 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158 [Bug 32158] Specify due date field is very long now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32158] New: Specify due date field is very long now
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158 Bug ID: 32158 Summary: Specify due date field is very long now Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 30952 When checking out an item with a specified due date, this field is stretched the full length of the options area now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #27 from David Cook --- (In reply to Martin Renvoize from comment #21) > Sorry chaps, it was late last night when this discussion took place. I've > marked it assigned and will work on it today. > > Bit disappointed with myself that I didn't spot this at initial development. > Still, it should be a trivial follow-up. No worries. We're all human and it's why it's always good to have another set of eyes on things! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32043] Circulation alerts can overlap other elements on smaller screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 --- Comment #35 from Katrin Fischer --- Hm, but: + + +Other related works: + + + +a + + + + You only display the 580 of a 787 exists and it displays after the "Other related works" which is the 787 label. The problem is: 580 might belong to ANY 7xx field, not just the 787. In the documentation there are examples for 773 and 785 respectively. The problem is not if there are mulitple 787, but if we give a totally wrong context here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #25 from Katrin Fischer --- (In reply to David Cook from comment #24) > (In reply to Katrin Fischer from comment #23) > > It might also hinder a a quick desaster recovery to a different server? At > > least something more to think about for backups etc. > > With the encryption key in koha-conf.xml, they wouldn't be able to decrypt > the encrypted passwords in the database either. True, so something to keep in mind then for the sysadmins? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 --- Comment #34 from Nick Clemens --- (In reply to Katrin Fischer from comment #33) > (In reply to Katrin Fischer from comment #32) > > This wasn't PQA for a reason. Displaying 580 in context of 787 is not > > correct, I'd even say it can lead to things looking quite wrong. Please see > > comment#20. > > We should remove 580 display for the time being. I did move the 580, they display after the 787 While they could mismatch, in general the documentation makes it seem it will be clear which note relates to which link. The 580 can now also be easily styled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #24 from David Cook --- (In reply to Katrin Fischer from comment #23) > It might also hinder a a quick desaster recovery to a different server? At > least something more to think about for backups etc. With the encryption key in koha-conf.xml, they wouldn't be able to decrypt the encrypted passwords in the database either. (In reply to Kyle M Hall from comment #22) > (In reply to Victor Grousset/tuxayo from comment #21) > > That's why I wondered if there was any gain compared to just storing the > > passwords into koha-conf.xml directly? (or another file) > > Simply put, imo, that would mean librarians could no longer update that data > without help from the server administrator, making their jobs more difficult. Agreed with Kyle. There needs to be a balance between security and functionality/convenience. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #265 from David Cook --- (In reply to Marcel de Rooy from comment #263) > Error while loading /etc/koha/plack.psgi: Can't load application from file > "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm > in @INC > > Should we mark this as dependency for Mason please? > > apt-get install libmojolicious-plugin-oauth2-perl > apt-get install libmojolicious-plugin-renderfile-perl I can see 'Mojolicious::Plugin::RenderFile' in cpanfile, but I can't see 'Mojolicious::Plugin::OAuth2'. I think cpanfile might need an update? I think debian/control gets updated at release time... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed --- Comment #33 from Katrin Fischer --- (In reply to Katrin Fischer from comment #32) > This wasn't PQA for a reason. Displaying 580 in context of 787 is not > correct, I'd even say it can lead to things looking quite wrong. Please see > comment#20. We should remove 580 display for the time being. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 --- Comment #32 from Katrin Fischer --- This wasn't PQA for a reason. Displaying 580 in context of 787 is not correct, I'd even say it can lead to things looking quite wrong. Please see comment#20. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #33 from David Cook --- (In reply to Martin Renvoize from comment #32) > Any chance of sharing those patches David? They're a bit hacky but I could certainly share them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142 Aleisha Amohia changed: What|Removed |Added Text to go in the||This enhancement adds an release notes||issued_or_reserved option ||to the HoldFeeMode system ||preference, so that a hold ||fee may be charged if ||either all items are check ||out, or the record has at ||least one hold already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
