[Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a column we're not expecting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #32 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #28) > First and last patches are useless, can we remove them? So I did now, making Martin loose his attribution. One of the reasons why I didnt do it in the first place.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a column we're not expecting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #31 from Marcel de Rooy --- Created attachment 144277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144277=edit Bug 32350: Add subtest for bad columns Test plan: Run t/db_dependent/TestBuilder.t And now run the whole test suite :) Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a column we're not expecting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy changed: What|Removed |Added Attachment #144245|0 |1 is obsolete|| Attachment #144246|0 |1 is obsolete|| Attachment #144247|0 |1 is obsolete|| Attachment #144248|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 144276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144276=edit Bug 32350: Use array_minus and ignore nesting Note: Test will be extended in follow-up. This fixes the module_bit hash to follow the FK path from user_permissions to permissions to userflags. One step was missed in the existing test, although it did not fail. The change here revealed that now. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32355] Add class url to all URL syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355 Didier Gautheron changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32355] Add class url to all URL syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355 --- Comment #1 from Didier Gautheron --- Created attachment 144275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144275=edit Bug 32355: Add css class url to URL syspref Add missing css class to URL syspref. To Test: 1 - open admin/preferences.pl 2 - Search for URL 3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL, PrivacyPolicyURL, LibrisURL input field size are small. 4 - Apply patch 5 - all URL fields have the same bigger size. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32355] New: Add class url to all URL syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355 Bug ID: 32355 Summary: Add class url to all URL syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: didier.gauthe...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Hi, Some syspref aren't defined as class url and their input field is too small. To Test: 1 - open admin/preferences.pl 2 - Search for URL 3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL, PrivacyPolicyURL, LibrisURL input field size are small. 4 - Apply patch 5 - all URL fields have the same bigger size. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] Release team 23.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 --- Comment #12 from Victor Grousset/tuxayo --- > This patch adds the 'Rosalie' codename to the 22.11 release and adds > corresponding support to the about page for displaying it. Thanks a lot! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32078] We should have an easy way for an administrator to update the encryption keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078 --- Comment #3 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #2) > > The tricky thing is that we don't currently have a way of noting which key > > was used to encrypt which field. > > As long as there is one key at the time, it's not needed. The update process > should be one transaction to guaranty that though. That's not going to scale. If you have a large number of amount of data, that's going to be slow, require downtime, and potentially put unnecessary load on the database server. Large transactions are rarely a programmer's friend. That said, it would be easier in the short-term and for small databases. So certainly better than nothing. > > However, we have no easy way to change key should that key be leaked or > > found to be to simple to crack > > > It's generated so cracking shouldn't be an issue. As for a leak, yes a > webserver misconfiguration or a vulnerability in Koha or another app on the > same server could expose the config file while still having the DB unleaked. Theoretically we might learn of new computing methods that mean the generated key is too weak, and we need to employ a different algorithm. What Martin is saying is that there's no way to currently re-encrypt using a stronger/unknown key. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 --- Comment #61 from Victor Grousset/tuxayo --- Updated doc to reflect this: https://wiki.koha-community.org/wiki/System_requirements_and_recommendations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually authorize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797 --- Comment #8 from David Cook --- (In reply to David Cook from comment #7) > (In reply to Aleisha Amohia from comment #6) > > Is this still valid? Noting Bug 31378 has now been pushed upstream. > > Bug 31378 is unrelated That said, I have thought about how it would be cool to use tokens from an OIDC IdP to allow access to Koha's REST API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually authorize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797 --- Comment #7 from David Cook --- (In reply to Aleisha Amohia from comment #6) > Is this still valid? Noting Bug 31378 has now been pushed upstream. Bug 31378 is unrelated. This bug is about using OAuth tokens from the /api/v1/oauth/token endpoint. I don't think this bug was ever valid. I've only used the Cookie auth and HTTP Basic auth for the REST API, so I can't really speak to the OAuth2 auth for the REST API, but the issue report and patch don't really make sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32354] Handle session_state param given by OAuth identity provider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- I noticed this during testing as well. I was able to turn off session management in Keycloak, but that might not be possible in all identity providers. I'll come back to this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32335] Allow stock rotation items to be moved several stages ahead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Martin Renvoize changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Katrin Fischer changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32335] Allow stock rotation items to be moved several stages ahead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 --- Comment #4 from Katrin Fischer --- Sounds more like an enh than a bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32305] Background worker doesn't check jobs receive from rabbitmq are in 'new' state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305 Katrin Fischer changed: What|Removed |Added Summary|Background worker doesn't |Background worker doesn't |check jobs receive from |check jobs receive from |rabbitmq are in 'new' |rabbitmq are in 'new' state |state. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31381] Searching patrons by letter broken when using non-mandatory extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381 Katrin Fischer changed: What|Removed |Added Summary|[Intranet/REST-API] |Searching patrons by letter |Searching patrons by letter |broken when using |broken when using |non-mandatory extended |non-mandatory extended |attributes |attributes | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32354] Handle session_state param given by OAuth identity provider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 Aleisha Amohia changed: What|Removed |Added Text to go in the||This patch ensures Koha release notes||doesn't throw an error if ||the IdP hands back a ||session_state parameter. Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32354] Handle session_state param given by OAuth identity provider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 --- Comment #1 from Aleisha Amohia --- Created attachment 144274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144274=edit Bug 32354: Accept session_state param given by OAuth IdP This patch ensures Koha doesn't throw an error if the IdP hands back a session_state parameter. To test: 1) Set up an identity provider 2) On the IdP's configuration, make it hand back a session_state 3) Confirm authentication using OIDC works with and without the session_state Sponsored-by: Plant & Food Research -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Aleisha Amohia changed: What|Removed |Added Blocks||32354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 [Bug 32354] Handle session_state param given by OAuth identity provider -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32354] Handle session_state param given by OAuth identity provider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 Aleisha Amohia changed: What|Removed |Added Depends on||31378 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32354] New: Handle session_state param given by OAuth identity provider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
Bug ID: 32354
Summary: Handle session_state param given by OAuth identity
provider
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: blocker
Priority: P5 - low
Component: Authentication
Assignee: koha-bugs@lists.koha-community.org
Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org
We're trying Bug 31378 in production with OpenID Connect and Azure AD.
Azure is passing back a parameter session_state which causes Koha to throw a
'malformed query string' error
[{"message":"Malformed query string","path":"\/query\/session_state"}]
Believe this means we need to add session_state to the list of parameters Koha
can expect from the IdP.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually authorize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #6 from Aleisha Amohia --- Is this still valid? Noting Bug 31378 has now been pushed upstream. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32126] Adding item search fields is broken - can't add more than one field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Katrin Fischer --- A major bug, a silly easy fix, but noone to QA? :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
