[Koha-bugs] [Bug 31059] encryption_key config entry not generated when upgrading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059 --- Comment #3 from Katrin Fischer --- We could add something to the about page and future release notes here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff client advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff client advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #3 from wainuiwitikap...@catalyst.net.nz --- Created attachment 144310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144310&action=edit Bug 32301: defaultSortField changes the default Sort By in Staff Client Advanced Search Use the system preference "defaultSortField" to choose the default Sort By in the Staff Client Advances Search To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search Sponsored-by: National Institute of Atmospheric and Water Research -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32354] Handle session_state param given by OAuth identity provider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 --- Comment #4 from David Cook --- (In reply to Tomás Cohen Arazi from comment #3) > We need to document it better. Understand if the param name is standard, if > it needs to be carried around in responses as well, etc. I'm not 100% sure what you mean, but I think I agree. I've got a deadline tomorrow, but I'm hoping to look at this in December. I'll be testing with Keycloak. That said, from what I've read so far at https://openid.net/specs/openid-connect-session-1_0.html, it looks like the session_state is just used by optional client side iframes for checking the user's session status with the IdP. So I think we can accept session_state in the IdP's AuthN response without actually supporting OIDC session management ourselves. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32354] Handle session_state param given by OAuth identity provider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #3 from Tomás Cohen Arazi --- We need to document it better. Understand if the param name is standard, if it needs to be carried around in responses as well, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi |ity.org | --- Comment #6 from David Nind --- I've changed the assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Tests pass both before and after the patch is applied. However, I don't think the databaseupdate updates existing installations. I had to do a reset_all to replicate a new installation (using koha-testing-docker). Not that I really know how all this should work! Testing notes: 1. Access the database: koha-mysql kohadev 2. Show the current database configuration - the default before the patch is applied for days_in_advance is 0. SQL query: show columns from borrower_message_preferences; 3. Apply the patch. 4. Update the database (updatedatabase). 5. Repeat steps 1-2 - the default for days_in_advance should now be NULL.[1] 6. Tests should pass: . prove t/db_dependent/cronjobs/advance_notices_digest.t . prove t/db_dependent/Letters/TemplateToolkit.t . prove t/db_dependent/Koha/CurbsidePickups.t . prove t/db_dependent/Koha/Patrons.t . prove t/db_dependent/Patron/Messaging.t [1] The updatedatabase command didn't update the existing installation, I had to do a reset_all to get the database to update. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31059] encryption_key config entry not generated when upgrading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Yeah, this is an annoyance. The same problem exists for quite a few different koha-conf.xml options :/. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Lari Taskula changed: What|Removed |Added Attachment #144307|0 |1 is obsolete|| --- Comment #4 from Lari Taskula --- Created attachment 144309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144309&action=edit Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL To test: 1. prove t/db_dependent/cronjobs/advance_notices_digest.t 2. prove t/db_dependent/Letters/TemplateToolkit.t 3. prove t/db_dependent/Koha/CurbsidePickups.t 4. prove t/db_dependent/Koha/Patrons.t 5. prove t/db_dependent/Patron/Messaging.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 --- Comment #3 from Lari Taskula --- Not sure how to test it thoroughly, but any case using SetMessagingPreference() should not be affected as mentioned in comment #1 - as far as I understand only direct SQL INSERT to borrower_message_preferences and inserts with DBIx object (or TestBuilder) may cause regression. I found five tests making such insertions using $ grep -rn 'BorrowerMessagePreference' and $ grep -rn 'borrower_message_preferences' t/db_dependent/cronjobs/advance_notices_digest.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Koha/CurbsidePickups.t t/db_dependent/Koha/Patrons.t t/db_dependent/Patron/Messaging.t I'll add these to the patch description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31160] Required fields in the Patrons API are a bit random
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
--- Comment #5 from David Nind ---
Hi Matt.
I'll let you fix up the title for the patch - it should be in sentence case.
David
Testing notes using KTD (koha-testing-docker):
1. I used Postman to make the request.
2. I had to put empty curly brackets in the body ({}) and select JSON as the
format to get the error message asking for the empty fields.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31160] Required fields in the Patrons API are a bit random
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160 David Nind changed: What|Removed |Added Attachment #144218|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 144308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144308&action=edit Bug 31160: Required Fields in Patron API The Patron API PUT request required the fields "surname","address","city","library_id","category_id". Meanwhile the CSV import page for patrons only requires "surname","library_id","category_id". The fields for "address" and "city" have been removed from the "required" section of the api>v1>swagger>definitions>patron.yaml file to match the CSV import page. Test Plan: 1) Send a PUT request to http://localhost:8081/api/v1/patrons/19 with an empty body 2) Error message should ask for 5 missing fields as listed above 3) Apply patch 4) Restart Apache server using "restart_all" in your ktd shell 5) Resubmit your request 6) Error message should now only request "surname","library_id","category_id" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31160] Required fields in the Patrons API are a bit random
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 --- Comment #2 from Lari Taskula --- Created attachment 144307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144307&action=edit Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Lari Taskula changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Depends on||32357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Lari Taskula changed: What|Removed |Added Blocks||18595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 [Bug 18595] Move C4::Members::Messaging to Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31059] encryption_key config entry not generated when upgrading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org --- Comment #1 from Chris Slone --- Confirming that this does not get added to the koha-conf.xml. For anyone looking for what to add it would be: __ENCRYPTION_KEY__ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 --- Comment #1 from Lari Taskula --- (In reply to Lari Taskula from comment #0) > because all but one entry in message_attribute has takes_days=1 making it > the exception and not the default. I of course meant to say that only one entry in message_attribute has takes_days=1 making it the exception and not the default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] New: Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Bug ID: 32357 Summary: Set borrower_message_preferences.days_in_advance default to NULL Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: lari.task...@hypernova.fi QA Contact: testo...@bugs.koha-community.org days_in_advance currently defaults to 0, but it should default to NULL because all but one entry in message_attribute has takes_days=1 making it the exception and not the default. Current column default 0 is already ignored by C4::Members::Messaging::SetMessagingPreference, see https://github.com/Koha-Community/Koha/blob/8c367775470fcecdda54e28270b05d92834cd33f/C4/Members/Messaging.pm#L134 , so we should also make NULL default at database level instead. Blocking Bug 18595 (because without this change some tests there will fail unless we replicate the misuse of default values) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32356] New: fr-FR installer dir /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356 Bug ID: 32356 Summary: fr-FR installer dir /kohadevbox/koha/installer/data/mysql/fr-FR already exists. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: alei...@catalyst.net.nz, frede...@tamil.fr When installing a language that has already been installed before you'll end up with this error: fr-FR installer dir /kohadevbox/koha/installer/data/mysql/fr-FR already exists. This is a problem, as the files in the directory won't be replaced with their updated versions or files will be missing: Hadn't been installed before: kohadev-koha@kohadevbox:/kohadevbox/koha/misc/translator$ ls -l ../../installer/data/mysql/es-ES total 12 drwxr-xr-x 2 kohadev-koha kohadev-koha 4096 Nov 28 20:25 mandatory drwxr-xr-x 4 kohadev-koha kohadev-koha 4096 Nov 28 20:25 marcflavour drwxr-xr-x 2 kohadev-koha kohadev-koha 4096 Nov 28 20:25 optional Had been installed before: kohadev-koha@kohadevbox:/kohadevbox/koha/misc/translator$ ls -l ../../installer/data/mysql/fr-FR/ total 0 There have been reports on problems with installing/updating languages on the mailing list and IRC: https://lists.katipo.co.nz/pipermail/koha/2022-November/058691.html https://lists.koha-community.org/pipermail/koha-devel/2022-November/047398.html http://irc.koha-community.org/koha/2022-11-28#i_2464321 Something is not going well here. Another thing: The start page looks ok for es-ES but appears broken for de-DE in my test. Still investigating, but also wondering if it's another file related issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 --- Comment #7 from Katrin Fischer --- Just to explain why this is not as easy of a fix as it might sound: The information if an item is on hold or in transfer is only found in the reserves table right now. it's not part of the item records. In order to be able to exclude these from the availability search, the information needs to be made available to the search engines. This means: The information needs to be added to the records, for example into otherwise unused MARC fields at the time of indexing. And every time a hold changed status, we'd need to automatically trigger reindexing of the record. At the moment the filter only looks at information in the item record already. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32221] Password entry should be removed from placeholder list in notices editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221 Katrin Fischer changed: What|Removed |Added Summary|password entry should be|Password entry should be |removed from placeholder|removed from placeholder |list in notices editor |list in notices editor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32221] password entry should be removed from placeholder list in notices editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com CC||da...@davidnind.com --- Comment #7 from David Nind --- Matt, I have added you as the assignee for the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #31 from Nick Clemens --- (In reply to Arthur Suzuki from comment #29) > thx pushed to 21.11.x for 21.11.12 This is causing a regression in 21.11.x - missing dependency bug 30409 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Keywords||rel_21_11_candidate --- Comment #27 from Nick Clemens --- This is missing from 21.11.x - its dependent bug was pushed, however, which is causing failures in libraries adding items to lists - please backport ASAP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32221] password entry should be removed from placeholder list in notices editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221 David Nind changed: What|Removed |Added Attachment #144284|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 144306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144306&action=edit Bug 32221: Borrowers.password should no longer be an option When creating a notice template the user has the option to add the borrower's password to the template. This should be removed as the password should not be an option to be added to a notice. Test plan: 1) Navigate to Tools > Notices and slips 2) Either create a new notice or edit an existing notice 3) Observe that in the list of fields available to insert into the message body, there is the option for "borrowers.password" 4) Apply patch 5) Navigate to the same menu 6) Observe that the "borrowers.password" option is now no longer visible Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32221] password entry should be removed from placeholder list in notices editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32257] Label for patron attributes misaligned on patron batch mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #3 from David Nind --- Hi Matt. I probably should have marked as Failed QA, but have amended your patch as this is an easy change: 1. We normally use sentence case for field labels: I changed "Patron Attribute" to "Patron attribute". 2. Commit message title: I changed the bug title in the patch, see the development guidelines https://wiki.koha-community.org/wiki/Commit_messages#Subject_line David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32257] Label for patron attributes misaligned on patron batch mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 David Nind changed: What|Removed |Added CC||da...@davidnind.com Attachment #144210|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32257] Label for patron attributes misaligned on patron batch mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #2 from David Nind --- Created attachment 144305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144305&action=edit Bug 32257: Label for patron attributes misaligned Label has now been realigned to match the format of the fields above. Test plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32257] Label for patron attributes misaligned on patron batch mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32257] Label for patron attributes misaligned on patron batch mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32348] Library public is missing from columns settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348 Lucas Gass changed: What|Removed |Added Attachment #144225|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 144304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144304&action=edit Bug 32348: Add library public in columns settings Bug 27360 added public info on libraries table. This should be added to columns settings. Currently the column "STMP server" can not be managed in settings. Test plan : Play with columns settings of table Administration > Libraries Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32348] Library public is missing from columns settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31984] TaxRate system preference - add note about updating vendor tax rates where required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 Lucas Gass changed: What|Removed |Added Attachment #144282|0 |1 is obsolete|| --- Comment #12 from Lucas Gass --- Created attachment 144303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144303&action=edit Bug 31984: TaxRate preference - add note about vendor updates If a value for the TaxRates system preference is changed or removed, vendors retain the original value recorded in their tax rate field. The vendor tax rate is used to calculate prices for orders added to a basket. Where the tax rate doesn't match with the system preference, a warning message is displayed on the order form "Tax rate not defined in system preference TaxRates!". This patch adds a note to the system preference description about updating vendor tax rate information where required. Test plan: 1. Check the values recorded for the TaxRates system preference. 2. For a vendor (Acquisitions > search for a vendor > Edit vendor), check the value recorded in the tax rate field. 3. Note that the tax rate field is populated from a dropdown list using values from the TaxRates system preference. 4. Change the TaxRates system preferemce to remove a tax rate. For example, change 0|0.12|0.1965 to 0|0.12. 5. Refresh the vendor page. 6. Note that the vendor tax rate remains as the original value until you edit the vendor. 7. Apply the patch. 8. Review the description for the TaxRates system preference and make sure the new note about updating vendor tax rates where required makes sense. 9. Sign off! Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31984] TaxRate system preference - add note about updating vendor tax rates where required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144297|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5463] limit to available shows on hold items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463 Katharine Dixon changed: What|Removed |Added CC||katha...@ci.salinas.ca.us --- Comment #8 from Katharine Dixon --- Comment on attachment 2796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2796 on hold when limited to available This issue is very troublesome for our Patron's requesting holds on Hot spots, I hope that it can be resolved soon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144295|0 |1 is obsolete|| --- Comment #21 from Pedro Amorim --- Created attachment 144302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144302&action=edit Bug 30719: Batch requests minor misc improvements - Fix wrong link in message in case there are no requests batch - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144294|0 |1 is obsolete|| --- Comment #20 from Pedro Amorim --- Created attachment 144301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144301&action=edit Bug 30719: Batch statuses This commits adds the following provision for batch statuses: - Database updates - Object definitions - CRUD REST API - Unit tests - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144293|0 |1 is obsolete|| --- Comment #19 from Pedro Amorim --- Created attachment 144300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144300&action=edit Bug 30719: Logging of batch operations This commit adds logging of the following batch operations: - Batch creation - Batch update (Updating of the batch itself, not its contents) - Batch delete Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144292|0 |1 is obsolete|| --- Comment #18 from Pedro Amorim --- Created attachment 144299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144299&action=edit Bug 30719: Batch ILL requests - Add API endpoint for ILL request creation - UI for creation of ILL batches, including: - Ability to paste in list of identifier - Auto metadata enrichment for each identifier, using installed third party service API plugins - Auto retrieval of identifier availability, using installed third party service API plugins - Auto creation of local requests within batch - UI for management of existing ILL batches, including adding requests to, and removing requests from, batches - Additional UI to allow users to navigate from requests to their enclosing batches and vice-versa Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144291|0 |1 is obsolete|| --- Comment #17 from Pedro Amorim --- Created attachment 144298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144298&action=edit Bug 30719: DB, API & tests This commit adds the following: - A database update that adds an "illbatches" table, a "illrequest.batch_id" foreign key and an "illbatches.borrowernumber" foreign key - Illbatch and Illbatches Koha objects - Adds 'batch' accessor to Illrequest object - CRUD API endpoints for working with ILL batches - Unit tests of the Koha objects and API endpoints - Adds 'batch_id' filter to /illrequests endpoint Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 Carolyn Hughesman changed: What|Removed |Added CC||chughes...@cclsny.org --- Comment #6 from Carolyn Hughesman --- Hoping to revive this bug. On the search results page in the staff interface, items are still counted as available both when they are in transit and sitting on the holds shelf. This is confusing to our staff. Items should only be listed as available if they are physically on the shelf. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31933] Import patrons fails when patron attribute value contains a comma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31933 Jacob O'Mara changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Jacob O'Mara --- After some more extensive searching it appears that the issue lies in how smart quotes are being handled within the spreadsheet editor itself prior to uploading to the koha db as I was getting some weird results once saving the csv in LibreOffice and opening in text editor. The easiest way we discussed to solve this is possibly just to disable smart quotes entirely in the spreadsheet editor and amend the documentation notes to specify the issues between escape quotes and smart quotes. Commas etc then seem to work as expected once disabled and in the format you specified below, bounded within one cell: "COURSE:Government, Economics and Commerce","CSCODE:ABC1234" we could probably do some kind of regex fix for the smart quotes issue as you suggested but Martin believes this is something we should discuss further first. It appears the error handling does in fact catch the mismatch of columns:values and probably won't need any additional tinkering. Let me know what you think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144296|0 |1 is obsolete|| --- Comment #16 from Pedro Amorim --- Created attachment 144297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144297&action=edit Koha 22.11.00 Rosalie is here! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31651] Log message incorrect in Auth_with_shibboleth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Jacob O'Mara changed: What|Removed |Added CC||jacob.om...@ptfs-europe.com Assignee|koha-b...@lists.koha-commun |jacob.om...@ptfs-europe.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #15 from Pedro Amorim --- Created attachment 144296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144296&action=edit Koha 22.11.00 Rosalie is here! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] Release team 23.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 --- Comment #13 from Martin Renvoize --- Hopefully I split the commits up enough that it should be simple enough to backport what's needed and ignore the rest ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #14 from Pedro Amorim --- Apply all current 5 patches, on ktd, preparation: - Run DBIC - Run reset_all - Enable ILLModule sys pref - Default ILLLIBS patron category needs to exist, create that - At least one ILL batch status needs to exist, admin -> ILL batch statuses, create for example name:NEW status:NEW - At least one ILL Backend with "provide_batch_requests" capability needs to exist, create ReprintsDesk backend from https://github.com/PTFS-Europe/koha-ill-reprintsdesk - Install ReprintsDesk backend dependencies: cpan XML::Compile XML::Smart XML::Compile:WSDL11 XML::Compile::SOAP12 - Need to restart plack here - Update backend_directory in koha-conf.xml to /kohadevbox/koha/Koha/Illbackends - Need to restart plack here - Install metadata enrichment plugin pubmedid from https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.0 through "Manage plugins" in admin - Need to restart plack here - Go to ILL Requests admin area, click "New ILL batch request" and select ReprintsDesk - Create new batch (insert name, cardnumber and library) and press "continue" - Add PubMed ID, one per line (example: 23668524\n29710265) and press "Process identifiers" - After processing is complete, click "add items to batch" and then "finish and view batch" Verify that: - The items requested in the batch are now illrequests in Koha, and are part of the batch that was just created - Clicking on "Batch requests" lists all batch requests created - Clicking on a batch name lists only the requests from that batch - If a batch is deleted, whatever requests previously on that batch are not deleted (they have been detached, their batch_id is now NULL) - When editing a request that is part of a batch, it's possible to change which batch the request is part of, or none. Test logs: - Before doing the above, enable illlog sys pref - Do some CRUD actions on batch requests - Check log viewer -> module "Interlibrary loans" - Verify that the actions performed have been logged Run tests: perl t/db_dependent/Illbatches.t perl t/db_dependent/Illbatchstatuses.t #currently failing, will check why soon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31160] Required fields in the Patrons API are a bit random
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144290|0 |1 is obsolete|| --- Comment #13 from Pedro Amorim --- Created attachment 144295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144295&action=edit Bug 30719: Batch requests minor misc improvements - Fix wrong link in message in case there are no requests batch - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144288|0 |1 is obsolete|| --- Comment #12 from Pedro Amorim --- Created attachment 144294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144294&action=edit Bug 30719: Batch statuses This commits adds the following provision for batch statuses: - Database updates - Object definitions - CRUD REST API - Unit tests - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144287|0 |1 is obsolete|| --- Comment #11 from Pedro Amorim --- Created attachment 144293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144293&action=edit Bug 30719: Logging of batch operations This commit adds logging of the following batch operations: - Batch creation - Batch update (Updating of the batch itself, not its contents) - Batch delete -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144286|0 |1 is obsolete|| --- Comment #10 from Pedro Amorim --- Created attachment 144292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144292&action=edit Bug 30719: Batch ILL requests - Add API endpoint for ILL request creation - UI for creation of ILL batches, including: - Ability to paste in list of identifier - Auto metadata enrichment for each identifier, using installed third party service API plugins - Auto retrieval of identifier availability, using installed third party service API plugins - Auto creation of local requests within batch - UI for management of existing ILL batches, including adding requests to, and removing requests from, batches - Additional UI to allow users to navigate from requests to their enclosing batches and vice-versa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144289|0 |1 is obsolete|| --- Comment #9 from Pedro Amorim --- Created attachment 144291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144291&action=edit Bug 30719: DB, API & tests This commit adds the following: - A database update that adds an "illbatches" table, a "illrequest.batch_id" foreign key and an "illbatches.borrowernumber" foreign key - Illbatch and Illbatches Koha objects - Adds 'batch' accessor to Illrequest object - CRUD API endpoints for working with ILL batches - Unit tests of the Koha objects and API endpoints - Adds 'batch_id' filter to /illrequests endpoint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144281|0 |1 is obsolete|| --- Comment #8 from Pedro Amorim --- Created attachment 144290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144290&action=edit Bug 30719: Batch requests minor misc improvements - Fix wrong link in message in case there are no requests batch - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #7 from Pedro Amorim --- Apply all current 5 patches, on ktd, preparation: - Run DBIC - Run reset_all - Enable ILLModule sys pref - Default ILLLIBS patron category needs to exist, create that - At least one ILL batch status needs to exist, admin -> ILL batch statuses, create for example name:NEW status:NEW - At least one ILL Backend with "provide_batch_requests" capability needs to exist, create ReprintsDesk backend from https://github.com/PTFS-Europe/koha-ill-reprintsdesk - Install ReprintsDesk backend dependencies: cpan XML::Compile XML::Smart XML::Compile:WSDL11 XML::Compile::SOAP12 - Need to restart plack here - Update backend_directory in koha-conf.xml to /kohadevbox/koha/Koha/Illbackends - Need to restart plack here - Install metadata enrichment plugin pubmedid from https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.0 through "Manage plugins" in admin - Need to restart plack here - Go to ILL Requests admin area, click "New ILL batch request" and select ReprintsDesk - Create new batch (insert name, cardnumber and library) and press "continue" - Add PubMed ID, one per line (example: 23668524\n29710265) and press "Process identifiers" - After processing is complete, click "add items to batch" and then "finish and view batch" Verify that: - The items requested in the batch are now illrequests in Koha, and are part of the batch that was just created - Clicking on "Batch requests" lists all batch requests created - Clicking on a batch name lists only the requests from that batch - If a batch is deleted, whatever requests previously on that batch are not deleted (they have been detached, their batch_id is now NULL) - When editing a request that is part of a batch, it's possible to change which batch the request is part of, or none. Test logs: - Before doing the above, enable illlog sys pref - Do some CRUD actions on batch requests - Check log viewer -> module "Interlibrary loans" - Verify that the actions performed have been logged Run tests: perl t/db_dependent/Illbatches.t perl t/db_dependent/Illbatchstatuses.t #currently failing, will check why soon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #144285|0 |1 is obsolete|| --- Comment #6 from Pedro Amorim --- Created attachment 144289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144289&action=edit Bug 30719: DB, API & tests This commit adds the following: - A database update that adds an "illbatches" table, a "illrequest.batch_id" foreign key and an "illbatches.borrowernumber" foreign key - Illbatch and Illbatches Koha objects - Adds 'batch' accessor to Illrequest object - CRUD API endpoints for working with ILL batches - Unit tests of the Koha objects and API endpoints - Adds 'batch_id' filter to /illrequests endpoint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #5 from Pedro Amorim --- Created attachment 144288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144288&action=edit Bug 30719: Batch statuses This commits adds the following provision for batch statuses: - Database updates - Object definitions - CRUD REST API - Unit tests - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #4 from Pedro Amorim --- Created attachment 144287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144287&action=edit Bug 30719: Logging of batch operations This commit adds logging of the following batch operations: - Batch creation - Batch update (Updating of the batch itself, not its contents) - Batch delete -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #3 from Pedro Amorim --- Created attachment 144286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144286&action=edit Bug 30719: Batch ILL requests - Add API endpoint for ILL request creation - UI for creation of ILL batches, including: - Ability to paste in list of identifier - Auto metadata enrichment for each identifier, using installed third party service API plugins - Auto retrieval of identifier availability, using installed third party service API plugins - Auto creation of local requests within batch - UI for management of existing ILL batches, including adding requests to, and removing requests from, batches - Additional UI to allow users to navigate from requests to their enclosing batches and vice-versa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #2 from Pedro Amorim --- Created attachment 144285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144285&action=edit Bug 30719: DB, API & tests This commit adds the following: - A database update that adds an "illbatches" table, a "illrequest.batch_id" foreign key and an "illbatches.borrowernumber" foreign key - Illbatch and Illbatches Koha objects - Adds 'batch' accessor to Illrequest object - CRUD API endpoints for working with ILL batches - Unit tests of the Koha objects and API endpoints - Adds 'batch_id' filter to /illrequests endpoint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Andrew Fuerste-Henry changed: What|Removed |Added Summary|Add preferred pronoun field |Add pronoun field to patron |to patron record|record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32221] password entry should be removed from placeholder list in notices editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221 Matt Blenkinsop changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europe ||.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32221] password entry should be removed from placeholder list in notices editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221 --- Comment #5 from Matt Blenkinsop --- Created attachment 144284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144284&action=edit Bug 32221: Borrowers.password should no longer be an option When creating a notice template the user has the option to add the borrower's password to the template. This should be removed as the password should not be an option to be added to a notice. Test plan: 1) Navigate to Tools > Notices and slips 2) Either create a new notice or edit an existing notice 3) Observe that in the list of fields available to insert into the message body, there is the option for "borrowers.password" 4) Apply patch 5) Navigate to the same menu 6) Observe that the "borrowers.password" option is now no longer visible -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Tomás Cohen Arazi changed: What|Removed |Added Attachment #144242|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 144283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144283&action=edit Bug 32352: Make xt/check_makefile.t check directories in git index It's failing if 'node_modules' exists. We could simply skip it, but it seems that it would be better to actually list directories that are part of the git index only. The question is: do we actually support test execution outside of a git directory? Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31984] TaxRate system preference - add note about updating vendor tax rates where required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 --- Comment #11 from David Nind --- Created attachment 144282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144282&action=edit Bug 31984: TaxRate preference - add note about vendor updates If a value for the TaxRates system preference is changed or removed, vendors retain the original value recorded in their tax rate field. The vendor tax rate is used to calculate prices for orders added to a basket. Where the tax rate doesn't match with the system preference, a warning message is displayed on the order form "Tax rate not defined in system preference TaxRates!". This patch adds a note to the system preference description about updating vendor tax rate information where required. Test plan: 1. Check the values recorded for the TaxRates system preference. 2. For a vendor (Acquisitions > search for a vendor > Edit vendor), check the value recorded in the tax rate field. 3. Note that the tax rate field is populated from a dropdown list using values from the TaxRates system preference. 4. Change the TaxRates system preferemce to remove a tax rate. For example, change 0|0.12|0.1965 to 0|0.12. 5. Refresh the vendor page. 6. Note that the vendor tax rate remains as the original value until you edit the vendor. 7. Apply the patch. 8. Review the description for the TaxRates system preference and make sure the new note about updating vendor tax rates where required makes sense. 9. Sign off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31984] TaxRate system preference - add note about updating vendor tax rates where required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 David Nind changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31984] TaxRate system preference - add note about updating vendor tax rates where required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||note to the TaxRates system ||preference about updating ||vendors tax rates when the ||TaxRates system preference ||values are changed or ||removed. (Vendors retain ||the original value entered, ||and this is used to ||calculate the tax rate for ||orders.) Summary|TaxRate system preference - |TaxRate system preference - |incorrect default value |add note about updating |used and warning message on |vendor tax rates where |order form |required Severity|normal |trivial Status|NEW |ASSIGNED Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21544] Self Check-in tool does not trigger holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21544 Laura changed: What|Removed |Added Version|18.05 |22.05 CC||Laura.escamilla@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #6 from Tomás Cohen Arazi --- I agree only checking things in the git tree is the right approach. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #1 from Pedro Amorim --- Created attachment 144281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144281&action=edit Bug 30719: Batch requests minor misc improvements - Fix wrong link in message in case there are no requests batch - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32334] Sync comments in database with schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32334] Sync comments in database with schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Marcel de Rooy changed: What|Removed |Added Blocks||30486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486 [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database revisions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database revisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486 Marcel de Rooy changed: What|Removed |Added Depends on||32334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 [Bug 32334] Sync comments in database with schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 --- Comment #36 from Hans Pålsson --- It would be of great value to many Swedish libraries if this could be backported to 22.05.x (if possible also 21.11.x). Thanks everyone for the great work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Hans Pålsson changed: What|Removed |Added CC||hans.pals...@hkr.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32355] Add class url to all URL syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |didier.gautheron@biblibre.c |ity.org |om CC||da...@davidnind.com --- Comment #3 from David Nind --- Changed assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32355] Add class url to all URL syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355 David Nind changed: What|Removed |Added Attachment #144275|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 144280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144280&action=edit Bug 32355: Add css class url to URL syspref Add missing css class to URL syspref. To Test: 1 - open admin/preferences.pl 2 - Search for URL 3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL, PrivacyPolicyURL, LibrisURL input field size are small. 4 - Apply patch 5 - all URL fields have the same bigger size. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32355] Add class url to all URL syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #66 from Marcel de Rooy --- To still catch differences more easily, I will submitting some code on bug 32334 to sync the comments between actual database and schema. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32334] Sync comments in database with schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Summary|Working title |Sync comments in database ||with schema See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26947 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32334 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #5 from Martin Renvoize --- Checking the git tree feels like the right approach. Must admit, I've never tried to run the tests from outside of the kohaclone.. but that's doesn't mean there isn't someone out there doing that. I think I'd suggest going with this patch and documenting that the expectation is that tests are run from inside the project somewhere. I can't see any obvious flaws with this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31933] Import patrons fails when patron attribute value contains a comma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31933 --- Comment #1 from Martin Renvoize --- We investigated this a little further last week.. It's a bit strange to allow more fields in the rows than in the header that describes which rows are available. Jacob is working on refining that to give clear errors when we find such cases in the input data and also add a bit more documentation around full quoting with escaped quotes the attributes field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 --- Comment #14 from Marcel de Rooy --- # Subtest: transferbook tests 1..9 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/Koha/Objects.pm line 96 ok 1 - Koha::Patron->store raises an exception on missing params DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/Koha/Objects.pm line 96 ok 2 - Koha::Patron->store raises an exception on missing params DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/Koha/Objects.pm line 96 ok 3 - Koha::Patron->store raises an exception on missing params DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/Koha/Objects.pm line 96 # Looks like you planned 9 tests but ran 3. not ok 57 - transferbook tests # Failed test 'transferbook tests' # at t/db_dependent/Circulation.t line 5394. Exception 'Koha::Exceptions::MissingParameter' thrown 'The to parameter is mandatory' # Looks like your test exited with 11 just after 57. Might be something else ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 Jonathan Druart changed: What|Removed |Added Attachment #144253|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 144279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144279&action=edit Bug 32353: Don't generate item group for holds in tests See bug 31447, we don't want the tests to deal with potential failures because of some item groups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 --- Comment #12 from Jonathan Druart --- it's reserves.item_group_id, not items.item_group_id. I've noticed my mistake on Friday, and correct the patch but... hadn't attached it here it seems :-/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 Jonathan Druart changed: What|Removed |Added Summary|items.item_group_id should |reserves.item_group_id |be undefined in tests by|should be undefined in |default |tests by default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin Somers --- This looks great -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26860 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26860] Add search limit for records without items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
