[Koha-bugs] [Bug 32305] Background worker doesn't check jobs receive from rabbitmq are in 'new' state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305 --- Comment #9 from Fridolin Somers --- (In reply to Martin Renvoize from comment #8) > Should we force a refetch from the DB just prior to checking this status.. > just in case we have a stale object? Sounds like a good idea to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694
--- Comment #14 from Shi Yao Wang ---
Created attachment 144409
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144409=edit
wrong preset caused by different fr-CA translation
On a side note, there is a small issue in fr-CA preset display. The word
"Remove" is translated into "Retirer" in column "Retiré" ("Removed" in en), but
other instances of "Remove" are translated to "Enlever" so it messes up the
preset display.
The problem is fixed if instead of "Retirer" it's "Enlever".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32397] Language falls back to default if changing the language to german and try to access the tools in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32397 --- Comment #4 from Katrin Fischer --- Well, it IS falling back, because the German file is just not there. :( Sorry for that mess. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32397] Language falls back to default if changing the language to german and try to access the tools in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32397 --- Comment #3 from Katrin Fischer --- It's not falling back I think, but you have run into the translation bug that ws fixed in the most recent packages but not on master yet I believe - it will be fixed in .01. There are 2 fatal errors in the po files currently that prevent all template files form being created. If you fix them locally, remove the language and install the language again, it should be fixed: #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:145 #, c-format msgid "Are you sure you want to delete \"%s\"?" -msgstr "Sind Sie sicher, dass Sie \"%s% löschen möchten?" +msgstr "Sind Sie sicher, dass Sie '%s' löschen möchten?" #. For the first occurrence, #. SCRIPT @@ -66875,7 +66875,7 @@ msgstr "Unbekannter Datensatztyp, kann nicht importiert werden" #: koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc:272 #, c-format msgid "Unknown status \"%s\"" -msgstr "Unbekannter Status \"%s%" +msgstr "Unbekannter Status \"%s\"" Not: REMOVE the language, there also is a bug in update right now we are about to fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #13 from Shi Yao Wang --- Created attachment 144408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144408=edit Bug 31694: (follow-up) Fix preset display issue Preset column should now display the right preset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com |ity.org | --- Comment #12 from Shi Yao Wang --- Sorry. The patch I added is supposed to fix this bug, but I'll try to add on what is already done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang changed: What|Removed |Added Attachment #142579|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang changed: What|Removed |Added Attachment #144407|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang changed: What|Removed |Added Attachment #142598|1 |0 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #11 from Katrin Fischer --- Hm, a little sad to see my patch just thrown out without comment. I think we still need a lot of fixes there for translatability. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com Attachment #142598|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang changed: What|Removed |Added Attachment #142579|0 |1 is obsolete|| --- Comment #10 from Shi Yao Wang --- Created attachment 144407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144407=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch uses the text of option (which is translated) instead of the value (which is not translated) for the process. Test plan: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32398] Patron import may partially delete restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32398 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31095 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32398 CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32398] New: Patron import may partially delete restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32398 Bug ID: 32398 Summary: Patron import may partially delete restrictions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: andre...@dubcolib.org QA Contact: testo...@bugs.koha-community.org To recreate: 1 - have a patron, put a manual restriction on their account 2 - create a CSV for patron import that matches your patron 3 - add the debarred and debarredcomment columns to your CSV, but don't put any values into them for your test patron 4 - import your file, matching your patron, and overwriting the existing patron with the new data 5 - reload your patron's record 6 - confirm your patron is allowed to check out but that the Restrictions tab still lists the restriction created in step 1 The patron import nulls out borrowers.debarred and borrowers.debarredcomment but does not update the borrower_debarments table. This leaves the patron with a zombie debarment that doesn't get enforced. I'm not entirely sure what the right answer here is. Either we should not allow patron imports to delete debarments at all or we should make sure it does the deletion properly and completely. For comparison, if one uses batch patron modification to clear the debarred and debarredcomment fields, Koha deletes ALL debarments on that account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 --- Comment #12 from Nick Clemens --- (In reply to Anke Bruns from comment #11) > Note for testers: The aim of the batch modification is to populate the > number of totalissues in the biblioitems tab to have some entries there > without having to perform manual checkouts; the biblionumber is used to > populate this field. > > This means also that checking if the sorting was correct can be done by just > looking at the results' URLs where the biblionumber also appears. > > Thanks to Victor and his patch testing session! Thanks Anke, and Victor, for explaining the bit I forgot to explain :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32397] Language falls back to default if changing the language to german and try to access the tools in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32397 --- Comment #2 from Victor Grousset/tuxayo --- Nothing wrong in any log (/var/log/koha/kohadev/*) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32397] Language falls back to default if changing the language to german and try to access the tools in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32397 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #1 from Victor Grousset/tuxayo --- I have almost the same thing on my local Koha (using koha-testing-docker), when trying to switch the UI to German, it fails an goes back to English. It's certainly related to the error I got when deploying the translation: root@kohadevbox:koha(testing-SO-QA)$ cd misc/translator ; ./translate update de-DE ; cd - /kohadevbox/koha root@kohadevbox:koha(testing-SO-QA)$ cd misc/translator ; ./translate install de-DE ; cd - %s: Completely confused parametrizing -- msgid: Unbekannter Status "%s% Koha directories hierarchy for de-DE must be created first /kohadevbox/koha It interferes with testing patches related to translation and if not fixed will likely to be a problem for 23.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Anke Bruns changed: What|Removed |Added CC||anke.br...@gwdg.de Status|Needs Signoff |Signed Off --- Comment #11 from Anke Bruns --- Note for testers: The aim of the batch modification is to populate the number of totalissues in the biblioitems tab to have some entries there without having to perform manual checkouts; the biblionumber is used to populate this field. This means also that checking if the sorting was correct can be done by just looking at the results' URLs where the biblionumber also appears. Thanks to Victor and his patch testing session! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #144115|0 |1 is obsolete|| --- Comment #10 from PTFS Europe Sandboxes --- Created attachment 144406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144406=edit Bug 13976: Sort popularity numerically in Zebra To test: 1 - Create a new template at Tools->Marc modification template 2 - Add action: Copy 999$c to 942$0 3 - Create a report: SELECT biblionuber FROM biblios 4 - Run report, show all, do a batch modification to all records using template above 5 - Search for 'a' (make sure you are using Zebra) 6 - Sort by popularity 7 - Note records are sorted wrong 8 - Apply patch 9 - Restart all 10 - Reload search results 11 - Success! Sorted correctly Signed-off-by: Anke -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32396] Pages/Additional contents/CMS page default language link should still allow to the change language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32396 --- Comment #2 from Victor Grousset/tuxayo --- Actually the link doesn't reset the UI language, we got confused. It just the additional contents part of the page. Which made us think that the additional contents translation logic didn't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 --- Comment #7 from Lucas Gass --- (In reply to Owen Leonard from comment #6) > I think biblio-title.inc should be used here instead That is a reasonable request. However, when I attempt to add that include into the JSON include ( itemsearch_item.json.inc ) it crashes! I'm not seeing why or getting an useful errors to help. It is finding the include but the itemseach page won't properly load. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31212] Datelastseen should be a datetime
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32251] opac-page.pl: Add a fallback for when language cookie was removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32251 Pascal Uphaus changed: What|Removed |Added CC||pascal.uph...@gwdg.de Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32251] opac-page.pl: Add a fallback for when language cookie was removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32251 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #144045|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 144405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144405=edit Bug 32251: Add a fallback for when language cookie was removed Since we remove cookies after logout now, the language cookie might not be there yet. It is friendlier to add the template language fallback here now too before switching to 'default' in the Additional contents (AC)-context. Note: The cookie will not be removed when you added it to the list in koha-conf.xml. Note2: This only pertains to the use of opac-page with code param. Test plan: [1] Create a CMS page with AC. Add two languages (say en, nl-NL). Add different text to default and both languages. [2] Remove the KohaOPACLanguage cookie from your browser (via dev console). [3] Without this patch, copy the Current language URL from the AC overview page. (Note that the Default URL always refers you to 'default'.) [4] Go to that page with the selected (Current..) URL. Observe that you still see the 'default' text. [5] Remove the cookie again if it might be there already. [6] With this patch, observe that you get the language of the interface now on the CMS page using the same URL. Signed-off-by: Marcel de Rooy Signed-off-by: Pascal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32397] New: Language falls back to default if changing the language to german and try to access the tools in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32397 Bug ID: 32397 Summary: Language falls back to default if changing the language to german and try to access the tools in the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pascal.uph...@gwdg.de QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Test plan: 1. Install the german language to the koha instance running the main/master version 2. Enable the language via the systempreferences (language, OPAClanguages and opaclanguagesdisplay) 3. Changing the language to german 4. Access the tools in the staff interface 5. Result: the complete language of the staff interface is english I tested it with the french language and it works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32396] Pages/Additional contents/CMS page default language link should still allow to the change language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32396 Victor Grousset/tuxayo changed: What|Removed |Added Summary|CMS page default language |Pages/Additional |link should still allow to |contents/CMS page default |the change language |language link should still ||allow to the change ||language -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32396] CMS page default language link should still allow to the change language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32396 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #1 from Victor Grousset/tuxayo --- Got confused as well. On the rest of the Koha, when changing the language, one is redirected to the homepage. Then it's usual use the back button of the browser, and with additional content(CMS pages) it's necessary for the OPAC to have the direct URL otherwise it's not possible to find back the page. But then one triggers the language reset. I think the confusion is that the default language URL is meant to reset the language. But then if one wants to check the translation of the additional content, it's expected to use the language switches instead of the link in the additional content interface. And then when using the language switch it's expected to back to the page to check if the right language is shown and oops it's reset and the language. I don't know how the UX should be avoid this but this is at least to document the confusion that can arise, we though the translation mechanism of additional content was broken and didn't notice the two URL in the additional content interface are different. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32391] Reorganise the manual contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391 David Nind changed: What|Removed |Added URL||https://docs.google.com/doc ||ument/d/1KyrsMVWG_kcVvbFsUk ||ysRC9oovIbFCNTNgCwSyM4SL0/e ||dit?usp=sharing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32391] Reorganise the manual contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391 --- Comment #2 from David Nind --- I've created a document that anyone should be able to comment on (no login required): https://docs.google.com/document/d/1KyrsMVWG_kcVvbFsUkysRC9oovIbFCNTNgCwSyM4SL0/edit?usp=sharing If you prefer not to use a Google document, you can use https://annuel.framapad.org/p/koha-manual-contents-reorganisation Quite a few changes from comment #1 - more a narrowing down of the top-level items: Introduction Koha overview What's new in Koha Getting started Using Koha [where most of the content is]: - Core modules: Circulation, patrons, etc - Other modules, tools and features - Enhanced content - Customising the OPAC and staff interface - System configuration - System administration Implementing Koha Installing Koha System preference [reference] Glossary Index -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32396] New: CMS page default language link should still allow to the change language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32396 Bug ID: 32396 Summary: CMS page default language link should still allow to the change language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pascal.uph...@gwdg.de QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Test plan: 1. Install a second language to the koha instance 2. Enable the language via the systempreferences (language, OPAClanguages and opaclanguagesdisplay) 3. Adding a page via koha-domain/cgi-bin/koha/tools/additional-contents.pl?category=pages 4. added the translations default, english and the second language 5. Opening the default link for OPAC or for the Staff Interface 6. Change the Language and go back to the same url and reload the page. 7. Result: the language of the opac is still the default one Is this intended that the Link always resets the language to the default language, when accessing the page via link or go back and reload the page? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32134] Show the bundle size when checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134
Kyle M Hall changed:
What|Removed |Added
Attachment #143625|0 |1
is obsolete||
--- Comment #3 from Kyle M Hall ---
Created attachment 144404
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144404=edit
Bug 32134: Show the bundle size when checked out
When checking out a bundle, it can be useful to know the number of items
in this bundle, so that librarians can quickly check if items are
missing.
Test plan:
1. Create a bundle (see bug 28854 comment 458)
2. Check out the bundle.
3. Verify that you have the bundle size in the message below the barcode
input ("Checked out: [...]. Bundle of X items. Due on [...]")
4. Checkout an item that is not a bundle.
5. Verify that the bundle message does not appear
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32134] Show the bundle size when checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #19) > (In reply to Jonathan Druart from comment #12) > > (In reply to Jonathan Druart from comment #11) > > > malformed JSON string, neither tag, array, object, number, string or atom, > > > at character offset 0 (before "HASH(0x55ae880d9628)") at > > > /kohadevbox/koha/misc/background_jobs_worker.pl line 93. > > > > Hum, forget that, I guess I need to copy the new version of the misc script. > > I have faced some very weird behaviours testing this (and linked bugs). > > At some point I got background_jobs.pl processes that were not attached to > the koha-worker daemon, and were using an old version of the code (like this > message that was because of this bug, but was also in the log after a > checkout master && restart_all). Just noting, but good to keep in mind. Not having the job_id might be a good source for weirdness :-D well spotted, Jonathan. I should've put the background jobs related change on a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #61 from Jonathan Druart --- (In reply to Jonathan Druart from comment #60) > Why do we need the DB column background_jobs.queue exactly? ... In case we are defaulting to the DB (no broker). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #60 from Jonathan Druart --- Why do we need the DB column background_jobs.queue exactly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31994] Clicking the next button of a DataTable loading its data from the HTML does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31994 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version|master |21.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370 --- Comment #19 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > (In reply to Jonathan Druart from comment #11) > > malformed JSON string, neither tag, array, object, number, string or atom, > > at character offset 0 (before "HASH(0x55ae880d9628)") at > > /kohadevbox/koha/misc/background_jobs_worker.pl line 93. > > Hum, forget that, I guess I need to copy the new version of the misc script. I have faced some very weird behaviours testing this (and linked bugs). At some point I got background_jobs.pl processes that were not attached to the koha-worker daemon, and were using an old version of the code (like this message that was because of this bug, but was also in the log after a checkout master && restart_all). Just noting, but good to keep in mind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370 --- Comment #18 from Jonathan Druart --- I think attention must be on bug 32393, bug 32394 and bug 32395 first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar, but still an additional save button at the bottom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |matt.blenkinsop@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
--- Comment #17 from Jonathan Druart ---
108 $self->set_encoded_json_field( { data => $job_args,field => 'data'
} );
120 $job_args->{job_id} = $self->id;
130 my $json_args = $self->data; # we pass the JSON string
137 my $encoded_args = Encode::encode_utf8( $json_args ); # FIXME We
should better leave this to Net::Stomp?
This is terribly wrong, we are loosing job_id...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32134] Show the bundle size when checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 --- Comment #10 from Kyle M Hall --- Created attachment 144403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144403=edit Bug 28975: (QA follow-up) Fix indentation, simplify if statement Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 Kyle M Hall changed: What|Removed |Added Attachment #137170|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 144402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144402=edit Bug 28975: Holds queue lists can show holds from all libraries even with IndependentBranches When using IndependentBranches, usually all branches are removed from the drop-down menus. But in the Holds Queue page, there is the possibility to choose "All branches". From there, you can see holds from all libraries. To recreate : 1) Activate IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers 2) Create a staff user with limited permissions (NOT a superlibrarian), including holds permissions. Here are mine as an example - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 3) Create (or make sure you already have) a patron in another branch (we'll call them patron X) 4) Place a hold for patron X on an available item from their own library 5) Run misc/cronjobs/holds/build_holds_queue.pl 6) Go to Circulation > Holds queue and make sure you can see the hold 7) Log in as your limited staff patron 8) Go to Circulation > Holds queue 9) In the drop-down menu, choose "All" and click Submit -- Notice you see the hold of the patron from another branch under Patron column: "A patron from library " 11) Apply the patch. 12) Notice that the "All" option is no longer available for the limited patron. Limited patrons can't see holds from other libraries anymore. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32395 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32395] Why do we send job's params to the broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32393 --- Comment #1 from Jonathan Druart --- We would have avoided all the JSON encoding/decoding stuffs we had recently, and bug 32393. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32381] Koha should be able to receive and record reasons for failed SMS notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381 --- Comment #3 from Andrew Fuerste-Henry --- (In reply to Emmi Takkinen from comment #2) > Could this be a duplicate of bug 31481? I don't *think* so, but I'm really not certain. I've got only the vaguest explanation of why Twilio's unsubscribed user response can't make its way into Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32395] Why do we send job's params to the broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31090 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31090] Background jobs needs highlights and searchability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31090 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30982 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Jonathan Druart changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #22 from Jonathan Druart --- *** Bug 31561 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31561] Background jobs stuck at "New"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE CC||jonathan.druart+koha@gmail. ||com Status|NEW |RESOLVED --- Comment #10 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 31245 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What|Removed |Added Blocks||32395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395 [Bug 32395] Why do we send job's params to the broker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32395] Why do we send job's params to the broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395 Jonathan Druart changed: What|Removed |Added Depends on||22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32381] Koha should be able to receive and record reasons for failed SMS notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31481 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31481] Pass message_id to SMS drivers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31481 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32381 CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32395] New: Why do we send job's params to the broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395 Bug ID: 32395 Summary: Why do we send job's params to the broker Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dc...@prosentient.com.au, m.de.r...@rijksmuseum.nl, martin.renvo...@ptfs-europe.com, tomasco...@gmail.com We are: - Building the parameters - Insert a job and its parameters in DB - Send a message to the broken with the parameters - Retrieve the message from the worker - Process the job using the parameter from the broker Why don't we simply pass the job_id to the broker, then retrieve the parameters from the DB in the worker? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from Kyle M Hall --- Unit tests are failing randomly: root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 526. Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 526. # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1243. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1247. # got: '169.44' # expected: '157.6' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1270. # got: '157.6' # expected: '147.36' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1272. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1276. # got: '169.44' # expected: '157.6' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1278. # got: '169.44' # expected: '157.6' # Looks like you failed 6 tests of 34. t/db_dependent/Budgets.t .. 154/154 # Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell FieldsForCalculatingFundValues tests' # at t/db_dependent/Budgets.t line 1290. # Looks like you failed 1 test of 154. t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/154 subtests Test Summary Report --- t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1) Failed test: 154 Non-zero exit status: 1 Files=1, Tests=154, 4 wallclock secs ( 0.02 usr 0.00 sys + 3.43 cusr 0.65 csys = 4.10 CPU) Result: FAIL root@kohadevbox:koha(bug31631-qa)$ git log commit 2a3c15c91467b01802c31a65f3436c9175ef1103 (HEAD -> bug31631-qa) Author: Aleisha Amohia Date: Tue Oct 25 03:08:03 2022 + Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind commit cc6bcfe54ea55691bd4ed749b58fac2f9331f8fd Author: Alex Buckley Date: Tue Sep 27 17:01:51 2022 +1300 Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind commit a50a301eacde061376c6a3c0cafc03b56e8d1604 Author: Alex Buckley Date: Tue Sep 27 16:59:00 2022 +1300 Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. t/db_dependent/Budgets.t .. ok All tests successful. Files=1, Tests=154, 4 wallclock secs ( 0.02 usr 0.01 sys + 2.99 cusr 0.54 csys = 3.56 CPU) Result: PASS root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515.
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What|Removed |Added CC||dc...@prosentient.com.au, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart changed: What|Removed |Added CC||dc...@prosentient.com.au, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #1 from Jonathan Druart ---
Created attachment 144401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144401=edit
Bug 32393: Prevent invalid job to block the job queue
I have faced a problem when testing an incorrect version of bug 32370.
The frame sent to the message broker was not a correct JSON encoded
string, and its decoding was obviously failing, exploding the worker
script.
Additionally, as we don't send a ack for this frame, the next pull will
result in processing the same message, and so in the same explosion.
No more messages can be processed!
This patch is logging the error and ack the message to the broker, in
order to not get stuck.
Test plan:
0. Dont' apply this patch
1. Enqueue a bad message
a. Apply 32370
b. Comment the following line in Koha::BackgroundJob::enqueue
$self->set_encoded_json_field( { data => $job_args,field => 'data' } );
c. restart_all
d. Use the batch item modification tool to enqueue a new job
=> Notice the error in the log
=> Note that the status of the job is "new"
=> Inspect rabbitmq queue:
% rabbitmq-plugins enable rabbitmq_management
% rabbitmqadmin get queue=koha_kohadev-long_tasks
You will notice there is a message in the "long_tasks" queue
2. Enqueue a good message
a. Remove the change from 1.b
b. restart_all
c. Enqueue another job
=> Same error in the log
=> Both jobs are new
=> Inspect rabbitmq, there are 2 messages
3. Apply this patch
4. restart_all
=> Second (good) job is finished
=> rabbitmq long_tasks queue is empty
We cannot mark the first job as done, we have no idea which job it was!
QA: Note that this patch is dealing with another problem, not tested in
this test plan. If an exception is not correctly caught by the ->process
method of the job, we won't crash the worker. The job will be marked as
failed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What|Removed |Added Depends on||32394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 [Bug 32394] Long tasks queue is never used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart changed: What|Removed |Added Blocks||32393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 [Bug 32393] background job worker explodes if JSON is incorrect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #4 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #1) > Aren't the parameter confusing but the outcome correct? All jobs are using the default queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #3 from Jonathan Druart --- Created attachment 144400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144400=edit Bug 32394: Restore long tasks queue We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Test plan: Read code and confirm the above. More fun for test plan will be found on bug 32393 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #2 from Jonathan Druart --- This one could be considered critical actually. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #1 from Tomás Cohen Arazi --- Aren't the parameter confusing but the outcome correct? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Jonathan Druart changed: What|Removed |Added Blocks||32394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 [Bug 32394] Long tasks queue is never used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] New: Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Bug ID: 32394 Summary: Long tasks queue is never used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 27783 We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 [Bug 27783] Introduce background job queues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25314] Make OPAC facets collapse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #18 from Owen Leonard --- I notice the Bootstrap Collapse component uses pseudo elements but adds the "aria-expanded" attribute: https://getbootstrap.com/docs/3.4/javascript/#collapse Would that solve the issue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] New: background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Bug ID: 32393 Summary: background job worker explodes if JSON is incorrect Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org If a message that is not (or incorrect) JSON is received by the worker, the script will explode. Additionally, it will restart and get the same frame, over and over again, which means no other job will be processed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32291] "library category" messages should be removed (not used)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291 Owen Leonard changed: What|Removed |Added Attachment #144191|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 144399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144399=edit Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt On bug 16735 we rewrite the library groups system. Those references in branches.tt were part of the previous code, and they can be removed. Test plan: Confirm the above and that those code errors are never sent to the template. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32291] "library category" messages should be removed (not used)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] OPAC - Mobile - Items table columns are too thin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 Daphne Hoolahan changed: What|Removed |Added CC||d...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31326] Koha::Biblio->get_components_query fetches too many component parts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31326 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31326] Koha::Biblio->get_components_query fetches too many component parts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31326 Emmi Takkinen changed: What|Removed |Added Attachment #138886|0 |1 is obsolete|| CC||emmi.takki...@koha-suomi.fi --- Comment #3 from Emmi Takkinen --- Created attachment 144398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144398=edit Bug 31326: Koha::Biblio->get_components_query fetches too many component parts This patch adds double quotes to rcn and cni when searching component parts with get_components_query. Test plan: 1) Apply the patch 2) prove Koha/t/db_dependent/Koha/Biblio.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31490] Terminology: change "staff client" to "staff interface" in marc-overlay-rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31490 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32389] Syndetics links are built wrong on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389 --- Comment #4 from Owen Leonard --- Signed off based on the content of the patch even though I don't have Syndetics credentials to test live. I suspect the origin of this bug was some variation on handling the BiblioDefaultView system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32389] Syndetics links are built wrong on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389 Owen Leonard changed: What|Removed |Added Attachment #144383|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 144397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144397=edit Bug 32389: Fix Syndetics link on staff results page To test: 1. Have SyndeticsCoverImages on and Syndetics setup. 2. Do a search that will return some results with Syndetics images 3. Click on the image link and you will get a 404 4. Apply patch 5. Link works! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32389] Syndetics links are built wrong on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar, but still an additional save button at the bottom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Owen Leonard changed: What|Removed |Added Attachment #144395|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 144396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144396=edit Bug 32074: Edit vendor has two save buttons When editing a vendor there is a floating toolbar with options to save and cancel. There is also an additional save and cancel button set at the bottom of the page and this is superfluous. This has now been removed to leave the floating toolbar as the only toolbar. Test plan: 1) Navigate to Acquisitions and select a Vendor. 2) Click edit vendor 3) Scroll down the page and observe that there is a floating save/cancel toolbar as well as the buttons to save/cancel at the bottom of the page 4) Apply patch 5) Observe that the duplicate buttons at the bottom of the page are now gone Signed-off-by: Owen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar, but still an additional save button at the bottom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- I think biblio-title.inc should be used here instead -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30943] Make background job classes use helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > OK.. I think this patchset if solid as is if we push the process fix first > that checks for status... > > Having both process and start methods is slightly confusing at first ;P I agree the terminology is confusing. But they are really different things, as ->process is really the overloaded method in the job class, and ->start is just marking the task as started. i.e. if we rename process => start, we will still want a (say) ->mark_started method that does what this method does. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32381] Koha should be able to receive and record reasons for failed SMS notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi --- Comment #2 from Emmi Takkinen --- Could this be a duplicate of bug 31481? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar, but still an additional save button at the bottom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Matt Blenkinsop changed: What|Removed |Added Status|NEW |Needs Signoff CC||matt.blenkinsop@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar, but still an additional save button at the bottom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 --- Comment #1 from Matt Blenkinsop --- Created attachment 144395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144395=edit Bug 32074: Edit vendor has two save buttons When editing a vendor there is a floating toolbar with options to save and cancel. There is also an additional save and cancel button set at the bottom of the page and this is superfluous. This has now been removed to leave the floating toolbar as the only toolbar. Test plan: 1) Navigate to Acquisitions and select a Vendor. 2) Click edit vendor 3) Scroll down the page and observe that there is a floating save/cancel toolbar as well as the buttons to save/cancel at the bottom of the page 4) Apply patch 5) Observe that the duplicate buttons at the bottom of the page are now gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to wrong column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Jacob O'Mara changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||jacob.om...@ptfs-europe.com Version(s)|23.05.00|23.05.00, 22.11.01 released in|| --- Comment #28 from Jacob O'Mara --- Nice work! Pushed to 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32334] Sync comments in database with schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Marcel de Rooy changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, tomasco...@gmail.com --- Comment #5 from Marcel de Rooy --- A few excerpts from the POD of the new module and script: === SYNOPSIS perl sync_db_comments.pl [-h] [-v] [-database DB_NAME] [-table TABLE_NAME] [-dry_run] [-clear|-reset|-renumber] Synchronize column comments in database with Koha schema. Allows you to clear comments too. Operates additionally on specific tables only. And provides a dry run mode that prints sql statements. This script may prove helpful to track synchronization issues between Koha schema and actual database structure due to inconsistencies in database revisions. It reduces the noise from missing column comments when running script update_dbix_class_files.pl. and The advantage of keeping in sync is that you can easily track differences between schema and database with the maintenance script update_dbix_class_files.pl. === Yes, it adds another module. But keeping track of schema issues is imo important enough. The noise of missing or changed comments can be handled in various ways. This approach was the most practical one for me in the end. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
