[Koha-bugs] [Bug 24258] Sending partner request doesn't fall back to KohaAdminEmailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24258 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30962] REST API: Add endpoint /patrons/:patron_id/check_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #17 from David Cook --- (In reply to Tomás Cohen Arazi from comment #16) > (In reply to David Cook from comment #12) > > Are all the existing API tests in "t/db_dependent/api/v1/"? > > Not sure what you mean here, but we try to enforce 100% code coverage on the > tests. Are good examples of API tests found in that location? > > > 2. Route's name should not be a verb (/password/validation maybe?) > > > > I did struggle to come up with a noun for this one so I take the point. > > I'd go with 'validation'. In light of the /api/v1/auth/* routes that we have these days... /api/v1/auth/validation? Or do we want another path prefix in there like "password" for /api/v1/auth/password/validation? And we'd be posting userid and password to that endpoint. -- I'm currently using /patrons/:patron_id/check_password and when I implemented bug 31982 locally it did cause a problem because I was using the OPAC interface. I switched to the Staff Interface API and then it was all good. In my case, the consumer of this API is Keycloak, which also runs locally. If it was a third-party system, I think I'd need to create an security exception to allow it through to that endpoint. I keep thinking about public vs non-public APIs... and I figure public APIs are things that every day people and front-end systems should be able to use. They offer the same functionality to the public as the OPAC but they do so in a machine-friendly way. If an action is only allowed by staff, it's part of the non-public admin API. And if there's a third-party system that needs to access that, because we trust it, then we make an explicit exception for it, and ideally keep the scope narrowed to just what it needs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32500] OPAC_REG_VERIFY has too many options for "Message body"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32500] OPAC_REG_VERIFY has too many options for "Message body"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 --- Comment #1 from David Cook --- Created attachment 144731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144731=edit Bug 32500: Show only relevant message body option for OPAC_REG_VERIFY This patch changes the "Message body" options for the OPAC_REG_VERIFY notice so that only the relevant "borrower_modifications.verification_token" appears as an option. Tables like branches, biblio, biblioitems, items, borrowers, and issues aren't passed to OPAC_REG_VERIFY at processing time. The only table passed is "borrower_modifications", and only the token is the relevant field there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32500] OPAC_REG_VERIFY has too many options for "Message body"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32057] Add optional stack trace to action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from David Nind --- The patch no longer applies 8-(... Applying: Bug 32057: Add optional stack trace to action logs Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/mandatory/sysprefs.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 32057: Add optional stack trace to action logs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #6 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz Status|Pushed to oldoldstable |Pushed to oldoldoldstable Version(s)|22.11.00, 22.05.07, |22.11.00, 22.05.07, released in|21.11.15|21.11.15, 21.05.22 --- Comment #13 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29671] Dropbox mode is unchecked after check in confirm on item with Materials specified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29671] Dropbox mode is unchecked after check in confirm on item with Materials specified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 Status|Pushed to oldstable |Pushed to oldoldstable CC||wainuiwitikapark@catalyst.n ||et.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31643] Link authorities automatically requires ALL cataloging and authorities permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|22.11.00, 22.05.8, 21.11.15 |22.11.00, 22.05.8, released in||21.11.15, 21.05.22 Status|Pushed to oldoldstable |Pushed to oldoldoldstable CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #9 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31559] Staff results page doesn't always use up full available screen width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31559 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz Status|Pushed to oldoldstable |Pushed to oldoldoldstable Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 --- Comment #7 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz Status|Pushed to oldoldstable |Pushed to oldoldoldstable Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 --- Comment #24 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31593] Remove Test::DBIx::Class from Context.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31593 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 CC||wainuiwitikapark@catalyst.n ||et.nz Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #7 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to oldoldstable |Pushed to oldoldoldstable CC||wainuiwitikapark@catalyst.n ||et.nz Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 --- Comment #8 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to oldoldstable |Pushed to oldoldoldstable Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #9 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20473] "Item information" tab should not appear if item is not created upon placing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 David Nind changed: What|Removed |Added Text to go in the||This updates adding an release notes||order to a basket from a ||staged file (when the ||setting for the basket is ||to not create items until ||the order is received or ||catalogued) so that the ||'Item information' tab ||doesn't appear, as it is ||not used. CC||da...@davidnind.com --- Comment #8 from David Nind --- Testing notes (using KTD): 1. For step 2: When adding a basket to a vendor, for 'Create items when' select either 'receiving an order' or 'cataloging the record'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31651] Log message incorrect in Auth_with_shibboleth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #8 from David Cook --- (In reply to David Cook from comment #7) > I've created the wiki page https://wiki.koha-community.org/wiki/Testing_SSO > > I haven't filled it in yet, but I'll see if I can get something up soon... Apparently I'm not good at leaving things be... so I went ahead and created the guides. The formatting needs work but I've tested both OpenID Connect and SAML with Keycloak and both worked. The SAML guide took a few iterations, so if something doesn't work, it's probably because I forgot to make update it. But I think it should be right. Note that Koha forces HTTPS for SAML, which is good in theory, but not so good for testing. However, you can manually bypass this by updating the URL yourself to be HTTP only. -- In the near future, we could probably set up koha-testing-docker to have more of this setup out of the box. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20473] "Item information" tab should not appear if item is not created upon placing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 David Nind changed: What|Removed |Added Attachment #144679|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 144730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144730=edit Bug 20473: Whitespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20473] "Item information" tab should not appear if item is not created upon placing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 David Nind changed: What|Removed |Added Attachment #144678|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 144729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144729=edit Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save' Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20473] "Item information" tab should not appear if item is not created upon placing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31890] PrefillGuaranteeField should include option to prefill surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31890 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This enhancement adds the release notes||surname field to the list ||of fields (in the ||PrefillGuaranteeField ||system preference) that can ||be automatically prefilled ||when adding a guarantee to ||a patron's account. --- Comment #3 from David Nind --- Testing notes (using KTD): 1. Step 4: Showing my lack of knowledge (for whatever reason, I originally couldn't work out how to do this!) - to add a guarantee to a patron: 1.1 Go to a patron's account (such as Mary Burton) 1.2 Click the '+ Add guarantee' option after the 'Edit' option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32499] HOLDPLACED email goes to patron branch rather than item branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #2) > Maybe pick-up library could be an alternative? But I get a feeling that this > might need a configuration option. I thought about pick-up library, but that might still be the patron's library, rather than the library that actually holds the item. Yeah, I thought about getting it to obey CircControl, but "the library you are logged in at" is a bit problematic. I don't love relying on global variables and there would be no easy way to pass it in. -- I was thinking the current behaviour has been around for many years, so configuration option probably makes sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32499] HOLDPLACED email goes to patron branch rather than item branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #1) > What if there are multiple items from several branches? I think one email goes out per item but interesting point -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31890] PrefillGuaranteeField should include option to prefill surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31890 David Nind changed: What|Removed |Added Attachment #144725|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 144728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144728=edit Bug 31890: Add surname to PrefillGuaranteeField system pref To test: 1. Apply patch and restart_all 2. Find the system preference PrefillGuaranteeField 3. Look for the Surname option and add it 4. Go to a patron account and add a gaurantee 5. See that the surname is properly populated for the gaurantor's surname field Note: This patch replaces borrower_data.surname with patron.surname. There seems to be a mismatch here so I filed Bug 32458. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31890] PrefillGuaranteeField should include option to prefill surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31890 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31890] PrefillGuaranteeField should include option to prefill surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31890 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32382] Fund input misaligned on invoice summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #5 from Lucas Gass --- (In reply to Andrew Fuerste-Henry from comment #3) > Alignment looks good. > > On both the Shipping fund and the Adjustment fund, after I've checked the > Show Inactive box once, inactive funds show in the dropdown forever, even > after I uncheck the box. I've confirmed this doesn't happen without your > patches. Nice catch, I provided a follow up that should fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32382] Fund input misaligned on invoice summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #4 from Lucas Gass --- Created attachment 144727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144727=edit Bug 32382: (follow-up) Fix selector -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32382] Fund input misaligned on invoice summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32499] HOLDPLACED email goes to patron branch rather than item branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499 --- Comment #2 from Katrin Fischer --- Maybe pick-up library could be an alternative? But I get a feeling that this might need a configuration option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32499] HOLDPLACED email goes to patron branch rather than item branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499 --- Comment #1 from Katrin Fischer --- What if there are multiple items from several branches? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31651] Log message incorrect in Auth_with_shibboleth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #7 from David Cook --- (In reply to Martin Renvoize from comment #3) > CCing David whose much more familiar with KeyCloak.. I think we could do > with getting a few little mini guides on how to set these things up for > quick tests. I've created the wiki page https://wiki.koha-community.org/wiki/Testing_SSO I haven't filled it in yet, but I'll see if I can get something up soon... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32500] New: OPAC_REG_VERIFY has too many options for "Message body"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 Bug ID: 32500 Summary: OPAC_REG_VERIFY has too many options for "Message body" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org When creating the "Message body" for the "OPAC_REG_VERIFY" email template, the only available options should be <> and <> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32499] New: HOLDPLACED email goes to patron branch rather than item branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499 Bug ID: 32499 Summary: HOLDPLACED email goes to patron branch rather than item branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The HOLDPLACED email is sent out if "emailLibrarianWhenHoldIsPlaced" is enabled. Currently, it is sent to the patron's branch, but it seems to me (and my librarians) that it would make more sense to be emailed to the item's branch, since that's the branch where the librarian is going to be able to do something about it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Special characters causes patron search to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > As we are doing an > SQL based search here I am not sure what could be done to make this easily > possible - removing the comma or other characters by default might break > some searches? Hmm maybe normalizing the search to remove punctuation isn't a bad idea. I normalize the search for phone number (see bug 23817) although it can actually be fairly difficult to do in the newest versions of Koha because of how we use the REST API for patron search... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32487] Cronjob to delete records with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32487 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Locally we handle this scenario using a custom report page where librarians can review bib records with no items attached. They'll often exclude electronic resources by item type. It's a more manual process than a cronjob, but it's less error prone I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32498] New: Checking an in-transit item out at a branch other than the tobranch should cancel the transfer rather than complete it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32498 Bug ID: 32498 Summary: Checking an in-transit item out at a branch other than the tobranch should cancel the transfer rather than complete it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andre...@dubcolib.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If an item is mid-transfer and gets checked out at a branch other than its tobranch, Koha marks the transfer as arrived and edits the tobranch to be the branch at which the checkout happens. This makes for a confusing data trail. Instead, the transfer should be cancelled and the original tobranch should be retained. https://github.com/Koha-Community/Koha/blob/c7a995d28f7ae3759ec9ad377b5f7f2b5828e06a/C4/Circulation.pm#L1613 To recreate: 1: Start a manual transfer of an item from Branch A to Branch B 2: Confirm the item shows as in transit and the branchtransfers table shows frombranch=A, tobranch=B 3: Check item out at Branch A 4: Confirm the branchtransfers table now shows frombranch=A, tobranch=A, has a datearrived value, and has a comment "Forced branchtransfer" (or, if the checkout happens at a third branch) 5: Start a manual transfer of an item from Branch A to Branch B 6: Confirm the item shows as in transit and the branchtransfers table shows frombranch=A, tobranch=B 7: Check item out at Branch C 8: Confirm the branchtransfers table now shows frombranch=A, tobranch=C, has a datearrived value, and has a comment "Forced branchtransfer" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31624] REST API: Add endpoint for generated covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 --- Comment #3 from Paul Derscheid --- I made some typos. The patch is not ready for a sign-off (not 'now' ready). And of course I'm in the process of writing unit tests, not using them. See #c1 for reference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31624] REST API: Add endpoint for generated covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 --- Comment #2 from Paul Derscheid --- The preliminary test plan assumes ktd, btw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31624] REST API: Add endpoint for generated covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624
--- Comment #1 from Paul Derscheid ---
Created attachment 144726
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144726=edit
Bug 31624: REST API: Add endpoint for generated covers
This commit contains the main changes for the endpoint and the controller for
the image generation.
To test this, if you don't have a very elaborate setup:
1. Apply the patch
2. Request the endpoint, for example using:
http://localhost:8080/api/v1/public/biblios/1/default_cover
3. Now you could use this JS in your console to get an unescaped version of the
JSON response
const response = await
fetch('http://localhost:8080/api/v1/public/biblios/1/default_cover');
const result = await response.json();
console.log(result);
4. Copy the response and check whether it actually is a valid base64 encoded
image. For example using this tool: https://base64.guru/converter/decode/file
5. Give me your thoughts on this patch
I'm still in the process of using unit tests and hunting bugs, so it's now
ready for a sign-off but I thought I'd already show it to whoever is
interested.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31890] PrefillGuaranteeField should include option to prefill surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31890 --- Comment #1 from Lucas Gass --- Created attachment 144725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144725=edit Bug 31890: Add surname to PrefillGuaranteeField system pref To test: 1. Apply patch and restart_all 2. Find the system preference PrefillGuaranteeField 3. Look for the Surname option and add it 4. Go to a patron account and add a gaurantee 5. See that the surname is properly populated for the gaurantor's surname field Note: This patch replaces borrower_data.surname with patron.surname. There seems to be a mismatch here so I filed Bug 32458. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31890] PrefillGuaranteeField should include option to prefill surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31890 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32470] (Bug 14783 follow-up) Fix mysql error in db_rev for 22.06.000.064
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32470 Katrin Fischer changed: What|Removed |Added CC||hannah...@northwestu.edu --- Comment #6 from Katrin Fischer --- *** Bug 32497 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32497] Updating Database Structure fails with table "specified twice"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32497 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Hanna, a fix for this will be in 22.11.01, see bug 32470. *** This bug has been marked as a duplicate of bug 32470 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32497] Updating Database Structure fails with table "specified twice"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32497 Hannah Co changed: What|Removed |Added Severity|enhancement |blocker Priority|P5 - low|P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32497] New: Updating Database Structure fails with table "specified twice"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32497
Bug ID: 32497
Summary: Updating Database Structure fails with table
"specified twice"
Change sponsored?: ---
Product: Koha
Version: 22.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Installation and upgrade (web-based installer)
Assignee: koha-bugs@lists.koha-community.org
Reporter: hannah...@northwestu.edu
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Upgrading from 22.05 to 22.11, the web installer is failing at "Updating
database structure" with the following error:
Upgrade to 22.06.00.064 [11:24:08]: Bug 14783 - Allow patrons to change pickup
location for non-waiting holds
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table
'systempreferences' is specified twice, both as a target for 'UPDATE' and as a
separate source for data at /usr/share/koha/lib/C4/Installer.pm line 739
Added new system preference 'OPACAllowUserToChangeBranch'
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table
'systempreferences' is specified twice, both as a target for 'UPDATE' and as a
separate source for data at /usr/share/koha/lib/C4/Installer.pm line 739
I am looking for a solution to this one, and not finding much that's helpful.
Does installer.pm need modification, or does the database need some changes.
Prior to the error I followed steps to resolve errors related to bug 32399,
with errors on the issues table and a couple foreign keys. I don't see how the
systempreferences table is related, though.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #34 from David Gustafsson --- Created attachment 144724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144724=edit Bug 31735: Optimize OPAC checkouts view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 David Gustafsson changed: What|Removed |Added Attachment #144723|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #2 from David Gustafsson --- Created attachment 144723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144723=edit Bug 32496: Optimize OPAC checkouts view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #1 from David Gustafsson --- Created attachment 144722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144722=edit Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm Refactor the most performance critical subroutines in Circulation.pm to take objects instead of unblessed ones to reduce unnecessary unblessings and generally clean up the code. To test: 1) Ensure the following tests all pass: t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/ILSDI_Services.t t/db_dependent/Illrequests.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/SIP/ILS.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3249] LOST is not triggering replacement charge on checked out items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3249 Owen Leonard changed: What|Removed |Added Depends on|21996 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21996 [Bug 21996] SPAM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21996] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21996 Owen Leonard changed: What|Removed |Added Blocks|3249| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3249 [Bug 3249] LOST is not triggering replacement charge on checked out items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Owen Leonard changed: What|Removed |Added Depends on|21996 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21996 [Bug 21996] SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3249] LOST is not triggering replacement charge on checked out items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3249 Owen Leonard changed: What|Removed |Added Depends on||21996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21996 [Bug 21996] SPAM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21996] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21996 Owen Leonard changed: What|Removed |Added Blocks|32496 |3249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3249 [Bug 3249] LOST is not triggering replacement charge on checked out items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What|Removed |Added Blocks||32496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21996] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21996 David Gustafsson changed: What|Removed |Added Blocks||32496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 David Gustafsson changed: What|Removed |Added Depends on||21996, 31735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21996 [Bug 21996] SPAM https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] New: Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Bug ID: 32496 Summary: Reduce unnecessary unblessings of objects in Circulation.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: glask...@gmail.com QA Contact: testo...@bugs.koha-community.org There are a lot of instances in of unnecessary unblesssings in Circulation.pm (and also in some other parts of the C4 namespace), for legacy reasons I assume as it was an convenient way not having to adept the code to much after changing to the object oriented interface. This patch builds on Bug 31735 and cleans up a large part, but not all, of these uncalled-for unblessings. I focused mainly on refactoring CanBookBeRenewed and the subroutines it calls as this is run for each checked out item and has on of the highest performance impacts of the circulation related subroutines. The performance gains are pretty modest though, so the main motivation is to clean up the code (and in some instances avoid having to re-fetch the object where a method needs to be called, and an unblessed hashref was passed in). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32495] New: Required fields in API and UI form don't match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32495 Bug ID: 32495 Summary: Required fields in API and UI form don't match Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+k...@gmail.com Reporter: matt.blenkin...@ptfs-europe.com CC: jonathan.druart+k...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, pedro.amo...@ptfs-europe.com The required fields in the API for adding a new agreement and the form on the UI to add it don't match. The API endpoint for POST "/api/v1/erm/agreements" requires "name, status, is_perpetual" The form on the UI requires the fields above (is_perpetual is a checkbox with a default value selected) but also requires "Description". Description should either be added to the API or the flag on the UI should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Blocks||32494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32494 [Bug 32494] Potentially expensive API calls made for conditional template rendering -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32494] Potentially expensive API calls made for conditional template rendering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32494 Matt Blenkinsop changed: What|Removed |Added Depends on||32474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 [Bug 32474] Implement infinite scroll in vue-select -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32494] New: Potentially expensive API calls made for conditional template rendering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32494 Bug ID: 32494 Summary: Potentially expensive API calls made for conditional template rendering Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+k...@gmail.com Reporter: matt.blenkin...@ptfs-europe.com CC: jonathan.druart+k...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, pedro.amo...@ptfs-europe.com Bug 32474 introduces ajax based scrolling in v-selects to reduce expensive API calls. Within ERM there are components where an API call is made and then sections of template are conditionally rendered depending on whether the call returns any data. For example, LicensesList.vue requests a list of all licenses and then renders a div containing a table if "licences.length" is true. The table then makes the same API call again to fetch the data to populate the table. The initial API call is therefore not relevant to the table data and if there is a large number of licenses, this will be an expensive call to make simply to render the table before making the same call again. I would suggest that the initial API call needs to be paginated to return a small amount of data to pass the licenses.length conditional check. The change proposed in bug 32474 in fetch.js allows fetchLicenses to be called with a parameter to paginate to just one page like this: "fetchLicenses(1)". We will then only be fetching one page of 20 values to pass the check. N.B. in bug 32474 components with a v-select have already been paginated e.g. AgreementLicenses.vue - this bug is to patch the components that have not been modified already, such as LicensesList.vue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32487] Cronjob to delete records with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32487 --- Comment #2 from Katrin Fischer --- There are actually quite a lot of cases that come to mind, where a record has no items but is still wanted/needed: * Set type records for multi-volumes * Series type records for traced series * Records where the item is linked using EasyAnalytics * Analytical records using 773 standard linking * Serials where the library has subscriptions and issues, but doesn't create items * Acquisition records where the library doesn't attach items or new standing order records * Electronic resources - 856 might not be best, as it could also be some other type of content enrichment like a scanned TOC. Maybe 007, Pos. 0? https://www.loc.gov/marc/bibliographic/bd007.html Maybe an option: add a --WHERE SQL condition option to the existing batchdeletebiblios.pl. This way it would allow libraries to easily specifiy "has no items", without going into the rabbit hole of discussing all the above cases. Keeping it simple. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Blocks||32493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32493 [Bug 32493] Vendor store loads unpaginated vendor list on ERM module main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32493] Vendor store loads unpaginated vendor list on ERM module main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32493 Matt Blenkinsop changed: What|Removed |Added Depends on||32474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 [Bug 32474] Implement infinite scroll in vue-select -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32493] New: Vendor store loads unpaginated vendor list on ERM module main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32493 Bug ID: 32493 Summary: Vendor store loads unpaginated vendor list on ERM module main page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+k...@gmail.com Reporter: matt.blenkin...@ptfs-europe.com CC: jonathan.druart+k...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, pedro.amo...@ptfs-europe.com Work is in progress to implement pagination on select dropdowns to avoid loading large lists of data for select options. However, in the ERMMain component there is an API call to fetch all the vendors and then load these into a Pinia store. This vendor store is then used in tables throughout ERM. The store should probably be removed and a different solution found for fetching the data for those tables to avoid a slow initial load of the ERM module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Katrin Fischer changed: What|Removed |Added Summary|Avoid re-fetcing objects|Avoid re-fetching objects |from database by passing|from database by passing |them down instead of object |them down instead of object |ids |ids -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32487] Cronjob to delete records with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32487 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org --- Comment #1 from Andrew Fuerste-Henry --- It'd be great if this included some way to exclude some itemless bibs, for libraries that include bibs for ebooks without attached item records. Maybe an option to exclude certain biblio-itemtypes from the deletion? Or to exclude bibs with something in the 856? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31735] Avoid re-fetcing objects from database by passing them down instead of object ids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What|Removed |Added Attachment #144635|0 |1 is obsolete|| --- Comment #33 from David Gustafsson --- Created attachment 144721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144721=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.01 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32492] New: Improve mark-up of OPAC messaging table to ease customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32492 Bug ID: 32492 Summary: Improve mark-up of OPAC messaging table to ease customization Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When looking at the messaging preferences table in the OPAC, it's really hard to customize. You can only use the row index or the translated descriptions when trying to select the correct line to add things to or when you want to hide unused messages. It would be great if we could add classes with the code for each notice/message, so this is easier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #144614|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #5 from Matt Blenkinsop --- Created attachment 144720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144720=edit Bug 32474: Ajax based infinite scroll selects I have created a reuseable component called InfiniteScrollSelect which allows v-selects to load options in a paginated manner through Ajax requests rather than making expensive Ajax calls when the select box is first opened. All v-selects that are likely to need this functionality have been updated for Agreements, Licenses, Packages and Vendors. Test Plan: To test this requires adding enough dummy data to show the pagination fully. I have written a script that does this, please see the attachments if you wish to use this. 1) Navigate to a window that offers a dropdown menu for either Vendors, Agreements, Licenses, Packages. 2) Observe that all data is already pre-loaded into the options list and only one request is made for this data regardless of data size 3) Apply patch 4) Navigate to the same select box and observe that only the first 20 values are available with paginated Ajax requests being made as you scroll down -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #4 from Matt Blenkinsop --- Created attachment 144719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144719=edit Test data population script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23538] Email library when new patrons self register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Special characters causes patron search to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #1 from Katrin Fischer --- I don't think the special character is the issue here - the problem is, that the comma is not part of the data, so you get no match. As we are doing an SQL based search here I am not sure what could be done to make this easily possible - removing the comma or other characters by default might break some searches? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] New: Special characters causes patron search to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Bug ID: 32491 Summary: Special characters causes patron search to fail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Using a comma when searching for patrons such as "Smith, John" will show no results. However, searching for "Smith John" will pull all related patron records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Lucas Gass changed: What|Removed |Added Attachment #144713|0 |1 is obsolete|| --- Comment #10 from Lucas Gass --- Created attachment 144718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144718=edit Bug 29453: Add endpoints for fetching patron credits & debits This patch adds two new API endpoints for fetching a patrons credits and a patrons debits. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 --- Comment #9 from Lucas Gass --- The QA tool complains: OK Koha/Account.pm FAIL Koha/Account/Credit.pm FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Account::Credit': current merge results [ Koha::Account::Credit, ] merging failed on 'Koha::Account::Line' OK Koha/Account/Credits.pm FAIL Koha/Account/Debit.pm FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Account::Debit': current merge results [ Koha::Account::Debit, ] merging failed on 'Koha::Account::Line' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453
--- Comment #8 from Lucas Gass ---
Note: I am testing by playing around with this JS:
let bn = 5;
let api_url = "/api/v1/patrons/" + bn + "/account/debits";
$.getJSON(api_url, function(data) {
console.log(data)
});
Works well.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31950] Page section on library view is too wide / not aligned with toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950 Lucas Gass changed: What|Removed |Added Attachment #144712|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 144717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144717=edit Bug 31950: Amend page-section width and alignment Test Plan: Navigate to Admin -> Libraries and click on a Library Observe that the page-section is too wide and not aligned Apply Patch Observe that page-section is now the correct width Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31950] Page section on library view is too wide / not aligned with toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31950] Page section on library view is too wide / not aligned with toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950 Lucas Gass changed: What|Removed |Added Attachment #144636|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Maude changed: What|Removed |Added CC||maude.boudr...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32378] Incorrect label for in identity provider domains
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32378 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32378] Incorrect label for in identity provider domains
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32378 Martin Renvoize changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.01 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330 Martin Renvoize changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.01 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Thanks for the quick fix Jonathan and the quick testing Lucas. All looks good and works for me.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize changed: What|Removed |Added Attachment #144622|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 144716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144716=edit Bug 32468: Remove unecessary fetch titles JS functions Those JS functions are no longer in use and can be removed. Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
