[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

--- Comment #5 from Katrin Fischer  ---
A timeout seems arbitrary when you ultimately want all jobs to be processed and
nothing be lost.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
(In reply to David Cook from comment #3)
> According to the RabbitMQ Work Queues tutorial, we're doing the right thing
> by ACKing after the message has been processed.

According to that tutorial, this allows RabbitMQ to redeliver the message to
another worker. But do we really want that ? A background job should not be
restarted if it failed, because it might fail forever, or because by running it
more than once it might do unwanted modifications to the database.
I believe that the background job worker should acknowledge the message as soon
as it receives it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

--- Comment #7 from Julian Maurice  ---
> as soon as it receives it...
or at least as soon as it has validated that the message correspond to an
existing pending job, or something like that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32061] in the title of z39.50 servers page

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |minor
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32512] New: Add ability to select subfields to display on authority summary page

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32512

Bug ID: 32512
   Summary: Add ability to select subfields to display on
authority summary page
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: janet.mcgo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

In the display that shows on the Authorities Summary page
/authorities/auth_finder.pl it is not possible to control which fields display.
Specifically for PERSO_NAME authorities the 100$a displays and the $y
Chronological subdivision displays.
For the PERSO_NAME it would be more relevant to display the $e relator term.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in Table settings

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504

Slava Shishkin  changed:

   What|Removed |Added

Summary|Empty column name for   |Empty column name,
   |basket/orders in Table  |misaligning visibility, and
   |settings|export for basket/orders in
   ||Table settings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in Table settings

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504

--- Comment #3 from Slava Shishkin  ---
Created attachment 144767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144767&action=edit
Bug 32504: Fix misalignment of visibility of basket orders table columns and
missing export columns

To reproduce:
1. Go to /cgi-bin/koha/admin/columns_settings.pl
2. In the section Acquisition > Basket > Orders uncheck all checkboxes in the
table settings
3. Go to a separate browser window to /cgi-bin/koha/acqui/booksellers.pl and
open/create a new basket and add one book to it so the basket table will have
rows in the "Order" table which we will configure below:
4. Click on the ["Columns" settings] for the table.
5. In the dropdown menu, observe that all Columns are marked as visible and
correspond to the current table display.
6. Also check the export table feature: Click on "Export" and choose print, you
will see that Columns up to GST (goods_and_services_tax) are displayed, and
Fund and Estimated delivery date are missing.
7. Go back to table settings (like it was in steps.1-2)
8. Make the estimated_delivery_date column 'invisible by default' by checking
out the appropriate checkbox and saving the changes.
9. Refresh the basket window/page (like in step 3).
10. Observe that in the table the whole columns "Estimated delivery date" is
visible but "Fund" is gone.
11. Click on the ["Columns" settings] for the table.
12. In the dropdown menu observe that the wrong column is disabled ("Fund"
instead of "Estimated delivery date").
13. Apply the patch.
14. Go through steps 3-12 and make sure that everything mentioned in those
steps now works correctly: when you hide any columns in columns_settings.pl
they are correctly hidden for the "Order" table, as well when exporting the
table, the Fund, and Estimated delivery date columns are now exported.

Note: this patch also respects Koha.Preference('EDIFACT') setting and when it's
enabled it also correctly hides/shows and exports the 'supplier_report' column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in Table settings

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504

--- Comment #4 from Slava Shishkin  ---
(In reply to Lucas Gass from comment #2)

Right, this is fixed. And also export was broken: missed two columns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after uninstalling a plugin

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #11 from Blou  ---
> Not sure we should even fix it ;)

are you trolling?  If Olivier fixed it, it's because it caused us sufficient
headaches during (Koha) upgrades to open/look for a Bz.  Our threshold is
pretty high in that regard, nowadays  

I understand the discussion is threading toward the old "you can't call the
garbage collector from the code", that's valid.  But then the bug must be fixed
some other way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

Paul Derscheid  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #144546|0   |1
is obsolete||

--- Comment #4 from Paul Derscheid  ---
Created attachment 144768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144768&action=edit
Bug 32341: Some OPAC tables are not displayed well in mobile mode

Some OPAC tables are not displayed well in mobile mode, it is absolutely
necessary to scroll to the right to read the content properly

This patch fix this problem by making the tables responsive

To test:
  1- Go to the OPAC
  2- Open mobile mode
  3- Go to a bibliographic record detail page in the OPAC
(opac-detail.pl?biblionumber=X)
  4- Check the Holdings table
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> we see very narrow columns
--> unreadable text
  5- Go to to the page 'Summary' (opac-user.pl)
  6- Check the 'Checked out' table
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> The columns are overflowing to the right
  7- Check the 'Overdue' table
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> The columns are overflowing to the right
  8- Go to the page 'Charges' (opac-account.pl)
  9- Click on 'Show all transactions'
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> The columns are overflowing to the right
  10- Go to the page 'Search history' (opac-search-history.pl)
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> The columns are overflowing to the right
  11- Apply the patch
  12- Execute 'yarn build --view opac'
  13- Clean your cache or open your navigator on private mode (to load
updated css files)
  14- Perform previous step (1-10)
  15- Confirm that the tables are now displayed correctly and is now
responsive.

Signed-off-by: LMSCloudPaulD 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

Paul Derscheid  changed:

   What|Removed |Added

 CC||paul.dersch...@lmscloud.de

--- Comment #5 from Paul Derscheid  ---
Works as advertised. However, imho the svgs and the button placement could
still be improved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after uninstalling a plugin

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #12 from Katrin Fischer  ---
I don't think Frido was trolling, but adding his 2 cents to the discussion. 

I agree that we need to make the process for updating/installing/removing
plugins more seamless somehow. If the point is that the user should be able to
do these actions from the GUI, we need a way to make Plack aware of changes,
because right now we expect them to do a server side action, without even
telling them to.

This is prominent when you install a new version of a plugin: the version shown
on the plugin page will not increase, although the plugin was installed
correctly, until Plack is restarted. This is very confusing.

If the approach taken here, as David noted in comment#10, maybe we could find a
way to improve the patch or find another way?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

--- Comment #6 from Paul Derscheid  ---
For reference look at this discussion on irc @Hammat:
http://irc.koha-community.org/koha/2022-12-21$=#id_l75

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32057] Add optional stack trace to action logs

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32057] Add optional stack trace to action logs

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

--- Comment #10 from Kyle M Hall  ---
Created attachment 144769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144769&action=edit
Bug 32057: Update ActionLog schema file [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

--- Comment #7 from Owen Leonard  ---
I would like to see some more iteration of this... I think the last column in
the table makes more sense for the placement of the button. Having it's own
column (using "details: {type: 'column'}" ) would help prevent it from being
too small a target for someone to tap.

The button isn't very clear to me in terms of what it's for... I'm not sure at
the moment what to suggest, though.

Is it necessary to add jquery.dataTables.min.css globally? I think our CSS
includes the styles we need.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

Owen Leonard  changed:

   What|Removed |Added

 QA Contact|hammat.w...@inlibro.com |testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32114] Template error in OPAC search results RSS

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Lucas Gass  changed:

   What|Removed |Added

   Keywords||rel_22_05_candidate
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27973] Limit to currently available items should have an option to filter out notforloan statuses

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

Susan  changed:

   What|Removed |Added

 CC||susan.mer...@nhs.net

--- Comment #9 from Susan  ---
I tried to limit by items available and was surprised to find withdrawn items
appeared within results. I do not consider those to be available for loan or
requesting so to be able to exclude such items or having the filter
automatically exclude withdrawn/missing/on order would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476

--- Comment #10 from David Gustafsson  ---
Ok! My bad, now think I understand. There is an issue with your suggestion
though, if I'm not still misinterpreting parts of it. The current behavior is
to clear the cache if the accessor method is called without the cache parameter
set to true. This is if course slightly ugly imho, as not at all obvious
without looking at the code. The idea is that calling the accessor uncached
should be done either when caching doesn't matter, or when the cached value
could be stale. If the cache was not cleared subsequent cached calls could
return a stale value, resulting in subtle bugs that could be difficult to track
down. An alternative could be to always enter values into the cache regardless
if caching is enabled or not, but this is also not what one would expect and it
feels more intuitive that caching in that case is skipped altogether.

I just can't see how to this behavior using your suggestion, but if there is
something I'm missing perhaps you could provide a full example.

I created a new version which avoids the code duplication of the caching
behavior based on the previous version but instead using a class property for
storing cached values as you suggested. It's a little bit more opaque than the
original version, but the upside is that caching behavior is generalized and
the code duplication can be avoided.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144744|0   |1
is obsolete||

--- Comment #11 from David Gustafsson  ---
Created attachment 144770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144770&action=edit
Bug 32476: Add caching for relatively expensive patron methods

To test:
1) Ensure tests in t/db_dependant/Koha/Patrons.t all pass

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Andreas Jonsson  changed:

   What|Removed |Added

 CC||andreas.jons...@kreablo.se

--- Comment #22 from Andreas Jonsson  ---
This patch breaks the patch for bug 29760 since it removes the patron from the
itemloop.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

--- Comment #23 from Kyle M Hall  ---
(In reply to Andreas Jonsson from comment #22)
> This patch breaks the patch for bug 29760 since it removes the patron from
> the itemloop.

I'm still seeing the patron category displayed in the patron category column on
the holds queue viewer after applying this patch set. Am I looking in the wrong
place?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144770|0   |1
is obsolete||

--- Comment #12 from David Gustafsson  ---
Created attachment 144771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144771&action=edit
Bug 32476: Add caching for relatively expensive patron methods

To test:
1) Ensure tests in t/db_dependant/Koha/Patrons.t all pass

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476

--- Comment #13 from David Gustafsson  ---
Renamed _cached_accessor to _maybe_cached as the former implies a function is
returned.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

David Gustafsson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23009] Add -deleted_marc_conditions argument to export_records script

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23009

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32242] The job has not been sent to the message broker: (Wide character in syswrite ... )

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #22 from Lucas Gass  ---
Created attachment 144772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144772&action=edit
Bug 32242: [22.05] fix selenium tests for 22.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #142814|0   |1
is obsolete||

--- Comment #27 from David Gustafsson  ---
Created attachment 144773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144773&action=edit
Bug 29145: use overdues restrict delays when removing overdues restriction upon
return

How to test:
1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t

Sponsored by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #142815|0   |1
is obsolete||

--- Comment #28 from David Gustafsson  ---
Created attachment 144774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144774&action=edit
Bug 29145: Add tests and modify sysprefs

Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead
modify AutoRemoveOverduesRestrictions to have a third option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #142816|0   |1
is obsolete||

--- Comment #29 from David Gustafsson  ---
Created attachment 144775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144775&action=edit
Bug 29145: Fix conditions for patron debarring overdues

Signed-off-by: Michaela 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #142817|0   |1
is obsolete||

--- Comment #30 from David Gustafsson  ---
Created attachment 144776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144776&action=edit
Bug 29145: (QA follow-up) Fix missing bug number in database update and typos

Fixes some typos in test and update message that were highlighted
by the QA tools.
Adds missing bug number to the atomic update file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #143213|0   |1
is obsolete||

--- Comment #31 from David Gustafsson  ---
Created attachment 144777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144777&action=edit
Bug 29145: (QA follow-up) Add missing POD and don't return undef

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #32 from David Gustafsson  ---
Ok! Got some weird error trying to apply the current patch, so reconstructed
the patch set using our local branch. Should now apply to the current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32242] The job has not been sent to the message broker: (Wide character in syswrite ... )

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.08
released in||

--- Comment #23 from Lucas Gass  ---
Backported to 22.05.x for upcoming 22.05.08 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474

Matt Blenkinsop  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144773|0   |1
is obsolete||

--- Comment #33 from David Gustafsson  ---
Created attachment 144778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144778&action=edit
Bug 29145: use overdues restrict delays when removing overdues restriction upon
return

How to test:
1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t

Sponsored by: Gothenburg University Library

Signed-off-by: Michaela 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144774|0   |1
is obsolete||

--- Comment #34 from David Gustafsson  ---
Created attachment 144779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144779&action=edit
Bug 29145: Add tests and modify sysprefs

Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead
modify AutoRemoveOverduesRestrictions to have a third option

Signed-off-by: Michaela 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144775|0   |1
is obsolete||

--- Comment #35 from David Gustafsson  ---
Created attachment 144780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144780&action=edit
Bug 29145: Fix conditions for patron debarring overdues

Signed-off-by: Michaela 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144776|0   |1
is obsolete||

--- Comment #36 from David Gustafsson  ---
Created attachment 144781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144781&action=edit
Bug 29145: (QA follow-up) Fix missing bug number in database update and typos

Fixes some typos in test and update message that were highlighted
by the QA tools.

Add missing bug number to the atomic update file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144777|0   |1
is obsolete||

--- Comment #37 from David Gustafsson  ---
Created attachment 144782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144782&action=edit
Bug 29145: (QA follow-up) Add missing POD and don't return undef

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

--- Comment #38 from David Gustafsson  ---
Forgot to add the signed-off lines for the recreacted commits (which should be
identical to the previously signed-off ones).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32114] Template error in OPAC search results RSS

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|22.11.00|22.11.00, 22.05.08
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Lucas Gass  ---
Backported to 22.05.x for upcoming 22.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32114] Template error in OPAC search results RSS

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Lucas Gass  changed:

   What|Removed |Added

   Keywords|rel_22_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32242] The job has not been sent to the message broker: (Wide character in syswrite ... )

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Lucas Gass  changed:

   What|Removed |Added

   Keywords|rel_22_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32502] Getting patrons/{patron_id} via REST API requires edit_borrowers permission

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32502

--- Comment #1 from Matt Blenkinsop  ---
Created attachment 144783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144783&action=edit
Bug 32502: Api call to patrons/{patron_id} permission change

The API permissions for GET patrons/{patron_id} required staff to have
edit_borrowers permission rather than view_borrower_infos_from_any_libraries.
This has now been changed to allow staff to access patrons through the API.

Test plan:
1) From a staff account that does not have edit_borrowers permission, make a
request to patrons/{patron_id}
2) The request should be rejected
3) Apply patch
4) Repeat the request
5) The request should return the data for the patron requested

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32502] Getting patrons/{patron_id} via REST API requires edit_borrowers permission

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32502

Matt Blenkinsop  changed:

   What|Removed |Added

 CC||matt.blenkinsop@ptfs-europe
   ||.com
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

--- Comment #24 from Andreas Jonsson  ---

The column "Patron category" on the page /cgi-bin/koha/circ/view_holdsqueue.pl
will contain empty parentheses.

This patch removes the patron attribute from each item:

-for my $item ( @$items ) {
-$item->{patron} = Koha::Patrons->find( $item->{borrowernumber} );
-}

But the displaying of category uses this attribute:

[%
itemsloo.patron.category.description | html %] ([% itemsloo.patron.categorycode
| html %])

Also, the phone number should be affected:

  [% UNLESS Koha.Preference('HidePatronName') %]
 [% itemsloo.patron.phone | html %]
  [% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #36 from David Gustafsson  ---
Created attachment 144784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144784&action=edit
Bug 31735: Fix array that should be passed as reference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32513] New: Misalignment of List field input in label-edit-layout.pl

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32513

Bug ID: 32513
   Summary: Misalignment of List field input in
label-edit-layout.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When adding a label layout, there is the possibility to list fields to be
printed on the label. This part of the form is misaligned in the new staff
interface design.

To access this form:
1. Go to Cataloging > Label creator
2. Click on New > Layout
3. In the Bibliographic data to print section, choose List fields
--> Note that Data fields is on the right and the input box is on the left on
the next line

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32513] Misalignment of List field input in label-edit-layout.pl

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32513

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 144785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144785&action=edit
Screenshot of new label layout form with list fields option selected

Attached is a screenshot of what I'm currently seeing in the new label layout
form. (I'm using Chrome on Ubuntu 22.04, if it's relevant)

This is a screenshot of what it looked like in the previous design:
https://koha-community.org/manual/22.05/en/html/_images/listlabelfields.png

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32057] Add optional stack trace to action logs

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32057] Add optional stack trace to action logs

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

David Nind  changed:

   What|Removed |Added

 Attachment #144735|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 144786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144786&action=edit
Bug 32057: Add optional stack trace to action logs

It can be useful to know where in Koha a particular logged action was generated
from, and how. We should add the ability to attach a syspref controlled basic
stack trace with the caller depth controlled via the syspref. We can the call
caller() until the specified depth has been reached.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
4) Restart all the things!
5) Set the new syspref ActionLogsTraceDepth to a number ( e.g. 3 )
6) Update a syspref or trigger another enabled log action
7) Query the database: SELECT * FROM action_logs WHERE trace IS NOT NULL
8) Note the stack trace was created!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32057] Add optional stack trace to action logs

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

David Nind  changed:

   What|Removed |Added

 Attachment #144738|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 144787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144787&action=edit
Bug 32057: Replace insert query with use of Koha::ActionLogs

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32057] Add optional stack trace to action logs

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

David Nind  changed:

   What|Removed |Added

 Attachment #144769|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 144788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144788&action=edit
Bug 32057: Update ActionLog schema file [DO NOT PUSH]

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505

Avery Campbell (Butte County Library (CA))  changed:

   What|Removed |Added

 CC||acampb...@buttecounty.net

--- Comment #1 from Avery Campbell (Butte County Library (CA)) 
 ---
"We should be able to find patrons in a search based on the dateformat
specified."
+1 on this. Maybe even having a system preference that sets our locale
dateformat (we use mm/dd but many areas use dd/mm and /mm/dd).

mm/dd/ or mm-dd- is our locale dateformat so staff are much more used
to typing dates in this dateformat (especially since it was possible before our
recent update to 22.05).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32057] Add optional stack trace to action logs

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

David Nind  changed:

   What|Removed |Added

  Text to go in the||It can be useful to know
  release notes||where in Koha a particular
   ||logged action was generated
   ||from, and how his
   ||enhancement adds stack
   ||traces to action logs. To
   ||use, add a number for the
   ||trace depth (such as 3) to
   ||the new system preference
   ||ActionLogsTraceDepth. The
   ||details for the stack trace
   ||are available by querying
   ||the database, for example:
   ||SELECT * FROM action_logs
   ||WHERE trace IS NOT NULL;

--- Comment #14 from David Nind  ---
Thanks Kyle for fixing!

I should have thought of running dbic!

Now signed off.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after uninstalling a plugin

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #13 from Fridolin Somers  ---
(In reply to Blou from comment #11)
> > Not sure we should even fix it ;)
> 
> are you trolling?  If Olivier fixed it, it's because it caused us sufficient
> headaches during (Koha) upgrades to open/look for a Bz.  Our threshold is
> pretty high in that regard, nowadays  
Sort of trolling yes, dont feed the troll ;)

Does not the upgrade script refresh plack + memcached ?


I must say we at Biblibre do not allow plugins install via UI so we install via
script with a refresh of memcached then plack (this order is important).

I know PHP with persistence (PHP-FPM) manages that by knowing changes in
sources, I dont know how.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32057] Add optional stack trace to action logs

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

David Nind  changed:

   What|Removed |Added

  Text to go in the|It can be useful to know|It can be useful to know
  release notes|where in Koha a particular  |where in Koha a logged
   |logged action was generated |action was generated from,
   |from, and how his   |and how. This enhancement
   |enhancement adds stack  |adds stack traces to action
   |traces to action logs. To   |logs. To use, add a number
   |use, add a number for the   |for the trace depth (such
   |trace depth (such as 3) to  |as 3) to the new system
   |the new system preference   |preference
   |ActionLogsTraceDepth. The   |ActionLogsTraceDepth. The
   |details for the stack trace |details for the stack trace
   |are available by querying   |are available by querying
   |the database, for example:  |the database, for example:
   |SELECT * FROM action_logs   |SELECT * FROM action_logs
   |WHERE trace IS NOT NULL;|WHERE trace IS NOT NULL;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144722|0   |1
is obsolete||

--- Comment #3 from David Gustafsson  ---
Created attachment 144789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144789&action=edit
Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm

Refactor the most performance critical subroutines in Circulation.pm
to take objects instead of unblessed ones to reduce unnecessary
unblessings and generally clean up the code.

To test:

1) Ensure the following tests all pass:
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Illrequests.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/SIP/ILS.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144721|0   |1
is obsolete||

--- Comment #37 from David Gustafsson  ---
Created attachment 144790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144790&action=edit
Bug 31735: Avoid re-fetcing objects from database by passing them directly
instead of ids to various subroutines

To test:

1) Run the following test and make sure all pass:
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/Illrequests.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Items.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Acquisition/Order.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Holds.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Item.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/Reserves.t
  t/db_dependent/rollingloans.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/SIP/ILS.t
2) Performe one or more checkouts for a patron, making sure
  that the circulation rules allows for renewals (for example by
  setting an earlier due-date).
3) Log in as this patron in OPAC and make sure the list of
  checkouts is displayed correctly, and that renewing an issue
  still works.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144724|0   |1
is obsolete||

--- Comment #38 from David Gustafsson  ---
Created attachment 144791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144791&action=edit
Bug 31735: Optimize OPAC checkouts view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144784|0   |1
is obsolete||

--- Comment #39 from David Gustafsson  ---
Created attachment 144792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144792&action=edit
Bug 31735: Fix array that should be passed as reference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #40 from David Gustafsson  ---
Thanks for the review. I obviously failed to manually test the opac-view, this
is now fixed (the array for the in-condition should have been passed by
reference).

Regarding the failing tests, it's surprising so many are failing. I pretty sure
I originally ran through them successfully, so it could be that those test
regressions have been introduced after the rebase was performed, even though it
seems odd regarding how many are now failing. I ran through those that failed
for you on the current master, and got the following results:

Passing:

t/db_dependent/api/v1/biblios.t
t/db_dependent/api/v1/return_claims.t
t/db_dependent/Circulation/transferbook.t

Failing:

t/db_dependent/api/v1/checkouts.t
t/db_dependent/Circulation/Returns.t
t/db_dependent/Circulation.t
t/db_dependent/Illrequests.t
t/db_dependent/Koha/Account/Line.t (foreign key constraint, could work on clean
Koha with only test data)
t/db_dependent/Koha/Items.t
t/db_dependent/Koha/Object.t
t/db_dependent/Koha/Patrons.t
t/db_dependent/Koha/Recalls.t
t/db_dependent/Koha/Recall.t
t/db_dependent/Letters/TemplateToolkit.t (Duplicate entry 'a_t_barcode', could
work with test data)
t/db_dependent/Reserves.t
t/db_dependent/SIP/ILS.t (foreign key constraint, might work with test data)

The ones passing also pass after applying the patches (though there were some
changes in bug 32496 that should have been included here which I have now moved
for transferbook.t to pass).

I haven't used koha-testing-docker before, but could try to run the tests there
and see if I get the same result (for koha-master). Feel free to do the same if
you have the time I don't know how easy it will be to get it up and running. It
could be that the current test suite is pretty broken, even though it seems odd
this has gone under the radar regarding the number of failing tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32394] Long tasks queue is never used

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #22 from Lucas Gass  ---
This doesn't apply cleanly to 22.05.x, if needed please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24608] Allow modification of checkout due date

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Lucas Gass  changed:

   What|Removed |Added

   Keywords|rel_22_05_candidate |
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32080] Public lists not available after recent upgrade

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Lucas Gass  changed:

   What|Removed |Added

   Keywords|rel_22_05_candidate |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31035] Script to update OPACSuppression field depending on hidden items

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #136472|0   |1
is obsolete||

--- Comment #6 from Fridolin Somers  ---
Created attachment 144793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144793&action=edit
Bug 31035: Script to update OPACSuppression field depending on hidden items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #41 from David Nind  ---
Hi David.

Thanks for the updates!

I'll have another go at testing in the next day and let you know how I get on -
I'll run the tests before applying the patch to see if any have "problems".

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32514] New: Local cover images missing at OPAC for user checkouts

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32514

Bug ID: 32514
   Summary: Local cover images missing at OPAC for user checkouts
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Local cover images do not appear in OPAC user checkouts tables.
See koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt.
For example you can see there is the amazon cover with '[% IF (
OPACAmazonCoverImages ) %]'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27265] process_message_queue.pl cron should be able to take multiple types as a parameter

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265

--- Comment #23 from Lucas Gass  ---
Backported to 22.05.x for upcoming 22.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #13 from Fridolin Somers  ---
This needs a test plan.

I can reproduce by editing URL with a unkown itemnumber, ie :
/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=99
(with KTD).

But I think we should test the item existence at the beginning of the page.
And display a message in TT, like in addbiblio.pl :
https://git.koha-community.org/Koha-community/Koha/src/commit/0a934194ca25e2614912f9248f55822aebf38fb8/cataloguing/addbiblio.pl#L771

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32322] Column settings menu should not include "select all |none" in label text for Check In column

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Needs Signoff   |Failed QA

--- Comment #5 from Fridolin Somers  ---
Heuuu this patch simply removes the checkboxes select feature.
It is a regression.

(In reply to Katrin Fischer from comment #3)
> Maybe the select all | none could be moved somewhere else? Or wrapped into a
> classs that is then hidden from the column listing?
Good idea.
Looks like the column name comes from th aria-label attribute, that contains
the text-only version of th content.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #9 from Fridolin Somers  ---
> since "location" doesn't have a phrase index defined...
Why not add it to Zebra MARC21 configuration ?

Even if unlikely :
Imagine two locations "foo bar" and "bar foo", words list type search "wrdl"
will match both.

This indexing can be useful for other cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31216] inventory.pl is slow when comparing many barcodes

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #3 from Fridolin Somers  ---
But, Koha::AuthorisedValues->get_description_by_koha_field already uses
Koha::Cache::Memory::Lite.
Do you have perf differences ?

New code looks complex and is not covered by unit tests.

It is worth it ?

Maybe it can call get_descriptions_by_koha_field().

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31061] OPACSuppress behavior with Elasticsearch

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31061

Fridolin Somers  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |INVALID

--- Comment #9 from Fridolin Somers  ---
> We whould like to have several MARC fields with 'suppress' search field.
We abandonned this idea
Lets keep the actual code ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   Severity|normal  |major

--- Comment #22 from Fridolin Somers  ---
I rise to major because a lot of librarians asked about this regression

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen

2022-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #23 from Fridolin Somers  ---
Looks like second patch is on a bit different and complex issue.
Maybe this report can deal with guarantor name only and create a new bug report
for second patch, with a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/