[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528

--- Comment #4 from Martin Renvoize  ---
Do we care about the order in which these failure messages are returned here?

We effectively reverse their priority here by returning early.  If that matters
we could re-arrange the code blocks and stick achieve the early returns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32377] GetBudgetHierarchy slows down acqui/histsearch.pl

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32377] GetBudgetHierarchy slows down acqui/histsearch.pl

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377

Frédéric Demians  changed:

   What|Removed |Added

 Attachment #144343|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians  ---
Created attachment 144891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144891&action=edit
Bug 32377: Set param skiptotals on call of GetBudgetHierarchy in
acqui/histsearch.pl

Calling GetBudgetHierarchy from acqui/histsearch.pl
is slow if param skiptotals is not used.

To test:
1. Open browsers Console -> Network (F12).
2. Navigate to Order search page and perform search.
=> Take a note how long it takes to load the Search results page.
3. Apply this patch.
4. Repeat step 2.
=> Page should now load faster.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Frédéric Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

--- Comment #14 from Alex Buckley  ---
(In reply to Alex Buckley from comment #13)
> Hi Jonathan and Katrin, 
> 
> Thank you for your responses. 
> 
> Jonathan: I originally removed the 'Clear on loan' link from the batch item
> modification and deletion pages for the reason outlined in the description:
> 
> This patchset makes items on loan display a red cross, rather than a
> disabled checkbox. So giving users the ability to clear on loan items when
> they could not be selected in most cases seemed redundant.
> 
> However, when the 'IndependentBranches' syspref is set to 'No' then on-loan
> items can be displayed with a selectable checkbox in the Batch item
> modification page so I have now re-added the 'Clear on loan' link to both
> batch item tool pages. 
> 
> ---
> 
> Katrin: I've done some testing: The 'Clear on loan' link only appears on the
> batch item modification and deletion pages on master/main (and I have
> re-added it in my patches) - loaded from the html_helpers.inc. 
> 
> It does not appear on the batch record deletion page - as that uses links
> from batch_delete_records.tt (
> https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/
> prog/en/modules/tools/batch_delete_records.tt#L142 ).
> 
> I do notice, however, the 'Clear on loan' link doesn't appear to work on the
> batch item modification page on master/main - so I'll make a new bug report
> for that.
> 
> ---
> 
> I've removed the tab char that QA test tools reported in comment #7, and
> have updated the test plans on both patches now batch item/record tools
> exist in the 'Cataloguing' module.
> 
> Ready for testing again!
> 
> Many thanks,
> Alex

I've created a new bug report for the 'Clear on loan' link not working on the
'Batch item modification' page: bug 32550

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32550

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31611

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10599] Uncheck on loan items on the batch item modification tool

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32550

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10599

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32550] New: 'Clear on loan' link on Batch item modification doesn't untick on loan items

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550

Bug ID: 32550
   Summary: 'Clear on loan' link on Batch item modification
doesn't untick on loan items
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Steps to replicate:

1. Enter a checked-out barcode in the 'Batch item modification' page 
2. Click 'Continue'
3. Notice a table is loaded displaying the on-loan item with a ticked checkbox
4. Click the 'Clear on loan' link above the table
5. Notice the on-loan item still has a ticked checkbox

Notes:
The 'Clear on loan' link was added in bug 10599

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #13 from Alex Buckley  ---
Hi Jonathan and Katrin, 

Thank you for your responses. 

Jonathan: I originally removed the 'Clear on loan' link from the batch item
modification and deletion pages for the reason outlined in the description:

This patchset makes items on loan display a red cross, rather than a disabled
checkbox. So giving users the ability to clear on loan items when they could
not be selected in most cases seemed redundant.

However, when the 'IndependentBranches' syspref is set to 'No' then on-loan
items can be displayed with a selectable checkbox in the Batch item
modification page so I have now re-added the 'Clear on loan' link to both batch
item tool pages. 

---

Katrin: I've done some testing: The 'Clear on loan' link only appears on the
batch item modification and deletion pages on master/main (and I have re-added
it in my patches) - loaded from the html_helpers.inc. 

It does not appear on the batch record deletion page - as that uses links from
batch_delete_records.tt (
https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt#L142
).

I do notice, however, the 'Clear on loan' link doesn't appear to work on the
batch item modification page on master/main - so I'll make a new bug report for
that.

---

I've removed the tab char that QA test tools reported in comment #7, and have
updated the test plans on both patches now batch item/record tools exist in the
'Cataloguing' module.

Ready for testing again!

Many thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

--- Comment #12 from Alex Buckley  ---
Created attachment 144890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144890&action=edit
Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record
deletion tool

Test plan:
1. Apply patch
2. Check out an item
3. Go to: 'Cataloguing' > 'Batch record deletion'
4. Into the 'Enter a list of record numbers' area paste in the
biblionumber belonging to the checked-out item and that of a biblio without
checked out items
5. Submit the form
6. Observe the row of the biblio with checked-out items is highlighted yellow,
with a
red cross in the first column
7. Hover over the red cross to see the reason why the biblio cannot be
deleted
8. Observe the row of the biblio without checked-out items is not
highlighted yellow, and does have a checkbox in the first column
9. Click 'Delete selected records'
10. Confirm the biblio without checked-out items is successfully deleted

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

Alex Buckley  changed:

   What|Removed |Added

 Attachment #144889|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

--- Comment #11 from Alex Buckley  ---
Created attachment 144889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144889&action=edit
Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record
deletion tool

Test plan:
1. Apply patch
2. Check out an item
3. Go to: Tools > 'Batch record deletion'
4. Into the 'Enter a list of record numbers' area paste in the
biblionumber belonging to the checked-out item and that of a biblio without
checked out items
5. Submit the form
6. Observe the row of the biblio with checked-out items is highlighted yellow,
with a
red cross in the first column
7. Hover over the red cross to see the reason why the biblio cannot be
deleted
8. Observe the row of the biblio without checked-out items is not
highlighted yellow, and does have a checkbox in the first column
9. Click 'Delete selected records'
10. Confirm the biblio without checked-out items is successfully deleted

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

--- Comment #10 from Alex Buckley  ---
Created attachment 144888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144888&action=edit
Bug 31611: Clearly highlight items that cannot be modified/deleted in the Batch
item tools

Test plan:
1. Apply patches
2. Check out an item with a different home branch than the library
you're logged in as
3. Go to: 'Cataloguing' > 'Batch item deletion'
4. Into the barcode list area paste the checked-out item's barcode and the
barcode of a non-checked out item (with the same home library as the branch
you're logged in as) and submit the form
5. Observe in the table that loads the row containing the checked out item is
highlighted
yellow, and it has a red cross in the first column.
6. Hover over the red cross to see the reason why you cannot delete the
item appears
7. Observe the non checked out item has a checkbox and is not
highlighted yellow
8. Click 'Select all' and 'Clear all' links and notice the display of
the checked out item remains unchanged

9. Change 'IndependentBranches' syspref = 'yes'
10. Log into the staff client as a patron with only the '(catalogue)',
'(editcatalogue)', and '(tools)'
permissions selected
11. Go to: 'Cataloguing' > 'Batch item modification'
12. Enter the checked-out item's barcode and a non-checked out item's
barcode and submit the form
13. Observe the table row for the checked out item is again highlighted
yellow, with a red cross.
14. Hover over the red cross and observe the text 'Cannot edit' is shown
15. Observe the non-checked out item is not highlighted yellow and does
have a checkbox

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

Alex Buckley  changed:

   What|Removed |Added

 Attachment #140879|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

Alex Buckley  changed:

   What|Removed |Added

 Attachment #140878|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32542] Coce images not appearing in staff client

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32460] Columns missing from table configuration for patron categories

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32460

Laura  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||Laura.escamilla@bywatersolu
   ||tions.com

--- Comment #3 from Laura  ---
The columns below are all now visible and working appropriately in the Patron
Categories table:
*password expiration - (I think this is what you meant instead of patron
expiration)
*can be guarantee
*exclude from local holds priority

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32469] Keyboard shortcuts no longer work in details.pl

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32469

Lucas Gass  changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32469] Keyboard shortcuts no longer work in details.pl

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32469

--- Comment #2 from Lucas Gass  ---
I'm not entirely convinced this functionality should be brought back. The
standard use of the arrow keys is scroll horizontally or vertically in the
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32469] Keyboard shortcuts no longer work in details.pl

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32469

Lucas Gass  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32469] Keyboard shortcuts no longer work in details.pl

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32469

Lucas Gass  changed:

   What|Removed |Added

Version|22.05   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32549] New: Add CSS classes to biblio and auth MARC preview

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32549

Bug ID: 32549
   Summary: Add CSS classes to biblio and auth MARC preview
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pablo.bian...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

On the staff client, when visiting a biblio on detail.pl or an auth on a
Authority search results authorities-home.pl (on some other places too) we can
see a very plain MARC preview. Inside #marcPreview there is a table with a very
basic formatting and no class to let the user (or Koha devs on
staff-global.scss) improve the view through CSS.

Would be useful a set of classes on each section of the MARC (biblio and auth)
records. For example: leader-tag leader-value field-control-tag
field-control-value field-data-tag field-data-value indicators ind1 ind2
subfield-char subfield-code subfield-value.

subfield-char would be particularly useful to change easier the yazy _ to a
traditional $ or ‡.

For biblios would be also neat for e.g.: leader-00-04 leader-05 leader-06
leader-07 leader-08 leader-09 leader-10 leader-11 leader-12-16 leader-17
leader-18 leader-19 leader-20 leader-21 leader-22 field-008-07-10
field-008-11-14 field-008-15-17 field-008-18-34 field-008-35-37 field-008-38
field-008-39.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32542] Coce images not appearing in staff client

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542

--- Comment #1 from Lucas Gass  ---
It seems like what is happening here is that we are removing the containers
prematurely. 

coce.js fetches the images and adds them but not before other JS in results.js
is deciding there is no image and removing the container.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser's tooltip on paging

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635

Pablo AB  changed:

   What|Removed |Added

 CC||pablo.bian...@gmail.com

--- Comment #6 from Pablo AB  ---
Will be backported to 22.05?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32538] Biblionumber problem

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32538

--- Comment #3 from Katrin Fischer  ---
I would not recommend an older version, but I'd recommend signing up to the
mailing list as it's the best way to get free support. :) Joining the IRC chat
via Element or your favourite IRC client could also be an option.

Your report doesn't have all that much information, maybe we can get to the
issue with some more questions:

* Did you update or do a fresh installation?
* How were the items added? (imported or added in Koha?)
* I think by items, you mean records, right?
* Are you using Zebra or Elasticsearch?
* MARC21 or UNIMARC?

Some ideas:
* Have you tried reindexing? Usually if you see an entry in the results list,
but not the detail page, it might have been deleted and the index not updated.
* Another idea: maybe in one of your frameworks the biblionumber is set to not
be visible. Please make sure all the 999 fields are set to be visible in the
bibliographic frameworks.

If it's a configuration issue like the biblionumber one, the error would also
probably occur in older versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32538] Biblionumber problem

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32538

--- Comment #2 from Big Ben  ---
Well, I didn't click because there's no useful link on the page to fix the
problem. Do you think it would be a good idea to install an older version like
the 21.05 or the 21.11 ? I'm not on the mailing list, could you ask the
question for me ?

Thank you,
RB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30031] Add lists to table settings

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031

Lucas Gass  changed:

   What|Removed |Added

 Attachment #132049|0   |1
is obsolete||
 Attachment #132050|0   |1
is obsolete||
 Attachment #132051|0   |1
is obsolete||

--- Comment #12 from Lucas Gass  ---
Created attachment 144887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144887&action=edit
Bug 30031: Add column settings to list view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27973] Limit to currently available items should have an option to filter out notforloan statuses

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC results

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32548] New: Make illrequestattributes easily available to ILL notices

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548

Bug ID: 32548
   Summary: Make illrequestattributes easily available to ILL
notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de

Often the most interesting information about the title, like article_title is
only available in illrequestattributes. It would be super nice if we had these
available with a nice syntax in the ILL notices.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32547] Koha::Item->as_marc_field ignores more_subfields_xml

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32547

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Tomás Cohen Arazi  ---
I'm going to close this. It seems that the problem is the frameworks contained
'' for kohafield instead of NULL, and the code checks 

if ( defined $kohafield )

Will double check on the different branches how this looks. But closing for
now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32547] Koha::Item->as_marc_field ignores more_subfields_xml

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32547

--- Comment #2 from Tomás Cohen Arazi  ---
I confirm this problem is only present in 21.11.

Steps to reproduce:

0. Launch a 21.11 KTD:
   # stop any running KTD
   $ ktd down
   $ git checkout origin/21.11.x -b bug_32547
   $ KOHA_IMAGE=21.11 ktd up -d

1. Edit the default framework field 952, add a 'R' subfield for items. Make
sure you set:

tab: 10
visibility: opac, staff, editor

2. Pick a biblio and make sure it uses the default framework. I searched for
'att' and picked  "Introduction to Attic Greek / Donald J. Mastronarde." from
the sample dataset.
3. Add an item, set the 'R' subfield to some value.
4. Run:
   $ kshell
  k$ perl -MKoha::Items -MData::Printer -e 'my $item = Koha::Items->find(973);
p($item->as_marc_field->as_formatted);'
=> FAIL: the output doesn't show subfield R.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32547] Koha::Item->as_marc_field ignores more_subfields_xml

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32547

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |21.11
 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi  ---
I think the bug references are wrong, as I cannot reproduce in master. But this
bug is present in 21.11 and wasn't on 20.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32547] New: Koha::Item->as_marc_field ignores more_subfields_xml

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32547

Bug ID: 32547
   Summary: Koha::Item->as_marc_field ignores more_subfields_xml
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The method, as introduced on bug 23807, handled the extra subfields correctly.

Probably due to the changes introduced by bug 28445, it now doesn't. This is
really bad.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32546] New: Move ILL system preferences to their own tab in administration

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546

Bug ID: 32546
   Summary: Move ILL system preferences to their own tab in
administration
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de

At the moment the ILL related system preference appear on the Circulation tab,
which is already very long. As ILL is a module, it should have its own tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503

--- Comment #5 from Martin Renvoize  ---
My Google foo is weak today.. where did you find the suggestion to use
`data-type="@data-sort"` Katrin?

I think I spotted the issue with most of the sorting and have removed the
data-type definition stuff.. but the cancellation date is more challenging.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503

--- Comment #4 from Martin Renvoize  ---
Created attachment 144886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144886&action=edit
Bug 32503: (follow-up) Move data-order attributes

It looks like the data-order attributes were at the wrong level to me,
i.e. not part of the 'td' but instead part of the cell content.

This patch moves those data-order attributes where possible and drops
the data-type definitions on the headers.

However, for the cancellation case, this isn't as clear cut as we may
well display more than one cancellation request date in the same cell.
For this case I've left Katrins data-type="@data-order" trick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #144884|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 144885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144885&action=edit
Bug 32503: Fix date sorting for holds awaiting pickup tables

This patch is a little experimental, but seems to do the trick.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32456] Date accessioned is now cleared when items are replaced

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32456

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31231] Link authorities automatically does not always work

2022-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231

pierre.ge...@biblibre.com changed:

   What|Removed |Added

 CC||pierre.ge...@biblibre.com

--- Comment #4 from pierre.ge...@biblibre.com ---
Hi, 
I had a similar experience in unimarc with author fields (700) : if the
authority only have a surname (heading 700$a), not a first name (700$b), it is
find by "Link authorities automatically" function. 
However, if searching for firstname + surname the "Link authorities
automatically" function will not find the existing authority and a duplicate
authority is created.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/