[Koha-bugs] [Bug 32026] 'Search within results' and its input field in staff search results page are misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32026 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #10 from David Cook --- Yikes, where are we at with this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30846] Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #1 from Katrin Fischer --- Created attachment 144924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144924&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Bug 31947 depends on bug 32001, which changed state. Bug 32001 Summary: Make submit button yellow when adding a new matching rule https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32001 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32001] Make submit button yellow when adding a new matching rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32001 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This button is also very yellow now :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Bug 31947 depends on bug 32000, which changed state. Bug 32000 Summary: Add yellow buttons to administration > upload page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32000 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32000] Add yellow buttons to administration > upload page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32000 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- I think I probably meant Tools > Uploads and there are yellow buttons there now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32499] HOLDPLACED email goes to patron branch rather than item branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499 David Cook changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #8 from David Cook --- (In reply to Katrin Fischer from comment #7) > But if you have 10 libraries owning the same item, which can well happen > with popular ones, you will have 10 librarians potentially running to the > shelf to get it... doesn't seem very effective. > > I was assuming the worst case: record level hold with multiple branches > holding it. Ahhh yes that would explain it. I forgot that not all holds are item-level holds. Since a hold could be either record-level or item-level, I don't think there's a consistent way of handling the email except emailing the patron's branch. Maybe the pickup library like you suggested before, but the current behaviour has been around for many years, and I think you've explained well why that's the case here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267
--- Comment #34 from David Cook ---
(In reply to Matthew Ross from comment #33)
> I'm receiving the followin error, even after manually changing the
> "borrowers" table to dynamic:
>
> ---
> Upgrade to 22.06.00.006 [09:37:59]: Bug 21978 - Add middle_name to borrowers
> table
> ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Row size too
> large. The maximum row size for the used table type, not counting BLOBs, is
> 8126. This includes storage overhead, check the manual. You have to change
> some columns to TEXT or BLOBs at /usr/share/koha/lib/C4/Installer.pm line 739
> ---
Looking at bug 21978, it looks like you'll need to change the
borrower_modifications and deletedborrowers tables too.
Alternatively, you could follow the steps that Liz Rea outlines at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267#c20 to update
all tables. That would be a more future-proofed solution.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30846] Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #1 from Caroline Cyr La Rose --- I'm not sure if this is what you meant Nick, but I came across this situation and thought it was maybe the same. Let me know if it's completely different and I'll create a new bug for this. I'm trying to set up Koha so that only unavailable items can be put on hold, including those with negative not for loan values. (The exact use case is a library that wants to prevent on shelf holds, but want people to be able to put on hold the most recent issue of a serial even if it is for reference only while the other issue hasn't yet arrived. When the next issue arrives, the previous issue will be lent out, in order of the holds... Not sure if that makes sense, but it's the same principle as placing holds on "ordered" items.) I was not able to test this on master because of bug 32445, but I tried it on 22.05.05 To test: 1. Set up a circulation rule where on shelf holds are not allowed and force the choosing of an item (to facilitate the test) 1.1. Go to Administration > Circulation and fines rules 1.2. In the matrix, add a circulation like this - Patron category: All - Item type: Books - Current checkouts allowed: 10 - Current on-site checkouts allowed: 10 - Loan period: 21 - Holds allowed (total): 10 - Holds allowed (daily): 10 - Holds per record (count): 10 - On shelf holds allowed: If any unavailable - OPAC item level holds: Force 1.3. Click Save 2. Create a record with one "Ordered" item (or any negative value not for loan status) 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (by default in MARC21: 000, 003, 005, 008, 040$c, 245$a, and 942$c (942$c should be set to Books)) 2.4. Click Save 2.5. Fill out the following item fields - Not for loan: Ordered - Koha item type: Books 2.6. Click Add item 2.7. Click Normal to go to the detailed record 3. Try to place a hold on the "Ordered" item 3.1. From the detailed record, click OPAC view: Open in new window. --> Note that the "Place hold" option is not present 4. Add a second "Available" item 4.1. Back in the staff interface tab with the detailed record, click New > New item 4.2. Make sure the item type is set to Books 4.3. Add a barcode in p 4.4. Click Add item 5. Try again to place a hold on the "Ordered" item 5.1. Go back to the OPAC tab and refresh the page --> Note that the "Place hold" option is still not present 6. Check out the available item to a patron 6.1. In the staff interface tab, copy the barcode from the available item 6.2. Go to Patrons 6.3. Click on Search 6.4. Click Check out next to one of the patrons 6.5. Paste the barcode in the box and click Check out 7. Try again to place a hold on the "Ordered" item 7.1. Go back to the OPAC tab and refresh the page --> Note that the "Place hold" option is now present 7.2. Click Place hold --> Note that only the checked out item is available to place on hold, if you click Show unholdable items, it will show the Ordered item, but you can't place a hold on it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29911] Default amounts for fee types display with comma in some cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29911 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- It appears this was meanwhile fixed on another bug :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28703] Display problem in 505$a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 --- Comment #10 from Katrin Fischer --- (In reply to Fridolin Somers from comment #9) > Duplicate of Bug 29604? No, totally different thing. This is about showing an extra --> that has no content after. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Tomás Cohen Arazi changed: What|Removed |Added Component|MARC Authority data support |REST API CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Tomás Cohen Arazi changed: What|Removed |Added Component|MARC Authority data support |REST API CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit | |y.org | Component|MARC Authority data support |REST API CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31793] REST API: DELETE endpoint for Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit | |y.org | CC||tomasco...@gmail.com Component|MARC Authority data support |REST API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32554] Test prediction pattern does not consider subscription length (uses only subscription end date)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 Caroline Cyr La Rose changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32555] New: Error when viewing serial in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32555 Bug ID: 32555 Summary: Error when viewing serial in OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org I'm getting a 500 error when trying to view a serial with issues in the OPAC. The message is very long, but it starts with Template process failed: undef error - The method Koha::Serial::Item->serialseq is not covered by tests! To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number (I used 108) - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. --> It should open normally in another tab/window and the record displays without problem 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. Click Save 4. Go back to the OPAC tab and refresh --> Error I put this bug as "major", but maybe it should be higher... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32554] Test prediction pattern does not consider subscription length (uses only subscription end date)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 --- Comment #1 from Caroline Cyr La Rose --- I tried this in 22.05.05 and it works fine with only a subscription length (without a subscription end date). So it's something that was changed recently. I haven't tried on a 22.11 though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32554] New: Test prediction pattern does not consider subscription length (uses only subscription end date)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 Bug ID: 32554 Summary: Test prediction pattern does not consider subscription length (uses only subscription end date) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When creating a new serial subscription, it used to be that we could enter either a subscription length (number of issues, months or weeks) OR a subscription end date. When we would test the prediction pattern, it would show the right number of issues based on one of these values. Now it seems that if we only enter a number of issues for the subscription length and test the prediction pattern, not only does it tell us we're not being consistent with our end date (I thought it was optional?) but it also doesn't show the correct number of issues. To test: 1. For this, I created my own record, but you can skip this step and use any existing record 1.1. Go to Cataloging 1.2. Click on New record 1.3. Fill out the manadatory fields (in MARC21, typically 000, 003, 005, 008, 040$c, 245$a and 942$c) 1.4. Click Save 1.5. Note the record number, do not create an item 2. Create a serial subscription 2.1. Go to Serials 2.2. Click on New subscription 2.3. Enter the record number 2.4. Click Next (and confirm you're not using a vendor) 2.5. Fill out the second form as follows - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 24 - Subscription start date: 2023-01-01 - Subscription end date: leave empty - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 2.6. Click on Test prediction pattern --> Note there is a message saying "End date is not consistent with subscription length." even if, normally, only one is needed --> Only the issues until today are displayed (in my case, only the January 2023 issue), even if we said our subscription was for 24 issues There is no problem if we enter a subscription end date. This means either the subscription length problem is a bug, or end date is now mandatory and should be displayed in red like other mandatory fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Keywords||rel_22_11_candidate Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr |ity.org | --- Comment #4 from Jonathan Druart --- Oops, silly mistake! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 Jonathan Druart changed: What|Removed |Added Attachment #144872|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 144923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144923&action=edit Bug 32531: Restore behaviour of 'include archived' filter In Suggestions management, there is a sidebar menu to organize and filter suggestions. In the "Suggestion information" filter section, there is a checkbox "Include archived". When this box us unchecked, the archived suggestions are not displayed. When this box is checked, all suggestions are displayed, archived, and not archived. This is not the case anymore, only archived suggestions are displayed, supposedly since patch for bug 23991. TO TEST: 1. On a Koha installation remove all suggestions (in the table). 2. Create two suggestions. Archive one of them. 3. Check/Uncheck filter 'Include Archived'. Confirm that when the box is checked, you don't see anymore the unarchived suggestion. 4. Apply the patch. 5. Repeat 3, and confirm that the filter operates properly. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #114 from Jonathan Druart --- 1. FAIL Koha/Patron/Restriction.pm FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Patron/Restriction.pm FAIL Koha/Patron/Restrictions.pm FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Patron/Restrictions.pm 2. Koha/Patron/Restriction.pm:=head2 Relation accessors Why? This is not used anywhere else. We use "Class methods". 3. 64[% PROCESS restriction_type_description %] I think it's always better to pass the parameter, even if not needed => [% PROCESS restriction_type_description restriction_type => restriction_type %] Nothing considering blocker, passing QA. Please go ahead with bug 31458 and friends, I will be happy to QA them! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC||jonathan.druart+koha@gmail. ||com Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 --- Comment #5 from Jonathan Druart --- Created attachment 144922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144922&action=edit Bug 32505: Restore patron search by formatted dob Prior to the rewrite of the patron searches (bug 30063 and friends) it was possible to search for a patron using their date of birth, formatted following the dateformat syspref. Now it only works if the date is iso formatted. This patch is providing a fix to restore the behaviour, but does not make it consistent. Only searching patrons by date of birth is fixed here, when we actually want to fix the problem for the REST API DT wrapper instead. Test plan: Search for patrons given their date of birth. You need to select "date of birth" in the "Search field" dropdown, or set it in DefaultPatronSearchFields. Note that the column filtering is still not working, but I guess it was the case already in older versions. Ideally we will need to have a "datatype" attribute passed to the the 'th' and retrieved from datatables.js to add this same trick and build the query appropriately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 --- Comment #16 from Jonathan Druart --- Original problem found with the following warning: Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line 5719. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 --- Comment #15 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #14) > Might be something else ? I think so, it's passing for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #113 from Jonathan Druart --- Created attachment 144921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144921&action=edit Bug 31095: (follow-up) Iterate debarments in batch mod Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #112 from Jonathan Druart --- Created attachment 144920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144920&action=edit Bug 31095: (QA follow-up) Fix after rebase Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #111 from Jonathan Druart --- Created attachment 144919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144919&action=edit Bug 31095: Remove GetDebarments from Koha::Patron::Debarments This patch finally removes GetDebarments from the codebase. Test plan 1. Confirm GetDebarments is no longer mentioned in the codebase. `git grep GetDebarments` 2. Confirm t/db_dependent/Patron/Borrower_Debarments.t continues to pass Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #110 from Jonathan Druart --- Created attachment 144918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144918&action=edit Bug 31095: Remove GetDebarments from Borrower_Debarments.t This patch replaces calls to GetDebarments with teh $patron->restritions->search() equivilents. Test plan 1. Run the test prior to the patch and confirm it passes 2. Run the test after the patch and confirm it passes 3. Confirm no tests were removed Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #109 from Jonathan Druart --- Created attachment 144917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144917&action=edit Bug 31095: Remove GetDebarments from Restriction/Type.t This patch replaces GetDebarments with $patron->restrictions in t/db_dependent/Koha/Patron/Restriction/Type.t Test plan 1. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes prior to the patch 2. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes after the patch 3. Confirm no tests were removed Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #108 from Jonathan Druart --- Created attachment 144916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144916&action=edit Bug 31095: Remove GetDebarments from MarkIssueReturned.t This patch removes GetDebarments from Ciculation/MarkIssueReturned.t Test plan 1. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes prior to the patch 2. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes after the patch 3. Confirm no tests have been removed Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #107 from Jonathan Druart --- Created attachment 144915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144915&action=edit Bug 31095: Remove GetDebarments from maxsuspensiondays.t This patch replaces GetDebarments in maxsuspensiondays.t with calls to the restrictions accessor. Test plan 1. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes prior to this patch 2. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes after this patch 3. Confirm no tests have been removed in this patch Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #106 from Jonathan Druart --- Created attachment 144914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144914&action=edit Bug 31095: Remove GetDebarments from Patron::Import This patch replaced GetDebarments with $patron->restrictions->search in Koha::Patron::Import. Test plan 1. Confirm that importing patrons with debarred and debarredcomment fields in the import still works as expected Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #105 from Jonathan Druart --- Created attachment 144913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144913&action=edit Bug 31095: Remove GetDebarments from Circulation.t Replace GetDebarments with $patron->restrictions. Test plan 1. Run test prior to patch - all should pass 2. Run test after patch - all should pass 3. Confirm no tests were removed as part of the patch Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #104 from Jonathan Druart --- Created attachment 144912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144912&action=edit Bug 31095: Remove GetDebarments from Circulation.pm This patch removes GetDebarments from Circulation.pm replacing them with calls to $patron->restrictions and filtering using a chained search call. Test plan 1. Confirm that t/db_dependant/Circulation.t continues to pass Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #103 from Jonathan Druart --- Created attachment 144911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144911&action=edit Bug 31095: Remove GetDebarments from tools/modborrowers.pl This patch removes GetDebarments from the modborrowers tool controller and replaces it with $patron->restrictions as appropriate. Test plan 1. Confirm that the 'Batch patron modification' tool pages still load and perform as expected. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #102 from Jonathan Druart --- Created attachment 144910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144910&action=edit Bug 31095: Remove keyed_on_code We no longer require keyed_on_code from Koha::Patron::Restrictoin::Types as we have relation accessors for the relevent use cases and no longer reference the method anywhere in the codebase! Test plan 1. Confirm 'keyed_on_code' is no longer referenced anywhere in the codebase. `git grep keyed_on_code` Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #101 from Jonathan Druart --- Created attachment 144909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144909&action=edit Bug 31095: Remove borrower_debarments and patron_restrictions includes This patch removes the aforementioned includes and drops the last remaining reference to them. We have replaces these includes with patron-restrictions-tab.inc and restriction-types.inc. Test plan 1. Confirm the includes are no longer referenced anywhere in the codebase. 'git grep borrower_debarments.inc', 'git grep patron_restrictions.inc' Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #100 from Jonathan Druart --- Created attachment 144908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144908&action=edit Bug 31095: Remove GetDebarments from members/memberentry.pl This patch removes the use of GetDebarments from members/memberentry.pl and replaces the references in the templates with patron.restrictions. Test plan 1. Add a new user and confirm that the patron restrictions section does not appear on the form 2. Edit the user and confirm the patron restrictions section now appears 3. Add a manual restriction using the patron edit form 4. Confirm the restriction appears on the patron edit form 5. Confirm you can remove the restriction usine the patron edit form Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #99 from Jonathan Druart --- Created attachment 144907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144907&action=edit Bug 31095: Remove GetDebarments from members/moremember.pl This patch removes the use of GetDebarments from members/moremember.pl and replaces template references with patrons.restrictions and the new includes introduced in the prior patch Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the patron details page. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #98 from Jonathan Druart --- Created attachment 144906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144906&action=edit Bug 31095: Remove GetDebarments from circ/circulation.pl This patch remove the use of GetDebarments from circ/circulation.pl, replacing it with a reference to patron.restrictions in the template and includes. Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the checkout page for a user. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #97 from Jonathan Druart --- Created attachment 144905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144905&action=edit Bug 31095: Add type relation accessor to Koha::Patron::Restriction Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #96 from Jonathan Druart --- Created attachment 144904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144904&action=edit Bug 31095: Add restrictions accessor to Koha::Patron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Jonathan Druart changed: What|Removed |Added Attachment #143745|0 |1 is obsolete|| Attachment #143746|0 |1 is obsolete|| Attachment #143747|0 |1 is obsolete|| Attachment #143748|0 |1 is obsolete|| Attachment #143749|0 |1 is obsolete|| Attachment #143750|0 |1 is obsolete|| Attachment #143751|0 |1 is obsolete|| Attachment #143752|0 |1 is obsolete|| Attachment #143753|0 |1 is obsolete|| Attachment #143754|0 |1 is obsolete|| Attachment #143755|0 |1 is obsolete|| Attachment #143756|0 |1 is obsolete|| Attachment #143757|0 |1 is obsolete|| Attachment #143758|0 |1 is obsolete|| Attachment #143759|0 |1 is obsolete|| Attachment #143760|0 |1 is obsolete|| Attachment #143761|0 |1 is obsolete|| Attachment #143762|0 |1 is obsolete|| Attachment #143763|0 |1 is obsolete|| --- Comment #95 from Jonathan Druart --- Created attachment 144903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144903&action=edit Bug 31095: Add Koha::Patron::Restriction(s) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #1 from Agustín Moyano --- Created attachment 144902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144902&action=edit Bug 31799: Add REST endpoint to modify a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio with an item 4. Make a PUT request to /api/v1/biblios/:biblio_id/items/:item_id with a json body that represents an item to replace 5. Check that the item was modified 6. Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano changed: What|Removed |Added Blocks||31799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 [Bug 31799] REST API: PUT endpoint for Items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Agustín Moyano changed: What|Removed |Added Depends on||31798 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 [Bug 31798] REST API: POST endpoint for Items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 --- Comment #7 from Jonathan Druart --- This patch seems to simplify and make the method more readable, but I guess it's a matter of taste. Feel free to obsolete it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 --- Comment #6 from Jonathan Druart --- Created attachment 144901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144901&action=edit Bug 32528: Change return logic Back to 1 return statement Prevent the Koha::Result::Boolean instanciation duplication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30819] Not able to adjust size of barcode numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30819 --- Comment #1 from Thibaud Guillot --- Hello all, I'm interested in your advice on this because like this comment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762#c3 (related to the original bug) it may - may need to change the way barcodes are generated for this improvement. What do you think about it ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30819] Not able to adjust size of barcode numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30819 Thibaud Guillot changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |thibaud.guil...@biblibre.co |u |m CC||thibaud.guil...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |thibaud.guil...@biblibre.co |u |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Thibaud Guillot changed:
What|Removed |Added
CC||thibaud.guil...@biblibre.co
||m
--- Comment #16 from Thibaud Guillot ---
(In reply to Katrin Fischer from comment #13)
> 1) QA test tools:
>
> FAIL installer/data/mysql/atomicupdate/update-BZ_10762.pl
>FAIL file permissions
> File must have the exec flag
>
> 2) See comment#11, it looks like the original value was 0.01:
>
> +scale_height=> 0.02,
>
> -my $barcode_y_scale_factor = 0.01 * $self->{'height'}; #
> this scales the barcode height to 10% of the label height
>
> 3) Defaults
>
> Just a question, maybe someone else can answer that one too:
>
> The patch adds the 2 new database columns with defaults 0.02 and 0.8 in the
> database and also sets the defaults in new.
>
> Should we do both or would one option suffice?
>
> 4) Changes to kohastructure.sql are missing
Hello Katrin,
Normally I fixed this things on my last 'push'
For default value (repeat in sql and view on 'sub new()' I'm not an expert but
it like the same than 'layout_name' for example (set to 'DEFAULT' in default
sql value and also in the template when we passed vars).
I hope this will be okay for everyone :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #15 from Thibaud Guillot --- Created attachment 144900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144900&action=edit Bug 10762: (follow-up) Update test plan, add kohastructure.sql files I also change the default value for scale_height to '0.01' Test plan: 1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Thibaud Guillot --- Anyone get the same error than David ? So I tested right now and it's working for me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jan Kissig changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Jonathan Druart --- I am getting a conflict, can you rebase please? Also, could you run the tidy script, I am seeing invalid changes: -licenses: [], +licenses: [], (space at the end of the line) Make sure you set up the pre-commit git hook https://wiki.koha-community.org/wiki/Tips_and_tricks#Hooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
