[Koha-bugs] [Bug 10198] Add the ability to import and export authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198 Anne-Cécile Bories changed: What|Removed |Added CC||anne-cecile.bor...@iepg.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #44 from David Cook --- I've added a lot more tests, streamlined the code more, and resolved an issue with the authorization process. I could probably add a couple more end-to-end tests but I've run out of time today and I'm away the next 5 days. Moving this back to "Needs Signoff" to get eyes on it in the meantime... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #140675|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #140674|0 |1 is obsolete|| --- Comment #43 from David Cook --- Created attachment 144970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144970&action=edit Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller This change checks for a "use_mojolicious" method in the plugin in order to determine whether it should use a Mojolicious controller or a CGI script controller. Note that the check is for the existence of the method, so it is backwards compatible with all existing Koha Plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #140673|0 |1 is obsolete|| --- Comment #42 from David Cook --- Created attachment 144969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144969&action=edit Bug 31380: Allow Koha Plugins to run using Mojolicious controllers This patch adds a new mount point in plack.psgi, which makes Koha able to run Mojolicious controllers. For example: http://localhost:8081/cgi-bin/koha/staff/plugins/run 0a) Apply patch 0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi 0c) koha-plack --restart kohadev 1) Upload Koha Plugin koha-plugin-mojolicious.kpz 2) koha-plack --restart kohadev 3) Go to http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl 4) Next to "Mojolicious Test", click "Actions", then click "Run tool" 5) Note that the web page looks perfect 6) Note that the URL is a bit different to normal: http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious&method=tool instead of: http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious&method=tool Note: The test Koha plugin will only work with a Mojolicious controller, but it could be easily made to work with both 7) Run the above test using an unauthenticated user, use a staff user without plugin permissions, try with a staff user with plugin permissions, and try with a superlibrarian 8) Run tests prove t/db_dependent/Koha/Auth.t prove t/db_dependent/Koha/Mojo/Plugins/Core.t prove t/db_dependent/Koha/Template.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #139313|0 |1 is obsolete|| --- Comment #41 from David Cook --- Created attachment 144968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144968&action=edit Koha Plugin with Mojolicious controller Updating attached plugin to use updated staff interface templates and to use some code updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #40 from David Cook --- (In reply to Tomás Cohen Arazi from comment #38) > I think we need some more tests here, particularly for the 'staff_authorize' > and 'prepare_template', unless I'm missing something. I noticed at first > glance a subtle issue with __koha__user__ vs. __koha_user__ that is not > caught by the provided tests. Good catch with __koha__user__. I hadn't used that return value anywhere yet. Following my unit tests on Bug 30962 and looking at t/Koha/REST/Plugin/Query.t, I think I now know how to write the tests you're talking about. I'll give it a go. > It would be great (also) if you could perltidy some of this code. I usually > select the code I want to tidy, and just ctrl+k ctrl+f on VScode. Please do > it inline. Thanks! I think there's a problem with the perltidy vim macro in KTD but otherwise I'm open to it... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 --- Comment #1 from Alex Buckley --- Created attachment 144967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144967&action=edit Bug 32560: Cronjob to mark expired borrowers as lost their card Test plan: 1. Edit a borrower to have an expiration date in the past - also make sure they have 'Lost card' set to 'No' 2. Run the set_expired_lost.pl script: sudo koha-shell cd misc/cronjobs ./set_expired_lost.pl 3. Notice you get output saying the number of borrowers are to be changed 4. View the borrower account from #1 and notice they have a 'Lost card' value of 'Yes' 5. Run the set_expired_lost.pl script again and observe no output is printed to the terminal - this is because all expired borrowers have already been marked as lost. Sponsored-by: Dalton McCaughey Library, Australia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 David Nind changed: What|Removed |Added Attachment #144962|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 144966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144966&action=edit Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 5. The search results table should be listed, with the ability to hide the author, date_added, or call_number 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) 8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now. Note: I have also added the page-section class to this table. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #22 from David Cook --- (In reply to Jonathan Druart from comment #11) > 1. Missing tests (you must provide tons of tests to cover the different > situations) > 2. Route's name should not be a verb (/password/validation maybe?) > 3. Routes that returns empty should return 204 > 4. It's always returning "Invalid password" even for other failures (like > too many attempts) > 5. It allows you to check for pwd validation for a user you don't know their > userid (you can force brute only by knowing the patron's id). I don't think > it's a security concern as userid could be guessed anyway (?) > 6. following 5, you can lock any accounts if FailedLoginAttempts is set, no > need to know the userid list. How bad is that? I think that I've addressed all these points now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #21 from David Cook --- Created attachment 144965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144965&action=edit Bug 30962: Add unit tests for /auth/password/validation endpoint Test plan: 0. Apply patch 1. prove -v t/db_dependent/api/v1/password_validation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962
David Cook changed:
What|Removed |Added
Attachment #144810|0 |1
is obsolete||
--- Comment #20 from David Cook ---
Created attachment 144964
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144964&action=edit
Bug 30962: REST API: Add endpoint /auth/password/validation
This patch adds an endpoint for /auth/password/validation
This allows a third-party, using an authenticated and authorized Koha
API user, to check if the username and password given by a user is
correct in Koha.
For example, a Keycloak extension can be created using its
User Storage SPI to use Koha as the user database for Keycloak. This
API allows us to authenticate the user as a particular Koha user - without
creating a Koha user session for them.
Test plan:
0. Apply patch and koha-plack --restart kohadev
1. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RESTBasicAuth
2. Enable "RESTBasicAuth"
3. Run the following commands while substituting correct values for
and
3. curl -XPOST -H "Content-Type: application/json" -u
:
http://localhost:8081/api/v1/auth/password/validation -d '{ "username":
", "password": "" }' -v
4. Note "204 No Content" response
5. curl -XPOST -H "Content-Type: application/json" -u
:
http://localhost:8081/api/v1/auth/password/validation -d '{ "username":
", "password": "this is definitely not the password" }' -v
6. Note "400 Bad Request" response and error message {"error":"Validation
failed"}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #7 from David Nind --- Hi Thibaud. Apologies for not retesting sooner! I'm getting this error trace message now after applying the patch: Could not compile /kohadevbox/koha/opac/ilsdi.pl: Bareword "_description" not allowed while "strict subs" in use at /kohadevbox/koha/C4/ILSDI/Services.pm line 262. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 ... If I refresh the page again, I get this error trace message: Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload C4/ILSDI/Services.pm aborted. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 ... Maybe this is because koha-testing-docker is using strict mode for the database? (I don't know enough about these things to offer an informed opinionor how to disable struct mode). David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #18 from David Nind --- I've tested, and this now fixes the display for: - the record in the staff interface and OPAC - the cart in the OPAC For course reserves, the status is shown as: - OPAC: Programming error, item-status.inc must be called with a Koha::Item object. - Staff interface: Available How I tested (using KTD): 1. Replicated the issue (as per the bug description), and in addition I added a record/item to a course reserve and the cart (for both the OPAC and staff interface). 2. Applied the patch, flush_memcached, restart_all and cleared the browser cache. 3. Refreshed the pages. 4. Results: - this worked fine for the record/item in the staff interface and OPAC; and the cart in the OPAC - Didn't work for course reserves: the status in the staff interface shows as 'Available' (I guess this is right as it is available but can't be borrowed?), and in the OPAC shows as 'Programming error, item-status.inc must be called with a Koha::Item object.' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #37 from David Nind --- Hi I'm getting this error when trying to apply the patch: root@kohadevbox:koha(bz29173)$ git bz apply 29173 Bug 29173 - Button "replace authority record via Z39/50/SRU" doesn't pre-fill 144867 - Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) error: sha1 information is lacking or useless (cataloguing/z3950_auth_search.pl). error: could not build fake ancestor Patch failed at 0001 Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32560] New: Mark expired borrowers as having lost their card
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Bug ID: 32560 Summary: Mark expired borrowers as having lost their card Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz We have a library that marks expired borrowers as having lost their card. It would be nice to be able to upstream the cronjob they use to mark borrowers.lost = 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Nind changed: What|Removed |Added Attachment #144856|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 144963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144963&action=edit Bug 32515: Ignore no-block flag in check-in message Bug 12225 changed the templates to correctly pass through the no-block flag, however, we don't have a no-block routine for checkins This patch restore previous behaviour of performing a normal checkin when no block was requested - it adds a new FIXME To test: 1 - See bug 32537 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 2 - Repeat test plan on that bug, noting that there is no response when no-block = Y 3 - Apply this patch 4 - Repeat the tests and confirm no-block = Y has a standard checkin response Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #4 from David Nind --- (In reply to Nick Clemens from comment #3) > (In reply to David Nind from comment #2) > > > > I'm not sure if this is what is expected (as it is pretty similar to what I > > got for bug 32537, except the second and third series of numbers in the SEND > > are different), but happy to sign off if it is. > > Hi David, > > It looks like the SIP response is still failing on no-block, but I don't > recreate > > Could you retest with 'restart_all' rather than just SIP to see if that > works? Or try koha-sip --stop, confirm stopped, then koha-sip --start? I'm getting a response now, so will sign off! The response is now: root@kohadevbox:koha(bz32515)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 311418 -n Y Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09Y2023010323115420230103 231154APCPL|AOCPL|AB311418|ACterm1|BIN| READ: 101YNN20230103231155AOCPL|AB311418|AQCPL|AJProgramming Perl /|CRREF| Maybe I forgot to flush_memcached and restart_all after stopping and starting SIP 8-; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- > Two questions: > > 1. How do we fix this for sites that reach the limit? > > 2. How do we make sure this never happens? > > To extend the period before this happens, it might be a quick fix to change > the borrower_message_preference_id column from SIGNED (the default) to > UNSIGNED. As far as I can tell, this would double the number of IDs the > column can hold. It might make more sense to switch from SIGNED INT to SIGNED BIGINT as the maximum value for SIGNED BIGINT is 9,223,372,036,854,775,807 That would make it much less likely to hit the max value limit. > A better solution might be to make the borrower_message_preferences update > in place, and not generate new borrower_message_preference_id's every time > they are updated? That's probably a better solution although it would involve more elaborate coding. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 --- Comment #14 from Lucas Gass --- reset to 'Needs signoff' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What|Removed |Added Attachment #144887|0 |1 is obsolete|| --- Comment #13 from Lucas Gass --- Created attachment 144962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144962&action=edit Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 5. The search results table should be listed, with the ability to hide the author, date_added, or call_number 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) 8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now. Note: I have also added the page-section class to this table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #7 from David Cook --- An alternative would be to launch more background_jobs_worker.pl processes, although that would require updating the koha-worker script. Speaking of the koha-worker script, how would the max processes be configured for it? Perhaps something in debian/koha-common.init that can be overridden in /etc/default/koha-common? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #6 from Kyle M Hall --- Created attachment 144961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144961&action=edit Bug 32558: (follow-up) Set default max processes to 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #5 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > Hi Kyle, you embedded unrelated changes (sip). > This would make sense in some cases (job types), but I think it should > default to 1 to keep the existing behaviour (we don't want 10 long > tasks/batch mod running at the same time). Yep, that was an accident. It just took me a few minutes to untangle ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What|Removed |Added Text to go in the||This fixes the standard release notes||MARC editor so that the ||links for any errors go to ||the correct tab. Currently, ||the links only work if you ||are the correct tab. --- Comment #5 from David Nind --- I've added a draft release note. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Hi Jan. Your patch works (yeah!), but I can't seem to sign it off. I get this message: root@kohadevbox:koha(bz32523)$ git bz attach -e 32523 HEAD /usr/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal obsoleted = (initial_description == patch.description) Traceback (most recent call last): File "/usr/bin/git-bz", line 2722, in do_attach(*args) File "/usr/bin/git-bz", line 2074, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/bin/git-bz", line 1988, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/bin/git-bz", line 1940, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue self.buf += ''.join(self.buflist) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128) I can sign off other patches (and my koha-testing-docker (KTD) is all up to date), so I don't think it is my setup (but I could be wrong!). Also, I think you will need to amend your patch for the QA Team to be happy, including: - Formatting title as Bug X: Title - Including the description and test plan in the patch See the commit message guidelines at https://wiki.koha-community.org/wiki/Commit_messages David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Special characters causes patron search to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 PPLCS changed: What|Removed |Added CC||ad...@pplcs.net --- Comment #5 from PPLCS --- We desperately need this fixed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32177] Tests failing for t/db_dependent/Circulation.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32177 David Nind changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from David Nind --- This seems to have been fixed now - tests pass (with warnings) now on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What|Removed |Added Attachment #144947|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 144960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144960&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #19 from David Nind --- Testing notes (using KTD): 1. Before the patches are applied, ran prove t/db_dependent/Circulation.t 2. Note that tests pass, but there are warnings: root@kohadevbox:koha(bz32353)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 60/64 Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line 5712. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. t/db_dependent/Circulation.t .. ok All tests successful. Files=1, Tests=64, 26 wallclock secs ( 0.15 usr 0.02 sys + 18.55 cusr 2.50 csys = 21.22 CPU) Result: PASS 3. Applied patches and restarted everything. 4. Run test again. Note that "60/64 Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line 5712." warning/output after running the tests is gone: root@kohadevbox:koha(bz32353)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 60/64 Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. t/db_dependent/Circulation.t .. ok All tests successful. Files=1, Tests=64, 26 wallclock secs ( 0.13 usr 0.01 sys + 18.61 cusr 2.52 csys = 21.27 CPU) Result: PASS I hope this is sufficient for testing - I don't understand all the other stuff 8-). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #4 from Agustín Moyano --- Created attachment 144959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144959&action=edit Bug 31799: (follow-up) Tidy up and fix duplicate barcode handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 David Nind changed: What|Removed |Added Attachment #144279|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 144958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144958&action=edit Bug 32353: Don't generate item group for holds in tests See bug 31447, we don't want the tests to deal with potential failures because of some item groups. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 David Nind changed: What|Removed |Added Attachment #144255|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 144957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144957&action=edit Bug 32353: Pick the default value for FK Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano changed: What|Removed |Added Attachment #144952|0 |1 is obsolete|| Attachment #144953|0 |1 is obsolete|| --- Comment #7 from Agustín Moyano --- Created attachment 144956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144956&action=edit Bug 31798: (follow-up) Tidy up and add duplicate barcode test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 Lucas Gass changed: What|Removed |Added Attachment #144934|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 144955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144955&action=edit Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on item batch mod The 'Clear on loan' link displayed at the top of the batch item modification tool has been broken by bug 28445. data-is-onloan attribute is supposed to be 1 or 0, but we passed the checkout (Koha::Checkout=HASH) Test plan: 1. Enter a checked-out barcode in the 'Batch item modification' page 2. Click 'Continue' 3. Notice a table is loaded displaying the on-loan item with a ticked checkbox 4. Click the 'Clear on loan' link above the table 5. Notice the on-loan item is no longer selected Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Lucas Gass changed: What|Removed |Added Attachment #144951|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 144954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144954&action=edit Bug 32559: Add support for formatted date when filtering on a column When dates are displayed formatted (following the dateformat syspref) in a DataTable table and that there is a filter for the column, we should filter correctly the data. Test plan: Assuming dateformat is set to metric Go to the main patron search, search for all patrons (don't provide a search term) In the "date of birth" column filter, enter "1958", notice that you see Henry Search using an iso formatted date 1958-05-30 Search using a metric formatted date 30/05/1958 Note that: - it's also working for "Expires on" on the same table. We may want to adjust other tables that are using the DT REST API wrapper and the column filters - You need to search for the full formatted date to make it work. "30/05" won't work. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Special characters causes patron search to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #4 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > This also effects wildcard searches. Previously you could search for a > cardnumber like '2913*' and that would return all patrons with cardnumbers > starting with '2913'. Now it tries searching for the exact match '2352*' and > returns nothing. I don't think * has worked, but it automatically did a begin with. % should probably still work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #6 from Agustín Moyano --- (In reply to Tomás Cohen Arazi from comment #4) > Agustin, I think this is missing tests for the duplicate barcode use case. > And in those tests it should be returning a 409 (conflict?) instead of a 500 > because of the unhandled exception. > > Thanks. Should we return 409 conflict or 400 bad request? Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #5 from Agustín Moyano --- Created attachment 144953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144953&action=edit Bug 31798: (follow-up) Add duplicate barcode test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Tomás Cohen Arazi --- Agustin, I think this is missing tests for the duplicate barcode use case. And in those tests it should be returning a 409 (conflict?) instead of a 500 because of the unhandled exception. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org --- Comment #2 from Jason Robb --- Not sure if this is the exact same issue but I'm on 22.05.07 and consistently getting the "Wrong CSRF Token" error any time I try to add a patron photo from any page of the account *other than* the Details (moremember.pl) tab. I've tested with both the snazzy new camera integration and by manually uploading a file, and in both cases, it only succeeds on moremember.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #3 from Agustín Moyano --- Created attachment 144952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144952&action=edit Bug 31798: (follow-up) Tidy up camel cased variables and unnecessary checks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Special characters causes patron search to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #3 from Lucas Gass --- This also effects wildcard searches. Previously you could search for a cardnumber like '2913*' and that would return all patrons with cardnumbers starting with '2913'. Now it tries searching for the exact match '2352*' and returns nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Special characters causes patron search to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #1) > Hm, maybe data-search could work? Nope, we need to deal with it "manually", we cannot rely on DT internals. Here we are using the REST API and don't have the data loaded in the DOM already. However I would be happy if someone else come with a better solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #2 from Jonathan Druart --- Created attachment 144951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144951&action=edit Bug 32559: Add support for formatted date when filtering on a column When dates are displayed formatted (following the dateformat syspref) in a DataTable table and that there is a filter for the column, we should filter correctly the data. Test plan: Assuming dateformat is set to metric Go to the main patron search, search for all patrons (don't provide a search term) In the "date of birth" column filter, enter "1958", notice that you see Henry Search using an iso formatted date 1958-05-30 Search using a metric formatted date 30/05/1958 Note that: - it's also working for "Expires on" on the same table. We may want to adjust other tables that are using the DT REST API wrapper and the column filters - You need to search for the full formatted date to make it work. "30/05" won't work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart changed: What|Removed |Added Blocks||32559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 [Bug 32559] Support formatted date for column filtering (DT) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What|Removed |Added Depends on||30310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 [Bug 30310] Replace Moment.js with Day.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #38 from Jonathan Druart --- Created attachment 144950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144950&action=edit Bug 30310: Fix date_to_rfc3339 We need the customParseFormat plugin to provide a custom date format to the dayjs constructor. Found while working on bug 32559, don't remove this function, it will be used later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Lucas Gass changed: What|Removed |Added Attachment #144902|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 144949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144949&action=edit Bug 31799: Add REST endpoint to modify a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio with an item 4. Make a PUT request to /api/v1/biblios/:biblio_id/items/:item_id with a json body that represents an item to replace 5. Check that the item was modified 6. Sign off Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #5 from David Gustafsson --- Found tests that still needs fixing, working on this and then should be ready for review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
--- Comment #2 from Lucas Gass ---
Tested with different iterations of this:
$.ajax({
url: '/api/v1/biblios/55/items/117',
method: 'PUT',
data: JSON.stringify({
"collection_code": "COLLECTION1",
"external_id": "123test",
}),
contentType: 'application/json',
success: function(result) {
console.log('altered')
},
});
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #1 from Katrin Fischer --- Hm, maybe data-search could work? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What|Removed |Added Depends on||32505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 [Bug 32505] Cannot search by dateofbirth in specified dateformat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Jonathan Druart changed: What|Removed |Added Blocks||32559 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > Note that the column filtering is still not working, but I guess it was > the case already in older versions. Ideally we will need to have a > "datatype" attribute passed to the the 'th' and retrieved from > datatables.js to add this same trick and build the query appropriately. See bug 32559. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 [Bug 32559] Support formatted date for column filtering (DT) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32557] Implement SIP2 no block flag for checkin messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557 --- Comment #1 from Kyle M Hall --- I've been working on this, and I'm not actually convinced we need anything more than what Nick has done on bug 32515. If someone can point out a scenario where we need more please let me know! Kyle -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32559] New: Support formatted date for column filtering (DT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Bug ID: 32559 Summary: Support formatted date for column filtering (DT) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When dates are displayed formatted (following the dateformat syspref) in a DataTable table and that there is a filter for the column, we should filter correctly the data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #3 from Katrin Fischer --- Thanks, Lucas :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #37 from Jonathan Druart --- Created attachment 144948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144948&action=edit Bug 30310: Replace one more occurrence to moment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What|Removed |Added Attachment #144946|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #3 from Kyle M Hall --- Created attachment 144947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144947&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #2 from Jonathan Druart --- Hi Kyle, you embedded unrelated changes (sip). This would make sense in some cases (job types), but I think it should default to 1 to keep the existing behaviour (we don't want 10 long tasks/batch mod running at the same time). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 slmontesde...@orem.org changed: What|Removed |Added CC||slmontesde...@orem.org --- Comment #7 from slmontesde...@orem.org --- My cataloging team and I are very interested in having the ability to edit authority records using the advanced editor. We are very focused on improving our authority database and being able to edit the authorities easier would be a big step in achieving that goal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #1 from Kyle M Hall --- Created attachment 144946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144946&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32394] Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi changed: What|Removed |Added Version(s)|23.05.00,22.11.01,22.11.01 |23.05.00,22.11.01 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass changed: What|Removed |Added Attachment #144924|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 144945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144945&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] New: Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Bug ID: 32558 Summary: Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32373] Show date of restriction on patron screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Lucas Gass changed: What|Removed |Added Attachment #144942|0 |1 is obsolete|| --- Comment #18 from Lucas Gass --- Created attachment 144944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144944&action=edit Bug 32373: (follow-up) Show patron restriction date Unnecessary import of format_sqldatetime has now been removed Test plan: 1) Create a restriction on a patron and navigate to that patron in Checkouts or the patron details page 2) There should be a message with details about the restriction but the creation date of the restriction won't be included in the message 3) Apply patch 4) The message should now say "Restricted since DATE" as in the screenshot attached. 5) Change the 'dateformat' syspref and refresh, the date should change to reflect the syspref Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32373] Show date of restriction on patron screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Lucas Gass changed: What|Removed |Added Attachment #144931|0 |1 is obsolete|| --- Comment #17 from Lucas Gass --- Created attachment 144943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144943&action=edit Bug 32373: Show patron restriction date When viewing a patron account with a restriction there is no way to see when the restriction was placed. This is available in the borrower_debarrments table and has now been added to the UI and matched to the 'dateformat' syspref. (Previous commit missed the moremember.tt render and the syspref formatting - this is now being done with the KohaDates template filter) Test plan: 1) Create a restriction on a patron and navigate to that patron in Checkouts or the patron details page 2) There should be a message with details about the restriction but the creation date of the restriction won't be included in the message 3) Apply patch 4) The message should now say "Restricted since DATE" as in the screenshot attached. 5) Change the 'dateformat' syspref and refresh, the date should change to reflect the syspref Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32373] Show date of restriction on patron screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32373] Show date of restriction on patron screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32373] Show date of restriction on patron screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 --- Comment #16 from Matt Blenkinsop --- Created attachment 144942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144942&action=edit Bug 32373: (follow-up) Show patron restriction date Unnecessary import of format_sqldatetime has now been removed Test plan: 1) Create a restriction on a patron and navigate to that patron in Checkouts or the patron details page 2) There should be a message with details about the restriction but the creation date of the restriction won't be included in the message 3) Apply patch 4) The message should now say "Restricted since DATE" as in the screenshot attached. 5) Change the 'dateformat' syspref and refresh, the date should change to reflect the syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Lucas Gass changed: What|Removed |Added Attachment #144933|0 |1 is obsolete|| --- Comment #21 from Lucas Gass --- Created attachment 144941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144941&action=edit Bug 10762: (follow-up) Add exec right on atomic update file https://bugs.koha-community.org/show_bug.cgi?id=17062 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Lucas Gass changed: What|Removed |Added Attachment #144900|0 |1 is obsolete|| --- Comment #20 from Lucas Gass --- Created attachment 144940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144940&action=edit Bug 10762: (follow-up) Update test plan, add kohastructure.sql files I also change the default value for scale_height to '0.01' Test plan: 1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Lucas Gass changed: What|Removed |Added Attachment #134754|0 |1 is obsolete|| --- Comment #19 from Lucas Gass --- Created attachment 144939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144939&action=edit Bug 10762: Change the size of barcodes in label creator Test plan: 1)Home > Tools > Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.04), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 Jonathan Druart changed: What|Removed |Added Attachment #144847|0 |1 is obsolete|| Attachment #144925|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 144938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144938&action=edit Bug 32528: Make safe_to_delete exit earlier on error conditions This patch makes the `Koha::Item->safe_to_delete` method return right after one of the checked conditions is met. This way we avoid further DB queries and processing. No behavior change is expected To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests STILL pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Bug 32528: Change return logic Back to 1 return statement Prevent the Koha::Result::Boolean instanciation duplication Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32373] Show date of restriction on patron screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- (In reply to Katrin Fischer from comment #14) > I believe this could be removed again now, could you confirm? > -use Koha::DateUtils qw( dt_from_string ); > +use Koha::DateUtils qw( dt_from_string format_sqldatetime ); Yes, it looks like 'format_sqldatetime' is not needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Lucas Gass changed: What|Removed |Added Attachment #144922|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 144937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144937&action=edit Bug 32505: Restore patron search by formatted dob Prior to the rewrite of the patron searches (bug 30063 and friends) it was possible to search for a patron using their date of birth, formatted following the dateformat syspref. Now it only works if the date is iso formatted. This patch is providing a fix to restore the behaviour, but does not make it consistent. Only searching patrons by date of birth is fixed here, when we actually want to fix the problem for the REST API DT wrapper instead. Test plan: Search for patrons given their date of birth. You need to select "date of birth" in the "Search field" dropdown, or set it in DefaultPatronSearchFields. Note that the column filtering is still not working, but I guess it was the case already in older versions. Ideally we will need to have a "datatype" attribute passed to the the 'th' and retrieved from datatables.js to add this same trick and build the query appropriately. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920
--- Comment #26 from Jonathan Druart ---
(In reply to Nick Clemens from comment #25)
> (In reply to Jonathan Druart from comment #19)
> > I think this change is coming whereas we don't use the same code to display
> > the descriptions, and it could lead to confusion (theoretically at least):
> > fetch from cache and fetch from DB.
>
> Can you explain this a bit more? Where are we not using this that could be a
> conflict?
Everywhere we fetch branchname, itemtype's description, av's lib (mainly from
C4)
> > There is at least one thing that could go wrong, itemtype's descriptions.
> > First we only deal with 'en', then it is actually wrong with 'en': it could
> > be overwritten by the "Translate into other languages" feature (yes that's a
> > weird use case but the UI allows it).
> In testing I can provide a French translation and the correct one shows when
> changing languages in search results on both staff and OPAC
Sorry, I think it didn't make sense. I guess I was referring to
Koha::Itemtype->store
+if ($flush) {
+my $cache = Koha::Caches->get_instance();
+my $key = "enItemTypeDescriptions";
+$cache->clear_from_cache($key);
+}
But it actually sounds good after having a second look at it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > Created attachment 144925 [details] [review] > Bug 32528: Change return logic > > Back to 1 return statement > Prevent the Koha::Result::Boolean instanciation duplication I agree with the follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
