[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Testing notes (using KTD): 1. Everything looks OK to me after applying the patches and viewing the About page tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 David Nind changed: What|Removed |Added Attachment #145060|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 145076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145076&action=edit Bug 32571: (follow-up) Implement abstracted tabs on About page This patch implements the proposed system for building tabs on the About page. To test, apply the patch and view the About page. It should look the same as before and all tabs should function correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 David Nind changed: What|Removed |Added Attachment #145059|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 145075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145075&action=edit Bug 32571: Use template wrapper to build tabbed components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build tabbed components while keeping tab structural markup separate. Each individual component of a Bootstrap tabbed interface is defined: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels Included is a usage example: [ WRAPPER tabs id= "tabs container id" ] [ WRAPPER tabs_nav ] [ WRAPPER tab_item tabname= "tab name 1" ] [ content ] [ END ] [ WRAPPER tab_item tabname= "tab name 2" ] [ content ] [ END ] ... [ END ] [ WRAPPER tab_panels ] [ WRAPPER tab_panel id="tab name 1"] [ content ] [ END ] [ WRAPPER tab_panel id="tab name 2"] [ content ] [ END ] ... [ END ] [ END ] Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15491] Disable the ability to suspend holds related to certain itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15491 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com --- Comment #1 from Benjamin Daeuber --- How much does this development overlap with https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org --- Comment #4 from Michael Adamyk --- Confirmed, I'm experiencing this issue after the 22.05 upgrade also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27314] Update default Elastic mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com --- Comment #3 from Sarah Cornell --- Created attachment 145074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145074&action=edit ES mappings that were not included in default setup but are used by OPAC searches I reviewed all the searches that our OPAC generates and made sure that the fields they used were indexed. I found MANY missing indexes. Some of the searches SEEMED okay but were not because one of the 3 fields used in the automatically generated search was missing. So no one has to go through it again I will share the indexes I've added in an attachment. NB: the search that the OPAC generates that might use the 775at is still under discussion. We're not sure which index is best when the search generated is ti,phr. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Esther Melander changed: What|Removed |Added CC||esth...@sodaspringsid.com --- Comment #14 from Esther Melander --- In regards to the wild card searches in the patron field, Should this be a separate ticket? Prior to our upgrade to 22.05, we could do searches like 2913*3456 and have it return results. After the upgrade this no longer works. The % wildcard appears to work in the search example above. However the % as a wildcard is odd when compared with how other search indexes work. Most major search engines use either an asterisk or a question mark. The same is true with searching indexes at Ancestry or Family Search. The asterisk replaces multiple characters and the question mark replaces a single character. Most of our staff is accustomed to using an asterisk and trying to adapt to a different nomenclature and keyboard position has proven difficult. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > Created attachment 145064 [details] [review] > Bug 32393: Remove fork Just a thought; removing that fork will cause the workers memory footprint to balloon as soon as the plugins require is evaluated which obviates the bug patch where you introduce the require. I think this pushes us farther in the direction of needing to ack each request before handling the job. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Caroline Cyr La Rose changed: What|Removed |Added Attachment #145069|0 |1 is obsolete|| --- Comment #3 from Caroline Cyr La Rose --- Created attachment 145073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145073&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings Signed-off-by: David Nind Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27314] Update default Elastic mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32562] Reindent the about page template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Lucas Gass changed: What|Removed |Added Attachment #145056|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 145072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145072&action=edit Bug 32562: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32562] Reindent the about page template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Lucas Gass changed: What|Removed |Added Attachment #145055|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 145071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145071&action=edit Bug 32562: Reindent the about page template This patch reindents the about page template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the about page. Everything should look normal. All tabs should work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32562] Reindent the about page template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 --- Comment #3 from Owen Leonard --- Created attachment 145070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145070&action=edit Bug 32507: (follow-up) Change parameter name to avoid collisions The variable name "active" is very likely to already be set for other reasons, so changing the parameter name to "bc_active" to avoid problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes an issue with release notes||configuring the columns for ||patron search results in ||Koha 22.05 - this should ||now work as expected. The ||columns are now ||configurable using the ||Columns button in the ||search results and in the ||table settings ||(Administration > ||Additional parameters > ||Table settings > Patrons > ||member > memberresultst). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind changed: What|Removed |Added Attachment #145068|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 145069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145069&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 --- Comment #1 from Lucas Gass --- Created attachment 145068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145068&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32574] New: memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Bug ID: 32574 Summary: memberresultst table cannot be column configured in 22.05.x Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com memberresultst needs to use TablesSettings.GetTableSettings but it is using TablesSettings.GetColumns so table settings don't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 --- Comment #14 from Martin Renvoize --- Right.. so going back to this.. I still think this patch is incorrect in it's implementation.. the idea taken forward in bug 11175 was to pass a prebuild query to the xslt rather than constructing it again.. i.e DRY coding so we don't fall out of sync again.. https://git.koha-community.org/Koha-community/Koha/src/branch/master/opac/opac-detail.pl#L621 - We pass the query to the template here.. seems it's moved out of the XSLT entirely now.. I can't remember without digging how it all fits together now. But the point is.. we don't want the query to get out of sync between what's used server-side and what's displayed client-side. I also still think the query needs work as bug 29268 highlights. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 Martin Renvoize changed: What|Removed |Added Blocks||27507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 [Bug 27507] Search host record using control number identifier / organization code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What|Removed |Added Depends on||29268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32275] Fill blank record in basic editor using ISBN with Google Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32275 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26482] Add macros ability to basic editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26482 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What|Removed |Added Attachment #144960|0 |1 is obsolete|| Attachment #144961|0 |1 is obsolete|| Attachment #145043|0 |1 is obsolete|| Attachment #145062|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall --- Created attachment 145067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145067&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl with parameter -p 3 or some other number of max processes 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #1 from Kyle M Hall --- Created attachment 145066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145066&action=edit Bug 32573: Send ACK message to RabbitMQ before handling the job Splitting off this functionality from bug 32558. This is the comment that started this discussion: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558#c15 From the O'Reilly book Mobile and Web Messaging: --- By default, the STOMP broker will consider the message automatically acknowledged when it is delivered to the consumer. However, there are cases in which the consumer may prefer to explicitly acknowledge the message. It leaves a window of opportunity to determine whether it can handle the message or not. For example, the client needs to write the message payload in a data store. There may be issues with opening a connection to the data store and the client could choose to acknowledge the message only after having successfully written its body to the data store. In case of failure, it will instead nack the message (explicitly refuse to take ownership of it). When the STOMP broker is informed of this negative acknowledgment, it may then decide to deliver the message to another consumer subscribed to the destination or try again some time later depending on its configuration. --- From https://www.rabbitmq.com/stomp.html --- RabbitMQ STOMP plugin supports auto, client, and client-individual subscription headers that affect how ACK on NACK operations work. The auto mode uses automatic acknowledgements. The client mode is manual (client-driven) acknowledgements of multiple messages at once. The client-individual is for message-by-message manual acknowledgement. --- If ACK is meant to be sent post-work, why would automatic acknowledgement exist? The interpretation that an ACK is meant to be sent after handling the processing of a job doesn't make sense. In summary, we should be sending back ACK messages as soon as we've successfully processed ( e.g. read and decoded the data ) of a frame. Only then should we process it. Test Plan: 1) Apply this patch 2) Launch background_jobs_worker.pl 3) Note no changes in background job processing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What|Removed |Added Depends on||32573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added Blocks||32558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #19 from Kyle M Hall --- (In reply to Kyle M Hall from comment #18) > (In reply to Jonathan Druart from comment #17) > > This contradicts https://metacpan.org/pod/Net::Stomp#ack > > > > """ > > This acknowledges that you have received and processed a frame and all > > frames before it (if you are using client acknowledgements) > > """ > > That interpretation contradicts the STOMP protocol specification: > https://stomp.github.io/stomp-specification-1.2.html#ACK > > I think the problem here lay in the vagueness of the phrase "processed a > frame". That doesn't mean "completed a task". It simply means the frame was > successfully read by the client, and that we were able to decode the data > within it, and nothing more. Moving this discussion and patch to Bug 32573 to avoid scope creep. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32573 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32558 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] New: background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Bug ID: 32573 Summary: background_jobs_worker.pl should ACK a message before it forks and runs the job Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Splitting off this functionality from bug 32558. This is the comment that started this discussion: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558#c15 From the O'Reilly book Mobile and Web Messaging: --- By default, the STOMP broker will consider the message automatically acknowledged when it is delivered to the consumer. However, there are cases in which the consumer may prefer to explicitly acknowledge the message. It leaves a window of opportunity to determine whether it can handle the message or not. For example, the client needs to write the message payload in a data store. There may be issues with opening a connection to the data store and the client could choose to acknowledge the message only after having successfully written its body to the data store. In case of failure, it will instead nack the message (explicitly refuse to take ownership of it). When the STOMP broker is informed of this negative acknowledgment, it may then decide to deliver the message to another consumer subscribed to the destination or try again some time later depending on its configuration. --- From https://www.rabbitmq.com/stomp.html --- RabbitMQ STOMP plugin supports auto, client, and client-individual subscription headers that affect how ACK on NACK operations work. The auto mode uses automatic acknowledgements. The client mode is manual (client-driven) acknowledgements of multiple messages at once. The client-individual is for message-by-message manual acknowledgement. --- If ACK is meant to be sent post-work, why would automatic acknowledgement exist? The interpretation that an ACK is meant to be sent after handling the processing of a job doesn't make sense. In summary, we should be sending back ACK messages as soon as we've successfully processed ( e.g. read and decoded the data ) of a frame. Only then should we process it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Owen Leonard changed: What|Removed |Added Attachment #145031|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 145065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145065&action=edit Bug 32567: Update unimarc_field_110.pl with some values 'Script of title' values => e - b/c/d/e/f/g/h i - d/e j - f/g l - f n - b/c o - a p - a 'Translitteral code' values => 'g' and 'h' Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #18 from Kyle M Hall --- (In reply to Jonathan Druart from comment #17) > This contradicts https://metacpan.org/pod/Net::Stomp#ack > > """ > This acknowledges that you have received and processed a frame and all > frames before it (if you are using client acknowledgements) > """ That interpretation contradicts the STOMP protocol specification: https://stomp.github.io/stomp-specification-1.2.html#ACK I think the problem here lay in the vagueness of the phrase "processed a frame". That doesn't mean "completed a task". It simply means the frame was successfully read by the client, and that we were able to decode the data within it, and nothing more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #23 from Jonathan Druart --- (In reply to Jonathan Druart from comment #22) > The best solution I found is the 2 patches from bug 32393. But still not idea, I still get gaps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #22 from Jonathan Druart --- The best solution I found is the 2 patches from bug 32393. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #8 from Jonathan Druart --- Created attachment 145064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145064&action=edit Bug 32393: Remove fork -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29798] [DOCS] Improve explanation of Allow auto-renewal button in Patron edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29798 Aude Charillon changed: What|Removed |Added Status|ASSIGNED|RESOLVED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/550 Keywords|Manual |Manual-updated Resolution|--- |FIXED --- Comment #1 from Aude Charillon --- Manual updated July 2022 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32572] We should have a background queue for each job type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32558 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32572 CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32572] New: We should have a background queue for each job type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 Bug ID: 32572 Summary: We should have a background queue for each job type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In production we are seeing that ES updates and real time holds queue can overwhelm the background worker and fall behind from "real time" If we had a dedicated worker for each of these jobs we could batch the operations, e.g. Fetch ES jobs until we hit 100 records or run out of queue, then index 100 at a time Indexing 1 record at a time takes a long time for each record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Aude Charillon changed: What|Removed |Added Documentation||Aude Charillon contact|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Aude Charillon changed: What|Removed |Added Status|REOPENED|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #17 from Jonathan Druart --- This contradicts https://metacpan.org/pod/Net::Stomp#ack """ This acknowledges that you have received and processed a frame and all frames before it (if you are using client acknowledgements) """ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 --- Comment #13 from Andrew Nugged --- (this one above is just rebased on the current master, let's see what to do further, our productions use this feature because it is related to related records so it's needed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Andrew Nugged changed: What|Removed |Added Attachment #119904|0 |1 is obsolete|| --- Comment #12 from Andrew Nugged --- Created attachment 145063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145063&action=edit Bug 27507: Specify organization code when searching host record This allows now importing records to Koha database from multiple different organizations and keeps the "In: XXX" links in the catalogue/detail.pl page unique. To test: 1) Add host record with 001 and 003 values of "1234" and "TEST" 2) Add host record with 001 and 003 values of "1234" and "TEST2" 2) Add component record with 773w value of (TEST)1234 3) Notice the link in the component record goes to search page with two results 4) Apply patch 5) Notice the link in the component record goes directly to the first host record created with 001 = 1234 and 003 = TEST 6) Test also that if you modify the 773w link with just the value of "1234" the search will still work and give you two results Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Aude Charillon changed: What|Removed |Added Resolution|FIXED |--- Status|CLOSED |REOPENED CC||aude.charillon@ptfs-europe. ||com --- Comment #43 from Aude Charillon --- Re-opening to add Documentation status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #16 from Kyle M Hall --- Created attachment 145062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145062&action=edit Bug 32558: (follow-up) Ack the stomp message before forking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #15 from Kyle M Hall --- (In reply to Jonathan Druart from comment #14) > From > https://www.grzegorowski.com/rabbitmq-406-channel-closed-precondition-failed > > "You have to ACK messages in same order as they arrive to your system" > > If this is correct, forking is not an option here. > > I have not found something similar in rabbitmq doc however. You are correct. I've been reading a lot about ACK messages, and we are using them wrong. ACK isn't suppose to indicate a process has completed. It's only meant to indicate the a message has been received. In fact, sending ACK messages appears to be optional. This is from the O'Reilly book Mobile and Web Messaging: --- By default, the STOMP broker will consider the message automatically acknowledged when it is delivered to the consumer. However, there are cases in which the consumer may prefer to explicitly acknowledge the message. It leaves a window of opportunity to determine whether it can handle the message or not. For example, the client needs to write the message payload in a data store. There may be issues with opening a connection to the data store and the client could choose to acknowledge the message only after having successfully written its body to the data store. In case of failure, it will instead nack the message (explicitly refuse to take ownership of it). When the STOMP broker is informed of this negative acknowledgment, it may then decide to deliver the message to another consumer subscribed to the destination or try again some time later depending on its configuration. --- I will submit a following so that we ACK the message before forking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30859] Upgrade jQuery Validation plugin from v1.19.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Aude Charillon changed: What|Removed |Added CC||aude.charillon@ptfs-europe. ||com Resolution|--- |FIXED Status|Needs documenting |CLOSED --- Comment #7 from Aude Charillon --- No update to Koha manual needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481
Jonathan Druart changed:
What|Removed |Added
Severity|normal |critical
--- Comment #21 from Jonathan Druart ---
There is something scary happening here.
I've added 3 debug statements, one displays the frame, 2 others are before the
process and ack calls.
{"record_ids":[295],"record_server":"biblioserver","job_id":1824} at
/kohadevbox/koha/misc/background_jobs_worker.pl line 97.
Processing 1824 at /kohadevbox/koha/misc/background_jobs_worker.pl line 105.
Acking 1824 at /kohadevbox/koha/misc/background_jobs_worker.pl line 107.
{"record_ids":[296],"job_id":1825,"record_server"CONNECTED
server at /kohadevbox/koha/misc/background_jobs_worker.pl line 97.
':' expected, at character offset 49 (before "CONNECTED\nserver") at
/kohadevbox/koha/misc/background_jobs_worker.pl line 98.
{"record_server":"biblioserver","job_id":1879,"record_ids":[350]} at
/kohadevbox/koha/misc/background_jobs_worker.pl line 97.
Processing 1879 at /kohadevbox/koha/misc/background_jobs_worker.pl line 105.
Acking 1879 at /kohadevbox/koha/misc/background_jobs_worker.pl line 107.
=> Frame for job 1825 is incorrect (?!), and we are losing jobs 1826-1878.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31488] Rephrase "You have checked out too many items" to be friendlier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 Aude Charillon changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |CLOSED CC||aude.charillon@ptfs-europe. ||com --- Comment #8 from Aude Charillon --- Checked manual: no mention or screenshot of this particular message. No need to document. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #20 from Jonathan Druart --- > operation basic.ack caused a channel exception precondition_failed: unknown > delivery tag 245 I think it's the fork, I removed it and it seems to be ok now. Could someone confirm? > Detail: "PRECONDITION_FAILED - consumer ack timed out on channel 1\n" I am still seeing this after I removed the fork, which means this patch does not fix the timeout problem. I am also seeing this: ':' expected, at character offset 49 (before "CONNECTED\nserver") at /kohadevbox/koha/misc/background_jobs_worker.pl line 97. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32481 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32393 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Jonathan Druart --- There are 2 ack sent, because of the fork I guess. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Carolyn Hughesman changed: What|Removed |Added CC||chughes...@cclsny.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 David Nind changed: What|Removed |Added Attachment #145050|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 145061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145061&action=edit Bug 32570: Display patron.state correctly To test: 1. Have a patron with both a city and state in their Main address. 2. Do a patron search that will return that patron among others. 3. Notice the patroncity will say something like Centerville, Centerville: repeating the city but no state. 4. Apply patch 5. Try step 2 again, this time the city, state should display correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #14 from Jonathan Druart --- From https://www.grzegorowski.com/rabbitmq-406-channel-closed-precondition-failed "You have to ACK messages in same order as they arrive to your system" If this is correct, forking is not an option here. I have not found something similar in rabbitmq doc however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #13 from David Nind --- Testing notes (using KTD): 1. For me, this fixes the search from the 'Search for patron' box on the patrons page 2. In the header search it continues to work, however I note that if you search for example for 'burton' then this gives you the autocomplete results. However, if you search for 'Burton,' it doesn't show in autocomplete (but does give you the correct result when you click the button to search). Searching for 'burton mary' will give you the autocomplete results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 --- Comment #2 from Owen Leonard --- Created attachment 145060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145060&action=edit Bug 32571: (follow-up) Implement abstracted tabs on About page This patch implements the proposed system for building tabs on the About page. To test, apply the patch and view the About page. It should look the same as before and all tabs should function correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 --- Comment #1 from Owen Leonard --- Created attachment 145059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145059&action=edit Bug 32571: Use template wrapper to build tabbed components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build tabbed components while keeping tab structural markup separate. Each individual component of a Bootstrap tabbed interface is defined: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels Included is a usage example: [ WRAPPER tabs id= "tabs container id" ] [ WRAPPER tabs_nav ] [ WRAPPER tab_item tabname= "tab name 1" ] [ content ] [ END ] [ WRAPPER tab_item tabname= "tab name 2" ] [ content ] [ END ] ... [ END ] [ WRAPPER tab_panels ] [ WRAPPER tab_panel id="tab name 1"] [ content ] [ END ] [ WRAPPER tab_panel id="tab name 2"] [ content ] [ END ] ... [ END ] [ END ] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32562] Reindent the about page template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Owen Leonard changed: What|Removed |Added Blocks||32571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff Depends on||32562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 [Bug 32562] Reindent the about page template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What|Removed |Added Attachment #145054|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 145058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145058&action=edit Bug 32491: Split patron search terms on comma Previous behaviour allowed search 'surname, firstname'. We should remove the comma from the search terms. Test plan: On the main patron search, search for "surname, firstname" and confirm that with this patch applied the search returns the expected results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] New: Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Bug ID: 32571 Summary: Use template wrapper to build tabbed components Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: dc...@prosentient.com.au, testo...@bugs.koha-community.org In preparation for an upgrade to Bootstrap 5 I propose that we try to abstract the way we build some components. This will help reduce the number of template changes required during the update. Using Template::Toolkit WRAPPERs we can create the structural components for tabs separately from the tab content: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels This can be done gradually before the Bootstrap upgrade without causing any disruption. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32529] Holds in processing should block item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32529 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32529] Holds in processing should block item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32529 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #51 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #50 from Tomás Cohen Arazi --- Thanks, Jonathan. This ended up being a nice cleanup along with the fix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 David Nind changed: What|Removed |Added Attachment #145046|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. I amended the commit message to fix the bug title (should be Bug 32564: )/ 2. Enabled the FreeForm backend using the instructions at https://wiki.koha-community.org/wiki/ILL_backends -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 --- Comment #2 from David Nind --- Created attachment 145057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145057&action=edit Bug 32564: Update ILL template markup to conform to Bootstrap panels The ILL request detail template uses Bootstrap panel markup that isn't quite correct. This patch changes the markup around the details and comments panels so that they look correct. To test you must have ILL enabled and have at least one request to view. - Apply the patch and go to ILL requests -> Manage request - The page should display with the "Request details" panel expanded by default. - Expanding and collapsing the "Request details" and "Comments" panels should work correctly. https://bugs.koha-community.org/show_bug.cgi?id=32564 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32562] Reindent the about page template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 --- Comment #2 from Owen Leonard --- Created attachment 145056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145056&action=edit Bug 32562: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32562] Reindent the about page template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 --- Comment #1 from Owen Leonard --- Created attachment 145055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145055&action=edit Bug 32562: Reindent the about page template This patch reindents the about page template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the about page. Everything should look normal. All tabs should work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32562] Reindent the about page template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491
--- Comment #11 from Jonathan Druart ---
(In reply to Owen Leonard from comment #8)
> (In reply to Katrin Fischer from comment #6)
>
> > Has this worked before?
>
> Patron searching works correctly in 22.05 with the comma included, so this
> is a regression.
Hum I am expecting a regression caused by 30063 or 30093 and both are in 22.05
Also I see, in 22.05.x
includes/patron-search.inc
314 let patterns = pattern.split(' ').filter(function(s){
return s.length });
I haven't tested though.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Blocks||32491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 [Bug 32491] Can no longer search patrons in format 'surname, firstname' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_11_candidate Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Depends on||30063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #10 from Jonathan Druart --- Created attachment 145054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145054&action=edit Bug 32491: Split patron search terms on comma Previous behaviour allowed search 'surname, firstname'. We should remove the comma from the search terms. Test plan: On the main patron search, search for "surname, firstname" and confirm that with this patch applied the search returns the expected results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
