[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #140259|0   |1
is obsolete||

--- Comment #131 from Aleisha Amohia  ---
Created attachment 145234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145234=edit
Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #140257|0   |1
is obsolete||

--- Comment #130 from Aleisha Amohia  ---
Created attachment 145233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145233=edit
Bug 3150: (follow-up) Fixing errors and notices

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #140256|0   |1
is obsolete||

--- Comment #129 from Aleisha Amohia  ---
Created attachment 145232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145232=edit
Bug 3150: (follow-up) Add missing bracket

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #140255|0   |1
is obsolete||

--- Comment #128 from Aleisha Amohia  ---
Created attachment 145231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145231=edit
Bug 3150: (follow-up) Reformat notices, don't send if no sender email

This patch reformats the notices so that the is_html flag is disabled
and the notices display better

It also throws an error if trying to send an email but the logged in
borrower has no valid email address.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #140254|0   |1
is obsolete||

--- Comment #127 from Aleisha Amohia  ---
Created attachment 145230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145230=edit
Bug 3150: (follow-up) HTML filtering TT notices and removing old files

Signed-off-by: David Nind 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #140253|0   |1
is obsolete||

--- Comment #126 from Aleisha Amohia  ---
Created attachment 145229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145229=edit
Bug 3150: Move emails for sending cart and list contents to notices

This patch creates notices using Template Toolkit syntax for sending
emails containing cart and list contents.

To test:
1. Apply Bug 27266
2. Run update database and restart services
3. In the staff client, add multiple items to your cart and to a list
4. Go to your cart and click Send to email the contents
5. Add an email and a comment and click Send
6. Confirm the information shown in the success message is correct
7. In your terminal, log into the database. View the message queue ( i.e.
select * from message_queue; ). Confirm that your email has been queued and the
content is all correct. Confirm the cart contents has been included as an
attachment.
8. Go to your list and click Send list to email the contents
9. Repeat steps 5-7
10. Log into the OPAC
11. Add multiple items to your cart and to a list
12. Repeat steps 4-9
13. By the end, you should have four emails in your message queue. All
of the data about the items should be correct, they should all have
attachments, and be addressed to the correct email address.

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

--- Comment #66 from Victor Zuniga  ---
Hi Jonathan,

Thanks so much for the update! I just upgraded and was able to complete the DB
schema upgrade.

We are up and running.

Best,

Victor


(In reply to Jonathan Druart from comment #65)
> (In reply to Victor Zuniga from comment #64)
> > Hello,
> > 
> > Is there a workaround for this issue? I ran into this issue when updating
> > the structure of the database via the web installer. It's not letting me
> > complete the installation.
> > 
> > Victor
> 
> Hi Victor, see bug 32470. The fix is available in the new release of 21.11.x
> but the debian packages are not ready yet. They should be published very
> soon!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32585] Followup on Bug 32583 - fix some variable references

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32585

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes (using KTD):

1. I tested by first apply bug 32583 and then this bug.

2. I then repeated the test plan in bug 32583.

I hope this is sufficient, otherwise let me know if any other tests are
required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32585] Followup on Bug 32583 - fix some variable references

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32585

David Nind  changed:

   What|Removed |Added

 Attachment #145115|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 145228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145228=edit
Bug 32585 - followup on Bug 32583 - fix some variable references

Bug 32583 change the $item variable from a hash to an object.  Trivial patch
to change some hash references to object method calls.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32585] Followup on Bug 32583 - fix some variable references

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32585

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583

--- Comment #3 from David Nind  ---
Created attachment 145227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145227=edit
Bug 32583 - Restore display of only one item in catalogue/moredetails

Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits
the items displayed to only one item if the itemnumber was passed as a
parameter to the page.
This restores that code.

Test plan:

1. find a title with multple items.
2. click on an items barcode in the holdings table on the title details page.
3. observe that all items are shown on the catalogue/moredetails page.
4. apply patch.
5. refresh (catalogue/moredetails) page.
6. observe that only the item for the barcode clicked on is shown.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31994] Clicking the next button of a DataTable loading its data from the HTML does nothing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31994

--- Comment #8 from David Nind  ---
(In reply to Olivier Hubert from comment #7)
> If someone can confirm reproduction on master, I will update the test plan
> accordingly.

Hi Olivier.

I was able to reproduce on the current master (using koha-testing-docker), here
is what I did:

1. Followed steps 1-2 in the current test plan.

2. Followed new step 2a.

3. Ran a flush_memcached, restart_all, and cleared the browser cache.[1]

4. The first time I go to Administration > Basic parameters > Item types the
behavour as identified occurs. That is, clicking on Next or Last options don't
work (from both at the top and bottom of the table).

5. If I click on the menu in the sidebar again (Item types) to refresh the
page, then the Next and Last options work as expected.

6. I applied the patch and followed the rest of the test plan, and this
resolved the issue.

I'm happy to sign off once you have updated the test plan.

Thanks for persevering with this!

David


[1] Clearing the browser cache: I normally use the Firefox Developer Edition,
and have set things so that all history, etc., are deleted when it is closed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 30526] The pagination in the REST API does not work if $c->objects->search is called multiple times.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596

--- Comment #7 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528

--- Comment #11 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491

--- Comment #21 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

--- Comment #36 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400

--- Comment #9 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32349] Remove TEST_QA

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349

--- Comment #18 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32349] Remove TEST_QA

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32437] When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32437] When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #144576|0   |1
is obsolete||

--- Comment #12 from ByWater Sandboxes  ---
Created attachment 145226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145226=edit
Bug 32437: Honor overlay setting in staged batch when adding to a basket

This patch uses the replace method added in last patch to ensure
records are overlayed when added to a basket

To test:
 1 - Stage the sample file on this report using the options below
 (If not using sample database simply save a record as marc from the
details page, then change the title in the interface and import the saved
version)
 2 - Make sure to match using KohaBiblio (999c)
 3 - Set option "Replace existing record" if match found
 4 - Once record is staged go to Acquisitions
 5 - Find a vendor and select/create an open basket
 6 - Add to basket from the staged file
 7 - Add order info and save
 8 - Check the record, title is unchanged -  Sample file should add 'New and
improved!'
 9 - Check the staged records batch - note the diff shows that new record
should have overwritten
10 - Apply patch
11 - Stage file, match on KohaBiblio, set action if matching record found to
'Ignore incoming record'
12 - Add to basket from the staged file and save
13 - Confirm record not overlayed when not reuqested
14 - Stage file, match on KohaBiblio, set action if mathc record found to 
'Replace existing...'
15 - Add to basket from staged file and save
16 - Confirm the record is updated to 'New and improved!'

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32437] When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #144575|0   |1
is obsolete||

--- Comment #11 from ByWater Sandboxes  ---
Created attachment 145225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145225=edit
Bug 32437: Add replace method to Koha::Import::Record objects

This patch adds a replace routine to Koha::Import::Record - largely
copying and updating code from C4::ImportBatch

To test:
prove t/db_dependent/Koha/Import/Records.t

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32437] When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #144574|0   |1
is obsolete||

--- Comment #10 from ByWater Sandboxes  ---
Created attachment 145224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145224=edit
Bug 32437: Add Objects for ImportAuths

This patch:
1 - Adds an atomic update to add a primary key to import_auths table
2 - Adds objects for Koha::Import::Records::Auths
3 - Adds tests for import auth and biblio objects

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32437] When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #144573|0   |1
is obsolete||

--- Comment #9 from ByWater Sandboxes  ---
Created attachment 145223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145223=edit
Bug 32437: Cleanup script

This patch:
- fixes some indentation
- flips unless-else to if-else for readability
- expands some comments for clarity
- removes unused biblioitemnum variable

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

solene.nga...@inlibro.com changed:

   What|Removed |Added

 CC||solene.nga...@inlibro.com

--- Comment #16 from solene.nga...@inlibro.com ---
I was not able to repeat the bug. 

The message expected in step 8 is already present in step 4. The libraries are
already sorted no matter if there's a "[" or not before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428

solene.nga...@inlibro.com changed:

   What|Removed |Added

 Attachment #139681|0   |1
is obsolete||

--- Comment #24 from solene.nga...@inlibro.com ---
Created attachment 145222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145222=edit
Bug 27428: Show the number of records in the bibliographic record detail page
with ElasticSearch.

Tests:
1. Apply this patch;
2. In the Preference system - OPACDisplayRecordCount -> Show;
3. We can see the number of records next to search links in the bibliographic
record detail page in the OPAC.

Signed-off-by: Stina Hallin 
Signed-off-by: Solene Ngamga 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428

solene.nga...@inlibro.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817

solene.nga...@inlibro.com changed:

   What|Removed |Added

 Attachment #145219|0   |1
is obsolete||

--- Comment #23 from solene.nga...@inlibro.com ---
Created attachment 145221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145221=edit
Bug 23817: [Alternative patch] Normalize phone number only when searching

This patch rewrites the phone number DBIC query when sent from DataTables
like in the Patron module.

Test plan:
0. Apply patch and koha-plack --restart kohadev
1. Go to
http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51
2. Input '1-(234)-567-8901' into the 'Primary phone' field
3. Note on the next screen the phone number is shown as '1-(234)-567-8901'
4. Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl
5. Choose "Search field" of "Primary phone"
6. Search for '12345678901'
7. Note you are taken to
http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51
8. Try out different permutations like '234 567 8901' or '5678901'
9. Note that every permutation works to find the borrower

Signed-off-by: Marius Mandrescu 
Signed-off-by: Solene Ngamga 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768

solene.nga...@inlibro.com changed:

   What|Removed |Added

 Attachment #142607|0   |1
is obsolete||

--- Comment #26 from solene.nga...@inlibro.com ---
Created attachment 145220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145220=edit
Bug 29768: Fix patron name displays and hyperlinks

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Solene Ngamga 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768

solene.nga...@inlibro.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817

Marius  changed:

   What|Removed |Added

 Attachment #140648|0   |1
is obsolete||

--- Comment #22 from Marius  ---
Created attachment 145219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145219=edit
Bug 23817: [Alternative patch] Normalize phone number only when searching

This patch rewrites the phone number DBIC query when sent from DataTables
like in the Patron module.

Test plan:
0. Apply patch and koha-plack --restart kohadev
1. Go to
http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51
2. Input '1-(234)-567-8901' into the 'Primary phone' field
3. Note on the next screen the phone number is shown as '1-(234)-567-8901'
4. Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl
5. Choose "Search field" of "Primary phone"
6. Search for '12345678901'
7. Note you are taken to
http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51
8. Try out different permutations like '234 567 8901' or '5678901'
9. Note that every permutation works to find the borrower

Signed-off-by: Marius Mandrescu 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 30846] Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846

--- Comment #2 from Caroline Cyr La Rose  ---
Now that bug 32445 is fixed, I tried in master and it still doesn't allow holds
when an item has a negative not for loan value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

Nick Clemens  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

--- Comment #1 from Nick Clemens  ---
Created attachment 145218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145218=edit
Bug 32612: Add worker-error to log4perl conf

To test:
1 - Apply patch
2 - vim /etc/koha/sites/kohadev/log4perl.conf, Add lines below:
log4perl.logger.worker = WARN, WORKER
log4perl.appender.WORKER=Log::Log4perl::Appender::File
log4perl.appender.WORKER.filename=/var/log/koha/kohadev/worker-error.log
log4perl.appender.WORKER.mode=append
log4perl.appender.WORKER.layout=PatternLayout
log4perl.appender.WORKER.layout.ConversionPattern=[%d] [%p] %m %l%n
log4perl.appender.WORKER.utf8=1
3 - Restart all
4 - Edit misc/background_jobs_worker.pl
-my $job = Koha::BackgroundJobs->find($args->{job_id});
+my $job;# = Koha::BackgroundJobs->find($args->{job_id});
5 - In another terminal: tail -f /var/log/koha/kohadev/koha-worker-error.log
6 - Force enqueue a job (that won't be found because of #4
  perl -e 'use Koha::BackgroundJob::BatchUpdateItem; my $bg =
Koha::BackgroundJob::BatchUpdateItem->new(); $bg->enqueue({
record_ids=>['88']});'
7 - Note error in log like:
  [2023/01/11 19:26:10] [WARN] No job found for id=2983 main::
/kohadevbox/koha/misc/background_jobs_worker.pl (111)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32611] Not for loan items don't show the specific not for loan value in OPAC detail page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611

--- Comment #2 from Caroline Cyr La Rose  ---
(In reply to Katrin Fischer from comment #1)
> Could this be Bug 32445 - Status display of 'not for loan' items is broken
> in OPAC/staff ?

That is what I thought too, but I didn't want to presume since the display was
already broken before that patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32612] New: Koha background worker should log to the worker-error.log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

Bug ID: 32612
   Summary: Koha background worker should log to the
worker-error.log
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573

--- Comment #21 from Kyle M Hall  ---
(In reply to David Cook from comment #19)
> (In reply to David Cook from comment #18)
> > > I've been pondering having separate workers for polling and rabbit
> > > respectively. It would simplify things a lot.
> > 
> > That does sound interesting. Could you explain that one more?
> 
> Actually, I think that I might know what you mean. If we had separate
> processes for polling and rabbit, people who prefer polling could use
> polling, and people who prefer rabbit could use rabbit. 
> 
> That could make things easier, as concurrent processing for polling and
> rabbit needs to be handled differently. And acknowledgements may or may not
> be used with polling...

I get where you are coming from, but the failover to polling has definitely
provided valuable. If we ACK first, it's not too difficult to handle both in
one script. If we continue to ACK last, it's more complicated but still
possible. I'd say we need to make the decision on where to ACK and the rest of
the plan will follow from that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 28980] Add temporary passwords which must be reset after first login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

Jason Robb  changed:

   What|Removed |Added

 CC||jr...@sekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #9 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #0)
> We need to improve our yarn build commands to generate css and js compiled
> files.
> 
> Then remove them from our codebase, and generate them when needed:
> 
> - when generating the debian packages
> - when ktd is starting up
> - when patches are applied on the sandbox

Hm, what about tarballs? 

We roll our own packages - what would be the suggested workflow? Generate the
files on the git branch before building the packages?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32611] Not for loan items don't show the specific not for loan value in OPAC detail page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611

--- Comment #1 from Katrin Fischer  ---
Could this be Bug 32445 - Status display of 'not for loan' items is broken in
OPAC/staff ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32611] New: Not for loan items don't show the specific not for loan value in OPAC detail page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611

Bug ID: 32611
   Summary: Not for loan items don't show the specific not for
loan value in OPAC detail page
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When viewing a detailed record on the OPAC, we used to see the specific value
of Not for loan (e.g. Ordered). Right now, any Not for loan value displays as
"Not for loan" no matter what the authorized value description (or description
(OPAC)) is.

To test:
1. In the staff interface, edit an item
2. Change the Not for loan value to Ordered
3. Save
4. Click on "Normal" to see the detailed record
--> Status is "Not for loan (Ordered)"
5. Click on "OPAC view: Open in new window."
--> Status is "Not for loan". It should be "Ordered"
6. Try with any not for loan value
--> Status stays "Not for loan". It should be whatever value you chose
7. Try changing the descriptions or descriptions (OPAC) in Administration >
Authorized values > NOT_LOAN
--> Status stays "Not for loan". It should be whatever you put in description
(OPAC) or description, if description (OPAC) is empty

I tested in 22.05(.07) and it shows Ordered (or whatever value I put). In
master, it always shows "Not for loan".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32610] New: Add ability to specify patron attribute as a date and apply flatpickr

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Bug ID: 32610
   Summary: Add ability to specify patron attribute as a date and
apply flatpickr
 Change sponsored?: ---
   Product: Koha
   Version: 22.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Sometimes libraries use patron extended attributes that are dates. It would be
handy if we could specify that a particular attribute is a date and then have
it become a flatpickr instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32114] Template error in OPAC search results RSS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #27 from Nick Clemens  ---
Testing notes:
1.b didn't work for me, I did:
-my $json_args = $self->_json->encode($job_args);
+#my $json_args = $self->_json->encode($job_args);
+my $json_args=$job_args;

To check the queues I just did:
rabbitmqctl list_queues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393

Nick Clemens  changed:

   What|Removed |Added

 Attachment #145207|0   |1
is obsolete||

--- Comment #26 from Nick Clemens  ---
Created attachment 145217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145217=edit
Bug 32393: Split into 2 try catch blocks

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393

Nick Clemens  changed:

   What|Removed |Added

 Attachment #144569|0   |1
is obsolete||

--- Comment #25 from Nick Clemens  ---
Created attachment 145216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145216=edit
Bug 32393: Prevent invalid job to block the job queue

I have faced a problem when testing an incorrect version of bug 32370.
The frame sent to the message broker was not a correct JSON encoded
string, and its decoding was obviously failing, exploding the worker
script.
Additionally, as we don't send a ack for this frame, the next pull will
result in processing the same message, and so in the same explosion.
No more messages can be processed!

This patch is logging the error and ack the message to the broker, in
order to not get stuck.

Test plan:
0. Dont' apply this patch
1. Enqueue a bad message
  a. Apply 32370
  b. Comment the following line in Koha::BackgroundJob::enqueue
$self->set_encoded_json_field( { data => $job_args,field => 'data' } );
  c. restart_all
  d. Use the batch item modification tool to enqueue a new job
=> Notice the error in the log
=> Note that the status of the job is "new"
=> Inspect rabbitmq queue:
% rabbitmq-plugins enable rabbitmq_management
% rabbitmqadmin get queue=koha_kohadev-long_tasks
You will notice there is a message in the "long_tasks" queue
2. Enqueue a good message
  a. Remove the change from 1.b
  b. restart_all
  c. Enqueue another job
=> Same error in the log
=> Both jobs are new
=> Inspect rabbitmq, there are 2 messages
3. Apply this patch
4. restart_all
=> Second (good) job is finished
=> rabbitmq long_tasks queue is empty

We cannot mark the first job as done, we have no idea which job it was!

QA: Note that this patch is dealing with another problem, not tested in
this test plan. If an exception is not correctly caught by the ->process
method of the job, we won't crash the worker. The job will be marked as
failed.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21472] Allow linking of $w subfields to 035 or 001+003 using the MarcOrgCode prefix

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Nick Clemens  changed:

   What|Removed |Added

 Attachment #15|0   |1
is obsolete||

--- Comment #24 from Nick Clemens  ---
Created attachment 145215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145215=edit
Bug 32370: (follow-up) Make Koha::BackgroundJob use Koha::Object::JSONFields

https://bugs.koha-community.org/show_bug.cgi?id=32371

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Nick Clemens  changed:

   What|Removed |Added

 Attachment #144377|0   |1
is obsolete||

--- Comment #23 from Nick Clemens  ---
Created attachment 145214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145214=edit
Bug 32370: Provide a generic set of tools for JSON fields

This patch introduces a new class for extending Koha::Object-based
classes so they have reusable ways to deal with JSON encoded fields.

As documented in the POD, classes can now

```perl
use base qw(Koha::Object Koha::Object::JSONFields);
```

and will have the following methods available:

* decode_json_field
* set_encoded_json_field

For convenience, the Koha::Auth::Identity::Provider class is tweaked to
make use of this, and also to prove the behavior is correct (expected
results, exceptions, encoding, etc).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Auth/Identity/Provider.t \
   t/db_dependent/api/v1/idp.t
=> SUCCESS: Identity provider related tests pass!
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run the specific tests:
  k$ prove t/db_dependent/Koha/Object/JSONField.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Nick Clemens  changed:

   What|Removed |Added

 Attachment #144376|0   |1
is obsolete||

--- Comment #22 from Nick Clemens  ---
Created attachment 145213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145213=edit
Bug 32370: Unit tests

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|tomasco...@gmail.com|agustinmoy...@theke.io
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #8 from Tomás Cohen Arazi  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

Jonathan Druart  changed:

   What|Removed |Added

URL||https://gitlab.com/joubu/Ko
   ||ha/-/commits/bug_32609

--- Comment #7 from Jonathan Druart  ---
The full patch set is on a remote branch:
https://gitlab.com/joubu/Koha/-/commits/bug_32609

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion
 CC||martin.renvoize@ptfs-europe
   ||.com, m...@kohaaloha.com,
   ||oleon...@myacpl.org,
   ||paul.dersch...@lmscloud.de,
   ||tomasco...@gmail.com

--- Comment #6 from Jonathan Druart  ---
I think this is going toward the good direction, what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #5 from Jonathan Druart  ---
And the last patch didn't make it, too large.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #4 from Jonathan Druart  ---
Created attachment 145212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145212=edit
Bug 32609: Add warning to the about page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #3 from Jonathan Druart  ---
Created attachment 145211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145211=edit
Bug 32609: Add compiled css files to gitignore

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #2 from Jonathan Druart  ---
Created attachment 145210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145210=edit
Bug 32609: Improve yarn build commands

We had:
yarn css # Build staff css
yarn css --view opac # Build OPAC css
yarn build # Nothing, was broken
yarn watch # Nothing, was broken
yarn build_js # Build JS/Vue
yarn watch_js # Watch JS/Vue

This patch is suggesting to have something more consistent:
yarn css:build  # Build CSS for OPAC and staff (dev)
yarn css:build:prod # Build CSS for OPAC and staff (prod)
yarn css:watch  # Watch CSS for OPAC and staff (dev)
yarn js:build   # Build JS (dev)
yarn js:build:prod  # Build JS (prod)
yarn js:watch   # Watch JS (dev)
yarn build  # Same as css:build and js:build (dev)
yarn build:prod # Same as css:build:prod and js:build:prod (prod)

Note that the cssnano was breaking the build function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #1 from Jonathan Druart  ---
Created attachment 145209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145209=edit
Bug 32609: Remove JS vars from gulpfile

They are not used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6532] Way to move items to another record in batches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6532

mathieu saby  changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

--- Comment #4 from mathieu saby  ---
Hi
It would be useful :
We have serials with hundreds of items, but we realized that some items should
be moved to an other record, because the serial has been given a new ISSN from
a certain date.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 29921] Allow to index in Elasticsearch all records modified since a given date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29921

solene.nga...@inlibro.com changed:

   What|Removed |Added

 CC||solene.nga...@inlibro.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from solene.nga...@inlibro.com ---
Bug 29921 - Allow to index in Elasticsearch all records modified since a given
date

130594 - Bug 29921: Allow to index in ES all records modified since a given
date

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29921: Allow to index in ES all records modified since a given
date
Using index info to reconstruct a base tree...
M   Koha/BiblioUtils.pm
Falling back to patching base and 3-way merge...
Auto-merging Koha/BiblioUtils.pm
CONFLICT (content): Merge conflict in Koha/BiblioUtils.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29921: Allow to index in ES all records modified since
a given date
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-29921-Allow-to-index-in-ES-all-records-modifie-ZvCefZ.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043

Lukas Koszyk  changed:

   What|Removed |Added

 CC||lukasz.kos...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

Nick Clemens  changed:

   What|Removed |Added

 Attachment #145173|0   |1
is obsolete||

--- Comment #35 from Nick Clemens  ---
Created attachment 145208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145208=edit
Bug 32481: Limit prefetch size for background jobs worker

This patch adds a prefetch size of 1 to the background jobs worker,
so that it fetches 1 message at a time. Without this change,
the RabbitMQ connection timeout when too many messages for slow tasks
are fetched at the same time.

To test:
0. Apply patch
1. Run background worker
2. Rapidly enqueue multiple jobs that in total will take longer
than 30 minutes to process

Bug 32481: Use correct prefetch syntax for RabbitMQ

According to https://www.rabbitmq.com/stomp.html the header to
use for managing the prefetch is "prefetch-count".

You can verify the number of delivered and unacknowledged messages
on a channel on a connection by running "rabbitmqctl list_channels"
on the RabbitMQ host. This will tell you how many messages have been
delivered and are awaiting acknowledgement

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573

--- Comment #20 from Kyle M Hall  ---
Nick asked me to post this

https://stomp.github.io/stomp-specification-1.2.html#ACK
---
ACK is used to acknowledge consumption of a message from a subscription using
client or client-individual acknowledgment. Any messages received from such a
subscription will not be considered to have been consumed until the message has
been acknowledged via an ACK.
---

The stomp protocol doesn't specify that an ACK is meant to indicate the
completion of whatever activity a message would require. An ACK is only meant
to verify that the client received the message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32473

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32473] Exclude compiled files from some git commands

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32473

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |MOVED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32609

--- Comment #8 from Jonathan Druart  ---
Replaced by bug 32609.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32609] New: Remove compiled files from src

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

Bug ID: 32609
   Summary: Remove compiled files from src
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org

We need to improve our yarn build commands to generate css and js compiled
files.

Then remove them from our codebase, and generate them when needed:

- when generating the debian packages
- when ktd is starting up
- when patches are applied on the sandbox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32114] Template error in OPAC search results RSS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #6 from Marcel de Rooy  ---
This has been backported to 21.11.x too. But it is actually not needed there.
It does not use BLOCK biblio_a_href.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

Jan Kissig  changed:

   What|Removed |Added

 CC||bibliot...@th-wildau.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32473] Exclude compiled files from some git commands

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32473

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #7 from Jonathan Druart  ---
Well, yes, ok, we all agree they should not be versioned, but that was not the
point of this bug report.
Here I wanted a quick solution to stop them bothering devs (they are always
showing as modified in git commands).

What we really want, the long term solution, is to remove all compiled files
(so main.js for the vue app, and the css files generated by yarn build) from
the git repo. But it's not as easy as... what I thought would be easy to
implement here.

So basically if it's not easy to have the quick solution, maybe better to spend
time on the long term version...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #24 from Jonathan Druart  ---
I don't understand what you are asking for guys. I've written a follow-up patch
that I think does what you want, but I don't see how it is better.

Note that now we are acking early.

Please provide your own version if you are still disagreeing with the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393

--- Comment #23 from Jonathan Druart  ---
Created attachment 145207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145207=edit
Bug 32393: Split into 2 try catch blocks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3796] Place a hold on a specific copy allows impossible items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3796

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #9 from Katrin Fischer  ---
I'll close this RESOLVED given the age of this bug, if we find a new case it
might make sense to file a new bug, just so we have a clean starting point
again. Thx for the replies!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32608] OPACFRBRizeEditions or FRBRizeEditions cause timeouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32608

Jonathan Field  changed:

   What|Removed |Added

 CC||jonathan.field@ptfs-europe.
   ||com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32608] New: OPACFRBRizeEditions or FRBRizeEditions cause timeouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32608

Bug ID: 32608
   Summary: OPACFRBRizeEditions or FRBRizeEditions cause timeouts
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.fi...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

On odd occasions, if you have OPACFRBRizeEditions or FRBRizeEditions set to
"Show" and you are using a FRBR service like ThingISBN, the full record display
will load so loading that it times out with a Plack proxy error. 

I believe this is related to the length of the API return from ThingISBN. An
example would be ISBN 9781913755201. 

https://www.librarything.com/api/thingISBN/9781913755201

This API call returns many hundreds of ISBNs and the Editions tab in Koha is
not able to load and process the response. 

Not sure how we address this, whether we add a limit to the results returned,
add some pagination or "click here for more"?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869

Pedro Amorim  changed:

   What|Removed |Added

   Assignee|pjamori...@gmail.com|pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3796] Place a hold on a specific copy allows impossible items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3796

--- Comment #8 from Chris Cormack  ---
Naw, wasn't me i just migrated it to Bugzilla. When we moved from savannah to
Bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32605] Restore some form styling from before the redesign

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #2 from Jonathan Druart  ---
I don't see any differences on the patron edit form. Where am I supposed to
look at?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/