[Koha-bugs] [Bug 18805] Currently it is impossible to apply credits against debits in patron accounts

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||21916


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916
[Bug 21916] Add ability to specify where credits are used
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21916] Add ability to specify where credits are used

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||18805


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805
[Bug 18805] Currently it is impossible to apply credits against debits in
patron accounts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21916] Add ability to specify where credits are used

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20519] Credit amount in pay.pl should use the class="credit"

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20519

Martin Renvoize  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||martin.renvoize@ptfs-europe
   ||.com
  Component|Fines and fees  |Staff interface

--- Comment #1 from Martin Renvoize  ---
I feel like this may have been resolved now?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18496] Membership renewal fee

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18496

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #6 from Martin Renvoize  ---
Still planning to submit some code for this Amit?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22872] payment_type handling is untested in Koha::Account->add_credit.

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22872

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|jacob.om...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22872] payment_type handling is untested in Koha::Account->add_credit.

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22872

--- Comment #1 from Martin Renvoize  ---
I wonder if this is still the case?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #25 from Marcel de Rooy  ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #24 from Marcel de Rooy  ---
* Commit title does not contain 'follow-up' correctly spelt -
f8e52c1569
* Commit title does not contain '(QA follow-up)' correctly spelt -
f8e52c1569
* Commit title does not contain 'follow-up' correctly spelt -
8df1eff282
* Commit title does not contain '(QA follow-up)' correctly spelt -
8df1eff282

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #146029|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 146059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146059=edit
Bug 32797: Check if fields have a value, not if true

When saving OAI set mappgins we are checking for truth, this prevents
saving subfield 0. We should check for content

To test:
1 - Go to Admin->OAI sets
2 - Create a set
3 - Define mappings for the set
4 - Attempt to save a rule on field 952 subfield 0 (withdrawn)
5 - It does not save
6 - Apply patch
7 - Try again
8 - Success!

Signed-off-by: David Nind 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32793] import_patrons.pl typo in usage

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793

Marcel de Rooy  changed:

   What|Removed |Added

Version|22.11   |master
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32793] import_patrons.pl typo in usage

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #5 from Marcel de Rooy  ---
Pedro: Please fill the Assignee field !

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32793] import_patrons.pl typo in usage

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #146028|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 146058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146058=edit
Bug 32793: import_patrons.pl typo in usage

Typo fix to prevent confusion in CLI usage

Signed-off-by: David Nind 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32793] import_patrons.pl typo in usage

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #143936|0   |1
is obsolete||

--- Comment #75 from Emmi Takkinen  ---
Created attachment 146057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146057=edit
Bug 16223: Add correct value attributes to restriction options in select
element

Restrictions weren't lift after payment because value
attributes for restrictions code were missing from
restriction select element in patron-restrictions-tab.inc.
Due this restrictions were always set as type "MANUAL".

To test:
1. Add new restriction which has "Lift after payment?" set
as Yes and fee limit as 5.
2. Create fees for a patron so they exceed fee limit e.g. 10
3. Add restriction made in step 1. for the patron
4. Pay patrons fees partially so that they go under fee limit
=> Note that patrons restriction should now be lifted.

Also prove t/db_dependent/Patron/Borrower_Debarments.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #143770|0   |1
is obsolete||

--- Comment #74 from Emmi Takkinen  ---
Created attachment 146056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146056=edit
Bug 16223: (QA follow-up) Move trigger to apply

This patch moves the del_restrictions_after_payment from before the
actual credit application call inside Koha::Account::pay to after the
application of credits to debits in Koha::Account::Line::apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #143769|0   |1
is obsolete||

--- Comment #73 from Emmi Takkinen  ---
Created attachment 146055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146055=edit
Bug 16223: (QA follow-up) Remove GetDebarments

We remove the GetDebarments routine in 31095.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #143768|0   |1
is obsolete||

--- Comment #72 from Emmi Takkinen  ---
Created attachment 146054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146054=edit
Bug 16223: (QA follow-up) Fix kohastructure bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #143767|0   |1
is obsolete||

--- Comment #71 from Emmi Takkinen  ---
Created attachment 146053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146053=edit
Bug 16223: Add ability to define liftable restrictions

Some libraries debar Patrons at the end of the year for having unpaid fines,
like in Bug 15157. Currently librarians have to manually remove this type of
debarments after Patron has paid his/her fines.

This patch adds ability to create restrictions which are lifted after
patron pays ceratain amount of fines.

To test:
1. Apply this patch.
2. Restart your services if needed.
3. Navigate to page restrictions.pl.
=> Note that table has two new colums in it, "Lift after payment?" and "Fee
limit".
4. Add new restriction which has "Lift after payment?" set
as Yes and fee limit as 5.
5. Create fees for a patron so they exceed fee limit e.g. 10
6. Add restriction made in step 2. for the patron
7. Pay patrons fees partially so that they go under fee limit
=> Note that patrons restriction should now be lifted.

Also prove t/db_dependent/Patron/Borrower_Debarments.t.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Anneli Österman 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #143766|0   |1
is obsolete||

--- Comment #70 from Emmi Takkinen  ---
Created attachment 146052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146052=edit
Bug 16223: DO NOT PUSH! Schema changes

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Anneli Österman 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #143765|0   |1
is obsolete||

--- Comment #69 from Emmi Takkinen  ---
Created attachment 146051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146051=edit
Bug 16223: Add new columns to table restriction_types

This patch adds two new columns, lift_after_payment and fee_limit,
to table restriction_types. These colums are used to control
lifting patrons restrictions after paying their fees.

To test:
1. Apply this patch.
2. Update your database via updatedatabase.pl.
=> Confirm your table restriction_types has two new columns.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Anneli Österman 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624

Suzanne  changed:

   What|Removed |Added

 CC||smhodson123ex...@yahoo.com

--- Comment #3 from Suzanne  ---
This has caused a lot of problems at our library. Patrons end up trying to pay
over and over and the fines won't go away (because they are fines from another
account) and then they have a bunch of credit on their library account and we
have to go find the other family member cards and resolve the fines manually.
Would love to see this get fixed as soon as possible. Thank you for working on
it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32809] Automatic debian/control updates (dev/unstable)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809

Mason James  changed:

   What|Removed |Added

Summary|Automatic debian/control|Automatic debian/control
   |updates (dev)   |updates (dev/unstable)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667

--- Comment #10 from Mason James  ---
(In reply to Lucas Gass from comment #7)
> Mason, this doesn't cleanly apply to 22.05.x. Can you check?

looks like its OK now...

mason@xen1:~/koha$ git reset --hard v22.05.09
HEAD is now at cb5f3095c2 Update release notes for 22.05.09 release

mason@xen1:~/g/k/m$ git bz apply 32667

Bug 32667 - Automatic debian/control updates (oldstable)

146047 - Update debian/changelog file: 22.05.09
146048 - Update debian/control file: 22.05.09 on deb9 (cb5f3095)

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Update debian/changelog file: 22.05.09
Applying: Update debian/control file: 22.05.09 on deb9 (cb5f3095)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30034] Automatic debian/control updates (testing, please ignore)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034

Mason James  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
 Resolution|FIXED   |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32809] Automatic debian/control updates (dev)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809

Mason James  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30034

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30034] Automatic debian/control updates (testing, please ignore)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034

Mason James  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32809

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668

--- Comment #10 from Mason James  ---
Created attachment 146050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146050=edit
Update debian/control file: 21.11.16 on deb9 (09f26f0d)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668

--- Comment #9 from Mason James  ---
Created attachment 146049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146049=edit
Update debian/changelog file: 21.11.16

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668

Mason James  changed:

   What|Removed |Added

 Attachment #145561|0   |1
is obsolete||
 Attachment #145562|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667

--- Comment #9 from Mason James  ---
Created attachment 146048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146048=edit
Update debian/control file: 22.05.09 on deb9 (cb5f3095)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667

--- Comment #8 from Mason James  ---
Created attachment 146047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146047=edit
Update debian/changelog file: 22.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667

Mason James  changed:

   What|Removed |Added

 Attachment #145557|0   |1
is obsolete||
 Attachment #145558|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32809] Automatic debian/control updates (dev)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809

Mason James  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32809] Automatic debian/control updates (dev)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809

Mason James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32809] Automatic debian/control updates (dev)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809

--- Comment #2 from Mason James  ---
Created attachment 146046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146046=edit
Update debian/control file: 22.12.00-3 on deb9 (1b6e9c7b)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32809] Automatic debian/control updates (dev)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809

--- Comment #1 from Mason James  ---
Created attachment 146045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146045=edit
Update debian/changelog file: 22.12.00-3

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32809] New: Automatic debian/control updates (dev)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809

Bug ID: 32809
   Summary: Automatic debian/control updates (dev)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m...@kohaaloha.com
QA Contact: testo...@bugs.koha-community.org
CC: m...@kohaaloha.com

this bug tracks automatic updates for debian/control, on 'master/main' branch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762

--- Comment #4 from quickfir...@gmail.com ---
Im not that good in MySQL, can i ask how can i locate the lines before and
after the error? the KOHA version im going to update is 20.05( i already fix
the first bug i found in my update using this (MariaDB [koha]> SELECT
language_subtag,GROUP_CONCAT(script_subtag SEPARATOR ' | '),COUNT(*) AS nb\
-> FROM language_script_mapping GROUP BY language_subtag HAVING nb > 1;
+-+-++
| language_subtag | GROUP_CONCAT(script_subtag SEPARATOR ' | ') | nb |
+-+-++
| ar  | Arab | Arab |  2 |
| he  | Hebr | Hebr |  2 |
+-+-++

And fix with :
DELETE FROM language_script_mapping WHERE language_subtag = 'ar' LIMIT 1 ;
DELETE FROM language_script_mapping WHERE language_subtag = 'he' LIMIT 1 ;)


but after this one the next error bug appears.
(ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739)

Please help me in finding the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762

--- Comment #3 from quickfir...@gmail.com ---
Im not that good in MySQL, can i ask how can i locate the lines before and
after the error? the KOHA version im going to update is 20.05( i already fix
the first bug i found in my update using this (MariaDB [koha]> SELECT
language_subtag,GROUP_CONCAT(script_subtag SEPARATOR ' | '),COUNT(*) AS nb\
-> FROM language_script_mapping GROUP BY language_subtag HAVING nb > 1;
+-+-++
| language_subtag | GROUP_CONCAT(script_subtag SEPARATOR ' | ') | nb |
+-+-++
| ar  | Arab | Arab |  2 |
| he  | Hebr | Hebr |  2 |
+-+-++

And fix with :
DELETE FROM language_script_mapping WHERE language_subtag = 'ar' LIMIT 1 ;
DELETE FROM language_script_mapping WHERE language_subtag = 'he' LIMIT 1 ;)


but after this one the next error bug appears.
(ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739)

Please help me in finding the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32743] Reindent the invoice details page

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32743] Reindent the invoice details page

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743

Lucas Gass  changed:

   What|Removed |Added

 Attachment #145886|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 146044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146044=edit
Bug 32743: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32743] Reindent the invoice details page

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743

Lucas Gass  changed:

   What|Removed |Added

 Attachment #145885|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 146043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146043=edit
Bug 32743: Reindent the invoice details page

This patch reindents the invoice template so that it has consistent
indentation. These changes should have no visible effect on the page.

To test, apply the patch and go to Acquisitions -> Invoices.

- Perform a search which will return invoice results.
- Click on an invoice to view the details.
- Everything should look normal.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30928] Add interface to statistics table

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

--- Comment #4 from Lucas Gass  ---
Created attachment 146042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146042=edit
Bug 30928: Update Accounts.pm and Recalls.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992

Lucas Gass  changed:

   What|Removed |Added

 Status|Patch doesn't apply |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992

--- Comment #15 from Lucas Gass  ---
> In marked my item lost using the 'claims returned' feature. With this change
> the item will be returned and the claim remains unresolved. Is this an issue?

In this case should we return the item and resolve the claim. Or block the
return and leave the claim?

> When you try to return an item that is lost with BlockReturnOfLostItems we
> deny the return. But we allow checking it out to a statistical patron.
> Should the latter also be blocked?

If the item is LOST and BlockReturnOfLostItems is off, ask for confirmation but
if the item is LOST and BlockReturnOfLostItems is on block the return?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25512] Add support for LDAPS

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25512

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992

Lucas Gass  changed:

   What|Removed |Added

 Attachment #128634|0   |1
is obsolete||

--- Comment #14 from Lucas Gass  ---
Created attachment 146041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146041=edit
Bug 27992: Call AddReturn when checking in localuse item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
(In reply to Jonathan Druart from comment #0)
> Anyone willing to provide a patch to make their grip on Vue and the ERM
> module?

I don't really know anything about the ERM, but one of these days I do plan to
get to grips with Vue. Probably not this patch though 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32609] Remove compiled files from src

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32806

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32609
 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32609] Remove compiled files from src

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #52 from David Cook  ---
(In reply to Martin Renvoize from comment #49)
> You can add my SO lines to the remote branch Jonathan.. I'm happy I got it
> all working for a standard install and a dev type install.. and it sounds
> like David was pretty happy with building a package, all be it he had
> expected issues due to upstream having a bad debian.control file at the
> minute (I fixed that in 22.11.x branch already.. not sure if he's got it
> building and applying to master regularly yet?)

Yeah I'm pretty happy :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698

David Nind  changed:

   What|Removed |Added

 Attachment #145881|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 146040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146040=edit
Bug 32698: Use template wrapper for serials pages tabs

This patch updates three serials templates to replace tab markup with
the use of WRAPPERs.

To test requires more data than will be found in the sample data. You
need at least one subscription with issues spanning more than one year.
I suggest creating a new subscription which starts in December, then
receive one issue from December and one in January.

Apply the patch and go to Serials.

- Perform a subscription search.
  - On the search results page there should be two tabs: "Open" and
"Closed." These tabs should work correctly.
- Open the detail view of one of your subscriptions.
  - You should see at least four tabs: "Information," "Planning,"
"Issues," and "Summary."
  - In some cases an "Acquisition details" tab will also appear. To test
this you must go to Acquisitions and add an order to a basket by
choosing "From a subscription" option.
- Click "Serial collection" in the left-hand sidebar.
  - There should be tabs for each year of subscription issues in your
collection.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32726] Authority search result display and relator terms in 22.05

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
Should there be two patches with similar titles and contents?

Maybe this should be squashed - not sure of the protocol here...

(Can confirm it works, so happy to sign off.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783

Katrin Fischer  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #2 from Katrin Fischer  ---
Hm, do we have maybe some example data for these?
I'll also add Heather for a real MARC expert.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||32808


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808
[Bug 32808] Logic in AgreementsList is flawed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32808] New: Logic in AgreementsList is flawed

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808

Bug ID: 32808
   Summary: Logic in AgreementsList is flawed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: ERM
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
CC: jonathan.druart+k...@gmail.com,
jonathan.fi...@ptfs-europe.com,
martin.renvo...@ptfs-europe.com,
pedro.amo...@ptfs-europe.com
Depends on: 32807

{{ $__("Loading") }}


[...]




{{ $__("There are no agreements defined") }}




Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807
[Bug 32807] No need to fetch all if we need to know if one exist
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32609] Remove compiled files from src

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #51 from Katrin Fischer  ---
When everything is set, could you add a little write-up to the wiki?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947
Bug 31947 depends on bug 31958, which changed state.

Bug 31958 Summary: Save button when editing a vendor should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31958

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31958] Save button when editing a vendor should be yellow

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31958

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer  ---
There were some global fixes and a lot of patches overall, I believe this was
fixed elsewhere. Thx for checking and the screenshot!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31741] Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31741
Bug 31741 depends on bug 29239, which changed state.

Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23202] Problems when adding multiple items to an order in acquisitions

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202
Bug 23202 depends on bug 29239, which changed state.

Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31645] flatpickr - update coding guidelines

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31645
Bug 31645 depends on bug 29239, which changed state.

Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730

Michael Hafen  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730

Michael Hafen  changed:

   What|Removed |Added

 Attachment #145977|0   |1
is obsolete||

--- Comment #11 from Michael Hafen  ---
Created attachment 146039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146039=edit
Bug 32730: Add Patron Lists tab to patron details and  circulation pages

(rebased 2023-02-02)

Test Plan:
1. Apply patch
2. create a patron list if there aren't any
3. search for a patron
4. observe the "Patron lists" tab showing the list that the patron is not in
5. try adding the patron to the list and removing them from the list to
   be sure the feature has full operation
6. click "Check Out" on the side bar menu to navigate to the circulation
   page for this patron
7. observe the "Patron lists" tab, and verify it operates as it did on the
   patron details page

Bug 32730: (follow-up) Minor corrections
   by Owen Leonard

This patch corrects an instance of an incorrect capital letter
("Patron Lists" -> "Patron lists") and makes minor tweaks to
indentation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32030] Electronic resource management (ERM)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||32807


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807
[Bug 32807] No need to fetch all if we need to know if one exist
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32807] New: No need to fetch all if we need to know if one exist

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807

Bug ID: 32807
   Summary: No need to fetch all if we need to know if one exist
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ERM
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
CC: jonathan.druart+k...@gmail.com,
jonathan.fi...@ptfs-europe.com,
martin.renvo...@ptfs-europe.com,
pedro.amo...@ptfs-europe.com
Depends on: 32030

In (at least) AgreementsList we are calling fetchAgreements which fetch all the
agreements, to know if we display the table (that will fetch again the first X
agreements).
We need a fetchCountAgreements (similar to fetchCountLocalPackages) instead.

I think we discussed that already somewhere else.

Anyone willing to provide a patch to make their grip on Vue and the ERM module?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771

Owen Leonard  changed:

   What|Removed |Added

 Attachment #145930|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 146038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146038=edit
Bug 32771: Standardize structure around action fieldsets in serials

This patch updates serials templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and rebuild the staff interface CSS. Go to
serials and check the following pages to confirm that changes to
form structure look correct:

- Navigate directly to /cgi-bin/koha/serials/serials-search.pl
  - Check the form on this page.
  - Perform a subscription search. On the search results page, check
the sidebar form.
- Click "Manage numbering patterns" in the left-hand sidebar menu.
  - Click "New numbering pattern" and check the forms on that page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804

--- Comment #2 from Nick Clemens  ---
Created attachment 146037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146037=edit
Bug 32804: Do not adjust biblionumber when replacing items during import

This patch adjust the item matching at import to confirm that for a duplicate
itemnumber or barcode
matches an existing item in the DB and uses the original biblionumber when
updating the item.

When ordering in a consortium the items may be moved around, duplicate biblios
added, and various matches found.
We should not allow importing of items to move them from 1 biblio to another,
but  we should allow the imports
to succeed and assume itemnumber or barcode matches are authoritative. The
responsibility for correct matching of items to biblio should fall on the
creator of the files

To test:
 1 - Be using the sample data in koha testing docker
 2 - Stage the sample file on this report
 3 - Match on KohaBiblio(999$c) / Item processing: replace
 4 - Note the biblio match is "The complete novels / Austen, Jane"
 5 - View the staged marc, note the barcode 304090 in an item
 6 - Search for that barcode
 7 - You find biblio "Five novels : complete and unabridged / Gustave Flaubert"
 8 - Import the file
 9 - Check the db:
 SELECT * FROM items WHERE biblionumber != biblioitemnumber;
10 - Note the mismatch
11 - Fix the item and set it as 'Music' type
 UPDATE items SET biblionumber = biblioitemnumber, itype='MU' WHERE
biblionumber != biblioitemnumber;
12 - Apply patch, restart all
13 - Stage and import the file with the same settings
14 - Confirm the item is modified on its original biblio (99) and that item
type is Book again
15 - Change itemnumber to avoid itemnumber match and reset type
 UPDATE items SET itype='MU', itemnumber=999 WHERE itemnumber=212;
16 - Stage and import with the same setttings
17 - Confirm the marcode match worked and item is updated to book on original
record
18 - Delete the original item
19 - Stage and import the file with the same settings
20 - The item is successfully created
21 - Stage and import, but item processing option is 'add'
22 - Confirm 1 item ignored
23 - Check the db
 SELECT * FROM import_items WHERE barcode=304090
24 - Confirm there is a line with 'error' and duplicate_barcode

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

--- Comment #20 from Emily Lamancusa  
---
I encountered an error while testing this patch with batch item updates, in
which one bad bib blocked the ES indexing update for every item in the batch.

To reproduce the error:
1. Apply patches and run ktd --es7 up
2. Set SearchEngine system preference to 'Elasticsearch'
3. perl misc/search_tools/es_indexer_daemon.pl
   (leave running in the terminal while performing subsequent steps)
4. Perform an item search for all items where Collection is Reference
5. Export the results to a barcode file (898 items)
6. Upload this file to the Batch Item Modification Tool
7. Make an edit to the Full Call Number* and click Save
8. Notice that es_indexer_daemon prints an error to the console
9. Perform a catalog search
10. Limit the results with the Collection - Reference facet
11. Note that none of the results display the updated Call Number value

*Or, as far as I can tell, any edit that will produce a change in the record
for
biblionumber 369

Error message printed to the console:

^ at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 114.
DEBUG - Update of elastic index failed with: Invalid data, cannot decode
metadata object (biblio_metadata.id=368, biblionumber=369, format=marcxml,
schema=MARC21, decoding_error=':8: parser error : PCDATA invalid Char value 31
  00aD15937
^
:9: parser error : PCDATA invalid Char value 31
  00satmrnu0
^
:9: parser error : PCDATA invalid Char value 31
  00satmrnu0
   ^
:9: parser error : PCDATA invalid Char value 31
  00satmrnu0
  ^
:9: parser error : PCDATA invalid Char value 31
  00satmrnu0
 ^
:10: parser error : PCDATA invalid Char value 31
  00ar19881981bdkldan
^
:10: parser error : PCDATA invalid Char value 31
  00ar19881981bdkldan
   ^
:10: parser error : PCDATA invalid Char value 31
  00ar19881981bdkldan
   ^')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

--- Comment #4 from Jonathan Druart  ---
Created attachment 146036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146036=edit
Bug 32806: Move routes.js to routes/erm.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

--- Comment #3 from Jonathan Druart  ---
Created attachment 146035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146035=edit
Bug 32806: Rename ERMHome and ERMMain to Home and Main

We don't need to repeat "ERM"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25395] Enumchron needs to sort numerically

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25395

Enica Davis  changed:

   What|Removed |Added

 CC||en...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804

--- Comment #1 from Nick Clemens  ---
Created attachment 146034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146034=edit
Sample file for importing with item from another record

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

--- Comment #2 from Jonathan Druart  ---
Created attachment 146033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146033=edit
Bug 32806: Rename main.js to erm.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

Jonathan Druart  changed:

   What|Removed |Added

 CC||agustin.moy...@gmail.com,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||pedro.amo...@ptfs-europe.co
   ||m, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560

David Nind  changed:

   What|Removed |Added

 Attachment #145989|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 146032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146032=edit
Bug 32560: (follow-up) Altered wording of output

Sponsored-by: Dalton McCaughey Library, Australia
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560

David Nind  changed:

   What|Removed |Added

 Attachment #145782|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 146031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146031=edit
Bug 32560: Cronjob to mark expired borrowers as lost their card

Test plan:
1. Edit a borrower to have an expiration date in the past - also make
sure they have 'Lost card' set to 'No'

2. Run the set_expired_lost.pl script:
sudo koha-shell 
cd misc/cronjobs
./set_expired_lost.pl

3. Notice you get output saying the number of borrowers are to be changed

4. View the borrower account from #1 and notice they have a 'Lost card'
value of 'Yes'

5. Run the set_expired_lost.pl script again and observe no output is
printed to the terminal - this is because all expired borrowers have
already been marked as lost.

Sponsored-by: Dalton McCaughey Library, Australia
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

--- Comment #1 from Jonathan Druart  ---
Created attachment 146030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146030=edit
Bug 32806: Move Vue files for reusability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32030] Electronic resource management (ERM)

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||32806


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806
[Bug 32806] Some Vue files need to be moved for better reusability
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] New: Some Vue files need to be moved for better reusability

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

Bug ID: 32806
   Summary: Some Vue files need to be moved for better reusability
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 32030

So far the Vue files are only used by the ERM module, but some needs to be move
in a parent directory to make them reusable by another module.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797

David Nind  changed:

   What|Removed |Added

 Attachment #146011|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 146029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146029=edit
Bug 32797: Check if fields have a value, not if true

When saving OAI set mappgins we are checking for truth, this prevents
saving subfield 0. We should check for content

To test:
1 - Go to Admin->OAI sets
2 - Create a set
3 - Define mappings for the set
4 - Attempt to save a rule on field 952 subfield 0 (withdrawn)
5 - It does not save
6 - Apply patch
7 - Try again
8 - Success!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32793] import_patrons.pl typo in usage

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes (using koha-testing-docker):

1. From the command line run: misc/import_patrons.pl --help
2. Note that in the usage section for the [--preserve_field ] option,
there is an underscore used for --preserve_field. This should be a dash (see
the full list under options).
3. Apply the patch.
4. Repeat step 1 - the usage section now has --preserve-field with a dash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32793] import_patrons.pl typo in usage

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793

David Nind  changed:

   What|Removed |Added

 Attachment #145994|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 146028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146028=edit
Bug 32793: import_patrons.pl typo in usage

Typo fix to prevent confusion in CLI usage

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32793] import_patrons.pl typo in usage

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #23 from David Nind  ---
Testing notes (using KTD):

1. Step 5: I don't have a /var/log/koha/kohadev/koha-worker-error.log, but do
have a worker-error.log and worker-output.log

2. The error was logged in worker-output.log:
[2023/02/02 19:15:09] [WARN] No job found for id=2 main::
/kohadevbox/koha/misc/background_jobs_worker.pl (114)

3. I think I had to do another restart_all after making the change to the file
for the error to appear in the log.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

David Nind  changed:

   What|Removed |Added

 Attachment #145995|0   |1
is obsolete||

--- Comment #22 from David Nind  ---
Created attachment 146027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146027=edit
Bug 32612: (QA Follow-up) Update package files

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612

David Nind  changed:

   What|Removed |Added

 Attachment #145973|0   |1
is obsolete||

--- Comment #21 from David Nind  ---
Created attachment 146026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146026=edit
Bug 32612: (QA Follow-up) Remove superfluous line

Signed-off-by: Kyle M Hall 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >