[Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 --- Comment #10 from Marcel de Rooy --- Yes, you should use ARG with DEBIAN_FRONTEND instead of ENV. Only needed when building.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32936] Tag review 'Check list' search does not display search output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32936 Alex Buckley changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32936] Tag review 'Check list' search does not display search output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32936 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32936] New: Tag review 'Check list' search does not display search output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32936 Bug ID: 32936 Summary: Tag review 'Check list' search does not display search output Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When you do a 'Check list' search on the tags review page (/cgi-bin/koha/tags/review.pl) you should get one of the following search outputs displayed: - is neither permitted nor prohibited! - is permitted! - is prohibited! However, none of these get displayed on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30991] [% ELSE %]0[% END %] will break translations if used for assigning variables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30991
--- Comment #10 from David Cook ---
Comment on attachment 136554
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136554
Bug 30991: Fix remaining instances of [% ELSE %]0[% END %] in templates
Review of attachment 136554:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=30991=136554)
-
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
@@ +1307,5 @@
> +[%- IF Koha.Preference('OverDrivePasswordRequired') -%]
> +var OD_password_required = 1;
> +[%- ELSE -%]
> +var OD_password_required = 0;
> +[%- END -%]
I know it's after the fact, but would something like the following be a viable
alternative with the translation tools?
var OD_password_required = [% IF Koha.Preference('OverDrivePasswordRequired');
'1'; ELSE; '0'; END; %];
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #13 from Alex Buckley --- Working on unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 --- Comment #9 from David Cook --- Looks like I raised the DEBIAN_FRONTEND issue in ktd 2 years ago but haven't gotten around to the PR... what is time... https://gitlab.com/koha-community/koha-testing-docker/-/issues/238 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791
--- Comment #8 from David Cook ---
On ktd, I'm noticing /var/lib/ucf/cache/:etc:perl:XML:SAX:ParserDetails.ini
ucfq --verbose /etc/perl/XML/SAX/ParserDetails.ini
Configuration filePackage Exists
Changed
/etc/perl/XML/SAX/ParserDetails.ini libxml-sax-perl Yes No
In the postinst for the libxml-sax-perl Debian package, it calls
"update-perl-sax-parsers" which runs the following:
system("ucf", "--debconf-ok", "--sum-file",
"/var/lib/libxml-sax-perl/ParserDetails.ini.md5sum", $tmpfile, $file);
unlink $tmpfile or die("unlink $tmpfile: $!");
/usr/share/doc/ucf/examples/postinst also includes an example of using a
temporary file with "ucf", so that sounds pretty good to me.
--
I've done some hacking on "update-perl-sax-parsers" and the "ucf" data files to
try to get the prompt I wanted. I used "sudo su -" to bypass
"DEBIAN_FRONTEND=noninteractive" in the ktd env vars. (In ktd images, we should
use ARG instead of ENV for setting this env var. I'll double-check whether or
not I have an existing issue or PR for that...)
Hacked files:
- /usr/bin/update-perl-sax-parsers
- /var/lib/ucf/cache/\:etc\:perl\:XML\:SAX\:ParserDetails.ini
- /var/lib/ucf/hashfile
dpkg-reconfigure libxml-sax-perl
debconf: unable to initialize frontend: Dialog
debconf: (No usable dialog-like program is installed, so the dialog based
frontend cannot be used. at /usr/share/perl5/Debconf/FrontEnd/Dialog.pm line
78.)
debconf: falling back to frontend: Readline
update-perl-sax-parsers: Registering Perl SAX parser XML::SAX::PurePerl with
priority 10...
update-perl-sax-parsers: Updating overall Perl SAX parser modules info file...
debconf: unable to initialize frontend: Dialog
debconf: (No usable dialog-like program is installed, so the dialog based
frontend cannot be used. at /usr/share/perl5/Debconf/FrontEnd/Dialog.pm line
78.)
debconf: falling back to frontend: Readline
Modified configuration file
---
A new version (/tmp/61U6DAa6Rj) of configuration file
/etc/perl/XML/SAX/ParserDetails.ini is available, but the version installed
currently has been locally modified.
1. install the package maintainer's version3. show the differences
between the versions5. show a 3-way difference between available
versions 7. start a new shell to examine the situation
2. keep the local version currently installed 4. show a side-by-side
difference between the versions 6. do a 3-way merge between available versions
What do you want to do about modified configuration file ParserDetails.ini?
--
Basically, it checks if the installed version and the ucf cached version match.
If they match, then the upstream version is installed. If they don't match,
then the sysadmin is prompted as above.
I think that sounds pretty ideal.
We could actually use that for a variety of generated Koha config files.
--
Anyway, I think I better change to a different task now, but I'm curious to
hear what people think!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31563] Numbers on claims tab not showing in translated templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #3 from Katrin Fischer --- Created attachment 146462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146462=edit Bug 31563: Make zero claims show correctly for translations A tag that only contains 0 is turned into an empty tag by the translation scripts. This turns "Claims ( 0 0 )" into "Claims ( )" in translated templates. To test: * Install an additional language (fr-FR, es-ES) and activate it in the system preferences * Look at the checkouts and details tabs in any patron account in the staff interface * Verify the claims tab shows without the zeros as described above * Apply the patch * Update the translation so the templates are recreated with the change * Verify that the 0 0 now show correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31563] Numbers on claims tab not showing in translated templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 --- Comment #7 from David Cook --- (In reply to Jonathan Druart from comment #6) > Please perltidy the new file ;) I still can't get perltidy to work correctly in ktd. It creates code that violates https://wiki.koha-community.org/wiki/Coding_Guidelines ¯\_(ツ)_/¯ That said, I see some obvious whitespace issues now outside vim... -- > Should not we sort the file to ease comparison? > > Should we deal with extra values (not existing in koha community config) or > could we simply overwrite the file? I think that would be a much heavier touch. But... I figure in 99% of cases no one customizes their log4perl file, so maybe it does make sense to just overwrite it. I'm thinking about ways where we could generate a new log4perl file, compare it with the existing instance log4perl file, and then let sysadmins decide in the same way they do for conffiles provided by the Debian package. This is an interesting read: https://wiki.debian.org/ConfigPackages It might be worth looking more into the "ucf" utility. Looking at foomatic-filters.postinst, I see the following line: ucf --three-way --debconf-ok $tempfile $FILTERCONF It seems to generate the new config, put it in a temporary file, and then test that against $FILTERCONF which is /etc/foomatic/filter.conf. In our case, we'd need to do it for every instance in "koha-list", but it could be doable. Using "ucf" could be better than trying to re-invent the wheel. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30991] [% ELSE %]0[% END %] will break translations if used for assigning variables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30991 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31563 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31563] Numbers on claims tab not showing in translated templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30991 Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31563] Numbers on claims tab not showing in translated templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #2 from Katrin Fischer --- This shows that the 0 are lost in the translation process: English: Claims (0 0) French: Réclamations () -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Katrin Fischer changed: What|Removed |Added Blocks||31056 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 [Bug 31056] Unable to 'Close and export as PDF' a basket group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31056] Unable to 'Close and export as PDF' a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Katrin Fischer changed: What|Removed |Added Depends on||13614 Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Keywords||regression Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 [Bug 13614] Replace usage of YUI on basket groups page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31056] Unable to 'Close and export as PDF' a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 --- Comment #1 from Katrin Fischer --- Created attachment 146461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146461=edit Bug 31056: Restore closeandprint function on basketgroups page Bug 13614 removed the basketgroup.js asset from the basket group page. This file includes the closeandprint function used for closing and printing the PDF from the open basket groups tab. The patch restores just this function directly in the file where it's needed as this is the only spot and it's only a few lines. The rest of basketgroup.js appears unused. To test: * Create a basket with one or more oder lines * Close the basket and check the checkbox to add it to a basket group * Reopen the basket group from the basket groups page * Verify the close and print only leads to a JS error and nothing happens * Apply patch * Repeat and verify you can now 'Close and print' from the open basket group tab * Verify all other buttons work as expected as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31056] Unable to 'Close and export as PDF' a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32935 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32935] New: Can basketgroup.js be removed?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32935 Bug ID: 32935 Summary: Can basketgroup.js be removed? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Looking into bug 31056 it seems like this file is no longer used anywhere. If confirmed, we could remove it. See also: Bug 13614: Replace usage of YUI on basket groups page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31056] Unable to 'Close and export as PDF' a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32935 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #1 from Katrin Fischer --- Created attachment 146460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146460=edit Bug 31057: Add hint to the 'To date' input on the calendar form Just adding a hint using the 'hint' class didn't work as expected here. The hint was immediately hidden. That is because of the collapsable hint text for the option at the bottom of the form using the [?] link. So I chose to use the class of the [$] to make the script a little more selective. To test: * Go to the calendar tool * Test that the [$] hide/show different help texts * Apply patch * Verify a hint now shows below the "To date" * Verify that the help texts still function as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #35 from Mason James --- > - > mason@xen1:~/g/k/m$ git log | head -1 > commit 6ac569453b4b66dac7e221a4244869ca3cee3268 > oops, typo thats... mason@xen1:~/g/k/m$ git log | head -1 commit 32258f82b5dd6a2bef3faedf06211eaf674f674c -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #34 from Mason James --- (In reply to Kyle M Hall from comment #30) > Applying: Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) > error: sha1 information is lacking or useless > (Koha/OAI/Server/Repository.pm). > error: could not build fake ancestor > Patch failed at 0001 Bug 17704: Enable ->xslt method (must use HTTP::OAI >= > 4.07) oops, the order of the 3 patches got mixed up i've uploaded them again in the correct order - mason@xen1:~/g/k/m$ git log | head -1 commit 6ac569453b4b66dac7e221a4244869ca3cee3268 mason@xen1:~/g/k/m$ git gz apply -s 17704 fatal: Resolve operation not in progress, we are not resuming. fatal: No rebase in progress? Bug 17704 - Fix OAI breakage when using HTTP::OAI 4.03+ 146457 - Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api 146458 - Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) 146459 - Bug 17704: Bump version in cpanfile Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api Applying: Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) Applying: Bug 17704: Bump version in cpanfile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What|Removed |Added Attachment #141766|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What|Removed |Added Attachment #141765|0 |1 is obsolete|| --- Comment #33 from Mason James --- Created attachment 146459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146459=edit Bug 17704: Bump version in cpanfile Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What|Removed |Added Attachment #141764|0 |1 is obsolete|| --- Comment #32 from Mason James --- Created attachment 146458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146458=edit Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) Signed-off-by: David Cook Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #31 from Mason James --- Created attachment 146457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146457=edit Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api This is my attempt to adapt the existing implementation to the new version of the HTTP::OAI lib. Currently 4.06 is released, but 4.07 should be used once released, as it contains the fix for the ->xslt method missing. Signed-off-by: David Cook Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Katrin Fischer changed: What|Removed |Added Summary|Add clarifying text to 'To |Add clarifying text to 'To |Date' |date' in the calendar tool Version|21.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31209] Add a span with class around serial enumeration/chronology data in list of checkouts for better styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209 Katrin Fischer changed: What|Removed |Added Summary|Add span with class info to |Add a span with class |enumchron data in |around serial |circulation.tt, for better |enumeration/chronology data |styling |in list of checkouts for ||better styling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31209] Add span with class info to enumchron data in circulation.tt, for better styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209 --- Comment #3 from Katrin Fischer --- Created attachment 146456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146456=edit Bug 31209: Add a span with a class for items.enumchron in the checkouts list To test: * Add or edit an item and add some info to the 'Serial Enumeration / chronology' field * Check the item out * Verify by checking the source code or using the element inspector that the title and enumchron have been merged into one string * Apply patch * Reload and verify that now the enumchron is wrapped in a span with class="item_enumeration" matching the class in the list of checkins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31209] Add span with class info to enumchron data in circulation.tt, for better styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31209] Add span with class info to enumchron data in circulation.tt, for better styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209 --- Comment #2 from Katrin Fischer --- I think we should start with the span. More columns make the screen much wider and we already have a lot that libraries will want to display. The enumchron is also placed in the same spot in the list of checkins, but it has a class there that is also used here now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31209] Add span with class info to enumchron data in circulation.tt, for better styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32159] Uncertain prices has 2 level 1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 --- Comment #1 from Katrin Fischer --- Created attachment 146455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146455=edit Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32159] Uncertain prices has 2 level 1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32159] Uncertain prices has 2 level 1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 Katrin Fischer changed: What|Removed |Added Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32566] Don't show 'ILL request logs' button, when IllLog is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32566 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32566] Don't show 'ILL request logs' button, when IllLog is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32566 --- Comment #1 from Katrin Fischer --- Created attachment 146454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146454=edit Bug 32566: Don't show "ILL request log" when IllLog is disabled When the IllLog system preference is disabled there will be no log to view and the log will always appear empty. To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: https://wiki.koha-community.org/wiki/ILL_backends 3) Go to the ILL module and add a new request 4) The "ILL request log" entry in the toolbar should be visible 5) Turn off the IllLog system preference 6) Reload the page - the option should remain visible 7) Apply patch 8) Verify the link is now no longer visible after reload 9) Re-activate the IllLog 10) Verify the option now appears -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32566] Don't show 'ILL request logs' button, when IllLog is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32566 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32799] ILLSTATUS authorized value category name is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 --- Comment #3 from Katrin Fischer --- I hope I thought of everything - please test well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32799] ILLSTATUS authorized value category name is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Katrin Fischer changed: What|Removed |Added Attachment #146452|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 146453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146453=edit Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias 12) Manage the request again and verify that the ILL request log shows the status descriptions correctly 13) Verify the description of the ILLHiddenRequestStatuses has been updated with the new authorised value category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32820] Fix cataloguing/value_builder/stocknumberAV.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32820 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind --- This works, but similar to bug 32814 when I click on the three dots it jumps to the top of the screen. It does this when using an authorized value term and just a numerical value. It didn't do this before the patch was applied (and after a flush_memcached and restart_all). How I tested 1. Add the stocknumberAV.pl plugin to 952$i 2. Add a new authorized valued category called INVENTORY 3. Add some new authorized value, for example: TEST, TEST1 4. Adding an inventory number with a prefix from the INVENTORY authorized values: 4.1 Enter "TEST" to an item for a record 4.2 Click the three dots ==> A number should be added, for example: TEST 01 4.3 Repeat for another item using the same authorized value ==> This should increment, for example: TEST 02 5. Adding a numerical inventory number: 5.1 Add a numerical number without a prefix to an item for a record, for example: 98765 5.2 Click the three dots ==> There should be no change (as expected) Description of plugin ~ This plugin is based on authorised values from INVENTORY. It is used for stocknumber computation. If no prefix is submitted, or the prefix does contain only numbers, it returns the inserted code (= keep the field unchanged). If a prefix is submitted, we look for the highest stocknumber with this prefix and return it incremented. In this case, a stocknumber has this form (e.g. "PREFIX 0009678570"): PREFIX containing letters, a space separator and 10 digits with leading 0s if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32799] ILLSTATUS authorized value category name is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 --- Comment #1 from Katrin Fischer --- Created attachment 146452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146452=edit Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32799] ILLSTATUS authorized value category name is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32799] ILLSTATUS authorized value category name is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Katrin Fischer changed: What|Removed |Added Version|22.11 |master Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32757] "Save changes" button on housebound tab should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32757 --- Comment #1 from Katrin Fischer --- Created attachment 146451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146451=edit Bug 32757: Make 'Save changes' button on housebound details yellow This changes the button to btn-primary to make it appear yellow. To test: * Enable HouseboundModule * Search for any patron * Go to their patron account * Switch to Housebound tab * Edit details * Verify 'Save changes' is not yellow * Apply patch * Verify the button has changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32757] "Save changes" button on housebound tab should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32757 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32934] SIP checkouts using "no block" flag have a calculated due rather than the specified due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #1 from Kyle M Hall --- Created attachment 146450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146450=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32934] New: SIP checkouts using "no block" flag have a calculated due rather than the specified due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Bug ID: 32934 Summary: SIP checkouts using "no block" flag have a calculated due rather than the specified due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org SIP checkouts using the "no block" flag will cause the due date to wrongly be used as the transaction date, and the due date will instead be calculated using the circulation rules. In addition, the due date field in the SIP checkout response ( AH ) will be empty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 David Nind changed: What|Removed |Added Attachment #146038|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 146449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146449=edit Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 --- Comment #5 from Andreas Roussos --- Apologies, I somehow messed up the file permissions on the Selenium unit test file just before committing (644 instead of the correct 755). This has now been fixed and I've obsoleted my previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Andreas Roussos changed: What|Removed |Added Attachment #146441|0 |1 is obsolete|| --- Comment #4 from Andreas Roussos --- Created attachment 146448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146448=edit Bug 32926: Add Selenium tests This adds a new Selenium test to automatically test the correct behaviour when expanding/collapsing System preferences sections after a System preferences search. Test plan: 1) Apply the other patch from this bug report, then run the new Selenium unit test which should pass without failures: prove -v t/db_dependent/selenium/system_preferences_search.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32746] Standardize structure around action fieldsets in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 --- Comment #5 from David Nind --- (In reply to Owen Leonard from comment #3) > This is applying okay for me today, could you try again? Must have been something I did wrong at my end. Now applies, and have signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32746] Standardize structure around action fieldsets in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 David Nind changed: What|Removed |Added Attachment #145902|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 146447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146447=edit Bug 32746: Standardize structure around action fieldsets in acquisitions This patch updates acquisitions templates so that fieldsets with the "action" class are placed outside the form's main fieldset. A couple of minor changes have been made to related CSS. To test, apply the patch and rebuild the staff interface CSS. Go to acquisitions and check the following pages to confirm that changes to form structure look correct: - Open the "Late orders" page from the left-hand sidebar menu and check the form in the sidebar. - Open the "Orders search" form in the search header and submit the form without specifying any search criteria. This should bring up a blank orders search form. - Open the "Invoices" page from the left-hand sidebar menu. Check the form in the sidebar. - Perform an invoice search which will return results. - View one of the invoices returned by your search. - On the invoice detail age, the "Save" button associated with the invoice details at the top should look correct. - There should be a box below that with the heading "Adjustments" and a link to add an adjustment. - When you click "Add an adjustment," a form should be displayed with the correct controls at the bottom. Clicking "Cancel" should hide the form. - Click the "Manage invoice files" link, and check the form on that page. - Locate a vendor and view its details. - Check the "Uncertain prices" page, linked from the menu in the left-hand sidebar. - Open the "Baskets" page from the left-hand sidebar. Click the "Add to basket" button for one of the existing baskets. - Click "From existing orders (copy)". Check that this form looks correct. - Open the "Basket groups" page from the left-hand sidebar menu. - Click "New basket group" and check that form. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32746] Standardize structure around action fieldsets in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 solene.nga...@inlibro.com changed: What|Removed |Added Attachment #144827|0 |1 is obsolete|| --- Comment #7 from solene.nga...@inlibro.com --- Created attachment 146446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146446=edit Bug 32205: Remove unnecessary syspref template params for failed OPAC auth This patch removes some unnecessary syspref template params for failed OPAC auth. The templates handle these syspref using the Koha.Preference() TT plugin function, so they're completely redundant and just make checkauth() longer than it needs to be. Test plan: 1) Apply patch 2) Enable OpacCloud, OpacBrowser, and OpacTopissue sysprefs 3) koha-plack --restart kohadev 4) Log out of Koha if you're logged in 5) Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 6) Note that you can see the Cart as well as links for the following: Browse by hierarchy, Authority search, Tag cloud, Subject cloud, Most popular Signed-off-by: Fridolin Somers Signed-off-by: Solene Ngamga -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #11 from Andrew Fuerste-Henry --- (In reply to Kyle M Hall from comment #10) > > I've just tested this again with the same result. The item with barcode > > 304090 has been deleted but I get an import_error of "duplicate > > barcode' when importing the sample batch from this bug set to match on > > biblionumber and replace items. No new item is created. Having read through > > the test plan several times, I'm stumped. > > I retested and I'm failing on step 20. Is that where you are having your > issue as well? Yes, at step 20 I don't get an item created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #10 from Kyle M Hall --- > I've just tested this again with the same result. The item with barcode > 304090 has been deleted but I get an import_error of "duplicate > barcode' when importing the sample batch from this bug set to match on > biblionumber and replace items. No new item is created. Having read through > the test plan several times, I'm stumped. I retested and I'm failing on step 20. Is that where you are having your issue as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #1 from Caroline Cyr La Rose --- Not sure if it is managed in the same place, but the Yes/No in the agreement table, once the agreement is created, is also untranslatable, as well as the filtering drop-down in the table header. https://snipboard.io/QyfStJ.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #18 from Martin Renvoize --- (In reply to Katrin Fischer from comment #7) > it would also simplify your patch :) Not in the slightest.. it makes it significantly more involved and has a much higher risk of regression. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |koha-b...@lists.koha-commun |.com|ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #17 from Martin Renvoize --- Created attachment 146445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146445=edit Bug 29822: Use the modal This looks silly to me... and it still requires changes to koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc and a database update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds the release notes||ability to redirect users ||back to where they were ||when using the modal type ||logins in place of an ||action that requires login ||on the OPAC. || ||Example: On ||the OPAC detail page you ||can add comments if logged ||in. Prior to this patch, ||clicking the link to add a ||comment prior to being ||logged in would expose the ||login modal and then ||re-direct you to your OPAC ||user page, and thus lose ||the context of your action. || With this enhancement, you ||are redirected back to the ||record you were looking at ||and can then post your ||comment. Version(s)|This patch adds the ability |23.05.00 released in|to redirect users back to | |where they were when using | |the modal type logins in| |place of an action that | |requires login on the OPAC. | | | |Example: On the | |opac-detail page one can| |add comments if logged in. | |Prior to this | |patch,23.05.00, clicking| |the link to add a comment | |prior to being logged in| |would expose the login | |modal and then re-direct| |you to your opac-user page | |and thus loose the context | |of your action. With this | |patch you are redirected| |back to the biblio you were | |looking at so you can post | |your comment. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32933] Use val() instead of attr("value") when getting field values with jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32933
--- Comment #1 from Owen Leonard ---
Created attachment 146444
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146444=edit
Bug 32933: Use val() instead of attr("value") when getting field values with
jQuery
This patch replaces instances in Koha's templates where "attr('value')" is
used to get the value of a form field, using "val()" instead. This
ensures that we get the current value of the field, not just the
value of the field when the page first loaded.
To test, apply the patch and test the following pages:
- Tools -> Tags. Use the "Check lists" form in the right-hand sidebar
to test the approval status of some approved and rejected tags. It
should correctly respond with the tag's status.
- Cataloging -> Label creator.
- New -> Printer profile. Each offset and creep field should correctly
reflect the selected value in the "Units" dropdown. Changing the
dropdown should make the units change accordingly.
- New -> Label template. Perform the same tests as above.
- Tools -> Patron card creator.
- New -> Layout. If necessary, check the "Field 1" checkbox. The
units should be displayed correctly and change as you change the
"Units" dropdown.
- New -> Printer profile,
- New -> Card template: Perform the same tests as above.
- Lists -> List contents.
- Check that the "Add to" dropdown menu works for adding selected
titles to a cart or another list.
- Back record modification. Submit a batch of records for modification
and go to Administration -> Manage jobs.
- View the details of the job you just submitted.
- Confirm that the "Add modified records to the following list"
dropdown works correctly.
- Cataloging -> Find a bibliographic record -> Edit items.
- Confirm that clicking a cell in the table of existing items
triggers the "Edit item/Delete item" menu, and that these links
work correctly.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32933] Use val() instead of attr("value") when getting field values with jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32933 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32933] New: Use val() instead of attr("value") when getting field values with jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32933
Bug ID: 32933
Summary: Use val() instead of attr("value") when getting field
values with jQuery
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: minor
Priority: P5 - low
Component: Templates
Assignee: oleon...@myacpl.org
Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
This issue came up because I noticed that the tag review page's "test" feature
wasn't working. Clicking the test button didn't trigger any message about the
tag's approval status.
$(input).attr("value") is getting the initial contents of the "value" attribute
when the DOM initially loads. In the case of the tags page, this will always be
an empty string.
Using $(input).val() gets the current value of the field.
I think other instances of this code aren't buggy in the same way, but I think
it's worth updating all of them for consistency.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must be an enum
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must be an enum
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #8 from Jonathan Druart --- Created attachment 146443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146443=edit Bug 32923: needed? I think we need that, see later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must be an enum
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923
--- Comment #7 from Jonathan Druart ---
Tomas, Martin, I am seeing something weird with x-koha-embed here.
With a request with the following x-koha-header:
package_agreements,package_agreements.agreement,resources+count,vendor
I am correctly seeing it it Koha/REST/Plugin/Query.pm (in stash_embed)
However, I am getting the header later, using
$c->req->headers->header('x-koha-embed') and I am seeing "package_agreements"
only (!)
I guess I could use $c->stash('koha.embed') instead, but then it's no longer a
string an I need to change the logic in several places.
Is that expected?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop changed: What|Removed |Added Attachment #146439|0 |1 is obsolete|| --- Comment #2 from Matt Blenkinsop --- Created attachment 146442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146442=edit Bug_32932: Update router to use object references This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 --- Comment #3 from Andreas Roussos --- Created attachment 146441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146441=edit Bug 32926: Add Selenium tests This adds a new Selenium test to automatically test the correct behaviour when expanding/collapsing System preferences sections after a System preferences search. Test plan: 1) Apply the other patch from this bug report, then run the new Selenium unit test which should pass without failures: prove -v t/db_dependent/selenium/system_preferences_search.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 --- Comment #2 from Andreas Roussos --- Created attachment 146440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146440=edit Bug 32926: Assign unique ids to elements If you perform a System preferences search for a common word such as "type", you lose the ability to expand or collapse some sections. In particular, you cannot expand/collapse the sections with names that appear more than once in the results page. All sections except the first one in each group of duplicates are affected by this. See https://imgur.com/a/NSslIcV for a demo. This patch fixes that by prepending the ids with the top-level System preference section name to make them unique. Test plan: 1) Perform a System preferences search for a common word such as "type" or "log". In the results page, the "Policy" section will appear more than once. Now try to expand/collapse any "Policy" section but the first one. It won't work, only the first "Policy" section is toggled. 2) Apply this patch and refresh the page. 3) This time you should be able to expand or collapse all of the available system preference sections. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Andreas Roussos changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #1 from Matt Blenkinsop --- Created attachment 146439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146439=edit Bug_32932: Update router to use object references This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32918] ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 --- Comment #3 from Caroline Cyr La Rose --- I had originally made the authorized values themselves translatable since they are English words, and for historical and legal reasons, that doesn't always fly here. Unfortunately, some of them trigger actions (like the 'closed' ERM_AGREEMENT_STATUS makes the 'Closure reason' drop down active in agreements), so we can't translate them... at least not all of them. Since I'm not sure which ones trigger actions, I removed all of them from the translations. Now, only the descriptions are translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32918] ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918
Caroline Cyr La Rose changed:
What|Removed |Added
Attachment #146413|0 |1
is obsolete||
--- Comment #2 from Caroline Cyr La Rose ---
Created attachment 146438
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146438=edit
Bug 32918: ERM authorized values should be in
installer/data/mysql/en/mandatory/auth_values.yml
This patch moves the authorized value insertions for ERM categories into
the language-specific auth_values.yml file.
To test:
1. Count the number of authorized values in the mandatory categories
select count(*) from authorised_values where category in ('YES_NO',
'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS',
'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY',
'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS',
'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION',
'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE',
'COUNTRY', 'LANG', 'qualif');
--> There should be 929
2. Delete the authorized values from these categories
delete from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE',
'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON',
'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE',
'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS',
'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE',
'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG',
'qualif');
3. Apply patch
4. Load the mandatory authorized values
./misc/load_yaml.pl --file installer/data/mysql/en/mandatory/auth_values.yml
--load
5. Redo step 1
--> There should be the same number (929)
6. Update translations
cd misc/translator
./translate update xx-XX
7. Search the po/xx-XX-installer.po file for any of the loaded
authorized values
For example,
grep "Abstract and index" po/xx-XX-installer.po
--> descriptions should be translatable
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32932] New: Re-structure Vue router-links to use "name" instead of urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Bug ID: 32932 Summary: Re-structure Vue router-links to use "name" instead of urls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+k...@gmail.com Reporter: matt.blenkin...@ptfs-europe.com CC: jonathan.druart+k...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, pedro.amo...@ptfs-europe.com Currently the Vue router is set up with urls assigned to components with no "name" property. This means that in the components, where a router-link tag is used the full URL has been written out again. In the event that a url needs to be changed in the router, the url will also have to be changed in every component that uses that route. By using the "name" property we can avoid this and make maintenance of the router much more efficient. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32931] New: ERM - (is perpetual) Yes / No options untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Bug ID: 32931 Summary: ERM - (is perpetual) Yes / No options untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr The Yes and No radio button options for the "Is perpetual" field when adding an agreement are not translatable (at least, I didn't find the correct strings) To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No The only "Yes" that I found in fr-CA-messages-js.po is in holds. #: koha-tmpl/intranet-tmpl/prog/js/holds.js:241 msgid "Yes" msgstr "Oui" An option would be to change this to a checkbox, since the options are 0 or 1... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32930] New: No manual entry for "SMTP Servers"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32930 Bug ID: 32930 Summary: No manual entry for "SMTP Servers" Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: m...@adminkuhn.ch QA Contact: testo...@bugs.koha-community.org In Koha menu "Administration > Additional parameters" there is an entry named "SMTP servers". The Koha 22.11 manual misses to describe this entry. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32928] Filters missing in SQL builder on Orders::filter_by_active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32928 --- Comment #1 from Thibaud Guillot --- Created attachment 146437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146437=edit Bug 32928: Add filters on Orders::filter_by_active To have the same behavior than before 21.xx.xx filters must be added to the filter_by_active function. If not you can have on your list, some orders that can be cancelled, or orders with quantity totally received. Requirements: Have instances with different Koha version (20.11 VS Master for example) Test plan: 1) Apply this patch on Master Just have the same database with pending orders, and see differences between both instances on parcel.pl receptions. You will see that total of orders will be not the same -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32928] Filters missing in SQL builder on Orders::filter_by_active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32928 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511 --- Comment #26 from Blou --- Hello Katrin, Yes, please mark as INVALID. I came to the same conclusion, probably an update that failed when we moved to 21.05 (I see the change in 20.06 pile...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32609] Remove compiled files from src
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #57 from Martin Renvoize --- I've reviewed the joined misc4dev merge request too now.. I reckon we're PQA here so marking as such. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32929] New: ERM - 'Submit' button untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32929 Bug ID: 32929 Summary: ERM - 'Submit' button untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Hopefully, this is a "me" problem, but for some reason, I can't get the "Submit" button in the ERM module to translate. To get to the button: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> "Submit" button is at the bottom of the form I found this string in the xx-XX-messages-js.po file (example in fr-CA, but I also tried in es-ES and de-DE) #: koha-tmpl/intranet-tmpl/prog/js/vue/dist/main.js:2 msgid "Submit" msgstr "Valider" I did ./translate install xx-XX but the button stays in English -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32925] Display loading info when a form is submitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 --- Comment #5 from Jonathan Druart --- I am quite happy with this second patch. It could then be moved to 'fetch' and apply to all POST request without the need to modify every components. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32925] Display loading info when a form is submitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 --- Comment #4 from Jonathan Druart --- Created attachment 146436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146436=edit Bug 32925: Use a new state for this message The previous patch didn't work, there is a validation step that make the form non-accessible after it's greyed out. This patch is using a new state is_submitting, like the other messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #16 from Martin Renvoize --- This preference does not affect the attributes in any way.. I've varified that in the code. Attributes are handled as their own case in the main patron search page.. always searched. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32928] Filters missing in SQL builder on Orders::filter_by_active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32928 Thibaud Guillot changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32928] New: Filters missing in SQL builder on Orders::filter_by_active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32928 Bug ID: 32928 Summary: Filters missing in SQL builder on Orders::filter_by_active Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guil...@biblibre.com QA Contact: testo...@bugs.koha-community.org Since version 21.xx.xx there has been a change in the way to retrieve the data of the orders to receive. The table is built from a call to the API and then the data can be filtered. Bug_20212 has integrated this change. This is a good thing but two filters are missing on the query construction in the Koha::Acquisition::Orders::filter_by_active function Here is the query in version 20.11 : SELECT aqbasket.basketno, borrowers.surname, borrowers.firstname, biblio.*, biblioitems.isbn, biblioitems.biblioitemnumber, biblioitems.publishercode, biblioitems.publicationyear, aqbasket.authorisedby, aqbasket.booksellerid, aqbasket.closedate, aqbasket.creationdate, aqbasket.basketname, aqbasketgroups.id as basketgroupid, aqbasketgroups.name as basketgroupname, aqorders.* FROM aqorders LEFT JOIN aqbasket ON aqorders.basketno = aqbasket.basketno LEFT JOIN aqbasketgroups ON aqbasket.basketgroupid = aqbasketgroups.id LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber LEFT JOIN biblio ON aqorders.biblionumber=biblio.biblionumber LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber WHERE (datecancellationprinted is NULL) AND ( ( aqbasket.is_standing AND aqorders.orderstatus IN ( "new", "ordered", "partial" ) ) OR ( ( quantity > quantityreceived OR quantityreceived is NULL ) AND aqorders.orderstatus IN ( "ordered", "partial" ) ) ) AND aqbasket.booksellerid = ? ORDER BY aqbasket.basketno'; The condition "datecancellationprinted is NULL" is missing as well as the quantity control to display the results only if there are still quantities to receive. And so the result on the same database between the different versions can be very different! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 Pedro Amorim changed: What|Removed |Added Attachment #146433|0 |1 is obsolete|| --- Comment #5 from Pedro Amorim --- Created attachment 146435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146435=edit Bug 32924: (follow-up) Add left margin to 'Show mine only' label Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 Pedro Amorim changed: What|Removed |Added Attachment #146427|0 |1 is obsolete|| --- Comment #4 from Pedro Amorim --- Created attachment 146434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146434=edit Bug 32924: Add the ability to filter agreement by logged in user This patch adds a new filter checkbox at the top of the agreement list "Show only mine" that will display agreements linked with the logged in user. Test plan: Create several agreements, add your current logged in user to some of them On the agreement list view us the new checkbox to filter the agreements and see those where you are involved in. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 --- Comment #3 from Pedro Amorim --- Created attachment 146433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146433=edit Bug 32924: (follow-up) Add left margin to 'Show mine only' label -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
