[Koha-bugs] [Bug 31049] Add tool to set/reduce local cover image size and quality, interactively and in batch.

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31049

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

--- Comment #31 from Jonathan Druart  ---
Created attachment 147537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147537=edit
Bug 27634: Hide "Register here" links

Make sure the pref is filled with a valid patron's category to display
the "register" link

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

--- Comment #30 from Jonathan Druart  ---
Created attachment 147536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147536=edit
Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

--- Comment #29 from Jonathan Druart  ---
Created attachment 147535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147535=edit
Bug 27634: Add a warning to the about page if
PatronSelfRegistrationDefaultCategory not set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

--- Comment #28 from Jonathan Druart  ---
Created attachment 147534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147534=edit
Bug 27634: Force include of dateexpiry

Otherwise we see a "Date expiry" entry in the form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

--- Comment #27 from Jonathan Druart  ---
Created attachment 147533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147533=edit
Bug 27634: Add the ability to exclude fields from "modal" sysprefs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

--- Comment #26 from Jonathan Druart  ---
Created attachment 147532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147532=edit
Bug 27634: Force include categorycode to
PatronSelfRegistrationBorrowerUnwantedField

We should always use the category defined in
PatronSelfRegistrationDefaultCategory.
This could be discussed however.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #145599|0   |1
is obsolete||
 Attachment #145600|0   |1
is obsolete||
 Attachment #145601|0   |1
is obsolete||
 Attachment #145602|0   |1
is obsolete||
 Attachment #145603|0   |1
is obsolete||
 Attachment #145604|0   |1
is obsolete||
 Attachment #145922|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart  ---
Created attachment 147531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147531=edit
Bug 27634: Turn off patron self-registration if no default category is set

If there is no default category defined in
PatronSelfRegistrationDefaultCategory the full feature must be displayed.

We already hide the link from the OPAC main page, but the form is still
accessible.

Test plan (for the whole patch set):
1. Turn on PatronSelfRegistration
2. Don't set PatronSelfRegistrationDefaultCategory
3. Go to the OPAC main page and confirm that the "Register here" link is
not displayed
4. Hit opac-memberentry.pl and confirm that you are redirected to the
OPAC main page
5. Go to the about page and confirm that you see a warning in the
"System information" tab
6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's
category
7. Repeat 3, 4, 5
8. Set PatronSelfRegistrationDefaultCategory to a valid patron's
category
9. Self-register a patron and confirm it works as expected
10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that
you cannot remove dateexpiry and categorycode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33096] DefaultHoldExpirationdate does not show date when placing hold

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33096

--- Comment #1 from Emmi Takkinen  ---
(In reply to Christopher Brannon from comment #0)
> The preference DefaultHoldExpirationdate, when set, doesn't show the date in
> the expiration field while placing the hold, in either the staff side or the
> opac side.  So you don't know there is a default until after the hold is
> placed.
> 
> This is extremely counter productive, because you can't change the
> expiration date on a hold.  You then have to cancel the hold, and replace it
> and put the date you want in place.
> 
I assume you mean that expiration date can't be changed in OPAC? Because
changing it from the staff side seems to be working fine.

So from OPAC point of view this sure isn't ideal situation. To fix this we
could:
1) show default expiration date to the field while placing hold
2) allow patrons to change expiration date via OPAC (this should probably be a
syspref)
3) do both.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31471] Duplicate check in cataloguing fails with Elasticsearch for records with multiple ISBN

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31471

Michaela Sieber  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Michaela Sieber  ---
Tested with LoC Control No.


1.) 16509983 (100 countries, 5000 ideas), ISBN: 9781426207587 (softcover :
alk. paper) :; 1426207581 (softcover : alk. paper)
and  
2.) 19483458 (Cyberdoc), ISBN: 9780985248314 (cloth); 9780985248321 (pbk.)


Thanks for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31471] Duplicate check in cataloguing fails with Elasticsearch for records with multiple ISBN

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31471

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #147333|0   |1
is obsolete||

--- Comment #4 from Biblibre Sandboxes  ---
Created attachment 147530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147530=edit
Bug 31471: Send multiple ISBN with 'OR' for FindDuplicate

When a record has multiple ISBNs the database stores them seperated by a
pipe

Zebra interprets a string like "isbn:1600213510 | 9781600213519" as an 'OR'
search, but for
Elasticsearch we need to explicitly send "OR" - and Zebra support this
as well

To test:
1 - Make sure you are using Elasticsearch
2 - Cataloging->Add a new record from Z3950
3 - Choose target: LOC
4 - Search for: Control number: 14455023
5 - Import and save
6 - Search for the record again
7 - Import and save - duplicate check isn't been triggered
8 - Apply patch
9 - restart_all
10 - repeat 2-7
11 - this time you should get a duplicate notification
12 - Sitch SearchEngine syspref to 'Zebra'
13 - repeat 2-7
14 - Ensure you still get duplicate notification

Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33096] DefaultHoldExpirationdate does not show date when placing hold

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33096

Emmi Takkinen  changed:

   What|Removed |Added

 CC||emmi.takki...@koha-suomi.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33100] New: Authority linking doesn't work for bib headings ending in two or more punctuation characters

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100

Bug ID: 33100
   Summary: Authority linking doesn't work for bib headings ending
in two or more punctuation characters
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: p...@chetcolibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl, n...@bywatersolutions.com

At the time of bug 24094 this apparently worked, but now in both my production
22.05 instance and a master sandbox, while Doe, John A. in a bib record will
link to Doe, John A. in an authority record, Doe, John A., (as it will be in
virtually every RDA record, since you are supposed to have a $e relator for
personal names, and you are supposed to have a comma before the $e) will not
link to the Doe, John A. authority record.

That's a barely noticeable thing unless you actually track your unlinked
authorites, but it's very noticeable if you use AutoCreateAuthorites and the
first-match linker. In that case, every time you add a new Box, C. J. item, the
linker strips off the comma from $aBox, C. J.,$eauthor., declares that your
existing authority record for Box, C. J. doesn't match, and
AutoCreateAuthorities also strips off the comma, creates a new duplicate Box,
C. J. record, and then does it again the next time you save the record, and
then does it again when you update the authority record for the series heading
because it changed, and that triggers relinking the whole bib record, then
again any time you edit the record or any authority linked to it.

Two maybe-interesting exceptions, from when I started out looking at all the
punctuation that _get_search_form in C4/Heading/MARC21.pm trims from the end of
a bib heading to attempt to make it searchable, and the not-quite-the-same
things that AutoCreateAuthorities strips before creating what it hopes will be
an authority heading that will actually still match during the next linking:

Doe, John A-- will autocreate an authority record which is exactly that,
because autocreate's set of punctuation lack only that one character from
_get_search_heading's regex, but, even though _get_search_heading will turn
that into a search for Doe, John A- during a relink, that will match the --
authority form. The same is true for other characters: if you edit the
authority record for Doe, John A. and make it Doe, John A., then that will
match a bib record with Doe, John A., and will also match a bib record with
Doe, John A.! or Doe, John A./ or Doe, John A.^ which isn't even in the set of
stripped punctuation so the search should be for Doe, John A.^ and that still
matches Doe, John A.,

Doe, John A=, will match an authority record for Doe, John A with no
punctuation, though there's no similar magic for Doe, John,= where
_get_search_heading has stripped off the equal sign, making me think at least
that bit of magic is happening in the search engine or the query prep.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33099] New: Add missing MARC21 Match authority mappings so "Search all headings" search works

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33099

Bug ID: 33099
   Summary: Add missing MARC21 Match authority mappings so "Search
all headings" search works
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: p...@chetcolibrary.org
CC: n...@bywatersolutions.com

The authorities search option to "Search all headings" is actually the most
useful choice, but with ElasticSearch it only really works for personal names
and meeting names, because while
https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=admin/searchengine/elasticsearch/mappings.yaml;h=e892f9126c2b080fb00a931207f907917128c003;hb=HEAD#l264
maps 4xx and 5xx see and see-also headings for all types of authorities for the
Match index, it only maps 100 and 111, missing 110, 130, 148, 150, 151 and 155
for main headings.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

--- Comment #6 from Victor Grousset/tuxayo  ---
Works, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #145795|0   |1
is obsolete||

--- Comment #5 from Victor Grousset/tuxayo  ---
Created attachment 147529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147529=edit
Bug 32129: Use patron category when checking if item can fill recall

This patch uses the patron category of the patron who requested the most
relevant recall to check for more specific circulation rules relating to
recalls. This ensures that patrons who are allowed to place recalls are
able to fill their recalls, especially when recalls are not generally
available for all patron categories.

To test:
1) Go to Administration -> System preferences and enable UseRecalls
2) Go to Administration -> Circulation and fines rules and set a general
All/All rule and a Category A/Itemtype A rule. All values can be set
however you like except for these recalls rules:

All/All rule:
Recalls allowed: 0
Recalls per record: 0
On shelf recalls allowed: if any unavailable

Category A/Itemtype A rule:
Recalls allowed: 5
Recalls per record: 5
On shelf recalls allowed: if any unavailable

3) Find an item of Itemtype A. Check it out to Patron A (any category).
4) Log into the OPAC as Patron B (of Category A). Find the item and
place a recall on the item.
5) Back in the staff interface, check in the item. This should trigger
the recalls process so you can allocate the item to Patron B's recall,
however the pop-up box to confirm the recall does not show. This is the
bug.

6) Apply the patch and restart services

7) Check in the item again. Confirm the pop-up box to confirm the recall
shows and you are able to allocate the item to Patron B's recall.
8) Confirm tests pass t/db_dependent/Koha/Item.t

Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #140647|0   |1
is obsolete||

--- Comment #61 from Aleisha Amohia  ---
Created attachment 147528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147528=edit
Bug 24194: (follow-up) Throw an error if expiration date used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #140646|0   |1
is obsolete||

--- Comment #60 from Aleisha Amohia  ---
Created attachment 147527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147527=edit
Bug 24194: Add ReserveExpiration system preference to disable expiration date
options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm you can
see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and confirm you
can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user.
Check it in and set the reserve as waiting. Notice that an expiration date has
now been generated for this reserve.
5) Attempt to check out the item you reserved to some other borrower. Revert
waiting status. Notice that the expiration date that was generated remains.
6) Go to Administration -> system preferences and set ReserveExpiration system
preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration date
field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration date field
disappears.
9) Place another reserve. Check it in and set the reserve as waiting. Notice
that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower. Revert
waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
12) Go to Admin -> System preferences and search for ReserveExpiration.
Confirm related system preferences have a reference to ReserveExpiration
and the links all work
13) Text the cancel_expired_holds.pl cronjob and confirm it works with
ReserveExpiration enabled, and does nothing when disabled
14) Confirm all instances where hold expiration dates are set or
referenced are shown or hidden correctly, depending on
ReserveExpiration

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.
- Circulation -> Holds awaiting pickup

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098

--- Comment #1 from Aleisha Amohia  ---
Created attachment 147526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147526=edit
Bug 33098: Revert suggestion status when orders are cancelled

This enhancement will revert the status of a suggestion from ORDERED to
ACCEPTED when an order made from a suggestion is cancelled.

To test:
1. Log into the OPAC and go to purchase suggestions
2. Add a new purchase suggestion
3. Log into the staff interface. The suggestion will show on the home
page
4. Select the suggestion and mark it as Accepted
5. Go to Acquisitions. Find or create a basket
6. Add an order to the basket from a suggestion
7. You'll be redirected to the suggestions page. Click the order button
next to your suggestion
8. Fill out the order details as normal and confirm the order.
9. In a new tab, go to the suggestions management page and confirm the
suggestion now shows as ORDERED.
10. In the other tab with your basket, cancel the order you just made
from the suggestion.
11. Refresh the suggestions management tab. Confirm the suggestion now
shows as ACCEPTED.
12. Confirm tests pass t/db_dependent/Koha/Acquisition/Order.t

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33094] Change OPAC view link in search results for Suppressed bibs

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33094

--- Comment #1 from Katrin Fischer  ---
I wonder if it should depend on OpacSuppressionByIPRange - you might still be
able to see the record if within an allowed IP range.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33098] New: Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098

Bug ID: 33098
   Summary: Revert suggestion status to 'Accepted' when orders
made from a suggestion are cancelled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Currently when adding an order to a basket from an accepted suggestion, the
status of the suggestion goes from 'accepted' to 'ordered'.

If the order is then cancelled, the suggestion remains as 'ordered'. The status
should be reverted to 'accepted' as it is no longer on order.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Christopher Brannon  changed:

   What|Removed |Added

 Blocks||33097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33097
[Bug 33097] Is message for staff or OPAC on circulation.pl?
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33097] Is message for staff or OPAC on circulation.pl?

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33097

Christopher Brannon  changed:

   What|Removed |Added

 Depends on||12029


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
[Bug 12029] Patrons should be able to delete their patron messages
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33097] New: Is message for staff or OPAC on circulation.pl?

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33097

Bug ID: 33097
   Summary: Is message for staff or OPAC on circulation.pl?
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When looking at patron messages (not notices) on circulation.pl, it is
impossible to tell if a message was posted to staff or to the OPAC.  They
display differently, with one red and the other not.  But that doesn't tell the
staff member which is which.  We should have some kind of indicator to
differentiate the two types.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Christopher Brannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #66 from Christopher Brannon  ---
Works as describe, and totally awesome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #147521|0   |1
is obsolete||

--- Comment #65 from Biblibre Sandboxes  ---
Created attachment 147525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147525=edit
Bug 12029: Ability for patrons to dismiss OPAC messages

This enhancement adds the ability for patrons to dismiss an OPAC
message, marking it as read to remove it from their summary page.

To test:
1) Update database and restart services
2) Log into the staff interface and go to your patron account
3) Click the Add message button
4) Add a message for the OPAC and Save
5) Log into the OPAC. Note there is a message on the homepage saying you
have a message. Go to your user summary and confirm the message
displays.
6) Click the button to dismiss the message. A confirmation box should
pop up - hitting Cancel should stop the action.
7) Dismiss the message again and this time Confirm. Make sure the
message is gone from the OPAC user summary and from the homepage.
8) Confirm tests pass t/db_dependent/Koha/Patron/Messages.t
9) Create a few more messages for the OPAC
10) Log into the OPAC and dismiss one of the messages
11) Confirm the count of unread messages on the OPAC home page is
correct

Sponsored-by: Koha-US
Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146708|0   |1
is obsolete||

--- Comment #64 from Biblibre Sandboxes  ---
Created attachment 147524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147524=edit
Bug 12029: Tests

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146707|0   |1
is obsolete||

--- Comment #63 from Biblibre Sandboxes  ---
Created attachment 147523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147523=edit
Bug 12029: Schema updates

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146706|0   |1
is obsolete||

--- Comment #62 from Biblibre Sandboxes  ---
Created attachment 147522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147522=edit
Bug 12029: Adding messages.patron_read_date column

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32729] Deleting an item removes the itemnumber from old_issues when it probably should not

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32729

Lucas Gass  changed:

   What|Removed |Added

Version|22.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

Aleisha Amohia  changed:

   What|Removed |Added

 CC|alei...@catalyst.net.nz |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #146709|0   |1
is obsolete||

--- Comment #61 from Aleisha Amohia  ---
Created attachment 147521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147521=edit
Bug 12029: Ability for patrons to dismiss OPAC messages

This enhancement adds the ability for patrons to dismiss an OPAC
message, marking it as read to remove it from their summary page.

To test:
1) Update database and restart services
2) Log into the staff interface and go to your patron account
3) Click the Add message button
4) Add a message for the OPAC and Save
5) Log into the OPAC. Note there is a message on the homepage saying you
have a message. Go to your user summary and confirm the message
displays.
6) Click the button to dismiss the message. A confirmation box should
pop up - hitting Cancel should stop the action.
7) Dismiss the message again and this time Confirm. Make sure the
message is gone from the OPAC user summary and from the homepage.
8) Confirm tests pass t/db_dependent/Koha/Patron/Messages.t
9) Create a few more messages for the OPAC
10) Log into the OPAC and dismiss one of the messages
11) Confirm the count of unread messages on the OPAC home page is
correct

Sponsored-by: Koha-US

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33096] New: DefaultHoldExpirationdate does not show date when placing hold

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33096

Bug ID: 33096
   Summary: DefaultHoldExpirationdate does not show date when
placing hold
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The preference DefaultHoldExpirationdate, when set, doesn't show the date in
the expiration field while placing the hold, in either the staff side or the
opac side.  So you don't know there is a default until after the hold is
placed.

This is extremely counter productive, because you can't change the expiration
date on a hold.  You then have to cancel the hold, and replace it and put the
date you want in place.

This should be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase'

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093

Janusz Kaczmarek  changed:

   What|Removed |Added

 Attachment #147519|0   |1
is obsolete||

--- Comment #2 from Janusz Kaczmarek  ---
Created attachment 147520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147520=edit
Bug 33093 - (Bug 27546 follow-up) With ES searching within results does not
work for 'Keyword' and 'Keyword as phrase'

The feature of searching within search results in librarian
interface has some problems with with elastic: 'Keyword' and
'Keyword as phrase' searches give no results.  This is because
elastic is unaware of the search field 'kw' and 'kw' is not
transformed nor removed for limits.

Test plan
=
1. Have a Koha instance with reasonable number of biblio records
1. Set SearchEngine to Elasticsearch
3. In librarian interface, perform a search that would give
   you a list of results
4. With the new search box 'Search within results', having 'Keyword'
   and 'Keyword as phrase' active, try to perform a search within
   search results with a term that should give you some results
5. You should get no results
6. Apply the patch
7. Repeat steps 3 and 4
8. You should get expected results.  Note the difference between
   'Keyword' and 'Keyword as phrase' in results
9. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase'

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093

Janusz Kaczmarek  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33095] New: Text is white on white when hovering over pay/writeoff buttons in paycollect

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095

Bug ID: 33095
   Summary: Text is white on white when hovering over pay/writeoff
buttons in paycollect
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

The members/paycollect page has buttons to switch between pay and writeoff when
you are paying a charge. When you hover the mouse cursor over the inactive
button, the text becomes white, on a white background.

To get there:
1. Add a charge to a patron's account and go to pay
   1.1. Go to Patrons
   1.2. Click "Search"
   1.3. Click on the name of any patron
   1.4. Click on the "Accounting" tab (on the left)
   1.5. Click on the "Create manual invoice" tab
   1.6. Enter an amount
   1.7. Click "Save and pay"
2. Hover on the "Writeoff" button at the top of the form
   --> Text "disappears"

Also, I noticed the text for the active button becomes underlined and the
button changes size...

3. Hover on the "Pay" button at the top of the form
   --> "Pay" becomes underlined
   --> Yellow button gets smaller

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase'

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093

Janusz Kaczmarek  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |janus...@gmail.com
   |ity.org |

--- Comment #1 from Janusz Kaczmarek  ---
Created attachment 147519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147519=edit
Bug 33093 - (Bug 27546 follow-up) With ES searching within results does not
work for 'Keyword' and 'Keyword as phrase'

The feature of searching within search results in librarian
has some problems with with elastic: 'Keyword' and 'Keyword
as phrase' searches give no results.  This is because elastic
is unaware of the search field 'kw' and 'kw' is not
transformed nor removed for limits.

Test plan
=
1. Have a Koha instance with reasonable number of biblio records
1. Set SearchEngine to Elasticsearch
3. In librarian interface, perform a search that would give
   you a list of results
4. With the new search box 'Search within results', having 'Keyword'
   and 'Keyword as phrase' active, try to perform a search within
   search results with a term that should give you some results
5. You should get no results
6. Apply the patch
7. Repeat steps 3 and 4
8. You should get expected results.  Note the difference between
   'Keyword' and 'Keyword as phrase' in results
9. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33094] Change OPAC view link in search results for Suppressed bibs

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33094

Donna  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33094] New: Change OPAC view link in search results for Suppressed bibs

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33094

Bug ID: 33094
   Summary: Change OPAC view link in search results for Suppressed
bibs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

With the enhancement from bug 29406, in the staff interface, the OPAC view link
on the detail page reflects suppression status, but the OPAC view link in the
search results page still displays, and when you click on it, you get an error
message.  It would be great if the Suppressed status shows in the search
results too.  Perhaps instead of "OPAV view" display "Suppressed" instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32939] Have generic fetch functions in vue modules

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939

--- Comment #79 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32939] Have generic fetch functions in vue modules

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939

Matt Blenkinsop  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.04
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32925] Display loading info when a form is submitted

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925

--- Comment #29 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32925] Display loading info when a form is submitted

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925

Matt Blenkinsop  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

--- Comment #27 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

--- Comment #62 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

Matt Blenkinsop  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.04
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26058] Add ability for AllowHoldsOnPatronsPossessions to be limited by item type, collection code or shelving location

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26058

Cullen  changed:

   What|Removed |Added

 CC||cul...@benbrooklibrary.org

--- Comment #2 from Cullen  ---
I agree with the need for this adjustment. For our library, it isn't feasible
to prevent holds on all already checked out items, but like Barbara, we have
several item types (hot spots, video games, etc.) that we would like to prevent
holds on for those who have one checked out.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32579] Staged MARC Record match details return title of matching biblionumber record when importing authorities

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32579

--- Comment #5 from Heather  ---
Hi, Alexis!

Next time, hopefully, my searching will be more effective, and I can find any
duplicates right away!:)

Cheerio!
h2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33093] New: (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase'

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093

Bug ID: 33093
   Summary: (Bug 27546 follow-up) With ES searching within results
does not work for 'Keyword' and 'Keyword as phrase'
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P3
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: janus...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The new feature of searching within search results in librarian interface (Bug
27546) works well with zebra but there are some problems with elastic:
'Keyword' and 'Keyword as phrase' give no results.  This is because elastic is
unaware of the search field 'kw' and 'kw' is not transformed nor removed for
limits.

A patch proposal will follow.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33092] New: Add ability to search within a list

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33092

Bug ID: 33092
   Summary: Add ability to search within a list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

It would be really helpful to be able to search within a list in both the OPAC
and the staff interface.  For instance, in both the staff interface, if you are
viewing a public list with a lot of items on it, you do not have the ability to
see if a specific item appears on the list.  This is a needed functionality
with larger lists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32685] Display incorrect when matching authority records during import

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32685

Alexis  changed:

   What|Removed |Added

 CC||ale...@flo.org

--- Comment #6 from Alexis  ---
*** Bug 32579 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32579] Staged MARC Record match details return title of matching biblionumber record when importing authorities

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32579

Alexis  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Alexis  ---
Thanks, Heather, it looks like it is! Glad there's a fix for this now!

*** This bug has been marked as a duplicate of bug 32685 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33091] New: Autocomplete for patron search should work for other search criteria

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33091

Bug ID: 33091
   Summary: Autocomplete for patron search should work for other
search criteria
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Autocomplete only works for name searches.  Could we have it work for other
things like addresses, email or phone numbers?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31563] Numbers on claims tab not showing in translated templates

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563

--- Comment #17 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31563] Numbers on claims tab not showing in translated templates

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563

--- Comment #16 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26967] Patronautocomplete does not include streetnumber field in address

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967

Christopher Brannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Christopher Brannon  ---
Works like a charm!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #15 from Pedro Amorim  ---
Created attachment 147518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147518=edit
Bug 32968: ERM granular permissions - Navigation guards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #14 from Pedro Amorim  ---
Created attachment 147517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147517=edit
Bug 32968: ERM granular permissions - EHoldings Titles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #13 from Pedro Amorim  ---
Created attachment 147516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147516=edit
Bug 32968: ERM granular permissions - EHoldings Packages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #12 from Pedro Amorim  ---
Created attachment 147515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147515=edit
Bug 32968: ERM granular permissions - Agreements

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #11 from Pedro Amorim  ---
Created attachment 147514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147514=edit
Bug 32968: ERM granular permissions - Licenses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #10 from Pedro Amorim  ---
Created attachment 147513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147513=edit
Bug 32968: ERM granular permissions - API specs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26967] Patronautocomplete does not include streetnumber field in address

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #147480|0   |1
is obsolete||

--- Comment #3 from Biblibre Sandboxes  ---
Created attachment 147512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147512=edit
Bug 26967: Correctly format patron address in autocomplete

We should use the JS function to format patron's address in the
autocomplete result

Test plan:
Search for patron using the autocomplete feature, using the different values
of addressformat.
The address should be formatted correctly, like other places in Koha.
You should also notice that the street number is now displayed.

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #9 from Pedro Amorim  ---
Created attachment 147511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147511=edit
Bug 32968: ERM granular permissions - DB specific

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #8 from Pedro Amorim  ---
Created attachment 147510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147510=edit
Bug 32968: ERM granular permissions - Preparation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

Pedro Amorim  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32935] basketgroup.js is not longer used and should be removed

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32935

--- Comment #5 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32935] basketgroup.js is not longer used and should be removed

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32935

Matt Blenkinsop  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.04
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

--- Comment #26 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Matt Blenkinsop  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #147466|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC after switch to Bootstrap tabs

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248

--- Comment #16 from Christopher Brannon  ---
Seems like this one could be backported to 22.05?  Yes/No?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32579] Staged MARC Record match details return title of matching biblionumber record when importing authorities

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32579

--- Comment #3 from Heather  ---
Hi, again!  Is this a duplicate of bug 32685?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #45 from Lucas Gass  ---
> 2) Database update
> 
> UPDATE borrowers SET flags = flags + (1<<29) WHERE flags & 4
> 
> Can you explain that one to me? I have written stuff like that before, but
> it's not coming back to me right now. I had expected something like "where
> flags != 0 and IS NOT NULL"?

Because I want to set the new loggedinlibrary permission for patrons that have
the staff access permission when IndependentBranches is turned on. 

Now that I think about it what you say would work too "WHERE flags != 0 and IS
NOT NULL". 

Happy to change it if you'd like!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594

--- Comment #32 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #31)
> I think we forget an important part here, there is no daemon around the new
> script, and so it's not running (and records are not indexed!)

Maybe bake it into koha-indexer?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32579] Staged MARC Record match details return title of matching biblionumber record when importing authorities

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32579

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #2 from Heather  ---
This is causing me SO much time--because I can't see the record to be overlaid
correctly displayed in the list, I have to check Every. Single. Updated.
Authority. Record. That. I'm. Importing. From. OCLC.

I dearly hope this get fixed!!!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926

--- Comment #16 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926

Matt Blenkinsop  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.04
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32687] About may list version of SQL client in container, not actual server

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32687

--- Comment #10 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32687] About may list version of SQL client in container, not actual server

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32687

Matt Blenkinsop  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] Add page section to list of checkins

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

--- Comment #5 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] Add page section to list of checkins

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

Matt Blenkinsop  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413

--- Comment #6 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413

Matt Blenkinsop  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.04
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #44 from Katrin Fischer  ---

> > 2) Database update
> > 
> > UPDATE borrowers SET flags = flags + (1<<29) WHERE flags & 4
> > 
> > Can you explain that one to me? I have written stuff like that before, but
> > it's not coming back to me right now. I had expected something like "where
> > flags != 0 and IS NOT NULL"?
> 
> Using 1<<29 since borrower.flags is stored in bits. It's the bitwise
> operator '<<'. (right shift) I used in order to preserve other permissions
> set in borrower.flag. It takes the original value and adds (1<<29).

I understood that part, I was wondering about the flags & 4 in the where
condition :)
> 
> > 3) Changing home library
> > 
> > The staff user can still change their own home branch and circumvent the
> > limitation that way. Should we make the library read only when the
> > permission is missing?
> Good point. Do you think that is within the scope of this bug?

I am torn, I think it would make it feature complete, but also ok to handle as
a follow-up. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #43 from Lucas Gass  ---
In an effoft to keep this moving I am removing the 'FQA' status since I
answered the questions asked and provided a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #42 from Lucas Gass  ---
Created attachment 147509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147509=edit
Bug 30624: (QA follow-up) Use C4:Context to get permssions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #41 from Lucas Gass  ---
(In reply to Katrin Fischer from comment #40)
> 1) We have a mix now of $flags->{superlibrarian} == 1 and
> $patron->is_superlibrarian
> 
> I remember that is_superlibrarian was created in order to fix and avoid a
> lot of false/wrong permission checks for superlibrarian in the codebase. I
> am not sure if the flags will work correctly, maybe someone else could weigh
> in? Should we be consistent or doesn't it matter?

The inconsistency is set-library.pl. Instead of building a patron object so
that we can use $patron->is_superlibrarian I think we can use C4::Context for
the check.

> 2) Database update
> 
> UPDATE borrowers SET flags = flags + (1<<29) WHERE flags & 4
> 
> Can you explain that one to me? I have written stuff like that before, but
> it's not coming back to me right now. I had expected something like "where
> flags != 0 and IS NOT NULL"?

Using 1<<29 since borrower.flags is stored in bits. It's the bitwise operator
'<<'. (right shift) I used in order to preserve other permissions set in
borrower.flag. It takes the original value and adds (1<<29).

> 3) Changing home library
> 
> The staff user can still change their own home branch and circumvent the
> limitation that way. Should we make the library read only when the
> permission is missing?
Good point. Do you think that is within the scope of this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33055] SIP2 adding incorrect fines blocked message

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33055

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33055] SIP2 adding incorrect fines blocked message

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33055

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #147331|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 147508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147508=edit
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked

To test:
0 - Apply first patch
1 - prove -v t/db_dependent/SIP/Patron.t
2 - It fails
3 - Apply second patch
4 - prove -v t/db_dependent/SIP/Patron.t
5 - It passes!

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33055] SIP2 adding incorrect fines blocked message

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33055

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #147330|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 147507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147507=edit
Bug 33055: (bug 32624 follow-up) Unit tests

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33014] Add link to serial advanced search

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33014

--- Comment #11 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33014] Add link to serial advanced search

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33014

Matt Blenkinsop  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.04
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >