[Koha-bugs] [Bug 33034] KOHA Upgrade fails from v20.05 to v22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33034 --- Comment #1 from quickfir...@gmail.com --- Up to now cant get any answer for this. Did anyone encounter this kind of error while upgrading? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #2 from Adam Styles --- Hi All, I could not get BZ to work in order to apply my patch via git from branch 'bug_33190' I created in Koha dev box, so I used built in patch UI here to upload the edited 'advsearch.tt' file from my branch. I will try to get bz working from future bugs. Please let me know what else is required to do in order for this to be tested/reviewed. Thanks in advance for the help. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #1 from Adam Styles --- Created attachment 148048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148048=edit Add search history button to advance search form if EnableSearchHistory keep Bug 33190: Add search history button to advance search form if EnableSearchHistory keep Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' via added code block to advsearch.tt To test: 1) Login to Koha dev box instance 2) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 'Search history' icon will not be visible in tools groups in form. 3) Select 'koha administration' module '/cgi-bin/koha/admin/admin-home.pl' 4) Enter 'EnableSearchHistory' string into top search field 5) Change 'EnableSearchHistory' value to 'keep' 6) Press 'Save all Searching preferences' to save pref changes 7) Navigate back to Koha landing home '/cgi-bin/koha/mainpage.pl' 8) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 9) 'Search history' icon will now be visible in tools groups in form 10) SIGN OFF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Adam Styles changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |adam.sty...@esa.edu.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33165] Add search history with its own button to staff interface start page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33165 Adam Styles changed: What|Removed |Added Status|NEW |In Discussion --- Comment #4 from Adam Styles --- Hi All, I have created a new bug based on the new user story and feature offer. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Can someone please advise the correct way to close this ticket? Thanks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33190] New: Add search history button to advance search form if EnableSearchHistory keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190
Bug ID: 33190
Summary: Add search history button to advance search form if
EnableSearchHistory keep
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Searching
Assignee: koha-bugs@lists.koha-community.org
Reporter: adam.sty...@esa.edu.au
QA Contact: testo...@bugs.koha-community.org
Created attachment 148047
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148047=edit
screen shot of search history button in koha dev box as preview
Hi All,
I believe the 'search history' feature to be quite useful in daily repeated
search work flows, further to this it is a feature fairly hidden behind a drop
down UI in the top right when logged in.
Therefor to promote the use of this valuable tool and also to improve it's
discoverability, I propose the follow new enhancement.
User story:
* Add 'search history' button to advanced search button groups if
'EnableSearchHistory' sys pref is set to 'keep'
Key logic:
* If 'EnableSearchHistory' sys pref is set to 'keep' (this is an existing sys
pref), an additional 'search history' button will populate at the of the
current advance search buttons group
* This new button element makes use of the existing syntax for other button on
page and loads the font awesome 4.7 history icon which aligns with the buttons
action.
* The button will not display unless 'EnableSearchHistory' sys pref is set to
'keep', which makes use of a IF statement in the advsearch.tt template file at
around line 100 ish (see patch)
```
[% IF Koha.Preference('EnableSearchHistory') %]
search history
[% END %]
```
I have tested in Koha dev box v22 and all works well. I will create test plan
in patch commit message.
I am creating my first patch for this very soon, just reading coding guidelines
to ensure I patch as community expects.
See attached screen shot.
I welcome feedback.
Thanks.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33189] Plugin upload should prompt for .kpz files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33189 David Cook changed: What|Removed |Added Summary|Plugin upload should prompt |Plugin upload should prompt |for kpz files |for .kpz files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33189] Plugin upload should prompt for kpz files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33189 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33189] Plugin upload should prompt for kpz files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33189 --- Comment #1 from David Cook --- Created attachment 148046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148046=edit Bug 33189: Make plugin upload look for .kpz files in file picker This change configures the file picker to look for *.kpz files instead of *.* files, which makes it more convenient to locate .kpz files for upload when uploading plugins. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/plugins/plugins-upload.pl 2. Click on "Choose file" 3. Note that the file type in the box at the bottom right of the screen defaults to "KPZ File (*.kpz) 4. If you navigate to a directory that contains .kpz files (like Downloads), you'll now see directory folders and .kpz files. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33189] Plugin upload should prompt for kpz files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33189 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33189] New: Plugin upload should prompt for kpz files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33189 Bug ID: 33189 Summary: Plugin upload should prompt for kpz files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org At the moment, when you click "Choose file" when uploading a plugin, it looks for "All Files (*.*)", but really we only ever want "*.kpz" files. By changing the HTML we should be able to make it only look for "*.kpz" files which should make uploads a bit more convenient. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #177 from Aleisha Amohia --- Katrin's follow-up looks great so have done an additional sign-off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #147880|0 |1 is obsolete|| --- Comment #176 from Aleisha Amohia --- Created attachment 148045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148045=edit Bug 3150: (follow-up) Make sure host information displays for unlinked records When the 773 entry is not linked to a record using $w or Easyanalytics we still want to display the information about the source/host item in the emails. To test: 1. Activate the UseControlNumber system preference 2. Search for a record and make sure it has 001 set to some value. 3. Use Edit > Add child record to create an analytical record from this record. 4. Make sure 773$w was filled in and finish by adding any mandatory fields, save. 5. Add this record to your cart. Also add a 773$g with the pages or similar. 6. Create another record with 773$t and $g, but without $w. 7. Also add this record to your cart. 8. Add a few other records to the cart. 9. Host item information (In: ) should display for all entries with 773 in the record. This also makes use of the biblio-title include to display the different parts of the title (245$abnp), if the record is linked. Signed-off-by: Katrin Fischer Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #4 from Agustín Moyano --- Created attachment 148044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148044=edit Bug 33169: (follow-up) Cleanup and tidy a little bit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33165] Add search history with its own button to staff interface start page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33165 --- Comment #3 from Adam Styles --- Hi Katrin, You make some excellent points, I have been thinking on my idea submission over the last few days and agree that perhaps my perspective on a 'search history' action from the landing page is quite meaningful, as I use this daily, however for those who do not do so, and also for those who share Koha logins, perhaps this could be more noise then benefit. Building on your point about this suggestions being more feature of an existing module, as opposed to an actual module, perhaps I might pivot this original feature concept into an added button/link element that could sit in the footer of the advanced search module. This would offer an added quick action for those like myself who use the search history daily, but would create no friction for other users. As I a new to this community, would I now create a new feature ticket? or simply re-purpose this one. New concept: * I want a 'search history' button or link added to advanced search page, to allow quick previous search history action. I appreciate your thoughts on this BTW. Thanks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 148043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148043=edit Bug 33161: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 148042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148042=edit Bug 33161: (follow-up) Remove stray variables and fix POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 148041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148041=edit Bug 33161: Clarify method names The api_strings_mapping method isn't really only about api strings.. we deal with database fields in and out.. we just happen to then use those in to_api to map in the api. This patch simply renames the standard method whilst we're still early. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 148040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148040=edit Bug 33161: (follow-up) Consistent use of db fields throughout We should stick to DB field names as long as possible to allow re-use and only convert to api field names via to_api_mapping at the last moment inside the parent to_api function. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 148039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148039=edit Bug 33161: Add +strings support to GET /items and /items/:item_id This patch introduces the `api_strings_mapping` method to the *Koha::Item* class, and makes the API spec for the following routes: * GET /items * GET /items/:item_id * GET /acquisitions/orders accept the new `+strings` parameter that can be passed through the `x-koha-embed` header and was introduced by bug 26635. In the case of /acquisitions/orders, you will need to use x-koha-embed: items+strings I introduce it here to highlight the flebility we introduced with bug 26635. The `api_strings_mapping` method has its roots on the cool `columns_to_str` method already present. The main differences: * It is aware of the `public_read_list` for attributes so no hidden information is exposed. * Attribute names get mapped for consistency with the API (e.g. `homebranch` is converted into `home_library_id`, etc). * The data structure it returns includes information about the source for the descriptions (e.g. it it is an authorised value, then `type` will be `av`, and the related category information is returned so dropdowns and such can be built. The same goes for other types as `library`, `item_type` and `call_number_source`. To test: 1. Apply this patch 2. Reload everything 3. Play with your favourite REST tool (e.g. Postman) 4. Try: GET http://localhost:8081/api/v1/items x-koha-embed: +strings => SUCCESS: You get a list of items, they include the new _strings structure, and the contents make sense! 5. Repeat with a specific item: GET http://localhost:8081/api/v1/items/14 x-koha-embed: +strings => SUCCESS: It all makes sense! 6. Sign off :-D Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Pedro Amorim Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 Tomás Cohen Arazi changed: What|Removed |Added Attachment #148014|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 Tomás Cohen Arazi changed: What|Removed |Added Attachment #148013|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 Tomás Cohen Arazi changed: What|Removed |Added Attachment #148012|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 Tomás Cohen Arazi changed: What|Removed |Added Attachment #148011|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 Tomás Cohen Arazi changed: What|Removed |Added Attachment #148010|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33183] Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 David Cook changed: What|Removed |Added Summary|Bibs with several items |Bibs with several hundred |causes a slow loading |items causes a slow loading |screen |screen CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33188] Warning in Koha::Items->hidden_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33188
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- Comment #2 from David Cook ---
Shouldn't it be updated to one of the following:
1.
if ( any { $self->$field && $self->$field eq $_ } @{ $rules->{$field} } ) {
2.
if ( any { my $field = $self->$field; ($field && $field eq $_ ) ? 1 : 0; } @{
$rules->{$field} } ) {
Or am I missing something?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33133] Fast cataloging should be visible in cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- 2 things: 1) Why check for the existance of the FA framework on the staff interface start page, but not on the cataloguing start page? 2) I don't feel like Fast cataloguing is a tool and it gets really lost in the 3rd column. Maybe we could move it into the first column on top or even into the toolbar of the cataloging page? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33133] Fast cataloging should be visible in cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33144] Authority lookup in advanced editor overencodes HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33144 Katrin Fischer changed: What|Removed |Added Attachment #147817|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 148038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148038=edit Bug 33144: Unescape text from authority lookup for advanced editor While the basic editor is happy with an array of subfields it can stuff into separate fields, the advanced editor needs to get a JS string back from the authority lookup plugin, because it is going to just add the whole thing as text. The string has to be HTML entity encoded, both to not allow XSS and just to not break the window, but it needs to then be unencoded before being inserted into the editor. Test plan: 1. Set the system preference EnableAdvancedCatalogingEditor to Enable 2. Edit any Topical Term authority, and at the end of tag 150 subfield a, add & 3. Cataloging - Advanced editor 4. Press return in the editor to get a new blank line, type 650 and press tab three times, then type Ctrl-Shift-L 5. Search for your modified authority, and click Choose 6. Verify that the tiny popup opened by the search window finished its job and closed itself 7. Verify that your 650 now shows as "‡aAbduction & ‡vDrama" rather than "‡aAbduction /script‡vDrama." Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33144] Authority lookup in advanced editor overencodes HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33144 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33144] Authority lookup in advanced editor overencodes HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33144 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33150] Add specific message for renewal too_soon situation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Katrin Fischer changed: What|Removed |Added Attachment #147792|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33150] Add specific message for renewal too_soon situation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #6 from Katrin Fischer --- Hi Andreas, I've fixed the mistake pointed out by Lucas, but I also fixed your commit message. Please make sure to always add a short problem description and the test plan into your commit message. See here: https://wiki.koha-community.org/wiki/Commit_messages Also added Laura's SO line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33150] Add specific message for renewal too_soon situation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 --- Comment #5 from Katrin Fischer --- Created attachment 148037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148037=edit Bug 33150: Add specific message for informing about too_soon for renewal. The message "No renewals allowed" is incorrect when it is too soon for renewal, this patch adds a specific error message. To test: - Make sure the system preference SCOAllowCheckin is set to "allow" - Go to Koha administration -> Circulation and fine rules - Edit the rule for all items and change "No renewal before" to 1 and save. - Check out an item to a borrower (for instance barcode 300719 to the user koha with cardnumber 42). - Go to self checkout (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl) - Log in as the user (koha/koha) - Verify that the error message in the Renew column is "This item cannot yet be renewed." Signed-off-by: Laura Escamilla Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33150] Add specific message for renewal too_soon situation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33152] Set focus for cursor to search input box when creating new report from "New SQL from Mana" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33152 Katrin Fischer changed: What|Removed |Added Attachment #147958|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 148036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148036=edit Bug 33152: Add focus to search field This patch adds focus to the search field for a new SQL report from mana. Test plan: 1) Navigate to Reports > Create from SQL 2) Click on the new report dropdown and select "New SQL from Mana" 3) Observe that there is no focus on the input and the user needs to click to start typing 4) Apply patch 5) Repeat steps 1-2 6) There should now be focus on the input and typing can be started immediately Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33152] Set focus for cursor to search input box when creating new report from "New SQL from Mana" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33152 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156
--- Comment #4 from Katrin Fischer ---
Hi George,
it took me a while and I cannot reproduce the error with selecting an attribute
that is linked to an AV, the form itself seems ok in master, but I can see the
JS error now. You have to update an extended attribute in order to see it:
* Go to the patron modification tool
* Add one or more cardnumbers, I used 42
* Select the "show barcode" extended patron attribute at the end of the form
and update to yes or no
On the results list, you'll see the error in the console:
table_settings.push({
columname: "Attributes 1",
cannot_be_modified: 0,
cannot_be_toggled: 0,
is_hidden: 0
});
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #3 from George Williams (NEKLS) --- Katrin, Laura filed this bug on behalf of NEKLS and CIN and both of our consortia are experiencing it on Koha 22.05 George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #2 from Katrin Fischer --- Interesting: I don't see an error on the search form, but I see it on the 'result list' after the changes have been made. Maybe there is 2 different bugs here, one on the form, not present in master, and one for the results? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #1 from Katrin Fischer --- Hi Laura, I just tested this on master and it worked ok. Which version did you encounter the problem in? Does it still not work for you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33165] Add search history with its own button to staff interface start page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33165 Katrin Fischer changed: What|Removed |Added Summary|Creation of 'My search |Add search history with its |history' button via added |own button to staff |LI element in intranet |interface start page |landing intranet-main.tt| --- Comment #2 from Katrin Fischer --- I am not sure about this one tbh. The page is already quite full, and with ILL and ERM active the balance is already off by 2 for icons on the left vs right side. We try to only put modules on the start page and search history isn't really a module I'd say, but a catalog feature. It will also only be helpful if you have already done some searches. Functionally, I think you'd also need to check on the existing preference EnableSearchHistory, so it only displays when the feature is activated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal CC||m...@kohaaloha.com --- Comment #2 from Katrin Fischer --- I have checked in master on ktd and there the about page works as expected. Could this be a packaging problem? If he file was not copied into the right place in the file structure, that could explain the issue. The file is definitely present in the dev environment: /kohadevbox/koha/docs/history.txt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33173] Save and continue button in standard cataloging module broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33173 Katrin Fischer changed: What|Removed |Added Attachment #147978|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 148035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148035=edit Bug 33173: Save and continue button in standard cataloging module broken To test: 1 - Edit a record in the standard editor 2 - Click on to tab 2 3 - Click 'Save and continue' 4 - Error: tab is not defined 5 - Apply patch 6 - Reload page and try again 7 - Fixed! Signed-off-by: Laura Escamilla Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33173] Save and continue button in standard cataloging module broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33173 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33173] Save and continue button in standard cataloging module broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33173 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33174] Have better indication when one is cancelling multiple holds on a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33174
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||oleon...@myacpl.org
--- Comment #4 from Katrin Fischer ---
I like this, but I am not sure if we couldn't do a little better accounting for
singular/plural forms and translations here.
At the moment we have:
--
Are you sure you want to cancel this hold?
This action will cancel %s hold(s)
--
I wonder if we could use something like below with JavaScript too?
https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_RFC
[% tnpx('bibliographic record', 'there is {count} item', 'there are {count}
items', items.count, { count = items.count }) %]
Failed for feedback.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33188] Warning in Koha::Items->hidden_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33188 --- Comment #1 from Fridolin Somers --- Not sure how to fix. Do we consider undef like empty string in order to allow hiding undef ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Fridolin Somers changed: What|Removed |Added Depends on||33188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33188 [Bug 33188] Warning in Koha::Items->hidden_in_opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33188] Warning in Koha::Items->hidden_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33188 Fridolin Somers changed: What|Removed |Added Blocks||25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33188] New: Warning in Koha::Items->hidden_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33188
Bug ID: 33188
Summary: Warning in Koha::Items->hidden_in_opac
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
In Koha::Items->hidden_in_opac there is often a warning :
Use of uninitialized value in string eq at /home/koha/src/Koha/Item.pm line
633.
This the line :
if ( any { $self->$field eq $_ } @{ $rules->{$field} } ) {
When $self->$field is undef, the eq creates the warn.
This can happen with any nillable field like items.location not yet defined
after item acquisition.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #63 from Nick Clemens --- Signed by Lisette, minor rebase and test updates, I think this can go to QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 --- Comment #16 from Nick Clemens --- Created attachment 148034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148034=edit Bug 33159: Simplify ES handling and fix zebra handling Before this patch we used two indexes for the thesaurus values, we can simply index both needed fields into a single index and just form the search correctly. This patch also ensures we pass the 'thesaurus' vlaue for the heading directly to the query builder - for zebra it goes through, and for ES we convert it to the expected code. This patch also moves the necessary mappings out of the user definable mappings and hardcodes them. There is precedent for this with 'match-heading', it ensures matching works as expected To test: 1 - Follow previous test plan in Zebra and ES Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 --- Comment #15 from Nick Clemens --- Created attachment 148033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148033=edit Bug 33159: Correctly form thesaurus term for non-subject headings Bug 30280 fixed things for subject heading, but didn't take into account that all non-subject headings are considered LCSH - this means we can't really handle different thesauri for controlled headings outside of subjects - maybe a topic for a new bug, but we should fix matching for them now To test: 1 - Set sysprefs: RequireChoosingExistingAuthority - don't require AutoCreateAuthorities - generate CatalogModuleRelink - Do AutoLinkBiblio - Do LinkerModule - first match 2 - Find a record with an author attached to an authority, I used biblionumber 3 "Introduction to Attic Greek" 3 - Edit in advanced editor 4 - Delete the $9 link 5 - Save the record 6 - It generates a new number 7 - Repeat 4-5, it does it again 8 - Apply patch and restart all 9 - Repeat 4-5 10 - It links to the original authority Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 Nick Clemens changed: What|Removed |Added Attachment #147986|0 |1 is obsolete|| Attachment #147987|0 |1 is obsolete|| Attachment #147988|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 148032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148032=edit Bug 33159: Unit tests Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #6 from Nick Clemens --- Created attachment 148031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148031=edit Bug 33100: Remove all punctuation at end of record This could potentially be overkill - if you have two records that only differ in ending punctuation, you might get a false result - I don't know how likely that is ( as I have mentioned before '!!!' is a band ) This seems a reasonable fix To test: 1 - Set sysprefs as in bug 33159 2 - Edit a record, biblionumebr 3 is fine 3 - Add a comma to end of author subfield a 4 - Save and note relinked 5 - Apply patch, restart all 6 - Save again 7 - Linked to original record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Attachment #147885|0 |1 is obsolete|| Attachment #147886|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 148030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148030=edit Bug 33100: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33167] Bibs with several items causes a slow loading screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #1 from Nick Clemens --- Created attachment 148029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148029=edit Bug 33167: Cleanup staff detail page This patch begins reduing some of the extra things we are doing in detail.pl that could easily be handled in the templates - fetching authorised values and branches etc It also removes a loop to find items that should be hidden, and instead uses a searh parameter The template changes either use item object rather than passed variables, or utilize plugins to fetch authorised valued Template also includes addition of chomp to the template directives, this reduces the size of the items table by several megabytes on records with many items WIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26802] Improve speed with records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33167 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33167] Bibs with several items causes a slow loading screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26802 CC||n...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 Lucas Gass changed: What|Removed |Added Summary|paycollect.pl should have a |Improve enforcing of |check for payment type if |RequirePaymentType |RequirePaymentType | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more fields simpler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170 Katrin Fischer changed: What|Removed |Added Summary|Refactor|Refactor |MarcItemFieldsToOrder code |MarcItemFieldsToOrder code |to make adding more field |to make adding more fields |simpler |simpler -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33174] Have better indication when one is cancelling multiple holds on a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33174 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187
--- Comment #1 from Owen Leonard ---
Created attachment 148028
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148028=edit
Bug 33187: Use template wrapper for tabs article requests and holds awaiting
pickup pages
This patch updates the article requests management and holds awaiting
pickup templates in the staff interface so that they use the new WRAPPER
directive for building tabs.
To test, apply the patch and make sure the ArticleRequests system
preference is enabled.
- Go to Circulation -> Article requests
- You should see three tabs, "New," "Pending," and "Processing."
- The tabs should look correct and work correctly.
- Go to Circulation -> Holds awaiting pickup
- You should see three tabs, "Holds waiting", "Holds waiting over X
days," and "Holds with cancellation requests." ("X" is the value in
the ReservesMaxPickUpDelay system preference)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33176] paycollect.pl should have a check for payment type if RequirePaymentType
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 --- Comment #2 from Lucas Gass --- (In reply to Katrin Fischer from comment #1) > Maybe also in the module? Thinking of the API. Yes, good point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32404] Two-factor authentication for staff client doesn't work for all staff accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32404 Laura O'Neil changed: What|Removed |Added CC||la...@bywatersolutions.com --- Comment #3 from Laura O'Neil --- Workaround: superlibrarians can give cataloging permissions to staff in order for staff to activate 2FA. Cataloging permissions can then be removed after the staff person has completed 2FA setup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard changed: What|Removed |Added Blocks||33187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33187] New: Use template wrapper for tabs article requests and holds awaiting pickup pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 Bug ID: 33187 Summary: Use template wrapper for tabs article requests and holds awaiting pickup pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, the article requests management and holds awaiting pickup templates should be updated to use the new WRAPPER for tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla changed: What|Removed |Added Attachment #148018|0 |1 is obsolete|| --- Comment #6 from Laura Escamilla --- Created attachment 148027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148027=edit Bug 33117: Added new syspref Patronautocompletesesarchmethod Added a new system preference called "PatronAutoCompleteSearchMethod" which allows staff to choose between "Starts with" or "Contains" when searching for patrons. The "Contains" option should be useful when searching for patrons that have multiple surnames or when searching using a patron's middle name. Test Plan: 1. Create a patron that has a first name, middle name and two surnames. (i.e. Adela Maria, Hernandez Acosta). 2. Search for the patron using their first name and first surname. Confirm that a record is found. 3. Search for the patron using their first name and second surname. Confirm that no record is found. 4. Search for the patron using their middle name and first surname. Confirm that a record is found. 5. Search for the patron using their middle name and second surname. Confirm that no record is found. 6. Apply the patch. 7. Under Administration > Global System Preferences > search for “PatronAutocompleteSearchMethod” 8. Choose “Contains” instead of “Starts with” for the system preference. 9. Repeat steps 2-4. The patron record should appear for all search methods. 10. Sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 --- Comment #1 from Owen Leonard --- Created attachment 148026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148026=edit Bug 33186: Use template wrapper for tabs on search history and advanced search This patch updates the search history and advanced search templates in the staff interface so that they use the new WRAPPER directive for building tabs. The patch also makes a minor change to CSS in order to accommodate the different markup. To test, apply the patch and rebuild the staff interface CSS. - Go to the catalog's advanced search page. You should see tabs for each of the selections defined in the AdvancedSearchTypes system preference. - The tabs should look correct and work correctly. - If necessary, enable the EnableSearchHistory system preference. - Click the logged-in user name in the header menu and choose "Search history." - On this page you should see two tabs, catalog and authority. Both tabs should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33176] paycollect.pl should have a check for payment type if RequirePaymentType
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 --- Comment #1 from Katrin Fischer --- Maybe also in the module? Thinking of the API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33179] Allow for libraries to automatically suppress a bibliographic record from OPAC if no items are attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33179 Katrin Fischer changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33183] Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183 --- Comment #4 from Katrin Fischer --- Tested with: mariadb Ver 15.1 Distrib 10.5.18-MariaDB, for debian-linux-gnu (x86_64) using EditLine wrapper I also verified we have backticks in kohastructure.sql. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33183] Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183 --- Comment #3 from Katrin Fischer --- I couldn't test with this specific DBMS version, but I did a regression test and the code looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33183] Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183
Katrin Fischer changed:
What|Removed |Added
Attachment #148017|0 |1
is obsolete||
--- Comment #2 from Katrin Fischer ---
Created attachment 148025
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148025=edit
Bug 33183: Error inserting matchpoint_components when creating record matching
rules with MariaDB 10.6
The word "offset" is now a keyword. At the very least we need to escape the
fieldname with backticks. It would be nice to switch to Koha::Objects for this
module eventually.
C4::Matcher::_store_matchpoint(): DBI Exception: DBD::mysql::st execute failed:
You have an error in your SQL syntax; check the manual that corresponds to your
MariaDB server version for the right syntax to use near 'offset, length) VALUES
('27', '1', '999'...' at line 2 at /usr/share/koha/lib/C4/Matcher.pm line 314
Test Plan:
1) Set up Koha with MariaDB 10.6
2) Attempt to create a matching rule
3) Note the error screen
4) Apply this patch
5) Restart all the things!
6) Attempt to create another matching rule
7) No errors this time
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33183] Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard changed: What|Removed |Added Blocks||33186 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 [Bug 33186] Use template wrapper for tabs on search history and advanced search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33186] New: Use template wrapper for tabs on search history and advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Bug ID: 33186 Summary: Use template wrapper for tabs on search history and advanced search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, the search history and advanced search templates should be updated to use the new WRAPPER for tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3831] Add a warning/hint when FA framework is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 --- Comment #16 from Katrin Fischer --- And another 4-digit bug bites the dust :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3831] Add a warning/hint when FA framework is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 Katrin Fischer changed: What|Removed |Added Attachment #147744|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 148024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148024=edit Bug 3831: Add a warning to about page when there is no FA framework The feature is effectively disab;ed throughout Koha when this framework is deleted. There do not appear to be any other side effects. We should report this on the about page for informatinal purposes To test: 1 - Apply patch 2 - Check about page, no change 3 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FB' WHERE frameworkcode = 'FA' 4 - Refresh about page 5 - Note new warning 6 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FA' WHERE frameworkcode = 'FB' 7 - Refresh about page 8 - No warning Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3831] Add a warning/hint when FA framework is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Katrin Fischer changed: What|Removed |Added Change sponsored?|Seeking cosponsors |--- --- Comment #62 from Katrin Fischer --- (In reply to Katrin Fischer from comment #61) > (In reply to cart...@slolibrary.org from comment #60) > > Hi, > > > > My name is Charlie, I'm the Technical Services Librarian at the County of > > San Luis Obispo. We are interested in partnering up with anyone that would > > like to help pay for this bug to be a priority solve. > > > > Please let me know if you're interested and I can be reached at > > . > > > > Thank you, > > Charlie > > Hi Charly, I have updated the "change sponsored?" field to say "Seeking > cosponsors". It might help to get this some attention. Hm, I realize now: this patch is already in development. What it needs right now is someone to test it, and anyone can. You could use a sandbox to test and help progress this development. See: https://wiki.koha-community.org/wiki/Development_workflow https://wiki.koha-community.org/wiki/Sandboxes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Katrin Fischer changed: What|Removed |Added Change sponsored?|--- |Seeking cosponsors --- Comment #61 from Katrin Fischer --- (In reply to cart...@slolibrary.org from comment #60) > Hi, > > My name is Charlie, I'm the Technical Services Librarian at the County of > San Luis Obispo. We are interested in partnering up with anyone that would > like to help pay for this bug to be a priority solve. > > Please let me know if you're interested and I can be reached at > . > > Thank you, > Charlie Hi Charly, I have updated the "change sponsored?" field to say "Seeking cosponsors". It might help to get this some attention. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21459] Allow migrating requests between ILL and purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21459 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 --- Comment #1 from Owen Leonard --- Created attachment 148023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148023=edit Bug 33185: Use template wrapper for tabs on authority and biblio MARC details This patch updates the MARC detail views of bibliographic and authority records so that they use the new WRAPPER directives to build tabs. To test, apply the patch and locate a bibliographic record in the catalog. - Click the "MARC" menu item in the left-hand sidebar. - Confirm that all tabs work correctly. Perform the same test by going to Authorities and doing a search for authorities. Clicking one of the results should take you to a tabbed MARC view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard changed: What|Removed |Added Blocks||33185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33185] New: Use template wrapper for tabs on authority and biblio MARC details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 Bug ID: 33185 Summary: Use template wrapper for tabs on authority and biblio MARC details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, the bibliographic MARC detail page and authority detail pages should be updated to use the new WRAPPER for tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #26 from Martin Renvoize --- All working fantastically and feels much cleaner. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147825|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 148022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148022=edit Bug 33080: Adapt other use-cases This patch adapts the other controllers that rely on add_pagination_headers outside of `objects.search`. To test: 1. Apply this patchset 2. Run: $ ktd --shell $ prove t/db_dependent/api/v1/* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Pagination.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147824|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 148021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148021=edit Bug 33080: Allow pagination to be built from stashed values The way the old `objects.search` was build implied several totals were calculated there, and passed to the `$c->add_pagination_headers` helper. With the introduction of `objects.search_rs` and the ability of doing things to the resultset afterwards, it felt like out of place to have the pagination headers be implicitly set inside `objects.search_rs`. This patch makes the search_rs stash some required values (from the original request) and makes `add_pagination_headers` accept those values. This way other callers can still build their own pagination values, while allowing this simplified implementation. Full-stack tests still pass, and the helper tests are moved to the `db_dependent` section and are now more meaningful as well To test: 1. Apply this patch 2. Run: $ ktd --shell $ prove t/db_dependent/Koha/REST/Plugin/Pagination.t \ t/db_dependent/api/v1/ => SUCCESS: Tests pass! Nothing broken! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147823|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 148020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148020=edit Bug 33080: Introduce objects.search_rs, objects.find_rs and objects.to_api This patch introduces the mentioned helpers, and reimplements objects.search and objects.find in terms of them. To test: 1. Apply patch 2. restart_all 3. Check that any API that uses objects.search helper is still running (GET /api/v1/items, GET /api/v1/holds, etc) 4. prove t/db_dependent/Koha/REST/Plugin/Objects.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #5 from Laura Escamilla --- Caught an error. I will work on updating the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33184] Warnings when running holds queue builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33184 --- Comment #1 from Kyle M Hall --- Created attachment 148019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148019=edit Bug 33184: Warnings when running holds queue builder If a hold was fillable when the holds queue builder starts, but is no longer fillable when the builder gets to that hold's record ( for example, an item was trapped to fill that hold so the hold is now "found" ), it will generate warnings like: Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/HoldsQueue.pm line 219. Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/HoldsQueue.pm line 220. Test Plan: 1) Run holds queue builder from the command line 2) While it is running fill a hold 3) Note the warning generated by build_holds_queue.pl 4) Apply this patch 5) Repeat steps 1-2 6) No warnings! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
