[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

--- Comment #4 from Aleisha Amohia  ---
Created attachment 148440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148440=edit
Bug 33260: [WIP] Add Notice management tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

--- Comment #3 from Aleisha Amohia  ---
Created attachment 148439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148439=edit
Bug 33260: Add a patron getter method to Koha::Notice::Message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

--- Comment #2 from Aleisha Amohia  ---
Created attachment 148438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148438=edit
Bug 33260: Add NoticesManagement system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

--- Comment #1 from Aleisha Amohia  ---
Created attachment 148437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148437=edit
Bug 33260: Add view_generated_notices user permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33224] OPACHoldsIfAvailableAtPickup and no on-shelf holds don't mix well

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33224

Hammat wele  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33224] OPACHoldsIfAvailableAtPickup and no on-shelf holds don't mix well

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33224

Hammat wele  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30172] Background jobs failing due to race condition

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172

Nick Clemens  changed:

   What|Removed |Added

 CC||janus...@gmail.com

--- Comment #46 from Nick Clemens  ---
*** Bug 33287 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33287] Race condition in Koha::BackgroundJob?

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33287

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Nick Clemens  ---
This should be fixed in 22.11.05+

*** This bug has been marked as a duplicate of bug 30172 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33287] Race condition in Koha::BackgroundJob?

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33287

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340

Cheryl  changed:

   What|Removed |Added

 CC||clack...@fargolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33224] OPACHoldsIfAvailableAtPickup and no on-shelf holds don't mix well

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33224

--- Comment #1 from Hammat wele  ---
Created attachment 148436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148436=edit
Bug 33224: OPACHoldsIfAvailableAtPickup and no on-shelf holds don't mix well

When OPACHoldsIfAvailableAtPickup preference is set to Don't allow and
circulation rules allow on-shelf holds only if any unavailable, and we have a
record with a checked out copy at Centerville and an available copy at Midway,
a Midway patron should not be able to place a hold for pickup at Midway since
the Midway copy is available.

This is the setting:
- circulation rules allow on-shelf holds only if any unavailable
- OPACHoldsIfAvailableAtPickup is set to Don't allow

To test:
1. Set up the circulation rule so that on-shelf holds are allowed ('Yes')
2. Create a record with two items, one at Centerville and one at Midway
3. Check out the Centerville item
4. Log into the OPAC with a Midway patron (I used Henry Acevedo)
5. Try to place a hold on the record
   --> Midway is not a valid pickup location (correct behaviour)
6. Cancel
7. Change the circulation rules so that on-shelf holds are only allowed 'if any
unavailable'
8. Try to place a hold on the record from the OPAC again
   --> The system allows you to place the hold for pickup at Midway (incorrect
behaviour)
9. Optionally, check the Holds to pull for Midway (the hold is there, it
shouldn't)
10. Optionnaly, check in the Midway item (it is trapped for Henry's hold)
11. Apply the patch
12. Try again to place a hold on the record from the OPAC
   --> it is impossible to select Midway, Midway is not a valid pickup location

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33224] OPACHoldsIfAvailableAtPickup and no on-shelf holds don't mix well

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33224

Hammat wele  changed:

   What|Removed |Added

 CC||hammat.w...@inlibro.com
   Assignee|koha-b...@lists.koha-commun |hammat.w...@inlibro.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||33288


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288
[Bug 33288] Catalog concerns - Fallback email when CatalogerEmails is empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33288] Catalog concerns - Fallback email when CatalogerEmails is empty

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||31028


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalog records
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33288] New: Catalog concerns - Fallback email when CatalogerEmails is empty

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288

Bug ID: 33288
   Summary: Catalog concerns - Fallback email when CatalogerEmails
is empty
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

I'm not sure if this is needed, but I think in other instances where there is a
syspref for an email address, there are fall backs (for example I think
ILLDefaultStaffEmail falls back to the library email, then
KohaAdminEmailAddress).

We should probably do something similar? Since a bibliographic record is not
necessarily attached to one specific library, we could fall back to KohaAdmin
immediately.
1) CatalogerEmails syspref
2) KohaAdminEmailAddress

Currently, if there is no email in CatalogerEmails, no email is sent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159

--- Comment #33 from Janusz Kaczmarek  ---
(In reply to Nick Clemens from comment #29)
> I filed bug 33277 - I think we can require that one before pushing, but
> still work on a new bug, expanding the tests and code there, but agreeing on
> this base as it solves the problem for some cases.

Nick, OK, I understand.  But we have still remember about two other classes of
problems:

1. 6XX _7 $a NNN $2 

   but no 040 $f in auth rec.  This is common and perfectly legal when is 
   planed to have only one thesaurus in the system - like in data from NLPol,
   e.g.:
   http://data.bn.org.pl/api/institutions/authorities.marcxml?id=a001003606
   -- the auth record is to be used in 6XX (note 008/15='a') with 2nd ind. = 7
   (note 008/11 = 'z')

   and the use example:
http://data.bn.org.pl/api/networks/bibs.marcxml?id=b003061976:
   
   Literatura angielska
   DBN
   


2. 6XX _4 -- we should look for an auth rec. with 008/11 = '|', non 'n' ('n'
   means it is not, roughly speaking, 'it is not for 6XX', and more precisely:
   "is not appropriate for use as a subject added entry in bibliographic
   records").


You can have a look at the code proposed in Bug 32916 (where all the problems
have been solved) and adapt it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

--- Comment #4 from Phil Ringnalda  ---
Not sure how many other cases it would enable, but the bug 33159 comment 28
thing of searching for Heading-use-main-or-added-entry = 'a' while linking
1xx/7xx would work for LCSH plus FAST, since the FAST name authority records
correctly have 008/14 set to b.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33243] Reindex only Biblios changed in the last x minutes in Elasticsearch (ES)

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33243

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29921

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29921] Allow to index in Elasticsearch all records modified since a given date

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29921

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33243

--- Comment #6 from Katrin Fischer  ---
The idea is a little similar to bug 33243

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31056] Unable to 'Close and export as PDF' a basket group

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056

Katrin Fischer  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #12 from Katrin Fischer  ---
*** Bug 32077 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32077] 'Close and Export as PDF' doesn't work on basketgroups page

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32077

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 31056 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33287] New: Race condition in Koha::BackgroundJob?

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33287

Bug ID: 33287
   Summary: Race condition in Koha::BackgroundJob?
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P3
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: janus...@gmail.com
QA Contact: testo...@bugs.koha-community.org

With 22.11.03, I am experiencing the following: with ES indexing on, some
record, sometimes, are not being indexed.  A long time after record insertion I
can still find respective entries in Administration > Manage jobs, and also
background_jobs entries with status ‘new’, background_jobs.enqueued_on equal to
respective action_logs.timestamp entry, background_jobs.started_on ==
background_jobs.ended_on == NULL.  At the same time, in worker-output.log there
is a line like:

[2023/03/20 17:18:10] [WARN] No job found for id=13218 main::
/usr/share/koha/bin/background_jobs_worker.pl (114)

What is worth noting, the timestamp from worker-output.log is identical with
those of action_logs.timestamp and background_jobs.enqueued_on.

Closer inspection of rabbitmq shows that the queue is empty.

I wonder if the following scenario could be true:

1. in Koha::BackgroundJob::enqueue, the job description is being stored in DB
and the job is enqueued, i.e. sent to rabbitmq

2. the worker process immediately reads the queue element from rabbitmq,
getting the job_id as a part of the answer ($args->{job_id})

3. as a consequence, the worker tries to get the job from DB with
Koha::BackgroundJobs->find($args->{job_id}), but the DBIx at this very moment
Koha::BackgroundJobs does not answer with a job object, because 'store' story
has not finished yet (?)

4. as a result, the worker generates the warning "No job found for id=n"

5. unfortunately, the element has already been read from the queue and the
worker will never return to it

When I than imitate the worker function with my own script, looking for the
unfulfilled background jobs, I get the job objects from Koha::BackgroundJobs
and I can successfully call 

$args = $job->json->decode($job->data);
and 
$job->process( $args );

If p. 3 was true, then we would have a race condition here.  Or maybe there is
another explanation for this behavior...?

I wonder if anybody is experiencing same problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||33286


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286
[Bug 33286] 'Catalog record' should be 'Bibliographic record'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||31028


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalog records
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33286] New: 'Catalog record' should be 'Bibliographic record'

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286

Bug ID: 33286
   Summary: 'Catalog record' should be 'Bibliographic record'
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I noticed in the new 'report a concern' feature, we talk about 'catalog
records'. This is not a term used anywhere in Koha. The feature doesn't seem to
apply to authority records, so I think we should change it to 'bibliographic
records'.

To replicate:
1. Go to Administration > Global system preferences
2. Search for 'concern'
   --> The description for CatalogConcerns is "Allow/Don't allow staff to
report concerns about catalog records." (should be "[...] about bibliographic
records.")
   --> The description for OpacCatalogConcerns is "Allow/Don't allow OPAC users
to report concerns about catalog records." (should be "[...] about
bibliographic records."

I didn't check elsewhere yet... Just getting into documenting this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412

Joseph Alway  changed:

   What|Removed |Added

 CC||jbal...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33243] Reindex only Biblios changed in the last x minutes in Elasticsearch (ES)

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33243

--- Comment #5 from Katrin Fischer  ---
A where statement might be nice, then you could use the timestamp, but also use
it after SQL updates/bulk changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285

--- Comment #1 from Nick Clemens  ---
Created attachment 148435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148435=edit
Bug 33285: Allow specifying the delimeter for runreport.pl

To test:
1 - Write a report in koha
2 - perl misc/cronjobs/runreport.pl --format csv 1 (or correct report number)
3 - Note you get commas
4 - Apply patch
5 - Repeat #2 - no change
6 - perl misc/cronjobs/runreport.pl --format csv --separator "|" 1
7 - Now it is pipe delimited
8 - perl misc/cronjobs/runreport.pl --format tsv --separator "|" 1
9 - Error is reported, you cannot set separator unless csv
10 - Try other separators

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33285] New: It should be possible to specify the separator used in runreport.pl

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285

Bug ID: 33285
   Summary: It should be possible to specify the separator used in
runreport.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||33284


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284
[Bug 33284] checkout_renewals table retains checkout history in violation of
patron privacy
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33284] New: checkout_renewals table retains checkout history in violation of patron privacy

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284

Bug ID: 33284
   Summary: checkout_renewals table retains checkout history in
violation of patron privacy
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Depends on: 30275

The checkout_renewals table introduced in bug 30275 can retain a link between a
patron and an issue_id when the patron's privacy is set to Never. That data
should be anonymized.

To recreate:
- have a patron with their privacy set to Never retain reading history
- check an item out to the patron, renew it via the OPAC
- confirm your patron's borrowernumber can be found in
checkout_renewals.renewer_id and the issue_id for your checkout can be found in
checkout_renewals.checkout_id
- check your item in
- confirm your patron's borrowernumber has been removed from
old_issues.borrowernumber
- confirm your patron's borrowernumber and the issue_id for your checkout can
still be found in checkout_renewals.checkout_id (along with a note that the
renewal happened via the OPAC, thereby making it perfectly clear that this was
a patron renewing the item they had checked out themselves).

Should we not replace checkout_renewals.renewer_id with the anonymous patron's
borrowernumber when the item is returned, if the patron is set to not retain
reading history?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
[Bug 30275] Checkout renewals should be stored in their own table
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #12 from Jonathan Druart  ---
This is ready for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33283] New: Curbside pickups - Rogue curbside pickups

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33283

Bug ID: 33283
   Summary: Curbside pickups - Rogue curbside pickups
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Not sure if this is something that would happen IRL, but I have some rogue
curbside pickup appointments in my installation that I can't remove except by
going into the database.

I think maybe it's the filters in the curbside pickup lists that are a bit too
restrictive, removing anything that is not today?

Not sure how to replicate this one except make appointments and leave them
there...

In the patron's account, I have two notifications about curbside pickups
https://snipboard.io/whQPBJ.jpg

There is nothing in the "To be staged" report https://snipboard.io/GTkiNZ.jpg

There is no "Delivered" report except "Delivered today", which is also empty
https://snipboard.io/jdF8gW.jpg

The patron doesn't currently have any holds, so I can't cancel the holds to
cancel the pickups.

In the database, for this patron

select * from curbside_pickups where borrowernumber = 37 \G;
*** 1. row ***
   id: 9
   borrowernumber: 37
   branchcode: CPL
scheduled_pickup_datetime: 2023-02-04 13:00:00
  staged_datetime: NULL
staged_by: NULL
 arrival_datetime: NULL
   delivered_datetime: NULL
 delivered_by: NULL
notes: 
*** 2. row ***
   id: 23
   borrowernumber: 37
   branchcode: CPL
scheduled_pickup_datetime: 2023-02-06 13:40:00
  staged_datetime: 2023-02-06 11:37:52
staged_by: 51
 arrival_datetime: 2023-02-06 11:39:20
   delivered_datetime: 2023-02-06 11:39:35
 delivered_by: 51
notes: 
2 rows in set (0.000 sec)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20605] Make possible to set patron's privacy from staff client

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20605

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||esth...@sodaspringsid.com

--- Comment #1 from Andrew Fuerste-Henry  ---
*** Bug 26413 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26413] Allow changing privacy settings for reading history from the staff interface

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26413

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Andrew Fuerste-Henry  ---


*** This bug has been marked as a duplicate of bug 20605 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

--- Comment #12 from Nick Clemens  ---
(In reply to Nick Clemens from comment #11)
> (In reply to David Cook from comment #6)
> > Is this work in progress or ready for testing?
> 
> This can now be tested, template chomping removed in favor of bug 20657

It won't completely resolve slowness, but it should offer an improvement where
there are many items on a bib

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

--- Comment #11 from Nick Clemens  ---
(In reply to David Cook from comment #6)
> Is this work in progress or ready for testing?

This can now be tested, template chomping removed in favor of bug 20657

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

--- Comment #10 from Nick Clemens  ---
Created attachment 148434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148434=edit
Bug 33167: Add a filter relationship for branchtransfers

Prefetching is useful, but we don't want to fetch all the inactive
transfers for an item. This patch adds a filtered relationship and
updates get_transfer to use this

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

--- Comment #9 from Nick Clemens  ---
Created attachment 148433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148433=edit
Bug 33167: Use 'host_items' param to fetch all items at once

This patch adjusts the detail page to fetch items and host items
together, and prefetches transfers and checkouts

To test:
1 - Enable easy analytics
2 - Attach some items to a bib
3 - Checkout an item on the bib
4 - View the details page
5 - Apply patch
6 - View details page, confirm nothign has changed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

--- Comment #8 from Nick Clemens  ---
Created attachment 148432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148432=edit
Bug 33167: Add 'host_items' param to Koha::Biblio->items

This patch adds an option to the $biblio->items method to allow
retrieving the items and analytic items for a record. This is intended
to allow fetching a single Items object, and related object, rather than
having to fetch the items, and the host items, and push them together

This is step towards being able to fetch items using API/DataTables directly

To test:
1 - prove -v t/db_dependent/Koha/Biblio.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148082|0   |1
is obsolete||
 Attachment #148083|0   |1
is obsolete||
 Attachment #148084|0   |1
is obsolete||
 Attachment #148085|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 148431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148431=edit
Bug 33167: Cleanup staff detail page

This patch begins reduing some of the extra things we are doing in
detail.pl that could easily be handled in the templates - fetching
authorised values and branches etc

It also removes a loop to find items that should be hidden, and instead
uses a searh parameter

The template changes either use item object rather than passed
variables, or utilize plugins to fetch authorised valued

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #5 from Pedro Amorim  ---
This is not done yet, there's something weird happening with Packages_specs.ts.
It doesn't fail running cypress open, but sometimes fails running cypress
through CLI (headless), it's hard to pinpoint because it doesn't always fail.

I think it's something to do with the loading dialog modal.
Following the tests in the browser, the "Loading..." dialog modal is always
present, and it seems to sometimes block a click() in Packages_specs.ts.
Instead of just adding {force:true} to the click(), I'm trying to figure out
why "Loading..." modal never stops showing with Cypress on the browser, but
haven't figured it out yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #4 from Pedro Amorim  ---
Created attachment 148430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148430=edit
Bug 33282: Feed an array of titles so that no dialog message appears, including
but not limited to the one we're testing for

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #3 from Pedro Amorim  ---
Created attachment 148429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148429=edit
Bug 33282: Move get_title to index.js to be invoked by different specs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #2 from Pedro Amorim  ---
Created attachment 148428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148428=edit
Bug 33282: Remove redundant intercept

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #1 from Pedro Amorim  ---
Created attachment 148427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148427=edit
Bug 33282: Rename Dialog.spec.ts to Dialog_spec.ts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

--- Comment #19 from Nick Clemens  ---
Rebased, it now works - tests fail with out the patch, they succeed with the
patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148425|0   |1
is obsolete||

--- Comment #18 from Nick Clemens  ---
Created attachment 148426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148426=edit
Bug 23102: Selenium test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148424|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 148425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148425=edit
Bug 23102: Selenium test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] New: Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Bug ID: 33282
   Summary: Cypress tests are failing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: pedro.amo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.druart+k...@gmail.com,
martin.renvo...@ptfs-europe.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

--- Comment #16 from Nick Clemens  ---
Created attachment 148424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148424=edit
Bug 23102: Selenium test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

Nick Clemens  changed:

   What|Removed |Added

  Attachment #97581|0   |1
is obsolete||
  Attachment #98977|0   |1
is obsolete||
  Attachment #98978|0   |1
is obsolete||

--- Comment #15 from Nick Clemens  ---
Created attachment 148423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148423=edit
Bug 23102: 404 errors on page causes SCI user to be logged out

To test:
 1 - Have something on the SCO page that won't load
 2 - Add the self_checkin_module and self_checkout_module permissions to the
AutoSelfCheck user
 3 - Access the selfcheckout module
https://yoursite.org/cgi-bin/koha/sco/sco-main.pl
 4 - Sign in
 5 - Click 'Finish'
 6 - Yes to print a receipt
 7 - You are asked to sign in again
 8 - Repeat with the SCI module
 9 - Apply patch
10 - Repeat, but this time the slip can be printed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33243] Reindex only Biblios changed in the last x minutes in Elasticsearch (ES)

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33243

--- Comment #4 from Nick Clemens  ---
In other scripts we use a more generic 'where' option, this allows us to use
any SQL to limit. I think the same would be better here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21762] ES: Is it possible to differentiate between any and anywhere?

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21762

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
Yes, this works now if you use ElasticsearchMARCFormat = Searchable array

A keyword search right now uses all defined fields that are marked searchable

When you have records as a searchable array you also have the option tot search
the entire record

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33164] Return claim message shows intermittently when BlockReturnOfLostItems enabled

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33164

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

--- Comment #2 from Phil Ringnalda  ---
Wouldn't the correct fix be to instead move the processing of a ReturnClaims
message up out of the errmsgloop section, up around Wrongbranch? Otherwise,
someone else is going to show up with a workflow that involves withdrawing
claimed returns and wanting to resolve them at checkin.

If we believed in comments, the comment for the "# Error messages" loop would
be something like "Process messages that only need to be stuffed into
@errmsgloop, and which don't mind being randomly kept or ignored if something
sets $exit_required_p". Since ReturnClaims doesn't match either of those, it's
just in the wrong place (other than having to still have an empty elsif, to
stay out of the "unknown error code" path).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This|This enhancement adds a
  release notes||POST endpoint for /biblios
   ||allowing third parties to
   ||interact with cataloging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

Martin Renvoize  changed:

   What|Removed |Added

   Severity|new feature |enhancement
  Text to go in the||This
  release notes||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

--- Comment #12 from Martin Renvoize  ---
OK.. Ignore that.. Whilst I still think it was a mistake to backport at this
stage.. it's also a challenge to revert now too...  we'll be most stable by
keeping it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180

Owen Leonard  changed:

   What|Removed |Added

 Attachment #148015|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 148422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148422=edit
Bug 33180: Use template wrapper for tabs: Budgets and Search engine
configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.05.00,22.11.04   |23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33251] POST /biblios incorrect response

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33251
Bug 33251 depends on bug 31800, which changed state.

Bug 31800 Summary: REST API: POST endpoint for Biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33227] OpenAPI validation is failing for paths/biblios.yaml

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33227
Bug 33227 depends on bug 31800, which changed state.

Bug 31800 Summary: REST API: POST endpoint for Biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801
Bug 31801 depends on bug 31800, which changed state.

Bug 31800 Summary: REST API: POST endpoint for Biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus]

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788
Bug 31788 depends on bug 31800, which changed state.

Bug 31800 Summary: REST API: POST endpoint for Biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Martin Renvoize  ---
The backport here causes test failures, (git auto-merged more than expected
into the spec).

I also feel like we need to get the whole tree working as a set before we
consider a possible backport of this.. whilst it's API and thus Dev facing only
really and might make sense to backport at a future point.. I think we need to
focus on stability in this area first.

Reverting for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32421] Add collection ( ccode ) column to holds to pull

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32421

--- Comment #11 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32421] Add collection ( ccode ) column to holds to pull

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32421

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32421] Add collection ( ccode ) column to holds to pull

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32421

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #10 from Martin Renvoize  ---
Minor enhancement and I've decided we're early enough in the cycle to allow
it.. backporting to 22.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30555] Add more sample notice for SMS messages

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30555

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Needs documenting

--- Comment #12 from Martin Renvoize  ---
As much as I like this change, it's cetainly an enhancement that wouldn't be
expected on a running stable branch.. so chosing not to backport this to
22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

--- Comment #35 from Martin Renvoize  ---
Final follow-up also pushed to 22.11.x for 22.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161

--- Comment #32 from Martin Renvoize  ---
Will be in 22.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00, 22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281

--- Comment #1 from Nick Clemens  ---
Created attachment 148421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148421=edit
Bug 33281: Improve detail auth links and add to marc preview

This patch adds atuh links tot he marc preview, and makes detial auth links
open in a
new tab/window and consolidates some code

To test:
1 - View a record linked to authorities in staff client
2 - Note links have no hover text, and open in same window
3 - Apply patch
4 - Restart and reload
5 - Note links now have a hint
6 - Note they open in new window
7 -  View marc preview and note there are similar links

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33281] New: Improve authority links and add them to MARC preview

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281

Bug ID: 33281
   Summary: Improve authority links and add them to MARC preview
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

--- Comment #4 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3831] Add a warning/hint when FA framework is missing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

--- Comment #18 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3831] Add a warning/hint when FA framework is missing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33276] Library limitations will cause data loss when editing locations in the subscription form

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33276

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal
Summary|Library limitations will|Library limitations will
   |cause data loss when|cause data loss when
   |editing serial items|editing locations in the
   ||subscription form

--- Comment #4 from Katrin Fischer  ---
(In reply to Thibaud Guillot from comment #3)
> (In reply to Katrin Fischer from comment #1)
> > Hi Thibaud, I think the item form in acquisitions is also based on the same
> > code as the one in serials.
> 
> Hi Katrin, 
> 
> Hum.. I wrote a patch but it's not like in items, the form isn't generated
> on the same way.. or I miss up :/

What I meant: 

The item forms in Koha are built with different code:

* Cataloguing / Item form
* Serial item form / Acquisition item form

But I misunderstood your patch: you are updating the location in the
subscription form. That's also a great catch and I am very happy to see more
and more of these issues fixed!

There is also an option to set the collection for the subscription now, I think
we'll need the same fix there. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

Martin Renvoize  changed:

   What|Removed |Added

   Severity|minor   |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161

--- Comment #31 from Martin Renvoize  ---
As agreed with Tomas, I'm backporting this one :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278

--- Comment #2 from Owen Leonard  ---
Created attachment 148420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148420=edit
Bug 33278: Correct JS for activating default tab on various pages

The conversion of the header search tabs to Bootstrap resulted in a bug
on several staff interface pages: The first tab isn't selected by
default. The jQuery selector isn't specific enough.

The patch also corrects a template error which was introduced to
merge-record.inc by Bug 32683.

To test, apply the patch and test the following pages to confirm that
the first tab on each page is selected by default:

- Catalog -> Advanced search
- Catalog -> MARC details
- Catalog -> Search results -> Merge
- Administration -> Authorized values -> Edit
- Administratoin -> Library transfer limits
- Administration -> Item types -> Edit
- Authorities -> Authority details
- Authorities -> Search -> Merge

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483

Pablo López Liotti  changed:

   What|Removed |Added

 CC||palio...@mdp.edu.ar

--- Comment #15 from Pablo López Liotti  ---
Hi, I'm upgrading a Koha 21.05 in Debian 9.5 to Koha 22.05.

After I do command line upgrade of koha-common, the intranet shows web install.
Here, in tables structure update, the process stop with this message:

Updating database structure
Update errors :

Upgrade to 22.05.06.001 [13:31:19]: Bug 30483 - Make issues.borrowernumber and
itemnumber NOT NULL
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column
'borrowernumber': used in a foreign key constraint 'issues_ibfk_1' at
/usr/share/koha/lib/C4/Installer.pm line 739

Now, what can I do?
Thks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_22_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32495] Required fields in API and UI form don't match

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32495

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|additional_work_needed, |
   |rel_22_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278

Owen Leonard  changed:

   What|Removed |Added

Summary|Advanced search page first  |Correct JS for activating
   |tab not activated   |default tab on various
   ||pages

--- Comment #1 from Owen Leonard  ---
There are other pages which need the same correction, so I'm re-titling the
bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33280] New: Display more information about title within the Inventory Results

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33280

Bug ID: 33280
   Summary: Display more information about title within the
Inventory Results
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

More information such as publication date should be displayed within the
Inventory Tool results.  As libraries would like to easily look at their
shelves and inventory, it would useful and streamline the process.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33279] New: OAI-PMH should not die on record errors

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33279

Bug ID: 33279
   Summary: OAI-PMH should not die on record errors
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Currently if the OAI listRecords command hits a bad record the script dies and
there is no output.

We should wrap the code in an eval or try and handle the error gracefully,
allowing the rest of the catalogue to be harvested and reporting the problem in
a way it can be addressed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277

Nick Clemens  changed:

   What|Removed |Added

 CC||janus...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >