[Koha-bugs] [Bug 33392] New: Administrative Lockout of system

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33392

Bug ID: 33392
   Summary: Administrative Lockout of system
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: PC
OS: Linux
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jenni.nee...@defence.gov.au
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

In the process of running an import of bibliographic records as part of
migration process, Koha shut down and does not recognise the admin login
supplied at installation or the user account login created for me, the library
manager. How can we establish a new account to use the system again. Or do we
need to abandon our account and start again. We are stool in the set up stage
and our site is not test live.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299

Nick Clemens  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148823|0   |1
is obsolete||
 Attachment #149013|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 149073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149073=edit
Bug 33299: Item type column displays translated_description when placing item
level holds in OPAC

0. go to detail page of a record->place hold->"show more options"->"specific
item"
1. Item type column is empty when placing item level holds in OPAC
(or only the image is displayed)
2. apply patch
3. now the translated description is also shown
4. test with another language
4. please sign off ;-)

Signed-off-by: Amaury Gau 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31314] Remove GetItemsInfo from opac-reserve.pl

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31314

Nick Clemens  changed:

   What|Removed |Added

 Blocks||33299


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299
[Bug 33299] Item type column is empty when placing item level holds in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 Depends on||31314


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31314
[Bug 31314] Remove GetItemsInfo from opac-reserve.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC)

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148548|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 149072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149072=edit
Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC)

This patch improves the CSS for styling the OPAC cart's "remove" link in
search results so that the color is consistent within alternating table
row colors.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a search in the OPAC which will return multiple results.
- Click the "Add to cart" link next to multiple results.
- The "remove" link which appears should be the correct red color
  whether the table row background is white or grey.

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC)

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33149] Use template wrapper for breadcrumbs: Circulation part 1

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

--- Comment #4 from Nick Clemens  ---
Probably we should move this page to the catalog folder, however, the
permission  here is circ based, so it would be a bigger job and requires
discussion. IN the context of breadcrumbs, the change makes sense and is small
so passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33149] Use template wrapper for breadcrumbs: Circulation part 1

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148901|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 149071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149071=edit
Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

The patch also makes a minor change to bookcount.pl to allow for correct
display of the record title using the biblio-title include.

Navigation context for bookcount.tt has been changed to "catalog" from
"circulation" because the page is linked to from a catalog-related page.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation home page
  - Checkout notes
  - Article requests
  - Transfer
  - Overdues with fines
  - Check out -> Check out to patron ->
- Batch check out
- Catalog -> Search -> Bibliographic record -> Items
  - View item's checkout history. The updated page should show this new
breadcrumb sequence: Home -> Catalog -> [title] -> Items ->
Circulation statistics

Signed-off-by: Andrew Auld 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33149] Use template wrapper for breadcrumbs: Circulation part 1

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33148] Use template wrapper for breadcrumbs: Cataloging

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33148

Nick Clemens  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |
 CC||n...@bywatersolutions.com

--- Comment #5 from Nick Clemens  ---
(In reply to Lucas Gass from comment #2)
> I have one comment regarding the advanced editor vs basic edtior:
> 
> New record in the basic editor:
>  -Cataloging > Add MARC record 
> 
> New record in the advanced editor:
>  -Cataloging > Editor 
> 
> Existing record in the basic editor:
>  -Cataloging > CSS : the definitive guide / Eric A. Meyer. (Record number
> 12) 
> 
> Existing record in the advanced editor:
>  -Cataloging > Editor 
> Should these made to match? And if so should we do it here or in a different
> bug?

Yes, please file a new bug, these seem to exist before these patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33148] Use template wrapper for breadcrumbs: Cataloging

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33148

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148883|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 149070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149070=edit
Bug 33148: Use template wrapper for breadcrumbs: Cataloging

This patch updates several cataloging templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Cataloging -> Home page
  - Cataloging search results
- Select two results and 'Merge selected'
  - Basic MARC editor
  - Advanced MARC editor
  - Item edit page
 - Catalog -> Search -> Bibliographic record details
   - Edit -> Attach item
   - Edit -> Link to host record (must have EasyAnalyticalRecords
 preference enabled)

Signed-off-by: Clemens Tubach 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33148] Use template wrapper for breadcrumbs: Cataloging

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33148

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32263] Capitalization: ...and on the Libraries page in the OPAC.

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148979|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 149069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149069=edit
Bug 32263: Fix capitalization for "...and on the Libraries page in the OPAC."

Small fix to correct the capitalization in library editing mode to
display "...and on the libraries page in the OPAC.".

To Test:
1. apply patch
2. navigate to Administration -> Libraries
3. edit any library
4. confirm that the note underneath the option for "Public" now
   displays with the correct capitalization ("... on the libraries
   page...")

Signed-off-by: Owen Leonard 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32263] Capitalization: ...and on the Libraries page in the OPAC.

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27513] Add description to reports page

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
Testing notes (using KTD):

1. Not related to this bug, but on the reports results page, the text for
'Notes:' and 'Total number of results:' aren't aligned with the labels (the
text is slightly higher than the labels). Not sure whether there is already a
bug for this or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27513] Add description to reports page

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513

David Nind  changed:

   What|Removed |Added

 Attachment #149012|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 149068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149068=edit
Bug 27513: Add notes to variables for report parameters template

This patch adds the TT variable 'notes' to the variables
that guided_reports.pl passes to the template guided_reports_start.tt
during SQL parameters entry in the phase 'Run this report'.

To test:
1. apply the patch
2. navigate to Reports -> Guided Reports -> Create from SQL
3. create an SQL report that includes at least one parameter, e.g.:
   SELECT barcode FROM items WHERE homebranch=<>
   the actual SQL and name of the report doesn't matter much, just make
   sure that you also put a note e.g. "Test text for display" in the
   field "Notes:" before you save the report.
4. run the report
5. the note you entered should now be displayed below the heading
   "Enter parameters for report..."

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27513] Add description to reports page

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes (using KTD):

1. To see the highlight in the left sidebar, select any of the report creation
links from the reports page (such as create guided report, create from SQL, and
use saved).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356

David Nind  changed:

   What|Removed |Added

 Attachment #148917|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 149067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149067=edit
Bug 33356: Highlight mana-kb from reports when not configured

This patch adds a 'Knowledgebase' info block under 'Useful resources' on
teh report creation pages. This highlights to reports users that mana
has not be configured as yet, hopefully encouraging them to turn it on.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33342] Fix framework handling in manage-marc-import.pl

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
If you could add a test plan, I would be more than happy to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548

--- Comment #8 from Pedro Amorim  ---
I think this needs to be properly documented, or included in the fields list
somehow, or maybe a note mentioning this in the UI? I have no idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548

Pedro Amorim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #149035|0   |1
is obsolete||

--- Comment #7 from Pedro Amorim  ---
Created attachment 149066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149066=edit
Bug 32548: Replace while with map

Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #149034|0   |1
is obsolete||

--- Comment #6 from Pedro Amorim  ---
Created attachment 149065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149065=edit
Bug 32548: Add tests

Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #147157|0   |1
is obsolete||

--- Comment #5 from Pedro Amorim  ---
Created attachment 149064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149064=edit
Bug 32548: Make illrequestattributes available in ILL emails

Without this ILL module only provides very limited data to
be included in the notices sent about the request itself.

We have the columns illrequests, but not the illrequestattributes,
that often will contain the more useful information needed.

This patch enables to use values of the illrequestattributs using
[% illrequestattributes. %] in the notices.

To test:
* Apply patch
* First you'll need to activate the ILL module and install a
  backend to use it with. FreeForm was used for this test plan,
  BLDSS is usually also good for testing.
  See: https://wiki.koha-community.org/wiki/ILL_backends
* Also set up an SMTP server to use for notices and make
  sure the email address is set in KohaAdminEmailAddress
  and the user you are using for testing this with.
* Make sure your user has an email address and will receive
  ILL notices by seleting them in the messaging preferences.
* Create an ILL request with the FreeForm backend for your user.
* On the ILL request detail page: "Display supplier metadata"
  Pick some attributes you want to use in the notice
* Go to Tools > Notices and slips and edit ILL_REQUEST_UNAVAIL
* Add some of the attributes you picked. Example:
  [% illrequestattributes.type %]
  [% illrequestattributes.title %]
* Back to the ILL request detail page: Send notice to patron >
  ILL request unavailable
* Go to your patron's account and check the notices tab
* The generated notice shoudl show and include the information
  from the illrequestattributes you picked.

Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #149061|0   |1
is obsolete||

--- Comment #4 from Pedro Amorim  ---
Created attachment 149063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149063=edit
Bug 33381: Change router link active class match rule

This makes it so that the route erm/agreements/1 will also match the
router-link /erm/agreements instead of the previous exact match rule, thus
adding the 'current' class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

--- Comment #14 from Pedro Amorim  ---
(In reply to Hans PĂ„lsson from comment #13)
> it would be
> more logical to say what backends should be visible, since all are addons to
> Koha (mainly plugins).

Hi Hans!
The workflow I'm proposing is: as soon as you install a backend, it's enabled
and showing by default for both Staff and OPAC, as I believe this is likely the
intent (and expectation) of most ILL backend installations (I may be wrong
here, of course!).

This change in the sys pref would provide the option of hiding in the OPAC any
one, or more - or all - installed backends, an improvement over the current
functionality that does not allow for hiding all the backends in the OPAC.

Apologies if not clear enough! Any input or alternative suggestion is welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33370] Agreements_spec.ts is failing randomly

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370

--- Comment #9 from Pedro Amorim  ---
This seems like a decent solution to the problem.

(In reply to Jonathan Druart from comment #8)
> Maybe we could overload cy.visit to not have to add the wait statement all
> over the tests (?)

What do you mean by overload cy.visit?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381

Pedro Amorim  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #3 from Pedro Amorim  ---
Hmm... Giving this a second look, I don't think we should be adding niche ERM
styling cases onto staff-global.scss.

@Joubu this patch also "fixed" (unintentionally, I believe) the jumpy behavior
I mentioned to you on hackfest, I opened bug 33391 for that.

As for this specific bug, I think the selector in your patch is wrong, it
should be not(.disabled) instead of not(:disabled) because we're applying the
"disabled" class, instead of using the "disabled" attribute.

I think we should either:
1) Fix this through styling but keep it in ERM files
2) Fix it through code (make sure .current class is added to the left menu item
when in either FormAdd or Show views for that content type.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391

--- Comment #1 from Pedro Amorim  ---
Created attachment 149062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149062=edit
Bug 33391: Prevent applying hover style on navmenulist currently active item

* Apply patch
* Run yarn css:build
* Do the 2nd example above again and verify

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391

Pedro Amorim  changed:

   What|Removed |Added

Summary|Prevent applying hover  |Currently active menu item
   |style on navmenulist|on navmenulist should not
   |currently active item   |change style on hover

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33391] Prevent applying hover style on navmenulist currently active item

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391

Pedro Amorim  changed:

   What|Removed |Added

Summary|Prevent applying hover  |Prevent applying hover
   |style on navmenulist items  |style on navmenulist
   |that are active |currently active item

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||33391


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391
[Bug 33391] Prevent applying hover style on navmenulist items that are active
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33391] New: Prevent applying hover style on navmenulist items that are active

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391

Bug ID: 33391
   Summary: Prevent applying hover style on navmenulist items that
are active
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pedro.amo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, jonathan.druart+k...@gmail.com,
martin.renvo...@ptfs-europe.com, oleon...@myacpl.org
Depends on: 30952

If you go to system preferences with "Accounting" menu item active:
/cgi-bin/koha/admin/preferences.pl?tab=accounting
Hover on it, you'll see no difference (that's the intended behaviour)

Now go to cataloging tools - inventory with "Inventory" menu item active:
/cgi-bin/koha/tools/inventory.pl
Hover on it, you'll see the :hover is style is overriding the .current style,
resulting in jumpy behaviour with bold->normal font-size.
This is happening in other places (ERM side menu, others).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #149022|0   |1
is obsolete||

--- Comment #2 from Pedro Amorim  ---
Created attachment 149061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149061=edit
Bug 33381: Correct styling in the ERM menu

If you are on /erm/agreements you will notice that the "Agreements" tab on the
menu is correctly highlighted. However if you are on /erm/agreements/add it
won't.

Test plan:
Go to /cgi-bin/koha/erm/agreements/add and confirm that the "Agreements"
tab in styled the same as when you are on /erm/agreements

Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381

Pedro Amorim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23616] Private repeatable note field needed in Serials Subscription Record

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23616

Michaela Sieber  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33298

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33298] Add a internal/non-public note field to serial issues

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33298

Michaela Sieber  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23616

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371

--- Comment #1 from Mason James  ---
Created attachment 149060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149060=edit
Bug 33371: Add 'koha-common.service' systemd service

to test

- install current package
- note following $message on install
 'Failed to enable unit: Unit /run/systemd/generator.late/koha-common.service
is transient or generated.'

- apply patch, build package, install new package
- note $message is gone! :)

- test koha-common.service
   # systemctl start  koha-common
   # systemctl status koha-common | grep running
 Active: active (running) since Sun 2023-04-02 00:27:31 NZDT <<<

   # systemctl stop  koha-common

   # systemctl status koha-common | grep dead
 Active: inactive (dead) since Sun 2023-04-02 00:25:34 NZDT <<<

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371

Mason James  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24968] Add system preference controls for cronjobs

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add Syspref controls for|Add system preference
   |cronjobs|controls for cronjobs

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21548] Make ILL patron category in koha-conf.xml match with ILL patron category in sample data

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548

Katrin Fischer  changed:

   What|Removed |Added

Summary|ILLLIBS patron category /   |Make ILL patron category in
   |partner_code seems  |koha-conf.xml match with
   |extraneous  |ILL patron category in
   ||sample data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21329] Add additional fields to purchase suggestions

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329

Katrin Fischer  changed:

   What|Removed |Added

Summary|Purchase Suggestions Add|Add additional fields to
   |Custom Fields   |purchase suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16700] Quick spine label creator: Add a hint that IntranetUserCSS can be used for styling

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976

--- Comment #29 from Katrin Fischer  ---
Really happy to see this one fixed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168

--- Comment #44 from Mason James  ---
(In reply to David Nind from comment #43)
> Note: I also noticed that for lines 43 and 44 that spaces are used after the
> first tab - do these need to be fixed as well?

hi David
thanks for the sign-off

lines 43 and 44 are OK :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13325] Add logs for budgets and funds

2023-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Michaela Sieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/