[Koha-bugs] [Bug 19814] Batch Check-in function

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

--- Comment #27 from Mubassir Ahsan  ---
Hi,
We are looking for this for localuse records. Everyday users left used books on
the table, we like to add them to localuse check in. We are using blutooth
handheld scanner to capture barcodes. but it is difficult to put all the
barcode one by one. So batch check in is very much needed. 

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19814] Batch Check-in function

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Mubassir Ahsan  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
 CC||mahsa...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #15 from Aleisha Amohia  ---
Hi all, I think this is becoming a problem now - we have a library getting
covers through Syndetics and records with ^979 ISBNs are not fetching covers
successfully.

Any progress on this work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33501] New: Cashup amount should be configurable

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33501

Bug ID: 33501
   Summary: Cashup amount should be configurable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

It seems the Cashup summary only accounts for the cash payment type.  We have a
check payment type that should also be included.  Am I missing a configuration
somewhere, or do we need some way to define what should be included in the
summary and intake balance?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672

--- Comment #7 from Christopher Brannon  ---
Ah!  Thank you for the clarification.  Makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33500] New: Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500

Bug ID: 33500
   Summary: Failing test for t/db_dependent/Circulation.t when
RecordLocalUseOnReturn is set to record
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:

-Set the sys pref 'RecordLocalUseOnReturn' to 'record'.
-prove -v /kohadevbox/koha/t/db_dependent/Circulation.t


# Subtest: Tests for BlockReturnOfWithdrawnItems
1..1
not ok 1 - Item returned as withdrawn, no other messages

#   Failed test 'Item returned as withdrawn, no other messages'
#   at /kohadevbox/koha/t/db_dependent/Circulation.t line 5816.
# Structures begin differing at:
#  $got->[1]{LocalUse} = '1'
# $expected->[1]{LocalUse} = Does not exist
# Looks like you failed 1 test of 1.
not ok 65 - Tests for BlockReturnOfWithdrawnItems
# Subtest: Tests for transfer not in transit

#   Failed test 'Tests for BlockReturnOfWithdrawnItems'
#   at /kohadevbox/koha/t/db_dependent/Circulation.t line 5819.
1..2
not ok 1 - Item is reported to have been transferred

#   Failed test 'Item is reported to have been transferred'
#   at /kohadevbox/koha/t/db_dependent/Circulation.t line 5837.
# Structures begin differing at:
#  $got->[1]{LocalUse} = '1'
# $expected->[1]{LocalUse} = Does not exist
ok 2 - The datesent field is populated, i.e. transfer is initiated
# Looks like you failed 1 test of 2.
not ok 66 - Tests for transfer not in transit

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986

--- Comment #11 from Katrin Fischer  ---
Still not finished here, but I have fixed the QA script complaints :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986

--- Comment #10 from Katrin Fischer  ---
Created attachment 149507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149507=edit
Bug 32986: (QA follow-up) Fix QA script complaints: tabs and TT filters

* Perltidied the section with tabs in printslip.pl
* Fixed indentation and tabs in letter.tt
* Added missing TT filters to members-toolbar.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148376|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 149506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149506=edit
Bug 32986: Add patron_slip module to letters and allow printing on members
account

This patch adds a new module to letters 'patron_slip' / Patrons toolbar
(slip)

This also combines some of the slip printing JS to make things more
direct

To test:
1 - Apply patch
2 - restart_all
3 - yarn build
4 - Confirm you can print slip, summary, quickslip, and checkin slip
  when viewing a patron's account
5 - Enable  DisplayClearScreenButton syspref, and test that it works
  with both values
6 - Go to Tools->Notices and slips
7 - Define a new notice in the 'Patron toolbar (slip)' module
8 - Enter content like below in the 'Print' transport:
Patron has [% borrower.holds.count %] holds

List of holds:
[% FOREACH hold IN borrower.holds %]
===
Reserve id: [% hold.reserve_id %]
Title [% hold.biblio.title %]
[% END %]
9 - Go to patron scree
10 - Note new option under 'Print'
11 - Print the new slip and confirm it works (try with and without
  placing holds for patron

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470

Katrin Fischer  changed:

   What|Removed |Added

Summary|Don't calculate overridden  |Don't calculate overridden
   |values when placing a hold  |values when placing a hold
   |via the REST api|via the REST API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #3 from Katrin Fischer  ---
This is temporarily BLOCKED by the dependent patch waiting for SO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149463|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 149505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149505=edit
Bug 33489: Add indices to default patron search fields

This patch adds indices to the borrowers table to match the default
search fields for patrons.

To test:
1 - Apply patch
2 - Update database
3 - Ensure patron searching works as before

Signed-off-by: David Nind 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29598] Add a preference for default borrower's notice language

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29598

--- Comment #4 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #0)
> Notice language for a new borrower via staff interface defaults to language
> of the staff interface user.
> In the OPAC self registration does not list the field and the value will be
> set to the database default called ... 'default'.
> 
> Would be nice if we could make that more consistent.

I can't reproduce this on master:

* TranslateNotices off: Add a new patron. lang = default
* TranslateNotices on: Add a new patron. lang = default
* TranslateNotices on, staff user set to fr-FR. Add new patron. lang = default

Which version did you test with?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445

--- Comment #1 from Phil Ringnalda  ---
Created attachment 149504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149504=edit
Revert "Bug 29173: Fixed pre-filling of the search form from the "Replace
record with ZR39.50/SRU" (Authority page detail)"

This reverts commit 26c26164ba78029cb99fa99662f9e0a8ce9557df.

Test plan:

1. Without the patch, edit a personal name authority record,  replacing
the value in 100 subfield a (200 subfield a for UNIMARC) with your own
name.
2. Click "Replace record via Z39.50/SRU search" and note that the
prefilled search field contains the original value, not your name.
3. Replace the Author (personal) field with your name again, choose
a search target, and click Search.
4. Note that the results of the search are for the original value, not
for your name.
5. Apply patch, repeat, noting that the search form is prefilled with
your change made in the editor, and any changes you make in the search
form are reflected in what the search results return.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445

Phil Ringnalda  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33416] Agreements.ts is failing

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #6 from Katrin Fischer  ---
This is temporarily BLOCKED by the dependent patch waiting for sign-off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149431|0   |1
is obsolete||

--- Comment #48 from Katrin Fischer  ---
Created attachment 149503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149503=edit
Bug 33104: Remove fieldset

For consistency with "Contacts"

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149422|0   |1
is obsolete||

--- Comment #47 from Katrin Fischer  ---
Created attachment 149502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149502=edit
Bug 33104: Prevent 'Type' to be cleared

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149421|0   |1
is obsolete||

--- Comment #46 from Katrin Fischer  ---
Created attachment 149501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149501=edit
Bug 33104: Add email validation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149420|0   |1
is obsolete||

--- Comment #45 from Katrin Fischer  ---
Created attachment 149500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149500=edit
Bug 33104: Fix translatability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148480|0   |1
is obsolete||

--- Comment #44 from Katrin Fischer  ---
Created attachment 149499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149499=edit
Bug 33104: Add tests

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148479|0   |1
is obsolete||

--- Comment #43 from Katrin Fischer  ---
Created attachment 149498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149498=edit
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148478|0   |1
is obsolete||

--- Comment #42 from Katrin Fischer  ---
Created attachment 149497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149497=edit
Bug 33104: Encrypt password

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148477|0   |1
is obsolete||

--- Comment #41 from Katrin Fischer  ---
Created attachment 149496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149496=edit
Bug 33104: Make the code reusable

We could then reuse it for the contacts code in this same template, on
another bug report.

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148476|0   |1
is obsolete||

--- Comment #40 from Katrin Fischer  ---
Created attachment 149495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149495=edit
Bug 33104: Add the ability to create vendor interfaces

This patchset is adding the ability to create interfaces for vendors.
An interface is a website, software, or portal that you use to manage orders or
gather statistics from the vendor/organisation.

It will help librarians to keep track of those different information
within Koha.

* new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri,
login, password, account_email, notes)
* new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN,
ORDERS, REPORTS
* new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s]
* new method to retrieve the interfaces from the vendor
Koha::Acquisition::Bookseller->interfaces
* Add/Delete interfaces when editing a vendor
* Display the interfaces on the vendor show view

Test plan:
- Add a new vendor
=> Notice the new "Interfaces" block
- Create some interfaces
=> They are display on the vendor show view
=> The password is hashed and can displayed on the demand

QA Note:
The "contacts" code is not very nice and I didn't want to replicate it,
so I went another way and tried to make the code reusable, for further
reutilisation.

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148475|0   |1
is obsolete||

--- Comment #39 from Katrin Fischer  ---
Created attachment 149494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149494=edit
Bug 33104: Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148474|0   |1
is obsolete||

--- Comment #38 from Katrin Fischer  ---
Created attachment 149493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149493=edit
Bug 33104: DBIC changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148473|0   |1
is obsolete||

--- Comment #37 from Katrin Fischer  ---
Created attachment 149492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149492=edit
Bug 33104: DB changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

--- Comment #36 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #35)
> (In reply to Jonathan Druart from comment #30)
> > What are you suggesting? I think this is nicer than the others :D
> > 
> > https://snipboard.io/Iwetbx.jpg
> > 
> > Contacts are missing padding, contracts are in a table (what we don't want
> > here, it won't be easy to read).
> 
> See last patch. Better for consistency, but IMO it was nicer prior to this
> patch (except the background weirdness)
> 
> https://snipboard.io/jv7yIe.jpg

I've filed bug 33499 for improving the vendor detail page.

Otherwise... PQA now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||33499


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499
[Bug 33499] Improve styling of vendor detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33499] Improve styling of vendor detail page

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||33104


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104
[Bug 33104] Add vendor interfaces
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33499] New: Improve styling of vendor detail page

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499

Bug ID: 33499
   Summary: Improve styling of vendor detail page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

There are some inconsistencies on this page we could/should fix.

* The labels of the ordering information and subscriptions section are bold,
but all other labels are not.
* The sections with repeating information (contacts and interfaces) could be
improved for better readability.
* The information takes up a lot of space. I wonder if we could reorder/regroup
the information in a better way maybe?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33315] Missing space in TICKET_NOTIFY

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315
Bug 33315 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33266] Patron name missing space before surname

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33266
Bug 33266 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33498] Catalog concerns - Lots of whitespace before the notice text

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498
Bug 33498 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all'

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494
Bug 33494 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314
Bug 33314 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313
Bug 33313 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33327] Hide resolved catalog concerns by default

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327
Bug 33327 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33288] Catalog concerns - Fallback email when CatalogerEmails is empty

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288
Bug 33288 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286
Bug 33286 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32436] Add 'quick replies' to catalog concerns

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32436
Bug 32436 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435
Bug 32435 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Katrin Fischer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33315] Missing space in TICKET_NOTIFY

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315
Bug 33315 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33266] Patron name missing space before surname

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33266
Bug 33266 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all'

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494
Bug 33494 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33498] Catalog concerns - Lots of whitespace before the notice text

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498
Bug 33498 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33327] Hide resolved catalog concerns by default

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327
Bug 33327 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314
Bug 33314 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313
Bug 33313 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33288] Catalog concerns - Fallback email when CatalogerEmails is empty

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288
Bug 33288 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286
Bug 33286 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32436] Add 'quick replies' to catalog concerns

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32436
Bug 32436 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435
Bug 32435 depends on bug 31028, which changed state.

Bug 31028 Summary: Add 'Report a concern' feature for patrons to report 
concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

--- Comment #498 from Katrin Fischer  ---
(In reply to Caroline Cyr La Rose from comment #497)
> I finished documenting this, but I see there are some patches that still
> need to be pushed. I hesitate to put it to "RESOLVED", but I don't have many
> choices after "Needs documenting" (RESOLVED or CLOSED).
> 
> Can someone with more permissions maybe put it back to Passed QA or Signed
> off?

Hi Caroline, it's a workflow thing, not a permission thing. You can only jump
to certain status from one status... so you might have to step through some in
order to get to where you want to be. - Maybe we could improve this for Needs
documenting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149419|0   |1
is obsolete||

--- Comment #52 from Katrin Fischer  ---
Created attachment 149491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149491=edit
Bug 33103: Prevent vendors to be displayed several times in the search result

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149414|0   |1
is obsolete||

--- Comment #51 from Katrin Fischer  ---
Created attachment 149490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149490=edit
Bug 33103: Fix accessibility issues

* Add spaces
* Add 'Add' and 'Remove' in addition of the icons
* Do not submit the form when enter is hit
* Fix translatability

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148458|0   |1
is obsolete||

--- Comment #50 from Katrin Fischer  ---
Created attachment 149489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149489=edit
Bug 33103: Deal with html tags

HTML tags won't be interpreted. However 

[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148457|0   |1
is obsolete||

--- Comment #49 from Katrin Fischer  ---
Created attachment 149488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149488=edit
Bug 33103: Display the aliases in the dropdown list in ERM

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148456|0   |1
is obsolete||

--- Comment #48 from Katrin Fischer  ---
Created attachment 149487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149487=edit
Bug 33103: Add REST API tests

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148455|0   |1
is obsolete||

--- Comment #47 from Katrin Fischer  ---
Created attachment 149486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149486=edit
Bug 33103: Embed aliases in GET /vendors

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148454|0   |1
is obsolete||

--- Comment #46 from Katrin Fischer  ---
Created attachment 149485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149485=edit
Bug 33103: Make vendors searchable by aliases

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148453|0   |1
is obsolete||

--- Comment #45 from Katrin Fischer  ---
Created attachment 149484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149484=edit
Bug 33103: Add the ability to create vendor aliases

This patchset is adding the ability to create aliases for vendors. It
will then be easier to search for vendors.

* new DB table aqbookseller_aliases(id, vendor_id, alias)
* new pair of Koha classes Koha::Acquisition::Bookseller::Alias[es]
* new method to retrieve the aliases from the vendor
Koha::Acquisition::Bookseller->aliases
* The api spec changes to allow aliases to be embeded on
GET /acquisitions/vendors
* Add/Delete alias when editing a vendor
* Display the aliases on the vendor show view
* Search vendors by aliases
* Display the aliases in the dropdown list of the vendors in the ERM
module

Test plan:
- Create a vendor, add it some aliases
- Edit the vendor, remove some aliases
=> Behaviour must be consistent
- Search the vendor in the acquisition module by its aliases
=> The vendor must be returned in the result
- Go to the ERM module, add a new agreement or license
=> Notice that the dropdown list of the vendors is displaying the
aliases, that make vendors searchable by their aliases

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148452|0   |1
is obsolete||

--- Comment #44 from Katrin Fischer  ---
Created attachment 149483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149483=edit
Bug 33103: Add tests for Aliases Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148451|0   |1
is obsolete||

--- Comment #43 from Katrin Fischer  ---
Created attachment 149482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149482=edit
Bug 33103: Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148450|0   |1
is obsolete||

--- Comment #42 from Katrin Fischer  ---
Created attachment 149481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149481=edit
Bug 33103: DBIC specific

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148449|0   |1
is obsolete||

--- Comment #41 from Katrin Fischer  ---
Created attachment 149480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149480=edit
Bug 33103: DBIC changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148448|0   |1
is obsolete||

--- Comment #40 from Katrin Fischer  ---
Created attachment 149479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149479=edit
Bug 33103: DB changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/655
  Documentation||Caroline Cyr La Rose
contact||

--- Comment #497 from Caroline Cyr La Rose  
---
I finished documenting this, but I see there are some patches that still need
to be pushed. I hesitate to put it to "RESOLVED", but I don't have many choices
after "Needs documenting" (RESOLVED or CLOSED).

Can someone with more permissions maybe put it back to Passed QA or Signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33466] Link vendor name in list of licenses

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149466|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 149478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149478=edit
Bug 33466: Link to the vendor from the ERM module

There are 3 tables in the ERM module where we display the vendor name
but without a link to the acquisition module.

This patch adds the links.

Test plan:
Create an agreement, a license and a local package.
Pick a vendor and notice that now there is a link on the list view.

Signed-off-by: David Nind 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33466] Link vendor name in list of licenses

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33066] We need a KohaTable Vue component

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066

--- Comment #101 from Katrin Fischer  ---
Fixed by a yarn install before yarn build.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33066] We need a KohaTable Vue component

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066

--- Comment #100 from Katrin Fischer  ---
ERM is totally broken for me :(

I have tried it all: git pull, ktd down, ktd pull, ktd up, etc. But I am still
stuck with that and no table will display:

Source map error: Error: unsupported protocol for sourcemap request
webpack://koha/node_modules/vue-select/dist/vue-select.js.map
Resource URL: webpack://koha/./node_modules/vue-select/dist/vue-select.js?
Source Map URL: vue-select.js.map
[Vue warn]: Unhandled error during execution of render function 
  at <"top
pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons:
Proxy, lengthMenu: (2) […], pageLength: 20, fixedHeader: true, initComplete:
initComplete(settings), deferRender: true, paging: true, serverSide: true, … }
 data= 
Array []
  ... > 
  at  
  at  ref=Ref< 
Proxy { : {…}, : {…} }
 > > 
  at  
  at  runtime-core.esm-bundler.js:167:17
[Vue warn]: Unhandled error during execution of scheduler flush. This is likely
a Vue internals bug. Please open an issue at
https://new-issue.vuejs.org/?repo=vuejs/core 
  at <"top
pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons:
Proxy, lengthMenu: (2) […], pageLength: 20, fixedHeader: true, initComplete:
initComplete(settings), deferRender: true, paging: true, serverSide: true, … }
 data= 
Array []
  ... > 
  at  
  at  ref=Ref< 
Proxy { : {…}, : {…} }
 > > 
  at  
  at  runtime-core.esm-bundler.js:167:17
Uncaught (in promise) TypeError: currentRenderingInstance is null
renderSlot
webpack://koha/../node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3092
render VueJS
renderComponentRoot
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1028
componentUpdateFn
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5730
run
webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225
update
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844
setupRenderEffect
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858
mountComponent
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640
processComponent
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598
patch
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200
componentUpdateFn
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5737
run
webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225
update
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844
setupRenderEffect
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858
mountComponent
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640
processComponent
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598
patch
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200
mountChildren
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384
mountElement
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294
processElement
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277
patch
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197
mountChildren
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384
mountElement
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294
processElement
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277
patch
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197
componentUpdateFn
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5810
run
webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225
update
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844
callWithErrorHandling
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284
flushJobs
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:514
promise callback*queueFlush
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:406
queueJob
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:400
effect
webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5842
triggerEffect
webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:430
triggerEffects

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730

Michael Hafen  changed:

   What|Removed |Added

 Attachment #146039|0   |1
is obsolete||
 Attachment #147982|0   |1
is obsolete||

--- Comment #16 from Michael Hafen  ---
Created attachment 149477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149477=edit
Bug 32730: Add Patron Lists tab to patron details and  circulation pages

[Rebased 2023-04-10]

Test Plan:
1. Apply patch
2. create a patron list if there aren't any
3. search for a patron
4. observe the "Patron lists" tab showing the list that the patron is not in
5. try adding the patron to the list and removing them from the list to
   be sure the feature has full operation
6. click "Check Out" on the side bar menu to navigate to the circulation
   page for this patron
7. observe the "Patron lists" tab, and verify it operates as it did on the
   patron details page

Bug 32730: (follow-up) Minor corrections
   by Owen Leonard

This patch corrects an instance of an incorrect capital letter
("Patron Lists" -> "Patron lists") and makes minor tweaks to
indentation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233

--- Comment #3 from Lucas Gass  ---
Created attachment 149476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149476=edit
Bug 33233: Don't allow disabled attribute to remain when using browser's back
button

To test:
1. Go to OPAC advanced search and do a search using only one of the inputs.
2. Once the search is complete use the browser's back button to return to the
advanced search.
3. Notice the unused inputs are disabled.
4. Apply patch and try again. Now the inputs should not be disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730

Michael Hafen  changed:

   What|Removed |Added

 Blocks||32105


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105
[Bug 32105] Patron lists needs to share to specific people or groups
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105

Michael Hafen  changed:

   What|Removed |Added

 Depends on||32730


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730
[Bug 32730] Add patron lists tab to patron details and circulation pages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105

Michael Hafen  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |michael.ha...@washk12.org
   |ity.org |

--- Comment #3 from Michael Hafen  ---
Created attachment 149475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149475=edit
Bug 32105 - Add Library and Individual sharing modes to  Patron Lists

Test Plan:
1. apply patch, restart Plack, etc.
2. create or select three users, two at the same library and one not.
3. create or select a patron list owned by one of the users at the same
library.
4. edit list and change sharing mode to 'Library and individuals'.
5. login as the other user at the same library and navigate to patron lists.
6. observe that the list is shared.
7. login as the third user and navigate to patron lists.
8. observe that the list is not shared with this user.
9. login as the owner of the list.
10. edit the list and add the third user as an individual.
11. login as the third user and navigate to patron lists.
12. observe that the list is now shared with the third user.
13. login as the owner of the list.
14. edit the list to change the sharing mode to 'Individuals'.
15. login as the second and third users.
16. observe that the list is not shared with the second user, but still is
  with the third user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233

Lucas Gass  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289

--- Comment #5 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Sorry, the test plan is not detailed enough for me - can you please add some
> > more info?
> 
> You need to play with the code, or test a follow-up bug.
> 
> The code I pasted in the commit message is enough to test the change. You
> can pick a place in a Vue component ('script' part),  add the change, hit
> the page when the component is mounted, then confirm that the syspref value
> has been changed in DB.

I only understood half of that, probably because I have not even basic
knowledge of how Vue works. I'll leave this to someone more knowledgeable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||33498


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498
[Bug 33498] Catalog concerns - Lots of whitespace before the notice text
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33498] Catalog concerns - Lots of whitespace before the notice text

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||31028


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalog records
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33498] New: Catalog concerns - Lots of whitespace before the notice text

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498

Bug ID: 33498
   Summary: Catalog concerns - Lots of whitespace before the
notice text
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When viewing the catalog concerns notices in the patron's file, there is a big
whitespace before the text.

To reproduce:
1. Enable CatalogConcerns in system preferences

2. Enter an email address in CatalogerEmails

3. Add a concern on a bibliographic record from the staff interface
   3.1. Search the catalog for a record
   3.2. Click the title to access the details page
   3.3. Click New > New catalog concern
   3.4. Fill out the form
   3.5. Click "Submit"

4. Add an update to the concern
   4.1. Go to Cataloging > Catalog concerns
   4.2. Click "Details" next to the concern
   4.3. Enter some text in the "Update" field
   4.4. Check "Notify"
   4.5. Click "Comment"

5. Resolve the concern
   5.1. Click "Details" again
   5.2. Enter some text in the "Update" field
   5.3. Check "Notify"
   5.4. Click "Resolve"

6. View the notices in the reporter's account
   6.1. At the top right, click your username and choose My account
   6.2. Click "Notices" on the left
   6.3. Click "Catalog concern acknowledgment" (TICKET_ACKNOWLEDGE)
--> Long whitespace followed by the text
   6.4. Close the preview
   6.5. Click "Catalog concern updated" (TICKET_UPDATE)
--> Long whitespace followed by the text
   6.6. Close the preview
   6.7. Click "Catalog concern resolved" (TICKET_RESOLVE)
--> Long whitespace followed by the text

7. Check the notice in the CatalogerEmail inbox
   7.1. Go to the inbox for the email address in CatalogerEmail and view the
"Catalog concern reported" message (TICKET_NOTIFY) (note: in sandbox, check the
"Koha mail log")
   --> Long whitespace followed by text

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672

--- Comment #6 from Katrin Fischer  ---
I think we had talked about this one on the IRC chat. IIRC:

* It was a way to shorten the descriptions, especially for languages where the
words are much longer anyway and My turns into more letters too.
* For German it also removes the problem between formal and informal
translation of you (different words).
* We had agreed that it seemed uncommon given the rest of Koha's interface and
comparing with other applications.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33484] Generalise table saveState for all tables

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484

--- Comment #9 from Katrin Fischer  ---
Hi Emily, thanks for your comments!

I hope I won't get myself into trouble for this... but could it be a flag we
set on the column configuration page?

But that would bring us back to having a different behaviour for column
controlled vs. column uncontrolled tables...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33484] Generalise table saveState for all tables

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Emily Lamancusa  ---
Update: The tables that aren't retaining the save state are generated with the
REST API wrapper from datatables.js, not the KohaTable wrapper from
column_settings.inc. All the tables I've tested that use the KohaTable wrapper
do retain the save state as intended. I think I do need to set this in its
current state to Failed QA for causing a regression on branches.tt, though.

As for the fact that saveState saves pagination and filters, there are
certainly times when that's less desirable, but there are times when it is
desirable too. Part of what spurred me to create bug 33426 was that our
selectors want that behavior on the purchase suggestion table. Also, to be
fair, the same could be said for saving the column configuration - there are
definitely times when staff hide certain columns to make a page print more
nicely, but don't necessarily need that state to persist.

That being said...there are definitely some tables where saving the search
filters is almost never going to be desirable. For example, on holdings_table
in detail.pl, because the search filter on one bib will carry over to a
different bib where that search filter may not even make sense. Not sure what
the right answer is here... Go back to adding saveState only to certain tables
individually, where it's actually needed? Add it globally but make it
configurable (which would add some scope creep)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   5   >