[Koha-bugs] [Bug 33507] EBSCO packages - Dont list already related agreements when adding a new agreement

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33507

--- Comment #2 from Jonathan Druart  ---
Try that:

{ "agreement_packages.package_id": [ {"!=": 1}, {"=": null } ] }

You want to list those that are not linked with the current one but also those
that are not linked with any packages (it's a left join).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33507] EBSCO packages - Dont list already related agreements when adding a new agreement

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33507

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|jonathan.druart+koha@gmail. |pedro.amo...@ptfs-europe.co
   |com |m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33416] Agreements.ts is failing

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416

--- Comment #8 from Jonathan Druart  ---
Yesterday the tests have been moved to t/cypress/integration/ERM

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695

Kevin Carnes  changed:

   What|Removed |Added

 Attachment #149231|0   |1
is obsolete||

--- Comment #8 from Kevin Carnes  ---
Created attachment 149583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149583&action=edit
Bug 31695: Type standard number is missing field ci_raw in field_config.yaml

In Elasticsearch fields config field_config.yaml, default type as a field
'ci_raw'. This is used for exact search.
This field is missing for type  standard number 'stdno'.

Test plan :
1) In the staff interface, go to Administration, and search for SearchEngine
2) Make sure that the SearchEngine preference is set to Elasticsearch and save
3) Return to Administration and select "Search engine configuration"
4) Change the type of "Heading-Main" to "Std. Number" and save
5) Rebuild the index (e.g. "koha-elasticsearch --rebuild -d kohadev")
6) Go to the main staff page and select Authorities
7) Search for a heading (e.g. "A Dual-language book")
=> Result is found with or without patch
8) Click on the sliders and select "is exactly" for the operator and search
=> Result is found only with patch
9) Apply the patch
10) Rebuild the index (e.g. "koha-elasticsearch --rebuild -d kohadev")
11) Click on the sliders and select "is exactly" for the operator and search
=> Result is found only with patch

Signed-off-by: Kevin Carnes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #149443|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  ---
Created attachment 149584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149584&action=edit
Bug 33486: Remove Koha::BackgroundJob::UpdateElasticIndex->process

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #149395|0   |1
is obsolete||
 Attachment #149397|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  ---
Created attachment 149585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149585&action=edit
Bug 33316: Improve display of ES indexer jobs

We don't do a lot of processing to the data, but we can still
make the display a bit nicer, to show how many records were
done, and show the record ids.

To test:
1 - Do some batch modifications on a system running ES
2 - Check background jobs to see ES jobs
3 - Note display
4 - Apply patch
5 - Confirm display is improved

Signed-off-by: David Nind 
Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

--- Comment #18 from Jonathan Druart  ---
Created attachment 149586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149586&action=edit
Bug 33316: (QA follow-up) Add link to record, fix typo and heading

* h2 h2 directly following each other make no sense. Changed to h2 h3
* ids changed to IDs
* Linked the record ID to the catalog entry
  Note: We also have this link in the batch record mod job details

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

--- Comment #19 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #16)
> (In reply to Jonathan Druart from comment #15)
> > Sorry, I don't have time for this now.
> > 
> > Back to PQA, but we should not push as it IMO.
> 
> This is only a display change - can you explain your worries?

Not better than on bug 32594 comment 41.

This is all good now.

Thanks, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23079
 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo)

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32232

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #149335|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  ---
Created attachment 149587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149587&action=edit
Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt

It must be removed, we don't need it since bug 22417

Test plan :
Play with batch record modification and check there is no JS error

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #33 from Jonathan Druart  ---
* We don't need to hide nodes in the template
* The links we display in the template does not work (we do not send the biblio
to the template as we exit early)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33514] New: breaks ISBN search in item search

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514

Bug ID: 33514
   Summary: breaks ISBN search in item search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 23919

Item search is SQL based, not search engine based. When bug 23919 added
SearchWithISSNVariations to item search, it broke all searches, but for one use
case (that was tested): single ISBN, no ISBD punctuation. 

We are exploding the search now with up to 4 forms of ISBN into something like:

isbn like 'isbn1' or isbn like 'isbn2' ...

But: We are not truncating. 

As soon as there is more than one ISBN (this is a repeatable field) or the
library actually follows MARC21 standard adding ISBD punctuation, this fails.
The data in biblioitems.isbn looks like this:

isbn1 ; | isbn2 ; | isbn3.
isbn1.

This also seems to create quite a performance issue on big databases and it
can't be turned off separately from the normal search.

I am not sure what is best, we could do something like this, which will make
the search work again, but I think we also should make it a separate switch:

@@ -1047,7 +1047,12 @@ sub _SearchItems_build_where_fragment {
  if ( 
C4::Context->preference("SearchWithISBNVariations") and $query ) {
  my @isbns = C4::Koha::GetVariationsOfISBN( $query );
  $query = [];
+foreach my $isbn(@isbns) {
+$isbn = "%" . $isbn . "%";
+}


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919
[Bug 23919] Make ISSN searchable with and without hyphen
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||33514


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514
[Bug 33514] breaks ISBN search in item search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33514] breaks ISBN search in item search

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

--- Comment #37 from Katrin Fischer  ---
I am sad to say, but adding this to item search was not a great idea :(

Item search is SQL based, not a search engine, which changes things quite a
bit.

We are exploding the search now with up to 4 forms of ISBN into something like:

isbn like 'isbn1' or isbn like 'isbn2' ...

But: We are not truncating. 

As soon as there is more than one ISBN or ISSN (these are repeatable fields) or
the library actually follows MARC21 standard adding ISBD punctuation, this
fails. We store in biblioitems.isbn like this:

isbn1 ; | isbn2 ; | isbn3.
isbn1.

This also seems to create quite a performance issue on big databases and it
can't be turned off separately from the normal search.

I've filed bug 33514.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33514] SearchWithISSNVariations breaks ISBN search in item search

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514

Katrin Fischer  changed:

   What|Removed |Added

Summary|breaks ISBN search in item  |SearchWithISSNVariations
   |search  |breaks ISBN search in item
   ||search

--- Comment #1 from Katrin Fischer  ---
I should also mention that any truncation entered in the item search is lost
when it's run through the ISBN conversion. So there is no workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514

Katrin Fischer  changed:

   What|Removed |Added

Summary|SearchWithISSNVariations|SearchWithIS[B|S]NVariation
   |breaks ISBN search in item  |s breaks ISBN search in
   |search  |item search

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Expose MARC21 tag 765 - |Show MARC21 tag 765 -
   |Original Language Entry |Original Language Entry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33515] New: XSLT: Use GetCnumSearchURL utility template in other places

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33515

Bug ID: 33515
   Summary: XSLT: Use GetCnumSearchURL utility template in other
places
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Bug 29185 adds this new template (XSLT function) to build a URL for a search on
control number/organization code based on record control number subfields
(often $w) like 765$w.

We could use this logic in few more places in the OPAC/intranet XSLTs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185

--- Comment #1 from Marcel de Rooy  ---
Created attachment 149588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149588&action=edit
Bug 29185: Facilitate searching for cnum

Instead of typing the case sensitive Control-number each time.
4 strikes instead of 15 on your keyboard. Wow! Gain of 73%.

Test plan:
Copy ccl.properties to /etc/koha/zebradb, restart Zebra and
search for cnum=SOME_ID in opac or intranet.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185

--- Comment #2 from Marcel de Rooy  ---
Created attachment 149589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149589&action=edit
Bug 29185: Groundwork: add template GetCnumSearchURL in Utils

Note for QA: Opened bug 33515 to see if we can use this same
function in a few other places too. Would probably reduce code
and increase consistency.

Test plan:
See next patch.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185

--- Comment #3 from Marcel de Rooy  ---
Created attachment 149590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149590&action=edit
Bug 29185: Display MARC tag 765 in OPAC and intranet XSLT

Test plan:

** For OPAC
[1] Pick a biblio record A as original entry, fill $001/$003.
[2] Pick another biblio record B as translation, add 765 with $t,
$a and $d. Put (orgcode)cnum from A into $w.
[3] Disable UseControlNumber.
[4] Goto OPAC detail page of B. Check link; should be title based.
[5] Enable UseControlNumber.
[6] Goto OPAC detail page of B. Check link; should incl orgcode and cnum.
[7] Edit B. Replace $w with cnum of A only.
[8] Goto OPAC detail page of B. Check link; should incl cnum only.

** For staff client
[9] Goto staff detail page of B. Check link again.
[10] Edit B. Set 765 ind2 to 8, fill $i.
[11] Goto staff detail page of B. You should see different label.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #46 from Jonathan Druart  ---
1. Should we restrict access to the whole ERM module is vendor_manage is not
set?
2. I can list agreements even if I have only erm_eholdings. It's confusing as
we don't have access to "Licenses".
3. EBSCO Add to/Remove from holdings buttons should be removed with only
erm_show
4. Same for "Add new agreement" on EBSCO pkg show view
5. I don't get an error when I access /cgi-bin/koha/erm/licenses/edit/1 with
only erm_show (same for agreement)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185

Marcel de Rooy  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Marcel de Rooy  ---
Katrin: Please take a look at the logic in the second patch building a URL for
control-number and corresponding identifier.
Depends on UseControlNumber pref too.
Additionally, it looks at the orgcode if present and narrows the search down to
that orgcode too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||33515


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33515
[Bug 33515] XSLT: Use GetCnumSearchURL utility template in other places
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33515] XSLT: Use GetCnumSearchURL utility template in other places

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33515

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||29185


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185
[Bug 29185] Show MARC21 tag 765 - Original Language Entry
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #47 from Jonathan Druart  ---
Note that you should certain rebase on top of bug 33483, here is how I fixed
the conflict:

130 actions: {
131 0: ["show"],
132 ...((permissions.agreement.write || this.embedded) && {
133 "-1": this.embedded
134 ? [
135   {
136   select: {
137   text: this.$__("Select"),
138   icon: "fa fa-check",
139   },
140   },
141   ]
142 : ["edit", "delete"],
143 }),
144 },

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

--- Comment #48 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #46)
> 5. I don't get an error when I access /cgi-bin/koha/erm/licenses/edit/1 with
> only erm_show (same for agreement)

Not sure we should consider this blocker, does not seem trivial to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

--- Comment #13 from Jonathan Druart  ---
Should not we add the original name in the description, so that the search will
return the new one when then old one is searched for?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418

Paul Derscheid  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418

--- Comment #34 from Paul Derscheid  ---
Created attachment 149591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149591&action=edit
Bug 32418: (follow-up) Remove jQuery, Fix typos in url, add biblio as template
param

To test:
1. Go to any record
2. Hit the edit button on an item in the holdings table
3. Modify the URL so that the query param for the itemnumber is either
3.1 empty:
/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=
3.2 an itemnumber that doesn't exist:
 
/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=99
3.3 whatever else you come up with..
4. Check the same thing for the dupe option (op=dupeitem)
5. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

--- Comment #14 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #13)
> Should not we add the original name in the description, so that the search
> will return the new one when then old one is searched for?

Formerly known as... ? :)

I am not sure to be honest. I hesitate as that will mean that we will probably
never get rid of it and we might end up with a lot of those entries over time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33273] There is no space between the words after ":"

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33273

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #6 from Katrin Fischer  ---
Hi Igor, this looks like a translation issue. Translators have ommitted the
ending space in some (but not all) versions:

https://translate.koha-community.org/fr/translate/#search=ONLINE%20RESOURCES%3A&sfields=source,target&soptions=exact&unit=436557&offset=0

It needs to be fixed on translate.koha-community.org.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33516] New: Accessibility: WCAG 1.4.1 - Content reflow

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33516

Bug ID: 33516
   Summary: Accessibility: WCAG 1.4.1 - Content reflow
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

1.4.10 Reflow: Content can be presented without loss of information or
functionality, and without
requiring scrolling in two dimensions for: (Level AA)
• Vertical scrolling content at a width equivalent to 320 CSS pixels;
• Horizontal scrolling content at a height equivalent to 256 CSS pixels.
Except for parts of the content which require two-dimensional layout for usage
or meaning.

These 2 requirements are to be met simultaneously and are not independent of
each other.
A user should be able to increase the size of text to 200% even when the
information is displayed
on a narrow mobile phone screen.
Alternatively, a user should be able to magnify the screen to 400% and increase
the text size a
further 200%

Users with visual impairments often enlarge web content to make it easier to
see. When content is
enlarged to 400% zoom or viewed on a screen with a width of 320 CSS pixels,
content should be
presented to a user with no loss of information or functionality, and without
requiring scrolling in
two dimensions.
The value of 320 CSS pixels was chosen as a reasonable minimum size that
authors could
achieve and also replicates the smaller screen sizes of common mobile devices.
The width of 320 CSS pixels exactly corresponds to a desktop browser window set
to a width of
1280px and zoomed in to 400%.

FAIL: When the browser window is set to a width of 320px on the homepage, the
horizontal scroll bar is displayed.

FAIL: When the browser window is set to a width of 320px on the ‘Details for:
Biblio title’ page, the horizontal scroll bar is displayed.

Other pages may also be failing on this criteria.. To reach AA standard, we are
required to rework these pages and how they reflow for such zoom levels/screen
sizes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33516] Accessibility: WCAG 1.4.1 - Content reflow

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33516

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33505] Improve styling of scan index page

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Katrin Fischer  ---
I fixed a problem with the dependent bug and forgot to rebase this one on top.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154

Owen Leonard  changed:

   What|Removed |Added

 Attachment #149326|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 149592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149592&action=edit
Bug 33154: Tab WRAPPER follow-up: label text must be translatable

This patch updates templates which have already been updated to use the
new tab WRAPPER system for generating tab markup. Templates are changed
so that tab label strings are wrapped in  to make them
translatable.

The html_helpers include file is also updated so that the example code
in comments shows the right pattern (the breadcrumb example is similarly
corrected).

To test apply the patch and run the translation script to update the .po
files, e.g.

perl misc/translator/translate update fr-FR

Check the updated .po files for some of the lines modified in the patch:

 - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31
 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69
 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330
 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141
 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118
 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259
 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455
 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695

Kevin Carnes  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #149581|0   |1
is obsolete||

--- Comment #11 from ByWater Sandboxes  ---
Created attachment 149593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149593&action=edit
Bug 33260: Move patron search into main body of page

This patch moves the patron search in the Notices management page to the main
body of the page so that the patron search result table displays more nicely.

This is a better place for it anyway, as using this search takes the user to a
different page. In the sidebar, where it was previously, it implied it would
have the same results display as the search filters.

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33517] New: Add support for extended attributes mapping on IdP config

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517

Bug ID: 33517
   Summary: Add support for extended attributes mapping on IdP
config
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #148437|0   |1
is obsolete||

--- Comment #12 from ByWater Sandboxes  ---
Created attachment 149594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149594&action=edit
Bug 33260: Add view_generated_notices user permission

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #148438|0   |1
is obsolete||

--- Comment #13 from ByWater Sandboxes  ---
Created attachment 149595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149595&action=edit
Bug 33260: Add NoticesManagement system preference

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #148439|0   |1
is obsolete||

--- Comment #14 from ByWater Sandboxes  ---
Created attachment 149596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149596&action=edit
Bug 33260: Add a patron getter method to Koha::Notice::Message

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33517] Add support for extended attributes mapping on IdP config

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Depends on||31378


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
[Bug 31378] Add a generic OAuth2/OIDC client implementation
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #149413|0   |1
is obsolete||

--- Comment #15 from ByWater Sandboxes  ---
Created attachment 149597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149597&action=edit
Bug 33260: Add Notice management tool

This enhancement makes it easy for the library to view sent notices and filter
by various search parameters.

You can also print sent notices, individually or in a batch.

This enhancement uses a new system preference NoticesManagement and a new
view_generated_notices user permission.

To test:
1. Apply patches, install database updates, restart services
2. Make sure your logged in user has the view_generated_notices permission
checked
3. Enable the NoticesManagement system preference
4. Generate a few notices. There are a few ways to do this including:
- place holds, check in items and confirm the holds
- place recalls, check in items and confirm the recalls
5. Go to Tools -> Notices management
6. There are two search functions on the left navigation. Confirm the patron
search box works by searching for one of the patrons you generated a notice
for, you should be redirected to their Notice history.
7. Go back to Notices management. Use the set of search filters to search for
notices. Leaving the search filters empty will return all notices generated.
Confirm the filters work as expected by using different combinations of
filters.
8. Conduct a search so your notices show in a table. Confirm the information
fetched about the notices is correct.
9. Click on a notice title. Confirm the contents of the notice show in a pop-up
box.
10. Click one of the Print buttons next to a notice. Confirm the notice is
opened to be printed.
11. Redo your notices search. Confirm the status of the notice you just printed
has now been updated to 'sent'.
12. Use the 'Select all' and 'Clear all' buttons to select or clear the
checkboxes.
13. Select a few checkboxes and click the button at the bottom of the table to
'Print selected notices'. Confirm the notices have been collated into one
document, separated by horizontal lines, and prints successfully. The statuses
for the notices should all be updated to 'sent'.
14. Confirm the Notices management page is not visible without the
view_generated_notices permission
15. Confirm the Notices management page is not visible without the
NoticesManagement system preference being enabled.
16. Go to a patron's Notices history. If the view_generated_notices user
permission is checked for your logged in patron, you should see a Print button
for each notice. Confirm this works. Confirm this button doesn't show if your
logged in patron does not have the view_generated_notices user permission. It
does not require the NoticesManagement system preference.

Sponsored-by: Colorado Library Consortium
Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||33517


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517
[Bug 33517] Add support for extended attributes mapping on IdP config
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #149593|0   |1
is obsolete||

--- Comment #16 from ByWater Sandboxes  ---
Created attachment 149598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149598&action=edit
Bug 33260: Move patron search into main body of page

This patch moves the patron search in the Notices management page to the main
body of the page so that the patron search result table displays more nicely.

This is a better place for it anyway, as using this search takes the user to a
different page. In the sidebar, where it was previously, it implied it would
have the same results display as the search filters.

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #17 from Laura Escamilla  ---
Love the way the new setup looks for the notice management page!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33518] New: Inconsistent breadcrumbs in IdP pages

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33518

Bug ID: 33518
   Summary: Inconsistent breadcrumbs in IdP pages
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

There's no mention to the particular IdP you are editing or you are adding
domains to, so you need to start from scratch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33518] Inconsistent breadcrumbs in IdP pages

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33518

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||31378
 CC||tomasco...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
[Bug 31378] Add a generic OAuth2/OIDC client implementation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||33518


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33518
[Bug 33518] Inconsistent breadcrumbs in IdP pages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11585] pubdate index not working well in UNIMARC

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11585

Anke Bruns  changed:

   What|Removed |Added

 CC||anke.br...@gwdg.de

--- Comment #1 from Anke Bruns  ---
In 22.05, the pubdate index works well if searched for one year only (e.g.
1999).

However, searching for a date range, as suggested in the pulldown menu, doesn't
yield anything at all. Thus, "1999-2002" or "1999 - 2002" return 0 results,
even though there are records with pubdates 1999, 2002 and the years in
between, that can be retrieved by searching for one single year as mentioned
above.

How can this be fixed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33419] Make home library mandatory by default

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419

Laura Escamilla  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #7 from Laura Escamilla  ---
Thank you for taking the time to look at this! You're right, I do need to make
some changes to my Dev environment config. I'll work on that and rebase the
patches. 

We should do the same for the holding library. Do you suggest that we include
this in the same bug or open a new bug for this?

(In reply to Katrin Fischer from comment #6)
> Hi Laura,
> 
> I fully agree with this change. Some small things:
> 
> 1) Please take a look at your dev environment configuration, you probably
> missed setting the variables in .env. The patches were written by:
> From: John Doe 
> 
> 2) Should we not do the same for holding library?
> 
> ... I can't finish here right now because I have some trouble with Selenium
> tonight.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33419] Make home library mandatory by default

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419

--- Comment #8 from Katrin Fischer  ---
I think combining both here would make sense. We can also write up some nice
release notes to highlight the change in one place then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #5 from Owen Leonard  ---
(In reply to Andrew Auld from comment #4)
> Patron details link not working:
> /members/moremember.pl?borrowernumber=#

This looks to me like it is working. Could you re-test?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33519] New: Update description of ILS-DI:AuthorizedIPs

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33519

Bug ID: 33519
   Summary: Update description of ILS-DI:AuthorizedIPs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

After bug 24537, "we can use addresses in a variety of formats [in
ILS-DI:AuthorizedIPs]. This includes 127.0.0.1, 192.168.1.0/24, 10.0.0, and so
on."

It would be nice if this was reflected in the description of the syspref. This
syspref used to take a plain list of IPs, so if you missed it in the release
notes, there is no hint that the functionality has been changed/enhanced.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

--- Comment #14 from Nick Clemens  ---
(In reply to David Nind from comment #13)
> I'm not sure what is required to test this one - apply the patch, and repeat
> the tests for bug 33493 and 33497?

This one shouldn't cause any visible changes to the detail page - best test
plan would be to add items with varying statuses:
lost
damage
withdrawn
in transit
checked out

to a record, and confirm the page looks the same before and after

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Cleanup staff record details page

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

Nick Clemens  changed:

   What|Removed |Added

 Blocks||26802
Summary|Bibs with several hundred   |Cleanup staff record
   |items causes a slow loading |details page
   |screen  |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802
[Bug 26802] Improve speed with records with many items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26802] Improve speed with records with many items

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802

Nick Clemens  changed:

   What|Removed |Added

 Depends on||33167


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167
[Bug 33167] Cleanup staff record details page
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512

he...@bywatersolutions.com changed:

   What|Removed |Added

 CC||he...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

--- Comment #15 from Caroline Cyr La Rose  ---
AFAIK, there is no precedent for this...
gist -> TaxRates, gist is not mentioned in the description
NotesBlacklist -> NotesToHide, no mention
RequestOnOpac -> OPACHoldRequests, no mention

etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32542] Coce images not appearing in staff client

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542

pierre.ge...@biblibre.com changed:

   What|Removed |Added

 CC||pierre.ge...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33520] New: Update Patron Details link alignment

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33520

Bug ID: 33520
   Summary: Update Patron Details link alignment
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andrew.a...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 149599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149599&action=edit
Image showing alignment issue

The link to the 'Patron Details' view in the 'Update Patron Records' page is
out of alignment with the rest of the text on that row and the spacing is off.
/members/members-update.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149275|0   |1
is obsolete||

--- Comment #6 from PTFS Europe Sandboxes  ---
Created attachment 149600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149600&action=edit
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patrons ->
  - Patron details
- Notices
- Accounting
  - Edit patron
  - Add patron
  - Patrons requesting modification (submit patron update via the OPAC)

Signed-off-by: Andrew Auld 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388

Andrew Auld  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from Andrew Auld  ---
This is now signed off.
However I did spot an alignment issue on the Update Patron Records page for
which I have created a new bug number #33520.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388

--- Comment #8 from Andrew Auld  ---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33520

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694

--- Comment #15 from Kevin Carnes  ---
Created attachment 149601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149601&action=edit
Bug 31694: (follow-up) Use values for operations to avoid translation issues

To test:
* Try adding a preset rule that has an operation with different
translations
  for the column and the pull down (e.g. Outrepasser for fr-CA)
* Without the patch it appears as Custom (e.g. Personnalisé)
* With then patch it appears correctly (e.g. Outrepasser)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694

Kevin Carnes  changed:

   What|Removed |Added

 Attachment #149601|0   |1
is obsolete||

--- Comment #16 from Kevin Carnes  ---
Created attachment 149602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149602&action=edit
Bug 31694: (follow-up) Use values for operations to avoid translation issues

To test:
* Try adding a preset rule that has an operation with different
translations
  for the column and the pull down (e.g. Outrepasser for fr-CA)
* Without the patch it appears as Custom (e.g. Personnalisé)
* With the patch it appears correctly (e.g. Outrepasser)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490

--- Comment #8 from Martin Renvoize  ---
Created attachment 149603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149603&action=edit
Bug 33490: Unit tests

This patch adds cypress tests for the filter by expired functionality in
the ERM Agreements page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #149523|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 149604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149604&action=edit
Bug 33490: Prevent 400 on agreements?by_expired=true

We need to update the filter THEN update the current route

Signed-off-by: Pedro Amorim 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149580|0   |1
is obsolete||

--- Comment #2 from PTFS Europe Sandboxes  ---
Created attachment 149605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149605&action=edit
Bug 33512: Change text and add button classes on serial-edit page

To test:
1. Create a subscription
2. Make sure that you choose "Create an item record" when receiving the serial
and associate it with a record.
3. Fill out the numbering pattern stuff and save the subscription.
4. Receive and change the status to arrived. Doing so will make the item
subfields appear for editing.
5. Add some stuff, like a barcode, and Save.
6. Now, if you have made a mistake, you may want to edit the serial/item. Check
the edit box and click 'Edit serials '
7. For your issue that has already arrived click 'Click to add item'. The item
record from before appears.
8. Apply patch.
9. Try 6 & 7 again. The existing items should now read 'Click to edit item'

Signed-off-by: Andrew Auld 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512

Andrew Auld  changed:

   What|Removed |Added

 CC||andrew.a...@ptfs-europe.com
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Andrew Auld  ---
Lovely...much less confusing now. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490

--- Comment #10 from Martin Renvoize  ---
OK, that was a nice distraction for a few hours and I feel like I've wrapped my
brain around Cypress testing much better now.

I've added tests that I believe catch this particular issue, though I'd love a
review if anyone fancies it.

* I test for the existence of the filter options when there are any agreements
in the system.
* I then test for the default date of today being filled after filtering when
the 'Filter by expired' checkbox is checked.
* This tests:
  a) that the xhr includes the correct max_expiration_date
  b) that the window url is updated to reflect the filtering
  c) the input box value is set and displayed
* We then reload the page using the url as defined in step b) above and test
that the xhr and input box value get correctly filled again
* We then add a user selected date in the input box and check
  a) that the xhr includes the new correct max_expiration_date
  b) the window url is updated to reflect the filtering (including the new
date)
  c) the input box value is set and displaying the new date too
* Finally, we reload the page again in b) above and confirm all the changes
stuck.

I added a note that we should also really be testing the other filter too.. but
I felt that was out of scope for this particular patch (and I was running low
on tuits)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490

--- Comment #11 from Martin Renvoize  ---
PS.. I'm happy to PQA on the bug as a whole if someone wants to just
feedback/verify my cypress test addition here is sane.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33521] New: Column item_priority in OPAC holdingst can never show

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33521

Bug ID: 33521
   Summary: Column item_priority in OPAC holdingst can never show
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I was trying to document what all the columns in Administration > Table
settings >  OPAC > holdingst were exactly and I'm having trouble with
item_priority. Katrin looked at the opac-details.tt template and said there was
a logic error.

To test:
1. Change OPACShowHoldQueueDetails to show holds and priority levels
2. Place an item-level hold on an item
3. In the OPAC, log in as the user with the hold
4. Go to the bibliographic record
   --> In the holdings table, there is an "Item holds" column with hold AND
priority information but no Item hold priority column

I wonder if the column is useful at all... I don't mind having both information
in the same column. But I would only show the item holds column if there is an
item-level hold. Right now it shows if there is any hold, even just a
record-level hold, and I find it confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33521] Column item_priority in OPAC holdingst can never show

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33521

--- Comment #1 from Caroline Cyr La Rose  ---
Line

https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L1208

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483

--- Comment #21 from Martin Renvoize  ---
Hmmm.. I'd love to see some tests around this whole area...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33522] New: Optionally skip inactive patrons when sending membership expiry notices

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522

Bug ID: 33522
   Summary: Optionally skip inactive patrons when sending
membership expiry notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Could we use the patron->is_active method here? See bug 33245 (wip).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33522] Optionally skip inactive patrons when sending membership expiry notices

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||33245


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245
[Bug 33245] Add $patron->is_active
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33245] Add $patron->is_active

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||33522


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522
[Bug 33522] Optionally skip inactive patrons when sending membership expiry
notices
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33245] Add $patron->is_active

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 Status|NEW |ASSIGNED

--- Comment #1 from Marcel de Rooy  ---
Still have some code for this in the pipeline. Coming up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992

--- Comment #18 from Emily Lamancusa  
---
It sounds like the plan to (1) respect BlockReturnOfLostItems, (2) ask for
confirmation when recording local use on a lost item if it is not blocked, and
(3) resolve any return claims on the item, addresses all the concerns that have
been raised.

For #2, I feel like it could also make sense to follow the setting for
IssueLostItem instead of requiring confirmation no matter what, but I'm not
sure I have strong reasons for insisting on it if there are
objections/downsides.

Anything else that needs to be resolved before we can move forward with this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33523] New: Hold Queue targets items on record level holds that should not fill the hold

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33523

Bug ID: 33523
   Summary: Hold Queue targets items on record level holds that
should not fill the hold
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Holds queue doesn't check if a branch's item can fill the hold if at least one
item is available on the record for a bib level hold

To recreate: 

• Have ReservesControlBranch set to "item's home library"
• Have at least 2 libraries. 
• Set the circulation rules so that a patron type can place holds on an item
type at library A
• Set the circulation rules so that the same patron type cannot place holds on
or have any checkouts on the same item type at library B
• Make a record with at least 2 items, one at library A and one at library B. 
• Place a bib level hold for a patron matching the patron type in the rules
• Run holds to pull for both branches
• The item should only show on  Library A's list, but it also shows on library
B. 

Library B doesn't allow checkout of those items for that patron type. 

The same thing also happens if there are separate item types on the same
record, such as a public copy and a staff copy. The staff copy will try to fill
the hold even though it can only be held and loaned by staff. 

Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33517] Add support for extended attributes mapping on IdP config

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483

--- Comment #22 from Jonathan Druart  ---
(In reply to Martin Renvoize from comment #21)
> Hmmm.. I'd love to see some tests around this whole area...

See bug 33492.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #12 from Jonathan Druart  ---
I've noticed when reading the tests that something is not totally correct.

+cy.url().should('include',
"/cgi-bin/koha/erm/agreements?by_expired=true"); // Browser url also updated

It should contain max_expiration_date here.

The problem is the following:
Go to /cgi-bin/koha/erm/agreements
Tick "Filter by expired"
Click "Filter"

New route is "/cgi-bin/koha/erm/agreements?by_expired=true"
Input date is filled with today

Click "Filter" again
New route is
"/cgi-bin/koha/erm/agreements?by_expired=true&max_expiration_date=2023-04-13"

The date should be in the URL directly.

Anybody who'd take a look at it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29716] [DOCS] Automated screenshots using Cypress.io testing framework

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29716

Jonathan Druart  changed:

   What|Removed |Added

 CC||aude.charillon@ptfs-europe.
   ||com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >