[Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762
--- Comment #11 from quickfir...@gmail.com ---
(In reply to quickfire28 from comment #8)
> Here is the table that has Duplicate entry
>
> error - {unknown}: dbi exception: dbd::mysql::db do failed: duplicate entry
> '24690' for key 'import_biblios.primary' at
> /usr/share/koha/lib/c4/installer.pm line 739
>
>
> and even the biblios in Reservoir detected as Duplicate entry.
I already fixed this error by accessing the database using HeidiSQl then locate
and clear the import_biblios table.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31118] Allow to send the TOTP token when enabling 2FA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31118 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Yeah, I found it a bit weird that you need an Authenticator app to register but then can use email after that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Fridolin Somers changed: What|Removed |Added Blocks||25812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 [Bug 25812] Fines can be displayed on SIP checkin/checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25812] Fines can be displayed on SIP checkin/checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Depends on||25815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 [Bug 25815] SIP Checkout: add more information on why the patron is blocked -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #13 from Nick Clemens --- (In reply to Janusz Kaczmarek from comment #8) > (In reply to Nick Clemens from comment #7) > > This was "solved" with a hack on bug 31213 > > Nick, I'm aware of your 'hack'--now, I'm unable to verify if quickly, but as > far as I remember it didn't solve this case. If it did, there would be no > point for me to dig into this. Ah, so it doesn't solve this issue because we don't index the a and b together by default. So when you search for: "Will libraries survive? the future of public libraries" The quoted version fails, because no single field contains that string. If you change or add a title index with 245(ab) then the "hack" does work. In fact, it's probably a good idea because any quoted 'full' title search including a subtitle will fail otherwise -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33128] Add Polish translations for language descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Nick Clemens changed: What|Removed |Added Attachment #149781|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 149833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149833=edit Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33128] Add Polish translations for language descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33561] Improve display of location column in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #2 from Lucas Gass --- Created attachment 149832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149832=edit first iteration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33561] Improve display of location column in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #1 from Lucas Gass --- Created attachment 149831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149831=edit Bug 33561: New dispay for location column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33561] New: Improve display of location column in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 Bug ID: 33561 Summary: Improve display of location column in search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com I've been asked to customize the location column in staff search results. I am opening this bug to ideate. At the very least I would like to add more classes to make everything easier to customize. It would also be nice to have a way to only show items from the branch that you are logged in at. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26477] Emaillibrarianwhenholdisplace may be change to specify email as per library choice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26477 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com --- Comment #4 from Lisette Scheer --- It would be great if like ILL staff email it could be set per branch, no matter if it's looking for the pickup branch or the patron's branch. Right now you'd have to change the branch address, but if they don't want to change their branch email for whatever reason it would be great to be able to specify. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Juliet Heltibridle changed: What|Removed |Added CC||jheltibri...@rcplib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Phil Ringnalda changed: What|Removed |Added Attachment #149804|0 |1 is obsolete|| --- Comment #2 from Phil Ringnalda --- Created attachment 149830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149830=edit Bug 33557: Add LinkerConsiderThesaurus system preference Bug 30280 added the ability to use multiple thesauri for authorities in Koha. This is a large change, and many libraries use authorities in a ess strict manner. This patch simply adds a preference, disabled by default, to enable this new feature To test: 1 - Find or create a record with a 650 heading, second indicator 0 (LOC) 2 - Ensure this links to an authority in your system 3 - Disable AutoCreateAuthorities, enable CatalogModuleRelink 4 - Edit the heading to second indicator 2 5 - Save, the heading does not link 6 - Apply patch, updatedatabase, restart all 7 - Edit and save record again 8 - Heading should now link to the LOC authority, despite different second indicator value for source Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #9 from Katrin Fischer --- You always need to build the vue files (yarn build) with every change I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #12 from Janusz Kaczmarek --- (In reply to Katrin Fischer from comment #11) > ? and * are quite common for truncation and databases and the like, people > have been writing tutorials on Elasticsearch etc. like: > https://drive.google.com/file/d/17-YVjG6IJKeDmDCKuF7ZYvcTfzDYyxwa/view > That's also been promoted on the BywaterSolutions blog. > > So next question would be, why * and ? are handled differently... could the > behaviour of Elasticsearch removing the ending ? be changed? The fundamental differences between ? and * are: 1. * very rarely would be present in ordinary users' copy-paste queries, 2. even if, * means '0 or more characters' (like /.*/ in Perl) -- so it would not create problems -- whereas ? means _exactly_ one character (like Perlish /./) -- and therefor is quite problematic in the context we are in. Still, I would not expect from the users of the catalogue the knowledge about quite advanced, wildcarded ES queries... s/he is usually is not interested in what is in the back-end. Hence, I would prefer to prepare Koha to first "understand" a normal user instead of advanced search engines operator. And still, the basic scenario is: the user does copy-paste search and does not get the result -- which for him/her (and therefor for me) is not acceptable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #8 from Katrin Fischer --- (In reply to Caroline Cyr La Rose from comment #7) > Matt pointed me to bug 33355 for my form problems. This one doesn't apply on > top of that. So I can't check if it solves my problem. > > I retested and Yes/No are still in english. (It's not even Yes/Noes, so I > have no idea what I'm doing wrong) I guess it was a little too late again that day - I had changed it to noes to verify I was changing things in the right spot - forgot to change back or to commit the changed file... I won't be able to come back to this maybe for a while, if someone else wants to continue/fix this here please do. (I have no idea how to change to a checkbox either with vue) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #11 from Katrin Fischer --- ? and * are quite common for truncation and databases and the like, people have been writing tutorials on Elasticsearch etc. like: https://drive.google.com/file/d/17-YVjG6IJKeDmDCKuF7ZYvcTfzDYyxwa/view That's also been promoted on the BywaterSolutions blog. So next question would be, why * and ? are handled differently... could the behaviour of Elasticsearch removing the ending ? be changed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #6 from Nick Clemens --- (In reply to Katrin Fischer from comment #3) > I haven't had time to look at the methods at a whole, but do we really want > to remove the checks from IsAvailableForItemLevelRequest? Holdability is determined by calling both routines, and we call 'CanItemBeReserved' first - moving these checks to the start of the routine saves time calculating values that will be ignored later -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32607] Add import sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #9 from Agustín Moyano --- Created attachment 149829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149829=edit Bug 32607: Add CRUD for import sources This patch adds vue components to create, read, update and delete import sources To test: 1. apply patches 2. updatedatabase 3. yarn build_js 4. go to Administration -> Import sources 5. play around with the ui and create, update, remove and search import sources 6. Sign off ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32607] Add import sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #8 from Agustín Moyano --- Created attachment 149828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149828=edit Bug 32607: [DO NOT PUSH] Koha schemas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32607] Add import sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Attachment #146410|0 |1 is obsolete|| Attachment #146411|0 |1 is obsolete|| Attachment #149777|0 |1 is obsolete|| --- Comment #7 from Agustín Moyano --- Created attachment 149827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149827=edit Bug 32607: Add table and permissions Adds a new table called import_sources and a user permission called manage_import_sources -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #8 from Katrin Fischer --- (In reply to Lucas Gass from comment #7) > (In reply to Katrin Fischer from comment #6) > > Hi Lucas, > > > > I just realized that we had the "Click to..." previous to your patches, but > > we should not do that. I've added a small follow-up to remove them. It being > > a link or button already indicates that you can click it, see also > > accessibility guidelines like: > > https://www.mtu.edu/accessibility/training/web/link-text/ > > Hope you agree :) > > > > But: The edit/add text change doesn't work perfectly yet: > > > > To test: > > * Add a new subscription creating items on receive > > * Receive a first issue and create the item > > * From serial collection check both issues and edit > > * The unreceived issue in status "arrived also has "Edit item", but there is > > no item to edit yet > > > > I really like this change, can you please have another look? > > Good catch Katrin. I 100% agree with you. Should we set this back to NSO? > Thanks for the follow-up! I couldn't fix the second issue - so we will still need a follow up or maybe change to "Add/edit item" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #43 from Katrin Fischer --- Thank you Frank. Note for QA: Please add sign-off lines! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #10 from Janusz Kaczmarek --- (In reply to Katrin Fischer from comment #9) > (In reply to Janusz Kaczmarek from comment #8) > > (In reply to Nick Clemens from comment #7) > > > This was "solved" with a hack on bug 31213 > > > > > > If I understand what this patch is doing, you are escaping the question > > > mark > > > so it no longer operates as a special character? > > > > > > This is not a bad idea, however, it needs to be documented with a comment > > > in > > > the code, as well as in the system preference. I think it would actually > > > be > > > better as its own system preference. > > > > Nick, I'm aware of your 'hack'--now, I'm unable to verify if quickly, but as > > far as I remember it didn't solve this case. If it did, there would be no > > point for me to dig into this. > > > > If I remember well, the patch intends to treat the question mark, in the > > function _query_regex_escape_process, in exactly the same way as it is done > > with slash: instead of escaping/unescaping only '/': (?=/) it escapes also > > '?': (?=[/\?]). Maybe I could extend the existing comment, but I don't feel > > like this is a candidate for a new syspref...? > > I think it would be nice if we could keep the truncation feature without > requiring to escape it. It's easy to explain to people to use ?, but much > harder to explain \? - also quite a change in behavior at this point maybe? > > I was wondering, if ? replaces one or more characters... why does it not > work as a wild card if there really is a question mark? Well, IMHO it will be not so easy to explain to an ordinary user (who usually will not read complicated introductory texts, and what we are discussing is a very special case) how '?' functions with ES. Moreover, I expect that an ordinary user will rather use '?' as a verbatim '?' (from copy-paste) than as a wildcard. So, I expect (and have already experienced) alarms from the users who are not able to find a book (with a title containing '?', copied from other data source) in the local catalog even if it is there. If I understand well, in query_string ES query, '?' stands for a single character. But, at the same time, after a normal text analysis of a string containing a question mark attached at the end of the word, the '?' character is removed from what is stored in the index. So, the query 'are?' will not find an original string 'are?' but it would find for instance 'ares', 'arer', 'area' etc. (Similarly, '/' has a special meaning in ES but at the same time can be put unconsciously by an ordinary user as a part of query string -- and hence, if I get it right, the option QueryRegexEscapeOptions of escaping it.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- @Laura hi, thanks for the signoff :) The "Signed-off-by" line needs to be added to the patch itself and the updated/signed patch needs to be attached to the ticket here. You likely have git bz installed in you test environment or maybe you are using the sandboxes. Here is some documentation about how add a signoff to a patch and how to attach it here. You might want to discuss that with a colleague to find what's the most efficient or simplest workflow for your case. https://wiki.koha-community.org/wiki/Sign_off_on_patches#Method_1:_Using_sandboxes https://wiki.koha-community.org/wiki/Sign_off_on_patches#Method_2%3A_Using_git_bz https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #147526|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 149826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149826=edit Bug 33098: Revert suggestion status when orders are cancelled This enhancement will revert the status of a suggestion from ORDERED to ACCEPTED when an order made from a suggestion is cancelled. To test: 1. Log into the OPAC and go to purchase suggestions 2. Add a new purchase suggestion 3. Log into the staff interface. The suggestion will show on the home page 4. Select the suggestion and mark it as Accepted 5. Go to Acquisitions. Find or create a basket 6. Add an order to the basket from a suggestion 7. You'll be redirected to the suggestions page. Click the order button next to your suggestion 8. Fill out the order details as normal and confirm the order. 9. In a new tab, go to the suggestions management page and confirm the suggestion now shows as ORDERED. 10. In the other tab with your basket, cancel the order you just made from the suggestion. 11. Refresh the suggestions management tab. Confirm the suggestion now shows as ACCEPTED. 12. Confirm tests pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Waikato Institute of Technology Signed-off-by: Laura Escamilla Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Patch complexity|--- |Trivial patch Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #1 from Lucas Gass --- Created attachment 149825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149825=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 Owen Leonard changed: What|Removed |Added Blocks||33560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard changed: What|Removed |Added Depends on||32698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 [Bug 32698] Use template wrapper for serials pages tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14210] Manage staged MARC records deletes replaced item when undoing import into catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14210 CB changed: What|Removed |Added CC||balestri...@monterey.org --- Comment #8 from CB --- I agree. It erases data. From an acquisitions standpoint, I need to add the item back on to the Bib record and input the item information again. It seems like the reversion should simply "undo" the process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 --- Comment #1 from Lucas Gass --- Created attachment 149824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149824=edit Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33560] New: Batch edit link broken if subscriptions are selected using "select all" link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Bug ID: 33560 Summary: Batch edit link broken if subscriptions are selected using "select all" link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org When you use the mouse to check checkboxes on the serial search results page, it activates an "Edit selected serials" link which when clicked takes you to the batch edit page. If you use the "Select all" link to check the checkboxes the "Edit selected serials" link is activated but it doesn't work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32745] Background jobs view breaks when there are jobs with context IS NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 Cindy Murdock Ames changed: What|Removed |Added CC||cmurd...@ccfls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Matt Blenkinsop changed: What|Removed |Added Attachment #149778|0 |1 is obsolete|| --- Comment #7 from Matt Blenkinsop --- Created attachment 149823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149823=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Matt Blenkinsop changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Lucas Gass changed: What|Removed |Added Attachment #149805|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 149822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149822=edit Bug 33064: Update cypress tests This patch amends Searchbar_spec.ts to account for the new licenses option Test plan: 1) Run yarn cypress open 2) Select the Searchbar_spec.ts test 3) The test should pass Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Lucas Gass changed: What|Removed |Added Attachment #149803|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 149821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149821=edit Bug 33064: Add a licenses option to the searchbar This patch adds a licenses option to the top searchbar Test plan: 1) Apply patch 2) run yarn build 3) Navigate to the ERM module 4) Observe that the top search bar should have an option for licenses 5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What|Removed |Added Blocks||33559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33559] New: Use template wrapper for breadcrumbs: Serials part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Bug ID: 33559 Summary: Use template wrapper for breadcrumbs: Serials part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more serials templates so that they use the new template wrapper for breadcrumbs. - serials/serials-edit.tt - serials/serials-home.tt - serials/serials-search.tt - serials/subscription-add.tt - serials/subscription-batchedit.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #9 from Jonathan Druart --- Nick answered me, itemlost is passed in $params -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 --- Comment #1 from Owen Leonard --- Created attachment 149820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149820=edit Bug 33558: Use template wrapper for breadcrumbs: Serials part 1 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Claims - Claims for a vendor - Check expiration - Subscription details -> - Serial collection - Create routing list - Edit routing list - Preview routing list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Lucas Gass changed: What|Removed |Added Attachment #149797|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 149819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149819=edit Bug 33555: Use template wrapper for breadcrumbs: Rotating collections This patch updates rotating collections templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Rotating collections - New rotating collection - Edit collection - Delete collection - Manage items - Transfer collection Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #23 from Jonathan Druart --- (In reply to Jonathan Druart from comment #22) > (In reply to Marcel de Rooy from comment #13) > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt > >FAIL valid_template > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: > > DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at > > /usr/share/koha/Koha/Objects.pm line 421 > > > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt > >FAIL valid_template > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: > > DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at > > /usr/share/koha/Koha/Objects.pm line 421 > > Once you run the atomic update this will be fixed. Note that they are still failing with an other error: DBIx::Class::Schema::source(): Can't find source for AdditionalContentsLocalization at /kohadevbox/koha/Koha/Objects.pm line 524 I think it's a false positive, it happens occasionally with valid_template. t/db_dependent/TestBuilder.t is passing so I think we are safe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #22 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #13)
> Looking here.
>
> Rebased conflict with new WRAPPER in
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
Done.
(In reply to Marcel de Rooy from comment #14)
> FAIL Koha/Schema/Result/AdditionalContentsLocalization.pm
>FAIL pod coverage
> POD is missing for koha_object_class
> POD is missing for koha_objects_class
We don't require POD for those subroutines.
> FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>FAIL valid_template
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:
> DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at
> /usr/share/koha/Koha/Objects.pm line 421
>
> FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt
>FAIL valid_template
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:
> DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at
> /usr/share/koha/Koha/Objects.pm line 421
Once you run the atomic update this will be fixed.
(In reply to Marcel de Rooy from comment #15)
> perl installer/data/mysql/updatedatabase.pl
> DEV atomic update
> /usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl [13:36:56]:
> Bug 31383 - Split the additional_contents table
> Renamed additional_contents.idnew with 'id'
> Added new table 'additional_contents_localizations'
> Removed 'title', 'content', 'lang' columns from additional_contents
> ERROR - {UNKNOWN}: Not a HASH reference at
> /usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl line 71. at
> /usr/share/koha/C4/Installer.pm line 743
Fixed, sorry about that!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #21 from Jonathan Druart --- Created attachment 149818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149818=edit Bug 31383: Restore updated_on for individual content Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #20 from Jonathan Druart --- Created attachment 149817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149817=edit Bug 31383: DBIC specific Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #19 from Jonathan Druart --- Created attachment 149816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149816=edit Bug 31383: DBIC changes Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #18 from Jonathan Druart --- Created attachment 149815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149815=edit Bug 31383: DB changes Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #17 from Jonathan Druart --- Created attachment 149814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149814=edit Bug 31383: Adjust and add tests Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Attachment #147891|0 |1 is obsolete|| Attachment #147892|0 |1 is obsolete|| Attachment #147893|0 |1 is obsolete|| Attachment #147894|0 |1 is obsolete|| Attachment #147895|0 |1 is obsolete|| Attachment #147896|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 149813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149813=edit Bug 31383: Create a parent-child DB relation for additional content In the design of additional contents the idea of a parent-child relation is implicitly present. You have a default page and translations. But we do this in one table coming from the old news items. Several reports show that we would be better off creating a parent table listing the main news items, CMS pages or HTML content. And a child table containing the title, content and lang. Note that this first step is a prelimenary step to clean this area and make it more robust and extensible. More enhancements to come. What is this patchset doing? * DB changes - Rename additional_contents.idnew with id - Create a new table additional_contents_localizations(id, additional_content_id, title, content, lang) that will contain the translated contents - Move the content to this new table - Remove title, content and lang columns from additional_contents - Replace the notice templates that are using ''" (should only be ISSUESLIP) and remove support for this syntax. Also add a warning in case other occurrences of uses of the old syntax exist. * CRUD - We add a new Koha::AdditionalContentsLocalization[s] couple, and move some logic from Koha::AdditionalContent[s] to there. Note that, to prevent too much drastic changes in notice templates, and to make them easy to use, the different attributes of the content object is accessible from the translated content object (ie. Koha::AdditionalContentsLocatlization->library is available and return $self->additional_content->library). I think it's an elegant way to keep things simple. - No changes expected for "NewsLog" logging - Little behaviour changes for pages, see tools/page.pl changes. We are now passing the id of the content, and the desired language, instead of the mix of "page_id" or code and lang. Note that here we certainly need to rename "language" query param to not change the full interface language. Test plan: 0. Preparation steps, use master a. Create notice templates that are using "<< additional_contents.code >>". This won't be replaced, but we want the update process to alert us. b. Create several news, additional contents, pages. Some with translated contents, some without. c. Make sure ISSUESLIP has the "" section. If you are using the sample data there is nothing to do here d. Turn on NewsLogs 1. Apply the patches, restart_all, updatedatabase => Confirm that the new table is created and filled with the contents you had prior to the update => Confirm that additional_contents_localizations.updated_on has been kept to the previous values => Confirm that ISSUESLIP has been replaced properly => Confirm that you get a warning about the additional_contents 2. Create, update, delete news, html customs, pages => Confirm that the additional_contents_localizations.updated_on is only adjusted when required => Confirm that the logs are correctly created when NewsLogs is on 3. Check some items out, generate a slip => Confirm that the news are displayed at the bottom of the slip, and that the publication date is correctly formatted 4. Have several HTML customizations (like OpacNav, opacheader), in translated in different languages => Confirm that the default values is displayed when you are using the interface in a language without translation => Confirm that the translated version is picked when it exists Notes for QA: * I am not sure we really need the alert during the update DB process about the additional_contents leftover. We should not have them outside of ISSUESLIP. Shouldn't it hurt? * There is something ugly in sample_news.yml, the id is hardcoded. But how do we prevent that and keep translatability? Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29393] Ability to send emails from patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #27 from Julian Maurice --- Created attachment 149812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149812=edit Bug 29393: Prevent SQL errors when SQL strict mode is set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33484] Generalise table saveState for all tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Emily Lamancusa changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #42 from Frank Hansen --- (In reply to Nick Clemens from comment #41) > (In reply to Frank Hansen from comment #40) > > (In reply to Katrin Fischer from comment #39) > > > Can someone help to get this tested? > > > > I have now tested the patch on my testing docker. I get different results > > depending on whether I choose the ES or the Zebra engine. I am following the > > test plan in comment #17 > > > > ES works flawlessly. All headings are linked after the patch is applied. > > > > But when doing the same using Zebra, without the patch installed only field > > 100 is linked. After applying the patch and restarted not all headings are > > linked. Only > > field 100, 655 (Literature English), 700 and 830 fields are linked after > > saving the record again. > > > > Have I missed something. > > The test plan is missing the steps for Zebra as the index files need to be > copied and then a full reindex: > sudo cp > /kohadevbox/koha/etc/zebradb/marc_defs/marc21/authorities/authority-zebra- > indexdefs.xsl > /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl > restart_all > sudo koha-rebuild-zebra -v -f kohadev Yes! It works for me. I'm signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497
--- Comment #8 from Jonathan Druart ---
+my $items = $biblio->items({ host_items => 1 })->search_ordered( $params, {
prefetch => ['issue','branchtransfers'] } );
[...]
+$dat->{'count'} = $biblio->items({ host_items => 1 })->count;
+$dat->{'showncount'} = $items->count;
Are not we going to always get count == showncount?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #5 from Andrew Auld --- Created attachment 149811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149811=edit View report breadcrumb error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #4 from Andrew Auld --- Created attachment 149810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149810=edit Run report breadcrumb error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #3 from Andrew Auld --- Created attachment 149809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149809=edit Edit report breadcrumb error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Andrew Auld changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||andrew.a...@ptfs-europe.com --- Comment #2 from Andrew Auld --- Hi Owen, I have found a couple of issues with this patch. Firstly, I can't test the 'Items with no checkouts' results page as I am getting an error on the sandbox when I hit 'Submit': CGI::Compile::ROOT::kohadevbox_koha_reports_catalogue_out_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: 'koha_bugs.items.barcode' isn't in GROUP BY at /kohadevbox/koha/reports/catalogue_out.pl line 51 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Secondly, under saved reports and in the guided reports wizard area, there are a number of pages where the breadcrumb doesn't show as it should I don't think. I have attached a number of screenshots to show what I mean. Steps 1 through 6 of the wizard are all fine. I think it is the 'edit report' screen, the 'run report' screen and the 'view report' screen that are not quite right. All other parts of the test plan work fine. I hope this is helpful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #15 from Marcel de Rooy ---
perl installer/data/mysql/updatedatabase.pl
DEV atomic update
/usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl [13:36:56]: Bug
31383 - Split the additional_contents table
Renamed additional_contents.idnew with 'id'
Added new table 'additional_contents_localizations'
Removed 'title', 'content', 'lang' columns from additional_contents
ERROR - {UNKNOWN}: Not a HASH reference at
/usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl line 71. at
/usr/share/koha/C4/Installer.pm line 743
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 Andrew Auld changed: What|Removed |Added CC||andrew.a...@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld --- Nice one, looks great! All works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #149789|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 149808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149808=edit Bug 33439: Use template wrapper for breadcrumbs: Reports part 4 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Reports home - Orders by fund - Results - Holds statistics wizard - Results - Serials statistics wizard - Results Signed-off-by: Andrew Auld -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33167] Cleanup staff record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167
--- Comment #20 from Nick Clemens ---
(In reply to Jonathan Druart from comment #19)
> item.object.itemnotes.replace('\n','')
>
> Is this replace relevant? How do we test it?
1. Enter an itemnote note longer than 100 characters
2. Save the item
3. Edit the item, note field should now be a text area
4. Enter:
a
b
c
d
5. Save the item
6. View details page
7. Confirm line breaks are preserved
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550
Marius changed:
What|Removed |Added
Attachment #149780|0 |1
is obsolete||
--- Comment #2 from Marius ---
Created attachment 149807
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149807=edit
Bug 33550: Rename Patron restrictions administration page to Patron restriction
types
This patch renames 'Patron restriction' to 'Patron restriction type' in the
context of custom restriction type administration.
To test:
0. Apply patch
1. Enable PatronRestrictionTypes
2. Go to Administration
3. Check the name, spelling/grammar of the following elements
* Section name
* Section caption
4. Click 'Patron restriction types'
5. Check the name, spelling/grammar of the following elements
* Title of the page (in the browser tab)
* Breadcrumb
* Left hand side menu
* 'New' button
* Page heading
6. Click 'New restriction type'
7. Check the name, spelling/grammar of the following elements
* Title of the page (in the browser tab)
* Breadcrumb
* Page heading
8. Fill out the form and click 'Save' to create a new restriction type
* Dialog message ('Restriction type added')
9. Click 'New restriction type'
10. Enter the same code as last time
* Warning ('Restriction type code is already in use')
11. Click 'Cancel'
12. Click 'Edit' next to one of the types
13. Check the name, spelling/grammar of the following elements
* Title of the page (in the browser tab)
* Breadcrumb
* Page heading
14. Without changing anything, click 'Save'
* Warning ('Restriction type label is already in use')
15. Change the label and click 'Save'
* Dialog message ('Restriction type updated')
16. Click 'Delete' next to one of the types
17. Check the name, spelling/grammar of the following elements
* Title of the page (in the browser tab)
* Breadcrumb
* Page heading
* Delete button
18. Click 'Delete this restriction type'
* Dialog message ('Restriction type deleted')
Signed-off-by: Marius Mandrescu
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Marius changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #14 from Marcel de Rooy --- FAIL Koha/Schema/Result/AdditionalContentsLocalization.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL valid_template DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at /usr/share/koha/Koha/Objects.pm line 421 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt FAIL valid_template DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at /usr/share/koha/Koha/Objects.pm line 421 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Andrew Auld changed: What|Removed |Added CC||andrew.a...@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld --- Great job Owen, it all looks fine to me! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #13 from Marcel de Rooy --- Looking here. Rebased conflict with new WRAPPER in koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #149768|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 149806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149806=edit Bug 33438: Use template wrapper for breadcrumbs: Reports part 3 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Average loan time - Results - Circulation statistics - Results - Lost items - Results - Catalog by item type - Results Signed-off-by: Andrew Auld -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Matt Blenkinsop changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europe ||.com Status|NEW |Needs Signoff Assignee|jonathan.druart+koha@gmail. |matt.blenkinsop@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 --- Comment #2 from Matt Blenkinsop --- Created attachment 149805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149805=edit Bug 33064: Update cypress tests This patch amends Searchbar_spec.ts to account for the new licenses option Test plan: 1) Run yarn cypress open 2) Select the Searchbar_spec.ts test 3) The test should pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31925 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31925] AutoCreateAuthorities needs to preserve subject heading thesaurus to not create duplicate authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33557 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 --- Comment #1 from Nick Clemens --- Created attachment 149804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149804=edit Bug 33557: Add LinkerConsiderThesaurus system preference Bug 30280 added the ability to use multiple thesauri for authorities in Koha. This is a large change, and many libraries use authorities in a ess strict manner. This patch simply adds a preference, disabled by default, to enable this new feature To test: 1 - Find or create a record with a 650 heading, second indicator 0 (LOC) 2 - Ensure this links to an authority in your system 3 - Disable AutoCreateAuthorities, enable CatalogModuleRelink 4 - Edit the heading to second indicator 2 5 - Save, the heading does not link 6 - Apply patch, updatedatabase, restart all 7 - Edit and save record again 8 - Heading should now link to the LOC authority, despite different second indicator value for source -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens changed: What|Removed |Added Blocks||33557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Nick Clemens changed: What|Removed |Added Depends on||33277 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 [Bug 33277] Correctly handle linking subfields with no defined thesaurus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 --- Comment #1 from Matt Blenkinsop --- Created attachment 149803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149803=edit Bug 33064: Add a licenses option to the searchbar This patch adds a licenses option to the top searchbar Test plan: 1) Apply patch 2) run yarn build 3) Navigate to the ERM module 4) Observe that the top search bar should have an option for licenses 5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33167] Cleanup staff record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167
--- Comment #19 from Jonathan Druart ---
item.object.itemnotes.replace('\n','')
Is this replace relevant? How do we test it?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #16 from Julian Maurice --- Thank you Marcel for the QA and the follow-ups :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What|Removed |Added Blocks||33558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33558] New: Use template wrapper for breadcrumbs: Serials part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Bug ID: 33558 Summary: Use template wrapper for breadcrumbs: Serials part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several serials templates so that they use the new template wrapper for breadcrumbs. - serials/checkexpiration.tt - serials/claims.tt - serials/routing-preview.tt - serials/routing.tt - serials/serials-collection.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #15 from Marcel de Rooy --- Created attachment 149802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149802=edit Bug 32484: (QA follow-up) Few typos Test plan: Run git grep "specifique key" Run git grep "the fonction" Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #14 from Marcel de Rooy --- Created attachment 149801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149801=edit Bug 32484: (QA follow-up) Polishing unit test Test plan, removed done_testing. License. Since we are in t/db, good to add transaction, although we currently do not change anything here. But who knows? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #13 from Marcel de Rooy --- Created attachment 149800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149800=edit Bug 32484: (QA follow-up) Fixes to POD Resolve: FAIL Koha/UI/Form/Builder/Biblio.pm FAIL pod coverage POD is missing for build_authorized_values_list POD is missing for create_key Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy changed: What|Removed |Added Attachment #147298|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 149799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149799=edit Bug 32484: Replace DateTime->now by Koha::DateUtils::dt_from_string Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy changed: What|Removed |Added Attachment #144706|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 149798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149798=edit Bug 32484: Enable plugins when UseACQFrameworkForBiblioRecords is set Test plan: 1. Do not apply the patch yet 2. Make sure you have an ACQ biblio framework with some framework plugins enabled. Create it if you don't. 3. Enable UseACQFrameworkForBiblioRecords system preference 4. Create a new acquisition basket. 5. On this new basket, click on "+ Add to basket", then "From a new (empty) record" 6. You should see a simplified MARC editor based on ACQ framework. Confirm that the plugins are not enabled (no visible buttons, nothing happening on focus/blur) 7. Apply patch 8. Repeat step 5 9. You should now see the plugins' buttons (only if you enabled plugins that use the 'click' event) 10. Confirm that the enabled plugins work correctly Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
