[Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718

--- Comment #13 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #12)
> Signed-off-by: Katrin Fischer 

Thx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

Danyon Sewell  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |danyonsew...@catalyst.net.n
   |ity.org |z

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

Danyon Sewell  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

--- Comment #7 from Danyon Sewell  ---
Created attachment 151184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151184&action=edit
Bug 24401: REST API: Check-in

 Updating files to include API endpoints for check-ins

 Test plan:

 1) Apply bug 23336 as there are dependencies in there required for this to
work

 2) Apply this patch

 3) Run unit tests in t/db_dependent/api/v1/checkouts.t

 4) Make POST request to http://yourlibrary/api/v1/checkouts with request body
containing 'item_id' & 'library_id' properties.
- Observe returned data and HTTP code
  - 201 for item checked in
  - 403 for check in not allowed
  - 409 for Item not found
  - 400 for item not checked out

Sponsored-by: Auckland University of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #151183|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #151182|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #151109|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

--- Comment #6 from Alex Buckley  ---
Created attachment 151183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151183&action=edit
Bug 24401: REST API: Checkin unit test fixes

Sponsored-by: Auckland University of Technology

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

--- Comment #5 from Danyon Sewell  ---
Created attachment 151182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151182&action=edit
bug 24401 - REST API: Check-in WIP

Couple minor fixes to swagger.yaml

Sponsored by: Auckland University of Technology

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Attachment #151181|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

--- Comment #4 from Alex Buckley  ---
Created attachment 151181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151181&action=edit
Bug 24401: REST API: Checkin unit test fixes

Sponsored-by: Auckland University of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

--- Comment #17 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #150914|0   |1
is obsolete||

--- Comment #16 from Victor Grousset/tuxayo  ---
Created attachment 151180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151180&action=edit
Bug 26472: Configure Elasticsearch for better alphabetic sorting

This enhancement configures the ICU collation keyword plugin used by
Elasticsearch for sorting to better handle punctuation and whitespace in sort
fields.

Details at:
https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-collation-keyword-field.html

To test:

1. Create three authority records with the following values:

150 $a Science.
150 $a Science $v B.
150 $a Science $v C.

2. Search for your authority records with "Science" in "Heading A-Z" order

The search results will likely be in this order:

1. Science B.
2. Science C.
3. Science.

This is an unexpected order

3. Apply the patch and reindex

sudo koha-elasticsearch --rebuild -r 

4. Search for your authority records again with "Science" in "Heading A-Z"
order

Confirm your search results show in the correct order.

1. Science.
2. Science B.
3. Science C.

Sponsored-by: Education Services Australia SCIS
Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

David Nind  changed:

   What|Removed |Added

 Attachment #150938|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 151179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151179&action=edit
Bug 33686: Correction of existing terms related to 'Script of title'

According to
https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

David Nind  changed:

   What|Removed |Added

 Attachment #150937|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 151178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151178&action=edit
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values

According to
https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30002] Add project-level perltidyrc

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #9 from David Cook  ---
(In reply to Marcel de Rooy from comment #6)
> I am reading:
> When updating existing packaging, the Standards-Version must not be updated
> except after reviewing the changes between the old and the new versions of
> the standards and updating your package if necessary (the Upgrading
> checklist can help with this task).
> 
> Mason, how do/did we implement that review ?

I think this is the checklist to which Marcel was referring: 

https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt

There's about 4,884 words spanning 12 years in-between 3.8.4 and 4.6.2 so I
don't think anyone's fully reviewed it.

Perhaps we don't need to update all the way to 4.6.2 though. Maybe it's worth
finding a middle ground and doing a review between 3.8.4 and there. 

I spent a little bit of time checking backwards from 3.8.4 and we looked
compliant before it, although it's possible that we might not be 100% compliant
going back to the very beginning...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC"

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #63 from David Cook  ---
(In reply to Mengu Yazicioglu from comment #61)
> As you know, if there is a change in database structure, we have to run post
> installation steps from intranet part. Due to row format issues of some
> tables, newly added ERM tables in the post installation steps gave many
> errors saying "Row size too large..."
> 
> In order to finish upgrade we have to click "Try again" button but first
> solve the row format issue. In a new terminal, we have to change row_format
> feature of related tables to DYNAMIC.

Thanks, Mengu. 

I'm a bit surprised that the error would appear when adding new tables, since
they should default to the DYNAMIC format when you're on a newer MySQL/MariaDB
on a newer OS. Maybe something more to look at with your installation...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

David Nind  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #40 from David Nind  ---
Since the Wiki upgrade is completed, I've closed this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

--- Comment #39 from David Nind  ---
Message sent to the general mailing list:
https://lists.katipo.co.nz/pipermail/koha/2023-May/059454.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721

--- Comment #3 from Katrin Fischer  ---
Thanks, Barbara!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #151171|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 151177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151177&action=edit
Bug 33721: Fix display of shipping cost/fund on invoice summary page

When viewing an invoice, the elements in the 'Fund' line were out of order:
'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and
then the show inactive checkbox.

The order should be:
'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox.

This copies the markup that is used when you click on "Receive shipment".
It also changes 'Fund' to 'Shipping fund' to bring the forms even more in line.

To recreate:
1. In acquisitions, create an order and close the basket
2. Click 'Receive shipment' and receive the order
3. Click 'Finish receiving'
   --> The Fund line in invoice.tt is out of order
4. Apply patch
5. Verify the order is now fixed

Signed-off-by: Barbara Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514

--- Comment #2 from Katrin Fischer  ---
I am not sure what the best solution here is:

1) Remove the ISBN handling from item search.
2) Fix it to search for ISBN left and right truncated (%isbn%) 
   a) create a separate system preference to turn it on/off 
   b) leave it at one system preference as it is now that controls catalog and  
  item search

Note: the performance issues I mentioned earlier have been fixed by giving the
databaes more resources.

2a?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

--- Comment #39 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #38)
> (In reply to Katrin Fischer from comment #37)
> > I am sad to say, but adding this to item search was not a great idea :(
> > 
> > Item search is SQL based, not a search engine, which changes things quite a
> > bit.
> > 
> > We are exploding the search now with up to 4 forms of ISBN into something
> > like:
> > 
> > isbn like 'isbn1' or isbn like 'isbn2' ...
> > 
> > But: We are not truncating. 
> > 
> > As soon as there is more than one ISBN or ISSN (these are repeatable fields)
> > or the library actually follows MARC21 standard adding ISBD punctuation,
> > this fails. We store in biblioitems.isbn like this:
> > 
> > isbn1 ; | isbn2 ; | isbn3.
> > isbn1.
> > 
> > This also seems to create quite a performance issue on big databases and it
> > can't be turned off separately from the normal search.
> > 
> > I've filed bug 33514.
> 
> Can you please address bug 33514? In the meanwhile should we remove this?

What do you mean with "address"? It's all explained there as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33732] intranet Holdings Table uses opac item images

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33732

Mark Hofstetter  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33732] New: intranet Holdings Table uses opac item images

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33732

Bug ID: 33732
   Summary: intranet Holdings Table uses opac item images
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@trust-box.at
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

on the detail page in the intranet

cgi-bin/koha/catalogue/detail.pl

in the Holdings Table the image urls for the opac item images are used eg
"opac-tmpl/bootstrap/itemtypeimg/bridge/book.png"

and not the url to the intranet images like everywhere else


I am not sure if this intentional, but I doubt it

thx
Mark

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33658] Capitalization: **To Reproduce**

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150966|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 151176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151176&action=edit
Bug 33658: Fix capitalization 'To Reproduce'

Signed-off-by: Owen Leonard 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33658] Capitalization: **To Reproduce**

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33658] Capitalization: **To Reproduce**

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33731] New: Add hint to audio alert configuration page that for self checkout pages full URLs must be used

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33731

Bug ID: 33731
   Summary: Add hint to audio alert configuration page that for
self checkout pages full URLs must be used
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The self checkout pages implement Audio alerts, but you can't pick a sound from
the list, but have to enter a full URL instead in order to make them work (see
bug 22406). This is not obvious and a little hint would be nice until this can
be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22406] Add ability to play internal sounds in self checkout system

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22406

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
*** Bug 33695 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33695] Audio alerts for self checkout broken

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33695

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Katrin Fischer  ---
It turns out that the audio-alerts for sco only work when you use a full URL.

*** This bug has been marked as a duplicate of bug 22406 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

--- Comment #92 from Katrin Fischer  ---
*** Bug 17867 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #11 from Katrin Fischer  ---
I think this has been resolved by bug 16522 that centralized the 773 display
between detail and result pages using one common template in the Utils file.

*** This bug has been marked as a duplicate of bug 16522 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #3 from Katrin Fischer  ---
Thx, Caroline! Don't forget to assign yourself :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #151030|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 151175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151175&action=edit
Bug 33717: Typo in search_for_data_inconsistencies.pl

This patch corrects a typo in the output of
search_for_data_inconsistencies.pl when a bibliographic record has no
title.

The patch also replaces biblio to bibliographic record in the same
sentence for terminology consistency.

To test:
- Have a bibliographic record without a title
- Run misc/maintenance/search_for_data_inconsistencies.pl
- Read output, make sure the sentence is correct

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
   Severity|enhancement |trivial
   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33714] Enabling advanced editor causes 500 error

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33714

--- Comment #2 from Katrin Fischer  ---
Hm, I realize if it's this bug, it will be neither fixed in 21.05 nor 21.11. 
Can you confirm if you are using MySQL8?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33714] Enabling advanced editor causes 500 error

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33714

--- Comment #1 from Katrin Fischer  ---
Hi, there was a bug fixing a similar issue. Please check your exact version to
see if the fix is already included in your installation or not:

Bug 33375 - Advanced editor crashes when using MySQL 8 due to reserved rank
keyword 
See: Version(s) released in at the top section of the bug

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging editor

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

--- Comment #8 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #7)
> Could this be vug 33375?
Bug 33375.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging editor

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

--- Comment #7 from Katrin Fischer  ---
Could this be vug 33375?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #5 from Katrin Fischer  ---
Filed:
Bug 33730 - Action column should not be sortable

Easy fix, excercising QAM super powers here: PQA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33730

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33730] New: Action column should not be sortable

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33730

Bug ID: 33730
   Summary: Action column should not be sortable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Bug 33463 fixes the Actions column on the plugins table to be not sortable. The
fix used there can be also applied to other tables.

Jonathan suggests this to detect other cases:
git grep 'Actions'|grep -v NoSort 

They might still need some individual attention as some tables are not sortable
at all or sorting for Actions is already suppressed using different methods.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #151066|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 151174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151174&action=edit
Bug 33463: Remove sort for 'Actions' on the plugins table

Test plan:
Go go the plugin admin page
upload a plugin
Notice that the "Actions" column is not longuer sortable

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463

--- Comment #3 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #2)
> Looks like there are much more occurrences.
> 
> git grep 'Actions'|grep -v NoSort 
> 
> We should fix them all.

I have checked a few and I think there is other mark-up there to prevent them
from being sorted sometimes:

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt:  
 Actions
Action column on vendor search is NOT sortable.
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt:Actions
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt:
 Actions
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: 
  Actions
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt:   
Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt:
   Actions
Actions IS sortable.
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt:  
 Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt:  
 Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt:Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt:   
Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt:Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt:  
 Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt:   
Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt:   
   Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt:   
Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:   
Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt:Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt:Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt:Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt: 
  Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt:  
 Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt:   Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt:   
Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:
   Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:   
Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt:  
 Actions
Table is not sortable at all.
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:   
Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt:   
Actions
Table is not sortable at all.
koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt: 
  Actions
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:  
 Actions
Actions is NOT sortable.

I feel this might be a nice excercise for maybe a newbiew/intro session as they
require taking a closer look maybe? I feel we can still push this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246

--- Comment #5 from Katrin Fischer  ---
I like that it's at the beginning of the table, so quite obvious. It's also
only a small change, so we could consider putting it in 22.11 as well.

I imagine maybe having a filter on 'checked out' would be nice that is set by
default and can be unset if needed. Usually the item presented to you should
not be the checked out in this situation.

It could also be nice to have a different background color for the full line as
they can be a little long.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246

--- Comment #4 from Katrin Fischer  ---
Created attachment 151173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151173&action=edit
Bug 33246: Add some space between icon and text when there is only one result

When there is only one result line, the text "Checked out" would
show directly after the icon at the end of the title. This makes sure
there will always be a little space between them.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #151071|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 151172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151172&action=edit
Bug 33246: Show the onloan status on the BarcodeFallbackSearch result

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051

--- Comment #55 from Katrin Fischer  ---
(In reply to Caroline Cyr La Rose from comment #54)
> Can the [% IF savings %] [% savings | $Price with_symbol => 1 %] be used in
> notices? It would be useful to replace
> https://wiki.koha-community.org/wiki/
> Notices_and_Slips_Library#Add_total_value_of_items_borrowed_to_date_on_issue_
> slip

Hi Caroline, I tested in CHECKIN and this works:

[% USE Price %]
[% borrower.get_savings | $Price with_symbol => 1 %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721

--- Comment #1 from Katrin Fischer  ---
Created attachment 151171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151171&action=edit
Bug 33721: Fix display of shipping cost/fund on invoice summary page

When viewing an invoice, the elements in the 'Fund' line were out of order:
'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and
then the show inactive checkbox.

The order should be:
'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox.

This copies the markup that is used when you click on "Receive shipment".
It also changes 'Fund' to 'Shipping fund' to bring the forms even more in line.

To recreate:
1. In acquisitions, create an order and close the basket
2. Click 'Receive shipment' and receive the order
3. Click 'Finish receiving'
   --> The Fund line in invoice.tt is out of order
4. Apply patch
5. Verify the order is now fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor
 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add an API endpoint for |Add an API endpoint for
   |issuing an item to a patron |checking an item out to a
   ||patron

--- Comment #19 from Katrin Fischer  ---
(In reply to Danyon Sewell from comment #18)
> Going to be working on the check-in API endpoint now just in case there is
> already work being done on it, I really should have checked for duplicates
> before working on the checkout one too but oh well.

Duplicates are not always easy to spot especially with different terminology
used (issue/checkout etc.). I hope this fits your needs as well? And welcome,
Danyon :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009

--- Comment #8 from Katrin Fischer  ---
If I remember correctly one of the things that keeps us out of the Debian
repository is our messy copyright statements. It didn't look like an easy fix
at all. I'd go with trusting Mason here. 

Mason, could you give a quick feedback to the questions maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #151110|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 151170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151170&action=edit
Bug 33718: Fix the mock of Koha::Config->get in mock_config

It should not mock calls for other sections than 'config' in
koha-conf.xml.

Test plan:
Without this patch:
[1] Enable AutoLinkBiblios, CatalogModuleRelink and LinkerRelink.
This will trigger a SearchAuthorities call when creating a sample biblio.
Note: SearchAuthorities calls Zconn and gets back information from
a wrong part of koha-conf.xml.
[2] Run t/db_dependent/Koha/Pseudonymization.t
You should see something like:
  {UNKNOWN}: Can't use string ("authorities") as a HASH ref while "strict refs"
in use at /usr/share/koha/C4/Context.pm line 587. at
/usr/share/koha/C4/Biblio.pm line 302

With this patch:
[3] Run t/db_dependent/Koha/Pseudonymization.t. Should pass now.
[4] git grep -l mock_config | xargs -i{} prove {}
Exclude Mocks.pm.

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Nind 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33727] Merge Calendar tests

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #151166|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 151169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151169&action=edit
Bug 33727: Merge both Calendar tests

The old t tests become part of the first subtest.

Test plan:
Run the new t/db_dependent/Calendar.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33727] Merge Calendar tests

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #151165|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 151168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151168&action=edit
Bug 33727: Groundwork for Calendar.t

Update test while removing need for Test::DBIx::Class.

Test plan:
Run t/Calendar.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33727] Merge Calendar tests

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC)

2023-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272

--- Comment #8 from Katrin Fischer  ---
Created attachment 151167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151167&action=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/