[Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
  Change sponsored?|--- |Sponsored
   Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130

--- Comment #2 from Aleisha Amohia  ---
Created attachment 151550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151550=edit
Bug 28130: [WIP] Manage a patron's subscription alerts

Patch in progress

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26611] Required match checks don't work for authority records

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611

--- Comment #1 from Aleisha Amohia  ---
Created attachment 151549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151549=edit
Bug 26611: Make authority record matching use required match checks

This patch fixes record matching for authorities to correctly apply required
match checks.

To test:

1) Create a record matching rule:

Threshold: 100
Record type: Authority record

Match point 1
Search index: subject-topical
Score: 100
Tag: 150
Subfields: a

Match check 1
Both source and target record check fields:
Tag: 040
Subfields: a

This rule says we want to match on the topical term heading, then confirm the
match with 040$a.

2) Create two topical term authority records

Authority 1:
150$a: Test
040$a: A

Authority 2:
150$a: Test
040$a: B

3) Export authority 2 and save

4) Go to Cataloging -> Stage records for import

5) Upload your downloaded authority 2 file. Change the record type to
Authority. Choose your new record matching rule.

6) Stage for import.

7) Confirm that with the record matching rule applied, both authorities 1 and 2
show as possible matches, even though only authority 2 has a matching 040$a.

8) Apply the patch and restart services

9) Change the matching rule to "Do not look for matching records" and apply.
This is to essentially refresh the page.

10) Change the matching rule to your new matching rule and apply. Confirm only
the matching authority 2 shows and is selected.

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26611] Required match checks don't work for authority records

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26611] Required match checks don't work for authority records

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
 CC||alei...@catalyst.net.nz
 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33800] New: Error 500 in issues_stats.pl

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33800

Bug ID: 33800
   Summary: Error 500 in issues_stats.pl
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: eugen...@yahoo.com
QA Contact: testo...@bugs.koha-community.org

We're in Koha 22.11.04 and in "/cgi-bin/koha/reports/borrowers_stats.pl" and
just the default "itemtype" and "issuing library" buttons ticked, cell value =
count total items and output = "to screen into browser". After submitting,
we're getting "Error 500". In the log, we were getting this:
[2023/05/23 10:13:49] [WARN] Argument "2023-05-01" isn't numeric in numeric lt
(<) at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 214.
[2023/05/23 10:13:49] [WARN] Argument "2023-05-31" isn't numeric in numeric lt
(<) at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 214.

This worked in previous Koha ILS version. It seems there is a bug. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

--- Comment #62 from Aleisha Amohia  ---
Created attachment 151548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151548=edit
Bug 33478: Make sure formatting is applied to tables in notices

This fixes the formatting not showing on ACCOUNTS_SUMMARY and also applies
changes to headings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Passed QA

--- Comment #5 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #151492|0   |1
is obsolete||

--- Comment #4 from Victor Grousset/tuxayo  ---
Created attachment 151547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151547=edit
Bug 33362: Allow return claims to be resolved even if the issue has since been
delete from the database

Test Plan:
1) Check out an item
2) Claim return on it, moving it to the old_issues table
3) Delete the old_issue via koha-mysql or Use cleanup_database.pl
4) Attempt to resolve the claim
5) Note the error
6) Apply this patch set
7) Restart all the things!
8) Attempt to resolve the claim
9) No errors!

Signed-off-by: Sam Lau 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677

--- Comment #15 from Victor Zuniga  ---
Hi Jonathan,

I noticed I didn't include the instance name so perhaps that's the reason for
those error messages.

I tried again using the instance name (catalog) at the end of the command and
got the following:

vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ sudo koha-translate
--install es-ES catalog
[sudo] password for vzuniga:
Error: the selected language is not currently available.
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ sudo koha-translate
--update es-ES catalog
Error: the selected language is not currently installed. Try --install.
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ sudo koha-translate
--install es-ES catalog
Error: the selected language is not currently available.
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$


I tried the --update and -- install commands respectively with no success.

How can I add the language package again?

Thanks,

Victor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677

--- Comment #14 from Victor Zuniga  ---
(In reply to Jonathan Druart from comment #13)
> koha-translate has a 'print_installed' routine that is used by the script to
> know if the language is already installed (and block you with the error you
> get).
> 
> It is doing
> 
> print_installed()
> {
> ( ls -1 $KOHA_HOME/$OPAC_TMPL/bootstrap/ ; \ 
> ls -1 $KOHA_HOME/$OPAC_TMPL/prog/ 2> /dev/null ) | \ 
> sort | uniq | \ 
> grep -v -e images -e itemtypeimg -x -e en -e css -e js -e less -e
> lib 
> }
> 
> Can you list the 2 directory and confirm that you have es-ES in there?
> Then call remove and ls again. What's left?


Hi Jonathan,

Here's the output I'm getting:

vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ ls
es-ES
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ cd es-ES/
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog/es-ES$ ls
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog/es-ES$ cd ..
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ rm -rf es-ES/
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ ls
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$


Somehow the only thing left inside the prog folder was an empty es-ES folder.
Per your suggestion, I removed and tried to install the Spanish package again.

Here is the output I am getting:

vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ sudo koha-translate
--install es-ES
[sudo] password for vzuniga:
/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.
/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.
/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.
/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.
/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.
/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.

Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the
unix socket permissions set properly? Is the host reachable?
If you ignore this warning, you will face performance issues
vzuniga@SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$


Victor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33799] Setting hold options in circulation rules

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33799

--- Comment #1 from Christopher Brannon  ---
Obviously, that should be 1, 2 and 3 above!

4) We should be able to set which of the selected choices is default when
placing a hold.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33799] Setting hold options in circulation rules

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33799

Christopher Brannon  changed:

   What|Removed |Added

Summary|Setting default hold type   |Setting hold options in
   ||circulation rules

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33799] New: Setting default hold type

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33799

Bug ID: 33799
   Summary: Setting default hold type
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

With the new grouping option in our holdings, we are now much closer to being
able to place different formats in the same record.  However, we still need a
little work in terms of holds.

I can place different formats in the same record, and I can force the holds to
specific items, but it may not be the format the patron wants.  There are few
modifications I would like to see happen:

1) It would be preferable if in the circulation rules, the OPAC item level hold
dropdown were changed to multiple choice selections, so we can check if we want
to allow any first available, first available in group, or item level, or any
combination.
2) There should be a staff side version of these choices as well.  We should be
able to control the staff's choices as well.
2) We should have the option of pre-selecting an item or not.  There needs to
be a way to make the patron make a selection, rather than once being made for
them.  Particularly if patrons might want to get a first available in a group
rather than a specific item.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33573] Holds cancellation for waiting holds via the API don't generate a cancellation request

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573

Rhonda Kuiper  changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
Added assignee 8-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33798] Vendor details - improve consistency of edit forms and display

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798

David Nind  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33798] New: Vendor details - improve consistency of edit forms and display

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798

Bug ID: 33798
   Summary: Vendor details - improve consistency of edit forms and
display
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: da...@davidnind.com
QA Contact: testo...@bugs.koha-community.org

For vendor details in acquisitions, there are some inconsistencies in the
display of the edit forms and vendor details.

This could do with some tidy ups.

Specific items:

1. Field labels when displaying vendor details - bold and plain text: for some
sections, field labels are in bold, others are just plain text (for example:
'Vendor details' labels are in plain text, for 'Ordering information' they are
bold).

2. Edit form for 'Interface details' missing colons after the labels.

2. Accessibility issues: using the WAVE Evaluation Tool browser extension
(https://wave.webaim.org/), it shows lots of errors and warnings, such as
missing or multiple form labels, and empty buttons and links (some of which may
or may not be valid).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772

--- Comment #6 from Christopher Brannon  ---
I used Jason's CSS and it worked just fine.  Not sure where the problem is
Owen.  Also, I changed the color to black, as the contrast is not as great with
the yellow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #3 from Christopher Brannon  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #5 from Christopher Brannon  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33797] Extra space in supplier.tt

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This removes the space
  release notes||between the field label and
   ||the colon for the notes
   ||field in the interfaces
   ||section for a vendor's
   ||details.

--- Comment #3 from David Nind  ---
Testing notes (using KTD):

1. Add a new vendor:
   1.1 Acquisitions > New vendor
   1.2 Enter name of vendor: My vendor name
   1.3 In the interfaces section, select 'Add another interface'
   1.4 Enter some details:
   - Name: Test bz33797
   - Email: m...@example.com
   - Notes: Some notes!
   1.5 Save the new vendor.
   1.6 Search for vendors with: my
   1.7 In the search results, click 'My vendor name'
   1.8 Note that there is an extra space between Notes and the colon in the
interfaces section.
2. Apply the patch.
3. Refresh the vendor page:
   ==> There is now no space between Notes and the colon in the interface
section

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33797] Extra space in supplier.tt

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797

David Nind  changed:

   What|Removed |Added

 Attachment #151538|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 151546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151546=edit
Bug 33797: Remove extra space

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33797] Extra space in supplier.tt

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33755] Profile used is not saved when importing records

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33755

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29700] Koha performs a second cashup in error when changing registers immediately after cashup

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29700

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #1 from Andrew Fuerste-Henry  ---
Increased the severity of this one as it seems likely to be happening to others
and is hard to identify when encountered in the wild.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

Sam Lau  changed:

   What|Removed |Added

 CC||sama...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #61 from Sam Lau  ---
Everything worked fine for me except for Apply formatting to ACCOUNTS_SUMMARY.
The formatting stayed the same regardless of what was put under the
ACCOUNTS_SUMMARY formatting tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the default
  release notes||value in the database for
   ||the 'Days in advance' field
   ||for patron messaging
   ||preferences so that it
   ||defaults to NULL instead of
   ||0
   ||(borrower_message_preferenc
   ||es table and the
   ||days_in_advance field).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766

David Nind  changed:

   What|Removed |Added

  Text to go in the||This updates the labels for
  release notes||some values so that they
   ||match with the definitions
   ||in UNIMARC Bibliographic
   ||(3rd ed.) Updates, and to
   ||help with translation:
   ||
   ||-
   ||Specific material
   ||designation:
   ||  i- print
   ||(no change in display)
   ||  m-
   ||master -> m- mould
   ||
   ||-
   ||Techniques (drawings,
   ||paintings) 1, 2, and 3:
   ||
   ||crayon -> charcoal
   ||
   ||-
   ||Technique (prints) 1,2, and
   ||3:
   ||  Label for dropdown
   ||list changed to Techniques
   ||(print) 1, 2, and 3
   ||
   ||camaiu -> cameo
   ||  computer
   ||graphics -> infography
   ||
   ||-
   ||Functional designation
   ||
   ||ab- item cover -> ab-
   ||resource cover
   ||  ag- chart
   ||-> ag- diagram

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464

Nick Clemens  changed:

   What|Removed |Added

 Attachment #144608|0   |1
is obsolete||

--- Comment #18 from Nick Clemens  ---
Created attachment 151543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151543=edit
Bug 32464: (follow-up) fix t/db_dependent/Koha/Item.t

Remove useless unit tests with mss arg

Test with :
prove t/db_dependent/Koha/Filter/EmbedItems.t

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464

Nick Clemens  changed:

   What|Removed |Added

 Attachment #144604|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 151542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151542=edit
Bug 32464: Koha::Item->as_marc_field obsolete option mss

Since Bug 28445 the method Koha::Item->as_marc_field has the option mss not
anymore.

This patch removes this in Koha::Filter::MARC::EmbedItems.

Test with :
prove t/db_dependent/Koha/Filter/EmbedItems.t

Signed-off-by: Jonathan Druart 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796

--- Comment #2 from Kyle M Hall  ---
Unit tests are failing, but are so complicated I cannot figure out how to fix
them!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796

--- Comment #1 from Kyle M Hall  ---
Created attachment 151541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151541=edit
Bug 33796: Holds Queue builder should check more than just least cost branch
for TCM

If for some reason all the items from the least cost branch fail ( can't be
transferred, fail the hold policy, non-matching itemtype filter, etc ), Koha
does not check the next cheapest branch, but instead moves onto the "fall back
to basics" code. We should loop over all the branches from least costly to most
costly to find the least costly items that can be used.

Test Plan:
1) Set up TCM so it's cheapest to transport item from A to C than from
   B to C.
2) Place hold for record with items at A and B, for pick at C
3) Disable transfer from A to C
4) Build the holds queue
5) Note the B item was selected over other more costly items, but not
   the less costly A item ( which cannot be transferred ).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33755] Profile used is not saved when importing records

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33755

Lisette Scheer  changed:

   What|Removed |Added

   Severity|trivial |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32767] Trimming of attribute types by wish (if enabled)

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767

Sam Lau  changed:

   What|Removed |Added

 Attachment #145846|0   |1
is obsolete||

--- Comment #3 from Sam Lau  ---
Created attachment 151540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151540=edit
Bug 32767: New feature that trims attributes (if enabled) to avoid duplicates

Added a new "Trim identifier:" checkbox for attribute editor page, that if
enabled, will trim the value from any trailing whitespaces. The use case for
this feature is to avoid unintentionally creating duplicate attribute values
with trailing whitespaces around of it. If this checkbox is grayed for you,
that means that you have some values surrounded with whitespaces, and Koha
can't decide for you which you want to remove and when (because that as well
will lead to creating duplicated entries). So in order to use this feature you
first need to clean up your database from already existing values with trailing
whitespaces.

This SQL query might help you find all untrimmed attributes & borrowers:
```SELECT * FROM borrower_attributes WHERE code=%Attribute Name% AND attribute
REGEXP "^\\s+|\\s+$";```

Steps to reproduce:
1. Go to the attribute editor page. Check if the "Trim identifier:" checkbox is
not grayed. (if it is grayed, it means you have some values surrounded with
whitespaces, in that case you need to fix them manually)
2. Check the checkbox and save settings.
3. Add that attribute for a preferred patron, enter some value with a trailing
whitespaces around of it.
4. Check that the trailing whitespaces were trimmed correctly.

Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32767] Trimming of attribute types by wish (if enabled)

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767

Sam Lau  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791

--- Comment #11 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33787] Remove option to archive system debit types

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33787] Remove option to archive system debit types

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33774] Loading club table in every tab in patron details

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774

--- Comment #8 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33774] Loading club table in every tab in patron details

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 151539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151539=edit
Bug 33791: (QA follow-up) Stick to 'item_id' for the parameter name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33793] Add method to define limited access to run reports

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793

Eileen Chandler  changed:

   What|Removed |Added

 CC||echand...@clamsnet.org

--- Comment #2 from Eileen Chandler  ---
This would be great improvement for our consortium and I would imagine for any
larger library system too.  We want to empower library staff to run reports but
we'd also like our consortium-wide reports to be accessible only to our
consortium/network staff. Consortium wide reports are resource intensive and we
run those in "off" hours.  If library staff had access to a set of reports just
for their location it would be more efficient and effective.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33797] Extra space in supplier.tt

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |tomasco...@gmail.com
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33797] Extra space in supplier.tt

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 151538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151538=edit
Bug 33797: Remove extra space

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33797] New: Extra space in supplier.tt

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797

Bug ID: 33797
   Summary: Extra space in supplier.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|33796   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796
[Bug 33796] Holds Queue builder never looks at any but the least cost branch of
the transport cost matrix
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
 Depends on|33795   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795
[Bug 33795] Holds Queue builder should do cheap checks before expensive checks
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491

--- Comment #28 from Heather  ---
IMO, there really is no way to "misuse" an 035 field--a number in the 035 field
is simply a number that is not the current/valid system control number, but is
a number to be retained.  (Retaining control numbers being a very good idea,
IMO!)  Putting a number that is valid in all the other systems and catalogs in
the universe except for the one that the record is in right now is a perfectly
valid and IMO very good use of the 035.  035s sure can mean, "I'm personally
not currently using this number in 001."

Also, IMO, there is no way to accurately trace source(s) of records. Records
flow through systems, they are shared--that is really the point of cataloging
according to standards, so the records can be shared.  IMO.:)

Figuring out which human or process imported a record into a catalog (the
source of a record) works great for bibs in Koha--I can take a look a bib in
the Advanced Bibliographic Editor and see in the information in the 945 field. 
(e.g., "Connexion Client User"--that's me!)  And there are logs.

If there were an Advanced Authority Editor I would probably be able to see the
source of any authority record in a 945 field, but that's another
bug/development...:)

The MARC21 standard for authority records is that 001/003 work in tandem.  It
works great for bibs.  IMO it should work the same for auts.  The source of a
bib in Koha is in the locally-defined 945 and works great; it should be the
same for auts (and maybe it is?).  If libraries are using the 003 for a source
of a record, that is OK *if* it is functionally paired with the record number
in the 001, but IMO is duplicating information that *should* be present in a
945 (that should be visible.)  (Maybe there is a way to make a 945 visible in
an aut record framework, but I don't see any authority record framework in the
MARC frameworks, but, again, probably another bug!)

I wish this had gone ahead as was signed off in 2021:  if a library wants a
different number in the 001 then the replaced number in the 001 and the
therefore obsolute org code in the 003 is mapped to a $z in the 035, e.g., $z
(ReplacedOrgCode)ReplacedNumber And the source of the record could be, as in
bibs, in a locally-defined 945 field to serve the functionality for libraries
who need the source of the record tracked in the record as is done in bibs.

--h2, who always has *some* sort of cataloging-informed opinion!:)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627

Sam Lau  changed:

   What|Removed |Added

 Attachment #143022|0   |1
is obsolete||

--- Comment #16 from Sam Lau  ---
Created attachment 151537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151537=edit
Bug 31627: (followup) Hide id for HTML messages

Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627

Sam Lau  changed:

   What|Removed |Added

 Attachment #142826|0   |1
is obsolete||

--- Comment #15 from Sam Lau  ---
Created attachment 151536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151536=edit
Bug 31627: Add ability to embed the letter id in outgoing email notices

It can be useful to know exactly what template was used to generate a notice.
To further this end, it would be useful be able to send the letter id as part
of any emails sent out if there is a letter template associated with the
message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Enable SendLetterIdInEmailNotices
4) Generate an email notice like a checkout notice
5) Note your email has the letter id at the bottom!

Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627

Sam Lau  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795

--- Comment #1 from Kyle M Hall  ---
Created attachment 151535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151535=edit
Bug 33795: Holds Queue builder should do cheap checks before expensive checks

The holds queue builder runs many checks in a somewhat arbitrary order. We
should order those checks such that the most expensive checks are at the end
and can be avoided if a faster check fails.

Test Plan:
1) prove t/db_dependent/HoldsQueue.t
2) Apply this patch
3) prove t/db_dependent/HoldsQueue.t
4) Tests still pass!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #3 from Andrew Fuerste-Henry  ---
Don't forget to add these fields to the list of supported values in the syspref
description, please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33021] Show an alert when adding an item on hold to an item bundle

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||33795


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795
[Bug 33795] Holds Queue builder should do cheap checks before expensive checks
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||33796


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796
[Bug 33796] Holds Queue builder never looks at any but the least cost branch of
the transport cost matrix
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more fields simpler

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more fields simpler

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #147963|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 151534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151534=edit
Bug 33170: Refactor MARCItemFieldsToOrder to make adding more fields trivial

There is no need for this code to have a hard coded list of fields directly in
the code.
Any invalid keys would be skipped anyway.
If we refactor this code then adding new fields will be much simpler.

Test Plan:
1) Set up your MARCItemFieldsToOrder, verify everything is working
2) Apply this patch
3) Restart all the things!
4) Verify there has been no change to the MARCItemFieldsToOrder
   functionality

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32992] Move background worker script to misc/workers

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32992

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This enhancement enables|This bugfix enables the use
  release notes|the use of framework|of framework plugins when:
   |plugins when: 
 |-
   |-   |`UseACQFrameworkForBiblioRe
   |`UseACQFrameworkForBiblioRe |cords` is enabled, and
   |cords` is enabled, and
 |-
   |-   |entering catalog details
   |entering catalog details|when adding items to a
   |when adding items to a  |basket from a new (empty)
   |basket from a new (empty)   |record.
   |record. 
   |This requires
   |This requires   |plugins to be enabled for
   |plugins to be enabled for   |fields in the `ACQ`
   |fields in the `ACQ` |framework.
   |framework.  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33796] New: Holds Queue builder never looks at any but the least cost branch of the transport cost matrix

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796

Bug ID: 33796
   Summary: Holds Queue builder never looks at any but the least
cost branch of the transport cost matrix
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If for some reason all the items from the least cost branch fail ( can't be
transferred, fail the hold policy, non-matching itemtype filter, etc ), Koha
does not check the next cheapest branch, but instead moves onto the "fall back
to basics" code. We should loop over all the branches from least costly to most
costly to find the least costly items that can be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||33795


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795
[Bug 33795] Holds Queue builder should do cheap checks before expensive checks
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||33794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794
[Bug 33794] Holds Queue builder skips least cost branch unless target item's
homebranch is patron's homebranch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33795] New: Holds Queue builder should do cheap checks before expensive checks

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795

Bug ID: 33795
   Summary: Holds Queue builder should do cheap checks before
expensive checks
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The holds queue builder runs many checks in a somewhat arbitrary order. We
should order those checks such that the most expensive checks are at the end
and can be avoided if a faster check fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu
   |ity.org |tions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33794] New: Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794

Bug ID: 33794
   Summary: Holds Queue builder skips least cost branch unless
target item's homebranch is patron's homebranch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The line
next if $request->{borrowerbranch} ne $item->{homebranch};
has been in the holds queue builder since the very beginning, with no
explanation.

My justification for this line is that we would prefer to send an item to a
patron whose home library is the same is the item's home library, assuming that
patron will return the item at that library, thus reducing transportation
costs.

I will not argue here if this is a good feature or not. Bug 31557 makes in
configurable, but perhaps it should have an 'off' feature as well. 

This feature does not make sense when using the transport cost matrix. We get
the lowest cost branch, and then if the branches don't match we just move on
the the "fall back to basics code". This line should be removed from the code
section dealing with the transport cost matrix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761

Amanda Campbell  changed:

   What|Removed |Added

 CC||acampb...@hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32765] Transfer is not retried after cancelling hold

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765

Sam Lau  changed:

   What|Removed |Added

 CC||sama...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||29869


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869
[Bug 29869] Add Koha::Hold->fill
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29869] Add Koha::Hold->fill

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||33791


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791
[Bug 33791] $hold->fill does not set itemnumber when checking out without
confirming hold
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33793] Add method to define limited access to run reports

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793

--- Comment #1 from Michelle Spinney  ---
This would be very helpful for consortia. We'd like staff to run specific
reports created for their library. Right now they can run network wide reports
any time which can slow down our system during peak hours.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33793] Add method to define limited access to run reports

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33793] Add method to define limited access to run reports

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33793] New: Add method to define limited access to run reports

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793

Bug ID: 33793
   Summary: Add method to define limited access to run reports
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org

Currently a user with the execute_reports permission can run any report in the
system. A library may wish for a given user to be able run some reports but not
others. It would be great to have a mechanism for allowing limited reports
access.

Maybe something akin to the SubfieldsToAllowForRestrictedEditing preference? We
could create ReportGroupsToAllowForRestrictedExecution, in which one selects
groups of reports. We add a new execute_reports_restricted permission. A user
with that permission can only run reports in the groups specified in the
preference.

Or maybe ditch the system preference and add a "restricted access" flag to each
report?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #151518|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 151531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151531=edit
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect

This preselect cuts off all next available holds that are in reserves,
as well as holds filled by checkout without confirm (see 33791).

Test plan:
Go to reporting. Click Hold statistics.
Verify that Holding library and Home library are not selected.
Test that you can still filter by one of those.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169

--- Comment #13 from Agustín Moyano  ---
(In reply to Jonathan Druart from comment #11)
> There is something broken.
> 
> Uncaught (in promise) Error: Missing required param "license_id"
> 
> To recreate:
> 1. Create a license
> 2. Go to /cgi-bin/koha/erm/licenses
> 3. Click on a license's name

Could no reproduce this bug... could you please try again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #149744|0   |1
is obsolete||

--- Comment #12 from Agustín Moyano  ---
Created attachment 151530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151530=edit
Bug 33169: Build breadcrumbs and left-hand side menu from routes definition

Signed-off-by: Matt Blenkinsop 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #149935|0   |1
is obsolete||

--- Comment #40 from Agustín Moyano  ---
Created attachment 151529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151529=edit
Bug 32932: Update router to use object references - agreements

This patch updates the Vue files for ERM to use router object links rather than
urls - this will make it much simpler to maintain the router if urls need to be
updated. This first patch only updates the files in the agreements section of
ERM as a first step to introduce the topic for discussion.

Test plan:
1) Apply patch
2) Navigate to the Agreements section of ERM and click on different navigation
links/buttons
3) The links/buttons should all work as normal
4) Review the code to see that the component files now refer back to the router
using objects rather than url strings

Signed-off-by: Agustin Moyano 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||Laura.escamilla@bywatersolu
   ||tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit

2023-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #151498|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 151528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151528=edit
Bug 33789: Return issue info. when adding a credit

To test:
1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a
patrons account after being marked as lost.
2. Check an item out to a patron, make sure it has a replacementprice
3. Mark the item as lost.
4. Now check the item in.
5. Go to the patrons account -> transaction tab. You should see 2 accountlines
related to the item.
6. For the account type 'Lost item' you will see issue infomation ( check out
date, due date, checkouted out from, etc )
7. For the account type 'Lost item fee refund' there is no issue information.
8. Apply patch
9. Try 2 - 6 again. This time the 'Lost item fee refund' should include issue
information.

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >