[Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 --- Comment #35 from Fridolin Somers --- Great :D thanks to all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
--- Comment #5 from David Cook ---
If you want to verify the unit test works, you can either run it before
applying the first patch, or you can compromise Koha/Middleware/SetEnv.pm by
adding the following:
$env = {};
right before the final return in the call sub.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33904] 2FA registration fails if library name has non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904 Jonathan Druart changed: What|Removed |Added Attachment #152220|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 David Cook changed: What|Removed |Added Attachment #152229|0 |1 is obsolete|| --- Comment #4 from David Cook --- Created attachment 152230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152230&action=edit Bug 33967: Add unit test to ensure SetEnv doesn't compromise $env This patch includes a unit test which checks the memory address of the $env hashref in middlewares before and after Koha::Middleware::Env is applied. It succeeds when the same $env is maintained before and after this middleware. It fails if the $env has been overwritten with a new hashref (as evidenced by the new memory address for the hash). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 --- Comment #3 from David Cook --- Created attachment 152229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152229&action=edit Bug 33967: Add unit test to ensure SetEnv doesn't compromise $env This patch includes a unit test which checks the memory address of the $env hashref in middlewares before and after Koha::Middleware::Env is applied. It succeeds when the same $env is maintained before and after this middleware. It fails if the $env has been overwritten with a new hashref (as evidenced by the new memory address for the hash). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 --- Comment #3 from David Cook --- (In reply to David Cook from comment #2) > That's my interpretation at a glance. There might be other scenarios to take > into account... Looks like there can be other results like "Barcode not found". Not sure how we'd handle those kinds of things in a translation-friendly way... but maybe I just need to hook into the code and see. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 --- Comment #2 from David Cook --- This one seems a bit intimidating because there are different modes for the inventory and no one uses the inventory tool that much I think. When you provide barcodes, I think that you end up with an output that is either output to screen or to a CSV output. (This type of inventory can be evaluated against only itself or against "results" which are determined based on the other filters?) But if you don't provide a barcode list, then there is an interactive mode based off the "results" of the filters... and this list fetches all matches into a DataTable. I suppose both modes would be amenable to background processing. In terms of database schema, I think we'd need to store the items in the "results" with a column for problems? Maybe a "batch" table would have some reporting columns for barcodes read and items modified. That's my interpretation at a glance. There might be other scenarios to take into account... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- This is on my mind as well. I have a few libraries that have corporate HTTP forward proxies that time out after 60 seconds, which makes the inventory tool very difficult if not impossible to use. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 David Nind changed: What|Removed |Added Attachment #152227|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 152228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152228&action=edit Bug 33967: Fix SetEnv middleware to preserve $env integrity This patch fixes the Koha::Middleware::SetEnv, so that it preserves the referential integrity of the $env hash reference as it passes through the pre-process and post-process stages of middleware wrapped around the core Koha Plack application. Test plan: 0a. Apply the patch 0b. vi /etc/koha/sites/kohadev/koha-conf.xml 0c. Uncomment "koha_trusted_proxies" 0d. Add "172.0.0.0/8" to the end of the "koha_trusted_proxies" 0e. koha-plack --restart kohadev 1. vi /etc/apache2/sites-enabled/kohadev.conf 2. Add the following to the OPAC virtualhost: SetEnv OVERRIDE_SYSPREF_LibraryName "The Best, Truly the Best, Koha Library" RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName The Best\, Truly the Best\, Koha Library" RequestHeader add X-Forwarded-For "192.168.100.100" 3. service apache2 restart 4. tail -f /var/log/koha/kohadev/plack.log 5. Go to http://localhost:8080/ 6. Note that the plack.log lists 192.168.100.100 as the client IP address 7. Note that the title of the OPAC webpage is "The Best, Truly the Best, Koha Library Library catalog" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 --- Comment #13 from David Cook --- (In reply to David Cook from comment #12) > (In reply to Kyle M Hall from comment #11) > > I think we need to implement > > https://metacpan.org/pod/Email::Sender::Transport::SMTP::Persistent and keep > > the instances of it in memory during each call to SendQueuedMessages > > +1 > > Since different libraries can have different SMTP servers, I reckon > SendQueuedMessages should have an empty hashref that gets passed through to > _send_message_by_email. (Looks like _send_message_by_email is only used in > SendQueuedMessages so changes to the arguments should be easy.) > > Then the $stmp_server can be cached in that hashref for the life of > SendQueuedMessages. And that's exactly what you've already done. Just saw the other report heh. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33964] Use Email::Sender::Transport::SMTP::Persistent for sending email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964 --- Comment #3 from David Cook --- Is this still in progress or should it be needs signoff? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33964] Use Email::Sender::Transport::SMTP::Persistent for sending email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 --- Comment #1 from David Cook --- Created attachment 152227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152227&action=edit Bug 33967: Fix SetEnv middleware to preserve $env integrity This patch fixes the Koha::Middleware::SetEnv, so that it preserves the referential integrity of the $env hash reference as it passes through the pre-process and post-process stages of middleware wrapped around the core Koha Plack application. Test plan: 0a. Apply the patch 0b. vi /etc/koha/sites/kohadev/koha-conf.xml 0c. Uncomment "koha_trusted_proxies" 0d. Add "172.0.0.0/8" to the end of the "koha_trusted_proxies" 0e. koha-plack --restart kohadev 1. vi /etc/apache2/sites-enabled/kohadev.conf 2. Add the following to the OPAC virtualhost: SetEnv OVERRIDE_SYSPREF_LibraryName "The Best, Truly the Best, Koha Library" RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName The Best\, Truly the Best\, Koha Library" RequestHeader add X-Forwarded-For "192.168.100.100" 3. service apache2 restart 4. tail -f /var/log/koha/kohadev/plack.log 5. Go to http://localhost:8080/ 6. Note that the plack.log lists 192.168.100.100 as the client IP address 7. Note that the title of the OPAC webpage is "The Best, Truly the Best, Koha Library Library catalog" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 David Cook changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #55 from David Cook --- Boy that was crazy-making but feels good to figure out a tough problem 😅 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30002] Add project-level perltidyrc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #34 from Mason James --- (In reply to Jonathan Druart from comment #23) > (In reply to Julian Maurice from comment #21) > > Also, since it's a developer-only tool, do we need to restrict ourselves to > > an old version ? > > We could package the latest version on CPAN and have it in our repo. > > Mason, would that work for you? sure, i've added the latest perltidy (20230309) to the dev/unstable/master suite in koha-staging repo if it tests ok, ill push it everywhere # apt policy perltidy perltidy: Installed: 20230309-1~koha1 Candidate: 20230309-1~koha1 Version table: *** 20230309-1~koha1 500 500 http://debian.koha-community.org/koha-staging dev/main amd64 Packages 100 /var/lib/dpkg/status 20220613-1 500 500 http://ftp.nz.debian.org/debian sid/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 David Cook changed: What|Removed |Added Blocks||33967 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 David Cook changed: What|Removed |Added Depends on||23068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33967] New: REMOTE_ADDR incorrect in plack.log when run behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967 Bug ID: 33967 Summary: REMOTE_ADDR incorrect in plack.log when run behind a proxy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org As I note in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068#c54 the Koha::Middleware::SetEnv breaks the flow of $env through the Plack middleware wrapper chain. This means that post-processing middleware that happen after Koha::Middleware::SetEnv (e.g. Plack::Middleware::AccessLog) will use the wrong $env variable (ie the $env variable that was being used before Koha::Middleware::SetEnv was run in the pre-process middleware phase). By retaining the original $env hashref in Koha::Middleware::SetEnv, we should be able to preserve the referential integrity. Going to give a patch a go now... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #54 from David Cook --- The problem is Koha::Middleware::SetEnv. It's a fundamentally flawed middleware. The wrapping of middleware works by passing around a hash reference (ie $env), and Koha::Middleware::SetEnv breaks the referential train. It passes a new hashref to Koha::Middleware::RealIP which then passes that new reference to the Koha app. But when the post-processing aspect of the Plack middleware runs, after leaving the Koha::Middleware::SetEnv wrapper, it goes back to Plack::Middleware::Static which has the *original* reference, which undoes the changes of Koha::Middleware::SetEnv wrapper and Koha::Middleware::RealIP. We don't notice this because a lot of our middleware only "pre-process". But Plack::Middleware::AccessLog" is a "post-process" middleware. This should actually be a fairly easy fix, and it'll fix the IP address in plack.log when running behind a reverse proxy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #53 from David Cook ---
(In reply to David Cook from comment #52)
> I can get the client IP via $ENV{REMOTE_ADDR} in Koha as set by
> Koha::Middleware::RealIP, but plack.log is still using the proxy address as
> set by Plack::Middleware::ReverseProxy. (I've confirmed that by hacking on
> Plack::Middleware::ReverseProxy.pm in k-t-d.)
This one is driving me a little crazy...
It looks like /usr/share/perl5/Plack/Runner.pm applies the
Plack::Middleware::AccessLog middleware and that's wrapped around the app
last...
Yet it appears to be getting the REMOTE_ADDR from
Plack::Middleware::ReverseProxy and not Koha::Middleware::RealIP. (If you
remove Plack::Middleware::ReverseProxy then it'll get it from
Koha::Middleware::RealIP.)
But it seems more complicated than that because adding Koha::Middleware::RealIP
*after* Plack::Middleware::ReverseProxy doesn't seem to make a difference which
seems illogical...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #52 from David Cook ---
(In reply to David Cook from comment #50)
> Trying to remember why we needed this since in theory
> Plack::Middleware::ReverseProxy should've handled this...
Ahh I see now. Plack::Middleware::ReverseProxy chooses the last IP in the list
(rather than the first), so if you're using a reverse proxy in front of Koha's
Apache reverse proxy, then you'll get the IP address for that reverse proxy
instead of the client IP address.
I guess I can understand that... since it is the most recent IP address to
connect... and then we use Koha::Middleware::RealIP (inspired by
Plack::Middleware::RealIP) to validate the proxy addresses and get the real
client IP...
--
I can get the client IP via $ENV{REMOTE_ADDR} in Koha as set by
Koha::Middleware::RealIP, but plack.log is still using the proxy address as set
by Plack::Middleware::ReverseProxy. (I've confirmed that by hacking on
Plack::Middleware::ReverseProxy.pm in k-t-d.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33933] Use restrictions appear twice for items on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #5) > Available can be on the shelf... usable in the library, not necessarily for > loan. Mmm that's true and I think that's how we've been using it for years in our libraries. I think the search results say "Available for loan", although I've customized that locally to things like "Available electronically" or "Available for photocopy" depending on the use restriction... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 --- Comment #6 from David Cook --- (In reply to Ray Delahunty from comment #5) > We are testing auto-renewals in 22.11 (preparing to ditch our auto-renewal > workaround which avoided various bugs like 19014 in place since 17.11). We > have the ‘No renewal before’ set to zero and the renewal script running at > 00:15 after the item was late. So far we have found two interesting issues. > One is the renewal handling too soon problem that should be solved if we > could have David Cook’s local customisation. Is the customisation TT code > added to the AUTO_RENEWAL_DGST? The local customisation I'd done was in the code in the automatic_renewals.pl script. However, it hasn't been working correctly in 21.11 and 22.11. I haven't had any complaints about 22.11, so I'm not planning on looking at it again unless I get people complaining about confusion/unexpected behaviours locally. (In reply to Ray Delahunty from comment #5) > Is the customisation TT code > added to the AUTO_RENEWAL_DGST? I don’t want ‘Visual merchandising’ tacked > on as an orphan on this digest: > > There were 1 items that were not renewed. > There were 2 items that were renewed. > Mastering wildlife photography (barcode: 54250053) was not renewed as it is > reserved by another reader. > Cool infographics (barcode 54197511) was renewed until 12/06/2023 > The information design handbook (barcode 54240693) was renewed until > 12/06/2023 > Visual merchandising / : 40620336 It might be that you need to tweak your template as this does look a bit odd. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 --- Comment #12 from David Cook --- (In reply to Kyle M Hall from comment #11) > I think we need to implement > https://metacpan.org/pod/Email::Sender::Transport::SMTP::Persistent and keep > the instances of it in memory during each call to SendQueuedMessages +1 Since different libraries can have different SMTP servers, I reckon SendQueuedMessages should have an empty hashref that gets passed through to _send_message_by_email. (Looks like _send_message_by_email is only used in SendQueuedMessages so changes to the arguments should be easy.) Then the $stmp_server can be cached in that hashref for the life of SendQueuedMessages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30002] Add project-level perltidyrc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #33 from David Cook --- Does anything need to be done for folk who code in koha-testing-docker using vim? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33937] Incorrect export in C4::Members
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33937 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33937] Incorrect export in C4::Members
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33937 Katrin Fischer changed: What|Removed |Added Attachment #152095|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 152226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152226&action=edit Bug 33937: Remove incorrect export in C4::Members Bug 17600 re-add those exports, but the module does no longer have the subroutines. We should remove these export. Test plan: git grep is your friend Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33937] Incorrect export in C4::Members
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33937 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33858] Date for pending offline circulation is unformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33858] Date for pending offline circulation is unformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858 --- Comment #4 from Katrin Fischer --- It works, but I updated it to use with_hours=1 to show the time, but we are still losing the second. Should we worry about that? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33858] Date for pending offline circulation is unformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858 Katrin Fischer changed: What|Removed |Added Attachment #152079|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 152225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152225&action=edit Bug 33858: Format dates in offline circ 1 - check item 30001 out to a patron 2 - upload the attached KOC file from bug 33838 3 - navigate to pending offline circ actions 4 - verify that the date is shown unformatted 5 - apply patch 6 - verify that the date is now shown formatted Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33858] Date for pending offline circulation is unformatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24517] Zebra: date-entered-on-file misses 6th position
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24517 Katrin Fischer changed: What|Removed |Added Attachment #152072|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 152224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152224&action=edit Bug 24517: Add missing 6th position to date-entered-on-file index (XSLT) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24517] Zebra: date-entered-on-file misses 6th position
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24517 Katrin Fischer changed: What|Removed |Added Attachment #152071|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 152223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152223&action=edit Bug 24517: Add missing 6th position to date-entered-on-file index Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24517] Zebra: date-entered-on-file misses 6th position
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24517 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33929] Cannot export genre/form authority framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33929 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal Hardware|PC |All OS|Windows |All Version|22.11 |master --- Comment #1 from Katrin Fischer --- Confirmed in master as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24622] Restrict circulation by price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24622 Katrin Fischer changed: What|Removed |Added Summary|Restrict Circulation by |Restrict circulation by |price |price Version|19.05 |master --- Comment #1 from Katrin Fischer --- Hi Christofer, I don't remember any bug or discussion about a feature like this so far, but I understand where you are coming from. In the circulation module the total replacement price shows in the table of checkouts, maybe some workaround could be built using that and jQuery. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33966] "Update and run SQL" for non-English templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Katrin Fischer changed: What|Removed |Added Depends on||23824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 [Bug 23824] Add a 'Save and run' button to reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer changed: What|Removed |Added Blocks||33966 --- Comment #18 from Katrin Fischer --- Please report new bugs linked to the original one once the bug has been released. Otherwise it's too easy to miss these and we will always need a new bug anyway. Confirmed :( and reported as: Bug 33966 - "Update and run SQL" for non-English templates Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 [Bug 33966] "Update and run SQL" for non-English templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33966] New: "Update and run SQL" for non-English templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Bug ID: 33966 Summary: "Update and run SQL" for non-English templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Bug 23824 unfortunately introduced issues when the "Update and run SQL" button is used in translated templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33965] New: Hide patron accounts that are for admin use only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33965 Bug ID: 33965 Summary: Hide patron accounts that are for admin use only Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com We should have a setting that only superlibrarians can set to hide patron accounts that regular staff should not need to alter. Test accounts, anonymous patron accounts, etc. Superlibrarians would be the only users that could alter accounts marked as such. You should not be able to mark superlibrarian accounts as hidden. Regular staff would be able to see names and card info throughout the system, but they would not be able to view the patron record. They should be shown a screen like "Admin use only." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21833] illrequests.medium is not displayed on ILL request detail page and ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Katrin Fischer changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21833] illrequests.medium is not displayed on ILL request detail page and ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 --- Comment #13 from Katrin Fischer --- Our own backend has quite a bit of code using the medium, but it might date back to the type when it was still used. It would certainly need some work to clean-up. What could a deprecation process look like? How and where do we anounce it and how can we make it the most visible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 --- Comment #5 from Katrin Fischer --- (In reply to David Nind from comment #3) > A nice update! Agreed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 Katrin Fischer changed: What|Removed |Added Attachment #152021|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 15 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15&action=edit Bug 33855: Clean up forms and page sections on 'manage MARC imports' page This patch makes minor changes to the structure of the "Manage MARC imports" page so that sections are more clearly delineated and forms have the correct structure. The patch also shortens the new framework field labels and adds hints for clarification. To test, apply the patch and go to Cataloging -> Stage MARC records for import. - Import a batch of MARC records. - Go to Cataloging -> Manage staged records. - View the batch you just imported. - You should see three sections: - A list of information about the batch - Options for changing the matching rules - Options for setting frameworks during import. - Test that the form for applying different matching rules still works correctly. - Import a batch of records which contains matches (by, for example, exporting MARC records from Koha and then reimporting the same batch) - On the manage page for that batch try changing the matching rule applied, switching between "Do not look for matching records" and a matching rule which will catch the duplicate records. - Test that your records are imported correctly according to the framework settings you select, both for new records and for replaced records. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33868] Upgrade the Multiple Select plugin in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 Katrin Fischer changed: What|Removed |Added Attachment #152020|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 152221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152221&action=edit Bug 33868: Upgrade the Multiple Select plugin in the staff interface This patch upgrades the Multiple Select plugin in the staff interface and adds some minor adjustments to system preferences CSS to accommodate the change. The listing on the about page is updated with current information. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences. - Test some preferences which use the plugin, e.g. - ApplyFrameworkDefaults - CoceProviders - OpacHiddenItemsExceptions - OPACAllowUserToChangeBranch - Confirm that the menus look correct and work correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33868] Upgrade the Multiple Select plugin in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33868] Upgrade the Multiple Select plugin in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33904] 2FA registration fails if library name has non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904 --- Comment #12 from Katrin Fischer --- The perltidy patch does include a fair bit of whitespace changes. We might want to leave it off as Jonathan suggested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33904] 2FA registration fails if library name has non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904 Katrin Fischer changed: What|Removed |Added Attachment #152198|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 152220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152220&action=edit Bug 33904: (follow-up) Perltidy With the recent introduction of a community perltidyrc, I felt it sensible to give the module a tidy with this patch. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33904] 2FA registration fails if library name has non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904 Katrin Fischer changed: What|Removed |Added Attachment #152197|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 152219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152219&action=edit Bug 33904: Fix 2FA registration when library name has non-latin characters If the library name contains non-latin characters, the 2FA registration process will fail with a JS alert coming from a 500 server-side. The problem is that Auth::GoogleAuth is expecting an already UTF8 encoded string. We should set the encoding correctly to make Auth::GoogleAuth deal with the URL escaping internally correctly, then decode on our own (in the REST API controller) Test plan: * Modify your logged in library name and add some non-latin characters (eg. "my ❤ library") * Turn on TwoFactorAuthentication * Go to your account > More > Manage 2FA * Click the enable button => Notice that you see the QR code and that both "issuer" and "key id" entries display the library name correctly. * Test the whole 2FA process, confirm that the library name is correctly displayed on the app you are using. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33904] 2FA registration fails if library name has non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904 Katrin Fischer changed: What|Removed |Added Attachment #152196|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 152218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152218&action=edit Bug 33904: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33904] 2FA registration fails if library name has non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33904] 2FA registration fails if library name has non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33901] Only one issue shown when testing prediction pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Katrin Fischer changed: What|Removed |Added Version|unspecified |master Summary|Only one issue shown in |Only one issue shown when |Test prediction pattern |testing prediction pattern -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33901] Only one issue shown in Test prediction pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 --- Comment #7 from Katrin Fischer --- Much better, thx Caroline for filing and Jonathan for the fix :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33901] Only one issue shown in Test prediction pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901
Katrin Fischer changed:
What|Removed |Added
Attachment #152105|0 |1
is obsolete||
--- Comment #6 from Katrin Fischer ---
Created attachment 152217
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152217&action=edit
Bug 33901: (bug 30718 follow-up) Predition pattern - don't set end date to
today
If the end date is not set we should not set it to today.
On bug 30718 the following change was wrong:
-$enddate = eval { output_pref( { str => $enddate, dateonly => 1, dateformat =>
'iso' } ); };
+$enddate = dt_from_string($enddate)->ymd;
output_pref returns undef if str is empty
After the change we returned today's date.
Test plan:
1. Go to Serials > Manage numbering patterns
2. Click Edit next to one of the existing patterns (e.g. Number)
3. Enter information in the Test prediction pattern section
- Frequency: choose one (e.g. 1/month)
- First issue publication date: enter a date (e.g. 2023-06-01)
- Subscription length: issues + enter a number of issues (e.g. 12)
- Locale: leave empty
- Begins with: enter a number in the X column, e.g. 42
4. Click Test pattern
=> Without this patch only one issue is shown, no matter how many you enter in
Subscription length
=> With this patch applied the end date is not set to today and the
prediction pattern list is correct
Signed-off-by: Caroline Cyr La Rose
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33901] Only one issue shown in Test prediction pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #24 from George Williams (NEKLS) --- Any chance this patch can be applied to 22.11 also? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33901] Only one issue shown in Test prediction pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Katrin Fischer changed: What|Removed |Added Attachment #151984|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 152216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152216&action=edit Bug 33528: Use template wrapper for tabs: Patron details page This patch updates the checkout and patron details templates so that they use the new WRAPPER directive to build tabbed navigation. The markup for the tab navigation and tab panels is moved into its own include file since the templates were duplicating essentially the same code. To fully test you should have patrons with checkouts, fines, holds, recalls, and article requests. Apply the patch and go to the checkout page in the staff interface. With each tab, test as much functionality as you can within that tab. - Checkouts - Holds - Recalls (with UseRecalls enabled) - Claims (with a LOST value defined in ClaimReturnedLostValue) - Restrictions - Article Requests (with ArticleRequests preference enabled) - Clubs (with at least one club defined) - Relatives' checkouts (patron must have a guarantee linked to their account). Perform the same tests on the patron details page. Note that the "Charges" tab is shown on the patron details page but not the checkout page. This is not a change made by this patch. Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 --- Comment #13 from Katrin Fischer --- First time I noticed this: when doing actions on the tabs, the page reloads and you lose your 'active' tab. Maybe we could take a look at this sometime. But this is the same without the patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33894] Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer --- There is a conflict - can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- It looks like this patch breaks the opacSerialDefaultTab functionality. When it's set to subscription, the subscription tab should be active when loading the detail page when a subscription exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30002] Add project-level perltidyrc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #32 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #31) > (In reply to Jonathan Druart from comment #30) > > (In reply to Jonathan Druart from comment #24) > > > Suggestion addition for the wiki at > > > https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy > > > > > > """ > > > The code must be tidy using perltidy and the .perltidyrc file presents at > > > the root of the Koha directory. > > > You must run perltidy on any new perl files added. > > > When you add changes to existing files you should consider setting your > > > code > > > editor accordingly. > > > For vim you can add the following line to you `.vimrc`: `vmap > > > :!perltidy -q` > > > Then switch to visual move (ctrl+v), select a block and press F8. > > > """ > > > > Added to the wiki. > > I added the VSCode counterpart. Updated the general part of the page and Geany. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal --- Comment #18 from Katrin Fischer --- It would be nice to have this reconsidered, but it will only affect new installations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30002] Add project-level perltidyrc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #31 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #30) > (In reply to Jonathan Druart from comment #24) > > Suggestion addition for the wiki at > > https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy > > > > """ > > The code must be tidy using perltidy and the .perltidyrc file presents at > > the root of the Koha directory. > > You must run perltidy on any new perl files added. > > When you add changes to existing files you should consider setting your code > > editor accordingly. > > For vim you can add the following line to you `.vimrc`: `vmap > > :!perltidy -q` > > Then switch to visual move (ctrl+v), select a block and press F8. > > """ > > Added to the wiki. I added the VSCode counterpart. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 152215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152215&action=edit Bug 33960: (QA follow-up) ->delete doesn't send to deletedbiblio Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] self-checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 --- Comment #3 from Dave --- new line delimited list of barcodes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 --- Comment #4 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.07 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33838] Offline circulation interface error on return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 --- Comment #11 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33838] Offline circulation interface error on return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.07 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 --- Comment #6 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.07 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 --- Comment #4 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.07 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 --- Comment #8 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.07 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 --- Comment #6 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.07 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33867] Quantity received should default to number of unreceived items when creating items on cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33867 Bug 33867 depends on bug 33864, which changed state. Bug 33864 Summary: Problems in order receive modal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33863] On receive "change currency" is always checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Bug 33863 depends on bug 33864, which changed state. Bug 33864 Summary: Problems in order receive modal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33864] Problems in order receive modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Matt Blenkinsop changed: What|Removed |Added Resolution|--- |FIXED CC||matt.blenkinsop@ptfs-europe ||.com Status|Pushed to master|RESOLVED --- Comment #28 from Matt Blenkinsop --- Dependencies missing - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Matt Blenkinsop changed: What|Removed |Added Resolution|--- |FIXED CC||matt.blenkinsop@ptfs-europe ||.com Status|Pushed to master|RESOLVED --- Comment #16 from Matt Blenkinsop --- Dependencies missing - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 --- Comment #4 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.07 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #19 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.07 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 --- Comment #7 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
